rte_is_valid_assigned_ether_addr retrun true
if the given ethernet address is valid.
Signed-off-by: Li Han
---
drivers/net/iavf/iavf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index c3aa4cd..18ce809
I was looking for some clarification regarding how rx checksum
flags should be set for tunnel packets having both inner and outer
IP/L4 headers.
Based on comments in rte_mbuf_core.h, it seems to me. that the
inner (encapsulated) IP header checksum status should determine
which of these goes into o
On Mon, Aug 24, 2020 at 10:55 AM Ferruh Yigit wrote:
>
> On 8/24/2020 2:36 PM, Ed Czeck wrote:
> > Replace behavior with RTE_LIBRTE_ARK_MIN_TX_PKTLEN
> > with a default value of 0.
> > Update documentation as needed.
> >
> > Signed-off-by: Ed Czeck
> > ---
> > doc/guides/nics/ark.rst | 1
On Mon, Aug 24, 2020 at 11:09 AM Ferruh Yigit wrote:
>
> On 8/24/2020 3:40 PM, Bruce Richardson wrote:
> > On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote:
> >> On 8/24/2020 2:36 PM, Ed Czeck wrote:
> >>> Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG,
> >>> PMD_
When a device is inserted into an existing BDF slot
that has not been probed, we must overwrite the old
PCI ID with the ID of the new function. Otherwise
we may not probe the function with the correct driver,
if at all.
Signed-off-by: Jim Harris
---
drivers/bus/pci/linux/pci.c | 4 +++-
1 file c
On Thu, 20 Aug 2020 15:23:55 -0700, Narcisa Ana Maria Vasile wrote:
> From: Narcisa Vasile
>
> The Windows NetUIO kernel driver allows the DPDK userspace
> application to directly access the hardware.
>
> Cc: Harini Ramakrishnan
> Cc: Omar Cardona
> Signed-off-by: Narcisa Vasile
> ---
Major
https://bugs.dpdk.org/show_bug.cgi?id=530
Bug ID: 530
Summary: Lack of Support for Inner RSS Header Hashing (Feature
2.21)
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFI
Hi Phil,
Can you please add a statement in release notes indicating that these
APIs are removed.
Thank you,
Honnappa
> -Original Message-
> From: Phil Yang
> Sent: Monday, August 24, 2020 3:41 AM
> To: dev@dpdk.org
> Cc: jer...@marvell.com; d...@linux.vnet.ibm.com; Ajit Khaparde
On Mon, Aug 24, 2020 at 04:45:01PM +0100, Anatoly Burakov wrote:
> Current information regarding hugepage usage is a little out of date.
> Update it to include information on in-memory mode, as well as on
> default mountpoints provided by systemd.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Anatol
On Mon, Aug 24, 2020 at 04:45:00PM +0100, Anatoly Burakov wrote:
> The current instructions are slightly out of date when it comes to
> providing information about setting up the system for using DPDK as
> non-root, so update them.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Anatoly Burakov
> ---
On Fri, Aug 21, 2020 at 10:14:19AM +0100, Burakov, Anatoly wrote:
> On 20-Aug-20 4:43 PM, Bruce Richardson wrote:
> > When binding or unbinding a range of devices, it can be useful to use
> > wildcards to specify the devices rather than repeating the same prefix
> > multiple times. We can use the p
When binding or unbinding a range of devices, it can be useful to use
wildcards to specify the devices rather than repeating the same prefix
multiple times. We can use the python "glob" module to give us this
functionality - at least for PCI devices - by checking /sys for matching
files.
Examples
On Fri, Aug 21, 2020 at 10:17:14AM +0100, Burakov, Anatoly wrote:
> On 20-Aug-20 4:43 PM, Bruce Richardson wrote:
> > When binding or unbinding a range of devices, it can be useful to use
> > wildcards to specify the devices rather than repeating the same prefix
> > multiple times. We can use the p
This guide describes the two stack modes, their tradeoffs, and (via a
reference to the mempool guide) how to enable them.
Signed-off-by: Gage Eads
---
v2: Added commit description
doc/guides/mempool/index.rst | 1 +
doc/guides/mempool/stack.rst | 38 ++
The current instructions are slightly out of date when it comes to
providing information about setting up the system for using DPDK as
non-root, so update them.
Cc: sta...@dpdk.org
Signed-off-by: Anatoly Burakov
---
doc/guides/linux_gsg/enable_func.rst | 54
1 file
Current information regarding hugepage usage is a little out of date.
Update it to include information on in-memory mode, as well as on
default mountpoints provided by systemd.
Cc: sta...@dpdk.org
Signed-off-by: Anatoly Burakov
---
doc/guides/linux_gsg/sys_reqs.rst | 39 +++-
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, August 24, 2020 8:49 PM
> To: Stephen Hemminger ; Hemant Agrawal
> ; Sachin Saxena
> Cc: dev@dpdk.org; Gagandeep Singh ; Akhil Goyal
>
> Subject: Re: [dpdk-dev] Misuses of dev_info->if_index in embedded drivers.
>
> On 8/24/2020
On 8/24/2020 4:07 PM, Stephen Hemminger wrote:
> The use of if_index in some drivers is wrong.
> It does not match the user expectation in the documentation.
>
> This code:
> dpaa2/dpaa2_ethdev.c: dev_info->if_index = priv->hw_id;
> pfe/pfe_ethdev.c: dev_info->if_index = internals->id;
>
On Mon, 24 Aug 2020 13:54:12 +0530
rohit@nxp.com wrote:
> + if (vbus) {
> + if (vbus->close) {
Looks good, minor nit.
This could be:
if (vbus && vbus->close) {
On 8/24/2020 3:40 PM, Bruce Richardson wrote:
> On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote:
>> On 8/24/2020 2:36 PM, Ed Czeck wrote:
>>> Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG,
>>> PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG.
>>> Review and adjust log l
The use of if_index in some drivers is wrong.
It does not match the user expectation in the documentation.
This code:
dpaa2/dpaa2_ethdev.c: dev_info->if_index = priv->hw_id;
pfe/pfe_ethdev.c: dev_info->if_index = internals->id;
Does match:
struct rte_eth_dev_info {
struct rte_devi
On 8/24/2020 2:36 PM, Ed Czeck wrote:
> Replace behavior with RTE_LIBRTE_ARK_MIN_TX_PKTLEN
> with a default value of 0.
> Update documentation as needed.
>
> Signed-off-by: Ed Czeck
> ---
> doc/guides/nics/ark.rst | 13 --
> drivers/net/ark/ark_ethdev_tx.c | 44 ++
On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote:
> On 8/24/2020 2:36 PM, Ed Czeck wrote:
> > Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG,
> > PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG.
> > Review and adjust log levels and messages as needed.
> >
> > Signed-off
On 8/24/2020 2:36 PM, Ed Czeck wrote:
> Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG,
> PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG.
> Review and adjust log levels and messages as needed.
>
> Signed-off-by: Ed Czeck
> ---
> doc/guides/nics/ark.rst | 13 --
> dri
On Tue, Aug 18, 2020 at 8:12 PM Luca Boccassi wrote:
>
> Hi all,
>
> Here is a list of patches targeted for stable release 19.11.4.
>
> The planned date for the final release is August 31st.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-al
On Mon, 2020-08-24 at 15:22 +0200, Christian Ehrhardt wrote:
> On Tue, Aug 18, 2020 at 8:12 PM Luca Boccassi wrote:
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.4.
> >
> > The planned date for the final release is August 31st.
> >
> > Please help with testing
Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG,
PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG.
Review and adjust log levels and messages as needed.
Signed-off-by: Ed Czeck
---
doc/guides/nics/ark.rst | 13 --
drivers/net/ark/ark_ddm.c | 12 ++---
drivers/net/a
Replace behavior with RTE_LIBRTE_ARK_MIN_TX_PKTLEN
with a default value of 0.
Update documentation as needed.
Signed-off-by: Ed Czeck
---
doc/guides/nics/ark.rst | 13 --
drivers/net/ark/ark_ethdev_tx.c | 44 +++--
drivers/net/ark/ark_logs.h | 8
From: Yunjian Wang
This patch removes logically dead code reported by coverity.
Coverity issue: 349930
Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/bus/dpaa/base/qbman/qman_driver.c | 2 --
1 file changed, 2 de
On 8/24/2020 1:43 PM, wangyunjian wrote:
> From: Yunjian Wang
>
> Negative array index read using variable 'i' as an index to array
> 'filter_info->pkt_filters'. Fixed by add return value check.
>
> Coverity issue: 350364
> Fixes: f4ca3fd54c4d ("net/hinic: create and destroy flow director filter
From: Yunjian Wang
Negative array index read using variable 'i' as an index to array
'filter_info->pkt_filters'. Fixed by add return value check.
Coverity issue: 350364
Fixes: f4ca3fd54c4d ("net/hinic: create and destroy flow director filter")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
--
On 8/24/2020 12:46 PM, wangyunjian wrote:
> From: Yunjian Wang
>
> Coverity flags that 'fp->sb_info' variable is used before
> it's checked for NULL. This patch fixes this issue.
>
> Coverity issue: 260413
> Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")
> Cc: sta...@dp
Below is NVIDIA Mellanox's roadmap for DPDK20.11, which we are currently
working on:
rte_flow API updates:
==
[1] Support flow-based traffic sampling and mirroring:
Packets of a given classification can be cloned at a given sampling
rate and forwarded to a vport or que
From: Yunjian Wang
Coverity flags that 'fp->sb_info' variable is used before
it's checked for NULL. This patch fixes this issue.
Coverity issue: 260413
Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/qede
From: "Wei Hu (Xavier)"
This patch adds checking whether the related Tx or Rx queue has been
setuped in the rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get
API function to avoid illegal address access.
Signed-off-by: Wei Hu (Xavier)
---
lib/librte_ethdev/rte_ethdev.c | 16 +
From: "Wei Hu (Xavier)"
Currently, if there are not available Rx buffer descriptors in receiving
direction based on hns3 network engine, incoming packets will always be
dropped by hardware. This patch reports the '.rx_drop_en' information to
DPDK framework in the '.dev_infos_get', '.rxq_info_get'
This series include 3 patches.
One patch is a minor update to add checking whether the related Tx or Rx
queue has been setuped in the rte_eth_rx_queue_info_get and
rte_eth_tx_queue_info_get API function to avoid illegal address access.
And the other two patches for hns3 PMD driver.
Huisong Li (1)
From: Huisong Li
This patch adds support for querying Rx/Tx queue information.
Signed-off-by: Huisong Li
Signed-off-by: Wei Hu (Xavier)
---
v3 -> v4:
remove unused variable ‘hw’ in hns3_rxq_info_get
and hns3_rxq_info_get function.
---
drivers/net/hns3/hns3_ethdev.c| 2 ++
On 21/08/2020 17:29, Bruce Richardson wrote:
Add update of the relevant stats for the data path functions and point the
overall device struct xstats function pointers to the existing ioat
functions.
At this point, all necessary hooks for supporting the existing unit tests
are in place so call th
'_rte_eth_dev_callback_process()' & '_rte_eth_dev_reset()' internal APIs
has unconventional underscore ('_') prefix.
Although this is not documented most probably this is to mark them as
internal. Since we have '__rte_internal' flag to mark this, removing '_'
from API names.
For '_rte_eth_dev_rese
These are sturct type names, not object names. Removing them from .map
file.
Fixes: 9d41beed24b0 ("lib: provide initial versioning")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
lib/librte_ethdev/rte_ethdev_version.map | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ethde
Hiding the 'struct eth_dev_ops' from applications.
Removing relevant deprecation notice.
Signed-off-by: Ferruh Yigit
---
doc/guides/rel_notes/deprecation.rst | 9 -
drivers/net/i40e/i40e_vf_representor.c | 1 +
drivers/net/ixgbe/ixgbe_vf_representor.c | 1 +
lib/librte_ethdev/rte_et
Removing 'rte_eth_rx_descriptor_done()' API and relevant
'rx_descriptor_done' function pointer from 'struct eth_dev_ops'.
Deprecation notice is to deprecate the API in 20.11 and remove one year
later, this is useful to prevent new applications use the API but keep
the support for old application.
Hairpin helper functions were not used by drivers, but it was used only
local to ethdev. They are:
'rte_eth_dev_is_rx_hairpin_queue()'
'rte_eth_dev_is_tx_hairpin_queue()'
Exposing them as internal APIs and update mlx5 driver (only user of
hairpin) to use them.
Signed-off-by: Ferruh Yigit
---
dr
This patch is a preparation to hide the 'struct eth_dev_ops' from
applications by moving some device operations from 'struct eth_dev_ops'
to 'struct rte_eth_dev'.
Mentioned ethdev APIs are in the data path and implemented as inline
because of performance reasons.
Exposing 'struct eth_dev_ops' to
Some ethdev functions are for drivers only, not for applications.
Since we have '__rte_internal' tag available now, marking internal
functions with it and moving functions to INTERNAL section in linker
script.
This is also good for documenting the internal functions.
Some internal APIs seems mark
Remove the deprecated rte_cio_[rw]mb APIs.
Signed-off-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
lib/librte_eal/arm/include/rte_atomic_32.h | 4 ---
lib/librte_eal/arm/include/rte_atomic_64.h | 4 ---
lib/librte_eal/include/generic/rte_atomic.h | 39 -
lib/librt
Replace the deprecated rte_cio_[rw]mb barriers with rte_io_[rw]mb
barriers.
Signed-off-by: Phil Yang
Signed-off-by: Joyce Kong
---
drivers/common/mlx5/mlx5_common.h | 2 +-
drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 2 +-
drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 4 ++-
From: Rohit Raj
This patch add support for closing the bus objects which
were acquired In the bus probe.
Some devices need to be cleaned while in both primary and
secondary process and while some need to be cleaned only in
case of primary process.
The devices are closed as per the white list us
From: Rohit Raj
Certain bus objects may need to be closed and re-acquired
while terminating and rerunning the client application.
Hence a signal handler is required to catch the termination
of the App and hence closing the bus objects.
This patch adds the missing signal handler in the client
app
From: Rohit Raj
As per the current code we have API for bus probe, but the
bus close API is missing. This breaks the multi process
scenarios as objects are not cleaned while terminating the
secondary processes.
This patch adds a new API rte_bus_close() for cleanup of
bus objects which were acqui
Below is NVIDIA Mellanox's roadmap for DPDK20.11, which we are currently
working on:
rte_flow API updates:
==
[1] Support flow-based traffic sampling and mirroring:
Packets of a given classification, can be cloned at a given sampling rate and
forwarded to a vport or queue.
Hi Ferruh,
Thanks for your suggestion. I'll split the patch into a patchset as soon as
possible.
-Original Message-
From: Ferruh Yigit
Sent: Thursday, August 20, 2020 7:49 PM
To: Jiawen Wu ; dev@dpdk.org
Cc: jianw...@trustnetic.com; yuhongzh...@trustnetic.com
Subject: Re: [PATCH] net:
Several DV-based structs of type 'struct mlx5dv_devx_XXX' are replaced
with 'void *' to enable compilation under non-Linux operating systems.
New getter functions were added to retrieve the specific fields that
were previously accessed directly.
Replaced structs:
'struct mlx5dv_pp *'
'struct mlx5d
Flow metering is supported only in direct rules (DR). Currently the APIs
of meter actions create and modify are under #ifdef
HAVE_MLX5_DR_CREATE_ACTION_FLOW_METER, while detaching the meter action
is executed unconditionally. This commit adds the same ifdef to API
mlx5_flow_meter_detach().
This com
When updating a queue vlan stripping offload - either the WQ is modified
in Verbs or the RQ is modified in DevX. Add a vlan stripping modify
callback to 'struct mlx5_obj_ops' and assign it with the specic Verbs
and DevX implementations: 'rxq_obj_modify_wq_vlan_strip' and
'rxq_obj_modify_rq_vlan_st
During vdap device setup, if some error happens, event channel release
stuck at polling event channel.
Event channel fd is set to nonblocking in cqe setup, so if any error
happens before this function and after event channel created, the
pooling before releasing resources will stuck.
This patch m
From: Kiran Kumar K
Adding support for RTE Flow VLAN insert and strip actions for octeontx2
device.
Signed-off-by: Kiran Kumar K
---
doc/guides/nics/octeontx2.rst | 68 +++--
drivers/net/octeontx2/otx2_flow.c | 126
drivers/net/octeontx2/otx2_f
58 matches
Mail list logo