[dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path

2020-07-08 Thread Phil Yang
If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative path. This will break ninja in the ABI check test. Fixes: 777014e56d07 ("devtools: add ABI checks") Signed-off-by: Phil Yang --- devtools/test-meson-builds.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/de

Re: [dpdk-dev] [PATCH] net/ice: fix invalid RSS type

2020-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Thursday, July 9, 2020 2:27 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia ; Su, Simei > > Subject: [PATCH] net/ice: fix invalid RSS type > > When a RSS rule with only RSS type modifirer L2/L3/L4 SRC/DST_ONLY, it > should return failu

[dpdk-dev] [PATCH v2] eal: use c11 atomic built-ins for interrupt status

2020-07-08 Thread Phil Yang
The event status is defined as a volatile variable and shared between threads. Use c11 atomic built-ins with explicit ordering instead of rte_atomic ops which enforce unnecessary barriers on aarch64. The event status has been cleaned up by the compare-and-swap operation when we free the event data

[dpdk-dev] [PATCH] net/ice: fix invalid RSS type

2020-07-08 Thread Simei Su
When a RSS rule with only RSS type modifirer L2/L3/L4 SRC/DST_ONLY, it should return failure. This patch adds invalid RSS type check. Fixes: dfaedcf20170 ("net/ice: refactor PF hash flow") Signed-off-by: Simei Su --- drivers/net/ice/ice_hash.c | 5 + 1 file changed, 5 insertions(+) diff --

Re: [dpdk-dev] [PATCH v4 01/10] eal: introduce macros for getting valuefor bit

2020-07-08 Thread Parav Pandit
Hi Morten, > From: Morten Brørup > Sent: Tuesday, July 7, 2020 6:11 PM > Adding Joyce Kong to this discussion as the rte_bitops maintainer. > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Tuesday, July 7, 2020 2:13 PM > > > > 07/07/2020 13:38, Parav Pandit: > > > From: Morten

[dpdk-dev] [PATCH] net/ice: fix incomplete protocol header for PPPoE

2020-07-08 Thread Simei Su
When adding a RSS rule with pattern MAC_PPPOE_IPV4_UDP and input set SRC/DST IPV4, because of incomplete protocol header fields, the rule can't do hash with inner src/dst ipv4. PPPOE_IPV4_TCP/SCTP and PPPOE_IPV6_UDP/TCP/SCTP also have similar issues. This patch complements protocol header fields fo

[dpdk-dev] [PATCH v2 0/3] ring clean up

2020-07-08 Thread Feifei Wang
From: feifei Do some work for ring refactoring, which includes: 1. remove experimental tags 2. use element APIs to implement legacy APIs Feifei Wang (3): ring: remove experimental tag for ring reset API ring: remove experimental tag for ring element APIs ring: use element APIs to implement

[dpdk-dev] [PATCH v2 3/3] ring: use element APIs to implement legacy APIs

2020-07-08 Thread Feifei Wang
Use rte_ring_xxx_elem_xxx APIs to replace legacy API implementation. This reduces code duplication and improves code maintenance. Tests done on Arm, x86 [1] and PPC [2] do not indicate performance degradation. [1] https://mails.dpdk.org/archives/dev/2020-July/173780.html [2] https://mails.dpdk.org

[dpdk-dev] [PATCH v2 1/3] ring: remove experimental tag for ring reset API

2020-07-08 Thread Feifei Wang
Remove the experimental tag for rte_ring_reset API that have been around for 4 releases. Signed-off-by: Feifei Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- v2: 1. add the changed API into DPDK_21 ABI in the map file. (Ray) lib/librte_ring/rte_ring.h | 3 ---

[dpdk-dev] [PATCH v2 2/3] ring: remove experimental tag for ring element APIs

2020-07-08 Thread Feifei Wang
Remove the experimental tag for rte_ring_xxx_elem APIs that have been around for 2 releases. Signed-off-by: Feifei Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Acked-by: Konstantin Ananyev --- v2: 1. add the changed API into DPDK_21 ABI in the map file. (Ray) lib/librte_r

Re: [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action

2020-07-08 Thread Ori Kam
Hi Andrey, > -Original Message- > From: Jerin Jacob > Sent: Thursday, July 9, 2020 7:44 AM > To: Andrey Vesnovaty > Cc: dpdk-dev ; j...@marvell.com; Thomas Monjalon > ; Ferruh Yigit ; Stephen > Hemminger ; Richardson, Bruce > ; Ori Kam ; Slava > Ovsiienko ; Andrey Vesnovaty > ; Marko Kov

[dpdk-dev] [PATCH V2] net/i40e: i40e FDIR update rate optimization

2020-07-08 Thread chenmin . sun
From: Chenmin Sun This patch optimized the fdir update rate for i40e PF, by tracking whether the fdir rule being inserted into the guaranteed space or shared space. For the flows that are inserted to the guaranteed space, we assume that the insertion will always succeed as the hardware only repor

Re: [dpdk-dev] [PATCH] net/i40e: i40e FDIR update rate optimization

2020-07-08 Thread Sun, Chenmin
Best Regards, Sun, Chenmin > -Original Message- > From: Wang, Haiyue > Sent: Wednesday, July 8, 2020 4:41 PM > To: Sun, Chenmin ; Zhang, Qi Z > ; Xing, Beilei ; Wu, Jingjing > > Cc: dev@dpdk.org; Sun, Chenmin > Subject: RE: [dpdk-dev] [PATCH] net/i40e: i40e FDIR update rate optimizat

Re: [dpdk-dev] [PATCH] net/i40e: i40e FDIR update rate optimization

2020-07-08 Thread Sun, Chenmin
Best Regards, Sun, Chenmin > -Original Message- > From: Xing, Beilei > Sent: Wednesday, July 8, 2020 1:38 PM > To: Sun, Chenmin ; Zhang, Qi Z > ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/i40e: i40e FDIR update rate optimization > > > > > -Original Message-

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread Xia, Chenbo
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, July 9, 2020 1:14 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: David Marchand ; Tal Shnaiderman > ; Burakov, Anatoly ; > tho...@monjalon.net > Subject: RE: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource > > Hi Chenbo, > > Tha

Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status

2020-07-08 Thread Phil Yang
> -Original Message- > From: Kinsella, Ray > Sent: Wednesday, July 8, 2020 11:05 PM > To: David Marchand ; Phil Yang > ; Aaron Conole > Cc: dev ; David Christensen ; > Honnappa Nagarahalli ; Ruifeng Wang > ; nd ; Dodji Seketeli > ; Neil Horman ; Harman > Kalra > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status

2020-07-08 Thread Phil Yang
> -Original Message- > From: Harman Kalra > Sent: Wednesday, July 8, 2020 7:41 PM > To: Phil Yang > Cc: dev@dpdk.org; d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd > Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status > > On Thu, Jun 11,

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread Zhang, AlvinX
Hi Chenbo, Thanks your comments. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, July 8, 2020 9:58 PM > To: Zhang, AlvinX ; dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; David > Marchand ; Tal Shnaiderman > ; Burakov, Anatoly ; > tho...@monjalon.net > Subject: RE: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build flags

2020-07-08 Thread Jerin Jacob
On Thu, Jul 9, 2020 at 2:25 AM Honnappa Nagarahalli wrote: > > > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build > > > > flags > > > > > > > > On Mon, Jul 6, 2020 at 1:59 PM Juraj Linkeš > > > > > > > > wrote: > > > > > > > > > > Base the flags on config/defco

Re: [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action

2020-07-08 Thread Jerin Jacob
On Thu, Jul 9, 2020 at 3:09 AM Andrey Vesnovaty wrote: > > This commit gives very first shared RSS action usage example and > demonstrates shared action capability for in-place update. > > First application creates shared action during initialization phase. What if PMD does not support a shared c

Re: [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD

2020-07-08 Thread Jerin Jacob
On Thu, Jul 9, 2020 at 3:09 AM Andrey Vesnovaty wrote: > > Hi Jerin and Ori. > > V2 changes: > - First version of PMD implementation for shared action API. > - Simple example application demonstaration shared action update. > - Changes to shred action API according to discussion of V1. > > @Jerin

Re: [dpdk-dev] [PATCH v4 1/2] rte_flow: add eCPRI key fields to flow API

2020-07-08 Thread Bing Zhao
> -Original Message- > From: Akhil Goyal > Sent: Thursday, July 9, 2020 2:50 AM > To: Bing Zhao ; Ori Kam > ; john.mcnam...@intel.com; > marko.kovace...@intel.com; Thomas Monjalon > ; ferruh.yi...@intel.com; > arybche...@solarflare.com; olivier.m...@6wind.com > Cc: dev@dpdk.org; wenzhuo...

Re: [dpdk-dev] [PATCH 15/27] event/dlb: add probe

2020-07-08 Thread Eads, Gage
Hi Tim, > +/* declared extern in header, for access from other .c files */ int > +eventdev_dlb_log_level; > + > +RTE_INIT(evdev_dlb_init_log) > +{ > + eventdev_dlb_log_level = rte_log_register("pmd.event.dlb"); > + if (eventdev_dlb_log_level >= 0) > + rte_log_set_level(eventd

Re: [dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation

2020-07-08 Thread Eads, Gage
Hi Tim, > doc/guides/eventdevs/dlb.rst | 497 > ++ > 1 file changed, 497 insertions(+) > create mode 100644 doc/guides/eventdevs/dlb.rst > > diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb.rst new > file mode 100644 index 000..21

Re: [dpdk-dev] [PATCH 0/3] ring clean up

2020-07-08 Thread Feifei Wang
> -Original Message- > From: Ananyev, Konstantin > Sent: 2020年7月9日 1:06 > To: David Marchand ; Feifei Wang > > Cc: dev ; nd > Subject: RE: [dpdk-dev] [PATCH 0/3] ring clean up > > > On Fri, Jul 3, 2020 at 12:27 PM Feifei Wang wrote: > > > > > > Do some work for ring refactoring, whic

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread Xiao, QimaiX
Tested-by: Xiao Qimai Regards, Xiao Qimai > -Original Message- > From: dev On Behalf Of alvinx.zh...@intel.com > Sent: Wednesday, July 8, 2020 5:25 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia > Subject: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource > > From: Alvin Zhang >

[dpdk-dev] [PATCH v6 3/3] net/ice: add RSS support for IPv6 prefix

2020-07-08 Thread Qi Zhang
From: Junfeng Guo RSS for IPv6 prefix fields are supported in this patch, so that we can use prefixes instead of full IPv6 address for RSS. These prefixes include the first 32, 48, 64 bits of both SRC and DST IPv6 address. Signed-off-by: Junfeng Guo Acked-by: Qi Zhang --- drivers/net/ice/ice_

[dpdk-dev] [PATCH v6 2/3] app/testpmd: support extended RSS offload types

2020-07-08 Thread Qi Zhang
From: Junfeng Guo This patch adds testpmd cmdline support for IPv6 prefix. Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- app/test-pmd/cmdline.c | 12 app/test-pmd/config.c | 6 ++ 2 files changed, 18 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd

[dpdk-dev] [PATCH v6 1/3] ethdev: add new RSS types for IPv6 prefix

2020-07-08 Thread Qi Zhang
From: Junfeng Guo This patch defines new RSS offload types for IPv6 prefix with 32, 40, 48, 56, 64, 96 bits of both SRC and DST IPv6 address. Ref https://tools.ietf.org/html/rfc6052. Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- v6: - rename to RTE_ETH_RSS_xxx v5: - add 40 56, 96 ac

Re: [dpdk-dev] [PATCH v2 00/29] NXP DPAAx enhancements

2020-07-08 Thread Ferruh Yigit
On 7/7/2020 10:22 AM, Hemant Agrawal wrote: > v2: dropping the fmlib changes - we will send them separately > > This patch-set mainly address following enhancements > > 1. Supporting the non-EAL thread based I/O processing > 2. Reducing the thread local storage > 3. DPAA2 flow support > 4. other

[dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue

2020-07-08 Thread Ting Xu
When create softnic hash table with 16 keys, it failed on 32bit environment because of the structure rte_bucket_4_16 alignment issue. Add __rte_cache_aligned to ensure correct cache align. Fixes: 8aa327214c ("table: hash") Cc: sta...@dpdk.org Signed-off-by: Ting Xu --- v2->v3: Rebase v1->v2: Co

[dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue

2020-07-08 Thread Ting Xu
When create softnic hash table with 16 keys, it failed on 32bit environment because of the structure rte_bucket_4_16 alignment issue. Add __rte_cache_aligned to ensure correct cache align. Fixes: 8aa327214c ("table: hash") Cc: sta...@dpdk.org Signed-off-by: Ting Xu --- v2->v3: Rebase v1->v2: Co

[dpdk-dev] [PATCH v1] lib/table: fix cache alignment issue

2020-07-08 Thread Ting Xu
When create softnic hash table with 16 keys, it failed on 32bit environment because of the structure rte_bucket_4_16 alignment issue. Add __rte_cache_aligned to ensure correct cache align. Fixes: 8aa327214c ("table: hash") Cc: sta...@dpdk.org Signed-off-by: Ting Xu --- lib/librte_table/rte_tabl

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS types for IPv6 prefix

2020-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, July 8, 2020 10:29 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > ; Su, Simei ; Yigit, Ferruh > ; arybche...@solarflare.com; > viachesl...@mellanox.com; jer...@marvell.com; > ajit.khapa..

Re: [dpdk-dev] [RFC PATCH] log: track log level changes

2020-07-08 Thread Lukasz Wojciechowski
W dniu 26.06.2020 o 16:46, Andrew Rybchenko pisze: > On 6/26/20 2:47 PM, David Marchand wrote: >> Add a log message when changing log levels to be sure of which logtype >> is enabled. >> >> Suggested-by: Ilya Maximets >> Signed-off-by: David Marchand > Acked-by: Andrew Rybchenko > I also like

Re: [dpdk-dev] [PATCH] test/eal: check invalid cpu value

2020-07-08 Thread Lukasz Wojciechowski
W dniu 12.06.2020 o 14:09, Kevin Traynor pisze: > When using --lcores option, CPU_SETSIZE allows a range of > 0-1023. Check it is not being exceeded. > > Signed-off-by: Kevin Traynor > --- > app/test/test_eal_flags.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

[dpdk-dev] [PATCH v5 4/4] net/qede: add support for get register operation

2020-07-08 Thread Rasesh Mody
Add support for .get_reg eth_dev ops which will be used to collect the firmware debug data. PMD on detecting on some HW errors will collect the FW/HW Dump to a buffer and then it will save it to a file implemented in qede_save_fw_dump(). Dump file location and name: Location: or DPDK root Name:

[dpdk-dev] [PATCH v5 0/4] net/qede: add FW debug data collection support

2020-07-08 Thread Rasesh Mody
Hi Jerin, Ferruh, This patch-set adds an ability to collect FW and HW Debug Data/Dump (referred to as FW/HW Dump) to QEDE PMD. The dump is collected either when PMD detects an error or when a DPDK application asks PMD to collect it upon detection of application error. This FW/HW Dump needs to be s

[dpdk-dev] [PATCH v5 2/4] net/qede/base: add changes for debug data collection

2020-07-08 Thread Rasesh Mody
This patch adds base driver APIs required for debug data collection. It adds support for dumping internal lookup tables(ilt), reading nvram image, register definitions. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c | 6 + drivers/net

[dpdk-dev] [PATCH v5 1/4] net/qede/base: re-arrange few structures for DDC

2020-07-08 Thread Rasesh Mody
This patch rearranges some of the base driver structures which will be also used by debug data collection (DDC) implementation. It adds a new file ecore_hsi_func_common.h with Physical, Virtual memory descriptors. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base

Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient privileges for hugepages

2020-07-08 Thread Ranjit Menon
On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote: AdjustTokenPrivileges() succeeds even if no requested privileges have been granted; this behavior is documented. Check last error code in addition to return value to detect such case. Make error messages more specific and add troubleshooting hint. Si

[dpdk-dev] [PATCH v2] eal/windows: detect insufficient privileges for hugepages

2020-07-08 Thread Dmitry Kozlyuk
AdjustTokenPrivileges() succeeds even if no requested privileges have been granted; this behavior is documented. Check last error code in addition to return value to detect such case. Make error messages more specific and add troubleshooting hint. Signed-off-by: Dmitry Kozlyuk --- v2: Impro

[dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action

2020-07-08 Thread Andrey Vesnovaty
This commit gives very first shared RSS action usage example and demonstrates shared action capability for in-place update. First application creates shared action during initialization phase. Later on the flow object created by application uses previously created shared RSS action with 1 queue co

[dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX

2020-07-08 Thread Andrey Vesnovaty
Implement mlx5_devx_cmd_modify_tir() to modify TIR object using DevX API. Add related structs in mlx5_prm.h. Signed-off-by: Andrey Vesnovaty --- drivers/common/mlx5/mlx5_devx_cmds.c | 84 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 10 +++ drivers/common/mlx5/mlx

[dpdk-dev] [PATCH v2 5/6] net/mlx5: driver support for shared action

2020-07-08 Thread Andrey Vesnovaty
Implement shared action create/destroy/update/query. Implement RSS shared action and handle shared RSS on flow apply and release. Note: currently implemented for sharede RSS action only Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5_flow_dv.c | 671 ++-- 1

[dpdk-dev] [PATCH v2 4/6] net/mlx5: shared action PMD

2020-07-08 Thread Andrey Vesnovaty
Implement rte_flow shared action API for mlx5 PMD. Handle shared action on flow create/destroy. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_defs.h | 3 + drivers/net/mlx5/mlx5_flow.c | 492 +++

[dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD

2020-07-08 Thread Andrey Vesnovaty
Hi Jerin and Ori. V2 changes: - First version of PMD implementation for shared action API. - Simple example application demonstaration shared action update. - Changes to shred action API according to discussion of V1. @Jerin Jacob: please take a look at provided example, hopefully it will help to

[dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-07-08 Thread Andrey Vesnovaty
From: Andrey Vesnovaty This commit introduces extension of DPDK flow action API enabling sharing of single rte_flow_action in multiple flows. The API intended for PMDs where multiple HW offloaded flows can reuse the same HW essence/object representing flow action and modification of such an essen

[dpdk-dev] [PATCH v2 3/6] net/mlx5: modify hash Rx queue objects

2020-07-08 Thread Andrey Vesnovaty
Implement mlx5_hrxq_modify() to modify hash RX queue object. This commit relays on capability to modify TIR object via DevX. Signed-off-by: Andrey Vesnovaty --- drivers/net/mlx5/mlx5_rxq.c | 300 --- drivers/net/mlx5/mlx5_rxtx.h | 4 + 2 files changed, 243 inse

[dpdk-dev] [PATCH v4 4/4] pmdinfogen: remove C implementation

2020-07-08 Thread Dmitry Kozlyuk
Delete the files no longer used in build process. Keep Neil Horman maintainer of the entire "Driver information" section, only adjust paths. Signed-off-by: Dmitry Kozlyuk --- MAINTAINERS| 2 +- buildtools/pmdinfogen/Makefile | 20 -- buildtools/pmdinfogen/meson.bu

[dpdk-dev] [PATCH v4 0/4] pmdinfogen: rewrite in Python

2020-07-08 Thread Dmitry Kozlyuk
This patchset implements existing pmdinfogen logic in Python, replaces and removes the old code. The goals of rewriting are: * easier maintenance by using a more high-level language, * simpler build process without host application and libelf. Travis CI script is adjusted to install python3-pyelf

[dpdk-dev] [PATCH v4 3/4] doc/linux_gsg: require pyelftools for pmdinfogen

2020-07-08 Thread Dmitry Kozlyuk
The package is available on all major distributions. FreeBSD has no system requirements section in its GSG, Windows currently neither uses pmdinfogen not is supported by it. Signed-off-by: Dmitry Kozlyuk --- doc/guides/linux_gsg/sys_reqs.rst | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[dpdk-dev] [PATCH v4 1/4] pmdinfogen: add Python implementation

2020-07-08 Thread Dmitry Kozlyuk
Using a high-level, interpreted language simplifies maintenance and build process. Furthermore, ELF handling is delegated to pyelftools package. Original logic is kept, the copyright recognizes that. Signed-off-by: Dmitry Kozlyuk --- buildtools/pmdinfogen.py | 188 +++

[dpdk-dev] [PATCH v4 2/4] build: use Python pmdinfogen

2020-07-08 Thread Dmitry Kozlyuk
Like for other build scripts, use Python interpreter to run pmdinfogen. Adjust wrapper script accordingly and also don't suppress stderr from ar and pmdinfogen. Add python3-pyelftools to CI configuration. Signed-off-by: Dmitry Kozlyuk --- .travis.yml | 2 +- GNUmakefile

Re: [dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build flags

2020-07-08 Thread Honnappa Nagarahalli
> > > > > > > Subject: Re: [dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build > > > flags > > > > > > On Mon, Jul 6, 2020 at 1:59 PM Juraj Linkeš > > > > > > wrote: > > > > > > > > Base the flags on config/defconfig_arm-armv7a-linuxapp-gcc. > > > > Omit driver flags which can be built on arm3

[dpdk-dev] [PATCH] common/mlx5: fix physical port name pattern recognition

2020-07-08 Thread Viacheslav Ovsiienko
This patch makes the Infiniband device physical port name recognition more strict. Currently mlx5 PMD might recognize the names like "pf0sf0" erroneously as "pf0" and the wrong device type (host PF representor) is reported. The names like "pf0sf0" belong to PCI subfunctions which is currently not

Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status

2020-07-08 Thread Aaron Conole
David Marchand writes: > On Wed, Jul 8, 2020 at 3:43 PM Aaron Conole wrote: >> > Note: checking on the test-report ml, I saw nothing, but ovsrobot did >> > catch the issue with this change too, Aaron? >> >> I don't have archives back to Jun 11 on the robot server. I think it >> doesn't preserve

Re: [dpdk-dev] [PATCH 0/3] ring clean up

2020-07-08 Thread Honnappa Nagarahalli
> > > On Fri, Jul 3, 2020 at 12:27 PM Feifei Wang wrote: > > > > > > Do some work for ring refactoring, which includes: > > > 1. remove experimental tags > > > 2. use element APIs to implement legacy APIs > > > > This series triggers unit test failures. > > https://travis-ci.com/github/ovsrobot/

Re: [dpdk-dev] [PATCH v3 4/8] fib: introduce AVX512 lookup

2020-07-08 Thread Medvedkin, Vladimir
Hi Thomas, On 06/07/2020 20:21, Thomas Monjalon wrote: 19/05/2020 14:12, Vladimir Medvedkin: --- a/lib/librte_fib/meson.build +++ b/lib/librte_fib/meson.build +if dpdk_conf.has('RTE_ARCH_X86') and cc.has_argument('-mavx512f') + if cc.has_argument('-mavx512dq') + dir24_8_avx5

[dpdk-dev] [PATCH v4 5/8] fib6: make lookup function type configurable

2020-07-08 Thread Vladimir Medvedkin
Add type argument to trie_get_lookup_fn() Now it only supports RTE_FIB6_TRIE_SCALAR Add new rte_fib6_set_lookup_fn() - user can change lookup function type runtime. Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/rte_fib6.c | 20 +++- lib/librte_fib/rte_fib6.h

[dpdk-dev] [PATCH v4 4/8] fib: introduce AVX512 lookup

2020-07-08 Thread Vladimir Medvedkin
Add new lookup implementation for DIR24_8 algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_fib/Makefile | 14 +++ lib/librte_fib/dir24_8.c| 24 + lib/librte_fib/dir24_8_avx512.c | 165 +

[dpdk-dev] [PATCH v4 8/8] app/testfib: add support for different lookup functions

2020-07-08 Thread Vladimir Medvedkin
Added -v option to switch between different lookup implementations to measure their performance and correctness. Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 58 ++--- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/app/test-f

[dpdk-dev] [PATCH v4 6/8] fib6: move lookup definition into the header file

2020-07-08 Thread Vladimir Medvedkin
Move trie table layout and lookup defenition into the private header file. This is necessary for implementing a vectorized lookup function in a separate .с file. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_fib/trie.c | 121 --

[dpdk-dev] [PATCH v4 7/8] fib6: introduce AVX512 lookup

2020-07-08 Thread Vladimir Medvedkin
Add new lookup implementation for FIB6 trie algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_fib/Makefile | 10 ++ lib/librte_fib/meson.build | 13 ++ lib/librte_fib/rte_fib6.h| 3 +- lib/librte_fib/trie.c

[dpdk-dev] [PATCH v4 3/8] fib: move lookup definition into the header file

2020-07-08 Thread Vladimir Medvedkin
Move dir24_8 table layout and lookup defenition into the private header file. This is necessary for implementing a vectorized lookup function in a separate .с file. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_fib/dir24_8.c | 225 +---

[dpdk-dev] [PATCH v4 2/8] fib: make lookup function type configurable

2020-07-08 Thread Vladimir Medvedkin
Add type argument to dir24_8_get_lookup_fn() Now it supports 3 different lookup implementations: RTE_FIB_DIR24_8_SCALAR_MACRO RTE_FIB_DIR24_8_SCALAR_INLINE RTE_FIB_DIR24_8_SCALAR_UNI Add new rte_fib_set_lookup_fn() - user can change lookup function type runtime. Signed-off-by: Vladimir Medvedk

[dpdk-dev] [PATCH v4 1/8] eal: introduce zmm type for AVX 512-bit

2020-07-08 Thread Vladimir Medvedkin
New data type to manipulate 512 bit AVX values. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_eal/x86/include/rte_vect.h | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/x86/include/rte_vect.h b/lib/librte_eal/x86/include

[dpdk-dev] [PATCH v4 0/8] fib: implement AVX512 vector lookup

2020-07-08 Thread Vladimir Medvedkin
This patch series implements vectorized lookup using AVX512 for ipv4 dir24_8 and ipv6 trie algorithms. Also introduced rte_fib_set_lookup_fn() to change lookup function type. Added option to select lookup function type in testfib application. v4: - use __rte_aligned() instead of using compiler at

Re: [dpdk-dev] [PATCH v3 4/8] fib: introduce AVX512 lookup

2020-07-08 Thread Medvedkin, Vladimir
On 24/06/2020 14:18, Ananyev, Konstantin wrote: Add new lookup implementation for DIR24_8 algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/Makefile | 14 lib/librte_fib/dir24_8.c| 24 ++ lib/librte_fib/dir24_8_avx512

Re: [dpdk-dev] [PATCH v3 7/8] fib6: introduce AVX512 lookup

2020-07-08 Thread Medvedkin, Vladimir
Hi Konstantin, Thanks for review, On 08/07/2020 13:23, Ananyev, Konstantin wrote: Add new lookup implementation for FIB6 trie algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/Makefile | 10 ++ lib/librte_fib/meson.build | 9 ++ lib/l

Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug

2020-07-08 Thread Lukasz Wojciechowski
W dniu 08.07.2020 o 19:10, David Marchand pisze: > On Wed, Jul 8, 2020 at 4:52 PM Van Haaren, Harry > wrote: >>> The rte_service_lcore_reset_all function stops execution of services >>> on all lcores and switches them back from ROLE_SERVICE to ROLE_RTE. >>> However the thread loop for slave lcor

Re: [dpdk-dev] [PATCH v4 1/2] rte_flow: add eCPRI key fields to flow API

2020-07-08 Thread Akhil Goyal
> +#ifdef __cplusplus > +extern "C" { > +#endif > + > +/** > + * eCPRI Protocol Revision 1.0, 1.1, 1.2, 2.0: 0001b > + * Other values are reserved for future > + */ > +#define RTE_ECPRI_REV_UPTO_201 > + > +/** > + * eCPRI message types in specifications > + * IWF* types will only

[dpdk-dev] [PATCH v2] doc: add rib and fib into the API doxygen index

2020-07-08 Thread Vladimir Medvedkin
Add RIB/FIB library into the API doxygen index. Move LPM/LPM6 under separate section "Longest prefix match" Fixes: 5a5793a5ffa2 ("rib: add RIB library") Fixes: f7e861e21c46 ("rib: support IPv6") Fixes: 39e927248416 ("fib: add FIB library") Fixes: 40d41a8a7b34 ("fib: support IPv6") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v2] ethdev: verify reserved HW ring

2020-07-08 Thread Ferruh Yigit
On 6/24/2020 10:35 AM, Ferruh Yigit wrote: > Function 'rte_eth_dma_zone_reserve()' returns an existing memzone based > on name match, but other requested attributes are discarded. > This may cause driver using a memzone with wrong size or alignment. > > Verify size, alignment and socket_id for mat

Re: [dpdk-dev] [PATCH] net/ice/base: add SRC MAC field support for FD

2020-07-08 Thread Ferruh Yigit
On 7/8/2020 1:43 PM, Zhirun Yan wrote: > Add src MAC address field support, so that SRC MAC field in L2 can > be matched when set Flow Director filter with SRC MAC address. > > Signed-off-by: Zhirun Yan Squashed into relevant commit [1] in next-net, thanks. [1] net/ice: add support for src MAC

Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug

2020-07-08 Thread David Marchand
On Wed, Jul 8, 2020 at 4:52 PM Van Haaren, Harry wrote: > > The rte_service_lcore_reset_all function stops execution of services > > on all lcores and switches them back from ROLE_SERVICE to ROLE_RTE. > > However the thread loop for slave lcores (eal_thread_loop) distincts these > > roles to set l

Re: [dpdk-dev] [PATCH 0/3] ring clean up

2020-07-08 Thread Ananyev, Konstantin
> On Fri, Jul 3, 2020 at 12:27 PM Feifei Wang wrote: > > > > Do some work for ring refactoring, which includes: > > 1. remove experimental tags > > 2. use element APIs to implement legacy APIs > > This series triggers unit test failures. > https://travis-ci.com/github/ovsrobot/dpdk/builds/1741961

Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-07-08 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrzej Ostruszka > [C] > Sent: Tuesday, July 7, 2020 10:14 PM > > First of all, please excuse me Stephen for late reply. > > On 02/07/2020 02:34, Stephen Hemminger wrote: > > I had great hopes for this library, because such code exists in >

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: introduce accurate packet Tx scheduling

2020-07-08 Thread Slava Ovsiienko
> promote Acked-bt from previous patch version to maintain patchwork status > accordingly Acked-by: Olivier Matz > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Wednesday, July 8, 2020 18:47 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; olivier.

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: introduce accurate packet Txscheduling

2020-07-08 Thread Slava Ovsiienko
Hi, Morten Addressed most of your comments in the v5 commit message. Header file comments are close to become too wordy, and I did not dare to elaborate ones more. With best regards, Slava > -Original Message- > From: Morten Brørup > Sent: Wednesday, July 8, 2020 18:27 > To: Slava Ovsii

[dpdk-dev] [PATCH v5 2/2] app/testpmd: add send scheduling test capability

2020-07-08 Thread Viacheslav Ovsiienko
This commit adds testpmd capability to provide timestamps on the packets being sent in the txonly mode. This includes: - SEND_ON_TIMESTAMP support new device Tx offload capability support added, example: testpmd> port config 0 tx_offload send_on_timestamp on - set txtimes, registers fi

[dpdk-dev] [PATCH v5 1/2] mbuf: introduce accurate packet Tx scheduling

2020-07-08 Thread Viacheslav Ovsiienko
There is the requirement on some networks for precise traffic timing management. The ability to send (and, generally speaking, receive) the packets at the very precisely specified moment of time provides the opportunity to support the connections with Time Division Multiplexing using the contempora

Re: [dpdk-dev] [PATCH v7 1/3] lib/lpm: integrate RCU QSBR

2020-07-08 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Wednesday, July 8, 2020 10:30 PM > To: Ruifeng Wang > Cc: Bruce Richardson ; Vladimir Medvedkin > ; John McNamara > ; Marko Kovacevic > ; Ray Kinsella ; Neil Horman > ; dev ; Ananyev, Konstantin > ; Honnappa Nagarahalli > ; nd > Subjec

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: introduce accurate packet Txscheduling

2020-07-08 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slava Ovsiienko > Sent: Wednesday, July 8, 2020 4:54 PM > > Hi, Morten > > Thank you for the comments. Please, see below. > > > -Original Message- > > From: Morten Brørup > > Sent: Wednesday, July 8, 2020 17:16 > > To: Slava Ovsiien

Re: [dpdk-dev] [PATCH v2 12/20] net/ixgbe/base: modify coding style

2020-07-08 Thread Ferruh Yigit
On 7/2/2020 4:13 AM, Guinan Sun wrote: > Fix unchecked return value. > Add cast for type mismatch. > > Signed-off-by: Jakub Chylkowski > Signed-off-by: Guinan Sun > --- > drivers/net/ixgbe/base/ixgbe_82599.c | 12 +--- > drivers/net/ixgbe/base/ixgbe_common.c| 6 ++ > driver

Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-08 Thread Zhang, Roy Fan
Hi Akhil, Thanks for the comments! > -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 7, 2020 9:37 PM > To: Zhang, Roy Fan ; dev@dpdk.org; > ano...@marvell.com; asoma...@amd.com; ruifeng.w...@arm.com; > Nagadheeraj Rottela ; Michael Shamis > ; Ankur Dwivedi ; Jay > Zhou ; De

Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset

2020-07-08 Thread Stephen Hemminger
On Wed, 8 Jul 2020 10:06:26 +0500 Sarosh Arif wrote: > rte_timer_stop_sync(struct rte_timer *tim) > { > + struct rte_timer_data *timer_data; > + TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL); > + unsigned int lcore_id = rte_lcore_id(); This mixing code and

Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset

2020-07-08 Thread Stephen Hemminger
On Wed, 8 Jul 2020 10:06:26 +0500 Sarosh Arif wrote: > /* loop until rte_timer_reset() succeed */ > -void > +int > rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks, >enum rte_timer_type type, unsigned tim_lcore, >rte_timer_cb_t fct, void *arg)

Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status

2020-07-08 Thread Kinsella, Ray
On 08/07/2020 13:29, David Marchand wrote: > On Thu, Jun 11, 2020 at 12:25 PM Phil Yang wrote: >> >> The event status is defined as a volatile variable and shared >> between threads. Use c11 atomics with explicit ordering instead >> of rte_atomic ops which enforce unnecessary barriers on aarch6

Re: [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter

2020-07-08 Thread Thomas Monjalon
08/07/2020 15:30, Jerin Jacob: > On Tue, Jul 7, 2020 at 9:25 PM Phil Yang wrote: > > > > The n_poll_lcores counter and poll_lcore array are shared between lcores > > and the update of these variables are out of the protection of spinlock > > on each lcore timer list. The read-modify-write operatio

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: introduce accurate packet Txscheduling

2020-07-08 Thread Slava Ovsiienko
Hi, Morten Thank you for the comments. Please, see below. > -Original Message- > From: Morten Brørup > Sent: Wednesday, July 8, 2020 17:16 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; olivier.m...@6wind.com; > bernard.iremon...@intel.com; tho...@mellanox.

Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug

2020-07-08 Thread Van Haaren, Harry
> -Original Message- > From: Lukasz Wojciechowski > Sent: Wednesday, July 8, 2020 2:38 PM > To: Van Haaren, Harry ; Jerin Jacob > > Cc: dev@dpdk.org; l.wojciec...@partner.samsung.com; sta...@dpdk.org > Subject: [PATCH v2] eal: fix lcore state bug > > The rte_service_lcore_reset_all funct

Re: [dpdk-dev] [PATCH 0/3] ring clean up

2020-07-08 Thread David Marchand
On Fri, Jul 3, 2020 at 12:27 PM Feifei Wang wrote: > > Do some work for ring refactoring, which includes: > 1. remove experimental tags > 2. use element APIs to implement legacy APIs This series triggers unit test failures. https://travis-ci.com/github/ovsrobot/dpdk/builds/174196115 https://trav

Re: [dpdk-dev] [pull-request] next-crypto 20.08 rc1

2020-07-08 Thread Thomas Monjalon
08/07/2020 00:39, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

[dpdk-dev] [PATCH 5/5] net/mlx5: create and destroy eCPRI flex parser

2020-07-08 Thread Bing Zhao
eCPRI protocol has unified format layout for the variants, over ETH layer (including .1Q) and UDP layer. The common header of the message has 4 bytes fixed length, and the message payload layers are different based on the type field. Now only type #0, #2 and #5 will be supported, and 2 bytes are n

[dpdk-dev] [PATCH 4/5] net/mlx5: adding Devx command for flex parsers

2020-07-08 Thread Bing Zhao
From: Netanel Gonen In order to use dynamic flex parser to parse protocols that is not supported natively, two steps are needed. Firstly, creating the parse graph node. There are three parts of the flex parser: node, arc and sample. Node is the whole structure of a flex parser, when creating, th

[dpdk-dev] [PATCH 0/5] add eCPRI support in mlx5 driver

2020-07-08 Thread Bing Zhao
This patch set is to add the eCPRI support of flow rules in mlx5 PMD driver. Right now, only eCPRI over Ethernet layer (including VLAN) is supported. eCPRI over UDP will be supported in the future. If the flow rule to be inserted is not supported, PMD driver will return error to indicate the reason

[dpdk-dev] [PATCH 3/5] net/mlx5: add flex parser devx structures

2020-07-08 Thread Bing Zhao
The structures and other definitions will be used for the dynamic flex parser creation via Devx command interface. These structures will be used as some some intermediate variables and input parameters for the parser creation API. It is better to keep all members consistent with the PRM definition

[dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of eCPRI header

2020-07-08 Thread Bing Zhao
In the translation stage, the eCPRI item should be translated into the format that lower layer driver could use. All the fields that need to matched must be in network byte order after translation, as well as the mask. Since the header in the item belongs to the network layers stack, and the input

[dpdk-dev] [PATCH 1/5] net/mlx5: add flow validation of eCPRI header

2020-07-08 Thread Bing Zhao
When creating a flow with eCPRI header item, the validation of it is mandatory. The detailed limitations are listed below: 1. Over Ether / VLAN, ethertype must be 0xAEFE. 2. No tunnel support is described in the specification now. 3. L3 layer is only supported when L4 is UDP, see #4. 4. Ove

  1   2   3   >