Re: [dpdk-dev] [PATCH] crypto/qat: add data-path APIs

2020-06-25 Thread Jerin Jacob
On Fri, Jun 12, 2020 at 8:10 PM Fan Zhang wrote: > > This patch adds data-path APIs to QAT symmetric dirver to support > raw data as input. > > For applications/libraries that want to benefit from the data-path > encryption acceleration provided by QAT but not necessarily depends > on DPDK data-pa

Re: [dpdk-dev] [RFC PATCH 3/3] net/pcap: support hardware Tx timestamps

2020-06-25 Thread Olivier Matz
On Thu, Jun 25, 2020 at 03:01:19PM -0400, Vivien Didelot wrote: > When hardware timestamping is enabled on Rx path, system time should > no longer be used to calculate the timestamps when dumping packets. > > Instead, use the value stored by the driver in mbuf->timestamp > and assume it is already

Re: [dpdk-dev] [RFC PATCH 1/3] net/mlx5: add timestamp-to-ns converter from libibverbs

2020-06-25 Thread Olivier Matz
Hi Vivien, On Thu, Jun 25, 2020 at 03:01:17PM -0400, Vivien Didelot wrote: > From: Patrick Keroulas > > While some devices update their own clock info to provide current time, > mlx5dv part of libibverbs already handles this and also converts any > raw counter cycle to nanoseconds. > > Signed-o

Re: [dpdk-dev] [PATCH v5] net/octeontx2: add devargs to lock Rx/Tx ctx

2020-06-25 Thread Jerin Jacob
On Tue, Mar 31, 2020 at 7:29 PM wrote: > > From: Pavan Nikhilesh > > Add device arguments to lock Rx/Tx contexts. > Application can either choose to lock Rx or Tx contexts by using > 'lock_rx_ctx' or 'lock_tx_ctx' respectively per each port. > > Example: > -w 0002:02:00.0,lock_rx_ctx=1 -w

Re: [dpdk-dev] [PATCH 6/6] doc/guides: update qede features list

2020-06-25 Thread Jerin Jacob
On Wed, Jun 10, 2020 at 1:15 AM Manish Chopra wrote: > > Add SR-IOV PF entry in supported features > > Signed-off-by: Manish Chopra > Signed-off-by: Igor Russkikh > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/features/qede.ini | 1 + > doc/guides/nics/qede.rst | 2 +- Please sq

Re: [dpdk-dev] [PATCH 1/6] net/qede: define PCI config space specific osals

2020-06-25 Thread Jerin Jacob
On Wed, Jun 10, 2020 at 1:13 AM Manish Chopra wrote: > > This patch defines various PCI config space access APIs > in order to read and find IOV specific PCI capabilities. > > With these definitions implemented, it enables the base > driver to do SR-IOV specific initialization and HW specific > co

Re: [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix non-EAL thread support

2020-06-25 Thread Jerin Jacob
On Tue, Jun 16, 2020 at 3:19 PM Liron Himi wrote: > > > Acked-by: Liron Himi Applied to dpdk-next-net-mrvl/master. Thanks > > -Original Message- > From: David Marchand > Sent: Tuesday, 16 June 2020 12:47 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Liron Himi ; Natalie Samsonov > > S

Re: [dpdk-dev] [PATCH] net/qede: fix multicast pkts drop in promisc mode

2020-06-25 Thread Jerin Jacob
On Thu, Jun 18, 2020 at 1:40 PM Devendra Singh Rawat wrote: > > After enabling promiscuous mode all packets whose destination MAC address > is a multicast address were being dropped. This fix configures H/W to > receive all traffic in promiscuous mode. Promiscuous mode also overrides > allmulticas

Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function

2020-06-25 Thread Chautru, Nicolas
> From: Thomas Monjalon > 25/06/2020 02:30, Chautru, Nicolas: > > > From: Thomas Monjalon : > > > 02/05/2020 01:15, Chautru, Nicolas: > > > > Hi Akhil, Thomas, > > > > > > > > Following up on that previous discussion below so that to confirm > > > > whether > > > there is an available option to ha

Re: [dpdk-dev] Promiscuous Mode Feature

2020-06-25 Thread Ajit Khaparde
On Wed, Jun 24, 2020 at 1:03 PM Thomas Monjalon wrote: > Hi, > > A bit of context: David is going to implement a test in DTS > for promiscuous mode: > http://doc.dpdk.org/guides/nics/features.html#promiscuous-mode > > 24/06/2020 18:18, David Liu: > > Hi all, > > > > From my understanding, the pro

[dpdk-dev] [PATCH] maintainers: update for vmbus

2020-06-25 Thread Long Li
From: Long Li Add Long Li as additional maintainer. Signed-off-by: Long Li --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e739b87ea..15485c97c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -517,6 +517,7 @@ F: drivers/bus/vdev/ VMBUS bus d

[dpdk-dev] [PATCH v2 2/4] doc: remove build instructions where unneeded

2020-06-25 Thread Thomas Monjalon
The build should be described only in few places, in order to maintain up-to-date, accurate and detailed instructions. This change is removing some of the unneeded repetitions. Signed-off-by: Thomas Monjalon Acked-by: Ajit Khaparde Acked-by: Jay Zhou Acked-by: Bruce Richardson --- v2: fix unre

[dpdk-dev] [PATCH v2 4/4] mk: add a paused deprecation warning before each build

2020-06-25 Thread Thomas Monjalon
DPDK 20.05 had some deprecation notes after "make config" and after the build. For DPDK 20.08, the config note is replaced with a warning before the config and before the build. After the warning, there is a pause which can be skipped with the variable MAKE_PAUSE. This deprecation process was disc

[dpdk-dev] [PATCH v2 0/4] one more step in makefiles deprecation

2020-06-25 Thread Thomas Monjalon
Some "make" usages are cleaned up in the documentation, and an inevitable deprecation warning is printed when using "make". * NOTE: Lots of docs must be converted to meson build, configuration and installation layout, as soon as possible. Please HELP!

[dpdk-dev] [PATCH v2 3/4] doc: update build instructions in the Linux guide

2020-06-25 Thread Thomas Monjalon
Before removing the "make" build system completely, the Linux guide instructions are made more concise and accurate. Some detailed explanations are also available in doc/guides/prog_guide/dev_kit_root_make_help.rst This is the swan song for makefile system, in order to have accurate information ba

[dpdk-dev] [PATCH v2 1/4] doc: remove outdated guidelines for library addition

2020-06-25 Thread Thomas Monjalon
There was a doc about how to extend DPDK by adding a library. It could have been useful but was never updated, so it is lacking a lot of explanations about doxygen, meson, versioning, maintainership, etc. Anyway such guidelines should fit in the contributors guide. Better to completely remove this

[dpdk-dev] DPDK Virtio PMD RX RSS support?

2020-06-25 Thread Vincent Li
Hi, I found Qemu start to support virtio-net RX RSS: List: qemu-devel Subject:[PULL V2 02/33] virtio-net: implement RX RSS processing From: Jason Wang Date: 2020-06-18 13:21:17 Message-ID: 1592486508-6135-3-git-send-email-jasowang () redhat ! com [Download RAW message or

Re: [dpdk-dev] [PATCH 0/5] small fixes for mbuf's dynamic field/flag feature

2020-06-25 Thread Thomas Monjalon
13/06/2020 17:49, Xiaolong Ye: > This series contains some small fixes and enhancement for mbuf's > dynamic field/flag feature. > > Xiaolong Ye (5): > mbuf: fix out-of-bounds access at dyn field register > mbuf: fix missing errno for dyn field/flag registration > mbuf: fix free_space setting

[dpdk-dev] [PATCH 3/3] rib: add C++ include guard

2020-06-25 Thread Stephen Hemminger
All include files should be safe from C++ Fixes: 5a5793a5ffa2 ("rib: add RIB library") Fixes: f7e861e21c46 ("rib: support IPv6") Signed-off-by: Stephen Hemminger --- lib/librte_rib/rte_rib.h | 8 lib/librte_rib/rte_rib6.h | 10 +- 2 files changed, 17 insertions(+), 1 deletion(

[dpdk-dev] [PATCH 1/3] rib: constify arguments

2020-06-25 Thread Stephen Hemminger
The getter functions should take a constant pointer to make it clear that node is not modified. The rib create functions do not modify their config structure. Mark the config as constant so that programs can pass simple constant data. Signed-off-by: Stephen Hemminger --- lib/librte_rib/rte_rib.

[dpdk-dev] [PATCH 0/3] rib: minor fixes

2020-06-25 Thread Stephen Hemminger
Some minor updates to the RIB library to fix issues found while reviewing and trying it out. Stephen Hemminger (3): rib: constify arguments rib: check for invalid max_nodes rib: add C++ include guard lib/librte_rib/rte_rib.c | 11 +-- lib/librte_rib/rte_rib.h | 17 +--

[dpdk-dev] [PATCH 2/3] rib: check for invalid max_nodes

2020-06-25 Thread Stephen Hemminger
Max_nodes in config is signed, but a negative value makes no sense. Get rid of extra BSD style parens. Signed-off-by: Stephen Hemminger --- lib/librte_rib/rte_rib.c | 3 +-- lib/librte_rib/rte_rib6.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_rib/rte_rib.

[dpdk-dev] [PATCH] maintainers: update for netvsc

2020-06-25 Thread longli
From: Long Li Add Long Li as additional maintainer. Signed-off-by: Long Li --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 15485c97c..9d63a128a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -775,6 +775,7 @@ Microsoft Hyper-V netvsc - EXPERIME

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-25 Thread Medvedkin, Vladimir
Hi Yipeng, Thanks for the review. See below On 24/06/2020 02:19, Wang, Yipeng1 wrote: -Original Message- From: Medvedkin, Vladimir Sent: Friday, May 8, 2020 12:59 PM To: dev@dpdk.org Cc: Ananyev, Konstantin ; Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce Subject: [PATCH v4 1/4]

Re: [dpdk-dev] Speed Capabilities Feature

2020-06-25 Thread Daniel Kirichok
On Thu, Jun 25, 2020 at 3:52 AM Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, June 24, 2020 10:09 PM > > > > 24/06/2020 22:01, Lincoln Lavoie: > > > Inline. > > > > > > On Wed, Jun 24, 2020 at 3:55 PM Thomas Monjalon > > wrote: > > > > > > > Hi,

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-25 Thread Medvedkin, Vladimir
On 24/06/2020 00:06, Ananyev, Konstantin wrote: Hi Vladimir, --- /dev/null +++ b/lib/librte_hash/k32v64_hash.c @@ -0,0 +1,277 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2020 Intel Corporation + */ + +#include + +#include +#include +#include + +#include "k32v64_hash.h" +

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-25 Thread Medvedkin, Vladimir
Hi Konstantin, Thanks for the review. See below On 23/06/2020 16:44, Ananyev, Konstantin wrote: Hi Vladimir, --- /dev/null +++ b/lib/librte_hash/k32v64_hash.c @@ -0,0 +1,277 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2020 Intel Corporation + */ + +#include + +#include +#

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-25 Thread Thomas Monjalon
25/06/2020 19:55, Jerin Jacob: > On Thu, Jun 25, 2020 at 10:20 PM Jiawei Wang wrote: > > > > When using full offload, all traffic will be handled by the HW, and > > directed to the requested vf or wire, the control application loses > > visibility on the traffic. > > So there's a need for an actio

[dpdk-dev] [PATCH v5] eal/windows: fix thread handle

2020-06-25 Thread Tasnim Bashar
Casting thread ID to handle is not accurate way to get thread handle. Need to use OpenThread function to get thread handle from thread ID. pthread_setaffinity_np and pthread_getaffinity_np functions for Windows are affected because of it. Signed-off-by: Tasnim Bashar --- lib/librte_eal/windows/

Re: [dpdk-dev] [PATCH v4] eal/windows: fix thread handle

2020-06-25 Thread Tasnim Bashar
> From: Ranjit Menon > Sent: Wednesday, June 24, 2020 5:39 PM > To: Tasnim Bashar ; dev@dpdk.org > Cc: harini.ramakrish...@microsoft.com; pallavi.ka...@intel.com; > ocard...@microsoft.com; navas...@linux.microsoft.com; > dmitry.kozl...@gmail.com; Tal Shnaiderman ; Fady > Bader ; Ophir Munk ; Thom

Re: [dpdk-dev] [PATCH v4] bus/pci: fix VF bus error for memory access

2020-06-25 Thread Wang, Haiyue
> -Original Message- > From: Kevin Traynor > Sent: Friday, June 26, 2020 00:46 > To: David Marchand ; Wang, Haiyue > ; Luca Boccassi > > Cc: dev ; Burakov, Anatoly ; dpdk > stable ; > Harman Kalra > Subject: Re: [PATCH v4] bus/pci: fix VF bus error for memory access > > On 25/06/2020

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-25 Thread Jerin Jacob
On Thu, Jun 25, 2020 at 10:20 PM Jiawei Wang wrote: > > When using full offload, all traffic will be handled by the HW, and > directed to the requested vf or wire, the control application loses > visibility on the traffic. > So there's a need for an action that will enable the control application

[dpdk-dev] [PATCH 7/8] net/mlx5: update the metadata register c0 support

2020-06-25 Thread Jiawei Wang
For Sample flow, it splits into two sub flows and using metadata register as matcher between two flows. Meatadata register C0 filed might be also used for source vport index if kernel uses this field, this changes add the checking while do tag action with reg_c0 to decide using upper or lower 16-b

[dpdk-dev] [PATCH 6/8] net/mlx5: update translate function for sample action

2020-06-25 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list, then create the sample DR action. Signed-off-by: Jiawei Wang --- drivers/net/mlx5/mlx5_flow.c| 16 +- drivers/net/mlx5/mlx5_flow.h| 14 +- drivers/net/mlx5/mlx5_flow_dv.c | 502

[dpdk-dev] [PATCH 8/8] app/testpmd: add testpmd command for sample action

2020-06-25 Thread Jiawei Wang
Add a new testpmd command 'set sample_actions' that supports the multiple sample actions list configuration by using the index: set sample_actions The examples for the sample flow use case and result as below: 1. set sample_actions 0 mark id 0x8 / queue index 2 / end .. pattern eth / end action

[dpdk-dev] [PATCH 5/8] net/mlx5: split sample flow into two sub flows

2020-06-25 Thread Jiawei Wang
Add the sampler action resource structs definition. The flow with sample action will be splited into two sub flows, the prefix flow with sample action, the suffix flow with the left actions. For the prefix flow, add the extra the tag action with unique id to metadata register, and suffix flow wil

[dpdk-dev] [PATCH 3/8] common/mlx5: query sampler object capability via DevX

2020-06-25 Thread Jiawei Wang
Update function mlx5_devx_cmd_query_hca_attr() to add the NIC Flow Table attributes query, then get the log_max_flow_sampler_num from flow table properties. Add the related structs definition in mlx5_prm.h. Signed-off-by: Jiawei Wang --- drivers/common/mlx5/mlx5_devx_cmds.c | 27 +++

[dpdk-dev] [PATCH 2/8] common/mlx5: glue for default miss and sample action

2020-06-25 Thread Jiawei Wang
rdma-core introduce two new DR action: default miss and sample action. Add the rdma-core commands in glue to create these two actions. Default miss action is used for the sampled packet on FDB domain, it steering packet to eswitch manager vport. Sample action is used for creating the sample obje

[dpdk-dev] [PATCH 4/8] net/mlx5: add the validate sample action

2020-06-25 Thread Jiawei Wang
Add sample action validate function. For Sample flow support NIC-RX and FDB domain, must include an action of a dest TIR in NIC_RX or DEFAULT_MISS in FDB. Only NIC_RX support with addition optinal actions. Signed-off-by: Jiawei Wang --- drivers/net/mlx5/linux/mlx5_os.c | 14 + drivers/net

[dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-25 Thread Jiawei Wang
When using full offload, all traffic will be handled by the HW, and directed to the requested vf or wire, the control application loses visibility on the traffic. So there's a need for an action that will enable the control application some visibility. The solution is introduced a new action that

[dpdk-dev] [PATCH 0/8] support the flow-based traffic sampling

2020-06-25 Thread Jiawei Wang
This patch set implement the flow sampling for mlx5 driver. The solution is introduced a new rte_flow action that will sample the incoming traffic and send a duplicated traffic in some predefined ratio to the application, while the original packet will continue to the target destination. If the s

Re: [dpdk-dev] [PATCH v4] bus/pci: fix VF bus error for memory access

2020-06-25 Thread Kevin Traynor
On 25/06/2020 15:09, David Marchand wrote: > On Thu, Jun 25, 2020 at 6:00 AM Haiyue Wang wrote: >> >> To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps >> and block MMIO access on disabled memory, it will send a SIGBUS to the >> application: >> https://git.kernel.org/pub/scm/l

Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-25 Thread Olivier Matz
Hi Vivien, On Tue, Jun 23, 2020 at 06:10:09PM -0400, Vivien Didelot wrote: > > On Wed, Jun 17, 2020 at 4:16 AM Ferruh Yigit wrote: > > > On 6/10/2020 8:39 PM, Vivien Didelot wrote: > > > When hardware timestamping is enabled on Rx path, system time should > > > no longer be used to calculate th

Re: [dpdk-dev] [PATCH 00/13] rte_log registration usage improvement

2020-06-25 Thread Dybkowski, AdamX
> > -Original Message- > > From: dev On Behalf Of jer...@marvell.com > > Sent: Wednesday, 17 June, 2020 08:31 > > To: dev@dpdk.org > > Cc: tho...@monjalon.net; olivier.m...@6wind.com; > > david.march...@redhat.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH 00/13] rte_log registration usa

Re: [dpdk-dev] [PATCH 00/13] rte_log registration usage improvement

2020-06-25 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, 17 June, 2020 08:31 > To: dev@dpdk.org > Cc: tho...@monjalon.net; olivier.m...@6wind.com; > david.march...@redhat.com; Jerin Jacob > Subject: [dpdk-dev] [PATCH 00/13] rte_log registration usage improvement

[dpdk-dev] [PATCH 2/2] ethdev: tunnel offload model

2020-06-25 Thread Gregory Etelson
From: Eli Britstein Hardware vendors implement tunneled traffic offload techniques differently. Although RTE flow API provides tools capable to offload all sorts of network stacks, software application must reference this hardware differences in flow rules compilation. As the result tunneled traf

[dpdk-dev] [PATCH 0/2] ethdev: tunnel offload model

2020-06-25 Thread Gregory Etelson
Hardware vendors implement tunneled traffic offload techniques differently. Although RTE flow API provides tools capable to offload all sorts of network stacks, software application must reference this hardware differences in flow rules compilation. As the result tunneled traffic flow rules that ut

[dpdk-dev] [PATCH 1/2] ethdev: allow negative values in flow rule types

2020-06-25 Thread Gregory Etelson
RTE flow items & actions use positive values in item & action type. Negative values are reserved for PMD private types. PMD items & actions usually are not exposed to application and are not used to create RTE flows. The patch allows applications with access to PMD flow items & actions ability to

Re: [dpdk-dev] [PATCH 5/5] mbuf: support to dump free_flags for dynamic flag

2020-06-25 Thread Olivier Matz
On Sat, Jun 13, 2020 at 11:49:21PM +0800, Xiaolong Ye wrote: > Add support to dump free_flags as below format: > > Free bit in mbuf->ol_flags (0 = occupied, 1 = free): > : 0 0 0 0 0 0 0 0 > 0008: 0 0 0 0 0 0 0 0 > 0010: 0 0 0 0 0 0 0 1 > 0018: 1 1 1 1 1 1 1 1 > 0020: 1 1 1 1 1 1 1 1

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-25 Thread Owen Hilyard
I can do that. Thanks for the clarification On Thu, Jun 25, 2020 at 11:25 AM Thomas Monjalon wrote: > > > I think you should describe all the protocols you want to test. > > > > Could you please elaborate on this? > > I mean doing a test matrix inluding IP, TCP, UDP, VXLAN, GENEVE, etc. > > >

Re: [dpdk-dev] [PATCH 4/5] mbuf: fix a dynamic field dump log

2020-06-25 Thread Olivier Matz
On Sat, Jun 13, 2020 at 11:49:20PM +0800, Xiaolong Ye wrote: > For each mbuf byte, free_space[i] == 0 means the space is occupied, > free_space[i] != 0 means space is free. > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaolong Ye Ac

Re: [dpdk-dev] [PATCH 3/5] mbuf: fix free_space setting for dynamic field

2020-06-25 Thread Olivier Matz
On Sat, Jun 13, 2020 at 11:49:19PM +0800, Xiaolong Ye wrote: > The value free_space[i] is used to save the size of biggest aligned > element that can fit in the zone, current implementation has one flaw, > for example, if user registers dynfield1 (size = 4, align = 4, req = 124) > first, the free_s

[dpdk-dev] rte_ether_addr_copy() strange comment

2020-06-25 Thread Morten Brørup
The function rte_ether_addr_copy() checks for __INTEL_COMPILER and has a comment about "a strange gcc warning". It says: static inline void rte_ether_addr_copy(const struct rte_ether_addr *ea_from, struct rte_ether_addr *ea_to) { #ifdef __INTEL_COMPILER

Re: [dpdk-dev] [PATCH v2] net/octeontx2: add cn98xx support

2020-06-25 Thread Jerin Jacob
On Wed, Jun 24, 2020 at 6:17 PM Harman Kalra wrote: > > New cn98xx SOC comes up with two NIX blocks wrt > cn96xx, cn93xx, to achieve higher performance. > Also the no of cores increased to 36 from 24. > > Adding support for cn98xx where need a logic to > detect if the LF is attached to NIX0 or NIX

Re: [dpdk-dev] [PATCH 2/5] mbuf: fix missing errno for dyn field/flag registration

2020-06-25 Thread Olivier Matz
On Sat, Jun 13, 2020 at 11:49:18PM +0800, Xiaolong Ye wrote: > Set rte_errno as ENOMEM when allocation failure. > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaolong Ye Good catch, I was wrongly expecting that rte_malloc() functions

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-25 Thread Thomas Monjalon
> > I think you should describe all the protocols you want to test. > > Could you please elaborate on this? I mean doing a test matrix inluding IP, TCP, UDP, VXLAN, GENEVE, etc.

[dpdk-dev] [PATCH v2 2/3] eal: export needed functions for mbuf

2020-06-25 Thread talshn
From: Tal Shnaiderman Export needed eal functions used by the lib. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/

[dpdk-dev] [PATCH v2 3/3] mbuf: build on Windows

2020-06-25 Thread talshn
From: Tal Shnaiderman Build the lib for Windows. Signed-off-by: Tal Shnaiderman --- lib/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index a9a5be0e5e..dcee2e68ec 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -39,8

[dpdk-dev] [PATCH v2 1/3] eal: correct OS headers in rte_byteorder.h

2020-06-25 Thread talshn
From: Tal Shnaiderman Inclusion of the endian.h header is set only for Linux OS. Windows endlessness will be determined by the predefined __BYTE_ORDER__ macro. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/include/generic/rte_byteorder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[dpdk-dev] [PATCH v2 0/3] Support librte_mbuf on Windows

2020-06-25 Thread talshn
From: Tal Shnaiderman This patchset enables compilation and build of librte_mbuf on Windows. --- Depends-on: series-10550 ("build mempool on Windows") v2: * Remove unneeded endianness macro check (ThomasM) * Fix export list name order (ThomasM) * Remove __emutls_v.* MinGW export as it is no lo

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-25 Thread Owen Hilyard
Hello, In regards to the outer layers, having grepped through the code for "[\w_]+_GOOD|[\w_]+_BAD", I wasn't able to find the flags that I expected. I expected something like PKT_RX_OUTER_IP_CKSUM_BAD and PKT_RX_OUTER_IP_CKSUM_GOOD to show up since that seems to be the format for flags to be prin

Re: [dpdk-dev] [PATCH v9 02/10] eal: move OS common options functions

2020-06-25 Thread Thomas Monjalon
24/06/2020 10:28, tal...@mellanox.com: > From: Tal Shnaiderman > > Move common functions between Unix and Windows to eal_common_options.c. > > Those functions are getter functions for rte_application_usage_hook. [...] > +/* Return a pointer to rte_usage_hook_t */ > +rte_usage_hook_t * Why not r

Re: [dpdk-dev] [PATCH v4] bus/pci: fix VF bus error for memory access

2020-06-25 Thread David Marchand
On Thu, Jun 25, 2020 at 3:59 PM Thierry MARTIN wrote: > > Tested-by: Thierry MARTIN > Thanks for testing. The only issue is that this mail is missing a in-reply-to reference, but I added your tag when applying the fix. -- David Marchand

Re: [dpdk-dev] [PATCH v9 01/10] eal: move OS common config objects

2020-06-25 Thread Thomas Monjalon
24/06/2020 10:28, tal...@mellanox.com: > +void Could check the size in the function and return an error and log, instead of doing the check prior the call. > +eal_set_runtime_dir(char *run_dir, size_t size) > +{ > + strncpy(runtime_dir, run_dir, size); strlcpy would be better [...] > +void

Re: [dpdk-dev] [PATCH v4] bus/pci: fix VF bus error for memory access

2020-06-25 Thread David Marchand
On Thu, Jun 25, 2020 at 6:00 AM Haiyue Wang wrote: > > To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps > and block MMIO access on disabled memory, it will send a SIGBUS to the > application: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abaf

Re: [dpdk-dev] Promiscuous Mode Feature

2020-06-25 Thread Lincoln Lavoie
Small bit of context here, the described case already exists in the DTS Dynamic Config tests. So, would the other corner cases and "modes" justify additional test case development, etc. On Wed, Jun 24, 2020 at 4:03 PM Thomas Monjalon wrote: > Hi, > > A bit of context: David is going to implemen

[dpdk-dev] [PATCH] net/af_xdp: revert change to SP/SC ring for copy mode

2020-06-25 Thread Ciara Loftus
This reverts commit 489e0b5b33209d929dc490cc591abd840dcefdfc. The ring used in copy mode should be multi-producer multi-consumer because enqueues and dequeues to the ring are performed on both the rx and tx paths, which can be running on different threads. Fixes: 489e0b5b3320 ("net/af_xdp: use si

Re: [dpdk-dev] [PATCH v4] bus/pci: fix VF bus error for memory access

2020-06-25 Thread Thierry MARTIN
Tested-by: Thierry MARTIN

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-25 Thread Maxime Coquelin
On 6/18/20 7:50 AM, Liu, Yong wrote: > Thanks, Patrick. So comments are inline. > >> -Original Message- >> From: dev On Behalf Of patrick...@intel.com >> Sent: Thursday, June 11, 2020 6:02 PM >> To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo >> ; Wang, Zhihong ; Ye, >> Xiaol

[dpdk-dev] [PATCH v2 5/5] vdpa/mlx5: support queue update

2020-06-25 Thread Matan Azrad
Last changes in vDPA device management by vhost library may cause queue ready state update after the device configuration. So, there is chance that some queue configuration information will be known only after the device was configured. Add support to reconfigure a queue after the device configur

[dpdk-dev] [PATCH v2 4/5] vhost: notify virtq file descriptor update

2020-06-25 Thread Matan Azrad
When virtq call or kick file descriptors are changed in the device configuration when the queue is ready, the application and the vDPA driver should be notified to be aligned to the new file descriptors. Notify the state to be disabled before the file descriptor update and return it back to be ena

[dpdk-dev] [PATCH v2 0/5] vhost: improve ready state

2020-06-25 Thread Matan Azrad
Due to the issue described in "vhost: improve device ready definition" patch here, we need to change the ready state definition in vhost device. To support the suggestion improvement there is update for the host notifier control API. Also need to skip access lock when vDPA device is configured.

[dpdk-dev] [PATCH v2 3/5] vhost: handle memory hotplug with vDPA devices

2020-06-25 Thread Matan Azrad
Some vDPA drivers' basic configurations should be updated when the guest memory is hotplugged. Close vDPA device before hotplug operation and recreate it after the hotplug operation is done. Signed-off-by: Matan Azrad --- lib/librte_vhost/vhost_user.c | 9 + 1 file changed, 9 insertions

[dpdk-dev] [PATCH v2 2/5] vhost: improve device readiness notifications

2020-06-25 Thread Matan Azrad
Some guest drivers may not configure disabled virtio queues. In this case, the vhost management never notifies the application and the vDPA device readiness because it waits to the device to be ready. The current ready state means that all the virtio queues should be configured regardless the ena

[dpdk-dev] [PATCH v2 1/5] vhost: skip access lock when vDPA is configured

2020-06-25 Thread Matan Azrad
No need to take access lock in the vhost-user message handler when vDPA driver controls all the data-path of the vhost device. It allows the vDPA set_vring_state operation callback to configure guest notifications. Signed-off-by: Matan Azrad Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vh

[dpdk-dev] [dpdk-dev v2 2/3] test/crypto: add unit-test for QAT direct APIs

2020-06-25 Thread Fan Zhang
This patch adds the test to use QAT symmetric crypto direct APIs. The test will be enabled only when QAT Sym PMD is built. Signed-off-by: Fan Zhang --- app/test/Makefile | 4 + app/test/meson.build | 1 + app/test/test_cryptodev.c | 371 ++

[dpdk-dev] [dpdk-dev v2 3/3] doc: add QAT direct APIs guide

2020-06-25 Thread Fan Zhang
This patch updates programmer's guide to demonstrate the usage and limitations of QAT symmetric crypto data-path APIs. Signed-off-by: Fan Zhang --- doc/guides/prog_guide/cryptodev_lib.rst | 272 1 file changed, 272 insertions(+) diff --git a/doc/guides/prog_guide/crypto

[dpdk-dev] [PATCH 3/5] ethdev: remove structs from export list

2020-06-25 Thread Fady Bader
Some ethdev structs were present in ethdev export list. There structs were removed from the export list. Signed-off-by: Fady Bader --- lib/librte_ethdev/rte_ethdev_version.map | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_e

[dpdk-dev] [dpdk-dev v2 1/3] crypto/qat: add data-path APIs

2020-06-25 Thread Fan Zhang
This patch adds data-path APIs to QAT symmetric dirver to support raw data as input. This patch depends on patch-72157 ("cryptodev: add function to check if qp was setup") Signed-off-by: Fan Zhang Signed-off-by: Piotr Bronowski --- drivers/common/qat/Makefile | 8 +- drivers

[dpdk-dev] [PATCH 2/5] eal: updated export list for Windows

2020-06-25 Thread Fady Bader
Added eal functions used by ethdev lib to the export list under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 20f7346962..3b9

[dpdk-dev] [dpdk-dev v2 0/3] crypto/qat: add symmetric crypto data-path APIs

2020-06-25 Thread Fan Zhang
This patch adds symmetric crypto data-path APIs for QAT PMD. QAT direct symmetric crypto data-path APIs are a set of APIs that provide more HW friendly enqueue/dequeue data-path functions as an alternative approach to ``rte_cryptodev_enqueue_burst`` and ``rte_cryptodev_dequeue_burst``. The APIs are

[dpdk-dev] [PATCH 0/5] compiling ethdev lib under windows

2020-06-25 Thread Fady Bader
Added needed changes in order to get ethdev compiling under windows. Depends-on: series-10382 ("compile librte_net for windows") Fady Bader (5): eal: added interrupts empty stubs eal: updated export list for Windows ethdev: remove structs from export list telemetry: implement empty stubs

[dpdk-dev] [PATCH v2 3/3] vdpa/mlx5: control completion queue event mode

2020-06-25 Thread Matan Azrad
The CQ polling is necessary in order to manage guest notifications when the guest doesn't work with poll mode (callfd != -1). The CQ polling scheduling method can affect the host CPU utilization and the traffic bandwidth. Define 3 modes to control the CQ polling scheduling: 1. A timer thread whi

[dpdk-dev] [PATCH 5/5] ethdev: compiling ethdev under Windows

2020-06-25 Thread Fady Bader
Compiling needed libraries for ethdev under Windows. Signed-off-by: Fady Bader --- lib/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index 6317309ecf..34366cd614 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -37,9

[dpdk-dev] [PATCH v2 2/3] vdpa/mlx5: optimize completion queue poll

2020-06-25 Thread Matan Azrad
The vDPA driver uses a CQ in order to know when traffic works were completed by the HW. Each traffic burst completion adds a CQE to the CQ. When the vDPA driver detects CQEs in the CQ, it triggers the guest notification for the corresponding queue and consumes all of them. There is collapse feat

[dpdk-dev] [PATCH 1/5] eal: added interrupts empty stubs

2020-06-25 Thread Fady Bader
The ethdev lib uses interrupts. Interrupts are not implemented for Windows. To solve this, empty interrupt stubs were added under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal_interrupts.c | 17 + lib/librte_eal/windows/meson.build | 1 + 2 files changed

[dpdk-dev] [PATCH 4/5] telemetry: implement empty stubs for Windows

2020-06-25 Thread Fady Bader
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader --- lib/librte_telemetry/rte_telemetry.h| 4 +++ lib/librte_telemetry/telemetry.c| 43 - lib/librte_telemetry/telemetry_legacy.c | 26 +

[dpdk-dev] [PATCH v2 0/3] vdpa/mlx5: optimize cpu utilization

2020-06-25 Thread Matan Azrad
Defines new event modes in order to schedule CQ polling. Timer thread is created in mode 0 and 1 in order to save CPU utilization. v2: Add devargs to control the events mode. Matan Azrad (3): vdpa/mlx5: optimize notification events vdpa/mlx5: optimize completion queue poll vdpa/mlx5: cont

[dpdk-dev] [PATCH v2 1/3] vdpa/mlx5: optimize notification events

2020-06-25 Thread Matan Azrad
When the virtio guest driver doesn't work with poll mode, the driver creates event mechanism in order to schedule completion notifications for each virtq burst traffic. When traffic comes to a virtq, a CQE will be added to the virtq CQ by the FW. The driver requests interrupt for the next CQE inde

Re: [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to little endian

2020-06-25 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to little > endian > > 01/06/2020 11:38, tal...@mellanox.com: > > From: Tal Shnaiderman > > > > Set the endianness in Windows to RTE_LITTLE_ENDIAN as support for > > Windows is limited to x86 architecture for now. > > > > Signed-

Re: [dpdk-dev] [PATCH v9 05/10] pci: fix format warning on Windows

2020-06-25 Thread Thomas Monjalon
24/06/2020 10:28, tal...@mellanox.com: > From: Tal Shnaiderman > > the struct rte_pci_addr defines domain as uint32_t variable however > the PCI_PRI_FMT macro used for logging the struct sets the format > of domain to uint16_t. > > The mismatch causes the following warning messages > in Windows

Re: [dpdk-dev] [PATCH v2 5/9] usertools/cpu_layout: support python3 only

2020-06-25 Thread Burakov, Anatoly
On 17-Jun-20 4:10 PM, Louise Kilheeney wrote: Changed script to explicitly use python3 only to avoid maintaining python 2. Signed-off-by: Louise Kilheeney --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 3/9] usertools/dpdk-telemetry-client: support python3 only

2020-06-25 Thread Burakov, Anatoly
On 17-Jun-20 4:10 PM, Louise Kilheeney wrote: Changed script to explicitly use python3 only to avoid maaintaining python 2. Cc: Kevin Laatz Signed-off-by: Louise Kilheeney --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 2/9] usertools/dpdk-devbind: support python3 only

2020-06-25 Thread Burakov, Anatoly
On 17-Jun-20 4:10 PM, Louise Kilheeney wrote: Changed script to explicitly use python3 only to avoid maintaining python 2. Signed-off-by: Louise Kilheeney --- v2: removed check_output function as not required for python3. --- usertools/dpdk-devbind.py | 17 - 1 file changed,

Re: [dpdk-dev] [PATCH v2 1/9] app/test-bbdev: support python3 only

2020-06-25 Thread Burakov, Anatoly
On 17-Jun-20 4:10 PM, Louise Kilheeney wrote: Changed script to explicitly use python3 only to avoid maintaining python 2. Cc: Nicolas Chautru Signed-off-by: Louise Kilheeney Acked-by: Nicolas Chautru --- app/test-bbdev/test-bbdev.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletio

Re: [dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-06-25 Thread Andrew Rybchenko
On 5/29/20 8:43 AM, Stephen Hemminger wrote: > On Wed, 27 May 2020 15:31:41 +0100 > Andrew Rybchenko wrote: > >> SW VLAN insertion relies on Ethernet addresses location in contigous >> memory (do not split across mbuf segments). There is no any formal >> requirements on data location and mbuf str

Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-25 Thread Vivien Didelot
Hi Oliver, Surprisingly, dumping PCAP with hardware timestamps seems to be a niche, but we do need this feature for our network analyzing tool. Do you guys have objections for this patch? Regards, Vivien On Wed, Jun 17, 2020 at 4:16 AM Ferruh Yigit wrote: > On 6/10/2020 8:39 PM, Vivien Didel

[dpdk-dev] DPDK Release Status Meeting 25/06/2020

2020-06-25 Thread Ferruh Yigit
Minutes 25 June 2020 Agenda: * Release Dates * Subtrees * LTS * OvS * Opens Participants: * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.08 dates: * -rc1: Wednesday, 8 July 2020 * -rc2: Monday,

Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-06-25 Thread Ananyev, Konstantin
Hi everyone, > > > > Konstantin, Honnappa, > > Any update about a fix for compilation time please? > > +1 > A good amount of time waiting for builds is on this code. > Between 69567 and 69559: http://patches.dpdk.org/patch/69567/ http://patches.dpdk.org/patch/69559/ my preference is still 69559

Re: [dpdk-dev] [PATCH v16 2/2] eal: support for VFIO-PCI VF token

2020-06-25 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Thursday, June 25, 2020 15:33 > To: Harman Kalra ; Jerin Jacob Kollanukkaran > > Cc: Wang, Haiyue ; dev ; Burakov, Anatoly > ; Thomas Monjalon ; Andrew > Rybchenko > ; Maxime Coquelin > Subject: Re: [dpdk-dev] [PATCH v16 2/2] eal: sup

  1   2   >