[dpdk-dev] [PATCH v2 0/4] aarch32 compilation

2020-06-22 Thread Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these. When building with make, please refer to guide: http://patches.dpdk.org/patch/62820/ When building with meson, requires series: http://patches.dpdk.org/cover/69536/ [1] https://m

[dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-22 Thread Chengchang Tang
In common practice, PMD configure the rx_buf_size according to the data room size of the object in mempool. But in fact the final value is related to the specifications of hw, and its values will affect the number of fragments in recieving pkts. At present, we seem to have no way to espose relevan

Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file

2020-06-22 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to > single file > > Can we reduce the scope in the title? > This patch is about EAL config in general, so I would reword it to: > eal: move OS common config objects > Agree, will change in v9. > 22/06/2020 09:55, tal.

[dpdk-dev] [PATCH] doc: fix references to /dev/huge

2020-06-22 Thread Sarosh Arif
change /dev/huge to /dev/hugepages Bugzilla ID: 492 Signed-off-by: Sarosh Arif --- doc/guides/faq/faq.rst | 2 +- doc/guides/nics/thunderx.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index f19c1389b..bb1df7dc8 1

Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix features definition location

2020-06-22 Thread Xia, Chenbo
> -Original Message- > From: stable On Behalf Of Matan Azrad > Sent: Friday, June 19, 2020 3:08 AM > To: Maxime Coquelin > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] vhost: fix features definition location > > The vhost library provide an infrastructure in orde

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: integrate RCU QSBR

2020-06-22 Thread Honnappa Nagarahalli
> > > > > > On 08/06/2020 06:16, Ruifeng Wang wrote: > > > Currently, the tbl8 group is freed even though the readers might be > > > using the tbl8 group entries. The freed tbl8 group can be > > > reallocated quickly. This results in incorrect lookup results. > > > > > > RCU QSBR process is integ

Re: [dpdk-dev] [PATCH v2] net/ice: support based RSS configure

2020-06-22 Thread Jiang, JunyuX
Hi qi, > -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 22, 2020 10:37 PM > To: Jiang, JunyuX ; dev@dpdk.org > Cc: Yang, Qiming ; Su, Simei > Subject: RE: [PATCH v2] net/ice: support based RSS configure > > > > > -Original Message- > > From: Jiang, JunyuX > > Sen

[dpdk-dev] [PATCH v5 12/12] doc: enable DCF datapath configuration

2020-06-22 Thread Ting Xu
Add doc for DCF datapath configuration in DPDK 20.08 release note. Add "ice_dcf" driver features. Signed-off-by: Ting Xu --- doc/guides/nics/features/ice_dcf.ini | 19 +++ doc/guides/rel_notes/release_20_08.rst | 6 ++ 2 files changed, 25 insertions(+) create mode 100644

[dpdk-dev] [PATCH v5 10/12] net/ice: enable stats for DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Add support to get and reset Rx/Tx stats in DCF. Query stats from PF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 27 drivers/net/ice/ice_dcf.h| 4 ++ drivers/net/ice/ice_dcf_ethdev.c | 102 ++

[dpdk-dev] [PATCH v5 11/12] net/ice: set MAC filter during dev start for DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Add support to add and delete MAC address filter in DCF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 42 drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_ethdev.c | 7 ++ 3 files ch

[dpdk-dev] [PATCH v5 09/12] net/ice: add queue start and stop for DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Add queue start and stop in DCF. Support queue enable and disable through virtual channel. Add support for Rx queue mbufs allocation and queue reset. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 57 ++ drivers/net/ice/ice_dcf.h

[dpdk-dev] [PATCH v5 07/12] net/ice: init RSS during DCF start

2020-06-22 Thread Ting Xu
From: Qi Zhang Enable RSS initialization during DCF start. Add RSS LUT and RSS key configuration functions. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 117 +++ drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_

[dpdk-dev] [PATCH v5 06/12] net/ice: add Rx queue init in DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Enable Rx queues initialization during device start in DCF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_ethdev.c | 83 2 files changed, 84 insertions(+) diff --git a/driver

[dpdk-dev] [PATCH v5 08/12] net/ice: add queue config in DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Add queues and Rx queue irqs configuration during device start in DCF. The setup is sent to PF via virtchnl. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 111 +++ drivers/net/ice/ice_dcf.h| 6 ++ drivers

[dpdk-dev] [PATCH v5 03/12] net/ice: complete dev configure in DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Enable device configuration function in DCF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c i

[dpdk-dev] [PATCH v5 01/12] net/ice: init RSS and supported RXDID in DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Enable RSS parameters initialization and get the supported flexible descriptor RXDIDs bitmap from PF during DCF init. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c | 54 ++- drivers/net/ice/ice_dcf.h | 3 +++ 2

[dpdk-dev] [PATCH v5 05/12] net/ice: add stop flag for device start / stop

2020-06-22 Thread Ting Xu
From: Qi Zhang Add stop flag for DCF device start and stop. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 14 ++ drivers/net/ice/ice_dcf_parent.c | 1 + 2 files changed, 15 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/driv

[dpdk-dev] [PATCH v5 02/12] net/ice: complete device info get in DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Add support to get complete device information for DCF, including Rx/Tx offload capabilities and default configuration. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 70 ++-- 1 file changed, 67 insertions(+), 3

[dpdk-dev] [PATCH v5 04/12] net/ice: complete queue setup in DCF

2020-06-22 Thread Ting Xu
From: Qi Zhang Delete original DCF queue setup functions and use ice queue setup and release functions instead. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 42 +++- drivers/net/ice/ice_dcf_ethdev.h | 3 --- drivers/net/ice

[dpdk-dev] [PATCH v5 00/12] enable DCF datapath configuration

2020-06-22 Thread Ting Xu
This patchset adds support to configure DCF datapath, including Rx/Tx queues setup, start and stop, device configuration, RSS and flexible descriptor RXDID initialization and MAC filter setup. Qi Zhang (11): net/ice: init RSS and supported RXDID in DCF net/ice: complete device info get in DCF

Re: [dpdk-dev] [PATCH 16/70] net/e1000/base: implement Low-Power-Link-Up (LPLU) for i225

2020-06-22 Thread Zhao1, Wei
Hi, > -Original Message- > From: Sun, GuinanX > Sent: Monday, June 22, 2020 2:46 PM > To: dev@dpdk.org > Cc: Guo, Jia ; Zhao1, Wei ; Sun, > GuinanX ; Dima Ruinskiy > Subject: [PATCH 16/70] net/e1000/base: implement Low-Power-Link-Up (LPLU) > for i225 > > I225 introduces a new mechanism

Re: [dpdk-dev] [PATCH 15/70] net/e1000/base: setup copper link function for i225

2020-06-22 Thread Zhao1, Wei
Hi, > -Original Message- > From: Sun, GuinanX > Sent: Monday, June 22, 2020 2:46 PM > To: dev@dpdk.org > Cc: Guo, Jia ; Zhao1, Wei ; Sun, > GuinanX ; Trakhtenberg, Dany > > Subject: [PATCH 15/70] net/e1000/base: setup copper link function for i225 > > A dedicated function for i225 that

Re: [dpdk-dev] [RFC] example/vhost: add support for vhost async data path

2020-06-22 Thread Xia, Chenbo
Hi Cheng, > -Original Message- > From: Jiang, Cheng1 > Sent: Monday, June 22, 2020 10:59 AM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > Wang, Zhihong > Cc: dev@dpdk.org; Fu, Patrick ; Liang, Cunming > ; Jiang, Cheng1 > Subject: [RFC] example/vhost: add support for vhost async data

Re: [dpdk-dev] [PATCH v2 4/4] net/ice: support switch flow for specific L4 type

2020-06-22 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 22, 2020 11:36 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2 4/4] net/ice: support switch flow for specific L4 type > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: W

Re: [dpdk-dev] [PATCH v2 3/4] net/ice: add check for NVGRE protocol

2020-06-22 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 22, 2020 11:50 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2 3/4] net/ice: add check for NVGRE protocol > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Wednesday, Ju

Re: [dpdk-dev] [PATCH v8 2/9] pci: use OS generic memory mapping functions

2020-06-22 Thread Dmitry Kozlyuk
On Mon, 22 Jun 2020 10:55:22 +0300 tal...@mellanox.com wrote: [snip] > @@ -176,10 +177,10 @@ pci_unmap_resource(void *requested_addr, size_t size) > return; > > /* Unmap the PCI memory resource of device */ > - if (munmap(requested_addr, size)) { > - RTE_LOG(E

Re: [dpdk-dev] [PATCH 0/3] improve MinGW-w64 support

2020-06-22 Thread Kadam, Pallavi
On 6/20/2020 3:35 PM, Dmitry Kozlyuk wrote: Following the discussion on the mailing list [1], clarify MinGW-w64 installation process and stop linking with pthread on Windows. Make Meson cross-file more general along the way. [1]: https://mails.dpdk.org/archives/dev/2020-June/170252.html Dmit

Re: [dpdk-dev] [PATCH v16 2/2] eal: support for VFIO-PCI VF token

2020-06-22 Thread Harman Kalra
On Wed, Jun 17, 2020 at 02:33:21PM +0800, Haiyue Wang wrote: > The kernel module vfio-pci introduces the VF token to enable SR-IOV > support since 5.7. > > The VF token can be set by a vfio-pci based PF driver and must be known > by the vfio-pci based VF driver in order to gain access to the devic

Re: [dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-06-22 Thread Dmitry Kozlyuk
On Mon, 22 Jun 2020 08:41:17 -0400, Neil Horman wrote: > On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote: [snip] > > 1. No standard ELF or COFF module for Python > > (amount of Python code without libelf on par with C code using it). > Thats not really true, pyelftools is prett

[dpdk-dev] [Bug 492] Fix references to /dev/huge

2020-06-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=492 Bug ID: 492 Summary: Fix references to /dev/huge Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: Normal

Re: [dpdk-dev] [PATCH v4 1/4] librte_ethdev: Introduce a function to release HW rings

2020-06-22 Thread Ferruh Yigit
On 6/22/2020 10:54 AM, Renata Saiakhova wrote: > Free previously allocated memzone for HW rings > > Signed-off-by: Renata Saiakhova <...> > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Free previously allocated memzone for HW rings. > + * > +

Re: [dpdk-dev] [PATCH v4 1/4] librte_ethdev: Introduce a function to release HW rings

2020-06-22 Thread Ferruh Yigit
On 6/22/2020 10:54 AM, Renata Saiakhova wrote: > Free previously allocated memzone for HW rings > > Signed-off-by: Renata Saiakhova > --- > lib/librte_ethdev/rte_ethdev.c | 30 ++-- > lib/librte_ethdev/rte_ethdev_driver.h| 20 > lib/librte_ethde

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-22 Thread Andrey Vesnovaty
On Mon, Jun 22, 2020 at 6:22 PM Thomas Monjalon wrote: > 20/06/2020 15:32, Andrey Vesnovaty: > > Hi, and thanks a lot for your RFC v1 comments. > > > > RFC v2 emphasize the intent for sharing the flow action: > > * The term 'action context' was unclear and replaced with > >'shared action'. >

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 5:51 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/22/20 3:43 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: Sent: Monday, June 22, 2020 3:33 PM To: Matan Azrad ; Xiao Wang Cc: dev@dpdk.org Subject: Re: [PATCH v1 3/4] vhost: improve

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-22 Thread Ananyev, Konstantin
> > Hi David, > > > diff --git a/lib/librte_eal/common/eal_common_lcore.c > > b/lib/librte_eal/common/eal_common_lcore.c > > index 86d32a3dd7..7db05428e7 100644 > > --- a/lib/librte_eal/common/eal_common_lcore.c > > +++ b/lib/librte_eal/common/eal_common_lcore.c > > @@ -6,12 +6,13 @@ > > #inc

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
From: Maxime Coquelin: > On 6/22/20 3:43 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> Sent: Monday, June 22, 2020 3:33 PM > >> To: Matan Azrad ; Xiao Wang > >> > >> Cc: dev@dpdk.org > >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > >> > >> > >> > >> On 6

[dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode

2020-06-22 Thread Jasvinder Singh
Softnic can be used like other virtual devices without needing any special mode. Therefore, softnic forward mode is removed from testpmd app. Documentation is updated as well. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- app/test-pmd/Makefile | 4 - a

Re: [dpdk-dev] [PATCH v2 3/4] net/ice: add check for NVGRE protocol

2020-06-22 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 17, 2020 2:14 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v2 3/4] net/ice: add check for NVGRE protocol fix tunnel type for switch rule > > This patch add check for protocol

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-22 Thread Ananyev, Konstantin
Hi David, > diff --git a/lib/librte_eal/common/eal_common_lcore.c > b/lib/librte_eal/common/eal_common_lcore.c > index 86d32a3dd7..7db05428e7 100644 > --- a/lib/librte_eal/common/eal_common_lcore.c > +++ b/lib/librte_eal/common/eal_common_lcore.c > @@ -6,12 +6,13 @@ > #include > #include >

[dpdk-dev] [PATCH] doc: update softnic documentation

2020-06-22 Thread Jasvinder Singh
Update traffic management function parameters description and command for running the softnic device using testpmd app. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- doc/guides/nics/softnic.rst | 60 +++-- 1 file changed, 44 insertions(+), 16 d

Re: [dpdk-dev] [PATCH v2 4/4] net/ice: support switch flow for specific L4 type

2020-06-22 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 17, 2020 2:14 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v2 4/4] net/ice: support switch flow for specific L4 type > > This patch add more specific tunnel type for ipv4/ipv6

Re: [dpdk-dev] [PATCH v3 2/2] doc: include config options in testpmd user guide

2020-06-22 Thread Thomas Monjalon
19/06/2020 18:13, Dharmik Thakkar: > > On Jun 19, 2020, at 10:43 AM, Thomas Monjalon wrote: > > 19/06/2020 17:38, Dharmik Thakkar: > >>> On Jun 17, 2020, at 2:48 PM, Thomas Monjalon wrote: > >>> 17/06/2020 20:21, Ferruh Yigit: > On 5/20/2020 4:20 AM, Dharmik Thakkar wrote: > > Update tes

Re: [dpdk-dev] [PATCH v2 2/4] net/ice: add redirect support for VSI list rule

2020-06-22 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 17, 2020 2:14 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v2 2/4] net/ice: add redirect support for VSI list rule > > This patch enable redirect switch rule of vsi list type.

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-22 Thread Thomas Monjalon
20/06/2020 15:32, Andrey Vesnovaty: > Hi, and thanks a lot for your RFC v1 comments. > > RFC v2 emphasize the intent for sharing the flow action: > * The term 'action context' was unclear and replaced with >'shared action'. > * RFC v2 subject became 'add flow shared action API'. > * all propo

[dpdk-dev] [Bug 491] Timers synchronously resetting or stopping other timers as part of their callback can cause hangs

2020-06-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=491 Bug ID: 491 Summary: Timers synchronously resetting or stopping other timers as part of their callback can cause hangs Product: DPDK Version: 19.11 Hardware: All OS:

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: move getter functions from net to common

2020-06-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ori Kam > Sent: Friday, June 19, 2020 10:30 AM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; Ophir Munk > Subject: [PATCH v2 1/2] net/mlx5: move getter functions from net to > common > > From: O

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 3:43 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> Sent: Monday, June 22, 2020 3:33 PM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> >> >> On 6/22/20 12:06 PM, Matan Azrad wrote: >>> >>> Hi

Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file

2020-06-22 Thread Thomas Monjalon
Can we reduce the scope in the title? This patch is about EAL config in general, so I would reword it to: eal: move OS common config objects 22/06/2020 09:55, tal...@mellanox.com: > +#include > + > +#include > +#include Local files, like eal_*, are usually included with "". [...] > +/

Re: [dpdk-dev] [PATCH v2] net/ice: support based RSS configure

2020-06-22 Thread Zhang, Qi Z
> -Original Message- > From: Jiang, JunyuX > Sent: Monday, June 22, 2020 1:33 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Su, Simei ; Jiang, JunyuX > > Subject: [PATCH v2] net/ice: support based RSS configure The title is misleading, how about "initialize and update RSS

[dpdk-dev] [PATCH v2 4/4] eal: cache last directory permissions checked

2020-06-22 Thread Bruce Richardson
When loading a directory of drivers, we check the same hierarchy multiple times. If we just cache the last directory checked, this avoids repeated checks of the same path, since all drivers in that path have been added to the list consecutively. Signed-off-by: Bruce Richardson --- V2: Fix checkpa

[dpdk-dev] [PATCH v2 3/4] eal: don't load drivers from insecure paths

2020-06-22 Thread Bruce Richardson
Any paths on the system which are world-writable are insecure and should not be used for loading drivers. Therefore check each driver path before loading it and error out on insecure ones. Signed-off-by: Bruce Richardson --- v2: rebased to latest head to fix errors on apply in CI testing --- lib

[dpdk-dev] [PATCH v2 2/4] eal: only load shared libs from driver plugin directory

2020-06-22 Thread Bruce Richardson
When we pass a "-d" flag to EAL pointing to a directory, we attempt to load all files in that directory as driver plugins, irrespective of file type. This procludes using e.g. the build/drivers directory, as a driver source since it contains static libs and other files as well as the shared objects

[dpdk-dev] [PATCH v2 1/4] eal: remove unnecessary null-termination

2020-06-22 Thread Bruce Richardson
Since strlcpy always null-terminates, and the buffer is zeroed before copy anyway, there is no need to explicitly zero the end of the character array, or to limit the bytes that strlcpy can write. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/eal_common_options.c | 3 +-- 1 file chan

[dpdk-dev] [PATCH v2 0/4] improve runtime loading of shared drivers

2020-06-22 Thread Bruce Richardson
This set includes a number of small improvements for handling the loading of drivers at runtime using the EAL -d flag. It limits the loading of files to only those files which end in .so, which means that one can pass in the whole "drivers/" subfolder from a meson build and not get an error when D

Re: [dpdk-dev] [PATCH v2] doc: fix doc build when sphinx reports version to stderr

2020-06-22 Thread David Marchand
On Mon, Jun 22, 2020 at 4:00 PM Bruce Richardson wrote: > > When sphinx-build reports its version information to stderr rather > than stdout, the wrapper script misses it, and then fails to run. > We can fix this by redirecting stderr to stdout for the version > query call. > > Fixes: f5ab2074cfba

Re: [dpdk-dev] [PATCH v2] doc: fix doc build when sphinx reports version to stderr

2020-06-22 Thread Power, Ciara
>-Original Message- >From: dev On Behalf Of Bruce Richardson >Sent: Monday 22 June 2020 15:00 >To: david.march...@redhat.com >Cc: dev@dpdk.org; Richardson, Bruce >Subject: [dpdk-dev] [PATCH v2] doc: fix doc build when sphinx reports version >to stderr > >When sphinx-build reports its ve

[dpdk-dev] [PATCH v2] doc: fix doc build when sphinx reports version to stderr

2020-06-22 Thread Bruce Richardson
When sphinx-build reports its version information to stderr rather than stdout, the wrapper script misses it, and then fails to run. We can fix this by redirecting stderr to stdout for the version query call. Fixes: f5ab2074cfba ("doc: rebuild with meson whenever a file changes") Signed-off-by: B

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
From: Maxime Coquelin: > Sent: Monday, June 22, 2020 3:33 PM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > > > On 6/22/20 12:06 PM, Matan Azrad wrote: > > > > Hi Maxime > > > > From: Maxime Coquelin > >> Sent: Mond

[dpdk-dev] [PATCH v3 7/9] eal: add lcore init callbacks

2020-06-22 Thread David Marchand
DPDK components and applications can have their say when a new lcore is initialized. For this, they can register a callback for initializing and releasing their private data. Signed-off-by: David Marchand --- Changes since v2: - added missing test, - fixed rollback on lcore register, Changes sin

[dpdk-dev] [PATCH v3 9/9] mempool/bucket: handle non-EAL lcores

2020-06-22 Thread David Marchand
Convert to new lcore API to support non-EAL lcores. Signed-off-by: David Marchand --- drivers/mempool/bucket/rte_mempool_bucket.c | 131 1 file changed, 82 insertions(+), 49 deletions(-) diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c b/drivers/mempool/bucket/rte_

[dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-22 Thread David Marchand
DPDK allows calling some part of its API from a non-EAL thread but this has some limitations. OVS (and other applications) has its own thread management but still want to avoid such limitations by hacking RTE_PER_LCORE(_lcore_id) and faking EAL threads potentially unknown of some DPDK component. I

[dpdk-dev] [PATCH v3 8/9] eal: add lcore iterators

2020-06-22 Thread David Marchand
Add a helper to iterate all lcores. The iterator callback is read-only wrt the lcores list. Implement a dump function on top of this for debugging. Signed-off-by: David Marchand --- Changes since v2: - added rte_lcore_dump calls in unit test, for basic check, Changes since v1: - introduced lcor

[dpdk-dev] [PATCH v3 5/9] eal: move lcore role code

2020-06-22 Thread David Marchand
For consistency sake, move all lcore role code in the dedicated compilation unit / header. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_lcore.c | 11 +++ lib/librte_eal/common/eal_common_thread.c | 11 --- lib/librte_eal/include/rte_eal.h | 9 -- lib/

[dpdk-dev] [PATCH v3 2/9] eal: fix multiple definition of per lcore thread id

2020-06-22 Thread David Marchand
Because of the inline accessor + static declaration in rte_gettid(), we end up with multiple symbols for RTE_PER_LCORE(_thread_id). Each compilation unit will pay a cost when accessing this information for the first time. $ nm build/app/dpdk-testpmd | grep per_lcore__thread_id 0054 d p

[dpdk-dev] [PATCH v3 4/9] eal: introduce thread uninit helper

2020-06-22 Thread David Marchand
This is a preparation step for dynamically unregistering threads. Since we explicitly allocate a per thread trace buffer in rte_thread_init, add an internal helper to free this buffer. Signed-off-by: David Marchand --- Note: I preferred renaming the current internal function to free all threads

[dpdk-dev] [PATCH v3 3/9] eal: introduce thread init helper

2020-06-22 Thread David Marchand
Introduce a helper responsible for initialising the per thread context. We can then have a unified context for EAL and non-EAL threads and remove copy/paste'd OS-specific helpers. Per EAL thread CPU affinity setting is separated from the thread init. It is to accommodate with Windows EAL where CPU

[dpdk-dev] [PATCH v3 0/9] Register non-EAL threads as lcore

2020-06-22 Thread David Marchand
OVS and some other applications have been hacking into DPDK internals to fake EAL threads and avoid performance penalty of only having non-EAL threads. This series proposes to add a new type of lcores and maps those threads to such lcores. non-EAL threads won't run the DPDK eal mainloop. As a cons

[dpdk-dev] [PATCH v3 1/9] eal: relocate per thread symbols to common

2020-06-22 Thread David Marchand
We have per lcore thread symbols scattered in OS implementations but common code relies on them. Move all of them in common. RTE_PER_LCORE(_socket_id) and RTE_PER_LCORE(_cpuset) have public accessors and are not exported through the library map, they can be made static. Signed-off-by: David March

Re: [dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-06-22 Thread Neil Horman
On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote: > This is a PoC rewrite of pmdinfogen in Python with missing bits > described below and in commits. Community input is desired. > > Pros: > > 1. Simpler build process without host apps. > 2. Less build requirements (host libelf). > 3

Re: [dpdk-dev] [PATCH 04/14] vhost: make vDPA framework bus agnostic

2020-06-22 Thread Maxime Coquelin
On 6/22/20 11:49 AM, Adrian Moreno wrote: > > > On 6/19/20 5:11 PM, Maxime Coquelin wrote: >> >> >> On 6/19/20 1:14 PM, Adrian Moreno wrote: >>> >>> >>> On 6/11/20 11:37 PM, Maxime Coquelin wrote: This patch makes the vDPA framework to no more support only PCI devices, but any device

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 12:06 PM, Matan Azrad wrote: > > Hi Maxime > > From: Maxime Coquelin >> Sent: Monday, June 22, 2020 11:56 AM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> >> >> On 6/22/20 10:41 AM, Matan Azrad wro

Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: Remove the re-implementation of inet_pton

2020-06-22 Thread Ananyev, Konstantin
> > inet_pton4 and inet_pton6 was reimplemented. Replace implementation of > inet_pton4 and inet_pton6 with libc inet_pton function > > Bugzilla ID: 365 > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") > Cc: roy.fan.zh...@intel.com > > Reported-by: David Marchand >

Re: [dpdk-dev] [PATCH v3] bus/pci: fix VF bus error for memory access

2020-06-22 Thread Burakov, Anatoly
On 22-Jun-20 12:13 PM, Haiyue Wang wrote: To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps and block MMIO access on disabled memory, it will send a SIGBUS to the application: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abafbc551fddede3e0a08d

Re: [dpdk-dev] [PATCH 21/21] net/ixgbe/base: update version

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > Update base code version in readme. > > Signed-off-by: Guinan Sun > --- > drivers/net/ixgbe/base/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README > index a48b14

Re: [dpdk-dev] [PATCH 19/21] net/ixgbe/base: remove default advertising for 2.5G and 5G

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > We are seeing interoperability issues with switches when 2.5G and 5G are > advertised by default, so default to off. This is only for 'X550' device, right? If so can you please clarify this in the patch title and the commit log? > > LINUX ONLY: > > We w

Re: [dpdk-dev] [PATCH 13/21] net/ixgbe/base: modify Klocwork hits for DDK 7.0

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > Fix issues found by Klocwork for DDK 7.0 This doesn't say much on its own, can you please document the actual issues fixed, like "fix unchecked return value" and I think can drop the Klocwork reference, and even not asking what DDK is ... Feel free to spl

Re: [dpdk-dev] [PATCH 18/21] net/ixgbe/base: ipv6 Mask for purpose FDIR VLAN Port Feature

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > Allow Flow Director Filter to set IPv6 rules > without setting IPv6 source/destination address. Patch title is hard to understand, commit log is more clear, but title talks about the VLAN, but description looks different. Can you please clarify? > > Sign

Re: [dpdk-dev] [PATCH 17/21] net/ixgbe/base: improve log about autonego being disabled

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > On ESXi OS, when user disables auto negotiation, the following log > appears: "(unsupported) Flow control autoneg is disabled". Is ESXi reference valid for the DPDK commit? > It is true that AN is disabled but it is not necessarily true that it is > not s

Re: [dpdk-dev] [PATCH 14/21] net/ixgbe/base: add defines for min rollback revision fields

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > Add defines for Minimum Rollback Revision fields as defined in SGVL. SGVL? > > Signed-off-by: Jacek Naczyk > Signed-off-by: Guinan Sun <...>

Re: [dpdk-dev] [PATCH 10/21] net/ixgbe/base: move increments after evaluations

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:23 AM, Guinan Sun wrote: > The retry variable was being incremented before it was evaluated by the > subsequent conditional against the maximum retries to figure out which > message to print. So we'll move the increment op to the end. > > Signed-off-by: Jeb Cramer > Signed-off-by:

Re: [dpdk-dev] [PATCH 12/21] net/ixgbe/base: create dedicated func to restart auto nego

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > Code to restart auto negotiation on PHY is already used in two places > and is needed in CORE repo of ixgben. ixgben? > This patch places it in dedicated > function for code clarity and makes it available outside the SHARED repo. > > Testing Hints (requ

Re: [dpdk-dev] [PATCH 11/21] net/ixgbe/base: modify loop accounting for retries

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > The condition for comparing retry against max_retry was flawed in the > do-while loops. For the case where retry was initialized to 0 and > max_retry was initialized to 1, we'd break out of the loop at the > condition when the intent is to retry the code a

Re: [dpdk-dev] [PATCH 05/21] net/ixgbe/base: added API for NVM update

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:23 AM, Guinan Sun wrote: > When Secure Boot is enabled access to the /dev/mem is forbidden > for user-space applications and clients are reporting inability > to use tools in Secure Boot Mode. The way to perform NVM update > is to use ixgbe driver. Currently 10G Linux Base Driver has

Re: [dpdk-dev] [PATCH 04/21] net/ixgbe/base: x550em 10G NIC driver issue

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:23 AM, Guinan Sun wrote: > With the NVM image for x550em XFI ethtool will not report > the auto-negotiation feature correctly. The auto-negotiation > should be "No" for supports and advertised items. This is not 'ethtool' issue in this context, right? It also affects the reported va

Re: [dpdk-dev] [PATCH 03/21] net/ixgbe/base: hange flow for "Apply Update" command

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:23 AM, Guinan Sun wrote: > For the "Apply Update" command the firmware does not > given an response. For this command, success should > be return. Based on information at EAS. > > Signed-off-by: Mateusz Kowalski > Signed-off-by: Guinan Sun <...> > diff --git a/drivers/net/ixgbe/

Re: [dpdk-dev] [PATCH 01/21] net/ixgbe/base: clear VFMBMEM and toggle VF's Tx queues

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:23 AM, Guinan Sun wrote: > Add a method to clear VFMBMEM memory. Can you please give some context, what is "VFMBMEM memory", why need to clear it, etc...? > Add a method to toggle VF's TX queues as workaround > for silicon errata. 'toggle' here means enable and disable the Tx que

Re: [dpdk-dev] [PATCH 02/21] net/ixgbe/base: change in the condition for response HI

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:23 AM, Guinan Sun wrote: > According to SGVL EAS Host interface Shadow RAM Read (0x31) > command response buffer length is stored in two bytes, > instead of one byte. For patch subject, better to say 'fix' instead of 'change' because that is what done. Previously Shadow RAM Read (0x

[dpdk-dev] [PATCH v3 4/4] mempool: mempool build on Windows

2020-06-22 Thread Fady Bader
Added mempool to supported libraries for Windows compilation. Signed-off-by: Fady Bader --- lib/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 9074cb58af..a9a5be0e5e 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -39

[dpdk-dev] [PATCH v3 2/4] mempool: use generic memory management

2020-06-22 Thread Fady Bader
mempool used Unix memory management calls, which are not supported on Windows. Used generic memory management instead. Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/lib/librte_mempool/r

[dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool

2020-06-22 Thread Fady Bader
Some eal functions were used by mempool lib but not exported on Windows. The function was exported. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 6 ++ lib/librte_eal/rte_eal_version.map | 1 + 2 files changed, 7 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports

[dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-06-22 Thread Fady Bader
Function versioning is not needed on Windows, also the function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 4 1 file changed, 4 insertions(+) diff --git

[dpdk-dev] [PATCH v3 0/4] build mempool on Windows

2020-06-22 Thread Fady Bader
Added changes in order to build mempool lib on windows. Depends-on: patch-71845 ("eal/windows: ring build on Windows") v3: * Rebased on current master and v5 of "eal/windows: ring build on Windows". v2: * Replace ifndef of tracepoints with symbol export from memory management patch

Re: [dpdk-dev] [PATCH v2] bus/pci: fix VF bus error for memory access

2020-06-22 Thread Wang, Haiyue
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, June 22, 2020 16:53 > To: Wang, Haiyue ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH v2] bus/pci: fix VF bus error for memory access > > On 22-Jun-20 7:30 AM, Haiyue Wang wrote: > > To fix CVE-2020-12888, the linux

[dpdk-dev] [PATCH v3] bus/pci: fix VF bus error for memory access

2020-06-22 Thread Haiyue Wang
To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps and block MMIO access on disabled memory, it will send a SIGBUS to the application: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abafbc551fddede3e0a08dee1dcde08fc0eb8476 When the application ope

Re: [dpdk-dev] [PATCH 6/9] vhost: add support for virtio status

2020-06-22 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: Adrian Moreno > Sent: Monday, June 22, 2020 6:18 PM > To: Xia, Chenbo ; Maxime Coquelin > ; Ye, Xiaolong ; > shah...@mellanox.com; ma...@mellanox.com; Wang, Xiao W > ; viachesl...@mellanox.com; dev@dpdk.org > Cc: jasow...@redhat.com; l...@redhat.com

Re: [dpdk-dev] [PATCH 6/9] vhost: add support for virtio status

2020-06-22 Thread Adrian Moreno
Hi Chenbo On 6/16/20 6:29 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: dev On Behalf Of Maxime Coquelin >> Sent: Thursday, May 14, 2020 4:02 PM >> To: Ye, Xiaolong ; shah...@mellanox.com; >> ma...@mellanox.com; amore...@redhat.com; Wang, Xiao W >> ; viachesl...@me

Re: [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics

2020-06-22 Thread Phil Yang
> -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Friday, June 12, 2020 7:20 PM > To: dev@dpdk.org; erik.g.carri...@intel.com > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dharmik Thakkar ; > nd > Subject: [dpdk-dev] [PATCH 3/3] eventdev: relax smp

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin > Sent: Monday, June 22, 2020 11:56 AM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > > > On 6/22/20 10:41 AM, Matan Azrad wrote: > >> The issue is if you only check ready state only

Re: [dpdk-dev] [PATCH v3 0/4] Memory corruption due to HW rings allocation

2020-06-22 Thread Renata Saiakhova
Hi Ferruh, I've just send a new corrected version of the patchset, which takes into account the comments of Wie and Jeff, hope it is OK now. Kind regards and thank you, Renata On 06/19/2020 06:54 PM, Ferruh Yigit wrote: On 5/18/2020 10:48 AM, Renata Saiakhova wrote: Hi Ferruh, thanks for

[dpdk-dev] [PATCH v4 4/4] drivers/net: Fix in em and ice HW rings memory overlap

2020-06-22 Thread Renata Saiakhova
Delete memzones for HW rings in em and ice while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/em_rxtx.c | 2 ++ drivers/net/ice/ice_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index 49c53712a..67

  1   2   3   >