[dpdk-dev] [PATCH v2] bus/pci: fix VF bus error for memory access

2020-06-21 Thread Haiyue Wang
To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps and block MMIO access on disabled memory, it will send a SIGBUS to the application: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abafbc551fddede3e0a08dee1dcde08fc0eb8476 When the application ope

[dpdk-dev] [PATCH v2] net/ice: support based RSS configure

2020-06-21 Thread Junyu Jiang
Enable/disable RSS for corresponding flow base on the user's requirement. Signed-off-by: Junyu Jiang --- v1->v2: remove gtpu and pppoe/pppod configuration from rss init --- drivers/net/ice/ice_ethdev.c | 162 +-- 1 file changed, 96 insertions(+), 66 deletions(-)

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: integrate RCU QSBR

2020-06-21 Thread Ruifeng Wang
Hi Vladimir, > -Original Message- > From: Medvedkin, Vladimir > Sent: Friday, June 19, 2020 1:22 AM > To: Ruifeng Wang ; Bruce Richardson > ; John McNamara > ; Marko Kovacevic > ; Ray Kinsella ; Neil Horman > > Cc: dev@dpdk.org; konstantin.anan...@intel.com; Honnappa Nagarahalli > ; nd

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Sachin Saxena (OSS)
On 22-Jun-20 8:17 AM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads and does not check

Re: [dpdk-dev] [PATCH v4 12/12] doc: enable DCF datapath configuration

2020-06-21 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Friday, June 19, 2020 4:51 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wu, Jingjing ; Xing, Beilei > ; Kovacevic, Marko ; > Mcnamara, John ; Xu, Ting > Subject: [PATCH v4 12/12] doc: enable DCF datapath configuration > > Add

[dpdk-dev] L3fwd performance setup

2020-06-21 Thread krishna dutt dubey
Hi, I am new to this. I want to do the performance setup of 10Gig card. I want to use L3fwd app and pktgen . Could anyone help me with this? I have two setup machine each have one 10gig dpdk cards and centos 7. Thanks

Re: [dpdk-dev] [PATCH 00/21] update ixgbe base code

2020-06-21 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Zhao1, Wei > Sent: Monday, June 22, 2020 10:42 AM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Sun, GuinanX > Subject: Re: [dpdk-dev] [PATCH 00/21] update ixgbe base code > > Reviewed-by: Wei Zhao > > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-21 Thread Honnappa Nagarahalli
> Subject: [PATCH v2] app/testpmd: fix CPU cycles per pkt stats on transmit > modes > > In txonly and flowgen forwarding mode, calculating CPU per packets with > total received packets is not accurate. Use total transmitted packets for > these cases. > > The error output under txonly mode: > te

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Wei Hu (Xavier) > Sent: Monday, June 22, 2020 11:47 AM > To: tho...@monjalon.net; ferruh.yi...@intel.com; > arybche...@solarflare.com; anatoly.bura...@intel.com; > hemant.agra...@nxp.com; sachin.sax...@nxp.com; John Daley (johndale) > ; Hyong Youb Kim (hyonkim)

[dpdk-dev] [RFC] example/vhost: add support for vhost async data path

2020-06-21 Thread Cheng Jiang
This patch makes vhost-vswitch be able to use vhost asynchronous api for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async api. Since this is an early preview patch, the performance has not been fully optimized and it's not suggested to use this patch a

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Wei Hu (Xavier)
Hi, Andrew Rybchenko On 2020/6/21 21:44, Andrew Rybchenko wrote: On 6/20/20 9:53 AM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver do

[dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Wei Hu (Xavier)
Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads and does not check for it, the hardware setting will not change, bu

[dpdk-dev] [PATCH v3 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-21 Thread Wei Hu (Xavier)
In the rte_eth_rx_queue_setup API function, the local variable named mbp_buf_size, which is the data room size of the input parameter mp, is checked to guarantee that each memory chunck used for net device in the mbuf is bigger than the min_rx_bufsize. But if mbp_buf_size is less than RTE_PKTMBUF_H

[dpdk-dev] [PATCH v3 0/2] ethdev: minor bugfixes

2020-06-21 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 5 - drivers/net/enic/enic_ethdev.c | 12 ---

Re: [dpdk-dev] [PATCH 00/21] update ixgbe base code

2020-06-21 Thread Zhao1, Wei
Reviewed-by: Wei Zhao > -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Friday, June 12, 2020 11:24 AM > To: dev@dpdk.org > Cc: Sun, GuinanX > Subject: [dpdk-dev] [PATCH 00/21] update ixgbe base code > > update ixgbe base code. > > Guinan Sun (21): > net/ixgbe/base:

Re: [dpdk-dev] [PATCH 3/3] net/bnxt: add ARM64 vector support

2020-06-21 Thread Ruifeng Wang
> -Original Message- > From: Lance Richardson > Sent: Thursday, June 18, 2020 10:36 PM > To: dev@dpdk.org; Ajit Khaparde (ajit.khapa...@broadcom.com) > ; Ruifeng Wang > Subject: [PATCH 3/3] net/bnxt: add ARM64 vector support > > Add bnxt vector PMD support using NEON SIMD instructions.

[dpdk-dev] [RFC PATCH 2/2] build: use Python pmdinfogen

2020-06-21 Thread Dmitry Kozlyuk
* C pmdinfogen not removed. * No Makefile support yet. Signed-off-by: Dmitry Kozlyuk --- buildtools/meson.build | 3 +-- drivers/meson.build| 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/buildtools/meson.build b/buildtools/meson.build index d5f8291be..1af835a9c 100644

[dpdk-dev] [RFC PATCH 1/2] pmdinfogen: prototype in Python

2020-06-21 Thread Dmitry Kozlyuk
* No user-friendly error handling and no bounds checking yet. * No support for >65K sections case (is it needed?). * The order of definitions is reversed. Signed-off-by: Dmitry Kozlyuk --- buildtools/elf.py| 194 +++ buildtools/pmdinfogen.py | 144

[dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-06-21 Thread Dmitry Kozlyuk
This is a PoC rewrite of pmdinfogen in Python with missing bits described below and in commits. Community input is desired. Pros: 1. Simpler build process without host apps. 2. Less build requirements (host libelf). 3. Easier debugging and maintenance with a high-level language. 4. Easier porting

[dpdk-dev] [PATCH v2 5/6] bus/mlx5_pci: enable net and vDPA to use mlx5 PCI bus driver

2020-06-21 Thread Parav Pandit
Enable class driver to match with the mlx5 pci devices. Migrate mlx5 net PMD and vdpa PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Migreate API from rte_driver to rte_pci_driver --- drivers/bus/Makefile| 3 ++ drivers/bus/mlx

[dpdk-dev] [PATCH v2 3/6] bus/mlx5_pci: add mlx5 PCI bus

2020-06-21 Thread Parav Pandit
Add mlx5 PCI bus which enables multiple mlx5 drivers to bind to single pci device. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Address comments from Thomas and Gaetan - Inheriting ret_pci_driver instead of rte_driver - Added design and description of the mlx5_pci bus --- config/commo

[dpdk-dev] [PATCH v2 6/6] common/mlx5: Remove class checks from individual driver

2020-06-21 Thread Parav Pandit
Now that mlx5_pci bus does the check for enabled classes and performs probe(), remove() of associated classes, individual class driver doesn't need to check if other driver is enabled. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - New patch --- drivers/common/mlx5/mlx5_common.c

[dpdk-dev] [PATCH v2 4/6] bus/mlx5_pci: register a PCI driver

2020-06-21 Thread Parav Pandit
Create a mlx5 bus driver framework for invoking drivers of multiple classes who have registered with the mlx5_pci bus driver. Validate user class arguments for supported class combinations. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Address comments from Thomas and Gaetan - Enhanced

[dpdk-dev] [PATCH v2 0/6] Improve mlx5 PMD common driver framework for multiple classes

2020-06-21 Thread Parav Pandit
This commit introduces mlx5 bus to support multiple class of devices for a single PCI device. Motivation and example -- mlx5 PCI device supports multiple class of devices such as net, vdpa and regex devices. Currently only one pmd (either net or vdpa) can bind to this device.

[dpdk-dev] [PATCH v2 2/6] common/mlx5: change mlx5 class enum values as bits

2020-06-21 Thread Parav Pandit
mlx5 PCI Device supports multiple classes of devices such as net, vdpa, and/or regex. To support these multiple classes, change mlx5_class to a bitmap values so that if users asks to enable multiple of them, all supported classes can be parsed. Signed-off-by: Parav Pandit --- Changelog: v1->v2:

[dpdk-dev] [PATCH v2 1/6] eal: introduce macros for getting value for bit

2020-06-21 Thread Parav Pandit
There are several drivers which duplicate bit generation macro. Introduce a generic bit macros so that such drivers avoid redefining same in multiple drivers. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Addressed comments from Thomas and Gaten. - Avoided new file, added macro to rte_bi

Re: [dpdk-dev] When .remove function (of struct rte_vdev_driver) is called

2020-06-21 Thread Muhammad Bilal
Yes, I have used the rte_eal_cleanup() function when application exits. And still it does not call the .remove function of rte_vdev_driver structure, used in PMD. On Sun, Jun 21, 2020 at 11:11 PM Stephen Hemminger wrote: > > On Sun, 21 Jun 2020 18:17:09 +0500 > Muhammad Bilal wrote: > > > While

Re: [dpdk-dev] When .remove function (of struct rte_vdev_driver) is called

2020-06-21 Thread Stephen Hemminger
On Sun, 21 Jun 2020 18:17:09 +0500 Muhammad Bilal wrote: > While working on applications(l2fwd, testpmd) with PMD(memif, Tun|Tap > and some other) I have noticed that the .probe function of > rte_vdev_driver structure is called in rte_eal_init() and .remove > function of rte_vdev_driver structure

[dpdk-dev] [PATCH v1] bus/pci: fix VF bus error for memory access

2020-06-21 Thread Haiyue Wang
To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps and block MMIO access on disabled memory, it will send a SIGBUS to the application. In fact, vfio-pci will enable the memory command when openning the PCI device, but according to the PCIe specification, this enablement by real

Re: [dpdk-dev] [PATCH v2] net/mlx5: optimize free counter lookup

2020-06-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, June 18, 2020 11:13 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: optimize free counter lookup > > Currently, when allocate a new counter, it needs loop the w

Re: [dpdk-dev] [PATCH 0/3] net/mlx5: optimize single counter allocate

2020-06-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, June 18, 2020 10:25 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH 0/3] net/mlx5: optimize single counter allocate > > This patch set optimizes the DevX single counter alloc

[dpdk-dev] [dpdk-dev v3 2/2] net/ice: enable new input set for rss hash

2020-06-21 Thread Jeff Guo
PF could add or delete a RSS rule base on the PF's hash capability. Some new rss input set will be supported, the protocols as below: eth/vlan/l2tpv3/esp/ah/pfcp/gtpu. Signed-off-by: Jeff Guo --- v3->v2: refince code sturcture and fix simple xor issue fix some typos --- drivers/net/ice/ice_hash.

[dpdk-dev] [dpdk-dev v3 1/2] app/testpmd: add GTPU to RSS hash commands

2020-06-21 Thread Jeff Guo
Add testpmd cmdline support for GTPU, it could be used to configure gtpu teid hash. The commands as below: testpmd> flow create 0 ingress pattern eth / ipv4 / udp / gtpu / \ ipv4 / end actions rss types gtpu end key_len 0 queues end / end Signed-off-by: Jeff Guo --- v3->v2: add gtpu hash --- a

[dpdk-dev] [dpdk-dev v3] net/iavf: add inner 5 tuple hash for GTPU

2020-06-21 Thread Jeff Guo
Previous iavf only support inner ipv4 hash for GTPU, this patch aims to enable inner 5 tuple hash for GTPU, that involves inner ipv4 src/dst, tcp sport/dport, udp sport/dport and protocol id. Signed-off-by: Jeff Guo --- v3->v2: correct some typo and refine code --- drivers/net/iavf/iavf_hash.c |

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Andrew Rybchenko
On 6/20/20 9:53 AM, Wei Hu (Xavier) wrote: > Currently, there is a potential problem that calling the API function > rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the > driver does not support. If the PMD driver does not support certain VLAN > hardware offloads and does not che

Re: [dpdk-dev] [PATCH] net/i40e: fix modifying the number of queues

2020-06-21 Thread Jeff Guo
hi, alvin On 6/10/2020 8:07 PM, alvinx.zh...@intel.com wrote: From: Alvin Zhang For the newly created VF, if the number of qps is greater than 4 at startup, it may fail to start. This patch updates the API `i40evf_dev_configure`. Could you explicit explain why it limit to 4 qps, and more de

[dpdk-dev] [PATCH] dedicated queues: delete redundant check valid_bonded_port_id has include check_for_bonded_ethdev, no need to check again.

2020-06-21 Thread 197020236
From: pandongyang <197020...@qq.com> Signed-off-by: pandongyang <197020...@qq.com> --- drivers/net/bonding/rte_eth_bond_8023ad.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index b77a37d..3393743 1

[dpdk-dev] When .remove function (of struct rte_vdev_driver) is called

2020-06-21 Thread Muhammad Bilal
While working on applications(l2fwd, testpmd) with PMD(memif, Tun|Tap and some other) I have noticed that the .probe function of rte_vdev_driver structure is called in rte_eal_init() and .remove function of rte_vdev_driver structure is NEVER called, even after exiting the application. My Question

Re: [dpdk-dev] [PATCH] net/i40e: enable port filter by switch filter

2020-06-21 Thread Jeff Guo
hi, guinan On 6/11/2020 1:24 PM, Guinan Sun wrote: This patch enables the filter that supports to create following two rules for the same packet type: One is to select source port only as input set and the other is for destination port only. Signed-off-by: Guinan Sun --- doc/guides/rel_notes

Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline

2020-06-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Wednesday, June 17, 2020 4:53 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Bing Zhao ; Jack Min > Subject: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline >

[dpdk-dev] [PATCH v5] eal/windows: ring build on Windows

2020-06-21 Thread Fady Bader
Building ring on Windows. Signed-off-by: Fady Bader --- Depends-on: series-10531 ("Windows bus/pci support") v5: rebase to current master and "Windows bus/pci support" v7. v4: rebase on "Windows basic memory management" v5. v3: Fix style issues. v2: Fix style issues. --- lib/meson.build |

Re: [dpdk-dev] [PATCH v7 7/9] bus/pci: introduce Windows support with stubs

2020-06-21 Thread Fady Bader
> diff --git a/lib/librte_eal/rte_eal_exports.def > b/lib/librte_eal/rte_eal_exports.def > index 61bcb8aca7..3b0c8b60a5 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -3,6 +3,11 @@ EXPORTS > per_lcore__rte_errno > rte_calloc > rte

Re: [dpdk-dev] [PATCH v3 1/4] regexdev: introduce regexdev subsystem

2020-06-21 Thread Ori Kam
Hi All, This is the only patch that is missing an ack, I plan to submit the PMD code next week, so please review and ack this patch. Thanks, Ori > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Thursday, May 7, 2020 12:46 PM > To: jer...@marvell.com; xiang.w.w...@intel.com

[dpdk-dev] [PATCH v7 9/9] build: generate version.map file for MinGW on Windows

2020-06-21 Thread talshn
From: Tal Shnaiderman The MinGW build for Windows has special cases where exported function contain additional prefix: __emutls_v.per_lcore__* To avoid adding those prefixed functions to the version.map file the map_to_def.py script was modified to create a map file for MinGW with the needed ch

[dpdk-dev] [PATCH v7 7/9] bus/pci: introduce Windows support with stubs

2020-06-21 Thread talshn
From: Tal Shnaiderman Addition of stub eal and bus/pci functions to compile bus/pci for Windows. Signed-off-by: Tal Shnaiderman --- drivers/baseband/meson.build | 4 + drivers/bus/ifpga/meson.build | 6 ++ drivers/bus/pci/meson.build| 14 ++- drivers/bus/pci/pci_common.

[dpdk-dev] [PATCH v7 5/9] drivers: ignore pmdinfogen generation for Windows

2020-06-21 Thread talshn
From: Tal Shnaiderman pmdinfogen generation is currently unsupported for Windows. The relevant part in meson.build is skipped. Signed-off-by: Tal Shnaiderman --- drivers/meson.build | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/meson.

[dpdk-dev] [PATCH v7 1/9] eal: move OS common functions to single file

2020-06-21 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_config.c. Those functions are getter functions for IOVA, configuration, Multi-process. Move rte_config, internal_config, early_mem_config and runtime_dir to be defined in a common file. Signed-off-by: Tal Shnaid

[dpdk-dev] [PATCH v7 3/9] pci: build on Windows

2020-06-21 Thread talshn
From: Tal Shnaiderman Added in rte_pci header file to include off_t type since it is missing for Windows. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_pci/rte_pci.h | 1 + lib/meson.build| 5 - 3 files changed, 6 ins

[dpdk-dev] [PATCH v7 8/9] bus/pci: support Windows with bifurcated drivers

2020-06-21 Thread talshn
From: Tal Shnaiderman Uses SetupAPI.h functions to scan PCI tree. Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF. scanning currently supports types RTE_KDRV_NONE. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c

[dpdk-dev] [PATCH v7 2/9] pci: use OS generic memory mapping functions

2020-06-21 Thread talshn
From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Change all of PCI mapping function usage in bus/pci to support the new API. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/bsd/pci.c | 2 +- drivers/bus/pci/linux/pci_uio.c

[dpdk-dev] [PATCH v7 4/9] pci: fix format warning on Windows

2020-06-21 Thread talshn
From: Tal Shnaiderman the struct rte_pci_addr defines domain as uint32_t variable however the PCI_PRI_FMT macro used for logging the struct sets the format of domain to uint16_t. The mismatch causes the following warning messages in Windows clang build: format specifies type 'unsigned short' bu

[dpdk-dev] [PATCH v7 0/9] Windows bus/pci support

2020-06-21 Thread talshn
From: Tal Shnaiderman This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. --- v7: * Remove Unneeded code from MinGW mapping script (DmitryK) * Fix error flow issues in pci.c (DmitryK) * Fix Unix build errors followin

[dpdk-dev] [PATCH v7 6/9] drivers: fix incorrect meson import folder for Windows

2020-06-21 Thread talshn
From: Tal Shnaiderman import library (/IMPLIB) in meson.build should use the 'drivers' and not 'libs' folder. The error is: fatal error LNK1149: output filename matches input filename. The fix uses the correct folder. Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")

Re: [dpdk-dev] [PATCH 11/13] drivers/bus: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/bus/dpaa/dpaa_bus.c | 10 +- drivers/bus/fslmc/fslmc_bus.c

Re: [dpdk-dev] [PATCH 10/13] drivers/common: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/common/dpaax/dpaax_iova_table.c | 10 +-- drivers/common/iavf/iavf_impl.

Re: [dpdk-dev] [PATCH 06/13] drivers/mempool: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/mempool/dpaa/dpaa_mempool.c | 10 ++ drivers/mempool/dpaa2

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-21 Thread Sachin Saxena (OSS)
On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication in the log registration process. It is a wrapper macro for declaring the logtype, register the log and sets it's level in the constructor context. Signed-off

[dpdk-dev] [PATCH] vfio: fix resource leak when mapping fails

2020-06-21 Thread Yunjian Wang
Currently, only the 'vfio_dev_fd' is closed in failure path, so some resources are not released(such as 'vfio_group_fd'). The rte_vfio_release_device() should be used to avoid this problem. Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang ---

[dpdk-dev] [PATCH] eal: fix missing include

2020-06-21 Thread Yunjian Wang
This patch adds the missing include and fixes the build error: /dpdk/build/include/rte_uuid.h: In function 'rte_uuid_copy': /dpdk/build/include/rte_uuid.h:58:2: error: implicit declaration of function 'memcpy' [-Werror=implicit-function-declaration] memcpy(dst, src, sizeof(rte_uuid_t)); ^~