Re: [dpdk-dev] [PATCH v1] doc: fix typos and errors in abi policy doc

CC: John + Marko Gaetan, Looks good, thank you for the tidy up. On 13/05/2020 11:43, Gaetan Rivet wrote: > Some errors in the document: > > * API instead of ABI once. > > Some typos: > > * __rte_depreciated instead of __rte_deprecated. > * missing around value. > * inconsistent r

Re: [dpdk-dev] [PATCH v3] net/i40e: fix out of bounds read issue

Hi > -Original Message- > From: Guo, Jia > Sent: Thursday, May 14, 2020 2:17 PM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Xing, Beilei > Subject: Re: [PATCH v3] net/i40e: fix out of bounds read issue > > > On 5/14/2020 9:16 AM, Di, ChenxuX wrote: > > Hi, > > > > > > > >> -Original Mes

Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow

On 05/07, Shougang Wang wrote: >This patch fixes the issue that failed to create an RSS rule with type >L2-payload. > >Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") > >Signed-off-by: Shougang Wang >--- > drivers/net/i40e/i40e_flow.c | 14 ++ > 1 file changed,

Re: [dpdk-dev] [PATCH v3] net/i40e: fix out of bounds read issue

On 5/14/2020 9:16 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Guo, Jia Sent: Wednesday, May 13, 2020 2:51 PM To: Di, ChenxuX ; dev@dpdk.org Cc: Xing, Beilei Subject: Re: [PATCH v3] net/i40e: fix out of bounds read issue hi, chenxu On 5/13/2020 10:26 AM, Chenxu Di wrote:

Re: [dpdk-dev] [dpdk-dev v2 1/2] common/iavf: fix typo of rss algorithm type

On 05/13, Jeff Guo wrote: >A typo need to be fixd for Simple XOR algorithm configuration. > >Signed-off-by: Jeff Guo >--- >v2: fix a typo for xor. >--- > drivers/common/iavf/virtchnl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/common/iavf/virtchnl.h b/drivers/c

Re: [dpdk-dev] [dpdk-dev v2 2/2] net/iavf: fix rss algorithm configure issue

On 05/13, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Thursday, May 14, 2020 4:21 AM >> To: Xing, Beilei ; Ye, Xiaolong >> ; Zhang, Qi Z ; Wu, Jingjing >> >> Cc: dev@dpdk.org; Guo, Jia >> Subject: [dpdk-dev v2 2/2] net/iavf: fix rss algorithm configure issue >

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/crypto: fix gcc 10 no-common errors

> On 5/13/2020 2:50 PM, akhil.go...@nxp.com wrote: > > From: Akhil Goyal > > > > gcc 10 defaults to -fno-common and as a result when linking with > > crypto drivers: > > > > drivers/librte_pmd_dpaa_sec.a(crypto_dpaa_sec_dpaa_sec.c.o): > > (.bss+0x4): multiple definition of `rta_sec_era'; > > dri

Re: [dpdk-dev] [dpdk-dev v2 1/2] common/iavf: fix typo of rss algorithm type

On 05/13, Jeff Guo wrote: >A typo need to be fixd for Simple XOR algorithm configuration. > >Signed-off-by: Jeff Guo >--- >v2: fix a typo for xor. >--- > drivers/common/iavf/virtchnl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/common/iavf/virtchnl.h b/drivers/c

Re: [dpdk-dev] [PATCH] doc/mlx5: remove limitation for TSO over VM

Thanks, Raslan. ACK. Regards, Asaf Penso From: dev on behalf of Raslan Darawsheh Sent: Wednesday, May 13, 2020 2:00:31 PM To: Matan Azrad ; Slava Ovsiienko Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] doc/mlx5: remove limitation for TSO over VM removing the

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats

Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, May 13, 2020 6:13 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org > Subject: [EXT] RE: [PATCH v3] examples/ipsec-s

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

Hi Jerin, >From: Jerin Jacob >Sent: Sunday, May 10, 2020 12:04 AM > >On Wed, May 6, 2020 at 8:13 AM Rasesh Mody wrote: >> >> Hi, >> >> >From: Thomas Monjalon >> >Sent: Tuesday, May 05, 2020 2:15 AM >> > >> >05/05/2020 10:59, Ferruh Yigit: >> >> On 5/5/2020 7:44 AM, Jerin Jacob wrote: >> >> > On

Re: [dpdk-dev] [EXT] Re: [PATCH] net/qede: fix link state configuration

Hi Jerin, >From: Jerin Jacob >Sent: Wednesday, May 13, 2020 9:25 AM > >On Tue, May 12, 2020 at 6:16 AM Rasesh Mody wrote: >> >> Move link state enable/disable to dev_start() and dev_stop() >> respectively. This will ensure when devices are stopped, link status >> will be appropriately shown as d

[dpdk-dev] [PATCH v2 2/2] examples/kni: fix MTU change to setup Tx queue

This patch adds a fix to setup Tx queue when changing KNI interface MTU. It ensures device can safely start txq post MTU change operation. Fixes: fc9ee41b7016 ("examples/kni: convert to new ethdev offloads API") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- examples/kni/main.c | 14 +++

[dpdk-dev] [PATCH v2 1/2] net/qede: fix assignment of Rx/Tx handlers

Fix to assign dummy Rx/Tx handlers in dev_stop. For MTU set, assignment of the appropriate Rx/Tx handlers will be handled by dev_start/dev_stop. Fixes: 81f8804992c9 ("net/qede: enhance Rx CPU utilization") Fixes: 8de0c4201926 ("net/qede: fix odd number of queues usage in 100G mode") Cc: sta...@dpd

[dpdk-dev] [PATCH v2] net/qede: fix link state configuration

Move link state enable/disable to dev_start() and dev_stop() respectively. This will ensure when devices are stopped, link status will be appropriately shown as down. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh Signed-off-by: R

Re: [dpdk-dev] [PATCH] net/bnxt: add support for 200G link speed

On Tue, May 12, 2020 at 9:35 PM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > When the driver is loaded on a 200G NIC, the port speed is not > displayed correctly. Parse the 200G speed before displaying it. > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotu

[dpdk-dev] [PATCH] test/graph: fix memory leak

From: Kiran Kumar K Fix memory leaks reported by coverity. Signed-off-by: Kiran Kumar K --- app/test/test_graph.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/test_graph.c b/app/test/test_graph.c index cf6df0744..ed69eda99 100644 --- a/app/test/test_graph

[dpdk-dev] [Bug 475] failure in `EAL flags autotest`

https://bugs.dpdk.org/show_bug.cgi?id=475 Bug ID: 475 Summary: failure in `EAL flags autotest` Product: DPDK Version: 20.05 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority:

[dpdk-dev] [Bug 474] auto-test report crash while manual test skips

https://bugs.dpdk.org/show_bug.cgi?id=474 Bug ID: 474 Summary: auto-test report crash while manual test skips Product: DPDK Version: 20.05 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major

[dpdk-dev] [Bug 473] variance in test case fail for static and shared build binaries

https://bugs.dpdk.org/show_bug.cgi?id=473 Bug ID: 473 Summary: variance in test case fail for static and shared build binaries Product: DPDK Version: 20.05 Hardware: x86 OS: Linux Status: UNCONFI

[dpdk-dev] 答复: [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

> -邮件原件- > 发件人: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > 发送时间: 2020年5月14日 9:22 > 收件人: Lilijun (Jerry) ; 'dev@dpdk.org' > > 抄送: wangyunjian ; xudingke > ; 'sta...@dpdk.org' ; nd > ; yipeng1.w...@intel.com; Honnappa Nagarahalli > ; nd > 主题: RE: [dpdk-dev] [PATCH] lib/l

[dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

The function of rte_ipv4_cksum for calculating the checksum of IPv4 header is incorrect. This function will return checksum value like 0x. This value, however, is considered an illegal checksum on some switches(like Trident3). RFC 1624 specifies the IPv4 checksum as follows: https://tools.iet

Re: [dpdk-dev] [PATCH] eal: fix warnings on Windows

On 5/13/2020 5:43 PM, Dmitry Kozlyuk wrote: On Wed, 13 May 2020 15:53:41 -0700 Pallavi Kadam wrote: This patch fixes bunch of warnings when compiling on Windows such as the use of an unsafe string function (strerror), [-Wunused-const-variable] in getopt.c and [-Wunused-variable], [-Wunused-funct

Re: [dpdk-dev] [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

> > > > > > > > Adding Yipeng, maintainer for hash library > > > > > > > > > > > > > > Thanks for your reply. > > > > > > > > > > Using rte_hash iterate and delete keys is to free the related > > > > > data's > > > memory. > > > > > There are two reasons why rte_hash_reset() is not properly: > >

Re: [dpdk-dev] [PATCH v3] net/i40e: fix out of bounds read issue

Hi, > -Original Message- > From: Guo, Jia > Sent: Wednesday, May 13, 2020 2:51 PM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Xing, Beilei > Subject: Re: [PATCH v3] net/i40e: fix out of bounds read issue > > hi, chenxu > > On 5/13/2020 10:26 AM, Chenxu Di wrote: > > This patch fixes (out-o

Re: [dpdk-dev] [PATCH] app/test: Fix test_stats for dpaa_sec

> -Original Message- > From: Apeksha Gupta > Sent: Thursday, May 14, 2020 1:19 AM > To: dev@dpdk.org > Cc: Ruifeng Wang ; declan.dohe...@intel.com; > asoma...@amd.com; ano...@marvell.com; roy.fan.zh...@intel.com; > fiona.tr...@intel.com; rnagadhee...@marvell.com; adwiv...@marvell.com; >

Re: [dpdk-dev] [RFC] eal: adjust barriers for IO on Armv8-a

> > > > > > > > Subject: [RFC] eal: adjust barriers for IO on Armv8-a > > > > > > > > > > > > Change the barrier APIs for IO to reflect that Armv8-a is > > > > > > other-multi-copy atomicity memory model. > > > > > > > > > > > > Armv8-a memory model has been strengthened to require > > > > > > oth

[dpdk-dev] 答复: [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

> -邮件原件- > 发件人: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > 发送时间: 2020年5月14日 3:27 > 收件人: Lilijun (Jerry) ; 'dev@dpdk.org' > > 抄送: wangyunjian ; xudingke > ; 'sta...@dpdk.org' ; nd > ; yipeng1.w...@intel.com; nd ; Honnappa > Nagarahalli ; nd > 主题: RE: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH] eal: fix warnings on Windows

On Wed, 13 May 2020 15:53:41 -0700 Pallavi Kadam wrote: > This patch fixes bunch of warnings when compiling on Windows > such as the use of an unsafe string function (strerror), > [-Wunused-const-variable] in getopt.c and > [-Wunused-variable], [-Wunused-function] in eal_common_options.c > > Signe

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

On 2020-05-13 21:40, Honnappa Nagarahalli wrote: > > Subject: Re: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics On Tue, May 12, 2020 at 4:03 pm, Phil Yang wrote: parameter. Signed-off-by: Phil Yang >>

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

On 2020-05-12 20:20, Stephen Hemminger wrote: > On Tue, May 12, 2020 at 4:03 pm, Phil Yang wrote: >> parameter. Signed-off-by: Phil Yang > > > > > What is the purpose of having rte_atomic at all? > Is this level of indirection really helping? > To allow a different imple

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

On 2020-05-13 10:57, Morten Brørup wrote: >> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> Sent: Tuesday, May 12, 2020 9:24 PM >> >> >> >> Subject: Re: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics >> >> On Tue, May 12, 2020 at 4:03 pm, Phil Yang

[dpdk-dev] [PATCH] eal: fix warnings on Windows

This patch fixes bunch of warnings when compiling on Windows such as the use of an unsafe string function (strerror), [-Wunused-const-variable] in getopt.c and [-Wunused-variable], [-Wunused-function] in eal_common_options.c Signed-off-by: Ranjit Menon Signed-off-by: Pallavi Kadam Tested-by: Pal

Re: [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing

-Original Message- From: Stephen Hemminger Date: Tuesday, May 12, 2020 at 1:40 PM To: Yong Wang Cc: "dev@dpdk.org" , Stephen Hemminger Subject: [PATCH] net/vmxnet3: handle bad host framing The VMXNet3 protocol has a start-of-packet (SOP) and end-of-packet (EOP) marker. If there

[dpdk-dev] [PATCH] test/graph_perf: fix memory leaks

From: Pavan Nikhilesh Fix memory leaks reported by coverity. Coverity issue: 358440, 358441, 358446. Fixes: 61d77071ab99 ("test/graph: add performance tests") Signed-off-by: Pavan Nikhilesh --- app/test/test_graph_perf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test/test_

[dpdk-dev] [PATCH] app/eventdev: fix unchecked function return values

From: Pavan Nikhilesh Fix unchecked return values reported by coverity. Coverity issue: 357755 Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 8 ++-- 1 file changed, 6 insertions(+)

[dpdk-dev] [PATCH] examples/l3fwd-graph: fix unchecked function return values

From: Pavan Nikhilesh Fix unchecked return values reported by coverity. Coverity issue: 350601 Fixes: ef853f1fd979 ("examples/l3fwd-graph: add ethdev configuration changes") Signed-off-by: Pavan Nikhilesh --- examples/l3fwd-graph/main.c | 10 +- 1 file changed, 9 insertions(+), 1 dele

[dpdk-dev] [PATCH] examples/l3fwd: fix unchecked function return values

From: Pavan Nikhilesh Fix unchecked return values reported by coverity. Coverity issue: 354235 Fixes: 8bd537e9c6cf ("examples/l3fwd: add service core setup based on caps") Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH] net/mlx5: fix VLAN actions with wildcard VLAN iten

Previous patch added support of VLAN item without VLAN ID value, i.e. using wildcard VLAN item, to match VLAN with any VLAN ID. The implication on VLAN actions was not taken into consideration. VLAN actions (e.g. push vlan) use the VLAN ID value in the VLAN item, and expect it to be valid. This pa

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

> >> > >> Subject: Re: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics > >> > >> On Tue, May 12, 2020 at 4:03 pm, Phil Yang > >> wrote: > >> > >> parameter. Signed-off-by: Phil Yang > >> > >> > >> What is the purpose of having rte_atomi

Re: [dpdk-dev] [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

> > > > > > Adding Yipeng, maintainer for hash library > > > > > > > > Thanks for your reply. > > > > > > Using rte_hash iterate and delete keys is to free the related data's > memory. > > > There are two reasons why rte_hash_reset() is not properly: > > > 1) the reset function just clear all key

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

On 2020-04-14 19:55, Mattias Rönnblom wrote: > On 2020-04-14 18:15, Jerin Jacob wrote: > >> One more concern we have we are adding API for the new driver requirements >> and >> not updating the example application. Sharing the example application >> patch would >> enable us to understand the cost

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/crypto: fix gcc 10 no-common errors

On 5/13/2020 2:50 PM, akhil.go...@nxp.com wrote: > From: Akhil Goyal > > gcc 10 defaults to -fno-common and as a result when linking > with crypto drivers: > > drivers/librte_pmd_dpaa_sec.a(crypto_dpaa_sec_dpaa_sec.c.o): > (.bss+0x4): multiple definition of `rta_sec_era'; > drivers/librte_pmd_ca

[dpdk-dev] [PATCH v2] meter: provide experimental alias of API for old apps

On v20.02 some meter APIs have been matured and symbols moved from EXPERIMENTAL to DPDK_20.0.1 block. This can break the applications that were using these mentioned APIs on v19.11. Although there is no modification on the APIs and the action is positive and matures the APIs, the affect can be neg

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: add per core packet stats

Adding per core packet handling stats to analyze traffic distribution when multiple cores are engaged. Since aggregating the packet stats across cores would affect performance, keeping the feature disabled using compile time flags. Signed-off-by: Anoob Joseph --- v4: * Moved print stats routine

Re: [dpdk-dev] [PATCH] meter: provide experimental alias of API for old apps

On 5/13/2020 5:30 PM, Thomas Monjalon wrote: > I think the title should be about ABI, not API. > > 13/05/2020 14:11, Ferruh Yigit: >> Duplicate the existing and versioned symbol as experimental. > > Would be good to explain the case of the meter lib you are addressing. > If I understand well, you

[dpdk-dev] [PATCH] app/test: Fix test_stats for dpaa_sec

Test case test_stats should be unsupported for dpaa_sec and return -ENOTSUP. Signed-off-by: Apeksha Gupta --- app/test/test_cryptodev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index c624018ee..5aafe52f1 100644 --- a/app/test/tes

[dpdk-dev] [PATCH] ring: empty and count optimizations

Testing if the ring is empty is as simple as comparing the producer and consumer pointers. In theory, this optimization reduces the number of potential cache misses from 3 to 2 by not having to read r->mask in rte_ring_count(). It is not possible to enqueue more elements than the capacity of a rin

Re: [dpdk-dev] [PATCH] drivers/crypto: fix gcc 10 no-common errors

On 13/05/2020 14:50, akhil.go...@nxp.com wrote: > From: Akhil Goyal > > gcc 10 defaults to -fno-common and as a result when linking > with crypto drivers: > > drivers/librte_pmd_dpaa_sec.a(crypto_dpaa_sec_dpaa_sec.c.o): > (.bss+0x4): multiple definition of `rta_sec_era'; > drivers/librte_pmd_caa

Re: [dpdk-dev] [PATCH] meter: provide experimental alias of API for old apps

I think the title should be about ABI, not API. 13/05/2020 14:11, Ferruh Yigit: > Duplicate the existing and versioned symbol as experimental. Would be good to explain the case of the meter lib you are addressing. If I understand well, you consider we "broke" the experimental ABI during 20.02 whe

Re: [dpdk-dev] [PATCH] net/qede: fix link state configuration

On Tue, May 12, 2020 at 6:16 AM Rasesh Mody wrote: > > Move link state enable/disable to dev_start() and dev_stop() > respectively. This will ensure when devices are stopped, > link status will be appropriately shown as down. > > Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") I a

Re: [dpdk-dev] [PATCH v5] ethdev: fix DCB set failure

> -Original Message- > From: dev On Behalf Of Ting Xu > Sent: Wednesday, May 13, 2020 6:16 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; > arybche...@solarflare.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v5] ethdev: fix DCB set failure > > When rte_eth_dev_rss

[dpdk-dev] [PATCH] ring: empty and count optimizations

Testing if the ring is empty is as simple as comparing the producer and consumer pointers. In theory, this optimization reduces the number of potential cache misses from 3 to 2 by not having to read r->mask in rte_ring_count(). It is not possible to enqueue more elements than the capacity of a rin

Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak

On 5/13/2020 2:55 PM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Mcnamara, John >> Sent: Wednesday, May 13, 2020 1:46 PM >> To: Dumitrescu, Cristian >> Cc: dev@dpdk.org; Singh, Jasvinder >> Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak >> >>> -O

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

> > Subject: RE: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics > > > > > From: Phil Yang [mailto:phil.y...@arm.com] > > > Sent: Tuesday, May 12, 2020 10:03 AM > > > > > > Wraps up compiler c11 atomic built-ins with explicit memory ordering > > > parameter. > > > > > > Signed-off-by: Phil

[dpdk-dev] [PATCH] ring: empty and count optimizations

Testing if the ring is empty is as simple as comparing the producer and\nconsumer pointers.\nIn theory, this optimization reduces the number of potential cache misses\nfrom 3 to 2 by not having to read r->mask in rte_ring_count().\n\nIt is not possible to enqueue more elements than the capacit

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

> > Subject: Re: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics > > > > On Tue, May 12, 2020 at 4:03 pm, Phil Yang > > wrote: > > > > parameter. Signed-off-by: Phil Yang > > > > > > What is the purpose of having rte_atomic at all? > > I

Re: [dpdk-dev] [PATCH] net/mlx5: fix counter container resize

> -Original Message- > From: Matan Azrad > Sent: Tuesday, May 12, 2020 15:52 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix counter container resize > > The design of counter container resize used double buffer algorithm in order > to synchroni

Re: [dpdk-dev] [PATCH v3 0/4] Memory corruption due to HW rings allocation

On 5/13/2020 2:14 PM, Renata Saiakhova wrote: > igb and ixgbe and some other drivers allocate HW rings using > rte_eth_dma_zone_reserve(), > which checks first if the memzone exists for a given name, consisting of port > id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

> > > > > > Subject: Re: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics > > > > On Tue, May 12, 2020 at 4:03 pm, Phil Yang > wrote: > > > > parameter. Signed-off-by: Phil Yang > > > > > > What is the purpose of having rte_atomic at all?

Re: [dpdk-dev] [RFC] eal: adjust barriers for IO on Armv8-a

On Wed, May 13, 2020 at 3:14 AM Honnappa Nagarahalli wrote: > > > > > > > > Subject: [RFC] eal: adjust barriers for IO on Armv8-a > > > > > > > > > > Change the barrier APIs for IO to reflect that Armv8-a is > > > > > other-multi-copy atomicity memory model. > > > > > > > > > > Armv8-a memory mod

[dpdk-dev] [PATCH] i40e: i40evf link status is always down with the Intel XL710 driver

It is necessary to convert the link_speed, in Mbps, to the I40E_LINK_SPEED enum Fixes: 3c8c0b68b590 ("net/i40e: set speed to undefined for default case") Cc: laurent.ha...@6wind.com Bugzilla ID: 461 Signed-off-by: scott_wasson --- drivers/net/i40e/i40e_ethdev_vf.c | 25 ++

[dpdk-dev] [PATCH] drivers/crypto: fix gcc 10 no-common errors

From: Akhil Goyal gcc 10 defaults to -fno-common and as a result when linking with crypto drivers: drivers/librte_pmd_dpaa_sec.a(crypto_dpaa_sec_dpaa_sec.c.o): (.bss+0x4): multiple definition of `rta_sec_era'; drivers/librte_pmd_caam_jr.a(crypto_caam_jr_caam_jr.c.o): (.bss+0x0): first defined he

Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

Hi Ray, I could not find validate_abi using libabigail.abignore. Am I missing something. Though check_abi.sh uses it. When I am checking with validate_abi.sh, I still see warnings. Regards, Hemant > -Original Message- > From: Hemant Agrawal > Sent: Wednesday, May 13, 2020 6:

Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak

> -Original Message- > From: Mcnamara, John > Sent: Wednesday, May 13, 2020 1:46 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder > Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak > > > -Original Message- > > From: dev On Behalf Of Jasvinder

[dpdk-dev] [PATCH v3 12/12] bus/fslmc: remove unused symbols

rte_dpaa2_memsegs is not being used by any other library or even within bus. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c| 6 -- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 - 3 files changed, 10 delet

[dpdk-dev] [PATCH v3 07/12] net/dpaa: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.h| 2 ++ drivers/net/dpaa/rte_pmd_dpaa_version.map | 9 - 2 files changed, 10 insertions(+), 1

[dpdk-dev] [PATCH v3 11/12] bus/fslmc: share mcp ptr as function across libs

Currently rte_mcp_ptr_list is being shared as a variable across libs. This is only used in control path. This patch change it to a exported function based access. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 15 --- drivers/bus/fslmc/portal/dpaa2_hw

[dpdk-dev] [PATCH v3 10/12] bus/dpaa: change netcfg access as function

This patch changes the export of fman port config as function call instead of direct variable access. This is in control path, so it will not impact perf. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 6 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + driv

[dpdk-dev] [PATCH v3 08/12] bus/dpaa: share qman portal ids as function calls

qman caam and pool portal ids are only used in control path. This patch changes their inter library access to function call instead of direct shared variable. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 10 ++ drivers/bus/dpaa/include/fsl_qman.h |

[dpdk-dev] [PATCH v3 09/12] bus/dpaa: move log into to respective dpaa drivers

This is to reduce the number of variables getting exposed from the dpaa bus. They are not required to be in bus. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 19 +--- drivers/bus/dpaa/rte_bus_dpaa_version.map | 4 -- drivers/bus/dpaa/rte_dpaa_logs.h

[dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 3 +++ drivers/common/dpaax/dpaa_of.h| 15 +++ drivers/com

[dpdk-dev] [PATCH v3 06/12] net/dpaa2: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h| 2 ++ drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 2 +- 2 files changed, 3 insertions(+), 1 del

[dpdk-dev] [PATCH v3 04/12] bus/dpaa: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 2 ++ drivers/bus/dpaa/include/fsl_bman.h | 6 + drivers/bus/dpaa/include/fsl_fman.h

[dpdk-dev] [PATCH v3 05/12] crypto: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 2 ++ drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 5 +++-- drivers/crypto

[dpdk-dev] [PATCH v3 03/12] bus/fslmc: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which were not used anywhere else i.e. rte_fslmc_vfio_dmamap & dpaa2_get_qbman_swp Signed-off-by: Hemant Agrawal --- devtools/libabigail.ab

[dpdk-dev] [PATCH v3 02/12] mempool/dpaa2: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal -- v3: add entry in libabigail.abinore file --- devtools/libabigail.abignore| 2 ++ drivers/mempool/dpaa/rte_mempool_dpaa_v

[dpdk-dev] [PATCH v3 00/12] NXP DPAAx: move internal symbols to INTERNAL

This patchset moves the internal symbol to the INTERNAL sections This patch also change some of the shared variables to function calls. (Mostly control path used variables). Hemant Agrawal (12): common/dpaax: move internal symbols into INTERNAL section mempool/dpaa2: move internal symbols in

Re: [dpdk-dev] [PATCH v5] ethdev: fix DCB set failure

On 5/13/2020 6:16 PM, Ting Xu wrote: > When rte_eth_dev_rss_hash_conf_get() is called, if the variable > rss_conf is not initialized, the pointer member variable rss_key > may have a random address, which leads to an error in the following > processing. This patch initialized the variable rss_conf

Re: [dpdk-dev] [RFC v2] hash: unify crc32 API header for x86 and ARM

> > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Wednesday, May 13, 2020 4:40 AM > > To: jer...@marvell.com; konstantin.anan...@intel.com; > > harry.van.haa...@intel.com; Yipeng Wang ; > > Sameh Gobriel ; Bruce Richardson > > ; Ruifeng Wang > > Cc: dev@dpdk.org; Pava

Re: [dpdk-dev] [PATCH] doc: fix wrong config option

On 12/05/2020 21:48, Matteo Croce wrote: > External Email > > -- > The documentation says that CONFIG_ENABLE_LTO enables LTO during the > build, but the correct value actually is CONFIG_RTE_ENABLE_LTO > > Fixes: 098cc0fea3be ("bu

[dpdk-dev] [PATCH v3 2/4] drivers/net: Fix in igb and ixgbe HW rings memory

Delete memzones for HW rings in igb and ixgbe while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/igb_rxtx.c | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 68

[dpdk-dev] [PATCH v3 3/4] drivers/net: Fix in i40e HW rings memory overlap

Delete memzones for HW rings in i40e while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/i40e/i40e_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 5e7c86ed8..99cec9b99 100644 --- a/drivers/net/i40e/i4

[dpdk-dev] [PATCH v3 4/4] drivers/net: Fix in em and ice HW rings memory overlap

Delete memzones for HW rings in em and ice while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/em_rxtx.c | 2 ++ drivers/net/ice/ice_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index 49c53712a..67

[dpdk-dev] [PATCH v3 0/4] Memory corruption due to HW rings allocation

igb and ixgbe and some other drivers allocate HW rings using rte_eth_dma_zone_reserve(), which checks first if the memzone exists for a given name, consisting of port id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id. If the memzone with a given name exists it is return

[dpdk-dev] [PATCH v3 1/4] librte_ethdev: Introduce a function to release HW rings

Free previously allocated memzone for HW rings Signed-off-by: Renata Saiakhova --- lib/librte_ethdev/rte_ethdev.c | 28 ++-- lib/librte_ethdev/rte_ethdev_driver.h| 20 + lib/librte_ethdev/rte_ethdev_version.map | 1 + 3 files changed, 47 inserti

Re: [dpdk-dev] [PATCH v2] node: fix arm64 build issue for older gcc

On Wed, May 13, 2020 at 2:36 PM Jerin Jacob wrote: > > On Wed, May 13, 2020 at 5:36 PM Nithin Dabilpuram > wrote: > > > > Older GCC(~4) complains about uninitialized 'dip' > > var though all the lanes of the vec register are set. > > Hence this patch explicitly initializes vec register > > to fix

Re: [dpdk-dev] [PATCH] doc: fix wrong config option

On Tue, May 12, 2020 at 9:49 PM Matteo Croce wrote: > > The documentation says that CONFIG_ENABLE_LTO enables LTO during the > build, but the correct value actually is CONFIG_RTE_ENABLE_LTO > > Fixes: 098cc0fea3be ("build: add option to enable LTO") Cc: sta...@dpdk.org > Signed-off-by: Matteo Cr

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix DCB set failure

13/05/2020 10:54, Iremonger, Bernard: > The fix is no longer in testpmd, so the commit line should be "ethdev: fix > DCB set failure". In general, the word "failure" (or error, etc) is not needed. Because it is a fix, we know there was a failure before :) And specifically here, you are not fixin

Re: [dpdk-dev] [PATCH 20.08] buildtools/map_to_def.py: drop python2 support

On Wed, May 13, 2020 at 12:54:21PM +0100, Burakov, Anatoly wrote: > On 13-May-20 12:02 PM, Bruce Richardson wrote: > > The build scripts called from meson all use python3 as meson itself depends > > upon python3. Therefore there is no need for python2 compatibility in these > > script files. > > >

Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak

> -Original Message- > From: dev On Behalf Of Jasvinder Singh > Sent: Monday, April 27, 2020 3:03 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak > > When sending request messages to data plane pipelines, the caller must > fre

Re: [dpdk-dev] [PATCH v2 01/12] common/dpaax: move internal symbols into INTERNAL section

12/05/2020 16:00, Hemant Agrawal: > This patch moves the internal symbols to INTERNAL sections > so that any change in them is not reported as ABI breakage. > > Signed-off-by: Hemant Agrawal > --- > drivers/common/dpaax/dpaa_of.h| 15 +++ > drivers/common/dpaax/dp

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats

> > > @@ -1099,6 +1151,10 @@ ipsec_poll_mode_worker(void) > > > const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) > > > / US_PER_S * BURST_TX_DRAIN_US; > > > struct lcore_rx_queue *rxql; > > > +#if (STATS_INTERVAL > 0) > > > + const uint64_t timer_period = STATS_I

Re: [dpdk-dev] [PATCH v2] node: fix arm64 build issue for older gcc

On Wed, May 13, 2020 at 5:36 PM Nithin Dabilpuram wrote: > > Older GCC(~4) complains about uninitialized 'dip' > var though all the lanes of the vec register are set. > Hence this patch explicitly initializes vec register > to fix the issue. > > In file included from ip4_lookup.c:34:0: > ip4_looku

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

Hi Olivier, Any thoughts on this ? On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > > > On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

> -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, May 13, 2020 12:39 PM > To: Fady Bader > Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV) > ; Narcisa Ana Maria Vasile > ; Tal Shnaiderman ; > Thomas Monjalon ; Harini Ramakrishnan > ; Omar Cardona > ; Pallavi Kadam ; > Ranji

Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers

> -Original Message- > From: Gaëtan Rivet > Sent: Wednesday, May 13, 2020 11:04 AM > To: Stephen Hemminger > Cc: Stojaczyk, Dariusz ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers > > [SNIP] > > The original code predates the change from macro

Re: [dpdk-dev] [PATCH] net/ice: fix RSS for GTPU

Test-by Simei, Su > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 13, 2020 8:12 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Su, Simei ; Ye, Xiaolong > ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH] net/ice: fix RSS for GTPU > > All supported pattern for GTPU include

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats

> > > > > > +#if (STATS_INTERVAL > 0) > > > + > > > +/* Print out statistics on packet distribution */ static void > > > +print_stats(void) > > > +{ > > > + uint64_t total_packets_dropped, total_packets_tx, total_packets_rx; > > > + unsigned int coreid; > > > + float burst_percent; > > > + > > > +

[dpdk-dev] [PATCH] meter: provide experimental alias of API for old apps

Duplicate the existing and versioned symbol as experimental. This is to prevent DPDK maturing experimental API breaking old applications using that experimental API. The relevant process update is captured in: https://patches.dpdk.org/patch/65863/ Created VERSION_SYMBOL_EXPERIMENTAL helper macro.

  1   2   >