Re: [dpdk-dev] [PATCH v2] app/testpmd: support flow aging

2020-04-30 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > On 4/30/2020 4:53 PM, Bill Zhou wrote: > > Currently, there is no way to check the aging event or to get the > > current aged flows in testpmd, this patch include those implements, it's > included: > > - Registering aging event when the testpmd application start, add

Re: [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows

2020-04-30 Thread Ranjit Menon
On 4/30/2020 12:30 AM, Dmitry Kozlyuk wrote: On 2020-04-30 08:52 GMT+0200 Thomas Monjalon wrote: 30/04/2020 01:24, Pallavi Kadam: Added fnmatch implementation on Windows to support log level arguments. The source file is with BSD-3-Clause license. https://github.com/lattera/freebsd/blob/master/

Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread Ferruh Yigit
On 4/30/2020 2:37 PM, Yuan Linsi wrote: > From: yuanlinsi01 > > We see a stack smashing as a result of defensive code missing. Once the > nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to > zero after doing a floor align, and we can not exit the following > receiving packets lo

Re: [dpdk-dev] [PATCH v5 1/2] virtio: one way barrier for split vring used idx

2020-04-30 Thread Ferruh Yigit
On 4/30/2020 10:14 AM, Joyce Kong wrote: > In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend > and backend are assumed to be implemented in software, that is they can > run on identical CPUs in an SMP configuration. > Thus a weak form of memory barriers like rte_smp_r/wmb, ot

Re: [dpdk-dev] [PATCH v2] app/testpmd: support flow aging

2020-04-30 Thread Ferruh Yigit
On 4/30/2020 4:53 PM, Bill Zhou wrote: > Currently, there is no way to check the aging event or to get the current > aged flows in testpmd, this patch include those implements, it's included: > - Registering aging event when the testpmd application start, add new > command to control if the event

Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging

2020-04-30 Thread Ferruh Yigit
On 4/27/2020 4:12 PM, Matan Azrad wrote: > Hi > > From: Ferruh Yigit >> On 4/26/2020 8:23 AM, Bill Zhou wrote: >>> >>> -Original Message- From: Ferruh Yigit Sent: Saturday, April 25, 2020 12:25 AM To: Bill Zhou ; wenzhuo...@intel.com; jingjing...@intel.com; bernar

Re: [dpdk-dev] [PATCH 0/2] Windows logging

2020-04-30 Thread Kadam, Pallavi
On 4/29/2020 11:48 PM, Thomas Monjalon wrote: 30/04/2020 01:24, Pallavi Kadam: This patchset adds EAL logging support on Windows. Logs will be sent to console output. Pallavi Kadam (2): eal: initialize eal logging on Windows eal: add fnmatch implementation on Windows fnmatch is requi

Re: [dpdk-dev] [RFC] ring: count and empty optimizations

2020-04-30 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > Hi Morten, > > > > > > > > On Tue, Apr 28, 2020 at 03:53:15PM +0200, Morten Brørup wrote: > > > > > Olivier (maintainer of the Ring), > > > > > > > > I'm not anymore, CC'ing Konstantin and Honnappa. > > > > > > > > > I would like to suggest a couple of minor optimizatio

[dpdk-dev] VIRTIO DPDK

2020-04-30 Thread kumaraparameshwaran rathinavel
Hi All, We are using 16.04 version of DPDK and I am using the virtio driver in the guest VM which uses virtio_recv_mergeable_pkts in the rx_code path and I am thinking that there can be an infinite loop. Please let me know if this could happen and was there any bugs reported related to this and I

[dpdk-dev] [PATCH] net/bnxt: mark handling needs to look at meta_fmt instead of meta data

2020-04-30 Thread Venkat Duvvuru
From: Mike Baucom The current mark handling uses the meta data field of the rxcmp as the first level check for determining gfid vs lfid. When the meta data is zero due to only the lowest 16bits of the gfid being set, the cfa code is incorrectly interpreted as being an lfid. Changing code to loo

Re: [dpdk-dev] [PATCH v5 0/2] one way barrier for split vring idx

2020-04-30 Thread Maxime Coquelin
On 4/30/20 11:14 AM, Joyce Kong wrote: > This patchset replaces the two-way barriers with C11 one-way barriers > for split vring idx, when the frontend and backend are implemented > in software. > > By doing PVP benchmarking, the test result of 2c1q showed the throughput > increased 20% with th

Re: [dpdk-dev] [PATCH v2] examples/vhost_blk: refactor vhost-blk example

2020-04-30 Thread Maxime Coquelin
On 4/30/20 7:20 PM, Jin Yu wrote: > Decrease the code and make it easier to read. It's > useful for understanding the inflight APIs and how > packed ring works. Update the RST because the packed > ring patch has been merged to QEMU master and ring_packed > parameter changes to packed. > > Fixes

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-30 Thread Dan Gora
On Thu, Apr 30, 2020 at 5:29 PM Luca Boccassi wrote: > > > Adding a new dependecy happens only when building with the new version > > > of the library. If it's not available, then there's no new dependency. > > > > But you also do not get to use the new getentropy() if you happen to > > compile o

Re: [dpdk-dev] [PATCH v2] examples/vhost_blk: refactor vhost-blk example

2020-04-30 Thread Maxime Coquelin
On 4/30/20 7:20 PM, Jin Yu wrote: > Decrease the code and make it easier to read. It's > useful for understanding the inflight APIs and how > packed ring works. Update the RST because the packed > ring patch has been merged to QEMU master and ring_packed > parameter changes to packed. > > Fixes

Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-04-30 Thread Honnappa Nagarahalli
> > > > > >> Subject: Re: [PATCH] test/ring: fix long compilation time > >> > >> Honnappa Nagarahalli writes: > >> > >> > test_ring.c takes lot of time to compile with clang. It is > >> > reproducable with compiler version 8.0 on Ubuntu 18.04. > >> > Amount of testing is reduced, but attempt is m

Re: [dpdk-dev] [PATCH v2] eal/ppc: fix redefine bool type

2020-04-30 Thread David Christensen
On 4/30/20 7:22 AM, Ori Kam wrote: The AltiVec header file breaks boolean type. [1] [2] Currently the workaround was located only in mlx5 device. Adding the trace module caused this issue to appear again, due to order of includes, it keeps overriding the local fix. This patch solves this iss

[dpdk-dev] [PATCH 7/7] net/netvsc: don't configure RSS if disabled

2020-04-30 Thread Stephen Hemminger
This fixes the problem where driver would not start if only have a single Rx queue and multiple Txq. In that case, RSS should stay disabled. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 25 +++

[dpdk-dev] [PATCH 5/7] net/netvsc: manage VF port under rwlock

2020-04-30 Thread Stephen Hemminger
With multiple channels, the primary channel may receive notification that VF has been added or removed while secondary channel is in process of doing receive or transmit. Resolve this race by converting existing vf_lock to a reader/writer lock. Users of lock (tx/rx/stats) acquire for read, and ac

[dpdk-dev] [PATCH 3/7] net/vmbus: add missing barrier

2020-04-30 Thread Stephen Hemminger
The check for event ring being empty needs a barrier to avoid any over agressive optimization. This is same barrier as Linux kernel. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/vmbus_channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vmbus/vmbus_channel.c b/dri

[dpdk-dev] [PATCH 1/7] net/netvsc: fix comment spelling errors

2020-04-30 Thread Stephen Hemminger
No code change here. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 +- drivers/net/netvsc/hn_nvs.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 05f1a25a1abc..46da5a4e8170

[dpdk-dev] [PATCH 6/7] net/netvsc: do RSS across rx queue only

2020-04-30 Thread Stephen Hemminger
If number of tx queues is greater than the number of rx queues; the driver ends up allocating more channels than rx queues. The problem is that the RSS indirection table is programed such that some packets will end up on a channel that would never be polled. The fix is to limit the RSS indirection

[dpdk-dev] [PATCH 4/7] net/netvsc: check the vmbus ring buffer more often

2020-04-30 Thread Stephen Hemminger
Since VF notfications are handled as VMBUS notifications on the primary channel (and not as hotplug). The channel should be checked before deciding to use VF for Rx or Tx. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 22 -- 1 file changed, 12 insertions

[dpdk-dev] [PATCH 0/7] net/netvsc: more minor fixes

2020-04-30 Thread Stephen Hemminger
These are fixes for several small issues found during review and my testing of netvsc PMD. Stephen Hemminger (7): net/netvsc: fix comment spelling errors bus/vmbus: fix comment spelling errors net/vmbus: add missing barrier net/netvsc: check the vmbus ring buffer more often net/netvsc: m

[dpdk-dev] [PATCH 2/7] bus/vmbus: fix comment spelling errors

2020-04-30 Thread Stephen Hemminger
No code change here. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 2 +- drivers/bus/vmbus/vmbus_common.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c index 10e50c

Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread Ajit Khaparde
On Thu, Apr 30, 2020 at 6:45 AM Lance Richardson < lance.richard...@broadcom.com> wrote: > On Thu, Apr 30, 2020 at 9:37 AM Yuan Linsi wrote: > > > > From: yuanlinsi01 > > > > We see a stack smashing as a result of defensive code missing. Once the > > nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP,

Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header options

2020-04-30 Thread Ananyev, Konstantin
> When fragmenting ipv4 packet, the data offset should be calculated through > the ihl field in ip header rather than using sizeof(struct > rte_ipv4_hdr). Seems you missed my comments, except the very first one. Please look at my email and try to address all of them. > > Fixes: 4c38e5532a07 ("i

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread David Christensen
Why is this needed? It's hardware specific to the PPC64 platform.  I don't know of a situation where the IOMMU would be present on other hardware.  Even running a VM in KVM/QEMU on a PPC64 platform results in a SPAPR V1 IOMMU which isn't supported in DPDK. Dave Yes, but generally #ifdef's

Re: [dpdk-dev] [PATCH 2/2] vfio: modify spapr iommu support to use static window sizing

2020-04-30 Thread David Christensen
On 4/30/20 4:34 AM, Burakov, Anatoly wrote: On 30-Apr-20 12:29 AM, David Christensen wrote: Current SPAPR IOMMU support code dynamically modifies the DMA window size in response to every new memory allocation. This is potentially dangerous because all existing mappings need to be unmapped/rem

Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-04-30 Thread Aaron Conole
Honnappa Nagarahalli writes: > > >> Subject: Re: [PATCH] test/ring: fix long compilation time >> >> Honnappa Nagarahalli writes: >> >> > test_ring.c takes lot of time to compile with clang. It is >> > reproducable with compiler version 8.0 on Ubuntu 18.04. >> > Amount of testing is reduced, b

Re: [dpdk-dev] eal: can not run secondary process on openstack environment

2020-04-30 Thread Bruce Richardson
On Thu, Apr 30, 2020 at 09:09:02AM -0700, Stephen Hemminger wrote: > On Thu, 30 Apr 2020 10:14:57 +0100 > "Burakov, Anatoly" wrote: > > > On 30-Apr-20 5:14 AM, 陈亚辉-云杉研发部 wrote: > > > Deleting xdg_runtime_dir and fallback, runtime_dir will always be > > > "/var/run" defined by code: > > > static

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread Burakov, Anatoly
On 30-Apr-20 5:22 PM, David Christensen wrote: Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- Why is this needed? It's hardware specific to the PPC64 platform.  I don't know of a situation where the IOMMU would be present on other hardware.  Ev

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread David Christensen
Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- Why is this needed? It's hardware specific to the PPC64 platform. I don't know of a situation where the IOMMU would be present on other hardware. Even running a VM in KVM/QEMU on a PPC64 platform

Re: [dpdk-dev] eal: can not run secondary process on openstack environment

2020-04-30 Thread Stephen Hemminger
On Thu, 30 Apr 2020 10:14:57 +0100 "Burakov, Anatoly" wrote: > On 30-Apr-20 5:14 AM, 陈亚辉-云杉研发部 wrote: > > Deleting xdg_runtime_dir and fallback, runtime_dir will always be > > "/var/run" defined by code: > > static const char *default_runtime_dir = "/var/run" > > > > I'm not sure this is a g

Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-04-30 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH] test/ring: fix long compilation time > > Honnappa Nagarahalli writes: > > > test_ring.c takes lot of time to compile with clang. It is > > reproducable with compiler version 8.0 on Ubuntu 18.04. > > Amount of testing is reduced, but attempt is made to keep the same > > c

[dpdk-dev] [PATCH v5 18/18] doc: update telemetry documentation

2020-04-30 Thread Ciara Power
The existing documentation for Telemetry is updated, and further documentation is added. Signed-off-by: Ciara Power Reviewed-by: Keith Wiles --- v4: - Removed JSON API from docs as it is now internal. - Updated guide to show use of data functions. --- doc/guides/howto/telemetry.rst

[dpdk-dev] [PATCH v5 17/18] eal: add eal telemetry callbacks

2020-04-30 Thread Ciara Power
From: Bruce Richardson EAL now registers commands to provide some basic info from EAL. Example: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.05.0-rc0", "pid": 72662, "max_output_len": 16384} --> / {"/": ["/", "/eal/app_params", "/eal/params", "/ethdev/link_status", \

[dpdk-dev] [PATCH v5 16/18] eal: remove rte-option infrastructure

2020-04-30 Thread Ciara Power
As Telemetry no longer uses rte_option, and was the only user of this infrastructure, it can now be removed. Signed-off-by: Ciara Power Reviewed-by: Keith Wiles --- lib/librte_eal/common/eal_common_options.c | 1 - lib/librte_eal/common/eal_private.h| 28 --- lib/librte_eal/common/

[dpdk-dev] [PATCH v5 15/18] lib: add telemetry as eal dependency

2020-04-30 Thread Ciara Power
This patch moves telemetry further down the build, and adds it as a dependency for EAL. Telemetry V2 is now configured to build by default, and the legacy support is built when the telemetry config flag is set. Telemetry now has EAL flags, shown below: "--telemetry" = Enables telemetry (this is de

[dpdk-dev] [PATCH v5 14/18] telemetry: remove existing telemetry files

2020-04-30 Thread Ciara Power
This patch removes the existing telemetry files, which are now redundant as the new version of telemetry has backward compatibility for their functionality. Signed-off-by: Ciara Power Reviewed-by: Keith Wiles --- lib/librte_metrics/rte_metrics_telemetry.c|9 - lib/librte_telemetry/Makef

[dpdk-dev] [PATCH v5 13/18] telemetry: introduce telemetry backward compatibility

2020-04-30 Thread Ciara Power
The new telemetry will now open a socket using the old telemetry path, to ensure backward compatibility. This is not yet initialised, as it would clash with the existing telemetry, to be removed in a later patch. This means that both old and new telemetry socket interfaces are handled in a common w

[dpdk-dev] [PATCH v5 11/18] rawdev: add callback support for telemetry

2020-04-30 Thread Ciara Power
The rawdev library now registers commands with telemetry, and implements the corresponding callback functions. These allow a list of rawdev devices and xstats for a rawdev port to be queried. An example usage, with ioat rawdev driver instances, is shown below: Connecting to /var/run/dpdk/rte/dpdk

[dpdk-dev] [PATCH v5 12/18] examples/l3fwd-power: enable use of new telemetry

2020-04-30 Thread Ciara Power
The l3fwd-power example app now registers a stats command with telemetry, and provides a callback function to handle formatting the power stats. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.05.0-rc0", "pid": 63384, "max_output_len": 16384

[dpdk-dev] [PATCH v5 10/18] ethdev: add callback support for telemetry

2020-04-30 Thread Ciara Power
From: Bruce Richardson The ethdev library now registers commands with telemetry, and implements the callback functions. These commands allow the list of ethdev ports and the xstats and link status for a port to be queried. An example using ethdev commands is shown below: Connecting to /var/run/

[dpdk-dev] [PATCH v5 08/18] telemetry: add default callback commands

2020-04-30 Thread Ciara Power
The default commands are now added to provide the list of commands available, help text for a specified command, and also information about DPDK and telemetry. Signed-off-by: Ciara Power Signed-off-by: Bruce Richardson Reviewed-by: Keith Wiles --- v4: Added help command to provide help text fo

[dpdk-dev] [PATCH v5 09/18] usertools: add new telemetry python script

2020-04-30 Thread Ciara Power
From: Bruce Richardson This patch adds a python script that can be used with the new telemetry socket. It connects as a client to the socket, and allows the user send a command and see the JSON response. The example usage below shows the script connecting to the new telemetry socket, and sending

[dpdk-dev] [PATCH v5 07/18] telemetry: add functions for returning callback data

2020-04-30 Thread Ciara Power
From: Bruce Richardson The functions added in this patch will help applications build up data in reply to a telemetry request. Signed-off-by: Bruce Richardson Reviewed-by: Keith Wiles --- lib/librte_telemetry/Makefile | 1 + lib/librte_telemetry/meson.build |

[dpdk-dev] [PATCH v5 06/18] telemetry: introduce new telemetry functionality

2020-04-30 Thread Ciara Power
From: Bruce Richardson This patch introduces a new telemetry connection socket and handling functionality. Like the existing telemetry implementation (which is unaffected by this change) it uses a unix socket, but unlike the existing one it does not have a fixed list of commands - instead librari

[dpdk-dev] [PATCH v5 05/18] telemetry: add utility functions for creating json

2020-04-30 Thread Ciara Power
From: Bruce Richardson The functions added in this patch will make it easier for telemetry to convert data to correct JSON responses to telemetry requests. Tests are also added for these json utility functions. Signed-off-by: Bruce Richardson Reviewed-by: Keith Wiles --- v4: Tests included i

[dpdk-dev] [PATCH v5 03/18] metrics: reduce code taken from telemetry

2020-04-30 Thread Ciara Power
The telemetry code that was moved into the metrics library can be shortened, while still maintaining the same functionality. Signed-off-by: Ciara Power Signed-off-by: Bruce Richardson Reviewed-by: Keith Wiles --- lib/librte_metrics/rte_metrics_telemetry.c | 484 lib/librt

[dpdk-dev] [PATCH v5 04/18] telemetry: invert dependency on metrics

2020-04-30 Thread Ciara Power
From: Bruce Richardson Rather than having the telemetry library depend on the metrics lib we invert the dependency so that metrics instead depends on telemetry lib, and registers the needed functions with it at init time. This prepares the way for a cleaner telemetry architecture to be applied in

[dpdk-dev] [PATCH v5 02/18] telemetry: move code to metrics for later reuse

2020-04-30 Thread Ciara Power
This commit moves some of the telemetry library code to a new file in the metrics library. No modifications are made to the moved code, except what is needed to allow it to compile and run. The additional code in metrics is built only when the Jansson library is present. Telemetry functions as nor

[dpdk-dev] [PATCH v5 01/18] build: add arch-specific header path to global includes

2020-04-30 Thread Ciara Power
From: Bruce Richardson The global include path, which is used by anything built before EAL, points to the EAL header files so they utility macros etc. can be used anywhere in DPDK. This path included the OS-specific EAL header files, but not the architecture-specific ones. This patch moves the se

[dpdk-dev] [PATCH v5 00/18] update and simplify telemetry library.

2020-04-30 Thread Ciara Power
v5: - General cleanup to address comments on v4 patchset. v4: - Internal representation now uses generic data format instead of JSON. - Help command added to provide help text for a command. v3: - Removed rte_option as it is no longer used. - General cleanup. v2: - Added JSON API, an

[dpdk-dev] [PATCH v2] app/testpmd: support flow aging

2020-04-30 Thread Bill Zhou
Currently, there is no way to check the aging event or to get the current aged flows in testpmd, this patch include those implements, it's included: - Registering aging event when the testpmd application start, add new command to control if the event expose to the applications. If it's be set,

[dpdk-dev] [PATCH v4 2/2] cryptodev: version cryptodev info get function

2020-04-30 Thread Arek Kusztal
This patch adds versioned function rte_cryptodev_info_get() to prevent some issues with ABI policy. Node v21 works in same way as before, returning driver capabilities directly to the API caller. These capabilities may include new elements not part of the v20 ABI. Node v20 function maintains compat

[dpdk-dev] [PATCH v4 1/2] cryptodev: add chacha20-poly1305 aead algorithm

2020-04-30 Thread Arek Kusztal
This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. Signed-off-by: Arek Kusztal Acked-by: Fiona Trahe Acked-by: Anoob Joseph Acked-by: Akhil Goyal --- v3: - rebased against 20.05 v4: - rebased again against 20.05 doc/guides/cryptodevs/features/default.ini | 13 +++-- doc/g

Re: [dpdk-dev] [RFC] ring: count and empty optimizations

2020-04-30 Thread Ananyev, Konstantin
> > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > Sent: Thursday, April 30, 2020 3:12 AM > > > > > > > > > > > > Hi Morten, > > > > > > On Tue, Apr 28, 2020 at 03:53:15PM +0200, Morten Brørup wrote: > > > > Olivier (maintainer of the Ring), > > > > > > I'm not anymore, CC

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-04-30 Thread Ananyev, Konstantin
Hi Honnappa, > Hi Konstantin, > I like the way the tests are organized and it looks good. > > I am just wondering about the way it is being tested here. The intent to > write the test cases the way they are currently is to mimic how the > APIs would be used mostly. IMO, the APIs would b

[dpdk-dev] [PATCH v2] eal/ppc: fix redefine bool type

2020-04-30 Thread Ori Kam
The AltiVec header file breaks boolean type. [1] [2] Currently the workaround was located only in mlx5 device. Adding the trace module caused this issue to appear again, due to order of includes, it keeps overriding the local fix. This patch solves this issue by resetting the bool type, immediate

Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread Lance Richardson
On Thu, Apr 30, 2020 at 9:37 AM Yuan Linsi wrote: > > From: yuanlinsi01 > > We see a stack smashing as a result of defensive code missing. Once the > nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to > zero after doing a floor align, and we can not exit the following > receivin

Re: [dpdk-dev] [EXT] Re: [PATCH] eal/trace: fix coverity issues

2020-04-30 Thread Sunil Kumar Kori
Hello David, Mentioned patch (http://patches.dpdk.org/patch/69467/ ) takes care of your input to resolve GCC 10 build. Now I think, this patch is good to go. Please take care of this. Regards Sunil Kumar Kori >-Original Message- >From: David Marchand >Sent: Monday, April 27, 2020 7:2

Re: [dpdk-dev] [PATCH v4 3/8] eal: introduce memory management wrappers

2020-04-30 Thread Burakov, Anatoly
On 29-Apr-20 6:13 PM, Burakov, Anatoly wrote: @@ -547,10 +531,10 @@ rte_eal_memdevice_init(void)   int   rte_mem_lock_page(const void *virt)   { -    unsigned long virtual = (unsigned long)virt; -    int page_size = getpagesize(); -    unsigned long aligned = (virtual & ~(page_size - 1)); -    re

[dpdk-dev] DPDK Release Status Meeting 30/04/2020

2020-04-30 Thread Ferruh Yigit
Minutes 30 April 2020 - Agenda: * Release Dates * -rc1 status * Subtrees * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * Red Hat Release Dates - * v20.05 dates: * -rc1 is released on Monday, 27 April * http://inbox.dpdk.

Re: [dpdk-dev] [EXT] [PATCH v2] trace: fix build with gcc 10

2020-04-30 Thread Sunil Kumar Kori
Looks good to me. Regards Sunil Kumar Kori >-Original Message- >From: Phil Yang >Sent: Tuesday, April 28, 2020 8:07 PM >To: Sunil Kumar Kori ; dev@dpdk.org >Cc: david.march...@redhat.com; Jerin Jacob Kollanukkaran >; lijian.zh...@arm.com; ruifeng.w...@arm.com; >n...@arm.com >Subject: [EX

[dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread Yuan Linsi
From: yuanlinsi01 We see a stack smashing as a result of defensive code missing. Once the nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to zero after doing a floor align, and we can not exit the following receiving packets loop. And the buffers will be overwrite, then the stac

[dpdk-dev] 答复: [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread Yuan,Linsi
Sure, I'll add it. Thanks, Yuan Linsi 发件人: Somnath Kotur 发送时间: 2020年4月30日 20:55 收件人: Yuan,Linsi; Lance Richardson 抄送: Ajit Kumar Khaparde; dev 主题: Re: [PATCH] net/bnxt: fix a possible stack smashing +Lance Richardson Thanks for the patch, could you please add

Re: [dpdk-dev] [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode

2020-04-30 Thread Iremonger, Bernard
> -Original Message- > From: Xiaoyu Min > Sent: Thursday, April 30, 2020 2:08 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org > Subject: [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode > > One new cmdlin

Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread Somnath Kotur
+Lance Richardson Thanks for the patch, could you please add the 'Fixes' tag as well ? On Thu, Apr 30, 2020 at 5:35 PM yuanlinsi01 wrote: > > We see a stack smashing as a result of defensive code missing. Once the > nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to > zero af

Re: [dpdk-dev] [PATCH v2] l3fwd-power: add Rx interrupt timeout

2020-04-30 Thread Hunt, David
On 30/4/2020 11:49 AM, Anatoly Burakov wrote: Currently, thread waiting on an interrupt does not have a timeout, so it will not ever wake up until traffic arrives. This means that, when time comes to exit the application, it will not quit unless there happens to be traffic coming in and waking

[dpdk-dev] [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode

2020-04-30 Thread Xiaoyu Min
One new cmdline option `--rx-mq-mode` is added in order to have the possibility to check whether PMD handle the mq mode correctly or not. The reason is some NICs need to do different settings based on different RX mq mode, i.e RSS or not. With this support in testpmd, the above scenario can be te

Re: [dpdk-dev] [PATCH v11 6/9] net/virtio: add vectorized packed ring Rx path

2020-04-30 Thread Ferruh Yigit
On 4/30/2020 11:23 AM, Bruce Richardson wrote: > On Thu, Apr 30, 2020 at 10:48:35AM +0100, Ferruh Yigit wrote: >> On 4/28/2020 9:32 AM, Marvin Liu wrote: >>> Optimize packed ring Rx path with SIMD instructions. Solution of >>> optimization is pretty like vhost, is that split path into batch and >>>

Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-04-30 Thread Aaron Conole
Honnappa Nagarahalli writes: > test_ring.c takes lot of time to compile with clang. It is > reproducable with compiler version 8.0 on Ubuntu 18.04. > Amount of testing is reduced, but attempt is made to keep > the same coverage. > > Reported-by: Aaron Conole > Reported-by: Thomas Monjalon > Sig

Re: [dpdk-dev] [PATCH] net/mlx5: fix actions validation on root table

2020-04-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, April 29, 2020 3:54 PM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix actions validation on root table > > The maximal supported heade

Re: [dpdk-dev] [PATCH] app/testpmd: add cmdline option to set Rx mq mode

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 09:16, Iremonger, Bernard wrote: > Hi Xiaoyu, Hey Bernard, > > > -Original Message- > > From: Xiaoyu Min > > Sent: Wednesday, April 29, 2020 2:04 PM > > To: Lu, Wenzhuo ; Wu, Jingjing > > ; Iremonger, Bernard > > ; Mcnamara, John > > ; Kovacevic, Marko > > > > Cc: dev@

Re: [dpdk-dev] [PATCH v4 5/5] app/test-flow-perf: add packet forwarding support

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 10:33, Wisam Jaddo wrote: > Introduce packet forwarding support to the app to do > some performance measurements. > > The measurements are reported in term of packet per > second unit. The forwarding will start after the end > of insertion/deletion operations. > > The support ha

[dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread yuanlinsi01
We see a stack smashing as a result of defensive code missing. Once the nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to zero after doing a floor align, and we can not exit the following receiving packets loop. And the buffers will be overwrite, then the stack frame was ruined.

Re: [dpdk-dev] [PATCH v4 4/5] app/test-flow-perf: add memory dump to app

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 10:33, Wisam Jaddo wrote: > Introduce new feature to dump memory statistics of each socket > and a total for all before and after the creation. > > This will give two main advantage: > 1- Check the memory consumption for large number of flows > "insertion rate scenario alone" >

Re: [dpdk-dev] [PATCH v4 3/5] app/test-flow-perf: add deletion rate calculation

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 10:33, Wisam Jaddo wrote: > Add the ability to test deletion rate for flow performance > application. > > This feature is disabled by default, and can be enabled by > add "--deletion-rate" in the application command line options. > > Signed-off-by: Wisam Jaddo Acked-by: Xiaoyu

Re: [dpdk-dev] [PATCH v4 2/5] app/test-flow-perf: add insertion rate calculation

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 10:33, Wisam Jaddo wrote: > Add insertion rate calculation feature into flow > performance application. > > The application now provide the ability to test > insertion rate of specific rte_flow rule, by > stressing it to the NIC, and calculate the > insertion rate. > > The appli

Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 10:33, Wisam Jaddo wrote: > Add flow performance application skeleton. > > Signed-off-by: Wisam Jaddo Acked-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode

2020-04-30 Thread Matan Azrad
From: Slava Ovsiienko > > -Original Message- > > From: Slava Ovsiienko > > Sent: Thursday, April 30, 2020 11:52 > > To: Xiaoyu Min ; Matan Azrad > > ; Shahaf Shuler > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: RE: [PATCH] net/mlx5: fix default rule do RSS regardless > > rxmode > >

Re: [dpdk-dev] [PATCH 2/2] vfio: modify spapr iommu support to use static window sizing

2020-04-30 Thread Burakov, Anatoly
On 30-Apr-20 12:29 AM, David Christensen wrote: Current SPAPR IOMMU support code dynamically modifies the DMA window size in response to every new memory allocation. This is potentially dangerous because all existing mappings need to be unmapped/remapped in order to resize the DMA window, leaving

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread Burakov, Anatoly
On 30-Apr-20 12:29 AM, David Christensen wrote: Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- Why is this needed? -- Thanks, Anatoly

[dpdk-dev] [PATCH v6 1/1] abi: change references to abi 20.0.1 to abi v21

2020-04-30 Thread Ray Kinsella
Change references to abi 20.0.1 to use abi v21, see https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines "Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI versio

[dpdk-dev] [PATCH v6 1/1] abi: change references to abi 20.0.1 to abi v21

2020-04-30 Thread Ray Kinsella
Sending again, as I missed the cover letter last time. v6: * combined policy and versioning in the maintainers file. Ray Kinsella (1): abi: change references to abi 20.0.1 to abi v21 MAINTAINERS| 10 +- devtools/libabigail.abignore

[dpdk-dev] [PATCH v5] abi: change references to abi 20.0.1 to abi v21

2020-04-30 Thread Ray Kinsella
Change references to abi 20.0.1 to use abi v21, see https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines "Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI versio

[dpdk-dev] [PATCH v2] l3fwd-power: add Rx interrupt timeout

2020-04-30 Thread Anatoly Burakov
Currently, thread waiting on an interrupt does not have a timeout, so it will not ever wake up until traffic arrives. This means that, when time comes to exit the application, it will not quit unless there happens to be traffic coming in and waking up the thread from sleep. Fix it so that the inte

[dpdk-dev] [PATCH v4 3/5] app/test-flow-perf: add deletion rate calculation

2020-04-30 Thread Wisam Jaddo
Add the ability to test deletion rate for flow performance application. This feature is disabled by default, and can be enabled by add "--deletion-rate" in the application command line options. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 86 ++

[dpdk-dev] [PATCH v4 0/5] Introduce flow perf application

2020-04-30 Thread Wisam Jaddo
Add new application to test rte flow performance from: - Insertion rate. - Deletion rate. - Memory consumption. - PPS forward measurement. --- v4: * Fix compilation error due to variable set but not used. v3: * Fix passing hairpin queues to hairpin rss action. v2: * reset cpu_time_used every por

[dpdk-dev] [PATCH v4 4/5] app/test-flow-perf: add memory dump to app

2020-04-30 Thread Wisam Jaddo
Introduce new feature to dump memory statistics of each socket and a total for all before and after the creation. This will give two main advantage: 1- Check the memory consumption for large number of flows "insertion rate scenario alone" 2- Check that no memory leackage after doing insertion the

[dpdk-dev] [PATCH v4 5/5] app/test-flow-perf: add packet forwarding support

2020-04-30 Thread Wisam Jaddo
Introduce packet forwarding support to the app to do some performance measurements. The measurements are reported in term of packet per second unit. The forwarding will start after the end of insertion/deletion operations. The support has single and multi core performance measurements. Signed-of

[dpdk-dev] [PATCH v4 2/5] app/test-flow-perf: add insertion rate calculation

2020-04-30 Thread Wisam Jaddo
Add insertion rate calculation feature into flow performance application. The application now provide the ability to test insertion rate of specific rte_flow rule, by stressing it to the NIC, and calculate the insertion rate. The application offers some options in the command line, to configure w

[dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton

2020-04-30 Thread Wisam Jaddo
Add flow performance application skeleton. Signed-off-by: Wisam Jaddo --- MAINTAINERS | 5 + app/Makefile | 1 + app/meson.build | 1 + app/test-flow-perf/Makefile | 26 +++ app/test-flow-perf/main.c

Re: [dpdk-dev] [PATCH] net/mlx5: fix indexed pool bitmap initialization

2020-04-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Tuesday, April 28, 2020 12:14 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh ; > lijian.zh...@arm.com > Subject: [PATCH] net/mlx5: fix indexed pool bitmap initialization > > Currently, t

Re: [dpdk-dev] [PATCH v11 6/9] net/virtio: add vectorized packed ring Rx path

2020-04-30 Thread Bruce Richardson
On Thu, Apr 30, 2020 at 10:48:35AM +0100, Ferruh Yigit wrote: > On 4/28/2020 9:32 AM, Marvin Liu wrote: > > Optimize packed ring Rx path with SIMD instructions. Solution of > > optimization is pretty like vhost, is that split path into batch and > > single functions. Batch function is further optim

Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-04-30 Thread Thomas Monjalon
30/04/2020 03:56, Honnappa Nagarahalli: > test_ring.c takes lot of time to compile with clang. It is > reproducable with compiler version 8.0 on Ubuntu 18.04. > Amount of testing is reduced, but attempt is made to keep > the same coverage. > > Reported-by: Aaron Conole > Reported-by: Thomas Monja

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each pctype for FDIR

2020-04-30 Thread Ferruh Yigit
On 4/30/2020 1:52 AM, Zhao1, Wei wrote: > Hi, > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, April 29, 2020 6:35 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: sta...@dpdk.org; Xing, Beilei ; >> maxime.le...@6wind.com >> Subject: Re: [dpdk-stable] [PATCH v4 2/3] doc: in

[dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread yuanlinsi01
We see a stack smashing as a result of defensive code missing. Once the nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to zero after doing a floor align, and we can not exit the following receiving packets loop. And the buffers will be overwrite, then the stack frame was ruined.

[dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing

2020-04-30 Thread yuanlinsi01
We see a stack smashing as a result of defensive code missing. Once the nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to zero after doing a floor align, and we can not exit the following receiving packets loop. And the buffers will be overwrite, then the stack frame was ruined.

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-30 Thread Ray Kinsella
So that isn't the issue either. $ grep RTE_CPUFLAG_NUMFLAGS build-gcc-shared/install/dump/librte_eal.dump 4646: $ grep RTE_CPUFLAG_NUMFLAGS /build/dpdk/reference/v20.02/build-gcc-shared/dump/librte_eal.dump 3296: 1.7-1.fc31

  1   2   >