Re: [dpdk-dev] [PATCH] net/ice/base: fix bm mask set and find switch recipe method

2020-04-27 Thread Zhao1, Wei
Add fuqi > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, April 28, 2020 2:22 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/ice/base: fix bm mask set and find switch recipe method > > When we download a switch rule for ipv6 with esp payload "eth / i

[dpdk-dev] [PATCH] net/iavf: fix link speed

2020-04-27 Thread alvinx . zhang
From: Alvin Zhang If the PF driver does not support the new speed reporting capabilities then use link_event else use link_event_adv to get the speed. Fixes: 48de41ca11f0 (net/iavf: enable link status update) Cc: jingjing...@intel.com Signed-off-by: Alvin Zhang --- drivers/net/iavf/iavf_vchnl

[dpdk-dev] [PATCH] net/ice/base: fix bm mask set and find switch recipe method

2020-04-27 Thread Wei Zhao
When we download a switch rule for ipv6 with esp payload "eth / ipv6 / esp spi is 1 / end actions queue index 2 / end" if we don't add bm bit set check for tun_type, then a packet of ipv4 with esp payload "sendp([Ether(dst="00:00:00:00:01:00")/IP(proto=50)/ESP(spi=1)/ ("X"*480)], iface="ens5f0",

[dpdk-dev] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter

2020-04-27 Thread Wei Zhao
When we flush FDIR filter, we can not call i40e_fdir_teardown() function as it will free vsi used for FDIR, then the vsi->base_queue will be freed from pf->qp_pool, but vsi->base_queue can only get once when do dev init in i40e_pf_setup(). If we free it, it will never be alloc again. Bugzilla ID:

[dpdk-dev] [PATCH v2 0/3] fix i40e bug for flow filter

2020-04-27 Thread Wei Zhao
fix i40e bug for flow filter and add comment in doc. v2: add more comment in git log. Wei Zhao (3): net/i40e: fix FDIR issue for ARP packets doc: input set requirement of each pctype for FDIR net/i40e: remove teardown when flush FDIR filter doc/guides/nics/i40e.rst | 7 +++ drive

[dpdk-dev] [PATCH v2 2/3] doc: input set requirement of each pctype for FDIR

2020-04-27 Thread Wei Zhao
Add input set requirement info to i40e doc. Bugzilla ID: 403 Signed-off-by: Wei Zhao --- doc/guides/nics/i40e.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 416b3904e..ad5f51c38 100644 --- a/doc/guides/nics/i40e.rst +++ b/

[dpdk-dev] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets

2020-04-27 Thread Wei Zhao
This patch can enable FDIR awith ethertype as input set for ARP packet, it will associate this rule, "flow create 0 ingress pattern eth type is 0x0806 / end actions mark id 0x86 / rss / end", with pctype I40E_FILTER_PCTYPE_L2_PAYLOAD for ARP packet rule. I have tried to enable ARP ethertype for FDI

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-04-27 Thread Sunil Kumar Kori
Looks okay. Regards Sunil Kumar Kori >-Original Message- >From: pbhagavat...@marvell.com >Sent: Tuesday, April 28, 2020 12:01 AM >To: Jerin Jacob Kollanukkaran ; tho...@monjalon.net; >John McNamara ; Marko Kovacevic >; Ori Kam ; Bruce >Richardson ; Radu Nicolau >; Akhil Goyal ; Tomasz >

[dpdk-dev] [PATCH] net/iavf: fix VF reset issue for FDIR rule

2020-04-27 Thread Simei Su
After VF reset, FDIR rule still takes effect. To solve the issue, this patch adds to flush all flows before flow uninit. VIRTCHNL sends message to PF by Admin Queue, so flow flush should be implemented before Admin Queue shut down. Fixes: c6ea8bd9f11f ("net/iavf: support generic flow") Signed-off

Re: [dpdk-dev] [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter

2020-04-27 Thread Zhao1, Wei
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 9:21 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: maxime.le...@6wind.com; sta...@dpdk.org > Subject: RE: [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter > > > > > -Original Message- > > From: Zh

Re: [dpdk-dev] [PATCH v3 1/4] ring: future proof flag settings

2020-04-27 Thread Honnappa Nagarahalli
> > All API's should check that they support the flag values passed. > These checks ensure that the extra bits can safely be used without risk of ABI > breakage. > > Signed-off-by: Stephen Hemminger Reviewed-by: Honnappa Nagarahalli > --- > lib/librte_ring/rte_ring.c | 12 > 1

[dpdk-dev] [EXT] [PATCH] trace: fix build with gcc 10

2020-04-27 Thread Sunil Kumar Kori
Sent from Workspace ONE Boxer On 27-Apr-2020 10:18 PM, Phil Yang wrote: > > External Email > > -- > GCC 10 compiling output: > eal_common_trace_utils.c: In function 'eal_trace_dir_args_save': > eal_common_trace_utils.c:290:24: err

Re: [dpdk-dev] [PATCH] maintainers: update for Intel ixgbe/igb/igc

2020-04-27 Thread Jeff Guo
On 4/27/2020 9:28 AM, Wei Zhao wrote: Replace Wenzhuo Lu, Alvin Zhang and Konstantin Ananyev with Wei Zhao and Jeff Guo. Signed-off-by: Wei Zhao --- MAINTAINERS | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d31a80929..7a57535

Re: [dpdk-dev] [PATCH 1/3] maintainers: update for Intel i40e

2020-04-27 Thread Jeff Guo
On 4/26/2020 4:21 PM, Beilei Xing wrote: Replace Qi Zhang with Jeff Guo. Signed-off-by: Beilei Xing --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cd50160..cc2664a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -658,7 +658

Re: [dpdk-dev] [PATCH] maintainers: update for Intel ixgbe/igb/igc

2020-04-27 Thread Jeff Guo
On 4/28/2020 8:47 AM, Lu, Wenzhuo wrote: -Original Message- From: Zhao1, Wei Sent: Monday, April 27, 2020 9:24 AM To: dev@dpdk.org Cc: Guo, Jia ; lvinx.zh...@intel.com; Lu, Wenzhuo ; Ananyev, Konstantin ; Zhao1, Wei Subject: [PATCH] maintainers: update for Intel ixgbe/igb/igc Replace

Re: [dpdk-dev] rte epoll functions

2020-04-27 Thread Lukasz Wojciechowski
W dniu 27.04.2020 o 18:57, Stephen Hemminger pisze: > On Mon, 27 Apr 2020 17:01:21 +0200 > David Marchand wrote: > >> On Mon, Apr 27, 2020 at 4:51 PM Stephen Hemminger >> wrote: >>> On Mon, 27 Apr 2020 13:33:27 + >>> Liron Himi wrote: >>> Hi, We noticed that the impl

Re: [dpdk-dev] [PATCH v10 4/9] net/virtio-user: add vectorized devarg

2020-04-27 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Monday, April 27, 2020 7:07 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v10 4/9] net/virtio-user: add vectorized devarg > > > > On 4/26/20 4:19 AM, Marvin Liu wrote: > > Add new dev

[dpdk-dev] [PATCH] eal: fix lcore state bug

2020-04-27 Thread Lukasz Wojciechowski
The rte_service_lcore_reset_all function stops execution of services on all lcores and switches them back from ROLE_SERVICE to ROLE_RTE. However the thread loop for slave lcores (eal_thread_loop) distincts these roles to set lcore state after processing delegated function. It sets WAIT state for RO

Re: [dpdk-dev] [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter

2020-04-27 Thread Xing, Beilei
> -Original Message- > From: Zhao1, Wei > Sent: Monday, April 27, 2020 3:15 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; maxime.le...@6wind.com; > sta...@dpdk.org; Zhao1, Wei > Subject: [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter > > I have try to enable ARP ethertype fo

Re: [dpdk-dev] [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter

2020-04-27 Thread Zhao1, Wei
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 9:13 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: maxime.le...@6wind.com; sta...@dpdk.org > Subject: RE: [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter > > > > > -Original Message- > > From: Z

Re: [dpdk-dev] [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path

2020-04-27 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Monday, April 27, 2020 7:21 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path > > > > On 4/26/20 4:19 AM, Marvin Liu wrote: > > Opt

Re: [dpdk-dev] [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter

2020-04-27 Thread Xing, Beilei
> -Original Message- > From: Zhao1, Wei > Sent: Monday, April 27, 2020 3:15 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; maxime.le...@6wind.com; > sta...@dpdk.org; Zhao1, Wei > Subject: [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter > > When we flush FDIR filter, we can no

Re: [dpdk-dev] [PATCH 2/3] maintainers: update for Intel iavf

2020-04-27 Thread Lu, Wenzhuo
> -Original Message- > From: Xing, Beilei > Sent: Sunday, April 26, 2020 4:22 PM > To: dev@dpdk.org; Wu, Jingjing ; Lu, Wenzhuo > ; Zhang, Qi Z > Subject: [PATCH 2/3] maintainers: update for Intel iavf > > Replace Wenzhuo Lu with Beilei Xing. > > Signed-off-by: Beilei Xing Acked-by:

Re: [dpdk-dev] [PATCH] maintainers: update for Intel ixgbe/igb/igc

2020-04-27 Thread Lu, Wenzhuo
> -Original Message- > From: Zhao1, Wei > Sent: Monday, April 27, 2020 9:24 AM > To: dev@dpdk.org > Cc: Guo, Jia ; lvinx.zh...@intel.com; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhao1, Wei > Subject: [PATCH] maintainers: update for Intel ixgbe/igb/igc > > Replace Wenzhuo Lu, Alvin Zhang

Re: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation

2020-04-27 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Monday, April 27, 2020 4:45 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 2/2] vhost: cache gpa to hpa translation > > Hi Marvin, > > On 4/1/20 4:50 PM, Marvin Liu wrote: > > If Tx

[dpdk-dev] [PATCH 2/4] net/netvsc: fix invalid rte_free on dev_close

2020-04-27 Thread Stephen Hemminger
The netvsc PMD is putting the mac address in private data. Unless dev->data->mac_addrs is NULL'd rte_ethdev_close will try and free the address array. Causing the following scary error. EAL: Invalid memory This is a simpler alternative to the fix already merged in 20.05-rc1 Fixes: f8279f47dd89 (

[dpdk-dev] [PATCH 4/4] bus/vmbus: fix comment spelling errors

2020-04-27 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 2 +- drivers/bus/vmbus/vmbus_common.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c index 10e50c9b5a10..5451bfd1501d 1

[dpdk-dev] [PATCH 3/4] net/netvsc: fix comment spelling errors

2020-04-27 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 +- drivers/net/netvsc/hn_nvs.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 96480f930a46..6723abab1fe5 100644 --- a/drivers/n

[dpdk-dev] [PATCH 0/4] net/netvsc: minor fixes

2020-04-27 Thread Stephen Hemminger
These fix some minor issues found during testing and review of netvsc PMD Stephen Hemminger (4): net/vmbus: add missing barrier net/netvsc: fix invalid rte_free on dev_close net/netvsc: fix comment spelling errors bus/vmbus: fix comment spelling errors drivers/bus/vmbus/linux/vmbus_uio.c

[dpdk-dev] [PATCH 1/4] net/vmbus: add missing barrier

2020-04-27 Thread Stephen Hemminger
The check for event ring being empty needs a barrier to avoid any over agressive optimization. This is same barrier as Linux kernel. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/vmbus_channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vmbus/vmbus_channel.c b/dri

[dpdk-dev] [PATCH v3 4/4] cfgfile: check flags value

2020-04-27 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_cfgfile/rte_cfgfile.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_cfgfile/rte_cfg

[dpdk-dev] [PATCH v3 3/4] stack: check flags on creation

2020-04-27 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_stack/rte_stack.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_stack/rte_stack.c

[dpdk-dev] [PATCH v3 1/4] ring: future proof flag settings

2020-04-27 Thread Stephen Hemminger
All API's should check that they support the flag values passed. These checks ensure that the extra bits can safely be used without risk of ABI breakage. Signed-off-by: Stephen Hemminger --- lib/librte_ring/rte_ring.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/librte_r

[dpdk-dev] [PATCH v3 2/4] hash: check flags on creation

2020-04-27 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_hash/rte_cuckoo_hash.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/librte_ha

[dpdk-dev] [PATCH v3 0/4] Enforce checking on flag values in API's

2020-04-27 Thread Stephen Hemminger
The DPDK API's are lax about checking for undefined flag values. This makes it impossible to add new bits to existing API's without causing ABI breakage. This means we end up doing unnecessary symbol versioning just to work around applications that might pass in naughty bits. This is the DPDK anal

Re: [dpdk-dev] [PATCH 7/7] bus/pci: support Windows with bifurcated drivers

2020-04-27 Thread Narcisa Ana Maria Vasile
On Wed, Apr 22, 2020 at 10:27:47AM +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > Uses SetupAPI.h functions to scan PCI tree. > Uses DEVPKEY_Device_Numa_Node to get the PCI Numa node. > scanning currently supports types RTE_KDRV_NONE. > > Signed-off-by: Tal Shnaiderman > --- > d

[dpdk-dev] [PATCH] rte_trace: fix build on PPC64

2020-04-27 Thread Thinh Tran
The AltiVec header file breaks boolean type: In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, from ../lib/librte_mempool/rte_mempool.h:54, from ../lib/librte_mbuf/rte_mbuf.h:38, from ../lib/librte_net/rte_ether.h:23,

Re: [dpdk-dev] [PATCH 09/14] eal: close mem config on cleanup

2020-04-27 Thread Stephen Hemminger
On Mon, 27 Apr 2020 13:12:32 +0100 "Burakov, Anatoly" wrote: > On 04-Jan-20 1:33 AM, Stephen Hemminger wrote: > > Resolves file descriptor left open after rte_eal_cleanup. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_eal/linux/eal/eal.c | 6 ++ > > 1 file changed, 6 in

[dpdk-dev] [PATCH] net/tap: fix crash from unitialized memory in rte_flow_destroy

2020-04-27 Thread Stephen Hemminger
The TAP driver does not initialize all the elements of the rte_flow structure. This can lead to crash in rte_flow_destroy. (gdb) where flow=0x100e99280, error=0x0) at drivers/net/tap/tap_flow.c:1514 (gdb) p remote_flow $1 = (struct rte_flow *) 0x6b6b6b6b6b6b6b6b Which is here: static int

Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

2020-04-27 Thread Thomas Monjalon
27/04/2020 12:58, Ferruh Yigit: > On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote: > > [AMD Public Use] > > > > Acked-by: Ravi Kumar > >> -Original Message- > >> From: Somalapuram, Amaranath > >> Sent: Monday, April 27, 2020 11:42 AM > >> To: dev@dpdk.org > >> Cc: Kumar, Ravi1 > >> Subject: [

Re: [dpdk-dev] [PATCH] maintainers: update for Arm v7 and v8

2020-04-27 Thread Thomas Monjalon
> > Updating ARM v7 and v8 maintainer. Gavin is leaving Arm. > > > > Signed-off-by: Ruifeng Wang > Acked-by: Honnappa Nagarahalli Applied

Re: [dpdk-dev] [PATCH v2 2/2] timer: support EAL functions on Windows

2020-04-27 Thread Dmitry Kozlyuk
On 2020-04-27 15:20 GMT+0300 Fady Bader wrote: > Implemented the needed Windows eal timer functions. [snip] > +void > +rte_delay_us_sleep(unsigned int us) > +{ > + HANDLE timer; > + LARGE_INTEGER li_due_time; Here usually comes a blank line. > + /* create waitable timer */ > + tim

Re: [dpdk-dev] [PATCH v3 1/1] bus/pci: optimise scanning with whitelist/blacklist

2020-04-27 Thread Gaëtan Rivet
Hello Sunil, As it seems that this patch does not overly alarm people using the PCI bus, I have a few comments on this version. Sending those a little earlier will allow you to change as needed before proceeding with your tests. On 20/04/20 12:25 +0530, Sunil Kumar Kori wrote: > rte_bus_scan API

[dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-04-27 Thread pbhagavatula
From: Vamsi Attunuru Current l2fwd application statically configures adjacent ports as destination ports for forwarding the traffic. Add a portmap option to pass the forwarding port pair mapping which allows the user to configure forwarding port mapping. If no portmap argument is specified, des

[dpdk-dev] [PATCH] net/mlx5: fix packet length check assert in MPRQ

2020-04-27 Thread Alexander Kozyrev
The assert that checks if there is a enough room for the whole packet minus headroom data is written incorrectly. The check should be negated in order to work properly. Fixes: bd0d593 ("net/mlx5: enable MPRQ multi-stride operations") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyrev Acked-by:

[dpdk-dev] [PATCH] net/mlx5: fix assert in dynamic metadata handling

2020-04-27 Thread Alexander Kozyrev
The assert in dynamic flow metadata handling is wrong after the fix for the performance degradation. The assert meant to check the metadata mask but was updated with the metadata offset instead. Fix this assert and restore proper metadata mask checking. Fixes: 6c55b62 ("net/mlx5: set dynamic flow

[dpdk-dev] [PATCH] eventdev: fix device probe and remove for secondary process

2020-04-27 Thread pbhagavatula
From: Pavan Nikhilesh When probing event device in secondary process skip reinitializing the device data structure as it is already done in primary process. When removing event device in secondary process skip closing the event device as it should be done by primary process. Fixes: 322d0345c2bc

Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum

2020-04-27 Thread Jerin Jacob
On Mon, Apr 27, 2020 at 1:26 AM Thomas Monjalon wrote: > > 26/04/2020 20:48, Jerin Jacob: > > On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon > > wrote: > > > 26/04/2020 19:42, Jerin Jacob: > > > > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon > > > > wrote: > > > > > 06/02/2020 15:36, Jeri

Re: [dpdk-dev] [PATCH v3] mempool: return 0 if area is too small on populate

2020-04-27 Thread Lukasz Wojciechowski
W dniu 27.04.2020 o 13:44, Ray Kinsella pisze: > > On 25/04/2020 23:23, Thomas Monjalon wrote: >> From: Olivier Matz >> >> Change rte_mempool_populate_iova() and rte_mempool_populate_iova() to ... and rte_mempool_populate_virt() >> return 0 instead of -EINVAL when there is not enough room to sto

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-27 Thread Jerin Jacob
On Mon, Apr 27, 2020 at 1:36 AM Thomas Monjalon wrote: > > 26/04/2020 20:41, Jerin Jacob: > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > wrote: > > > > > > 26/04/2020 19:38, jer...@marvell.com: > > > > From: Jerin Jacob > > > > > > > > If the PCI device is not attached to any driver t

Re: [dpdk-dev] [PATCH] crypto/qat: fix computation of cd ptr in zuc

2020-04-27 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, April 27, 2020 3:40 PM > To: dev@dpdk.org; Trahe, Fiona > Cc: Kusztal, ArkadiuszX ; sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix computation of cd ptr in zuc > > Offset of cd pointer is too big by state1size + stat

[dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline

2020-04-27 Thread Jasvinder Singh
For sending request messages to data plane threads, the caller invokes pipeline_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response. Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711, 357722, 357725, 357734, 35773

[dpdk-dev] [PATCH v2] net/softnic: fix memory leak for thread

2020-04-27 Thread Jasvinder Singh
For sending request messages to data plane threads, the caller invokes thread_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response. Coverity Issue: 357717, 357772 Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline

Re: [dpdk-dev] [PATCH] maintainers: update for Arm v7 and v8

2020-04-27 Thread Honnappa Nagarahalli
> Subject: [PATCH] maintainers: update for Arm v7 and v8 > > Updating ARM v7 and v8 maintainer. Gavin is leaving Arm. > > Signed-off-by: Ruifeng Wang Acked-by: Honnappa Nagarahalli > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-27 Thread Jerin Jacob
On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit wrote: > > On 4/27/2020 5:29 PM, Jerin Jacob wrote: > > On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit wrote: > >> > >> On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > >>> > >>> > -Original Message- > From: Yigit, Ferruh > S

Re: [dpdk-dev] [PATCH] trace: fix build with gcc 10

2020-04-27 Thread Stephen Hemminger
On Tue, 28 Apr 2020 00:47:38 +0800 Phil Yang wrote: > - if (strlen(optarg) >= size) { > + /* the specified trace directory name cannot > + * exceed PATH_MAX-1. > + */ > + if (strlen(optarg) >= (size - 1)) { > trace_err("input string is too big"); strnlen() is

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-27 Thread Dan Gora
On Mon, Apr 27, 2020 at 1:19 PM Luca Boccassi wrote: > > On Thu, 2020-04-23 at 14:38 -0300, Dan Gora wrote: > > On Thu, Apr 23, 2020 at 12:59 PM Luca Boccassi wrote: > > > > > /dev/urandom is basically only a different interface to the same > > > > > underlying mechanism. > > > > > > This is not

Re: [dpdk-dev] rte epoll functions

2020-04-27 Thread Stephen Hemminger
On Mon, 27 Apr 2020 17:01:21 +0200 David Marchand wrote: > On Mon, Apr 27, 2020 at 4:51 PM Stephen Hemminger > wrote: > > > > On Mon, 27 Apr 2020 13:33:27 + > > Liron Himi wrote: > > > > > Hi, > > > > > > > > > We noticed that the implementation of rte_epoll_wait doesn't stopped on > > >

[dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak for pipeline

2020-04-27 Thread Jasvinder Singh
For sending request messages to data plane threads, the caller invokes pipeline_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response. Coverity Issues: 357750, 357740, 357749, 357758, 357702, 357736, 357679, 357791, 357738, 357778, 35771

[dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak for thread

2020-04-27 Thread Jasvinder Singh
For sending request messages to data plane threads, the caller invokes thread_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response. Coverity Issues: 357773, 357723 Fixes: 32e5d9b154cb ("examples/ip_pipeline: add enable and disable comma

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix fd leak

2020-04-27 Thread Ferruh Yigit
On 4/27/2020 12:12 PM, Gaëtan Rivet wrote: > On 27/04/20 18:44 +0800, wangyunjian wrote: >> From: Yunjian Wang >> >> Zero is a valid fd. The fd won't be closed thus leading fd leak, >> when it is zero. >> >> Fixes: f234e5bd996d ("net/failsafe: register slaves Rx interrupts") >> Fixes: 9e0360aebf23

Re: [dpdk-dev] [PATCH] eal: Place EAL thread stack in a reserved per-lcore memzone

2020-04-27 Thread Pavan Nikhilesh Bhagavatula
> lib/librte_eal/linux/eal.c | 20 > 1 file changed, 20 insertions(+) > >diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c >index 9530ee5..e047107 100644 >--- a/lib/librte_eal/linux/eal.c >+++ b/lib/librte_eal/linux/eal.c >@@ -68,6 +68,8 @@ > > #define KERNEL

Re: [dpdk-dev] [PATCH v3] examples/l2fwd: add cmdline option for forwarding port info

2020-04-27 Thread Sunil Kumar Kori
Sent from Workspace ONE Boxer On 27-Apr-2020 10:08 PM, Pavan Nikhilesh Bhagavatula wrote: > > >>diff --git a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst > >>b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst > >>index 39d6b0067..b54321b5b 100644 > >>--- a/doc/guides/sample_app_ug/l2

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-27 Thread Ferruh Yigit
On 4/27/2020 5:29 PM, Jerin Jacob wrote: > On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit wrote: >> >> On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: >>> >>> -Original Message- From: Yigit, Ferruh Sent: Saturday, April 25, 2020 9:09 PM To: Dumitrescu, Cristian ; Nith

[dpdk-dev] [PATCH] trace: fix build with gcc 10

2020-04-27 Thread Phil Yang
GCC 10 compiling output: eal_common_trace_utils.c: In function 'eal_trace_dir_args_save': eal_common_trace_utils.c:290:24: error: '__builtin___sprintf_chk' \ may write a terminating nul past the end of the destination \ [-Werror=format-overflow=] 290 | sprintf(dir_path, "%s/",

Re: [dpdk-dev] [PATCH v3] examples/l2fwd: add cmdline option for forwarding port info

2020-04-27 Thread Pavan Nikhilesh Bhagavatula
>>diff --git a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst >>b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst >>index 39d6b0067..b54321b5b 100644 >>--- a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst >>+++ b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst >>@@ -91,7 +91,1

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-27 Thread Jerin Jacob
On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit wrote: > > On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > > > > > >> -Original Message- > >> From: Yigit, Ferruh > >> Sent: Saturday, April 25, 2020 9:09 PM > >> To: Dumitrescu, Cristian ; Nithin Dabilpuram > >> ; Singh, Jasvinder ; > >>

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 27, 2020 5:13 PM > To: Dumitrescu, Cristian ; Nithin Dabilpuram > ; Singh, Jasvinder ; > Thomas Monjalon ; Andrew Rybchenko > > Cc: dev@dpdk.org; jer...@marvell.com; kka...@marvell.com; Nithin > Dabilpuram ; Kinsella, Ray

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-27 Thread Ferruh Yigit
On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Saturday, April 25, 2020 9:09 PM >> To: Dumitrescu, Cristian ; Nithin Dabilpuram >> ; Singh, Jasvinder ; >> Thomas Monjalon ; Andrew Rybchenko >> >> Cc: dev@dpdk.org; jer...@marv

Re: [dpdk-dev] [PATCH 06/14] eal: mp: end the multiprocess thread during cleanup

2020-04-27 Thread Burakov, Anatoly
On 04-Jan-20 1:33 AM, Stephen Hemminger wrote: When rte_eal_cleanup is called, all control threads should exit. For the mp thread, this best handled by closing the mp_socket and letting the thread see that. This also fixes potential problems where the mp_socket gets another hard error, and the t

Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging

2020-04-27 Thread Matan Azrad
Hi From: Ferruh Yigit > On 4/26/2020 8:23 AM, Bill Zhou wrote: > > > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Saturday, April 25, 2020 12:25 AM > >> To: Bill Zhou ; wenzhuo...@intel.com; > >> jingjing...@intel.com; bernard.iremon...@intel.com; Ori Kam > >> > >> Cc: de

[dpdk-dev] Flow action not supported in testpmd

2020-04-27 Thread diptyaroop
Hello, I am trying to check different flow rules using testpmd (DPDK v19.11), but facing the following error for any rule that I try: testpmd> flow validate 0 ingress pattern eth / end actions queue index 6 / end port_flow_complain(): Caught PMD error type 16 (specific action): cause: 0x7ff

Re: [dpdk-dev] [PATCH v2] build: add note about make system deprecation

2020-04-27 Thread Ferruh Yigit
On 4/27/2020 3:25 PM, Bruce Richardson wrote: > When anyone uses the make build system, they are to be informed > about upcoming plans to deprecate and subsequently remove that > system and to use meson and ninja instead. > > Signed-off-by: Bruce Richardson > Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] rte epoll functions

2020-04-27 Thread David Marchand
On Mon, Apr 27, 2020 at 4:51 PM Stephen Hemminger wrote: > > On Mon, 27 Apr 2020 13:33:27 + > Liron Himi wrote: > > > Hi, > > > > > > We noticed that the implementation of rte_epoll_wait doesn't stopped on > > signal such as SIGINT. > > > > Is anyone know why? > > > > If that on purpose and

Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

2020-04-27 Thread Thomas Monjalon
27/04/2020 14:58, Aaron Conole: > Ferruh Yigit writes: > > [1] Two issues reported > > a) ninja: build stopped: Error writing to build log: Disk quota > > exceeded. > > This occurs on some of the ARM64 builds. Travis is aware of the issue, > but don't seem urgently fixing it. :-/ I think we hav

[dpdk-dev] [PATCH v2] examples/l2fwd-keepalive: fix packet drops limited mbufs

2020-04-27 Thread Louise Kilheeney
MBUF pool of size 8192 was causing packet loss when using four ports. To fix this issue this patch specifies the number of MBUF's per port instead of having one set MBUF pool size, this way it will adapt to any number of ports. Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application

Re: [dpdk-dev] [PATCH 1/3] ring: fix build with -Wswitch-enum

2020-04-27 Thread Ananyev, Konstantin
> > Some popular vswitch implementation might use a gcc option that > complains about missing enums in switch statements. > Fix this by listing all possible values. > > Fixes: 664ff4b1729b ("ring: introduce peek style API") > > Signed-off-by: David Marchand > --- > lib/librte_ring/rte_ring_pee

Re: [dpdk-dev] rte epoll functions

2020-04-27 Thread Stephen Hemminger
On Mon, 27 Apr 2020 13:33:27 + Liron Himi wrote: > Hi, > > > We noticed that the implementation of rte_epoll_wait doesn't stopped on > signal such as SIGINT. > > Is anyone know why? > > If that on purpose and cannot be changed, how application can exit gracefully > when using rx interru

[dpdk-dev] [PATCH] crypto/qat: fix computation of cd ptr in zuc

2020-04-27 Thread Arek Kusztal
Offset of cd pointer is too big by state1size + state2size, so few extra unnecessary bytes will be copied into cd. Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability") Cc: sta...@dpdk.org Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_session.c | 3 +-- 1 file changed, 1

[dpdk-dev] [PATCH v2] build: add note about make system deprecation

2020-04-27 Thread Bruce Richardson
When anyone uses the make build system, they are to be informed about upcoming plans to deprecate and subsequently remove that system and to use meson and ninja instead. Signed-off-by: Bruce Richardson --- v2: added link to the docs on building DPDK --- mk/rte.sdkbuild.mk | 5 + mk/rte.sdk

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread Ferruh Yigit
On 4/27/2020 3:12 PM, David Marchand wrote: > On Mon, Apr 27, 2020 at 4:07 PM Ferruh Yigit wrote: >> >> On 4/27/2020 3:00 PM, David Marchand wrote: >>> On Mon, Apr 27, 2020 at 3:47 PM Ananyev, Konstantin >>> wrote: > -Original Message- > From: dev On Behalf Of Davi

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread David Marchand
On Mon, Apr 27, 2020 at 4:07 PM Ferruh Yigit wrote: > > On 4/27/2020 3:00 PM, David Marchand wrote: > > On Mon, Apr 27, 2020 at 3:47 PM Ananyev, Konstantin > > wrote: > >> > >> > >> > >>> -Original Message- > >>> From: dev On Behalf Of David Marchand > >>> Sent: Monday, April 27, 2020 2:

Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging

2020-04-27 Thread Ferruh Yigit
On 4/26/2020 8:23 AM, Bill Zhou wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Saturday, April 25, 2020 12:25 AM >> To: Bill Zhou ; wenzhuo...@intel.com; >> jingjing...@intel.com; bernard.iremon...@intel.com; Ori Kam >> >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread Ferruh Yigit
On 4/27/2020 3:00 PM, David Marchand wrote: > On Mon, Apr 27, 2020 at 3:47 PM Ananyev, Konstantin > wrote: >> >> >> >>> -Original Message- >>> From: dev On Behalf Of David Marchand >>> Sent: Monday, April 27, 2020 2:37 PM >>> To: Richardson, Bruce >>> Cc: dev ; Ori Kam ; Thomas Monjalon

[dpdk-dev] [PATCH] net/softnic: fix memory leak

2020-04-27 Thread Jasvinder Singh
When sending request messages to data plane thread, the caller must free the memory allocated to request message on receiving error response. Coverity Issue: 357717, 357772 Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline") Signed-off-by: Jasvinder Singh --- drivers/net

[dpdk-dev] [PATCH] net/softnic: fix resource leak

2020-04-27 Thread Jasvinder Singh
When sending request messages to data plane pipelines, the caller must free the memory allocated to request message on receiving error response. Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711, 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787 Fixes: 6d

Re: [dpdk-dev] [EXT] Re: [PATCH] eal/trace: fix coverity issues

2020-04-27 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Monday, April 27, 2020 7:22 PM >To: Sunil Kumar Kori >Cc: Jerin Jacob Kollanukkaran ; dev >Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] eal/trace: fix coverity issues > >On Mon, Apr 27, 2020 at 3:46 PM Sunil Kumar Kori >wrote: >> >> >-Or

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread David Marchand
On Mon, Apr 27, 2020 at 3:47 PM Ananyev, Konstantin wrote: > > > > > -Original Message- > > From: dev On Behalf Of David Marchand > > Sent: Monday, April 27, 2020 2:37 PM > > To: Richardson, Bruce > > Cc: dev ; Ori Kam ; Thomas Monjalon > > ; Yigit, Ferruh > > ; Andrew Rybchenko ; > >

Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx/Tx stats after clear stats command

2020-04-27 Thread Ferruh Yigit
On 4/26/2020 10:22 AM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit > > On 2020/4/25 0:12, Ferruh Yigit wrote: >> On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote: >>> From: Chengwen Feng >>> >>> Currently, when running start/clear stats&xstats/stop command many times >>> based on testpmd application, t

Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags

2020-04-27 Thread Ray Kinsella
On 27/04/2020 13:31, Thomas Monjalon wrote: > 27/04/2020 11:27, Ray Kinsella: >> On 25/04/2020 17:04, Thomas Monjalon wrote: >>> PS: Who is REALLY maintaining the ABI? >>> We really miss someone who carefully check all these things, >>> and take care of the doc and tooling. >> >> I would say tha

Re: [dpdk-dev] [EXT] Re: [PATCH] eal/trace: fix coverity issues

2020-04-27 Thread David Marchand
On Mon, Apr 27, 2020 at 3:46 PM Sunil Kumar Kori wrote: > > >-Original Message- > >From: David Marchand > >Sent: Monday, April 27, 2020 5:56 PM > >To: Sunil Kumar Kori > >Cc: Jerin Jacob Kollanukkaran ; dev > >Subject: [EXT] Re: [dpdk-dev] [PATCH] eal/trace: fix coverity issues > > > >E

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread Ananyev, Konstantin
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Monday, April 27, 2020 2:37 PM > To: Richardson, Bruce > Cc: dev ; Ori Kam ; Thomas Monjalon > ; Yigit, Ferruh > ; Andrew Rybchenko ; > Zhang, Xiao > Subject: Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on

Re: [dpdk-dev] [EXT] Re: [PATCH] eal/trace: fix coverity issues

2020-04-27 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Monday, April 27, 2020 5:56 PM >To: Sunil Kumar Kori >Cc: Jerin Jacob Kollanukkaran ; dev >Subject: [EXT] Re: [dpdk-dev] [PATCH] eal/trace: fix coverity issues > >External Email > >--

[dpdk-dev] [PATCH v4] abi: change references to abi 20.0.1 to abi v21

2020-04-27 Thread Ray Kinsella
v4: * restored suppressions for v20.0.1 incorrectly removed in v3. Ray Kinsella (1): abi: change references to abi 20.0.1 to abi v21 MAINTAINERS | 2 ++ devtools/libabigail.abignore | 5 + drivers/common/iavf

[dpdk-dev] [PATCH v4] abi: change references to abi 20.0.1 to abi v21

2020-04-27 Thread Ray Kinsella
Change references to abi 20.0.1 to use abi v21, see https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines. "Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI versi

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread Bruce Richardson
On Mon, Apr 27, 2020 at 03:40:30PM +0200, David Marchand wrote: > On Mon, Apr 27, 2020 at 3:39 PM Andrew Rybchenko > wrote: > > > > On 4/27/20 4:34 PM, Bruce Richardson wrote: > > > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote: > > >> Building OVS with dpdk, sparse complains abou

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread David Marchand
On Mon, Apr 27, 2020 at 3:39 PM Andrew Rybchenko wrote: > > On 4/27/20 4:34 PM, Bruce Richardson wrote: > > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote: > >> Building OVS with dpdk, sparse complains about 64-bit constant being > >> passed as a normal integer that can't fit it: >

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread Andrew Rybchenko
On 4/27/20 4:34 PM, Bruce Richardson wrote: > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote: >> Building OVS with dpdk, sparse complains about 64-bit constant being >> passed as a normal integer that can't fit it: >> error: constant 0x is so big it is unsigned long

Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value

2020-04-27 Thread David Marchand
On Mon, Apr 27, 2020 at 3:34 PM Bruce Richardson wrote: > > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote: > > Building OVS with dpdk, sparse complains about 64-bit constant being > > passed as a normal integer that can't fit it: > > error: constant 0x is so big it

Re: [dpdk-dev] [PATCH 2/3] eal: fix typo in endian conversion macros

2020-04-27 Thread Bruce Richardson
On Mon, Apr 27, 2020 at 03:23:40PM +0200, David Marchand wrote: > Caught by code inspection, for little endian, RTE_LEXX macros should > provide rte_leXX_t type values. > > Fixes: b75667ef9f7e ("eal: add static endianness conversion macros") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand

  1   2   >