Re: [dpdk-dev] [PATCH v2 0/3] add support for L2TP AH ESP and NAT-T on switch

2020-04-21 Thread Ye Xiaolong
On 04/20, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Zhao1, Wei >> Sent: Monday, April 20, 2020 1:19 PM >> To: dev@dpdk.org >> Cc: Zhang, Qi Z ; Fu, Qi >> Subject: [PATCH v2 0/3] add support for L2TP AH ESP and NAT-T on switch >> >> This patch set add switch filter support for

[dpdk-dev] [PATCH v7 9/9] doc: add packed vectorized path

2020-04-21 Thread Marvin Liu
Document packed virtqueue vectorized path selection logic in virtio net PMD. Signed-off-by: Marvin Liu diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 6286286db..4bd46f83e 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -417,6 +417,10 @@ Bel

[dpdk-dev] [PATCH v7 8/9] net/virtio: add election for vectorized path

2020-04-21 Thread Marvin Liu
Rewrite vectorized path selection logic. Default setting comes from RTE_LIBRTE_VIRTIO_INC_VECTOR option. Paths criteria will be checked as listed below. Packed ring vectorized path will be selected when: vectorized option is enabled AVX512F and required extensions are supported by compiler

[dpdk-dev] [PATCH v7 7/9] net/virtio: add vectorized packed ring Tx path

2020-04-21 Thread Marvin Liu
Optimize packed ring Tx path alike Rx path. Split Tx path into batch and single Tx functions. Batch function is further optimized by vector instructions. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 5c112cac7..b7d52d497 100

[dpdk-dev] [PATCH v7 6/9] net/virtio: reuse packed ring xmit functions

2020-04-21 Thread Marvin Liu
Move xmit offload and packed ring xmit enqueue function to header file. These functions will be reused by packed ring vectorized Tx function. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 7b65d0b0a..cf18fe564 100644 --- a/drivers

[dpdk-dev] [PATCH v7 4/9] net/virtio-user: add vectorized path parameter

2020-04-21 Thread Marvin Liu
Add new parameter "vectorized" which can select vectorized path explicitly. This parameter will work when RTE_LIBRTE_VIRTIO_INC_VECTOR option is yes. When "vectorized" is set, driver will check both compiling environment and running environment when selecting path. Signed-off-by: Marvin Liu diff

[dpdk-dev] [PATCH v7 5/9] net/virtio: add vectorized packed ring Rx path

2020-04-21 Thread Marvin Liu
Optimize packed ring Rx path when AVX512 enabled and mergeable buffer/Rx LRO offloading are not required. Solution of optimization is pretty like vhost, is that split path into batch and single functions. Batch function is further optimized by vector instructions. Also pad desc extra structure to 1

[dpdk-dev] [PATCH v7 3/9] net/virtio: inorder should depend on feature bit

2020-04-21 Thread Marvin Liu
Ring initialzation is different when inorder feature negotiated. This action should dependent on negotiated feature bits. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 94ba7a3ec..e450477e8 100644 --- a/drivers/net/virtio/virtio_r

[dpdk-dev] [PATCH v7 1/9] net/virtio: add Rx free threshold setting

2020-04-21 Thread Marvin Liu
Introduce free threshold setting in Rx queue, default value of it is 32. Limiated threshold size to multiple of four as only vectorized packed Rx function will utilize it. Virtio driver will rearm Rx queue when more than rx_free_thresh descs were dequeued. Signed-off-by: Marvin Liu diff --git a/

[dpdk-dev] [PATCH v7 0/9] add packed ring vectorized path

2020-04-21 Thread Marvin Liu
This patch set introduced vectorized path for packed ring. The size of packed ring descriptor is 16Bytes. Four batched descriptors are just placed into one cacheline. AVX512 instructions can well handle this kind of data. Packed ring TX path can fully transformed into vectorized path. Packed ring

[dpdk-dev] [PATCH v7 2/9] net/virtio: enable vectorized path

2020-04-21 Thread Marvin Liu
Previously, virtio split ring vectorized path is enabled as default. This is not suitable for everyone because of that path not follow virtio spec. Add new config for virtio vectorized path selection. By default vectorized path is disabled. Signed-off-by: Marvin Liu diff --git a/config/common_ba

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/1] bus/pci: optimise scanning with whitelist/blacklist

2020-04-21 Thread Sunil Kumar Kori
>-Original Message- >From: Gaëtan Rivet >Sent: Tuesday, April 21, 2020 8:48 PM >To: Sunil Kumar Kori >Cc: step...@networkplumber.org; david.march...@redhat.com; Jerin Jacob >Kollanukkaran ; dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] [PATCH v3 1/1] bus/pci: optimise scanning with >whiteli

Re: [dpdk-dev] [PATCH v6] net/ixgbe: fix resource leak after thread exits normally

2020-04-21 Thread Ye Xiaolong
On 04/22, taox@intel.com wrote: >From: Zhu Tao > >When the thread exits normally, pthread_join() is not called, which can >result in a resource leak. Therefore, the thread is set to separation >mode using function pthread_detach(), so that no program call >pthread_join() is required to recycle

Re: [dpdk-dev] [PATCH] net/ice: fix flow redirector issue

2020-04-21 Thread Wang, Haiyue
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, April 22, 2020 20:23 > To: dev@dpdk.org; Wang, Haiyue ; Zhang, Qi Z > > Subject: [PATCH] net/ice: fix flow redirector issue > > If there's VF reset, the kernel PF will remove rules > associated with the reset VF no matter the

[dpdk-dev] [PATCH v9 2/2] eal: support for VFIO-PCI VF token

2020-04-21 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. Signed-off-by: Haiyue Wang Acked-by: Vamsi Attunuru Tested-by: Va

[dpdk-dev] [PATCH v9 0/2] support for VFIO-PCI VF token interface

2020-04-21 Thread Haiyue Wang
v9: Rewrite the document. v8: Update the document. https://patchwork.dpdk.org/cover/68859/ v7: Add the Fixes tag in uuid, the release note and help document. https://patchwork.dpdk.org/cover/68845/ v6: Drop the Fixes tag in uuid, since the file has been moved to another place, no

[dpdk-dev] [PATCH v9 1/2] eal: add uuid dependent header files explicitly

2020-04-21 Thread Haiyue Wang
Add the dependent header files explicitly, so that the user just needs to include the 'rte_uuid.h' header file directly to avoid compile error: (1). rte_uuid.h:97:55: error: unknown type name ‘size_t’ (2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’ Fixes: 6bc67c497a51 ("ea

Re: [dpdk-dev] time for compiling test_ring.c

2020-04-21 Thread Honnappa Nagarahalli
> > > > > 22/04/2020 02:05, Honnappa Nagarahalli: > > > 22/04/2020 02:00, Thomas Monjalon: > > > > I don't want know why and when, but it seems the file test_ring.c > > > > became very long to compile, especially with clang. > > > > > > What is the compiler version? Is this on master? > > > > cla

[dpdk-dev] [PATCH v6] net/ixgbe: fix resource leak after thread exits normally

2020-04-21 Thread taox . zhu
From: Zhu Tao When the thread exits normally, pthread_join() is not called, which can result in a resource leak. Therefore, the thread is set to separation mode using function pthread_detach(), so that no program call pthread_join() is required to recycle, and when the thread exits, the system au

[dpdk-dev] [PATCH v5 4/4] lib/rcu: add additional debug logs

2020-04-21 Thread Honnappa Nagarahalli
Added additional debug logs. These helped in debugging RCU defer APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rcu/rte_rcu_qsbr.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_rcu/rte_rcu_qsbr.h

[dpdk-dev] [PATCH v5 3/4] doc/rcu: add RCU integration design details

2020-04-21 Thread Honnappa Nagarahalli
From: Ruifeng Wang Add a section to describe a design to integrate QSBR RCU library with other libraries in DPDK. Signed-off-by: Honnappa Nagarahalli Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- doc/guides/prog_guide/rcu_lib.rst | 59 ++

[dpdk-dev] [PATCH v5 2/4] test/rcu: test cases for RCU defer queue APIs

2020-04-21 Thread Honnappa Nagarahalli
Add test cases for RCU defer queue APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedhal Reviewed-by: Ruifeng Wang --- app/test/test_rcu_qsbr.c | 365 ++- 1 file changed, 363 insertions(+), 2 deletions(-) diff --git a/app/test/test_rcu_qsbr.c

[dpdk-dev] [PATCH v5 1/4] lib/rcu: add resource reclamation APIs

2020-04-21 Thread Honnappa Nagarahalli
Add resource reclamation APIs to make it simple for applications and libraries to integrate rte_rcu library. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedhal Reviewed-by: Ruifeng Wang Acked-by: Konstantin Ananyev --- lib/librte_rcu/Makefile| 2 +- lib/librte_rcu/me

[dpdk-dev] [PATCH v5 0/4] Add RCU reclamation APIs

2020-04-21 Thread Honnappa Nagarahalli
v5 1) rte_rcu_dq_delete does not return an error on NULL parameter 2) Removed good amount of memcopy's where possible 3) Changed the call back function to be friendly for batching. v4 1) RCU reclamation APIs changed to provide lot more flexibility a) The rte_rcu_qsbr_dq_enqueue and rte_rcu_q

[dpdk-dev] [PATCH] net/ice: fix flow redirector issue

2020-04-21 Thread Beilei Xing
If there's VF reset, the kernel PF will remove rules associated with the reset VF no matter the HW VSI ID is changed or not. So DCF should redirector all rules associated with the reset VF no matter the HW VSI ID is changed or not. Fixes: f10cde8e8478 ("net/ice: get VF hardware index in DCF") Fixe

Re: [dpdk-dev] [PATCH v3] doc: update hairpin data buffer size config

2020-04-21 Thread Bing Zhao
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, April 22, 2020 10:13 AM > To: Bing Zhao > Cc: john.mcnam...@intel.com; marko.kovace...@intel.com; Slava > Ovsiienko ; Ori Kam > ; Matan Azrad ; > Shahaf Shuler ; Raslan Darawsheh > ; dev@dpdk.org > Subject: Re: [PATCH v3] doc

Re: [dpdk-dev] [PATCH] eal: add madvise to avoid dump memory

2020-04-21 Thread Li Feng
Really?So weird. I have tested on 4 machines, running CentOS 7. The core dump size is the same as the first argument GiB. Thanks, Feng Li Burakov, Anatoly 于2020年4月22日周三 上午1:02写道: > > On 21-Apr-20 5:38 PM, Feng Li wrote: > > Hi Anatoly, > > > > This program could run like this: > > gcc test_map.

[dpdk-dev] [PATCH v4] doc: update hairpin data buffer size config

2020-04-21 Thread Bing Zhao
This patch updates the MLX5 PMD and release notes documentations. Adding the guideline for hairpin data buffer size configuration. Signed-off-by: Bing Zhao Acked-by: Ori Kam --- v2: update the range description of hairpin data buffer size v3: correct the minimum value of the range v4: correct so

Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix resource leak after thread exits normally

2020-04-21 Thread Ye Xiaolong
On 04/21, taox@intel.com wrote: >From: Zhu Tao > >When the thread exits normally, pthread_join() is not called, which can >result in a resource leak. Therefore, the thread is set to separation >mode using function pthread_detach(), so that no program call >pthread_join() is required to recycle

Re: [dpdk-dev] [pull-request] next-crypto 20.05 rc1

2020-04-21 Thread Thomas Monjalon
20/04/2020 16:20, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [RFC] app/testpmd: add generic swap forwarding engine

2020-04-21 Thread Xiaoyu Min
On Tue, 20-04-21, 21:56, Ferruh Yigit wrote: > On 4/15/2020 2:48 PM, Xiaoyu Min wrote: > > This RFC propose a generic `swap` forwarding engine, which could be seen > > as an extension of existing `macswap` but provide more flexibility. > > > > With this generic `swap` forwarding engine, we can `sw

Re: [dpdk-dev] [PATCH v3] doc: update hairpin data buffer size config

2020-04-21 Thread Thomas Monjalon
21/04/2020 09:29, Bing Zhao: > This patch updates the MLX5 PMD and release notes documentations. > Adding the guideline for hairpin data buffer size configuration. > > Signed-off-by: Bing Zhao > Acked-by: Ori Kam > --- > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > +- ``hp_b

Re: [dpdk-dev] [RFC] app/testpmd: add generic swap forwarding engine

2020-04-21 Thread Xiaoyu Min
On Tue, 20-04-21, 15:47, Iremonger, Bernard wrote: > Hi Xiaoyu, Hey Bernard, > > > -Original Message- > > From: Xiaoyu Min > > Sent: Wednesday, April 15, 2020 2:49 PM > > To: tho...@monjalon.net; as...@mellanox.com; Lu, Wenzhuo > > ; Wu, Jingjing ; Iremonger, > > Bernard ; Mcnamara, John

Re: [dpdk-dev] [PATCH v3] doc: update flow non-cached mode notes

2020-04-21 Thread Thomas Monjalon
Hi, Please prefer splitting lines after punctuation signs. 21/04/2020 08:08, Bing Zhao: > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > > +Notes for rte_flow A blank line is missing below: > +-- > +Implementation of flows organization is in non-cached mode.

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: diff --git a/lib/librte_eal/windows/eal_memory.c b/lib/librte_eal/windows/eal_memory.c new file mode 100644 index 0..5697187ce --- /dev/null +++ b/lib/librte_eal/windows/eal_memory.c @@ -0,0 +1,437 @@ + + if ((flags & EAL_RESERVE_

[dpdk-dev] [PATCH V1] add meson build 32-bits on x86_64

2020-04-21 Thread xueming
Add user interaction features. The default build is 64-bits. if you want to build 32-bits on x86_64, need to pass parameters of i686. Merge -vv and -v into the method Signed-off-by: xueming --- devtools/test-meson-builds.sh | 64 +++ 1 file changed, 58 insertions(

[dpdk-dev] [RFC] net/tap: avoid using SIGIO

2020-04-21 Thread Stephen Hemminger
The TAP device uses Linux signal internally to wakeup. The use of SIGIO is problematic because it maybe used by application. Instead choose another rt-signal since Linux allows any signal to be used for signal based IO. Search for an unused signal in the available rt-signal range. Add more error c

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: System meory management is implemented differently for POSIX and Windows. Introduce wrapper functions for operations used across DPDK: * rte_mem_map() Create memory mapping for a regular file or a page file (swap). This supports mapping to a res

Re: [dpdk-dev] time for compiling test_ring.c

2020-04-21 Thread Honnappa Nagarahalli
> > 22/04/2020 02:05, Honnappa Nagarahalli: > > 22/04/2020 02:00, Thomas Monjalon: > > > I don't want know why and when, but it seems the file test_ring.c > > > became very long to compile, especially with clang. > > > > What is the compiler version? Is this on master? > > clang 9.0.1 compiling

Re: [dpdk-dev] time for compiling test_ring.c

2020-04-21 Thread Thomas Monjalon
22/04/2020 02:05, Honnappa Nagarahalli: > 22/04/2020 02:00, Thomas Monjalon: > > I don't want know why and when, but it seems the file test_ring.c became > > very long to compile, especially with clang. > > What is the compiler version? Is this on master? clang 9.0.1 compiling DPDK master. > Any

Re: [dpdk-dev] time for compiling test_ring.c

2020-04-21 Thread Honnappa Nagarahalli
> > Hi, > > I don't want know why and when, but it seems the file test_ring.c became > very long to compile, especially with clang. What is the compiler version? Is this on master? Any info on test_ring_perf.c? > > I have no solution to shorten the compilation time, so I propose to rename > t

[dpdk-dev] time for compiling test_ring.c

2020-04-21 Thread Thomas Monjalon
Hi, I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang. I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce. Disclosure: I am failing this test :-(

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Dmitry Kozlyuk
> I'd remove the GetVersionEx check entirely and add the comments regarding OS > dependency to the RTE_LOG > Of the LoadLibraryA failure below, GetVersionEx returns the Windows 8 OS > version on newer servers Agreed, will do in v4. > Also, it looks like not all Win2016 servers versions support

[dpdk-dev] [Bug 458] Windows server 2019 UNH CI fails

2020-04-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=458 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolutio

Re: [dpdk-dev] [PATCH] eal: fix Windows build

2020-04-21 Thread Thomas Monjalon
21/04/2020 17:05, tal...@mellanox.com: > From: Tal Shnaiderman > > Windows headers pthread.h and fnmatch.h > uses rte_common types > > The error is: error: unknown type name '__rte_unused' > > The fix adds the missing includes. > > Bugzilla ID: 458 > Fixes: f2fc83b40f06 ("replace unused attrib

Re: [dpdk-dev] [PATCH v3 02/10] eal/windows: do not expose private EAL facilities

2020-04-21 Thread Thomas Monjalon
14/04/2020 21:44, Dmitry Kozlyuk: > The goal of rte_os.h is to mitigate OS differences for EAL users. > In Windows EAL, rte_os.h did excessive things: > > 1. It included platform SDK headers (windows.h, etc). Those files are >huge, require specific inclusion order, and are generally unused by

Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix resource leak after thread exits normally

2020-04-21 Thread Ananyev, Konstantin
> > When the thread exits normally, pthread_join() is not called, which can > result in a resource leak. Therefore, the thread is set to separation > mode using function pthread_detach(), so that no program call > pthread_join() is required to recycle, and when the thread exits, > the system aut

Re: [dpdk-dev] [PATCH] eal: add madvise to avoid dump memory

2020-04-21 Thread Feng Li
Hi Anatoly, This program could run like this: gcc test_map.c ./a.out 2 & gcore `pidof a.out` You will get a core dump sized to 2GiB. Thanks, Feng Li Burakov, Anatoly 于2020年4月21日周二 下午8:19写道: > > On 21-Apr-20 12:06 PM, Feng Li wrote: > > #include > > #include > > #include > > #include > > #i

Re: [dpdk-dev] [PATCH] eal: add madvise to avoid dump memory

2020-04-21 Thread Feng Li
Hi David, Mmap with PROT_NONE does not affected the core dump size. Here is a simple test prog: #include #include #include #include #include #include int main(int argc, char** argv) { // FIXME(fengli): X uint64_t gb = atoi(argv[1]); void* ptr = mmap(0, gb << 30, PROT_NONE,

Re: [dpdk-dev] [PATCH] sched: fix port time rounding error

2020-04-21 Thread Dewar, Alan
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, April 20, 2020 12:23 PM > To: Dumitrescu, Cristian ; > alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH] sched: fix port time rounding error > > > > > -Original Message- > > From: Dumi

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-21 Thread Thomas Monjalon
21/04/2020 20:37, Coyle, David: > From: Thomas Monjalon > > 21/04/2020 18:46, Doherty, Declan: > > > On 15/04/2020 11:33 PM, Thomas Monjalon wrote: > > > > 16/04/2020 00:19, Doherty, Declan: > > > >> On 14/04/2020 3:44 PM, Thomas Monjalon wrote: > > > >>> 14/04/2020 16:02, Trahe, Fiona: > > >

[dpdk-dev] [PATCH v3 8/9] net/bnxt: log firmware status on early init failure

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Firmware reports any fatal error (either ASIC or Firmware related) via a new status register. This status register can provide more detailed information about the firmware errors, especially if error occurs before HWRM_VER_GET is issued. Attempt to map this register if it is prese

[dpdk-dev] [PATCH v3 7/9] net/bnxt: fix vlan add when port is stopped

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Driver destroys the vnic when the port is brought down. When user tries to add a vlan when port is stopped, driver issues HWRM command to FW with invalid vnic_id and it fails. Fixed to return an error while setting vlan when port is not started. Fixes: b4e190d55c25 ("net/bnxt: f

[dpdk-dev] [PATCH v3 6/9] net/bnxt: fix to handle port start failure

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Fixed to invoke clean up in the reverse sequence of initialization in case any of the FW commands fail during port start. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-b

[dpdk-dev] [PATCH v3 5/9] net/bnxt: fix to use true/false for bool types

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++--- 1 file changed, 3 insertio

[dpdk-dev] [PATCH v3 9/9] net/bnxt: fix to not issue port MAC query on a VF

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP HWRM_PORT_MAC_QCFG is not supported on a VF. Added a PF check in bnxt_hwrm_port_mac_qcfg() to prevent the probe failure on a VF. Fixes: 184e3d13d88a ("net/bnxt: fetch SVIF information from firmware") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnx

[dpdk-dev] [PATCH v3 0/9] bnxt patchset with fixes

2020-04-21 Thread Ajit Khaparde
Patches with bug fixes. v1->v2: - Fix compilation on BSD. - Fix commit logs for some of the patches. v2->v3: - Squashed patches 8,9 into a single patch. Ajit Khaparde (1): net/bnxt: fix compilation on BSD Kalesh AP (8): net/bnxt: use macro for PCI log format net/bnxt: return speed capa

[dpdk-dev] [PATCH v3 2/9] net/bnxt: use macro for PCI log format

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Use PCI_PRI_FMT instead of "%04x:%02x:%02x:%02x" print format. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 6 +++--- drivers/net/bnxt/bnxt_ring.c | 2 +- drivers/net/bnxt/bnxt_vnic.c | 2 +- 3 files changed, 5 insertions(+), 5 deletio

[dpdk-dev] [PATCH v3 1/9] net/bnxt: fix compilation on BSD

2020-04-21 Thread Ajit Khaparde
There is no ENODATA in the errno.h in BSD. Use a common errno to return error. Fixes: cef1ca505d7f ("net/bnxt: support EM/EEM") Signed-off-by: Ajit Khaparde Reviewed-by: Kishore Padmanabha Reviewed-by: Lance Richardson --- drivers/net/bnxt/tf_core/stack.c | 2 +- 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH v3 3/9] net/bnxt: return speed capabilities in device get info

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Added information about supported speeds for the port in the "dev_infos_get". As other PMDs are returning the speed capabilities, apps may expect this behavior from bnxt PMD. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 36 ++

[dpdk-dev] [PATCH v3 4/9] net/bnxt: fix HWRM command failure during FW reset

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP FW returns HWRM_ERR_CODE_HOT_RESET_PROGRESS(0xa) when it is unable to process a specific cmd while hot reset is in progress. Host driver is expected to keep retrying the cmd for 2s with a gap of 50ms between each retrial. Also, fixed to fail port start if the HWRM_FUNC_DRV_IF_CHA

Re: [dpdk-dev] [PATCHv3] Remove validate-abi.sh from tree

2020-04-21 Thread Thomas Monjalon
21/04/2020 20:56, Neil Horman: > On Tue, Apr 21, 2020 at 01:46:43PM +0200, Thomas Monjalon wrote: > > 21/04/2020 13:12, Neil Horman: > > > On Fri, Apr 17, 2020 at 04:42:38PM +0100, Ray Kinsella wrote: > > > > On 17/04/2020 13:10, Thomas Monjalon wrote: > > > > > 17/04/2020 13:47, Ray Kinsella: > >

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-21 Thread Thomas Monjalon
21/04/2020 22:58, Lukasz Wojciechowski: > > W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: > > > > I am agree with Cristian concern here: that patch removes ability to > > enable/disable debug on particular library/PMD. If the purpose is > > to > > minimize

Re: [dpdk-dev] [PATCH v2 08/10] net/bnxt: add FW status location structure

2020-04-21 Thread Ajit Khaparde
On Tue, Apr 21, 2020 at 2:05 PM Ferruh Yigit wrote: > On 4/21/2020 9:07 PM, Ajit Khaparde wrote: > > From: Kalesh AP > > > > Code using this change will be added in next patch. > > It can be better to merge this patch to next one, where it uses this new > struct. > > > > > Signed-off-by: Kalesh

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-21 Thread Dan Gora
On Tue, Apr 21, 2020 at 6:03 PM Stephen Hemminger wrote: > > On Tue, 21 Apr 2020 16:54:45 -0300 > Dan Gora wrote: > > > The getentropy() function was introduced into glibc v2.25 and so is > > not available on all supported platforms. Previously, if DPDK was > > compiled (using meson) on a system

Re: [dpdk-dev] [PATCH v2 08/10] net/bnxt: add FW status location structure

2020-04-21 Thread Ferruh Yigit
On 4/21/2020 9:07 PM, Ajit Khaparde wrote: > From: Kalesh AP > > Code using this change will be added in next patch. It can be better to merge this patch to next one, where it uses this new struct. > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/hsi_struct

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-21 Thread Stephen Hemminger
On Tue, 21 Apr 2020 16:54:45 -0300 Dan Gora wrote: > The getentropy() function was introduced into glibc v2.25 and so is > not available on all supported platforms. Previously, if DPDK was > compiled (using meson) on a system which has getentropy(), it would > introduce a dependency on glibc v2.

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-21 Thread Lukasz Wojciechowski
W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: > > I am agree with Cristian concern here: that patch removes ability to > enable/disable debug on particular library/PMD. If the purpose is to > minimize number of config compile options, I wonder can't it be done >>>

Re: [dpdk-dev] [RFC] app/testpmd: add generic swap forwarding engine

2020-04-21 Thread Ferruh Yigit
On 4/15/2020 2:48 PM, Xiaoyu Min wrote: > This RFC propose a generic `swap` forwarding engine, which could be seen > as an extension of existing `macswap` but provide more flexibility. > > With this generic `swap` forwarding engine, we can `swap` the source and > destination of L2/L3 address as we

Re: [dpdk-dev] [PATCH] app/testpmd: add parsing for multiple VLAN headers

2020-04-21 Thread Ferruh Yigit
On 4/20/2020 4:32 PM, Raslan Darawsheh wrote: > When having multiple VLANs in the packet, parse_ethernet > is cabable of parsing only the first vlan. > > add parsing for mutliple VLAN headers in the packet. > > Fixes: 51f694dd40f5 ("app/testpmd: rework checksum forward engine") > Cc: sta...@dpdk.

[dpdk-dev] [PATCH v2 2/2] eal: resolve getentropy at run time for random seed

2020-04-21 Thread Dan Gora
The getentropy() function was introduced into glibc v2.25 and so is not available on all supported platforms. Previously, if DPDK was compiled (using meson) on a system which has getentropy(), it would introduce a dependency on glibc v2.25 which would prevent that binary from running on a system w

[dpdk-dev] [PATCH v2 0/2] eal: choose initial PRNG seed source at runtime

2020-04-21 Thread Dan Gora
Hi All, The following patches updates the rte_random subsystem to dynamically find the best source of the initial seed to the PRNG at run time. The first patch enables dynamic checking for the rdseed instruction and removes the requirement for it on the execution system. It also ensures that the

[dpdk-dev] [PATCH v2 1/2] eal: check for rdseed at run time for random seed

2020-04-21 Thread Dan Gora
Instead of enabling the rdseed instruction for the random number generator entropy source at compilation time, determine if the instruction can be used at run time. The DPDK build is updated to check that the compiler can generate the rdseed instruction even if the compilation platform does not na

Re: [dpdk-dev] ISSUE: compiling with asan+ubsan

2020-04-21 Thread Honnappa Nagarahalli
> > "Ananyev, Konstantin" writes: > > > Hi Aaron, > > > >> While compiling with asan and ubsan I run into the following error: > >> > >> FAILED: app/test/app@test@@dpdk-test@exe/test_ring.c.o > >> > >> gcc -Iapp/test/app@test@@dpdk-test@exe -Iapp/test -I../app/test > >> -Ilib/librte_acl -I../l

[dpdk-dev] [PATCH v2 10/10] net/bnxt: fix to not issue port MAC query on a VF

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP HWRM_PORT_MAC_QCFG is not supported on a VF. Added a PF check in bnxt_hwrm_port_mac_qcfg() to prevent the probe failure on a VF. Fixes: 184e3d13d88a ("net/bnxt: fetch SVIF information from firmware") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnx

[dpdk-dev] [PATCH v2 09/10] net/bnxt: log firmware status on early init failure

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Firmware reports any fatal error (either ASIC or Firmware related) via a new status register. This status register can provide more detailed information about the firmware errors, especially if error occurs before HWRM_VER_GET is issued. Attempt to map this register if it is prese

[dpdk-dev] [PATCH v2 08/10] net/bnxt: add FW status location structure

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Code using this change will be added in next patch. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 49 ++ 1 file changed, 49 insertions(+) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/

[dpdk-dev] [PATCH v2 07/10] net/bnxt: fix vlan add when port is stopped

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Driver destroys the vnic when the port is brought down. When user tries to add a vlan when port is stopped, driver issues HWRM command to FW with invalid vnic_id and it fails. Fixed to return an error while setting vlan when port is not started. Fixes: b4e190d55c25 ("net/bnxt: f

[dpdk-dev] [PATCH v2 05/10] net/bnxt: fix to use true/false for bool types

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++--- 1 file changed, 3 insertio

[dpdk-dev] [PATCH v2 06/10] net/bnxt: fix to handle port start failure

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Fixed to invoke clean up in the reverse sequence of initialization in case any of the FW commands fail during port start. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-b

[dpdk-dev] [PATCH v2 03/10] net/bnxt: return speed capabilities in device get info

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Added information about supported speeds for the port in the "dev_infos_get". As other PMDs are returning the speed capabilities, apps may expect this behavior from bnxt PMD. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 36 ++

[dpdk-dev] [PATCH v2 00/10] bnxt patchset with fixes

2020-04-21 Thread Ajit Khaparde
Patches with bug fixes. v1->v2: - Fix compilation on BSD. - Fix commit logs for some of the patches. Ajit Khaparde (1): net/bnxt: fix compilation on BSD Kalesh AP (9): net/bnxt: use macro for PCI log format net/bnxt: return speed capabilities in device get info net/bnxt: fix HWRM comma

[dpdk-dev] [PATCH v2 02/10] net/bnxt: use macro for PCI log format

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP Use PCI_PRI_FMT instead of "%04x:%02x:%02x:%02x" print format. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 6 +++--- drivers/net/bnxt/bnxt_ring.c | 2 +- drivers/net/bnxt/bnxt_vnic.c | 2 +- 3 files changed, 5 insertions(+), 5 deletio

[dpdk-dev] [PATCH v2 04/10] net/bnxt: fix HWRM command failure during FW reset

2020-04-21 Thread Ajit Khaparde
From: Kalesh AP FW returns HWRM_ERR_CODE_HOT_RESET_PROGRESS(0xa) when it is unable to process a specific cmd while hot reset is in progress. Host driver is expected to keep retrying the cmd for 2s with a gap of 50ms between each retrial. Also, fixed to fail port start if the HWRM_FUNC_DRV_IF_CHA

[dpdk-dev] [PATCH v2 01/10] net/bnxt: fix compilation on BSD

2020-04-21 Thread Ajit Khaparde
There is no ENODATA in the errno.h in BSD. Use a common errno to return error. Fixes: cef1ca505d7f ("net/bnxt: support EM/EEM") Signed-off-by: Ajit Khaparde Reviewed-by: Kishore Padmanabha Reviewed-by: Lance Richardson --- drivers/net/bnxt/tf_core/stack.c | 2 +- 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH 1/2] eal: check for rdseed at run time for random seed

2020-04-21 Thread Dan Gora
Instead of enabling the rdseed instruction for the random number generator entropy source at compilation time, determine if the instruction can be used at run time. The DPDK build is updated to check that the compiler can generate the rdseed instruction even if the compilation platform does not na

[dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-21 Thread Dan Gora
The getentropy() function was introduced into glibc v2.25 and so is not available on all supported platforms. Previously, if DPDK was compiled (using meson) on a system which has getentropy(), it would introduce a dependency on glibc v2.25 which would prevent that binary from running on a system w

[dpdk-dev] [PATCH 0/2] eal: choose initial PRNG seed source at runtime

2020-04-21 Thread Dan Gora
Hi All, The following patches updates the rte_random subsystem to dynamically find the best source of the initial seed to the PRNG at run time. The first patch enables dynamic checking for the rdseed instruction and removes the requirement for it on the execution system. It also ensures that the

Re: [dpdk-dev] [PATCHv3] Remove validate-abi.sh from tree

2020-04-21 Thread Neil Horman
On Tue, Apr 21, 2020 at 01:46:43PM +0200, Thomas Monjalon wrote: > 21/04/2020 13:12, Neil Horman: > > On Fri, Apr 17, 2020 at 04:42:38PM +0100, Ray Kinsella wrote: > > > On 17/04/2020 13:10, Thomas Monjalon wrote: > > > > 17/04/2020 13:47, Ray Kinsella: > > > >> On 17/04/2020 11:20, Thomas Monjalon

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-21 Thread Coyle, David
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 21, 2020 6:25 PM [PATCH v3 0/4] add AESNI-MB rawdev for multi- > function processing > > 21/04/2020 18:46, Doherty, Declan: > > On 15/04/2020 11:33 PM, Thomas Monjalon wrote: > > > 16/04/2020 00:19, Doherty, Declan: > >

Re: [dpdk-dev] [PATCH] net/mlx5: set dynamic flow metadata in Rx queues

2020-04-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Friday, April 17, 2020 8:15 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: set dynamic flow metadata in Rx queues > > Using a global mbuf dynamic field for metadata

Re: [dpdk-dev] [PATCH] net/mlx5: improve logging of MPRQ selection

2020-04-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Friday, April 17, 2020 8:21 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: improve logging of MPRQ selection > > MPRQ is silently turned off in case there is not en

Re: [dpdk-dev] [PATCH v3 09/12] service: avoid race condition for MT unsafe service

2020-04-21 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, April 18, 2020 7:22 AM > To: Van Haaren, Harry ; Phil Yang > ; tho...@monjalon.net; Ananyev, Konstantin > ; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@mar

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-21 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 21, 2020 16:48 > To: David Marchand ; Wang, Haiyue > > Cc: Neil Horman ; dev ; Burakov, Anatoly > ; Vamsi Attunuru ; Jerin > Jacob Kollanukkaran > ; Yigit, Ferruh ; Richardson, > Bruce > ; Kinsella, Ray > Subject: Re:

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-21 Thread Thomas Monjalon
21/04/2020 18:46, Doherty, Declan: > On 15/04/2020 11:33 PM, Thomas Monjalon wrote: > > 16/04/2020 00:19, Doherty, Declan: > >> On 14/04/2020 3:44 PM, Thomas Monjalon wrote: > >>> 14/04/2020 16:02, Trahe, Fiona: > From: Thomas Monjalon > > 14/04/2020 15:04, Trahe, Fiona: > >>> 14/04/2

Re: [dpdk-dev] [PATCH v2] app/testpmd: configure rxd and txd number correctly

2020-04-21 Thread Ferruh Yigit
On 4/21/2020 12:50 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: dev On Behalf Of Lijun Ou >> Sent: Saturday, April 18, 2020 4:45 AM >> To: Ye, Xiaolong ; Zhang, Qi Z >> >> Cc: dev@dpdk.org; linux...@huawei.com >> Subject: [dpdk-dev] [PATCH v2] app/testpmd: configure rxd an

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-21 Thread Coyle, David
Thank you Thomas for your input. We would like to request that the Tech-Board (CC'ed) also review the proposal to help us reach a consensus. If the current proposal is not acceptable, we would welcome feedback from the board on how to rework our proposal to something that would be acceptable.

Re: [dpdk-dev] [PATCH 0/2] updates for hns3 PMD driver

2020-04-21 Thread Ferruh Yigit
On 4/21/2020 4:32 AM, Wei Hu (Xavier) wrote: > This series are updates for hns3 PMD driver. > > Chengwen Feng (1): > net/hns3: get Rx/Tx queue fbd in extend device statistics > > Wei Hu (Xavier) (1): > net/hns3: modify the format for firmware version > Series applied to dpdk-next-net/master

Re: [dpdk-dev] [dpdk-dev v8 0/3] add RSS configuration for iavf

2020-04-21 Thread Ferruh Yigit
On 4/22/2020 2:02 AM, Jeff Guo wrote: > Because the VF must be capable of configuring RSS, so add RSS configuration > for iavf, VFs could add or delete a RSS rule base on the PF's capability. > The supported protocol rss input set as below. > > l2-src-only/ > l2-dst-only/ > svlan/ > cvlan/ > ipv4/

Re: [dpdk-dev] [dpdk-dev v8 1/3] ethdev: add new RSS offload types

2020-04-21 Thread Ferruh Yigit
On 4/22/2020 2:02 AM, Jeff Guo wrote: > Defines some new RSS offload types for ETH/S_VLAN/C_VLAN/L2TPV3/ > /PFCP/L2_SRC_ONLY/L2_DST_ONLY. > > Signed-off-by: Jeff Guo > Reviewed-by: Qi Zhang > Reviewed-by: Bernard Iremonger > Acked-by: Ori Kam Reviewed-by: Ferruh Yigit

  1   2   3   >