[dpdk-dev] [PATCH v3 1/1] bus/pci: optimise scanning with whitelist/blacklist

2020-04-19 Thread Sunil Kumar Kori
rte_bus_scan API scans all the available PCI devices irrespective of white or black listing parameters then further devices are probed based on white or black listing parameters. So unnecessary CPU cycles are wasted during rte_pci_scan. For Octeontx2 platform with core frequency 2.4 Ghz, rte_bus_s

[dpdk-dev] [PATCH] doc: update mlx5 PMD flow memory optimization

2020-04-19 Thread Suanming Mou
Add flow memory optimization item. Signed-off-by: Suanming Mou --- doc/guides/rel_notes/release_20_05.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index 6a03d6e..8065927 100644 --- a/doc/guides/rel_notes/

[dpdk-dev] [PATCH] net/bnxt: fix CLANG compilation error

2020-04-19 Thread Ajit Khaparde
Fix a compilation error seen with CLANG. The current code causes a typedef redefinition error because 'p__LINE__' is a C11 feature. Fixing it by defining it to something which is not already defined in the language. Fixes: 3ca9012a81f9 ("net/bnxt: add initial TruFlow core session open") Reported-

Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management

2020-04-19 Thread Xiaojun Liu
Hi Ferruh, Thanks! I checked the building by "devtools/test-build.sh x86_64-native-linux-gcc+next+shared", I didn't see any error. Could you tell me how do you build it and what's the error ? Best regards, Xiaojun -Original Message- From: Ye Xiaolong [mailto:xiaolong...@intel.com] Sent

[dpdk-dev] [PATCH v6 11/11] net/iavf: add RSS hash parsing in SSE path

2020-04-19 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in SSE data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 88 +++- 1 file changed, 72 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v6 09/11] net/iavf: support flow mark in SSE path

2020-04-19 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in SSE path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/i

[dpdk-dev] [PATCH v6 10/11] net/iavf: add RSS hash parsing in AVX path

2020-04-19 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in AVX data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 94 ++- 1 file changed, 92 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v6 06/11] net/iavf: add flow director enabled switch value

2020-04-19 Thread Leyi Rong
The commit adds fdir_enabled flag into iavf_rx_queue structure to identify if fdir id is active. Rx data path can be benefit if fdir id parsing is not needed, especially in vector path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_rxtx.h | 30 ++

[dpdk-dev] [PATCH v6 08/11] net/iavf: support flow mark in AVX path

2020-04-19 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in AVX path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 72 +-- 1 file changed, 67 insertions(+), 5 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf

[dpdk-dev] [PATCH v6 07/11] net/iavf: support flow mark in normal data path

2020-04-19 Thread Leyi Rong
Support Flow Director mark ID parsing in normal path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 3 +++ drivers/net/iavf/iavf_rxtx.c | 51 +++- 2 files changed, 47 insertions(+), 7 deletions(-) diff --git a/drivers/net/iavf/iavf.h b/drivers/net/

[dpdk-dev] [PATCH v6 05/11] net/iavf: flexible Rx descriptor support in SSE path

2020-04-19 Thread Leyi Rong
Support flexible Rx descriptor format in SSE path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 4 +- drivers/net/iavf/iavf_rxtx.h | 5 + drivers/net/iavf/iavf_rxtx_vec_sse.c | 414 +++ 3 files changed, 421 insertions(+), 2 d

[dpdk-dev] [PATCH v6 02/11] net/iavf: return error if opcode is mismatched

2020-04-19 Thread Leyi Rong
Adds error return when the opcode of read message is mismatched which is received from adminQ. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_vchnl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index fa4

[dpdk-dev] [PATCH v6 03/11] net/iavf: flexible Rx descriptor support in normal path

2020-04-19 Thread Leyi Rong
Support flexible Rx descriptor format in normal path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h| 2 + drivers/net/iavf/iavf_ethdev.c | 8 + drivers/net/iavf/iavf_rxtx.c | 485 ++--- drivers/net/iavf/iavf_rxtx.h | 9 + drivers/n

[dpdk-dev] [PATCH v6 04/11] net/iavf: flexible Rx descriptor support in AVX path

2020-04-19 Thread Leyi Rong
Support flexible Rx descriptor format in AVX path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 24 +- drivers/net/iavf/iavf_rxtx.h | 6 + drivers/net/iavf/iavf_rxtx_vec_avx2.c | 539 ++ 3 files changed, 563 insertions(+), 6

[dpdk-dev] [PATCH v6 01/11] net/iavf: flexible Rx descriptor definitions

2020-04-19 Thread Leyi Rong
Add definitions for flexible Rx descriptor structures and macros. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.h | 200 +++ 1 file changed, 200 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 09b5bd99e..d042

[dpdk-dev] [PATCH v6 00/11] framework for advanced iAVF PMD

2020-04-19 Thread Leyi Rong
This patchset enable framework for advanced iAVF, includes flexible descriptor support, FDIR mark id and RSS hash support. --- v6: - Remove some redundant code which may cause ICC build error. v5: - Set rxdid = 0 in iavf_configure_queues() when it's supported and RTE_LIBRTE_IAVF_16BYTE_RX_DESC

[dpdk-dev] Segmentation fault at rte_cpu_get_flag_enabled

2020-04-19 Thread vikram T
Hi, I have been seeing the application crashes( DPDK v19.08) with segmentation fault as below: (gdb) bt #0 0x0054fda9 in rte_cpu_get_flag_enabled () #1 0x004f5d5e in rte_hash_crc_init_alg () #2 0x0084cf7d in __libc_csu_init () #3 0x74df9425 in __libc_start_main (

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-19 Thread Tal Shnaiderman
> System meory management is implemented differently for POSIX and > Windows. Introduce wrapper functions for operations used across DPDK: > > * rte_mem_map() > Create memory mapping for a regular file or a page file (swap). > This supports mapping to a reserved memory region even on Windows.

[dpdk-dev] [PATCH v2 2/3] net/ice/base: add support for L2TP on switch

2020-04-19 Thread Wei Zhao
Add dummy packet and tunnel type to support L2TP on switch, now we can use session id as input set for swicth rule. Signed-off-by: Wei Zhao --- drivers/net/ice/base/ice_protocol_type.h | 2 + drivers/net/ice/base/ice_switch.c| 76 drivers/net/ice/base/ice_switch

[dpdk-dev] [PATCH v2 3/3] net/ice: add flow support for AH ESP and L2TP

2020-04-19 Thread Wei Zhao
Add switch filter support for AH ESP and L2TP protocol, and use spi or session idas input set for switch rule. Signed-off-by: Wei Zhao --- drivers/net/ice/ice_generic_flow.c | 25 drivers/net/ice/ice_generic_flow.h | 23 drivers/net/ice/ice_switch_filter.c | 198 +++

[dpdk-dev] [PATCH v2 1/3] net/ice/base: add support for AH ESP and NAT-T on switch

2020-04-19 Thread Wei Zhao
Add dummy packet and tunnel type to support AH ESP and NAT-T on switch, now we can use spi as input set for swicth rule. Signed-off-by: Wei Zhao --- drivers/net/ice/base/ice_protocol_type.h | 12 ++ drivers/net/ice/base/ice_switch.c| 235 +++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH v2 0/3] add support for L2TP AH ESP and NAT-T on switch

2020-04-19 Thread Wei Zhao
This patch set add switch filter support for AH ESP NAT-T and L2TP protocol, and use spi or session idas input set for switch rule. v2: -fix bug for input set error. Wei Zhao (3): net/ice/base: add support for AH ESP and NAT-T on switch net/ice/base: add support for L2TP on switch net/ice:

Re: [dpdk-dev] [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP

2020-04-19 Thread Zhao1, Wei
Ok, fix in v2 > -Original Message- > From: Zhang, Qi Z > Sent: Monday, April 20, 2020 1:17 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Fu, Qi > Subject: RE: [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Frid

Re: [dpdk-dev] [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP

2020-04-19 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, April 17, 2020 4:26 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Fu, Qi ; Zhao1, > Wei > Subject: [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP > > Add switch filter support for AH ESP and L2TP protocol, and use spi or >

Re: [dpdk-dev] [PATCH v4 5/5] net/fm10k: add switch management support

2020-04-19 Thread Ye Xiaolong
Hi, Xiaojun On 04/09, Xiaojun Liu wrote: >Split dev init to 2 parts. >First only register the port in switch >management; second init hook will be >called after all the pf are registered >and switch initialization. It will finish >dev init. Also add switch interrupt support. >Add fm10k_mirror_rule

Re: [dpdk-dev] Napatech pmd

2020-04-19 Thread Michael Lilja
> -Original Message- > From: Neil Horman > Sent: 19. april 2020 23:16 > To: Michael Lilja > Cc: Thomas Monjalon ; Finn Christensen > ; dev@dpdk.org; Bent Kuhre ; > techbo...@dpdk.org > Subject: Re: [dpdk-dev] Napatech pmd > > On Fri, Apr 17, 2020 at 04:38:42AM +, Michael Lilja wrote:

Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management

2020-04-19 Thread Ye Xiaolong
On 04/17, Ferruh Yigit wrote: >On 4/9/2020 7:26 AM, Xiaojun Liu wrote: >> V4: >> * Add I2C to control the inside LED and PHY. >> * Add SBUS to communicate with spico. >> * Add registers defination. >> * Add switch management log API. >> * Add switch management structures. >> * Add epl serdes includ

Re: [dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly

2020-04-19 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, April 16, 2020 11:11 AM > To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Ye, Xiaolong > Cc: Wang, Haiyue > Subject: [PATCH v1] net/ice: check the DSN package file firstly > > Align the package file search sequence with PF

[dpdk-dev] [PATCH v4] lpm: skip table entries update if rules found

2020-04-19 Thread Yangchao Zhou
Table entries do not need to be updated if the same rules can be found. Signed-off-by: Yangchao Zhou --- v1-v2: Skip updating when the next hop is the same as the current one v2-v4: Coding style fix --- lib/librte_lpm/rte_lpm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/lib

Re: [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of common bit operation APIs

2020-04-19 Thread Joyce Kong
> -Original Message- > From: Jerin Jacob > Sent: Friday, April 17, 2020 5:39 PM > To: Joyce Kong > Cc: tho...@monjalon.net; Stephen Hemminger > ; David Marchand > ; Morten Brørup > ; jer...@marvell.com; Richardson, Bruce > ; Ravi Kumar ; > Rasesh Mody ; Shahed Shaikh > ; Ziyang Xuan ; > X

[dpdk-dev] [PATCH 0/2] net/mlx5: fix indexed pool bugs

2020-04-19 Thread Suanming Mou
These two patches fix the bugs with indexed memory pool. 1. The incorrect pool entry size with mark reg copy. 2. The incorrect trunks free. Suanming Mou (2): net/mlx5: fix incorrect indexed pool configurations net/mlx5: fix indexed pool incorrect trunks free drivers/net/mlx5/mlx5.c |

[dpdk-dev] [PATCH 2/2] net/mlx5: fix indexed pool incorrect trunks free

2020-04-19 Thread Suanming Mou
When the allocated trunks are used out, the pool trunk array will be grown to a larger size to save more trunks. Currently, when replace the pool trunk array to the new one. The code wrongly frees the new trunk array. Should free the old trunk array to fix the bug. Fixes: 1702f7848f6a ("net/mlx5

[dpdk-dev] [PATCH 1/2] net/mlx5: fix incorrect indexed pool configurations

2020-04-19 Thread Suanming Mou
The indexed pool configurations of mark reg copy and hrxq are incorrect. The incorrect pool trunk size which assigned the meter struct size to mark reg copy pool will caused wrong memory entry allocated. The incorrect pool type makes the hrxq pool seems be confusing. Fixes: a339b088298d ("net/ml

[dpdk-dev] [PATCH] net/mlx5: fix RSS description corrupt issue

2020-04-19 Thread Suanming Mou
Currently, RSS description data is saved in the mlx5 private data. It dose not support the nest flow_list_create() routine. In the case with mark reg copy, the flow_list_create() function will be called nested. The RSS description data will be cleared in the nested case. Allocate one more RSS des

[dpdk-dev] [PATCH v2] bbdev: doxygen update only

2020-04-19 Thread Nicolas Chautru
Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib") Several doxygen markup were incorrect in header files. Signed-off-by: Nicolas Chautru --- lib/librte_bbdev/rte_bbdev.h | 16 lib/librte_bbdev/rte_bbdev_op.h | 16 lib/librte_bbdev/rte_b

[dpdk-dev] [PATCH v2] bbdev: doxygen fix

2020-04-19 Thread Nicolas Chautru
v2: Fixes reference added in commit message (this was there from the beginning) though this is not critical for LTS branch. Cosmetic changes for doxygen markup which were incorrect as raised during parallel code review. Nicolas Chautru (1): bbdev: doxygen update only lib/librte_bbdev/rte

Re: [dpdk-dev] [PATCH v4 1/4] lib/rcu: add resource reclamation APIs

2020-04-19 Thread Honnappa Nagarahalli
> > > Add resource reclamation APIs to make it simple for applications and > > libraries to integrate rte_rcu library. > > Few nits, thoughts, please see below. > Apart from that - LGTM. > Acked-by: Konstantin Ananyev > > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Ola Liljedh

Re: [dpdk-dev] [PATCH v5 7/9] ring: introduce peek style API

2020-04-19 Thread Ananyev, Konstantin
> > > > > > > > > > > > > diff --git a/lib/librte_ring/rte_ring_generic.h > > > > > b/lib/librte_ring/rte_ring_generic.h > > > > > index 953cdbbd5..9f5fdf13b 100644 > > > > > --- a/lib/librte_ring/rte_ring_generic.h > > > > > +++ b/lib/librte_ring/rte_ring_generic.h > > > > Changes in this file ar

Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance

2020-04-19 Thread Akhil Goyal
> test app to measures the performance of libipsec > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. > > Signed-off-by: Savinay Dharmappa > Acked-by: Konstantin Ananyev > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] doc: support IPsec Multi-buffer lib v0.54

2020-04-19 Thread Akhil Goyal
> Updated AESNI MB and AESNI GCM PMD documentation guides > with information about the latest Intel IPSec Multi-buffer > library supported. > > Signed-off-by: Pablo de Lara > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2 1/1] crypto/qat: support plain SHA1..SHA512 hashes

2020-04-19 Thread Akhil Goyal
> > This patch adds support for plain SHA-1, SHA-224, SHA-256, > SHA-384 and SHA-512 hashes to QAT PMD. > > Signed-off-by: Adam Dybkowski > Acked-by: Fiona Trahe > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] Napatech pmd

2020-04-19 Thread Neil Horman
On Fri, Apr 17, 2020 at 04:38:42AM +, Michael Lilja wrote: > > -Original Message- > > From: Neil Horman > > Sent: 17. april 2020 04:55 > > To: Thomas Monjalon > > Cc: Finn Christensen ; dev@dpdk.org; Bent Kuhre > > ; Michael Lilja ; techbo...@dpdk.org > > Subject: Re: [dpdk-dev] Napat

Re: [dpdk-dev] [PATCH v5 7/9] ring: introduce peek style API

2020-04-19 Thread Honnappa Nagarahalli
> > > > > > > > diff --git a/lib/librte_ring/rte_ring_generic.h > > > > b/lib/librte_ring/rte_ring_generic.h > > > > index 953cdbbd5..9f5fdf13b 100644 > > > > --- a/lib/librte_ring/rte_ring_generic.h > > > > +++ b/lib/librte_ring/rte_ring_generic.h > > > Changes in this file are not required as

Re: [dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase)

2020-04-19 Thread Akhil Goyal
> This patchset adds crypto capability checks > in the cryptodev test code, to be able to skip unsupported > test cases for each crypto device, according to their > capabilities. > > Thanks to this patchset, there is no more need to check > for internal PMD information in the test code, making it

Re: [dpdk-dev] [PATCH v2 0/4] Crypto test refactoring (second phase)

2020-04-19 Thread Akhil Goyal
> > Changes in v2: > > - Added new commit, adding a check for out-of-place operations > > > > Pablo de Lara (4): > > cryptodev: add sessionless support feature flag > > test/crypto: check if device supports sessionless > > test/crypto: check if device supports out-of-place ops > > test/cryp

Re: [dpdk-dev] [PATCH v1] bbdev: doxygen update only

2020-04-19 Thread Akhil Goyal
Hi Nicolas, Can you add fixes lines for the commits which introduced these issues so that these can be backported as well? Also cc stable Regards, Akhil > -Original Message- > From: Nicolas Chautru > Sent: Monday, April 20, 2020 2:17 AM > To: dev@dpdk.org; Akhil Goyal > Cc: Nicolas Ch

[dpdk-dev] [PATCH v1] bbdev: doxygen fix

2020-04-19 Thread Nicolas Chautru
Cosmetic changes for doxygen markup which were incorrect as raised during parallel code review. Nicolas Chautru (1): bbdev: doxygen update only lib/librte_bbdev/rte_bbdev.h | 16 lib/librte_bbdev/rte_bbdev_op.h | 16 lib/librte_bbdev/rte_bbdev_pmd.h | 14

[dpdk-dev] [PATCH v1] bbdev: doxygen update only

2020-04-19 Thread Nicolas Chautru
Several doxygen markup were incorrect in header files. Signed-off-by: Nicolas Chautru --- lib/librte_bbdev/rte_bbdev.h | 16 lib/librte_bbdev/rte_bbdev_op.h | 16 lib/librte_bbdev/rte_bbdev_pmd.h | 14 +++--- 3 files changed, 23 insertions(+), 23 de

Re: [dpdk-dev] [PATCH v1] ethdev: add rte_device to port_id function

2020-04-19 Thread Gaëtan Rivet
On 17/04/20 13:44 -0700, Stephen Hemminger wrote: > On Fri, 17 Apr 2020 18:48:37 +0200 > Gaetan Rivet wrote: > > > +/** > > + * Find the owned ethdev port id of an `rte_device`. > > + * > > + * @param dev > > + * An `rte_device`. > > + * @param owner > > + * An owner id. Use `RTE_ETH_DEV_NO_O

Re: [dpdk-dev] [PATCH v5 7/9] ring: introduce peek style API

2020-04-19 Thread Ananyev, Konstantin
> > > > diff --git a/lib/librte_ring/rte_ring_generic.h > > > b/lib/librte_ring/rte_ring_generic.h > > > index 953cdbbd5..9f5fdf13b 100644 > > > --- a/lib/librte_ring/rte_ring_generic.h > > > +++ b/lib/librte_ring/rte_ring_generic.h > > Changes in this file are not required as we agreed to imple

Re: [dpdk-dev] [PATCH v5 7/9] ring: introduce peek style API

2020-04-19 Thread Ananyev, Konstantin
> > diff --git a/lib/librte_ring/rte_ring_generic.h > > b/lib/librte_ring/rte_ring_generic.h > > index 953cdbbd5..9f5fdf13b 100644 > > --- a/lib/librte_ring/rte_ring_generic.h > > +++ b/lib/librte_ring/rte_ring_generic.h > Changes in this file are not required as we agreed to implement only C11 f

Re: [dpdk-dev] [PATCH v5] build: disable experimental API check internally

2020-04-19 Thread Chautru, Nicolas
Hi David, I will double check internally then as it may be something just that I miss on my end right now given you cannot reproduce it. > -Original Message- > From: David Marchand > Sent: Sunday, April 19, 2020 12:35 AM > To: Chautru, Nicolas > Cc: Trahe, Fiona ; Akhil Goyal ; > dev

Re: [dpdk-dev] [PATCH v5 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

2020-04-19 Thread Akhil Goyal
> > v5: Fix incremenral patch build and few rebase updates > v4: Fix incremental patch build and expose PMD header file to meson. > v3: Incremental changes from reviews : file name change, moving few inline > function to .h, adding missing inline, doxygen markup fix. > > Adding new baseband PMD f

Re: [dpdk-dev] [PATCH] devtools: reduce examples in static builds

2020-04-19 Thread Thomas Monjalon
19/04/2020 16:29, Thomas Monjalon: > 19/04/2020 09:08, David Marchand: > > On Sat, Apr 18, 2020 at 3:20 PM Thomas Monjalon wrote: > > > --- a/devtools/test-meson-builds.sh > > > +++ b/devtools/test-meson-builds.sh > > > - options="$options --werror -Dexamples=all" > > > + options="$opt

Re: [dpdk-dev] [PATCH] devtools: reduce examples in static builds

2020-04-19 Thread Thomas Monjalon
19/04/2020 09:08, David Marchand: > On Sat, Apr 18, 2020 at 3:20 PM Thomas Monjalon wrote: > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > - options="$options --werror -Dexamples=all" > > + options="$options --werror" > > + if echo $* | grep -q

Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions

2020-04-19 Thread Thomas Monjalon
19/04/2020 15:09, Thomas Monjalon: > 17/04/2020 16:09, Burakov, Anatoly: > > On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: > > > On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: > > >> Hi Anatoly, > > >> > > >> I’m working on the implementation of bus/pci driver for Windows, > > >> pci_common.c uses t

Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions

2020-04-19 Thread Thomas Monjalon
17/04/2020 16:09, Burakov, Anatoly: > On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: > > On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: > >> Hi Anatoly, > >> > >> I’m working on the implementation of bus/pci driver for Windows, > >> pci_common.c uses the titled functions however they are relevant onl

Re: [dpdk-dev] [PATCH v5 1/9] test/ring: add contention stress test

2020-04-19 Thread Ananyev, Konstantin
> > On Sun, Apr 19, 2020 at 4:31 AM Honnappa Nagarahalli > wrote: > > > Introduce stress test for ring enqueue/dequeue operations. > > > Performs the following pattern on each slave worker: > > > dequeue/read-write data from the dequeued objects/enqueue. > > > Serves as both functional and perfor

Re: [dpdk-dev] [PATCH] net/mlx5: fix indexed pool 32-bits build error

2020-04-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Saturday, April 18, 2020 4:45 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: ferruh.yi...@intel.com; Raslan Darawsheh ; > dev@dpdk.org > Subject: [PATCH] net/mlx5: fix indexed pool 32-bits build error > > Currently, 32-bits compiler

[dpdk-dev] [PATCH] common/mlx5: fix relaxed ordering optimization performance

2020-04-19 Thread Shiri Kuzin
Relaxed Ordering is a PCI optimization that allows reordering of reads/writes in order to improve performance. in order to support devices that don't enable this optimization we define IBV_ACCESS_RELAXED_ORDERING as 0. currently the optimization wasn't activated since we always defined IBV_ACCESS

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-19 Thread Guy Kaneti
> -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Wednesday, April 08, 2020 11:40 AM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com; Pavan Nikhilesh > Bhagavatula > Cc: dev@dpdk.org; Shahaf Shuler ; > hemant.agra...@nxp.com; Opher Reviv ; Alex

[dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-19 Thread jerinj
From: Jerin Jacob Add programmar's guide for trace library support. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS| 1 + doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/trace_lib.rst| 346 +

[dpdk-dev] [PATCH v6 32/33] mempool: add tracepoints

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- lib/librte_mempool/Makefile| 3 + lib/librte_mempool/mempool_trace_points.c | 108 + lib/librte_mempool/meson.build | 5 +

[dpdk-dev] [PATCH v6 11/33] eal/trace: implement debug dump function

2020-04-19 Thread jerinj
From: Jerin Jacob Implement rte_trace_metadata_dump() and rte_trace_dump() functions. Former one used to dump the CTF metadata file and the latter one to dump all the registered events and its status. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v6 17/33] eal/trace: add generic tracepoints

2020-04-19 Thread jerinj
From: Jerin Jacob This patch creates the following generic tracepoint for generic tracing when there is no dedicated tracepoint is available. - rte_trace_lib_eal_generic_void() - rte_trace_lib_eal_generic_u64() - rte_trace_lib_eal_generic_u32() - rte_trace_lib_eal_generic_u16() - rte_trace_lib_e

[dpdk-dev] [PATCH v6 24/33] eal/trace: add trace dir configuration parameter

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-dir EAL parameter to configure directory where traces will be generated. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 11 lib/librte_eal/common/eal_common_options.c| 15 ++ .../common/eal_c

[dpdk-dev] [PATCH v6 31/33] cryptodev: add tracepoints

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- lib/librte_cryptodev/Makefile | 4 +- lib/librte_cryptodev/cryptodev_trace_points.c | 70 + lib/librte_cryptodev/meson.build |

[dpdk-dev] [PATCH v6 29/33] ethdev: add tracepoints

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- examples/cmdline/Makefile | 1 + examples/cmdline/meson.build | 1 + examples/distributor/Makefile | 1 + exam

[dpdk-dev] [PATCH v6 28/33] eal/trace: add trace performance test cases

2020-04-19 Thread jerinj
From: Jerin Jacob This test case shall be used to measure the trace overhead. Example command to run the performance test case. echo "trace_perf" | ./build/app/test/dpdk-test -c 0x3 --trace=.* Signed-off-by: Jerin Jacob --- app/test/Makefile | 1 + app/test/meson.build | 1

[dpdk-dev] [PATCH v6 30/33] eventdev: add tracepoints

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- lib/librte_eventdev/Makefile | 3 + lib/librte_eventdev/eventdev_trace_points.c | 173 ++ lib/librte_eventdev/meson.build |

[dpdk-dev] [PATCH v6 22/33] eal/trace: add interrupt tracepoints

2020-04-19 Thread jerinj
From: Jerin Jacob Add the following interrupt related tracepoints. - rte_trace_lib_eal_intr_callback_register() - rte_trace_lib_eal_intr_callback_unregister() - rte_trace_lib_eal_intr_enable() - rte_trace_lib_eal_intr_disable() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points

[dpdk-dev] [PATCH v6 25/33] eal/trace: add trace bufsize configuration parameter

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-bufsz EAL parameter to configure maximum size of ring buffer where events are to be stored. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 13 lib/librte_eal/common/eal_common_options.c| 17 +

[dpdk-dev] [PATCH v6 27/33] eal/trace: add unit test cases

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Example commands to run UT and check the traces with babeltrace viewer. - Delete the existing /root/dpdk-traces/ directory if needed. > sudo rm -rf /root/dpdk-traces/ - Start the dpdk-test > sudo ./build/app/test/dpdk-test -c 0x3 - --trace=.* - Run trace_autotest > trac

[dpdk-dev] [PATCH v6 26/33] eal/trace: add trace mode configuration parameter

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-mode eal parameter to configure event record mode when ring buffers are full. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 12 ++ lib/librte_eal/common/eal_common_options.c| 17 .../com

[dpdk-dev] [PATCH v6 03/33] eal/trace: define the public API for trace support

2020-04-19 Thread jerinj
From: Jerin Jacob Define the public API for trace support. This patch also adds support for the build infrastructure and update the MAINTAINERS file for the trace subsystem. The tracepoint object is of size 8B, it a global variable and used in fastpath. Created a new __rte_trace_point section to

[dpdk-dev] [PATCH v6 23/33] eal/trace: add trace configuration parameter

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace EAL parameter to enable trace points. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 16 + lib/librte_eal/common/eal_common_options.c| 16 + lib/librte_eal/common/eal_common_trace.c | 10

[dpdk-dev] [PATCH v6 20/33] eal/trace: add memzone tracepoints

2020-04-19 Thread jerinj
From: Jerin Jacob Add the following memzone related tracepoints. - rte_trace_lib_eal_memzone_reserve() - rte_trace_lib_eal_memzone_lookup() - rte_trace_lib_eal_memzone_free() Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_memzone.c| 9 ++ .../common/eal_common_trace_

[dpdk-dev] [PATCH v6 21/33] eal/trace: add thread tracepoints

2020-04-19 Thread jerinj
From: Jerin Jacob Add the following thread related tracepoints. - rte_trace_lib_eal_thread_remote_launch() - rte_trace_lib_eal_thread_lcore_ready() Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace_points.c | 8 lib/librte_eal/freebsd/eal_interrupts.c |

[dpdk-dev] [PATCH v6 18/33] eal/trace: add alarm tracepoints

2020-04-19 Thread jerinj
From: Jerin Jacob Add following alarm related trace points. - rte_trace_lib_eal_alarm_set() - rte_trace_lib_eal_alarm_cancel() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c | 9 lib/librte_eal/freebsd/eal_alarm.c| 3 +++ lib/librte_eal/inc

[dpdk-dev] [PATCH v6 19/33] eal/trace: add memory tracepoints

2020-04-19 Thread jerinj
From: Jerin Jacob Add the following memory-related tracepoints. - rte_trace_lib_eal_mem_zmalloc() - rte_trace_lib_eal_mem_malloc() - rte_trace_lib_eal_mem_realloc() - rte_trace_lib_eal_mem_free() rte_malloc() and rte_free() has been used in the trace implementation, in order to avoid tracing im

[dpdk-dev] [PATCH v6 15/33] eal/trace: hook internal trace APIs to Linux

2020-04-19 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to Linux EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_thread.c | 4 +++- lib/librte_eal/linux/eal.c| 9 + lib/librte_eal/linux/eal_thread.c | 4 3 files changed, 16 insertion

[dpdk-dev] [PATCH v6 14/33] eal/trace: implement provider payload

2020-04-19 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_point_emit_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace mem emitters a.k.a provider payload. When it used as provider payload, those function copy the trace fi

[dpdk-dev] [PATCH v6 16/33] eal/trace: hook internal trace APIs to FreeBSD

2020-04-19 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to FreeBSD EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/freebsd/eal.c| 10 ++ lib/librte_eal/freebsd/eal_thread.c | 4 2 files changed, 14 insertions(+) diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librt

[dpdk-dev] [PATCH v6 13/33] eal/trace: implement registration payload

2020-04-19 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_point_emit_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace memory emitters. When it used as registration payload, it will do the following to fulfill the registra

[dpdk-dev] [PATCH v6 05/33] eal/trace: implement trace operation APIs

2020-04-19 Thread jerinj
From: Jerin Jacob This patch implements the following public trace APIs. - rte_trace_is_enabled() - rte_trace_mode_get() - rte_trace_mode_set() - rte_trace_pattern() - rte_trace_point_disable() - rte_trace_point_enable() - rte_trace_point_is_enabled() - rte_trace_point_lookup() - rte_trace_regex

[dpdk-dev] [PATCH v6 12/33] eal/trace: implement trace save

2020-04-19 Thread jerinj
From: Jerin Jacob Implement rte_trace_save(), which will save the metadata file and trace memory snapshot to the trace directory. Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_utils.c | 80 +++ lib/librte_eal/rte_eal_version.map| 1 + 2 files

[dpdk-dev] [PATCH v6 10/33] eal/trace: implement trace memory allocation

2020-04-19 Thread jerinj
From: Jerin Jacob Trace memory will be allocated per thread to enable lockless trace events updates to the memory. The allocator will first attempt to allocate from hugepage, if not available from hugepage then fallback to malloc memory. Later in the patches series, This API will be hooked to DP

[dpdk-dev] [PATCH v6 09/33] eal/trace: handle CTF keyword collision

2020-04-19 Thread jerinj
From: Sunil Kumar Kori Some of the keyword like align, event, "." and "->" etc will be used in CTF metadata syntax. This patch support for handling those keywords with DPDK events name. Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++

[dpdk-dev] [PATCH v6 08/33] eal/trace: create CTF TDSL metadata in memory

2020-04-19 Thread jerinj
From: Jerin Jacob Common trace format(CTF) defines the metadata[1][2] for trace events, This patch creates the metadata for the DPDK events in memory and latter this will be saved to trace directory on rte_trace_save() invocation. [1] https://diamon.org/ctf/#specification [2] https://diamon.org/

[dpdk-dev] [PATCH v6 06/33] eal/trace: add internal trace init and fini interface

2020-04-19 Thread jerinj
From: Jerin Jacob Define eal_trace_init() and eal_trace_fini() EAL interface functions that rte_eal_init() and rte_eal_cleanup() function can be use to initialize and finalize the trace subsystem. eal_trace_init() function will add the following functionality if trace is enabled through EAL comma

[dpdk-dev] [PATCH v6 07/33] eal/trace: get bootup timestamp for trace

2020-04-19 Thread jerinj
From: Jerin Jacob Find epoch_sec, epoch_nsec and uptime_ticks time information on eal_trace_init()/bootup to derive the time in the trace. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 3 +++ .../common/eal_common_trace_utils.c | 22 +

[dpdk-dev] [PATCH v6 01/33] meson: add libatomic as a global dependency for i686 clang

2020-04-19 Thread jerinj
From: Pavan Nikhilesh Add libatomic as a global dependency when compiling for 32-bit using clang. As we need libatomic for 64-bit atomic ops. Cc: bruce.richard...@intel.com Signed-off-by: Pavan Nikhilesh Acked-by: Bruce Richardson --- config/meson.build | 8 drivers

[dpdk-dev] [PATCH v6 04/33] eal/trace: implement trace register API

2020-04-19 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS

[dpdk-dev] [PATCH v6 00/33] DPDK Trace support

2020-04-19 Thread jerinj
From: Jerin Jacob v6 ~~ Following changes are based on David's feedback. 1) Changed rte_trace_t to rte_trace_point_t 2) Reworked the header file to have following API name and filename changes rte_trace.h has following trace control APIs ~~~ a) rte_trace_is_enabl

[dpdk-dev] [PATCH v6 02/33] eal: introduce API for getting thread name

2020-04-19 Thread jerinj
From: Jerin Jacob Introduce rte_thread_getname() API to get the thread name and implement it for Linux and FreeBSD. FreeBSD does not support getting the thread name. One of the consumers of this API will be the trace subsystem where it used as an informative purpose. Signed-off-by: Jerin Jacob

Re: [dpdk-dev] [PATCH v5 1/9] test/ring: add contention stress test

2020-04-19 Thread David Marchand
On Sun, Apr 19, 2020 at 4:31 AM Honnappa Nagarahalli wrote: > > Introduce stress test for ring enqueue/dequeue operations. > > Performs the following pattern on each slave worker: > > dequeue/read-write data from the dequeued objects/enqueue. > > Serves as both functional and performance test of r

Re: [dpdk-dev] [PATCH] ci: remove aarch64 from Travis jobs

2020-04-19 Thread David Marchand
Honnappa, Ruifeng, On Thu, Apr 16, 2020 at 5:55 PM Honnappa Nagarahalli wrote: > > > > > Subject: Re: [PATCH] ci: remove aarch64 from Travis jobs > > > > 16/04/2020 15:45, Aaron Conole: > > > David Marchand writes: > > > > On Thu, Apr 16, 2020 at 2:44 PM Aaron Conole > > wrote: > > > >> Thomas

Re: [dpdk-dev] [PATCH v5] build: disable experimental API check internally

2020-04-19 Thread David Marchand
On Sat, Apr 18, 2020 at 9:46 PM Chautru, Nicolas wrote: > It is probably just me but I having issue with this new patch. > I typically rebuild the PMD libraries directly when doing incremental changes > from the Makefile in the PMD directory (ie. not rebuilding full DPDK each > time, which still

Re: [dpdk-dev] [PATCH] devtools: reduce examples in static builds

2020-04-19 Thread David Marchand
On Sat, Apr 18, 2020 at 3:20 PM Thomas Monjalon wrote: > > Static builds can take a lot of space, so reduce the number of examples > built when testing those static builds. > > As makefile-based build is close to end of life, completely skip examples > in case of static linkage with make. > > Sign