Re: [dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-03-29 Thread Jerin Jacob
On Mon, Mar 30, 2020 at 9:40 AM Dmitry Kozlyuk wrote: > > This patch is for dpdk-kmods tree. > > This driver supports Windows EAL memory management by translating > current process virtual addresses to physical addresses (IOVA). > Standalone virt2phys allows using DPDK without PMD and provides a >

[dpdk-dev] [PATCH v2] net/ixgbe: fix issue for e-tag defination

2020-03-29 Thread Wei Zhao
An issue has been caused after change definations of bool, we had better use uint16_t to define e-tag ethertype, not 8 bits length bool, that patch will change bool bits length, which introduce a bug for etag/etag_strip for x550 NIC. So change to the 16 bits defination. Cc: sta...@dpdk.org Fixes:

Re: [dpdk-dev] [PATCH] event/octeontx2: use c11 atomics for statistics

2020-03-29 Thread Phil Yang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, March 27, 2020 4:56 PM > To: jer...@marvell.com; Honnappa Nagarahalli > ; Phil Yang ; Pavan > Nikhilesh > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] event/octeontx2: use c11 atomics for statistics > > From: Pavan N

Re: [dpdk-dev] [PATCH] net/mlx5: fix imissed counter overflow issue

2020-03-29 Thread Slava Ovsiienko
> -Original Message- > From: Jiawei Wang > Sent: Monday, March 30, 2020 6:02 > To: Slava Ovsiienko ; Matan Azrad > ; Jiawei(Jonny) Wang > Cc: Raslan Darawsheh ; dev@dpdk.org; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix imissed counter overflow issue > > The Hw counters is defined

[dpdk-dev] [PATCH] update MAINTAINERs for mrvl PMDs

2020-03-29 Thread lironh
From: Liron Himi update MRVL PMDs, Tomasz is no longer with semihalf Signed-off-by: Liron Himi --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index bc98b9167..339309089 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -704,7 +704,6 @@ F: doc/guides/

[dpdk-dev] [PATCH] change MAINTAINER for raw

2020-03-29 Thread Hemant Agrawal
replace raw maintainer. Shreyansh is no longer with NXP Signed-off-by: Hemant Agrawal --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index db235c2cc..f6061ea92 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -467,7 +467,7 @@ F: app/tes

[dpdk-dev] [RFC PATCH 8/9] eal/windows: replace sys/queue.h with a complete one from FreeBSD

2020-03-29 Thread Dmitry Kozlyuk
Limited version imported previously lacks at least SLIST macros. Import a complete file from FreeBSD, since its license exception is already approved by Technical Board. Signed-off-by: Dmitry Kozlyuk --- .../windows/eal/include/sys/queue.h | 663 -- 1 file changed, 601

[dpdk-dev] [RFC PATCH 9/9] eal/windows: implement basic memory management

2020-03-29 Thread Dmitry Kozlyuk
Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver to obtain IOVAs of hugepages allocated from user-mode. Signed-off-by: Dmitry Kozlyuk --- config/meson.build| 2 +- lib/librte_eal/common/eal_common_fb

[dpdk-dev] [RFC PATCH 3/9] eal/windows: improve CPU and NUMA node detection

2020-03-29 Thread Dmitry Kozlyuk
1. Map CPU cores to their respective NUMA nodes as reported by system. 2. Support systems with more than 64 cores (multiple processor groups). 3. Fix magic constants, styling issues, and compiler warnings. 4. Add EAL private function to map DPDK socket ID to NUMA node number. Fixes: 53ffd9f080fc (

[dpdk-dev] [RFC PATCH 4/9] eal/windows: initialize hugepage info

2020-03-29 Thread Dmitry Kozlyuk
Add hugepages discovery ("large pages" in Windows terminology) and update documentation for required privilege setup. Signed-off-by: Dmitry Kozlyuk --- config/meson.build | 2 + doc/guides/windows_gsg/build_dpdk.rst | 20 doc/guides/windows_gsg/index.rst

[dpdk-dev] [RFC PATCH 5/9] eal: introduce internal wrappers for file operations

2020-03-29 Thread Dmitry Kozlyuk
EAL common code uses file locking and truncation. Introduce OS-independent wrapeprs in order to support both POSIX and Windows: * eal_file_lock: lock or unlock an open file. * eal_file_truncate: enforce a given size for an open file. Wrappers follow POSIX semantics, but interface is not POSIX, so

[dpdk-dev] [RFC PATCH 7/9] eal/windows: fix rte_page_sizes with Clang on Windows

2020-03-29 Thread Dmitry Kozlyuk
Clang on Windows follows MS ABI where enum values are signed 32-bit, Enum rte_page_size has members valued beyond 2^32. EAL cannot use -fno-ms-compatibility because its code is OS-dependent. The only option is to define these values outside enum, but this prohibits using -fstrict-enums. Another

[dpdk-dev] [RFC PATCH 6/9] eal: introduce memory management wrappers

2020-03-29 Thread Dmitry Kozlyuk
System meory management is implemented differently for POSIX and Windows. Introduce wrapper functions for operations used across DPDK: * rte_mem_map() Create memory mapping for a regular file or a page file (swap). This supports mapping to a reserved memory region even on Windows. * rte_mem_u

[dpdk-dev] [RFC PATCH 2/9] eal/windows: do not expose private EAL facilities

2020-03-29 Thread Dmitry Kozlyuk
The goal of rte_os.h is to mitigate OS differences for EAL users. In Windows EAL, rte_os.h did excessive things: 1. It included platform SDK headers (windows.h, etc). Those files are huge, require specific inclusion order, and are generally unused by the code including rte_os.h. Declarations

[dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-03-29 Thread Dmitry Kozlyuk
This patch is for dpdk-kmods tree. This driver supports Windows EAL memory management by translating current process virtual addresses to physical addresses (IOVA). Standalone virt2phys allows using DPDK without PMD and provides a reference implementation. UIO drivers might also implement virt2phy

[dpdk-dev] [RFC PATCH 0/9] Windows basic memory management

2020-03-29 Thread Dmitry Kozlyuk
This RFC implements basic MM with the following features: * Hugepages are dynamically allocated in user-mode. * IOVA is always PA, obtained through kernel-mode driver. * No 32-bit support (presumably not demanded). * No multi-process support. Note that without --in-memory EAL MM will create file

[dpdk-dev] [PATCH] net/mlx5: fix imissed counter overflow issue

2020-03-29 Thread Jiawei Wang
The Hw counters is defined as 32bit unsigned value and read from the sysfs. Firstly read the base value while application start, then fetch the new value while do query and minus the base value. If the new value is less than base value, will result in the a negative value and convert to the big val

Re: [dpdk-dev] [PATCH v2 2/2] examples/vmdq: fix RSS configuration

2020-03-29 Thread Han, YingyaX
Tested-by: Han,YingyaX BRs, Yingya -Original Message- From: dev On Behalf Of Junyu Jiang Sent: Wednesday, March 25, 2020 2:33 PM To: dev@dpdk.org Cc: Yang, Qiming ; Yigit, Ferruh ; Jiang, JunyuX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2 2/2] examples/vmdq: fix RSS configuration

Re: [dpdk-dev] 18.11.7 (LTS) patches review and test

2020-03-29 Thread Yu, PingX
Kevin and all, FYI. Update the test result of Intel part, all passed. * Intel(R) Testing # Basic Intel(R) NIC testing * PF(i40e): Passed * PF(ixgbe): Passed * VF: Passed * Build or compile: Passed * Intel NIC single core/NIC performance: Passed #Basic cryptodev and virtio testing * vhost/virti

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] examples/vmdq: fix the output of pools/queues

2020-03-29 Thread Han, YingyaX
Tested-by: Han,YingyaX BRs, Yingya -Original Message- From: stable On Behalf Of Li, Xiaoyun Sent: Monday, March 2, 2020 3:19 PM To: Jiang, JunyuX ; dev@dpdk.org Cc: Yang, Qiming ; sta...@dpdk.org Subject: Re: [dpdk-stable] [PATCH v3] examples/vmdq: fix the output of pools/queues Hi > -

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-29 Thread Zhang, Xiao
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Sunday, March 29, 2020 8:46 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Xiao, > > > -Original Message- > > From:

Re: [dpdk-dev] rte_flow: Different devices have different field indianess?

2020-03-29 Thread Xing, Beilei
> -Original Message- > From: Tom Barbette > Sent: Friday, March 27, 2020 10:51 PM > To: Andrew Rybchenko ; dev@dpdk.org > Cc: or...@mellanox.com; Xing, Beilei ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] rte_flow: Different devices have different field > indianess? > > Le 27/03/2020 à 15:

Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-29 Thread Chautru, Nicolas
> From: Akhil Goyal > >> > >> From: Nic Chautru > >> > >> Supports for FEC 5G PMD Driver on FPGA card PAC N3000 > >> > >> Signed-off-by: Nic Chautru > >> --- > > > >I cannot review this patch. This patch should be a separate series. > >This should be split into logical parts as a new PMD is subm

[dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function

2020-03-29 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 57 ++ doc/guides/bbdevs/fpga_5gnr_fec.rst| 123 +++

[dpdk-dev] [PATCH v2 12/13] baseband/fpga_5gnr_fec: add interrupt support

2020-03-29 Thread Nicolas Chautru
Adding support for interrupt capability in the PMD and the related operations. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 156 + 1 file changed, 156 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/

[dpdk-dev] [PATCH v2 08/13] baseband/fpga_5gnr_fec: add HW error capture

2020-03-29 Thread Nicolas Chautru
Adding HW specific parsing of error report for negative scenarios. Not hit through unit test. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_

[dpdk-dev] [PATCH v2 11/13] baseband/fpga_5gnr_fec: add harq loopback capability

2020-03-29 Thread Nicolas Chautru
Adding optional capability to support loopback preloading and check of the extern HARQ memory. This function is required to run the HARQ bit exact test successfully. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 171 + 1 file changed,

[dpdk-dev] [PATCH v2 13/13] doc: add feature matrix table for bbdev devices

2020-03-29 Thread Nicolas Chautru
Adding missing overview page in documentation with comparison of feature set by each available PMD implementation. Signed-off-by: Nicolas Chautru --- .gitignore | 1 + doc/guides/bbdevs/features/default.ini | 16 doc/guides/bbdevs/feature

[dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add queue configuration

2020-03-29 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 441 - drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h | 35 ++ 2 files changed, 475 insertions(+),

[dpdk-dev] [PATCH v2 09/13] baseband/fpga_5gnr_fec: add debug functionality

2020-03-29 Thread Nicolas Chautru
Adding functionality for debug mode to be more verbose and catch error from unsupported configuration. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 364 + 1 file changed, 364 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec

[dpdk-dev] [PATCH v2 03/13] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-29 Thread Nicolas Chautru
Add stubs for the FPGA 5GNR FEC PMD Signed-off-by: Nicolas Chautru --- config/common_base | 5 + doc/guides/bbdevs/fpga_5gnr_fec.rst| 146 doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v2 01/13] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-29 Thread Nicolas Chautru
From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2 ++ lib/librte_bbdev/rte_bbdev_op.h | 12 ++-- 2 files changed,

[dpdk-dev] [PATCH v2 04/13] baseband/fpga_5gnr_fec: add register definition file

2020-03-29 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h | 189 + 1 file changed, 189 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h b/d

[dpdk-dev] [PATCH v2 02/13] bbdev: expose device HARQ buffer size at device level

2020-03-29 Thread Nicolas Chautru
From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +- lib/l

[dpdk-dev] [PATCH v2 05/13] baseband/fpga_5gnr_fec: add device info_get function

2020-03-29 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru --- app/test-bbdev/Makefile| 3 ++ app/test-bbdev/meson.build

[dpdk-dev] [PATCH v2 07/13] baseband/fpga_5gnr_fec: add LDPC processing functions

2020-03-29 Thread Nicolas Chautru
Adding LDPC processing operations and related documentation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/fpga_5gnr_fec.rst| 28 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 660 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h | 9 +

[dpdk-dev] [PATCH v2 00/13] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-29 Thread Nicolas Chautru
v2: minor fix to commit message. Adding new baseband PMD for FPGA 5GNR FEC implementation. This was first shared as part of that serie https://patches.dpdk.org/project/dpdk/list/?series=9050 but now splitting separately as suggested. The differental incremental patches are split based on logica

[dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv

2020-03-29 Thread Ophir Munk
File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS agnostic and not include any references to ibv or dv structs (defined in ibverbs and rdma-core linux libraries). This commit replaces all ibv and dv references with 'void *'. Specifically, the following struct were replaced: 1. s

Re: [dpdk-dev] DPDK 20.05 Mellanox Roadmap

2020-03-29 Thread Thomas Monjalon
Summarized for the web: http://git.dpdk.org/tools/dpdk-web/commit/?id=7edb98830 16/03/2020 09:21, Gal Cohen: > Below is Mellanox's roadmap for DPDK20.05: > > > > Reduce memory consumption in mlx5 PMD - > > [1] Reduce flow memory (entry size) footprint/consumption. > > [2] Remove flow

Re: [dpdk-dev] Broadcom roadmap for DPDK 20.05

2020-03-29 Thread Thomas Monjalon
Inserted into the roadmap on the web: http://git.dpdk.org/tools/dpdk-web/commit/?id=56408ab93 16/03/2020 03:24, Ajit Khaparde: > Sorry for the delay, the following is Broadcom's roadmap for DPDK 20.05: > * Adding support for host-memory based flow tables management for high > scalability

Re: [dpdk-dev] Marvell DPDK 20.05 Roadmap

2020-03-29 Thread Thomas Monjalon
Converted into roadmap summary for the web: http://git.dpdk.org/tools/dpdk-web/commit/?id=dc44d51cc I think it is reasonnable to announce IF proxy for 20.08, given the discussion on the mailing list and in techboard meeting. 27/02/2020 08:49, Jerin Jacob Kollanukkaran: > General: > -

Re: [dpdk-dev] [PATCH v3 0/3] Add RCU reclamation APIs

2020-03-29 Thread Thomas Monjalon
01/10/2019 08:29, Honnappa Nagarahalli: > This is not a new patch. This patch set is separated from the LPM > changes as the size of the changes in RCU library has grown due > to comments from community. These APIs will help reduce the changes > in LPM and hash libraries that are getting integrated

[dpdk-dev] [PATCH v1 13/13] doc: add feature matrix table for bbdev devices

2020-03-29 Thread Nicolas Chautru
Adding missing overview page in documentation with comparison of feature set by each available PMD implementation. Signed-off-by: Nicolas Chautru --- .gitignore | 1 + doc/guides/bbdevs/features/default.ini | 16 doc/guides/bbdevs/feature

[dpdk-dev] [PATCH v1 12/13] baseband/fpga_5gnr_fec: add interrupt support

2020-03-29 Thread Nicolas Chautru
Adding support for interrupt capability in the PMD and the related operations. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 156 + 1 file changed, 156 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/

[dpdk-dev] [PATCH v1 10/13] baseband/fpga_5gnr_fec: add configure function

2020-03-29 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 57 ++ doc/guides/bbdevs/fpga_5gnr_fec.rst| 123 +++

[dpdk-dev] [PATCH v1 09/13] baseband/fpga_5gnr_fec: add debug functionality

2020-03-29 Thread Nicolas Chautru
Adding functionality for debug mode to be more verbose and catch error from unsupported configuration. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 364 + 1 file changed, 364 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec

[dpdk-dev] [PATCH v1 07/13] baseband/fpga_5gnr_fec: add LDPC processing functions

2020-03-29 Thread Nicolas Chautru
Adding LDPC processing operations and related documentation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/fpga_5gnr_fec.rst| 28 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 660 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h | 9 +

[dpdk-dev] [PATCH v1 05/13] baseband/fpga_5gnr_fec: add device info_get function

2020-03-29 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru --- app/test-bbdev/Makefile| 3 ++ app/test-bbdev/meson.build

[dpdk-dev] [PATCH v1 06/13] baseband/fpga_5gnr_fec: add queue configuration

2020-03-29 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 441 - drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h | 35 ++ 2 files changed, 475 insertions(+),

[dpdk-dev] [PATCH v1 11/13] baseband/fpga_5gnr_fec: add harq loopback capability

2020-03-29 Thread Nicolas Chautru
Adding optional capability to support loopback preloading and check of the extern HARQ memory. This function is required to run the HARQ bit exact test successfully. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 171 + 1 file changed,

[dpdk-dev] [PATCH v1 08/13] baseband/fpga_5gnr_fec: add HW error capture

2020-03-29 Thread Nicolas Chautru
Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c index e330a6d..64d32e4 100644

[dpdk-dev] [PATCH v1 00/13] drivers/baseband: PMD for FPGA 5GNR FEC

2020-03-29 Thread Nicolas Chautru
Adding new baseband PMD for FPGA 5GNR FEC implementation. This used to be part of that serie https://patches.dpdk.org/project/dpdk/list/?series=9050 but now splitting here as suggested. The differental incremental patches are split based on logical functionality. Note the the first 2 commits a

[dpdk-dev] [PATCH v1 01/13] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-29 Thread Nicolas Chautru
From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2 ++ lib/librte_bbdev/rte_bbdev_op.h | 12 ++-- 2 files changed,

[dpdk-dev] [PATCH v1 04/13] baseband/fpga_5gnr_fec: add register definition file

2020-03-29 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h | 189 + 1 file changed, 189 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h b/d

[dpdk-dev] [PATCH v1 02/13] bbdev: expose device HARQ buffer size at device level

2020-03-29 Thread Nicolas Chautru
From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +- lib/l

[dpdk-dev] [PATCH v1 03/13] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-29 Thread Nicolas Chautru
Add stubs for the FPGA 5GNR FEC PMD Signed-off-by: Nicolas Chautru --- config/common_base | 5 + doc/guides/bbdevs/fpga_5gnr_fec.rst| 146 doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_2

Re: [dpdk-dev] [PATCH v4 0/4] net/mlx5: move to non-cached mode for flow rules

2020-03-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Tuesday, March 24, 2020 5:34 PM > To: Ori Kam ; Raslan Darawsheh > ; Matan Azrad > Cc: Slava Ovsiienko ; dev@dpdk.org > Subject: [PATCH v4 0/4] net/mlx5: move to non-cached mode for flow rules > > This patch set will remove the flow rul

[dpdk-dev] [Bug 430] i40e has wrong byte order in rte_flow_item_eth (ethdev)

2020-03-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=430 Bug ID: 430 Summary: i40e has wrong byte order in rte_flow_item_eth (ethdev) Product: DPDK Version: 20.02 Hardware: All OS: All Status: UNCONFIRMED

[dpdk-dev] [PATCH v3 29/33] ethdev: add tracepoints

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + app/pdump/Makefile| 1 + app/pdump/meson.build | 1 + app/

[dpdk-dev] [PATCH v3 32/33] mempool: add tracepoints

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS| 2 + drivers/common/cpt/Makefile| 1 + drivers/mempool/ring/Makefile | 1 + drivers/me

[dpdk-dev] [PATCH v3 33/33] doc: add trace library guide

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Add programmar's guide for trace library support. Signed-off-by: Sunil Kumar Kori Signed-off-by: Jerin Jacob --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/trace_lib.rst| 265 + doc/guides/rel_notes/release_20_05.rs

[dpdk-dev] [PATCH v3 26/33] eal/trace: add trace mode configuration parameter

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-mode eal parameter to configure event record mode when ring buffers are full. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 12 ++ lib/librte_eal/common/eal_common_options.c| 17 .../com

[dpdk-dev] [PATCH v3 31/33] cryptodev: add tracepoints

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/crypto/ccp/Makefile | 1 + drivers/crypto/ccp/meson.build| 2 + d

[dpdk-dev] [PATCH v3 30/33] eventdev: add tracepoints

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/event/skeleton/Makefile | 1 + drivers/event/skeleton/meson.build| 1 + l

[dpdk-dev] [PATCH v3 27/33] eal/trace: add unit test cases

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Example commands to run UT and check the traces with babeltrace viewer. - Delete the existing /root/dpdk-traces/ directory if needed. > sudo rm -rf /root/dpdk-traces/ - Start the dpdk-test > sudo ./build/app/test/dpdk-test -c 0x3 - --trace-level=8 - Run trace_autotest >

[dpdk-dev] [PATCH v3 28/33] eal/trace: add trace performance test cases

2020-03-29 Thread jerinj
From: Jerin Jacob This test case shall be used to measure the trace overhead. Example command to run the performance test case. echo "trace_perf" | ./build/app/test/dpdk-test -c 0x3 --trace-level=8 Signed-off-by: Jerin Jacob --- app/test/Makefile | 1 + app/test/meson.build

[dpdk-dev] [PATCH v3 25/33] eal/trace: add trace bufsize configuration parameter

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-bufsz EAL parameter to configure maximum size of ring buffer where events are to be stored. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 13 lib/librte_eal/common/eal_common_options.c| 17 +

[dpdk-dev] [PATCH v3 22/33] eal/trace: add interrupt tracepoints

2020-03-29 Thread jerinj
From: Jerin Jacob Add the following interrupt related tracepoints. rte_trace_lib_eal_intr_callback_register; rte_trace_lib_eal_intr_callback_unregister; rte_trace_lib_eal_intr_enable; rte_trace_lib_eal_intr_disable; Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v3 23/33] eal/trace: add trace level configuration parameter

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-level EAL parameter to configure global and trace point specific level. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 19 lib/librte_eal/common/eal_common_options.c| 19 +++- lib/librte_eal/co

[dpdk-dev] [PATCH v3 24/33] eal/trace: add trace dir configuration parameter

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-dir EAL parameter to configure directory where traces will be generated. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 11 lib/librte_eal/common/eal_common_options.c| 15 ++ .../common/eal_c

[dpdk-dev] [PATCH v3 19/33] eal/trace: add memory tracepoints

2020-03-29 Thread jerinj
From: Jerin Jacob Add the following memory-related tracepoints. rte_trace_lib_eal_mem_zmalloc; rte_trace_lib_eal_mem_malloc; rte_trace_lib_eal_mem_realloc; rte_trace_lib_eal_mem_free; rte_malloc() and rte_free() has been used in the trace implementation, in order to avoid tracing implementation

[dpdk-dev] [PATCH v3 21/33] eal/trace: add thread tracepoints

2020-03-29 Thread jerinj
From: Jerin Jacob Add the following thread related tracepoints. rte_trace_lib_eal_thread_remote_launch; rte_trace_lib_eal_thread_lcore_ready; Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 14 +++

[dpdk-dev] [PATCH v3 18/33] eal/trace: add alarm tracepoints

2020-03-29 Thread jerinj
From: Jerin Jacob Add following alarm related trace points. rte_trace_lib_eal_alarm_set() rte_trace_lib_eal_alarm_cancel() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 18 ++ lib/

[dpdk-dev] [PATCH v3 20/33] eal/trace: add memzone tracepoints

2020-03-29 Thread jerinj
From: Jerin Jacob Add the following memzone related tracepoints. rte_trace_lib_eal_memzone_reserve rte_trace_lib_eal_memzone_lookup rte_trace_lib_eal_memzone_free Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_memzone.c| 9 +++ .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v3 16/33] eal/trace: hook internal trace APIs to FreeBSD

2020-03-29 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to FreeBSD EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/freebsd/eal/eal.c| 10 ++ lib/librte_eal/freebsd/eal/eal_thread.c | 3 +++ 2 files changed, 13 insertions(+) diff --git a/lib/librte_eal/freebsd/eal/eal.c

[dpdk-dev] [PATCH v3 17/33] eal/trace: add generic tracepoints

2020-03-29 Thread jerinj
From: Jerin Jacob This patch creates the following generic tracepoint for generic tracing when there is no dedicated tracepoint is available. rte_trace_lib_eal_generic_void() rte_trace_lib_eal_generic_u64() rte_trace_lib_eal_generic_u32() rte_trace_lib_eal_generic_u16() rte_trace_lib_eal_generic

[dpdk-dev] [PATCH v3 11/33] eal/trace: implement debug dump function

2020-03-29 Thread jerinj
From: Jerin Jacob Implement rte_trace_metadata_dump() and rte_trace_dump() functions. Former one used to dump the CTF metadata file and the latter one to dump all the registered events and its status. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v3 15/33] eal/trace: hook internal trace APIs to Linux

2020-03-29 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to Linux EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/linux/eal/eal.c| 9 + lib/librte_eal/linux/eal/eal_thread.c | 3 +++ 3 files changed, 14 insertions(

[dpdk-dev] [PATCH v3 12/33] eal/trace: implement trace save

2020-03-29 Thread jerinj
From: Jerin Jacob Implement rte_trace_save(), which will save the metadata file and trace memory snapshot to the trace directory. Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_utils.c | 80 +++ lib/librte_eal/rte_eal_version.map| 1 + 2 files

[dpdk-dev] [PATCH v3 14/33] eal/trace: implement provider payload

2020-03-29 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace mem emitters aka provider payload. When it used as provider payload, those function copy the trace field to tr

[dpdk-dev] [PATCH v3 13/33] eal/trace: implement registration payload

2020-03-29 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace memory emitters. When it used as registration payload, it will do the following to fulfill the registration jo

[dpdk-dev] [PATCH v3 10/33] eal/trace: implement trace memory allocation

2020-03-29 Thread jerinj
From: Jerin Jacob Trace memory will be allocated per thread to enable lockless trace events updates to the memory. The allocator will first attempt to allocate from hugepage, if not available from hugepage then fallback to malloc memory. Later in the patches series, This API will be hooked to DP

[dpdk-dev] [PATCH v3 09/33] eal/trace: handle CTF keyword collision

2020-03-29 Thread jerinj
From: Sunil Kumar Kori Some of the keyword like align, event, "." and "->" etc will be used in CTF metadata syntax. This patch support for handling those keywords with DPDK events name. Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++

[dpdk-dev] [PATCH v3 08/33] eal/trace: create CTF TDSL metadata in memory

2020-03-29 Thread jerinj
From: Jerin Jacob Common trace format(CTF) defines the metadata[1][2] for trace events, This patch creates the metadata for the DPDK events in memory and latter this will be saved to trace directory on rte_trace_save() invocation. [1] https://diamon.org/ctf/#specification [2] https://diamon.org/

[dpdk-dev] [PATCH v3 07/33] eal/trace: get bootup timestamp for trace

2020-03-29 Thread jerinj
From: Jerin Jacob Find epoch_sec, epoch_nsec and uptime_ticks time information on eal_trace_init()/bootup to derive the time in the trace. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 3 +++ .../common/eal_common_trace_utils.c | 22 +

[dpdk-dev] [PATCH v3 06/33] eal/trace: add internal trace init and fini interface

2020-03-29 Thread jerinj
From: Jerin Jacob Define eal_trace_init() and eal_trace_fini() EAL interface functions that rte_eal_init() and rte_eal_cleanup() function can be use to initialize and finalize the trace subsystem. eal_trace_init() function will add the following functionality if trace is enabled through EAL comma

[dpdk-dev] [PATCH v3 03/33] eal: define the public API for trace support

2020-03-29 Thread jerinj
From: Jerin Jacob Define the public API for trace support. This patch also adds support for the build infrastructure and update the MAINTAINERS file for the trace subsystem. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 6 + confi

[dpdk-dev] [PATCH v3 05/33] eal/trace: implement trace operation APIs

2020-03-29 Thread jerinj
From: Jerin Jacob This patch implements the following public trace APIs. - rte_trace_global_is_enabled() - rte_trace_global_is_disabled() - rte_trace_is_id_invalid() - rte_trace_global_level_set() - rte_trace_global_level_get() - rte_trace_global_mode_set() - rte_trace_global_mode_get() - rte_tr

[dpdk-dev] [PATCH v7 5/5] net/virtio: Support of VIRTIO_NET_F_SPEED_DUPLEX

2020-03-29 Thread Ivan Dyukov
This patch adds a support of VIRTIO_NET_F_SPEED_DUPLEX feature for virtio driver. There are few ways to specify speed of the link: 'speed' devarg negotiate speed from qemu via VIRTIO_NET_F_SPEED_DUPLEX The highest priority is devarg. If devarg is not specified, drivers tries to negotiate it

[dpdk-dev] [PATCH v3 04/33] eal/trace: implement trace register API

2020-03-29 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS

[dpdk-dev] [PATCH v7 4/5] net/virtio-user: adding link speed devarg

2020-03-29 Thread Ivan Dyukov
virtio driver already parses speed devarg. virtio-user should add it to list of valid devargs and call eth_virtio_dev_init function which init speed value. eth_virtio_dev_init already is called from virtio_user_pmd_probe function. The only change is required to enable speed devargs: adding speed t

[dpdk-dev] [PATCH v7 3/5] net/virtio-user: fix devargs parsing

2020-03-29 Thread Ivan Dyukov
strtoull returns 0 if it fails to parse input string. It's ignored in get_integer_arg. This patch handles error cases for strtoull function. Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_user_ethdev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v3 02/33] eal: introduce API for getting thread name

2020-03-29 Thread jerinj
From: Jerin Jacob Introduce rte_thread_getname() API to get the thread name and implement it for Linux and FreeBSD. FreeBSD does not support getting the thread name. One of the consumers of this API will be the trace subsystem where it used as an informative purpose. Signed-off-by: Jerin Jacob

[dpdk-dev] [PATCH v3 01/33] meson: add libatomic as a global dependency for i686 clang

2020-03-29 Thread jerinj
From: Pavan Nikhilesh Add libatomic as a global dependency when compiling for 32-bit using clang. As we need libatomic for 64-bit atomic ops. Cc: bruce.richard...@intel.com Signed-off-by: Pavan Nikhilesh --- config/meson.build | 10 ++ drivers/event/octeontx/meson.buil

[dpdk-dev] [PATCH v7 2/5] net/virtio: add link speed devarg

2020-03-29 Thread Ivan Dyukov
Some applications like pktgen use link speed to calculate transmission rate. It limits outcome traffic to hardcoded 10G. This patch adds speed devarg which allows to configure link speed of virtio device. Signed-off-by: Ivan Dyukov --- doc/guides/nics/virtio.rst | 7 +++ drivers/net/vi

[dpdk-dev] [PATCH v7 1/5] net/virtio: refactor devargs parsing

2020-03-29 Thread Ivan Dyukov
refactor vdpa specific devargs parsing to more generic way Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 34 +- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev

[dpdk-dev] [PATCH v7 0/5] net/virtio: add link speed devarg

2020-03-29 Thread Ivan Dyukov
v7 chagnes: * rebased to latest master * added support of VIRTIO_NET_F_SPEED_DUPLEX v6 changes: * fix code style v5 changes: * fixed code style * fixed commit message and logging text v4 changes: * link_speed renamed to speed devarg * speed devarg is added to virtio-user driver v3 changes: * li

[dpdk-dev] [PATCH v3 00/33] DPDK Trace support

2020-03-29 Thread jerinj
From: Jerin Jacob v3: ~~ 1) Fix the following build issues reported by CI http://mails.dpdk.org/archives/test-report/2020-March/122060.html a) clang + i686 meson build issue(Fixed in the the patch meson: add libatomic as a global dependency for i686 clang) b) fixed build issue with FreeBSD wi

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix zero value validation for metadata

2020-03-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Wisam Monther > Sent: Thursday, March 26, 2020 12:22 PM > To: Ori Kam ; Matan Azrad ; > dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix zero value validation for metadata > > MARK and META item

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-29 Thread Ori Kam
Hi Xiao, > -Original Message- > From: Zhang, Xiao > Sent: Sunday, March 29, 2020 3:00 PM > To: Ori Kam ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Ori, > > > -Original Message- > > From:

  1   2   >