Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN actions in meter

2020-02-19 Thread Matan Azrad
From: Suanming Mou > Meter suffix subflow only has the port id and tag match item, if VLAN push > and set VLAN id actions exist in the suffix subflow, the user defined VLAN > items is required for the actions to set a correct VLAN id. > > Currently, the VLAN item stays in the meter prefix subfl

[dpdk-dev] [PATCH] net/mlx5: fix VLAN actions in meter

2020-02-19 Thread Suanming Mou
Meter suffix subflow only has the port id and tag match item, if VLAN push and set VLAN id actions exist in the suffix subflow, the user defined VLAN items is required for the actions to set a correct VLAN id. Currently, the VLAN item stays in the meter prefix subflow. Without the VLAN item, VLAN

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix lack of match information in meter

2020-02-19 Thread Matan Azrad
From: Suanming Mou > As meter flows are split into three subflows each, the prefix subflow with > meter action color the packet, the meter subflow filters out the colored > packets, the suffix subflow applies all the remaining actions to the passed > packets. > > Currently, all the user defined

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix layer flags missing in metadata

2020-02-19 Thread Matan Azrad
From: Suanming Mou > Metadata suffix subflow inherits the RSS needed hash_fields from the prefix > subflow as the suffix subflow only has the tag match item unable to generate > the full original hash_fields for RSS action. > > Unfortunately, hash_fields will only be generated if flow has RSS a

Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes

2020-02-19 Thread Ajit Khaparde
On Wed, Feb 19, 2020 at 7:55 PM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > These are couple of bnxt PMD bug fixes. Please apply. > Patches applied to dpdk-next-net-brcm. > > Kalesh AP (2): > net/bnxt: fix segmentation fault handling async events on port sto

Re: [dpdk-dev] [PATCH] net/ice: fix queue bind MSI-X interrupt error

2020-02-19 Thread Ye Xiaolong
On 02/19, taox@intel.com wrote: >From: Zhu Tao > >To bind a queue to an MSI-X interrupt, need to set some register. >The register consists of many parts, each of which has several >bits; therefore, the shift operator '<<' was used; so the operator >'<' in the code should be '<<'. > >Old code a

[dpdk-dev] [Bug 401] unit_tests: mempool_autotest failed with shared mode library

2020-02-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=401 Bug ID: 401 Summary: unit_tests: mempool_autotest failed with shared mode library Product: DPDK Version: 20.02 Hardware: All OS: All Status: UNCONFIRMED

[dpdk-dev] ethdev: add PFCP header to flow API

2020-02-19 Thread Xiao Zhang
This patch adds the new flow item RTE_FLOW_ITEM_TYPE_PFCP to flow API to match a PFCP header. Add sample PFCP rules for testpmd guide. Since Session Endpoint Identifier (SEID) only will be present in PFCP Session header and PFCP Session headers shall be identified when the S field is equal to 1, wh

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix layer flags missing in metadata

2020-02-19 Thread Suanming Mou
Metadata suffix subflow inherits the RSS needed hash_fields from the prefix subflow as the suffix subflow only has the tag match item unable to generate the full original hash_fields for RSS action. Unfortunately, hash_fields will only be generated if flow has RSS action. So it means the prefix fl

[dpdk-dev] [PATCH v2 0/2] net/mlx5: copy the item flags from prefix flow

2020-02-19 Thread Suanming Mou
For flow split to several subflows, the match items maybe in the prefix flow, and the actions are split to the suffix flow. In this case, for the actions need the user defined match item will not create correctly. Copy the item layers flags to the suffix flow from prefix flow to fix the issue. T

[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix lack of match information in meter

2020-02-19 Thread Suanming Mou
As meter flows are split into three subflows each, the prefix subflow with meter action color the packet, the meter subflow filters out the colored packets, the suffix subflow applies all the remaining actions to the passed packets. Currently, all the user defined items are matched in the prefix f

[dpdk-dev] [PATCH 0/2] bnxt bug fixes

2020-02-19 Thread Kalesh A P
From: Kalesh AP These are couple of bnxt PMD bug fixes. Please apply. Kalesh AP (2): net/bnxt: fix segmentation fault handling async events on port stop net/bnxt: fix race when port is stopped and async events are received drivers/net/bnxt/bnxt_cpr.c | 6 ++ drivers/net/bnxt/bnxt_hwr

[dpdk-dev] [PATCH 2/2] net/bnxt: fix race when port is stopped and async events are received

2020-02-19 Thread Kalesh A P
From: Kalesh AP Fix a race condition between port stop and error recovery task. When io forwarding is not started on Stingray devices, driver will not receive the async event from FW when there is a FW reset. While exiting testpmd, as part of port stop driver sees this event and this in turn caus

[dpdk-dev] [PATCH 1/2] net/bnxt: fix segmentation fault handling async events on port stop

2020-02-19 Thread Kalesh A P
From: Kalesh AP Check for bp->hwrm_cmd_resp_addr before using it in HWRM_PREP to avoid segmentation fault when stop port and meanwhile receive events from FW. Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Aji

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix lack of match information in meter

2020-02-19 Thread Suanming Mou
> -Original Message- > From: Matan Azrad > Sent: Wednesday, February 19, 2020 11:31 PM > To: Suanming Mou ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: RE: [PATCH 2/2] net/mlx5: fix lack of match information in meter > > > Hi Mou > > One com

Re: [dpdk-dev] [PATCH] examples/vhost_blk: use common macros for min/max

2020-02-19 Thread Tiwei Bie
On Wed, Feb 19, 2020 at 11:39:22AM +0100, Thomas Monjalon wrote: > The macros RTE_MIN and RTE_MAX can be used in DPDK applications. > > This change implies fixing the sign of used_len as size_t > as defined in vhost_strcpy_pad(). > > Signed-off-by: Thomas Monjalon > --- > examples/vhost_blk/blk

Re: [dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-19 Thread dwilder
On 2020-02-19 11:41, David Marchand wrote: Let's prune the jobs list to limit the amount of time spent by the robot in Travis. Since meson enables automatically the relevant components, there is not much gain in testing with extra_packages vs required_packages only. For a given arch/compiler/e

Re: [dpdk-dev] [PATCH v4 2/2] doc/ring: correct multi producer enqueue figure

2020-02-19 Thread Honnappa Nagarahalli
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, February 19, 2020 3:06 PM > To: olivier.m...@6wind.com; pratee...@cse.iitb.ac.in; ferruh.yi...@intel.com; > tho...@monjalon.net > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; sta...@dpdk.org > Subject: [PATCH v4 2/2

Re: [dpdk-dev] [PATCH v4 1/2] doc/rcu: correct quiescent state description

2020-02-19 Thread Honnappa Nagarahalli
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, February 19, 2020 3:05 PM > To: olivier.m...@6wind.com; pratee...@cse.iitb.ac.in; ferruh.yi...@intel.com; > tho...@monjalon.net > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; sta...@dpdk.org > Subject: [PATCH v4 1/2

Re: [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

2020-02-19 Thread Itsuro ODA
Hi Maxime, Tiewi, On Wed, 19 Feb 2020 09:17:41 +0100 Maxime Coquelin wrote: > Hi Tiwei, > > On 2/19/20 4:44 AM, Tiwei Bie wrote: > > On Tue, Feb 18, 2020 at 06:22:40PM +0100, Maxime Coquelin wrote: > >> Ethdev's .dev_configure callback can be called multiple > >> time during a device life-time,

Re: [dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-19 Thread Aaron Conole
David Marchand writes: > Let's prune the jobs list to limit the amount of time spent by the robot > in Travis. > > Since meson enables automatically the relevant components, there is not > much gain in testing with extra_packages vs required_packages only. > > For a given arch/compiler/env combin

Re: [dpdk-dev] [EXT] RE: [PATCH 2/2] examples/ip_pipeline: fix to use sock id instead of cpuid

2020-02-19 Thread Jun Yang
Hi Cristian, If my recall is correct, the issue comes from following commands: ip_pipleline running on DPAA1: #NOTE: rss ip_pipeline is not supported due to the limitation of DPAA1 driver. 1) mkdir -p /mnt/hugepages 2) mount -t hugetlbfs none /mnt/hugepages 3) export DPAA_FMCLESS_MODE=1 4) #fire

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-19 Thread Kinsella, Ray
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday 18 February 2020 09:50 > To: Richardson, Bruce > Cc: Kinsella, Ray ; nhor...@tuxdriver.com; > bl...@debian.org; david.march...@redhat.com; ktray...@redhat.com; > dev@dpdk.org > Subject: Re: ABI version of experimental librari

[dpdk-dev] [PATCH 1/2] build: add combined libs

2020-02-19 Thread Ruslan Babayev
Add combined libdpdk.a and libdpdk.so libs for Meson similar to how it's done for Make builds Signed-off-by: Ruslan Babayev --- buildtools/group-libs.sh | 2 ++ buildtools/meson.build | 1 + meson.build | 17 + 3 files changed, 20 insertions(+) create mode 10075

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-19 Thread Neil Horman
On Wed, Feb 19, 2020 at 01:43:01PM +0100, Thomas Monjalon wrote: > 19/02/2020 12:43, Neil Horman: > > On Tue, Feb 18, 2020 at 10:50:09AM +0100, Thomas Monjalon wrote: > > > 18/02/2020 10:42, Bruce Richardson: > > > > On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote: > > > > > Hi, > >

[dpdk-dev] [PATCH v4 2/2] doc/ring: correct multi producer enqueue figure

2020-02-19 Thread Honnappa Nagarahalli
The producer head pointer in multi producer enqueue fig.6.10 points to incorrect object in the ring array. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: sta...@dpdk.org Signed-off-by: Prateek Agarwal Signed-off-by: Honnappa Nagarahalli --- .../prog_guide/img/ring-mp-enqueue3.svg | 1

[dpdk-dev] [PATCH v4 1/2] doc/rcu: correct quiescent state description

2020-02-19 Thread Honnappa Nagarahalli
The quiescent state description refers to an incorrect thread. Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Cc: sta...@dpdk.org Signed-off-by: Prateek Agarwal Signed-off-by: Honnappa Nagarahalli --- V4 1) Seperated the commits for ring and RCU changes 2) Changed the co

Re: [dpdk-dev] [PATCH v2 3/3] ci: add travis ci support for native ppc64le

2020-02-19 Thread dwilder
On 2020-02-19 05:46, David Marchand wrote: On Wed, Feb 19, 2020 at 2:10 AM David Wilder wrote: This change follows the example of aarch64 Travis support by adding support for ppc64le gcc builds. Limitations for ppc64le are the same as aarch64 as described in commit 31bb45bcfd. checkpatch di

[dpdk-dev] [PATCH 2/4] ci: fix Travis config warnings

2020-02-19 Thread David Marchand
Reading https://config.travis-ci.com/ and using https://config.travis-ci.com/explore to check changes, we can cleanup some warnings reported by the config validation options in Travis. Signed-off-by: David Marchand --- .travis.yml | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-

[dpdk-dev] [PATCH 3/4] ci: use an explicit list of Travis jobs

2020-02-19 Thread David Marchand
Maintaining the .travis.yml requires some knowledge of how Travis computes the jobs list (combination of os: arch: compiler: etc...). Let's switch to an explicit list to find all jobs at a glance. To enhance readability, jobs have been sorted per arch/compiler with comments to isolate blocks. Set

[dpdk-dev] [PATCH 1/4] ci: remove unnecessary dependency on Linux headers

2020-02-19 Thread David Marchand
Following removal of kmod compilation, we don't need to install linux-headers anymore. Fixes: ea860973592b ("ci: remove redundant configs disabling kmods") Signed-off-by: David Marchand --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml

[dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-19 Thread David Marchand
Let's prune the jobs list to limit the amount of time spent by the robot in Travis. Since meson enables automatically the relevant components, there is not much gain in testing with extra_packages vs required_packages only. For a given arch/compiler/env combination, compilation is first tested in

[dpdk-dev] [PATCH 0/4] Reorganise Travis jobs

2020-02-19 Thread David Marchand
This series tries to make the travis configuration a bit easier to read, then drops jobs that are not essential or functional duplicates in the hope we can give some oxygen to the robot who seems to lag quite a bit and can't catch up. -- David Marchand David Marchand (4): ci: remove unnecessar

[dpdk-dev] [PATCH] build: add combined libs

2020-02-19 Thread Ruslan Babayev
Add combined libdpdk.a and libdpdk.so libs for Meson similar to how it's done for Make builds Signed-off-by: Ruslan Babayev --- buildtools/group-libs.sh | 2 ++ buildtools/meson.build | 1 + meson.build | 17 + 3 files changed, 20 insertions(+) create mode 10075

[dpdk-dev] [PATCH v2 7/7] vfio/pci: Cleanup .probe() exit paths

2020-02-19 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 497ecadef2ba..7d41

[dpdk-dev] [PATCH v2 5/7] vfio/pci: Add sriov_configure support

2020-02-19 Thread Alex Williamson
With the VF Token interface we can now expect that a vfio userspace driver must be in collaboration with the PF driver, an unwitting userspace driver will not be able to get past the GET_DEVICE_FD step in accessing the device. We can now move on to actually allowing SR-IOV to be enabled by vfio-pc

[dpdk-dev] [PATCH v2 6/7] vfio/pci: Remove dev_fmt definition

2020-02-19 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/

[dpdk-dev] [PATCH v2 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-19 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20 include/linux/vfio.h |4 2 files changed, 20 insertions(+), 4 deletions(-) dif

[dpdk-dev] [PATCH v2 2/7] vfio/pci: Implement match ops

2020-02-19 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci/vfio_

[dpdk-dev] [PATCH v2 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-19 Thread Alex Williamson
The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device agnostic ioctl for setting, retrieving, and probing device features. This implementation provides a 16-bit field for specifying a feature index, where the data porition of the ioctl is determined by the semantics for the given f

[dpdk-dev] [PATCH v2 3/7] vfio/pci: Introduce VF token

2020-02-19 Thread Alex Williamson
If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not fully isolated from the PF. The PF can always cause a denial of service to the VF, even if by simply resetting itself. The degree to which a PF can access the data passed through a VF or interfere with its operation is dependen

[dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-02-19 Thread Alex Williamson
Changes since v1 are primarily to patch 3/7 where the commit log is rewritten, along with option parsing and failure logging based on upstream discussions. The primary user visible difference is that option parsing is now much more strict. If a vf_token option is provided that cannot be used, we

Re: [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build

2020-02-19 Thread Ferruh Yigit
On 2/19/2020 2:31 PM, Wang, Xiao W wrote: > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, February 19, 2020 10:17 PM >> To: Zhang, Qi Z ; Wang, Xiao W >> ; Chen Jing D(Mark) >> Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org >> Subject: [PATCH] net/fm10k: fix non-x8

Re: [dpdk-dev] [PATCH] net/sfc: fix log format specifiers

2020-02-19 Thread Ferruh Yigit
On 2/19/2020 2:11 PM, Andrew Rybchenko wrote: > On 2/19/20 5:04 PM, Ferruh Yigit wrote: >> The format specifier for the 'size_t' format should be '%z'. >> >> Also this fix enables compiling PMD for 32bit architecture. >> >> Fixes: ba641f207642 ("net/sfc: add init on attach") >> Fixes: 82faef507608

[dpdk-dev] DPDK techboard minutes of February 12

2020-02-19 Thread Thomas Monjalon
Minutes of Technical Board meeting, 2020-02-12 Members Attending: 9/11 - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Thomas Monjalon (Chair) NOTE: Technical Board meetings happen every sec

[dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach

2020-02-19 Thread Wisam Jaddo
Identifier for new port may contain white list options, and white list options will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide better and more options Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Cc: muk...@igel.co.jp Cc: sta.

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Kamaraj P
Hi Anatoly, Yes we are facing an issue with our custom applications. Earlier we have tried with l2fwd DPDK application and does not see any issue with memory initialization. Not sure whether we missed any other options. BTW when we tried with l2fwd application, the application does not seem to ha

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Burakov, Anatoly
On 19-Feb-20 3:42 PM, Kamaraj P wrote: Hi Anatoly, Thanks for the suggestions. Yeah we have just changed in our application to invoke mlockall() before rte_eal_init(). Looks like it does not help either.      if (mlockall(MCL_CURRENT | MCL_FUTURE)) {          printf("Failed mlockall !!

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Kamaraj P
Hi Anatoly, Thanks for the suggestions. Yeah we have just changed in our application to invoke mlockall() before rte_eal_init(). Looks like it does not help either. if (mlockall(MCL_CURRENT | MCL_FUTURE)) { printf("Failed mlockall !! **\n"); } ret = rte_eal_init(argc, ar

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix header modifiy choose wrong layer type

2020-02-19 Thread Matan Azrad
From: Suanming Mou > Currently, for header modify actions after tunnel decapsulation, the header > modify actions will still select the old outermost layer type. > It will cause header modify actions get the wrong layer type. > > Add the tunnel decap flag to indicate the layer type to get for h

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix wrong layer validation with decapsulation

2020-02-19 Thread Matan Azrad
From: Suanming Mou > Currently, the flow validate function only validate the outermost layer with > the header modify actions. If there is decapsulation action before the header > modify action, the validation should choose the inner layer for validation. > > Add decapsulation check when valida

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix lack of match information in meter

2020-02-19 Thread Matan Azrad
Hi Mou One comment inline. From: Suanming Mou > As meter flows are split into three subflows each, the prefix subflow with > meter action color the packet, the meter subflow filters out the colored > packets, the suffix subflow applies all the remaining actions to the passed > packets. > > Cur

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-02-19 Thread Ye Xiaolong
On 02/19, Konieczny, TomaszX wrote: >>-Original Message- >>From: dev On Behalf Of Ye Xiaolong >>Sent: 19 February 2020 08:06 >>To: Sun, GuinanX >>Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming >>; Zhang, Qi Z ; sta...@dpdk.org >>Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mo

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Burakov, Anatoly
On 19-Feb-20 3:02 PM, Kamaraj P wrote: Thanks for the suggestions. We didnt have --mlockall parameter option in the rte_eal_init(). we have just tried the option and our application says an *unrecognized option*. Lets us check further on this and let you know. Thanks, Kamaraj No, that's not

Re: [dpdk-dev] [PATCH] ipsec: fix use of uninitialized variable

2020-02-19 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Iremonger, Bernard > Sent: Wednesday, February 19, 2020 2:15 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH] ipsec: fix use of uninitialized variable > > > -Or

[dpdk-dev] [PATCH] net/mlx5: fix match on Ethertype

2020-02-19 Thread Dekel Peled
HW supports match on one Ethertype, the Ethertype following the last VLAN tag of the packet (see PRM). Previous patch added specific handling for packets with VLAN tag, after setting match on Ethertype. This patch moves the handling of packets with VLAN tag, to be done before and instead of settin

Re: [dpdk-dev] [PATCH] net/mlx5: fix L3 vxlan RSS expansion

2020-02-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, February 19, 2020 10:30 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix L3 vxlan RSS expansion > > The RSS expansion feature was introduced to split

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Kamaraj P
Thanks for the suggestions. We didnt have --mlockall parameter option in the rte_eal_init(). we have just tried the option and our application says an *unrecognized option*. Lets us check further on this and let you know. Thanks, Kamaraj On Wed, Feb 19, 2020 at 7:53 PM Burakov, Anatoly wrote: >

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix the hairpin queue capacity

2020-02-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, February 19, 2020 10:29 AM > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix the hairpin queue capacity > > The hairpin TX/RX queue dep

Re: [dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Ferruh Yigit
On 2/19/2020 2:02 PM, Iremonger, Bernard wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, February 19, 2020 12:40 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> ; Lipiec, Herakliusz >> ; Govindharajan, Hariprasad >> ; Burakov, Anatoly >> >> Cc

[dpdk-dev] [PATCH 1/2] net/mlx5: fix layer flags missing in metadata

2020-02-19 Thread Suanming Mou
Metadata suffix subflow inherits the RSS needed hash_fields from the prefix subflow as the suffix subflow only has the tag match item unable to generate the full original hash_fields for RSS action. Unfortunately, hash_fields will only be generated if flow has RSS action. So it means the prefix fl

[dpdk-dev] [PATCH 0/2] net/mlx5: copy the item flags from prefix flow

2020-02-19 Thread Suanming Mou
For flow split to several subflows, the match items maybe in the prefix flow, and the actions are split to the suffix flow. In this case, for the actions need the user defined match item will not create correctly. Copy the item layers flags to the suffix flow from prefix flow to fix the issue. T

Re: [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build

2020-02-19 Thread Wang, Xiao W
Acked-by: Xiao Wang Thanks, Xiao > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, February 19, 2020 10:17 PM > To: Zhang, Qi Z ; Wang, Xiao W > ; Chen Jing D(Mark) > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > Subject: [PATCH] net/fm10k: fix non-x86 build > > 'fm1

[dpdk-dev] [PATCH 2/2] net/mlx5: fix lack of match information in meter

2020-02-19 Thread Suanming Mou
As meter flows are split into three subflows each, the prefix subflow with meter action color the packet, the meter subflow filters out the colored packets, the suffix subflow applies all the remaining actions to the passed packets. Currently, all the user defined items are matched in the prefix f

[dpdk-dev] [PATCH] net/mlx5: fix the modify checking in flow validate

2020-02-19 Thread Bing Zhao
The header modify actions number supported now has some limitation, and it is decided by both driver and hardware. If the configuration is different or the table to insert the flow is different, the result might be different if the flow contains header modify actions. Currently, the actual action n

[dpdk-dev] [PATCH 1/2] net/mlx5: fix wrong layer validation with decapsulation

2020-02-19 Thread Suanming Mou
Currently, the flow validate function only validate the outermost layer with the header modify actions. If there is decapsulation action before the header modify action, the validation should choose the inner layer for validation. Add decapsulation check when validate with the header modify action

[dpdk-dev] [PATCH 0/2] net/mlx5: fix incorrect layer choose with decap

2020-02-19 Thread Suanming Mou
For header modify actions after decapsulation action, the header modify actions should be applied to the inner layers. Currently, it always treats the outermost layers as the corresponding layer even though with decapsulation action. Add the layer validation with decapsulation for the header modi

[dpdk-dev] [PATCH 2/2] net/mlx5: fix header modifiy choose wrong layer type

2020-02-19 Thread Suanming Mou
Currently, for header modify actions after tunnel decapsulation, the header modify actions will still select the old outermost layer type. It will cause header modify actions get the wrong layer type. Add the tunnel decap flag to indicate the layer type to get for header modify actions. Fixes: 4b

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Burakov, Anatoly
On 19-Feb-20 11:16 AM, Kamaraj P wrote: Hi Kevin/Anatoly, Yes we have the patch already included in our code base. Looks like it get struck in the below piece of the code: mapped_addr = mmap(requested_addr, (size_t)map_sz, PROT_READ,                                 mmap_flags, -1, 0); Could y

[dpdk-dev] [PATCH] net/fm10k: fix non-x86 build

2020-02-19 Thread Ferruh Yigit
'fm10k_rxtx_vec.c' is SSE vector instructions implementation and should be compiled only for x86. The vector PMD support controlled by 'CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR' config option, but it is enabled by default, safer to add x86 checks too. Fixes: 10eb9ce8dccd ("fm10k: allow to disable vecto

[dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset

2020-02-19 Thread Suanming Mou
Currently, the set VLAN ID header modify action has already got the action pointer with offset from the header modify action array, but the configuration saves the detail to the memory of action with the offset again. It causes double offset to set the VLAN ID action to the wrong place in the heade

Re: [dpdk-dev] [PATCH] ipsec: fix use of uninitialized variable

2020-02-19 Thread Iremonger, Bernard
> -Original Message- > From: dev On Behalf Of Konstantin Ananyev > Sent: Wednesday, February 19, 2020 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin > > Subject: [dpdk-dev] [PATCH] ipsec: fix use of uninitialized variable > > Defects reported by coverity scan

Re: [dpdk-dev] [PATCH] net/sfc: fix log format specifiers

2020-02-19 Thread Andrew Rybchenko
On 2/19/20 5:04 PM, Ferruh Yigit wrote: > The format specifier for the 'size_t' format should be '%z'. > > Also this fix enables compiling PMD for 32bit architecture. > > Fixes: ba641f207642 ("net/sfc: add init on attach") > Fixes: 82faef507608 ("net/sfc: set RSS key and hash types config") > Fix

[dpdk-dev] [PATCH] net/sfc: fix log format specifiers

2020-02-19 Thread Ferruh Yigit
The format specifier for the 'size_t' format should be '%z'. Also this fix enables compiling PMD for 32bit architecture. Fixes: ba641f207642 ("net/sfc: add init on attach") Fixes: 82faef507608 ("net/sfc: set RSS key and hash types config") Fixes: 7803554a9e38 ("net/sfc: process RSS settings on Rx

Re: [dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Iremonger, Bernard
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, February 19, 2020 12:40 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Lipiec, Herakliusz > ; Govindharajan, Hariprasad > ; Burakov, Anatoly > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH] app/testpmd

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-19 Thread Ray Kinsella
On 19/02/2020 12:43, Thomas Monjalon wrote: > 19/02/2020 12:43, Neil Horman: >> On Tue, Feb 18, 2020 at 10:50:09AM +0100, Thomas Monjalon wrote: >>> 18/02/2020 10:42, Bruce Richardson: On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote: > Hi, > > I would like to rem

Re: [dpdk-dev] [PATCH v2 3/3] ci: add travis ci support for native ppc64le

2020-02-19 Thread David Marchand
On Wed, Feb 19, 2020 at 2:10 AM David Wilder wrote: > > This change follows the example of aarch64 Travis support > by adding support for ppc64le gcc builds. Limitations for > ppc64le are the same as aarch64 as described in commit > 31bb45bcfd. checkpatch did not catch it because of the \n (?).

Re: [dpdk-dev] [PATCH] net/mlx5: fix geneve tunnel flow validation

2020-02-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, February 19, 2020 8:52 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix geneve tunnel flow validation > > The new Mellanox devices support geneve tunn

Re: [dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Lipiec, Herakliusz
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, February 19, 2020 12:40 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Lipiec, Herakliusz > ; Govindharajan, Hariprasad > ; Burakov, Anatoly > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH] app/testpmd: g

Re: [dpdk-dev] [dpdk-announce] release candidate 20.02-rc3

2020-02-19 Thread Pei Zhang
Hi all, I would like to update our testing results with dpdk 20.02-rc3 from Red Hat. PASS: All below 15 scenarios work well. (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gues

Re: [dpdk-dev] [PATCH 1/2] net/memif: enable loopback

2020-02-19 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> -Original Message- > From: Július Milan > Sent: Wednesday, February 19, 2020 9:19 AM > To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) > > Subject: [dpdk-dev][PATCH 1/2] net/memif: enable loopback > > With this patch it is possible to connect 2 DPDK memifs i

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow match on GRE key

2020-02-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Tuesday, February 18, 2020 4:45 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow match on GRE key > > The RTE_FLOW_ITEM_TYPE_GRE_KEY means that GRE key shou

Re: [dpdk-dev] [PATCH 2/2] net/memif: fix init handling when already connected

2020-02-19 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> -Original Message- > From: Július Milan > Sent: Wednesday, February 19, 2020 9:19 AM > To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) > > Subject: [dpdk-dev][PATCH 2/2] net/memif: fix init handling when already > connected > > This patch fixes the situation

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-02-19 Thread Konieczny, TomaszX
>-Original Message- >From: dev On Behalf Of Ye Xiaolong >Sent: 19 February 2020 08:06 >To: Sun, GuinanX >Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming >; Zhang, Qi Z ; sta...@dpdk.org >Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting > >On 02/18, Guinan Sun wrote: >

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-19 Thread Thomas Monjalon
19/02/2020 12:43, Neil Horman: > On Tue, Feb 18, 2020 at 10:50:09AM +0100, Thomas Monjalon wrote: > > 18/02/2020 10:42, Bruce Richardson: > > > On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote: > > > > Hi, > > > > > > > > I would like to remind everybody our mistake when defining AB

[dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Ferruh Yigit
Coverity complains about out of bound access, which is a false positive. The return value of the 'parse_port_list()' can't be bigger than 'maxsize' because of the logic in the function. ('value >= (int)maxsize' check and 'marked[]' usage.) But this is not explicitly clear, causing coverity warnin

Re: [dpdk-dev] [PATCH] doc: add module EEPROM dump to mlx5 features

2020-02-19 Thread Ferruh Yigit
On 2/19/2020 10:11 AM, Thomas Monjalon wrote: > The dev_ops .get_module_info and .get_module_eeprom > were implemented in mlx5 in DPDK 19.11. > > Fixes: 8a6a09f853a0 ("net/mlx5: support reading module EEPROM data") > Cc: sta...@dpdk.org > > Reported-by: Gal Cohen > Signed-off-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH] net/ionic: fix ABI version

2020-02-19 Thread Ferruh Yigit
On 2/17/2020 4:13 PM, Ferruh Yigit wrote: > Changed the ABI version to 20.0.1. > > Fixes: a72cf98cc93e ("net/ionic: add skeleton") > > Reported-by: David Marchand > Signed-off-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc: update af_xdp documentation on MTU limitations

2020-02-19 Thread Ferruh Yigit
On 2/19/2020 12:57 AM, Ye Xiaolong wrote: > Nice doc about MTU of AF_XDP, thanks for the update. > > On 02/18, Ciara Loftus wrote: >> Explain how kernel driver RX buffer sizes affect the maximum >> MTU size in practice. >> >> Signed-off-by: Ciara Loftus >> --- >> doc/guides/nics/af_xdp.rst | 26 +

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix the hairpin queue capacity

2020-02-19 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Sent: Wednesday, February 19, 2020 10:29 AM > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix the hairpin queue capacity > > The hairpin TX/RX queue dept

Re: [dpdk-dev] Fwd: Fwd: high latency detected in IP pipeline example

2020-02-19 Thread Victor Huertas
Hi Oliver, Thanks for your answer. I think that the most appropriate maintainer to answer to this issue is Cristian as it is the maintainer of ip_pipeline. In order to tell you how to reproduce the problem, you should go back to the DPDK v17.11 and run the ip_pipeline app having a *.cfg configura

Re: [dpdk-dev] [PATCH] net/mlx5: fix ipv6 type icmp6 header rewrite actions

2020-02-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shiri Kuzin > Sent: Tuesday, February 18, 2020 1:53 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix ipv6 type icmp6 header rewrite actions > > ICMPv6 header contains the c

Re: [dpdk-dev] [PATCH] test/ipsec: fix a typo in function name

2020-02-19 Thread Ananyev, Konstantin
> > The name of the static function check_cryptodev_capablity() > is fixed for the word "capability". > There is no functional change. > > The same typo is fixed in a comment in ip_fragmentation example. > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-19 Thread Neil Horman
On Tue, Feb 18, 2020 at 10:50:09AM +0100, Thomas Monjalon wrote: > 18/02/2020 10:42, Bruce Richardson: > > On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote: > > > Hi, > > > > > > I would like to remind everybody our mistake when defining ABI versions. > > > It has been "fixed" in th

Re: [dpdk-dev] Proposal to add a new toolchain for dpdk: g++

2020-02-19 Thread Neil Horman
On Tue, Feb 18, 2020 at 03:06:51PM +0100, Victor Huertas wrote: > Thanks Neil for your answer, > I think I will try the first option you posted without touching the > makefiles from the dpdk-stable and I will tell how it goes. > So, as a conclusion, it seems that all the modifications I have done a

[dpdk-dev] [PATCH] test/ipsec: fix a typo in function name

2020-02-19 Thread Thomas Monjalon
The name of the static function check_cryptodev_capablity() is fixed for the word "capability". There is no functional change. The same typo is fixed in a comment in ip_fragmentation example. Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Cc: sta...@dpdk.org Signed-off-by: Thomas

Re: [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

2020-02-19 Thread Kevin Traynor
On 19/02/2020 10:18, Maxime Coquelin wrote: > Cc'ing stable as the commit it fixes was backported to v19.11 stable > branch. > fyi - it is relevant to 18.11 also as 3d01b759d is fixing something introduced in 18.11. I skipped 3d01b759d for now and will take the full set together when available.

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Kamaraj P
Hi Kevin/Anatoly, Yes we have the patch already included in our code base. Looks like it get struck in the below piece of the code: mapped_addr = mmap(requested_addr, (size_t)map_sz, PROT_READ, mmap_flags, -1, 0); Could you please share your thoughts on this? Tha

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-02-19 Thread Wang, Xiao W
Hi Xiaojun, 1. No, don't base on the old patch. Just send new version. 2. Yes. 3. No need, just send to the same names as this version. Please remember to add "-in-reply-to " when sending new version. The Message-ID can be found in the email header of the previous patch or in http://

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-19 Thread Kevin Traynor
On 19/02/2020 10:23, Burakov, Anatoly wrote: > On 17-Feb-20 9:57 AM, Kamaraj P wrote: >> Hi Anatoly, >> Thanks for the clarifications. >> >> Currently we are migrating to the new DPDK 18.11 ( from 17.05).  Here is >> our configuration: >> ===

  1   2   >