Re: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP

2020-02-11 Thread Somalapuram, Amaranath
Is it a fix or a new feature? It’s a new feature If it is a fix then only it should be sent to stable and the patch title should include "crypto/ccp: fix ...". Ok got it.. next time will keep in mind. If it is a feature(which is more likely the case IMO), the title is fine or I would change it t

Re: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP

2020-02-11 Thread Akhil Goyal
> > CCP use vdev framework, and vdev framework don’t support IOMMU. > Adding custom IOMMU support for AMD CCP drives. > Cc: sta...@dpdk.org > > Signed-off-by: Amaranath Somalapuram > --- Is it a fix or a new feature? If it is a fix then only it should be sent to stable and the patch title shou

Re: [dpdk-dev] [PATCH v3] net/i40e: relaxed barrier in the tx fastpath

2020-02-11 Thread Gavin Hu
Hi Xiaolong, Just sent v4 for this, thanks for reminding! Best Regards, Gavin > -Original Message- > From: Ye Xiaolong > Sent: Tuesday, February 11, 2020 10:11 AM > To: Gavin Hu > Cc: dev@dpdk.org; nd ; david.march...@redhat.com; > tho...@monjalon.net; rasl...@mellanox.com; > maxime.co

[dpdk-dev] [PATCH v4] net/i40e: relaxed barrier in the tx fastpath

2020-02-11 Thread Gavin Hu
To keep ordering of mixed accesses, rte_cio is sufficient. The rte_io barrier inside the I40E_PCI_REG_WRITE is overkill.[1] [1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9 qf0kpn89emdgdajepk...@mail.gmail.com Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH v1] net/ice: resolve unchecked return value

2020-02-11 Thread Sunil Pai G
This checks the return value of the function ice_xmit_cleanup Coverity issue: 353623 Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Cc: wenzhuo...@intel.com Signed-off-by: Sunil Pai G --- drivers/net/ice/ice_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[dpdk-dev] [PATCH v2] examples/vhost_blk: fix the TOCTOU

2020-02-11 Thread Jin Yu
Fix the time of check time of use warning in example code. Ignore the errno of unlink failure. There are two situations. The first one is that file doesn't exist the unlink fails and it's ok to ignore. The second one is that unlink fails to remove file but the next bind() would fail too. Coverity

[dpdk-dev] [PATCH v2] net/i40e: fix unchecked return value

2020-02-11 Thread Beilei Xing
This patch fixes unchecked return value of the i40e_xmit_cleanup function. Coverity issue: 353617 Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Beilei Xing --- V2 change: - Use cast. drivers/net/i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return value

2020-02-11 Thread Xing, Beilei
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, February 11, 2020 7:42 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return value > > On Wed, Feb 12, 2020 at 03:02:00AM +0800, Beilei Xing wrote: > > Check t

Re: [dpdk-dev] [PATCH v4 0/6] mlx ibverbs linking in meson

2020-02-11 Thread Thomas Monjalon
> Thomas Monjalon (6): > drivers: cleanup meson build variable > net/mlx: add static ibverbs linkage with meson > buildtools: get static mlx dependencies for meson > net/mlx: workaround static linkage with meson > net/mlx: rename meson variable for dlopen option > net/mlx: fix overlinki

[dpdk-dev] [PATCH v4 6/6] net/mlx: fix overlinking with meson and glue dlopen

2020-02-11 Thread Thomas Monjalon
If ibverbs_link is dlopen, the PMD and application should not be linked with ibverbs, but the glue library is. Unfortunately the ibverbs dependency was exported in the variable ext_deps, so there were overlinking. It is fixed by not exporting the dependency in ext_deps, and recreating a limited de

[dpdk-dev] [PATCH v4 3/6] buildtools: get static mlx dependencies for meson

2020-02-11 Thread Thomas Monjalon
The shell script options-ibverbs-static.sh was used with make in forcing static linkage of ibverbs libraries. When choosing to link with a static dependency in meson, the generated .pc file will not force such static linkage. The solution will rely on using this script in meson. If linking with l

[dpdk-dev] [PATCH v4 4/6] net/mlx: workaround static linkage with meson

2020-02-11 Thread Thomas Monjalon
If ibverbs_link is static and the application choose to link DPDK as static libraries, both PMD and ibverbs libraries must be linked as static libraries. And the dependencies of ibverbs (netlink) must still be linked as shared libraries. Unfortunately, meson forget about the static requirement for

[dpdk-dev] [PATCH v4 2/6] net/mlx: add static ibverbs linkage with meson

2020-02-11 Thread Thomas Monjalon
The libibverbs (and libmlx4/5) can be statically embedded in the shared PMD library, or in the application with the static PMD. It was supported with make build system in commit 2c0dd7b69fb0 ("config: add static linkage of mlx dependency"). The same feature is enabled with meson when using pkg-con

[dpdk-dev] [PATCH v4 5/6] net/mlx: rename meson variable for dlopen option

2020-02-11 Thread Thomas Monjalon
The name of the variable pmd_dlopen is confusing because it can be understood as true if the PMD is dlopen, whereas it means the ibverbs glue layer is a dlopen library. That's why it is renamed dlopen_ibverbs. Signed-off-by: Thomas Monjalon --- drivers/common/mlx5/meson.build | 8 drive

[dpdk-dev] [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-11 Thread Thomas Monjalon
The variable build is already initialized as true in drivers/meson.build. Duplicate initializations can be removed from mlx. When the variable build is set to false, it is easier to call subdir_done() than branch the rest of the code on build condition. Suggested-by: Bruce Richardson Signed-off-

[dpdk-dev] [PATCH v4 0/6] mlx ibverbs linking in meson

2020-02-11 Thread Thomas Monjalon
This is the follow-up of the feature I added one year ago: static linkage of libibverbs in mlx PMDs. The first implementation was focused on "make". This second round does the same with "meson". With the meson option ibverbs_link, only the mode "shared" was working correctly. This patchset adds th

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 6/9] eal: include SSE4 support for windows

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Modified \common\include\arch\x86\rte_vect.h > to include SSE4 header for Windows. > > Signed-off-by: Antara Ganesh Kolar > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > Reviewed-by: Keith Wiles > --- > lib/librte_eal/common/include/arch

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 5/9] eal: add function to detect process type

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Adding a function to detect process type, also included > header files to contain suitable function declarations > and to support extra warning flags. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Antara Ganesh Kolar > Reviewed-by: Ranjit Menon > R

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 8/9] build: add additional common files support

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Added support for additional common files in meson build > to expand Windows EAL and to support the lcore parsing > feature on Windows. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Antara Ganesh Kolar > Reviewed-by: Ranjit Menon > Reviewed-by: Kei

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 9/9] eal: add minimum viable code to support parsing

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Adding specific logic for eal.c to support parsing on > Windows. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Antara Ganesh Kolar > Reviewed-by: Ranjit Menon > Reviewed-by: Keith Wiles > --- > lib/librte_eal/windows/eal/eal.c | 133 +

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 7/9] eal: remove syslog and dlfcn support for windows

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Excluding syslog/ dlfcn definitions and parameters > from Windows by adding #ifndef RTE_EXEC_ENV_WINDOWS. > > Note: This is a temporary change. In future, separate > 'unix' directory will be created for unix specific functions. > > Signed-off-by: Pallavi

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 4/9] eal: getopt implementation for windows

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Adding getopt files to support parsing option on > Windows. > > The original contribution is under BSD-2 license. > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgreenplum-db%2Flibusual%2Fblob%2Fmaster%2Fusual%2Fgetopt.c&d

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 3/9] eal: add additional function overrides in windows header files

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Adding additional function definitions for pthread, cpuset > implementation, asprintf implementation, in order to support > common code. > > Signed-off-by: Bruce Richardson > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > Reviewed-by: Keith

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 2/9] eal: dirent.h implementation for windows

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > Adding dirent.h on Windows to support common code. > eal_common_options.c includes this file. > > The original contribution is under MIT license. > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftronkko%2Fdirent&data=02%7C0

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 1/9] license: add license exception for windows

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > The Governing Board and Tech Board have provided exceptions for > MIT and BSD-2-Clause license files for DPDK support on Windows. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > license/exceptions.txt | 12 +++- > 1 file ch

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: update Rx offload after setting MTU sccessfully

2020-02-11 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/1/28 19:27, Ferruh Yigit wrote: On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Currently, Rx offload capabilities and max_rx_pkt_len in the struct variable named rte_port are not updated after setting mtu successfully in port_mtu_set function by

[dpdk-dev] [PATCH 0/2] cleanup makefile config and testing

2020-02-11 Thread Thomas Monjalon
Thomas Monjalon (2): config: deduplicate options devtools: enable more config options in build test config/common_armv8a_linux| 2 -- config/common_linux | 6 -- config/defconfig_arm-armv7a-linuxapp-gcc | 9 - config/defconfig_

[dpdk-dev] [PATCH 2/2] devtools: enable more config options in build test

2020-02-11 Thread Thomas Monjalon
The Linux kernel modules kni and igb_uio were disabled by default so they need a new option (+kmods) for testing compilation. Some recent features were not enabled in compilation testing: - mlx5 vDPA (depends on libibverbs) - ifpga (depends on libfdt) - ipn3ke (depends on l

[dpdk-dev] [PATCH 1/2] config: deduplicate options

2020-02-11 Thread Thomas Monjalon
Some config options are overwritten with the same value as the one inherited from its template parent. Such duplicates which have no meaningful comments are removed. Signed-off-by: Thomas Monjalon --- config/common_armv8a_linux| 2 -- config/common_linux

Re: [dpdk-dev] [PATCH] examples/power: fix ack for enable/disable turbo

2020-02-11 Thread Yao, Lei A
> -Original Message- > From: Hunt, David > Sent: Tuesday, February 11, 2020 6:50 PM > To: dev@dpdk.org; Hunt, David > Cc: Yao, Lei A ; sta...@dpdk.org > Subject: [PATCH] examples/power: fix ack for enable/disable turbo > > When a VM sends a command through virtio-serial to enable/disa

[dpdk-dev] [PATCH 5/7] vfio/pci: Add sriov_configure support

2020-02-11 Thread Alex Williamson
With the VF Token interface we can now expect that a vfio userspace driver must be in collaboration with the PF driver, an unwitting userspace driver will not be able to get past the GET_DEVICE_FD step in accessing the device. We can now move on to actually allowing SR-IOV to be enabled by vfio-pc

[dpdk-dev] [PATCH 7/7] vfio/pci: Cleanup .probe() exit paths

2020-02-11 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index a88b45ce1cc7..fff4

[dpdk-dev] [PATCH 6/7] vfio/pci: Remove dev_fmt definition

2020-02-11 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/

[dpdk-dev] [PATCH 2/7] vfio/pci: Implement match ops

2020-02-11 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfi

[dpdk-dev] [PATCH 0/7] vfio/pci: SR-IOV support

2020-02-11 Thread Alex Williamson
Given the mostly positive feedback from the RFC[1], here's a new non-RFC revision. Changes since RFC: - vfio_device_ops.match semantics refined - Use helpers for struct pci_dev.physfn to avoid breakage without CONFIG_PCI_IOV - Relax to allow SR-IOV configuration changes while PF is opened.

[dpdk-dev] [PATCH 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-11 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20 include/linux/vfio.h |4 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/vfio.

[dpdk-dev] [PATCH 3/7] vfio/pci: Introduce VF token

2020-02-11 Thread Alex Williamson
If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not fully isolated from the PF. The PF can always cause a denial of service to the VF, if not access data passed through the VF directly. This is why vfio-pci currently does not bind to PFs with SR-IOV enabled and does not provide a

[dpdk-dev] [PATCH 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-11 Thread Alex Williamson
The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device agnostic ioctl for setting, retrieving, and probing device features. This implementation provides a 16-bit field for specifying a feature index, where the data porition of the ioctl is determined by the semantics for the given f

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 0/9] Windows patchset with additional EAL functionalities

2020-02-11 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: fix ABI version

2020-02-11 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Tuesday, February 11, 2020 21:49 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Thomas Monjalon > ; David Marchand > Subject: [PATCH 2/2] vdpa/mlx5: fix ABI version > > Changed the ABI version to 20.0.1. > > Fixes: 95276abaaf0a ("vdpa/mlx5: i

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: fix ABI version

2020-02-11 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Tuesday, February 11, 2020 21:49 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Thomas Monjalon > ; David Marchand > Subject: [PATCH 1/2] common/mlx5: fix ABI version > > Changed the ABI version to 20.0.1. > > Fixes: 7b4f1e6bd367 ("common/mlx

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix txonly flow generation entropy

2020-02-11 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Monday, February 10, 2020 16:02 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Thomas Monjalon ; > bernard.iremon...@intel.com; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix txonly flow generation > entropy >

[dpdk-dev] [PATCH 2/2] vdpa/mlx5: fix ABI version

2020-02-11 Thread Matan Azrad
Changed the ABI version to 20.0.1. Fixes: 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver") Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map

[dpdk-dev] [PATCH 1/2] common/mlx5: fix ABI version

2020-02-11 Thread Matan Azrad
Changed the ABI version to 20.0.1. Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") Signed-off-by: Matan Azrad --- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-11 Thread Jerin Jacob
On Tue, Feb 11, 2020 at 10:36 PM Alex Williamson wrote: > > On Tue, 11 Feb 2020 16:48:47 +0530 > Jerin Jacob wrote: > > > On Wed, Feb 5, 2020 at 4:35 AM Alex Williamson > > wrote: > > > > > > There seems to be an ongoing desire to use userspace, vfio-based > > > drivers for both SR-IOV PF and VF

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-11 Thread Alex Williamson
On Tue, 11 Feb 2020 16:48:47 +0530 Jerin Jacob wrote: > On Wed, Feb 5, 2020 at 4:35 AM Alex Williamson > wrote: > > > > There seems to be an ongoing desire to use userspace, vfio-based > > drivers for both SR-IOV PF and VF devices. The fundamental issue > > with this concept is that the VF is n

Re: [dpdk-dev] [PATCH v8] app/testpmd: add portlist option

2020-02-11 Thread Burakov, Anatoly
On 11-Feb-20 3:52 PM, Hariprasad Govindharajan wrote: In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p

Re: [dpdk-dev] [PATCH] build: remove redundant config include

2020-02-11 Thread David Marchand
On Mon, Feb 10, 2020 at 10:54 AM Thomas Monjalon wrote: > > The header file rte_config.h is always included by make or meson. > If required in an exported API header file, it must be included > in the public header file for external applications. > In the internal files, explicit include of rte_co

[dpdk-dev] [PATCH v8] app/testpmd: add portlist option

2020-02-11 Thread Hariprasad Govindharajan
In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn): mask must be in hex format - Using portlist i

Re: [dpdk-dev] [PATCH v7] app/testpmd: add portlist option

2020-02-11 Thread Govindharajan, Hariprasad
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, February 11, 2020 12:01 PM > To: Govindharajan, Hariprasad ; Lu, > Wenzhuo ; Wu, Jingjing ; > Iremonger, Bernard ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; Yigit, Ferruh ; > step...@networkplumber.org; david

Re: [dpdk-dev] [PATCH] kni: fix bug 389 - Crash in librte_kni driver due to noncontiguous pages

2020-02-11 Thread Ferruh Yigit
On 2/11/2020 12:18 PM, Burakov, Anatoly wrote: > On 11-Feb-20 9:28 AM, Ferruh Yigit wrote: >> On 2/10/2020 7:47 PM, Scott Wasson wrote: >>> Fixes: edd2fafbc0b8 ("kni: allocate memory dynamically for each device") >>> Cc: iryz...@nfware.com >>> Cc: sta...@dpdk.org >> >> I suggest following patch sub

Re: [dpdk-dev] [PATCH] common/octeontx2: update version map

2020-02-11 Thread David Marchand
On Mon, Feb 10, 2020 at 11:28 AM Anoob Joseph wrote: > > Move symbols added in 20.02 release to DPDK_20.0.1 ABI. > > Fixes: d06551535a09 ("common/octeontx2: add security capability routine") > Fixes: 3fe4d07d1678 ("crypto/octeontx2: enable CPT to share QP with ethdev") > Fixes: f44e71637755 ("net/

Re: [dpdk-dev] [PATCH 1/1] raw/octeontx2_ep: update the ABI version

2020-02-11 Thread David Marchand
On Tue, Feb 11, 2020 at 12:29 PM Mahipal Challa wrote: > > Changed the ABI version to 20.0.1. > > Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe") > > Signed-off-by: Mahipal Challa > --- > drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- > 1 file cha

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-11 Thread Thomas Monjalon
11/02/2020 12:18, Jerin Jacob: > On Wed, Feb 5, 2020 at 4:35 AM Alex Williamson wrote: > > > > There seems to be an ongoing desire to use userspace, vfio-based > > drivers for both SR-IOV PF and VF devices. The fundamental issue > > with this concept is that the VF is not fully independent of the

[dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path

2020-02-11 Thread Wisam Jaddo
The blocker should take FDB into consideration, since FDB all directions have transfer ingress in it. Fixes: 55060e62e4d2 ("net/mlx5: block push VLAN action on Rx") Cc: dek...@mellanox.com Signed-off-by: Wisam Jaddo --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[dpdk-dev] [PATCH] maintainers: update for NFP

2020-02-11 Thread Heinrich Kuhn
Jan is no longer with Netronome. Remove him as maintainer for the Netronome PMD Signed-off-by: Heinrich Kuhn --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index bc98b9167..3d5e8d110 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -784,7 +784,6 @@ F: d

Re: [dpdk-dev] [PATCH] kni: fix bug 389 - Crash in librte_kni driver due to noncontiguous pages

2020-02-11 Thread Burakov, Anatoly
On 11-Feb-20 9:28 AM, Ferruh Yigit wrote: On 2/10/2020 7:47 PM, Scott Wasson wrote: Fixes: edd2fafbc0b8 ("kni: allocate memory dynamically for each device") Cc: iryz...@nfware.com Cc: sta...@dpdk.org I suggest following patch subject: "kni: fix not contiguous FIFO" And I little detail in the

Re: [dpdk-dev] [PATCH v7] app/testpmd: add portlist option

2020-02-11 Thread Burakov, Anatoly
On 10-Feb-20 5:19 PM, Hariprasad Govindharajan wrote: In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix coverity issue

2020-02-11 Thread Ye Xiaolong
On 02/11, Shougang Wang wrote: >This patch fixes (Logically dead code ) coverity issue. > >Coverity issue: 353624 >Fixes: ba7b12dd64e4 ("net/ixgbe: fix link up in FreeBSD") > >Signed-off-by: Shougang Wang >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++ > 1 file changed, 6 insertions(+), 4

Re: [dpdk-dev] [PATCH v3 3/5] net/mlx: workaround static linkage with meson

2020-02-11 Thread Bruce Richardson
On Tue, Feb 11, 2020 at 12:36:06PM +0100, Thomas Monjalon wrote: > 11/02/2020 12:29, Bruce Richardson: > > On Tue, Feb 11, 2020 at 02:19:40AM +0100, Thomas Monjalon wrote: > > > If ibverbs_link is static and the application choose to link DPDK > > > as static libraries, both PMD and ibverbs librari

Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return value

2020-02-11 Thread Bruce Richardson
On Wed, Feb 12, 2020 at 03:02:00AM +0800, Beilei Xing wrote: > Check the return value of the i40e_xmit_cleanup function. > > Coverity issue: 353617 > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_rxtx.c | 5 +++-- > 1 file change

Re: [dpdk-dev] [PATCH v3 3/5] net/mlx: workaround static linkage with meson

2020-02-11 Thread Thomas Monjalon
11/02/2020 12:29, Bruce Richardson: > On Tue, Feb 11, 2020 at 02:19:40AM +0100, Thomas Monjalon wrote: > > If ibverbs_link is static and the application choose to link DPDK > > as static libraries, both PMD and ibverbs libraries must be linked > > as static libraries. And the dependencies of ibverb

Re: [dpdk-dev] [PATCH v3 5/5] net/mlx: fix overlinking with meson and glue dlopen

2020-02-11 Thread Thomas Monjalon
11/02/2020 12:32, Bruce Richardson: > On Tue, Feb 11, 2020 at 02:19:42AM +0100, Thomas Monjalon wrote: > > If ibverbs_link is dlopen, the PMD and application should not > > be linked with ibverbs, but the glue library is. > > Unfortunately the ibverbs dependency was exported in the > > variable ext

Re: [dpdk-dev] [PATCH v3 0/5] mlx ibverbs linking in meson

2020-02-11 Thread Bruce Richardson
On Tue, Feb 11, 2020 at 02:19:37AM +0100, Thomas Monjalon wrote: > This is the follow-up of the feature I added one year ago: > static linkage of libibverbs in mlx PMDs. > The first implementation was focused on "make". > This second round does the same with "meson". > > With the meson option ibve

Re: [dpdk-dev] [PATCH v3 5/5] net/mlx: fix overlinking with meson and glue dlopen

2020-02-11 Thread Bruce Richardson
On Tue, Feb 11, 2020 at 02:19:42AM +0100, Thomas Monjalon wrote: > If ibverbs_link is dlopen, the PMD and application should not > be linked with ibverbs, but the glue library is. > Unfortunately the ibverbs dependency was exported in the > variable ext_deps, so there were overlinking. > > It is f

[dpdk-dev] [PATCH 1/1] raw/octeontx2_ep: update the ABI version

2020-02-11 Thread Mahipal Challa
Changed the ABI version to 20.0.1. Fixes: 56d46d13f736 ("raw/octeontx2_ep: add build infra and device probe") Signed-off-by: Mahipal Challa --- drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/octeontx2_

Re: [dpdk-dev] [PATCH v3 3/5] net/mlx: workaround static linkage with meson

2020-02-11 Thread Bruce Richardson
On Tue, Feb 11, 2020 at 02:19:40AM +0100, Thomas Monjalon wrote: > If ibverbs_link is static and the application choose to link DPDK > as static libraries, both PMD and ibverbs libraries must be linked > as static libraries. And the dependencies of ibverbs (netlink) must > still be linked as shared

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-11 Thread Jerin Jacob
On Wed, Feb 5, 2020 at 4:35 AM Alex Williamson wrote: > > There seems to be an ongoing desire to use userspace, vfio-based > drivers for both SR-IOV PF and VF devices. The fundamental issue > with this concept is that the VF is not fully independent of the PF > driver. Minimally the PF driver mi

[dpdk-dev] [Bug 396] Build of octeontx2 with GCC 10.0.1 fails on armv7

2020-02-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=396 Bug ID: 396 Summary: Build of octeontx2 with GCC 10.0.1 fails on armv7 Product: DPDK Version: 20.02 Hardware: ARM OS: Linux Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 395] Build of hinic with GCC 10.0.1 fails on aarch64

2020-02-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=395 Bug ID: 395 Summary: Build of hinic with GCC 10.0.1 fails on aarch64 Product: DPDK Version: 20.02 Hardware: ARM OS: Linux Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 394] Build of librte_cryptodev with GCC 10.0.1 fails

2020-02-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=394 Bug ID: 394 Summary: Build of librte_cryptodev with GCC 10.0.1 fails Product: DPDK Version: 20.02 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v2] net/mlx5: fix VLAN item match for DV mode

2020-02-11 Thread Dekel Peled
Currently MLX5 PMD can't match on untagged packets specifically. Tagged traffic still hits the flows intended for untagged packets. If the flow has ETH, it will catch all matching packets, tagged and untagged. The solution is to use cvlan_tag bit. If mask=1 and value=0 it matches on untagged traffi

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add missing SPDX license tag

2020-02-11 Thread Ananyev, Konstantin
> > Add missing BSD-3 license tag to inline fallback testing scripts. > > Signed-off-by: Marcin Smoczynski > --- > .../ipsec-secgw/test/trs_aesgcm_inline_crypto_fallback_defs.sh | 1 + > .../ipsec-secgw/test/tun_aesgcm_inline_crypto_fallback_defs.sh | 1 + > 2 files changed, 2 insertions(

[dpdk-dev] [PATCH] examples/power: fix ack for enable/disable turbo

2020-02-11 Thread David Hunt
When a VM sends a command through virtio-serial to enable/disable turbo, it is successfully enabled or disabled, yet the response to the VM is NACK. This is because all the library frequency change APIs return 1 for success (change in frequency), 0 for success (no change in frequency) and -1 for fa

[dpdk-dev] [PATCH] examples/ipsec-secgw: add missing SPDX license tag

2020-02-11 Thread Marcin Smoczynski
Add missing BSD-3 license tag to inline fallback testing scripts. Signed-off-by: Marcin Smoczynski --- .../ipsec-secgw/test/trs_aesgcm_inline_crypto_fallback_defs.sh | 1 + .../ipsec-secgw/test/tun_aesgcm_inline_crypto_fallback_defs.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/e

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-02-11 Thread Wang, Xiao W
Since this is a big code change, so just some general comments/suggestions for your next version patch set: - please clean up comments like "XXX" in the code. - It's better to define MACRO for all register addrs and bit shift, please try to avoid magic number (e.g. in the serdes part). - There'r

Re: [dpdk-dev] Big spike in DPDK VSZ

2020-02-11 Thread Burakov, Anatoly
On 11-Feb-20 8:11 AM, David Marchand wrote: Hello Anatoly, On Tue, Feb 4, 2020 at 11:23 AM Burakov, Anatoly wrote: On 30-Jan-20 8:51 AM, David Marchand wrote: On Thu, Jan 30, 2020 at 8:48 AM siddarth rai wrote: I have been using DPDK 19.08 and I notice the process VSZ is huge. I tried run

[dpdk-dev] [PATCH v1] net/axgbe: add register dump support

2020-02-11 Thread chandu
From: Chandu Babu N Implement "get_reg" eth_dev_ops for axgbe Signed-off-by: Chandu Babu N --- drivers/net/axgbe/axgbe_common.h | 3 + drivers/net/axgbe/axgbe_ethdev.c | 25 drivers/net/axgbe/axgbe_regs.h | 229 +++ 3 files changed, 257 insertions(+) crea

[dpdk-dev] [PATCH] net/i40e: fix unchecked return value

2020-02-11 Thread Beilei Xing
Check the return value of the i40e_xmit_cleanup function. Coverity issue: 353617 Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_rxtx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b

Re: [dpdk-dev] Windows Support Plan

2020-02-11 Thread Burakov, Anatoly
On 08-Feb-20 8:09 PM, Dmitry Kozlyuk wrote: The main reason DPDK memory management works the way it does is because of need to support multiprocess. In order to map memory in all processes, we need that space reserved (otherwise there's no guarantee that the newly mapped memory segment will be ma

[dpdk-dev] [PATCH v2] net/ixgbe: fix coverity issue

2020-02-11 Thread Shougang Wang
This patch fixes (Logically dead code ) coverity issue. Coverity issue: 353624 Fixes: ba7b12dd64e4 ("net/ixgbe: fix link up in FreeBSD") Signed-off-by: Shougang Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/i

Re: [dpdk-dev] [PATCH] kni: fix bug 389 - Crash in librte_kni driver due to noncontiguous pages

2020-02-11 Thread Ferruh Yigit
On 2/10/2020 7:47 PM, Scott Wasson wrote: > Fixes: edd2fafbc0b8 ("kni: allocate memory dynamically for each device") > Cc: iryz...@nfware.com > Cc: sta...@dpdk.org I suggest following patch subject: "kni: fix not contiguous FIFO" And I little detail in the comment log can be good: " KNI requires

Re: [dpdk-dev] [PATCH] eal: fix to set the rte_device ptr's device args before hotplug

2020-02-11 Thread Gaetan Rivet
[...] (gdb) p dev2 $5 = (struct rte_pci_device *) 0x54de5e0 (gdb) p /x *dev2 $6 = {next = {tqe_next = 0x5307460, tqe_prev = 0x5539f80}, device = {next = {tqe_next = 0x0, tqe_prev = 0x0}, name = 0x54e4f00, driver = 0x3a6b7f0, bus = 0x3a59a00, numa_node = 0x0, devargs = 0x0}, addr = {domain =

Re: [dpdk-dev] [PATCH] net/mlx5: fix the legacy multi packet write session

2020-02-11 Thread Raslan Darawsheh
Hi > -Original Message- > From: Viacheslav Ovsiienko > Sent: Monday, February 10, 2020 12:55 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the legacy multi packet write session > > To provide the better PCIe ban

Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Sunday, February 9, 2020 11:17 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro > > Replace checking against 655

Re: [dpdk-dev] [PATCH] net/ixgbe: fix coverity issue

2020-02-11 Thread Ye Xiaolong
On 02/11, Shougang Wang wrote: >This patch fixes (Logically dead code ) coverity issue. > >Coverity issue: 353624 >Fixes: ba7b12dd64e4 ("net/ixgbe: fix link up in FreeBSD") > >Signed-off-by: Shougang Wang >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++- > 1 file changed, 6 insertions(+), 5

[dpdk-dev] [PATCH v1] net/axgbe: add debug logs

2020-02-11 Thread cnamburu
From: Chandu Babu N Add debug logs in various modules in axgbe Signed-off-by: Chandu Babu N --- drivers/net/axgbe/axgbe_dev.c | 17 -- drivers/net/axgbe/axgbe_ethdev.c | 2 ++ drivers/net/axgbe/axgbe_i2c.c | 10 ++ drivers/net/axgbe/axgbe_mdio.c | 51 ++

Re: [dpdk-dev] Big spike in DPDK VSZ

2020-02-11 Thread David Marchand
Hello Anatoly, On Tue, Feb 4, 2020 at 11:23 AM Burakov, Anatoly wrote: > > On 30-Jan-20 8:51 AM, David Marchand wrote: > > On Thu, Jan 30, 2020 at 8:48 AM siddarth rai wrote: > >> I have been using DPDK 19.08 and I notice the process VSZ is huge. > >> > >> I tried running the test PMD. It takes