Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-07 Thread Jerin Jacob
On Sat, Feb 8, 2020 at 2:04 AM Stephen Hemminger wrote: > > On Fri, 7 Feb 2020 19:48:17 +0530 > Jerin Jacob wrote: > > > On Fri, Feb 7, 2020 at 6:08 PM Coyle, David wrote: > > > > > > Hi Jerin, see below > > > > Hi David, > > > > > > > > > > On Thu, Feb 6, 2020 at 10:01 PM Coyle, David > > > >

[dpdk-dev] [PATCH] event/dpaa2: set number of order sequeuences

2020-02-07 Thread Nipun Gupta
This patch sets the number of atomic ordered sequeuences supported by the driver Fixes: dbf63bd43afa ("event/dpaa2: support ordered queue") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/event

[dpdk-dev] BUG BPF examples broken

2020-02-07 Thread Stephen Hemminger
The BPF examples do not compile on Debian. The issue is that ret_mbuf_core.h includes rte_atomic which include rte_common which pulls in errno.h and bits/errno.h. And then asm/errno.h /usr/include/linux/errno.h:1:10: fatal error: 'asm/errno.h' file not found #include ^ 1 err

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-07 Thread Stephen Hemminger
On Fri, 7 Feb 2020 19:48:17 +0530 Jerin Jacob wrote: > On Fri, Feb 7, 2020 at 6:08 PM Coyle, David wrote: > > > > Hi Jerin, see below > > Hi David, > > > > > > > On Thu, Feb 6, 2020 at 10:01 PM Coyle, David > > > wrote: > > > > > > > > > > There is a risk in drafting API that meant for H

Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson

2020-02-07 Thread Dmitry Kozlyuk
> On Wed, Feb 05, 2020 at 11:41:05PM +0300, Dmitry Kozlyuk wrote: > > > > > > > +if is_windows > > > > > > > + # Require platform SDK for Windows 7 and above. > > > > > > > + add_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c') > > > > > > > > > > > > > > > > > > > Please explai

Re: [dpdk-dev] [PATCH v8 0/9] Windows patchset with additional EAL functionalities

2020-02-07 Thread Dmitry Kozlyuk
> This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a

Re: [dpdk-dev] [PATCH 00/14] cleanup resources on shutdown

2020-02-07 Thread Stephen Hemminger
On Thu, 6 Feb 2020 15:06:56 +0100 David Marchand wrote: > On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger > wrote: > > > > Recently started using valgrind with DPDK, and the results > > are not clean. > > > > The DPDK has a function that applications can use to tell it > > to cleanup resources

[dpdk-dev] [PATCH v2] net/netvsc: initialize link state

2020-02-07 Thread Stephen Hemminger
If application is using link state interrupt, the correct link state needs to be filled in when device is started. This is similar to how virtio updates link information. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sta...@dpdk.org Reported-by: Mohammed Gamal Tested-by: Moha

[dpdk-dev] [PATCH v3] devtools: add new SPDX license compliance checker

2020-02-07 Thread Stephen Hemminger
Simple script to look for drivers and scripts that are missing requires SPDX header. Signed-off-by: Stephen Hemminger --- v3 - pickup more places with boilerplate text avoid false positive for cocci scripts or abignore devtools/spdx-check.sh | 24 1 file changed, 2

Re: [dpdk-dev] SPDX license nag

2020-02-07 Thread Stephen Hemminger
On Mon, 27 Jan 2020 11:15:44 + "Mcnamara, John" wrote: > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Wednesday, January 22, 2020 4:19 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] SPDX license nag > > > > Files without SPDX License > > -

Re: [dpdk-dev] [PATCH v2 0/7] MinGW-w64 support

2020-02-07 Thread William Tu
Hi Dmitry, Thanks for your reply. On Fri, Feb 7, 2020 at 2:24 AM Dmitry Kozliuk wrote: > > Hi William, > >> I applied your v2 patch and I did a native build on windows 10. >> Hit an error showing >> ../lib/librte_eal/windows/eal/eal_lcore.c:54:2: error: 'for' loop >> initial declarations are onl

Re: [dpdk-dev] [PATCH v2] devtools: add new SPDX license compliance checker

2020-02-07 Thread Stephen Hemminger
On Wed, 29 Jan 2020 07:59:07 -0800 Stephen Hemminger wrote: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger Ping. This should have been merged by now.

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-07 Thread Ranjit Menon
On 2/7/2020 8:46 AM, Ranjit Menon wrote: On 2/6/2020 1:26 AM, Thomas Monjalon wrote: > As discussed in community meeting, the goal was to have core parsing > in Windows EAL 20.02. > Given that there is a crash and a doubt on the imported getopt library, > I think it's better to postpone this seri

Re: [dpdk-dev] [PATCH] test/crypto: add cpu crypto mode tests

2020-02-07 Thread Ananyev, Konstantin
> > This patch adds ability to run unit tests in cpu crypto mode for AESNI > GCM cryptodev. > > Signed-off-by: Marcin Smoczynski > --- Tested-by: Konstantin Ananyev Acked-by: Konstantin Ananyev > 2.17.1

[dpdk-dev] [PATCH v2 2/3] net/af_xdp: use correct fill queue addresses

2020-02-07 Thread Ciara Loftus
The fill queue addresses should start at the beginning of the mempool object instead of the beginning of the mbuf. This is because the umem frame headroom includes the mp hdrobj size. Starting at this point ensures AF_XDP doesn't write past the available room in the frame, in the case of larger pac

[dpdk-dev] [PATCH v2 3/3] net/af_xdp: fix maximum MTU value

2020-02-07 Thread Ciara Loftus
The maximum MTU for af_xdp zero copy is equal to the page size less the frame overhead introduced by AF_XDP (XDP HR = 256) and DPDK (frame headroom = 320). The patch updates this value to reflect this. This change also makes it possible to remove unneeded constants for both zero-copy and copy mode

[dpdk-dev] [PATCH v2 1/3] net/af_xdp: fix umem frame size & headroom calculations

2020-02-07 Thread Ciara Loftus
The previous frame size calculation incorrectly used mb_pool->private_data_size and didn't include mb_pool->header_size. Instead of performing a manual calculation, use the rte_mempool_calc_obj_size API to determine the frame size. The previous frame headroom calculation also incorrectly used mb_p

[dpdk-dev] [PATCH v2 0/3] AF_XDP PMD Fixes

2020-02-07 Thread Ciara Loftus
This series introduces some fixes for the zero copy path of the AF_XDP. In zero copy, the mempool objects are mapped directly into the AF_XDP UMEM. Below depicts the layout of an object in a mempool. +-++--+--+-+-+ | mp | struct | mbuf | mbuf | XDP |

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-07 Thread Ranjit Menon
On 2/6/2020 1:26 AM, Thomas Monjalon wrote: As discussed in community meeting, the goal was to have core parsing in Windows EAL 20.02. Given that there is a crash and a doubt on the imported getopt library, I think it's better to postpone this series to 20.05. Thomas... We have fixed the cras

Re: [dpdk-dev] [RFT] net/netvsc: initialize link state

2020-02-07 Thread Mohammed Gamal
On Fri, 2020-02-07 at 08:12 -0800, Stephen Hemminger wrote: > On Fri, 07 Feb 2020 15:22:23 +0200 > Mohammed Gamal wrote: > > > On Thu, 2020-02-06 at 16:10 -0800, Stephen Hemminger wrote: > > > If application is using link state interrupt, the correct link > > > state > > > needs to be filled in w

Re: [dpdk-dev] [RFT] net/netvsc: initialize link state

2020-02-07 Thread Stephen Hemminger
On Fri, 07 Feb 2020 15:22:23 +0200 Mohammed Gamal wrote: > On Thu, 2020-02-06 at 16:10 -0800, Stephen Hemminger wrote: > > If application is using link state interrupt, the correct link state > > needs to be filled in when device is started. This is similar to > > how virtio updates link informat

[dpdk-dev] [PATCH 3/3] net/af_xdp: fix maximum MTU value

2020-02-07 Thread Ciara Loftus
The maximum MTU for af_xdp zero copy is equal to the page size less the frame overhead introduced by AF_XDP (XDP HR = 256) and DPDK (frame headroom = 320). The patch updates this value to reflect this. This change also makes it possible to remove unneeded constants for both zero-copy and copy mode

[dpdk-dev] [PATCH 1/3] net/af_xdp: fix umem frame size & headroom calculations

2020-02-07 Thread Ciara Loftus
The previous frame size calculation incorrectly used mb_pool->private_data_size and didn't include mb_pool->header_size. Instead of performing a manual calculation, use the rte_mempool_calc_obj_size API to determine the frame size. The previous frame headroom calculation also incorrectly used mb_p

[dpdk-dev] [PATCH 2/3] net/af_xdp: use correct fill queue addresses

2020-02-07 Thread Ciara Loftus
The fill queue addresses should start at the beginning of the mempool object instead of the beginning of the mbuf. This is because the umem frame headroom includes the mp hdrobj size. Starting at this point ensures AF_XDP doesn't write past the available room in the frame, in the case of larger pac

[dpdk-dev] [PATCH 0/3] AF_XDP PMD Fixes

2020-02-07 Thread Ciara Loftus
This series introduces some fixes for the zero copy path of the AF_XDP. In zero copy, the mempool objects are mapped directly into the AF_XDP UMEM. Below depicts the layout of an object in a mempool. +-++--+--+-+-+ | mp | struct | mbuf | mbuf | XDP |

Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation

2020-02-07 Thread Olivier Matz
Hi Somnath, On Fri, Feb 07, 2020 at 07:13:04PM +0530, Somnath Kotur wrote: > Olivier, > > On Thu, Feb 6, 2020 at 10:55 PM Olivier Matz wrote: > > > > Hi Somnath, > > > > Sorry for the delay, please find some comments below. > > > > I suggest the following title instead: > > > > mbuf: extend me

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2020-02-07 Thread Aaron Conole
Kevin Traynor writes: > On 20/12/2019 14:43, David Marchand wrote: >> On Wed, Dec 4, 2019 at 9:34 AM David Marchand >> wrote: >>> >>> On Wed, Dec 4, 2019 at 9:33 AM David Marchand >>> wrote: On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole wrote: > > The service_valid call is u

[dpdk-dev] [PATCH] test/crypto: add cpu crypto mode tests

2020-02-07 Thread Marcin Smoczynski
This patch adds ability to run unit tests in cpu crypto mode for AESNI GCM cryptodev. Signed-off-by: Marcin Smoczynski --- app/test/test_cryptodev.c | 181 -- 1 file changed, 172 insertions(+), 9 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-07 Thread Jerin Jacob
On Fri, Feb 7, 2020 at 6:08 PM Coyle, David wrote: > > Hi Jerin, see below Hi David, > > > > On Thu, Feb 6, 2020 at 10:01 PM Coyle, David > > wrote: > > > > > > There is a risk in drafting API that meant for HW without any HW exists. > > Because there could be inefficiency on the metadata and

[dpdk-dev] [PATCH] crypto/ccp: fix queue alignment

2020-02-07 Thread David Marchand
Caught by compiling with -fno-common. A cacheline_aligned symbol can be found in the crypto/ccp driver object files. Looking at this driver source, the cacheline_aligned (kernel?) alignment macro is undefined. The compiler treats this as a symbol definition and generates a global symbol.

Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation

2020-02-07 Thread Somnath Kotur
Olivier, On Thu, Feb 6, 2020 at 10:55 PM Olivier Matz wrote: > > Hi Somnath, > > Sorry for the delay, please find some comments below. > > I suggest the following title instead: > > mbuf: extend meaning of QinQ stripped bit > > On Mon, Jan 06, 2020 at 02:04:23PM +0530, Somnath Kotur wrote: > >

Re: [dpdk-dev] [RFT] net/netvsc: initialize link state

2020-02-07 Thread Mohammed Gamal
On Thu, 2020-02-06 at 16:10 -0800, Stephen Hemminger wrote: > If application is using link state interrupt, the correct link state > needs to be filled in when device is started. This is similar to > how virtio updates link information. > > Reported-by: Mohammed Gamal > Signed-off-by: Stephen Hem

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-07 Thread Coyle, David
Hi Jerin, see below > > On Thu, Feb 6, 2020 at 10:01 PM Coyle, David > wrote: > > Hi David, > > > > > > > > > > > > > - XGS-PON MAC: Crypto-CRC-BIP > > > > > > - Order: > > > > > > - Downstream: CRC, Encrypt, BIP > > > > > > > > > > I understand if the chain has two ope

Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services

2020-02-07 Thread Kevin Traynor
On 20/12/2019 14:43, David Marchand wrote: > On Wed, Dec 4, 2019 at 9:34 AM David Marchand > wrote: >> >> On Wed, Dec 4, 2019 at 9:33 AM David Marchand >> wrote: >>> >>> On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole wrote: The service_valid call is used without properly bounds checkin

Re: [dpdk-dev] Query for support hw gro offload

2020-02-07 Thread Ferruh Yigit
On 2/7/2020 10:39 AM, fengchengwen wrote: > Hello Ferruh, > > 1. Current dpdk framework provide software GRO feature, but do not > support hardware GRO offload. and it now can only process tcp4 and > vxland_tcp4 streams. > 2. HNS3's hardware 1620(ARM SoC) support hardware GRO offload, it > can pro

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: add link speed devarg

2020-02-07 Thread Ivan Dyukov
Hi Maxime, Adrian, Thank you for comments!  I have sent new patch with updated documentation. This is not final version of the link speed. I still have plan to rework it and use link speed which is stored in qemu. Best regards, Ivan 06.02.2020 17:26, Adrian Moreno пишет: > On 2/6/20 3:22 PM, Max

[dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg

2020-02-07 Thread Ivan Dyukov
Some applications like pktgen use link_speed to calculate transmit rate. It limits outcome traffic to hardcoded 10G. This patch adds link_speed devarg which allows to configure link_speed of virtio device. Signed-off-by: Ivan Dyukov --- doc/guides/nics/virtio.rst | 7 ++ drivers/net/v

[dpdk-dev] [PATCH v3 1/2] net/virtio: refactor devargs parsing

2020-02-07 Thread Ivan Dyukov
refactor vdpa specific devargs parsing to more generic way Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 35 +- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev

[dpdk-dev] [PATCH v3] eal/mem: preallocate VA space in no-huge mode

2020-02-07 Thread Anatoly Burakov
When --no-huge mode is used, the memory is currently allocated with mmap(NULL, ...). This is fine in most cases, but can fail in cases where DPDK is run on a machine with an IOMMU that is of more limited address width than that of a VA, because we're not specifying the address hint for mmap() call.

[dpdk-dev] Query for support hw gro offload

2020-02-07 Thread fengchengwen
Hello Ferruh, 1. Current dpdk framework provide software GRO feature, but do not support hardware GRO offload. and it now can only process tcp4 and vxland_tcp4 streams. 2. HNS3's hardware 1620(ARM SoC) support hardware GRO offload, it can process tcp4 and tcp6 streams. 3. linux kernerl driver supp

[dpdk-dev] [PATCH v2] examples/ioat: fix invalid link status check

2020-02-07 Thread Ciara Power
The return value of the get link function call was not checked, and could return a negative value indicating a failure. This meant the link_status of the link being checked is invalid, because the link was not filled with data. The return value is now checked, and if the return value is not 0 for s

Re: [dpdk-dev] [PATCH v2 0/7] MinGW-w64 support

2020-02-07 Thread Dmitry Kozliuk
Hi William, I applied your v2 patch and I did a native build on windows 10. > Hit an error showing > ../lib/librte_eal/windows/eal/eal_lcore.c:54:2: error: 'for' loop > initial declarations are only allowed in C99 mode > Thanks, will fix in v3. However the output looks weird: > C:\dpdk\build\exa

[dpdk-dev] [Bug 392] l3fwd fails to run with eventdev

2020-02-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=392 Vipin Varghese (vipin.vargh...@intel.com) changed: What|Removed |Added Resolution|--- |FIXED Stat

[dpdk-dev] [Bug 393] rte_zmalloc_socket does not zero memory

2020-02-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=393 Bug ID: 393 Summary: rte_zmalloc_socket does not zero memory Product: DPDK Version: 19.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: critical

[dpdk-dev] [PATCH] doc: update thunderx guide

2020-02-07 Thread Harman Kalra
Updating the thunderx with loopback port support, debugging options, new features added and correcting some formating issues. Signed-off-by: Harman Kalra --- doc/guides/nics/thunderx.rst | 153 --- 1 file changed, 88 insertions(+), 65 deletions(-) diff --git a/do

Re: [dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-02-07 Thread Kevin Traynor
On 04/02/2020 03:23, Ye Xiaolong wrote: > Hi, Kevin > > On 02/03, Kevin Traynor wrote: >> On 13/01/2020 05:59, Ye, Xiaolong wrote: > > [snip] > -Original Message- >> Hi Xiaolong/Beilei/Qi Z, >> >> Some of these patches are tagged to go to 'S'table and are 'F'ixes, >> while others ar

Re: [dpdk-dev] [RFC PATCH 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-02-07 Thread Cornelia Huck
On Thu, 6 Feb 2020 11:18:42 -0700 Alex Williamson wrote: > On Thu, 6 Feb 2020 12:14:19 +0100 > Cornelia Huck wrote: > > > On Tue, 04 Feb 2020 16:05:43 -0700 > > Alex Williamson wrote: > > > > > Allow bus drivers to provide their own callback to match a device to > > > the user provided stri

Re: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test vectors

2020-02-07 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Thursday, February 6, 2020 11:25 AM > To: dev@dpdk.org; Trahe, Fiona > Cc: Dybkowski, AdamX > Subject: [PATCH] test/crypto: replace wireless algos test vectors > > This patch replaces all KASUMI, SNOW3G, ZUC and all mixed > crypto