[dpdk-dev] [PATCH] net/mlx5: update Tx datapath to support no inline hint

This patch adds support for dynamic flag that hints transmit datapath do not copy data to the descriptors. This flag is useful when data are located in the memory of another (not NIC) physical device and copying to the host memory is undesirable. This hint flag is per mbuf for multi-segment packet

[dpdk-dev] [PATCH v2 4/4] net/mlx5: allow use allocated mbuf with external buffer

In the Rx datapath the flags in the newly allocated mbufs are all explicitly cleared but the EXT_ATTACHED_MBUF must be preserved. It would allow to use mbuf pools with pre-attached external data buffers. The vectorized rx_burst routines are updated in order to inherit the EXT_ATTACHED_MBUF from mb

[dpdk-dev] [PATCH v2 1/4] mbuf: detach mbuf with pinned external buffer

Update detach routine to check the mbuf pool type. Signed-off-by: Shahaf Shuler Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 65 +++--- 1 file changed, 61 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib

[dpdk-dev] [PATCH v2 2/4] mbuf: create packet pool with external memory buffers

The dedicated routine rte_pktmbuf_pool_create_extbuf() is provided to create mbuf pool with data buffers located in the pinned external memory. The application provides the external memory description and routine initialises each mbuf with appropriate virtual and physical buffer address. It is enti

[dpdk-dev] [PATCH v2 3/4] app/testpmd: add mempool with external data buffers

The new mbuf pool type is added to testpmd. To engage the mbuf pool with externally attached data buffers the parameter "--mp-alloc=xbuf" should be specified in testpmd command line. The objective of this patch is just to test whether mbuf pool with externally attached data buffers works OK. The m

[dpdk-dev] [PATCH v2 0/4] mbuf: introduce pktmbuf pool with pinned external buffers

Today's pktmbuf pool contains only mbufs with no external buffers. This means data buffer for the mbuf should be placed right after the mbuf structure (+ the private data when enabled). On some cases, the application would want to have the buffers allocated from a different device in the platform.

Re: [dpdk-dev] [PATCH] net/octeontx: add unicast MAC filter

On Tue, Jan 14, 2020 at 1:13 PM Harman Kalra wrote: > > On Mon, Jan 13, 2020 at 11:46:44AM +0530, Sunil Kumar Kori wrote: > > At BGX, DMAC filter table can be enabled to allow defined hosts. > > Patch implements 'mac_addr_add' and 'mac_addr_remove' ops to > > add/remove MAC filters which uses BGX

Re: [dpdk-dev] [PATCH] net/octeontx: add unicast MAC filter

On Mon, Jan 13, 2020 at 11:46:44AM +0530, Sunil Kumar Kori wrote: > At BGX, DMAC filter table can be enabled to allow defined hosts. > Patch implements 'mac_addr_add' and 'mac_addr_remove' ops to > add/remove MAC filters which uses BGX DMAC filter table. > > Signed-off-by: Sunil Kumar Kori Acked

Re: [dpdk-dev] [PATCH v1 1/2] net/iavf: unify the bool type value

> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, January 14, 2020 1:23 PM > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Yang, Qiming > Cc: Wang, Haiyue > Subject: [PATCH v1 1/2] net/iavf: unify the bool type value > > Replaces the redefined TRUE and FALSE values with s

Re: [dpdk-dev] [PATCH v1 2/2] net/ice: unify the bool type value

> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, January 14, 2020 1:23 PM > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Yang, Qiming > Cc: Wang, Haiyue > Subject: [PATCH v1 2/2] net/ice: unify the bool type value > > Replaces the redefined TRUE and FALSE values with st

Re: [dpdk-dev] [PATCH v1 2/2] net/ice: unify the bool type value

> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, January 14, 2020 1:23 PM > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Yang, Qiming > Cc: Wang, Haiyue > Subject: [PATCH v1 2/2] net/ice: unify the bool type value > > Replaces the redefined TRUE and FALSE values with st

Re: [dpdk-dev] [PATCH 1/4] mbuf: detach mbuf with pinned external buffer

> -Original Message- > From: Stephen Hemminger > Sent: Friday, January 10, 2020 20:24 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > > Subject: Re: [dpdk-dev] [PATCH 1/4] mbuf: detach mbuf with pinned external > buffer > > On Fri,

Re: [dpdk-dev] [PATCH] mempool/octeontx: fix error handling in initialization

On Thu, Dec 19, 2019 at 4:14 PM wrote: > > From: Krzysztof Kanas > > When octeontx_get_fpavf fails fpa pointer is used to get > pool_stack_base, which is then freed. > > Coverity issue: 351263 > > Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation") > Cc: pbhagavat...@marve

Re: [dpdk-dev] [PATCH] net/octeontx2: add check for PTP and HIGIG2

On Mon, Jan 13, 2020 at 9:55 AM wrote: > > From: Kiran Kumar K > > For octeontx2 we won't support both PTP and HIGIG2 together. > Added a check to verify this. Since it is a bug fix, Could change to the following or similar and send v2: net/octeontx2: fix PTP and HIGIG2 coexistence. octeontx2

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for EC Point Multiplication

Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Monday, January 13, 2020 6:14 PM > To: Anoob Joseph ; Declan Doherty > ; Pablo de Lara > > Cc: Balakrishna Bhamidipati ; Fiona Trahe > ; Arek Kusztal ; > Jerin Jacob Kollanukkaran ; Narayana Pra

[dpdk-dev] [PATCH v3] net/i40e: fix multi-queue Rx interrupt for VF

The vector id bound to each queue could not large than the max usable vector. It will cause port start failed. This patch fixed this issue. And in this patch I changed judgement condition for the limit of vector id. vf->vf_res->max_vectors represents the number of usable vectors. It can effectivel

Re: [dpdk-dev] [PATCH v2] net/octeontx2: perf improvement to Tx vector func

On Sat, Jan 11, 2020 at 7:27 PM wrote: > > From: Pavan Nikhilesh > > Use scalar loads instead of vector loads for fields > that don't need any vector operations. > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/net/octeont

Re: [dpdk-dev] [PATCH 1/2] net/qede: enhance receive data path CPU utilization

On Thu, Jan 2, 2020 at 11:29 PM Shahed Shaikh wrote: > > Use light weight receive packet handler for non-LRO and > non-scatter packets to improve CPU utilization in receive data path. > We achieved ~18% CPU cycles improvement using this handler. > > Signed-off-by: Shahed Shaikh Series applied to

[dpdk-dev] [PATCH v2] examples/l2fwd-event: fix ethdev RSS setup

From: Pavan Nikhilesh Setup RSS configuration based on underlying device capabilities. Fixes: 4ff457986f76 ("examples/l2fwd-event: add default poll mode routines") Cc: sta...@dpdk.org Signed-off-by: Satananda Burla Signed-off-by: Pavan Nikhilesh --- v2 Changes: - change the patch type to fi

[dpdk-dev] [PATCH v1 2/2] net/ice: unify the bool type value

Replaces the redefined TRUE and FALSE values with standard ones to match the 'bool' type definition. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 22 +++--- drivers/net/ice/ice_rxtx.c | 16 2 files changed, 19 insertions(+), 19 deletions(-) di

[dpdk-dev] [PATCH v1 1/2] net/iavf: unify the bool type value

Replaces the redefined TRUE and FALSE values with standard ones to match the 'bool' type definition. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 31 --- drivers/net/iavf/iavf_rxtx.c | 34 +- 2 files changed, 33 ins

Re: [dpdk-dev] [PATCH v3 00/10] bnxt patchset with bug fixes

On Mon, Jan 13, 2020 at 9:16 PM Ajit Khaparde wrote: > v1->v2: fixed the correct the commit ids in Fixes tag. > v2->v3: shorten commit log and update commit ids for Fixes tag. > > Note that Fixes tag in patch 07/10 is correct. > Patches applied to dpdk-next-net-brcm. Thanks > > Kalesh AP (8): >

[dpdk-dev] [PATCH v3 10/10] net/bnxt: fix calculation of max rings

From: Somnath Kotur Max Tx rings count could be lesser than max Rx rings in some cases, so take this into account as well. Account for stat contexts available(one for each ring) along with no: of completion rings(one for each ring) to cap the max no: of Tx /Rx rings that can be possibly created.

[dpdk-dev] [PATCH v3 09/10] net/bnxt: release port upon close

From: Somnath Kotur Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 + 1 file changed,

[dpdk-dev] [PATCH v3 07/10] net/bnxt: fix a memory leak in port stop

From: Kalesh AP The memory for mark table is allocated during port start. But the allocated memory is freed only during port close or driver unload which in turn causes a memory leakage on each port start/stop. Fixed it by moving the memory free to port stop. Fixes: a968a9f5456d ("net/bnxt: add

[dpdk-dev] [PATCH v3 03/10] net/bnxt: fix to use correct IOVA mapping

From: Kalesh AP Use rte_malloc_virt2iova() to obtain the IO address of a virtual address obtained through rte_malloc(). Fixed to use the iova address returned by rte_memzone_reserve_aligned() as the call always returns with populating "mz->iova" with rte_malloc_virt2iova(mz->addr). Removed redu

[dpdk-dev] [PATCH v3 08/10] net/bnxt: use macro for PCI log format

From: Kalesh AP Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers

[dpdk-dev] [PATCH v3 05/10] net/bnxt: fix VLAN strip support

From: Kalesh AP HWRM_VNIC_CFG command to configure vnic dynamically with traffic running is not working. Driver has to free and recreate the vnic and then reconfigure the vnic filters. Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Signed-off-by: Kalesh AP Reviewed-by: Ajit Kh

[dpdk-dev] [PATCH v3 06/10] net/bnxt: handle HW filter setting when port is stopped

From: Kalesh AP Driver destroy the vnic when the port is brought down. Port hw filter setting such as promiscuos, allmulti and vlan filtering will be applied when port is started. Fixed to return success silently for these callbacks when port is stopped. Also fixed to clear "bp->dev_stopped" bef

[dpdk-dev] [PATCH v3 00/10] bnxt patchset with bug fixes

v1->v2: fixed the correct the commit ids in Fixes tag. v2->v3: shorten commit log and update commit ids for Fixes tag. Note that Fixes tag in patch 07/10 is correct. Kalesh AP (8): net/bnxt: handle flow create failure net/bnxt: fix probe failure in FreeBSD net/bnxt: fix to use correct IOVA

[dpdk-dev] [PATCH v3 04/10] net/bnxt: fix enable/disable VLAN filtering

From: Kalesh AP There is no condition check for the user requested operation for VLAN filtering. As a result, VLAN filtering is getting disabled when the user enables/disables VLAN stripping on same port. The function bnxt_hwrm_clear_l2_filter() didn't actually free L2 filter in HW if the refere

[dpdk-dev] [PATCH v3 02/10] net/bnxt: fix probe failure in FreeBSD

From: Kalesh AP In FreeBSD environment, nic_uio driver does not support interrupts and rte_intr_callback_register() will fail to register interrupts which in turn causes bnxt driver probe failure. Fixed driver to ignore interrupt callback failures in FreeBSD. Also fixed to not use a dedicated co

[dpdk-dev] [PATCH v3 01/10] net/bnxt: handle flow create failure

From: Kalesh AP If flow create fails due to not enough filter resources, driver does not populate the rte_flow_error using rte_flow_error_set(). Since "rte_errno" could have garbage value and is not relaiable, it could cause a segfault in the stack in port_flow_complain(). Fix it to set rte_flo

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA

Hi Anoob, Akhil > -Original Message- > From: Anoob Joseph > Sent: Monday, January 13, 2020 10:07 PM > To: Kusztal, ArkadiuszX ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo > Cc: Ayuj Verma ; Trahe, Fiona > ; Jerin Jacob Kollanukkaran ; > Narayana Prasad Raju Athreya ; Sha

Re: [dpdk-dev] [PATCH] net/bnx2x: add support for secondary process

On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody wrote: > > Skip the device re-initialization for secondary process. > > Cc: sta...@dpdk.com Correct Cc: to sta...@dpdk.org Applied to dpdk-next-net-mrvl/master. Thanks > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 5 +

Re: [dpdk-dev] [PATCH] net/qede/base: fix number of ports per engine

On Sat, Dec 21, 2019 at 7:05 AM Rasesh Mody wrote: > > Fix the way in which the number of ports per engine of an adapter is > determined by reading port mode register. Set default value to 1. > > Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0") > Cc: sta...@dpdk.com Corrected Cc to s

Re: [dpdk-dev] [RFC 2/4] app/testpmd: new flow dump CLI

On Tue, Jan 14, 2020 at 9:15 AM Xiaoyu Min wrote: > > From: Xueming Li > > New flow dump CLI to dump MLX5 PMD specific flows into screen. > > Signed-off-by: Xueming Li > Signed-off-by: Xiaoyu Min > --- > app/test-pmd/Makefile | 4 ++ > app/test-pmd/cmdline_flow.c | 91 ++

Re: [dpdk-dev] [PATCH v1 1/1] net/octeontx2: allow vec to process pkts not multiple of 4

On Fri, Dec 20, 2019 at 6:33 PM wrote: > > From: Vamsi Attunuru > > Current vector mode implementation floor-aligns pkt count > with NIX_DESCS_PER_LOOP and process that many packets. > > Patch addresses the case where pkt count modulo NIX_DESCS_PER_LOOP > is non-zero, after the vector mode proces

Re: [dpdk-dev] [PATCH] common/octeontx2: reduce wait time for mbox messages

On Mon, Dec 16, 2019 at 8:33 PM Sunil Kumar Kori wrote: > > After each mbox send operation, context waits for minimum 1ms to get > corresponding response although response can come earlier. > So reducing wait time to lower granularity. > > Signed-off-by: Sunil Kumar Kori Acked-by: Jerin Jacob

[dpdk-dev] [RFC 0/4] net/mlx5: dump software steering flows in HW

This RFC intends to provide a way to dump all the offloaded rte flows in HW. This is very helpful for user and developer to debug flow offloading stuff, i.e, to check whether PMD offloads the rte flow in a correct way from HW perspective. A private PMD API is provided as well as a socket server fo

[dpdk-dev] [RFC 4/4] doc: update mlx5 document for flow dump feature

From: Xueming Li Guide of mlx5 is updated on how to dump HW flows. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- doc/guides/nics/mlx5.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 92228

[dpdk-dev] [RFC 2/4] app/testpmd: new flow dump CLI

From: Xueming Li New flow dump CLI to dump MLX5 PMD specific flows into screen. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- app/test-pmd/Makefile | 4 ++ app/test-pmd/cmdline_flow.c | 91 + app/test-pmd/config.c | 33 ++

[dpdk-dev] [RFC 3/4] net/mlx5: add socket server for external tools

From: Xueming Li Add pmd unix socket server to enable external tool applications to trigger flow dump. Socket path: /var/tmp/dpdk_mlx5_ Socket format: io_raw: port_id of uint16 file: file descriptor of int Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- driver

[dpdk-dev] [RFC 1/4] net/mlx5: support flow dump Api

From: Xueming Li Dump fdb/nic_rx/nic_tx raw flow data into specified file. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/Makefile | 11 ++- drivers/net/mlx5/meson.build | 4 +++ drivers/net/mlx5/mlx5.h | 2 ++ dri

Re: [dpdk-dev] [PATCH v5 0/6] OCTEON TX2 End Point Driver

Hi Thomas, Would you please merge this series. Thanks, Mahipal > -Original Message- > From: dev On Behalf Of Mahipal Challa > Sent: Monday, January 13, 2020 11:31 AM > To: dev@dpdk.org; tho...@monjalon.net > Cc: gavin...@arm.com; Jerin Jacob Kollanukkaran ; > Narayana Prasad Raju Athreya

Re: [dpdk-dev] [PATCH v9 4/4] net/e1000: cleanup Tx buffers

On 01/13, Chenxu Di wrote: >Add support to the igb vf for the API rte_eth_tx_done_cleanup > to force free consumed buffers on Tx ring. > >Signed-off-by: Chenxu Di >--- > drivers/net/e1000/igb_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/n

Re: [dpdk-dev] [PATCH] doc: basic update for ice

On 12/20, Xiaolong Ye wrote: >The ice PMD supports 10/25/50/100 Gbps. > >Signed-off-by: Xiaolong Ye >--- > doc/guides/nics/ice.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst >index 9b90b389e..cde3fd620 100644 >--- a/doc/

Re: [dpdk-dev] [PATCH] doc: basic update for ice

> -Original Message- > From: dev On Behalf Of Xiaolong Ye > Sent: Friday, December 20, 2019 3:10 PM > To: Yang, Qiming ; Lu, Wenzhuo > ; Mcnamara, John ; > Kovacevic, Marko > Cc: dev@dpdk.org; Anantharam, Arjun ; Zhang, > Fred ; Zhang, Helin ; Ye, > Xiaolong > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH V1] doc: update recommended kernel version for i40e

On 01/03, Chen, Zhaoyan wrote: >Update supported Intel NIC driver version and firmware version for 19.11 >Update supported Intel NIC driver version to 2.8.43 for 19.08 which is >widely tested > >Signed-off-by: Zhaoyan Chen >--- > doc/guides/nics/i40e.rst | 4 +++- > 1 file changed, 3 insertions(+)

Re: [dpdk-dev] [PATCH 0/4] drivers/net: cleanup Tx buffers

On 12/03, Chenxu Di wrote: >From: Di ChenxuX > >Add support to the drivers inclulding fm10k, i40e, ice, ixgbe > for the API rte_eth_tx_done_cleanup to > force free consumed buffers on Tx ring. > >Di ChenxuX (4): > net/fm10k: cleanup Tx buffers > net/i40e: cleanup Tx buffers > net/ice: cleanup T

Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix return value of tap offload sets not checked

On Mon, Jan 13, 2020 at 03:40:31PM +0800, Yunjian Wang wrote: > The function vhost_kernel_tap_set_offload() could return errors, > the return value need to be checked. And there is no need to fail > when error is -ENOTSUP. > > Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before

[dpdk-dev] [PATCH v2] net/i40e: fixed multi-queue Rx interrupt for VF

The value of vectors bound to each queue could not large than the max usable vector. It will let devices start failed. vf->vf_res->max_vectors is equal to the max vector number. intr_handle->nb_efd is equal to queue number. Whichever one is less, it is no need to check intr_handle->nb_efd when we

Re: [dpdk-dev] [PATCH v9 2/4] net/ice: cleanup Tx buffers

> -Original Message- > From: Di, ChenxuX > Sent: Monday, January 13, 2020 5:57 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Di, ChenxuX > > Subject: [PATCH v9 2/4] net/ice: cleanup Tx buffers > > Add support to the ice driver for the API rte_eth_tx_done_cleanup to force > free > consum

Re: [dpdk-dev] [PATCH v4 2/3] net/i40e: support FDIR for L2TPv3 over IP

> -Original Message- > From: Sexton, Rory > Sent: Monday, January 13, 2020 7:51 PM > To: dev@dpdk.org; or...@mellanox.com; Xing, Beilei ; > Zhang, Qi Z > Cc: Sexton, Rory ; Jagus, DariuszX > > Subject: [PATCH v4 2/3] net/i40e: support FDIR for L2TPv3 over IP > > Adding FDIR support fo

Re: [dpdk-dev] [PATCH] net/af_xdp: use single-prod-and-cons ring

On 01/08, Xiao Wang wrote: >The ring is used only by af_xdp pmd itself, so no need to support >multi-producer and multi-consumer mode. This patch changes the ring >to single-producer and single-consumer mode, which could yield better >performance for addr enqueue and dequeue. > >Signed-off-by: Xiao

[dpdk-dev] [PATCH 2/3] net/bnx2x: fix reset of scan FP flag

The fastpath task queue handler resets the fastpath scan flag unconditionally, this patch changes that to reset the flag only if it was set. Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 file changed,

[dpdk-dev] [PATCH 1/3] net/bnx2x: fix to use required mem barriers in Rx path

When handling RX completion queue PMD is not using required read/write barriers before reading completion queue element (CQE) indices, updating/writing hardware consumer and producer. This patch adds appropriate read/write memory barriers in places which are required by driver and adapter to read o

[dpdk-dev] [PATCH 3/3] net/bnx2x: fix to sync fastpath Rx queue access

PMD handles fast path completions in the Rx handler and control path completions in the interrupt handler. They both are processing completions from the same fastpath completion queue. There is a potential for race condition when these two paths are processing the completions from the same queue an

[dpdk-dev] [PATCH] net/enic: move macro to the correct file

Move a macro from a widely included header file to a header file used only by the one caller of the macro. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic_compat.h | 10 -- drivers/net/enic/enic_res.h| 11 ++- 2 files changed, 10 insertions(+)

[dpdk-dev] [PATCH] net/enic: use standard RTE defines

Use the memzone namesize, Ethernet address length defines from the RTE header files instead of locally defined versions. Use the RTE byte swap functions instead of the x86 specific locally defined versions. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/base/cq_desc.

[dpdk-dev] [PATCH] net/enic: consolidate and remove some defines

There were defines which originally allowed sharing of some code with the enic kernel driver. The code has long since diverged and now the abstraction just makes the code harder to read. Mostly mechanical replacement of defines and reformatting. Signed-off-by: John Daley Reviewed-by: Hyong Youb K

Re: [dpdk-dev] patches not showing up on list?

13/01/2020 19:48, Sowmini Varadhan: > > I just sent a couple of (RFC) patches to dev@dpdk.org and they > are showing up in the patch queue, but not on the list, is there > something wrong with my mail headers? How can I debug this? They are showing up on the list: http://inbox.dpdk.org/d

Re: [dpdk-dev] [PATCH v2 0/3] Introduce new class for vDPA device drivers

09/01/2020 12:00, Matan Azrad: > v2: > Apply comments from Maxime Coquelin, Andrew Rybchenko and Tiwei Bie. > > > Matan Azrad (3): > drivers: introduce vDPA class > doc: add vDPA feature table > drivers: move ifc driver to the vDPA class I've fixed few minor things as discussed in this thr

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

09/01/2020 12:00, Matan Azrad: > --- a/drivers/vdpa/Makefile > +++ b/drivers/vdpa/Makefile > +ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) > +ifeq ($(CONFIG_RTE_EAL_VFIO),y) > +DIRS-$(CONFIG_RTE_LIBRTE_IFC_PMD) += ifc > +endif > +endif # $(CONFIG_RTE_LIBRTE_VHOST) All vDPA drivers will need vhost lib. As i

Re: [dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table

09/01/2020 12:00, Matan Azrad: > +Useful links > + > + > + * `OASIS: Virtual I/O Device (VIRTIO) Version 1.1 > `_. > + * `QEMU: Vhost-user Protocol > `_. .ht

[dpdk-dev] [PATCH v5 8/9] build: add additional common files support

Added support for additional common files in meson build to expand Windows EAL and to support the lcore parsing feature on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/meson.build | 8

[dpdk-dev] [PATCH v5 6/9] eal: add function to detect process type

Adding a function to detect process type, also included header files to contain suitable function declarations and to support extra warning flags. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/

[dpdk-dev] [PATCH v5 4/9] eal: add additional function overrides in windows header files

Adding additional function definitions for pthread, cpuset implementation, asprintf implementation, in order to support common code. Signed-off-by: Bruce Richardson Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/include/pthread.h

[dpdk-dev] [PATCH v5 7/9] eal: remove syslog support for windows

Added #ifndef WIN64 to exclude syslog definitions and parameters from Windows builds. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/common/eal_common_options.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_

[dpdk-dev] [PATCH v5 9/9] eal: add minimum viable code to support parsing

Adding specific logic for eal.c to support parsing on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/eal.c | 133 ++- 1 file changed, 130 insertions(+), 3 de

[dpdk-dev] [PATCH v5 3/9] eal: add windows compatible header files

Modified \common\include\arch\x86\rte_vect.h to include SSE4 header for Windows. Adding dlfcn.h on Windows to support common code. Adding eal_filesystem.h to support functions and path defines for files and directories on Windows. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v5 2/9] eal: dirent.h implementation for windows

Adding dirent.h on Windows to support common code. eal_common_options.c includes this file. The original contribution is under MIT license. https://github.com/tronkko/dirent Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles ---

[dpdk-dev] [PATCH v5 1/9] license: add license exception for windows

The Governing Board and Tech Board have provided exceptions for MIT and BSD-2-Clause license files for DPDK support on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- license/exceptions.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lice

[dpdk-dev] [PATCH v5 5/9] eal: getopt implementation for windows

Adding getopt files to support parsing option on Windows. The original contribution is under BSD-2 license. https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.c https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.h Signed-off-by: Antara Ganesh Kola

[dpdk-dev] [PATCH v5 0/9] Windows patchset with additional EAL functionalities

This patchset includes additional functionalities for Windows EAL to support command-line parsing feature and some EAL common code on Windows. This patchset can be applied to windpdk-next-dev branch in the draft repo. v5 changes: Fixed indentation in patch 6. v4 changes: Modified

[dpdk-dev] net/cxgbe: DEV_TX_OFFLOAD_MULTI_SEGS support?

It looks like the cxgbe driver doesn't set the DEV_TX_OFFLOAD_MULTI_SEGS offload capability. However, it looks like sge.c does have support for sending mbuf chains, e.g. write_sgl(). Is this just an oversight or is there something fundamentally broken here?

[dpdk-dev] [PATCH] maintainers: update for Windows

Since Anand is no longer with Intel, Pallavi will replace him as maintainer. Signed-off-by: Ranjit Menon --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4395d8df1..f6c35cf77 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -318,7 +

[dpdk-dev] [PATCH 1/2] net/netvsc: fix crash in secondary process

The secondary process would crash trying to get the offload capability of the device. Since the device capabilities were already set by the primary process this was unnecessary. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH 0/2] net/netvsc: fix secondary process issues

First patch is a bug fix for crash in info_get in secondary process. Second one is modification to prevent similar issues in future. Stephen Hemminger (2): net/netvsc: fix crash in secondary process net/netvsc: eliminate numa specific allocation for control messages drivers/net/netvsc/hn_eth

[dpdk-dev] [PATCH 2/2] net/netvsc: eliminate numa specific allocation for control messages

The control messages do not need NUMA specific allocation. Numa node is not set anyway in most kernels anyway. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rndis.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/netvsc/hn_rndis.c b/driver

[dpdk-dev] patches not showing up on list?

I just sent a couple of (RFC) patches to dev@dpdk.org and they are showing up in the patch queue, but not on the list, is there something wrong with my mail headers? How can I debug this? Patches I am referring to are: https://patchwork.dpdk.org/patch/64574/ https://patchwork.dpdk.org/patch/64

[dpdk-dev] [PATCH RFC V2 2/2] Allow the flow_classify example to add an ACL table for tcp.

The struct rte_flow_classifier can have upto RTE_FLOW_CLASSIFY_TABLE_MAX (32) classifier tables, but the existing flow_classify examples only adds a single table for the L4 5-tuple. When dealing with tcp flows, we frequently want to add add ACLs and filters to filter based on the state of the TC

[dpdk-dev] [PATCH RFC V2 1/2] Hooks to allow the setting of filters on tcp flags

The rte_eth_ntuple_filter allows tcp_flags which can check for things like #define RTE_TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */ #define RTE_TCP_ECE_FLAG 0x40 /**< ECN-Echo */ #define RTE_TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */ #define RTE_TCP_ACK_FLAG

[dpdk-dev] [PATCH RFC V2 0/2] TCP flow classification using 4-tuple and flags

V2 updates: checkpatch fixes, revert accidently spelling error introduced in V1; The problem space of TCP flow tracking and classification based on TCP state requires the ability to classify TCP flows on more packet properties than just the 4-tuple, e.g., TCP flags. This patch-set investigates the

Re: [dpdk-dev] [PATCH] lmp: add lookup x4 with x4 default values

Hi, On 13/01/2020 12:34, Pavan Nikhilesh Bhagavatula wrote: -Original Message- From: dev On Behalf Of Medvedkin, Vladimir Sent: Monday, January 13, 2020 4:37 PM To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob Kollanukkaran ; Bruce Richardson ; Gavin Hu Cc: dev@dpdk.org Subject: Re: [dpdk

[dpdk-dev] [PATCH v8 6/6] lib/eventdev: use custom element size ring for event rings

Use custom element size ring APIs to replace event ring implementation. This avoids code duplication. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_eventdev/rte_event_ring.c | 147 ++- lib/librte_eventdev/rte_event_r

[dpdk-dev] [PATCH v8 5/6] lib/hash: use ring with 32b element size to save memory

The freelist and external bucket indices are 32b. Using rings that use 32b element sizes will save memory. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_hash/rte_cuckoo_hash.c | 97 --- lib/librte_hash/rte_cuckoo

[dpdk-dev] [PATCH v8 4/6] test/ring: modify perf test cases to use rte_ring_xxx_elem APIs

Adjust the performance test cases to test rte_ring_xxx_elem APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 454 +++--- 1 file changed, 273 insertions(+), 181 deletions(-) diff --git a/app/test/test_ring_perf.c b/a

[dpdk-dev] [PATCH v8 0/6] lib/ring: APIs to support custom element size

The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

[dpdk-dev] [PATCH v8 3/6] test/ring: add functional tests for rte_ring_xxx_elem APIs

Add basic infrastructure to test rte_ring_xxx_elem APIs. Adjust the existing test cases to test for various ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 1244 ++ app/test/test_ring.h | 187 +

[dpdk-dev] [PATCH v8 1/6] test/ring: use division for cycle count calculation

Use division instead of modulo operation to calculate more accurate cycle count. Signed-off-by: Honnappa Nagarahalli Acked-by: Olivier Matz --- app/test/test_ring_perf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/test/test_ring_perf.c b/app/

[dpdk-dev] [PATCH v8 2/6] lib/ring: apis to support configurable element size

Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin

Re: [dpdk-dev] [PATCH v2] net/axgbe: add a HW quirk for register definitions

On 1/9/2020 12:39 PM, Selwin Sebastian wrote: > V1000/R1000 processors are using the same PCI ids for the network > device as SNOWYOWL processor but has altered register definitions > for determining the window settings for the indirect PCS access. > Add support to check for this hardware and if fo

Re: [dpdk-dev] [PATCH 1/4] mbuf: detach mbuf with pinned external buffer

Hi, Stephen Thanks a lot for the comment. > -Original Message- > From: Stephen Hemminger > Sent: Friday, January 10, 2020 20:24 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > > Subject: Re: [dpdk-dev] [PATCH 1/4] mbuf: detach mbuf

Re: [dpdk-dev] [PATCH] ethdev: rte_eth_dev_callback_unregister() fails with cb_arg == -1

On 1/7/2020 3:51 PM, Ricardo Roldan wrote: > The function was checking -1 against the callback data instead of > the given cb_arg parameter. > > Signed-off-by: Ricardo Roldan Updated title as: ethdev: fix callback unregister with wildcard argument list Also adding following metadata to the

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA

Hi Akhil, Do you suggest any change for the title here? As in, should I make it, cryptodev: support ECDSA @Arek, please see inline for responses. Thanks, Anoob > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, January 9, 2020 6:34 PM > To: Anoob Joseph ; Akhil Goyal ;

Re: [dpdk-dev] [RFC] DPDK Trace support

On Mon, Jan 13, 2020 at 08:43:01PM +0530, Jerin Jacob wrote: > On Mon, Jan 13, 2020 at 8:28 PM Bruce Richardson > wrote: > > > > On Mon, Jan 13, 2020 at 08:16:07PM +0530, Jerin Jacob wrote: > > > On Mon, Jan 13, 2020 at 6:36 PM Bruce Richardson > > > wrote: > > > > > > > > > > > > > So, Probably

Re: [dpdk-dev] [PATCH] test/compress: add cycle-count mode to the perf tool

> -Original Message- > From: Trybula, ArturX > Sent: Wednesday, December 11, 2019 3:50 PM > To: dev@dpdk.org; Trahe, Fiona ; shal...@marvell.com; > Dybkowski, AdamX > ; Danilewicz, MarcinX > ; Trybula, > ArturX ; akhil.go...@nxp.com > Subject: [PATCH] test/compress: add cycle-count mo

Re: [dpdk-dev] [RFC] DPDK Trace support

On Mon, Jan 13, 2020 at 8:28 PM Bruce Richardson wrote: > > On Mon, Jan 13, 2020 at 08:16:07PM +0530, Jerin Jacob wrote: > > On Mon, Jan 13, 2020 at 6:36 PM Bruce Richardson > > wrote: > > > > > > > > > > So, Probably it good to have native CTF emitter in DPDK and reuse all > > > > open-source tr

Re: [dpdk-dev] [PATCH v4] net/virtio: packed ring notification data feature support

On 1/13/20 4:31 AM, Cheng Jiang wrote: > This patch supports the feature that the driver passes extra data > (besides identifying the virtqueue) in its device notifications, > expanding the notifications to include the avail index and avail > wrap counter. > > Signed-off-by: Cheng Jiang > ---

  1   2   >