Re: [dpdk-dev] [PATCH v5] net/iavf/base: change the base as driver common

2020-01-12 Thread Ye Xiaolong
On 01/10, Haiyue Wang wrote: >Change the iavf base code as driver common library, it is used by iavf >PMD now, and it can be used by other Intel SR-IOV PMDs in the future. > >Signed-off-by: Haiyue Wang >Acked-by: Qi Zhang >--- Applied to dpdk-next-net-intel, Thanks.

Re: [dpdk-dev] [PATCH] net/octeontx2: perf improvement to rx vector func

2020-01-12 Thread Jerin Jacob
On Tue, Dec 10, 2019 at 5:39 PM Nithin Dabilpuram wrote: > > From: Jerin Jacob > > Use scalar loads instead of vector loads for fields > that don't need any vector operations. > > Signed-off-by: Andrew Pinski > Signed-off-by: Jerin Jacob > Signed-off-by: Nithin Dabilpuram Applied to dpdk-next

[dpdk-dev] [PATCH v3] net/virtio-user: fix return value of tap offload sets not checked

2020-01-12 Thread Yunjian Wang
The function vhost_kernel_tap_set_offload() could return errors, the return value need to be checked. And there is no need to fail when error is -ENOTSUP. Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v3: * Fix

[dpdk-dev] [dpdk-users] Issue in draining packets when head is null

2020-01-12 Thread Suraj R Gupta
Hi all, This is regarding an issue in the draining packet using rte_reorder_drain. Suppose we have a window size of 16 and we get packets with sequence no like 0,1,2,4,5,6. On performing drain operation, I retrieve packets like 0,1,2. Since now order_buf->entries[order_buf->head] i.e. order_buf->en

Re: [dpdk-dev] [PATCH] net/octeontx2: fix VF configuration fail

2020-01-12 Thread Jerin Jacob
On Mon, Dec 2, 2019 at 8:11 PM Harman Kalra wrote: > > Returning -ENOTSUP only in case loopback mode is enabled and > device is VF or SDP. > > Fixes: c2c0aa75cd01 ("net/octeontx2: fix loopback config return for VF") > Cc: sta...@dpdk.org > > Signed-off-by: Harman Kalra > --- Acked-by: Jerin Jaco

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix return value of tap offload sets not checked

2020-01-12 Thread wangyunjian
> -Original Message- > From: Tiwei Bie [mailto:tiwei@intel.com] > Sent: Monday, January 13, 2020 10:16 AM > To: wangyunjian > Cc: dev@dpdk.org; maxime.coque...@redhat.com; zhihong.w...@intel.com; > xudingke ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix ret

[dpdk-dev] [PATCH v3] mempool: fix mempool obj alignment for non x86

2020-01-12 Thread jerinj
From: Jerin Jacob The existing optimize_object_size() function address the memory object alignment constraint on x86 for better performance. Different (micro) architecture may have different memory alignment constraint for better performance and it not the same as the existing optimize_object_si

[dpdk-dev] [PATCH v5 2/2] ci: add travis ci support for native aarch64

2020-01-12 Thread Ruifeng Wang
Add Travis compilation jobs for native aarch64. gcc/clang compilations for static/shared libraries are added. Some limitations for current aarch64 Travis support: 1. Container is used. Huge page is not available due to security reason. 2. Missing kernel header package in Xenial distribution. Solu

[dpdk-dev] [PATCH v5 0/2] add travis ci support for native aarch64

2020-01-12 Thread Ruifeng Wang
This patch set is to enable native aarch64 build in Travis CI. It leverages Travis CI multi arch support. As the first step, compilation jobs are added. Unit test is not added for now due to service limitation. We are planning to run unit test with no-huge in future. Plan is to enable the testing

[dpdk-dev] [PATCH v5 1/2] devtools: add path to additional shared object files

2020-01-12 Thread Ruifeng Wang
Drivers librte_mempool_ring.so and librte_pmd_null.so are loaded by librte_eal.so when running testpmd. In Ubuntu Xenial, driver path is installed to RPATH on testpmd. This allows librte_eal.so to find drivers by using the RPATH. However, in Ubuntu Bionic, driver path is installed to RUNPATH instea

[dpdk-dev] [PATCH] net/octeontx: add unicast MAC filter

2020-01-12 Thread Sunil Kumar Kori
At BGX, DMAC filter table can be enabled to allow defined hosts. Patch implements 'mac_addr_add' and 'mac_addr_remove' ops to add/remove MAC filters which uses BGX DMAC filter table. Signed-off-by: Sunil Kumar Kori --- doc/guides/nics/features/octeontx.ini| 2 +- drivers/net/octeontx/base/o

Re: [dpdk-dev] [PATCH v4 2/2] ci: add travis ci support for aarch64

2020-01-12 Thread Ruifeng Wang
> -Original Message- > From: Aaron Conole > Sent: Friday, January 10, 2020 23:13 > To: Ruifeng Wang > Cc: maicolgabr...@hotmail.com; tho...@monjalon.net; > ferruh.yi...@intel.com; arybche...@solarflare.com; dev@dpdk.org; > david.march...@redhat.com; Gavin Hu ; Honnappa > Nagarahalli ; n

[dpdk-dev] [PATCH v5 4/6] raw/octeontx2_ep: add enqueue operation

2020-01-12 Thread Mahipal Challa
Add rawdev enqueue operation for SDP VF devices. Signed-off-by: Mahipal Challa --- doc/guides/rawdevs/octeontx2_ep.rst | 6 + drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 242 ++ drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h | 39 + drivers/raw/octeontx2_ep/ot

[dpdk-dev] [PATCH v5 6/6] raw/octeontx2_ep: add driver self test

2020-01-12 Thread Mahipal Challa
Add rawdev's selftest feature in SDP VF driver, which verifies the EP mode functionality test. Signed-off-by: Mahipal Challa --- doc/guides/rawdevs/octeontx2_ep.rst | 13 +++ drivers/raw/octeontx2_ep/Makefile | 1 + drivers/raw/octeontx2_ep/meson.build | 1 + drivers/raw/

[dpdk-dev] [PATCH v5 5/6] raw/octeontx2_ep: add dequeue operation

2020-01-12 Thread Mahipal Challa
Add rawdev dequeue operation for SDP VF devices. Signed-off-by: Mahipal Challa --- drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 197 ++ drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h | 2 + drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 1 + drivers/raw/octeontx2_ep/otx2_e

[dpdk-dev] [PATCH v5 0/6] OCTEON TX2 End Point Driver

2020-01-12 Thread Mahipal Challa
This patchset adds support for OCTEON TX2 end point mode of operation. The driver implementation uses DPDK rawdevice sub-system. v2: * Updated memory barrier API's as per Gavin Hu suggestion. v3: * Fixed memory leak possibility issues. v4: * Improved error handling in selftest API. v5: * Update

[dpdk-dev] [PATCH v5 3/6] raw/octeontx2_ep: add device uninitialization

2020-01-12 Thread Mahipal Challa
Add rawdev close/uninitialize operation for SDP VF devices. Signed-off-by: Mahipal Challa --- drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 111 ++ drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 78 + drivers/raw/octeontx2_ep/otx2_ep_rawdev.h | 8 +++

[dpdk-dev] [PATCH v5 2/6] raw/octeontx2_ep: add device configuration

2020-01-12 Thread Mahipal Challa
Register "dev_configure" API to configure/initialize the SDP VF PCIe devices. Signed-off-by: Mahipal Challa --- doc/guides/rawdevs/octeontx2_ep.rst| 29 ++ drivers/common/octeontx2/hw/otx2_sdp.h | 184 + drivers/common/octeontx2/otx2_common.c |

[dpdk-dev] [PATCH v5 1/6] raw/octeontx2_ep: add build infra and device probe

2020-01-12 Thread Mahipal Challa
Add the OCTEON TX2 SDP EP device probe along with the build infrastructure for Make and meson builds. Signed-off-by: Mahipal Challa --- MAINTAINERS| 5 + config/common_base | 5 + doc/guides/rawdevs/index.rst

Re: [dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-01-12 Thread Ye, Xiaolong
> -Original Message- > From: Xing, Beilei > Sent: Monday, January 13, 2020 11:26 AM > To: Ye, Xiaolong > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: RE: [dpdk-dev] [PATCH v4 00/36] update for i40e base code > > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org

[dpdk-dev] [PATCH] common/octeotx2: add support for C0 silicon version

2020-01-12 Thread Nithin Dabilpuram
Avoid using PCI subsystem device id for SoC revision identification and just use PCI revision id to support C0 silicon. This patch also reduces SQB threshold to 70% to have sufficient buffer before we overflow SQ. Signed-off-by: Nithin Dabilpuram --- drivers/common/octeontx2/otx2_common.h | 3 --

[dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-12 Thread Fang TongHao
Secondary process calls “rte_eth_dev_pci_allocate” function and enters rte_eth_copy_pci_info function when initializing.Then it sets the value of struct "rte_eth_dev_data.dev_flags" to zero and reset it, but this struct is shared by primary process and secondary process.To fix this bug,by adding an

[dpdk-dev] [PATCH V2 07/10] net/bnxt: fix a memory leak in port stop

2020-01-12 Thread Kalesh A P
From: Kalesh AP The memory for mark table is allocated during port start. But the allocated memory is freed only during port close or driver unload which in turn causes a memory leakage on each port start/stop. Fixed it by moving the memory free to port stop. Fixes: a968a9f5456d ("net/bnxt: add

[dpdk-dev] [PATCH V2 09/10] net/bnxt: release port upon close

2020-01-12 Thread Kalesh A P
From: Somnath Kotur Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 + 1 file ch

[dpdk-dev] [PATCH V2 10/10] net/bnxt: fix to cap max rings to minimum of compl rings and stat contexts

2020-01-12 Thread Kalesh A P
From: Somnath Kotur Max Tx rings count could be lesser than max Rx rings in some cases, so take this into account as well. Account for stat contexts available(one for each ring) along with no: of completion rings(one for each ring) to cap the max no: of Tx /Rx rings that can be possibly created.

[dpdk-dev] [PATCH V2 06/10] net/bnxt: handle hw filter setting when port is stopped

2020-01-12 Thread Kalesh A P
From: Kalesh AP Driver destroy the vnic when the port is brought down. Port hw filter setting such as promiscuos, allmulti and vlan filtering will be applied when port is started. Fixed to return success silently for these callbacks when port is stopped. Also fixed to clear "bp->dev_stopped" bef

[dpdk-dev] [PATCH V2 08/10] net/bnxt: use macro for PCI log format

2020-01-12 Thread Kalesh A P
From: Kalesh AP Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers

[dpdk-dev] [PATCH V2 05/10] net/bnxt: fix enable/disable vlan strip

2020-01-12 Thread Kalesh A P
From: Kalesh AP HWRM_VNIC_CFG command to configure vnic dynamically with traffic running is not working. Driver has to free and recreate the vnic and then reconfigure the vnic filters. Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Signed-off-by: Kalesh AP Reviewed-by: Ajit Ku

[dpdk-dev] [PATCH V2 04/10] net/bnxt: fix enable/disable VLAN filtering

2020-01-12 Thread Kalesh A P
From: Kalesh AP There is no condition check for the user requested operation for VLAN filtering. As a result, VLAN filtering is getting disabled when the user enables/disables VLAN stripping on same port. The function bnxt_hwrm_clear_l2_filter() didn't actually free L2 filter in HW if the refere

[dpdk-dev] [PATCH V2 01/10] net/bnxt: handle flow create failure

2020-01-12 Thread Kalesh A P
From: Kalesh AP If flow create fails due to not enough filter resources, driver does not populate the rte_flow_error using rte_flow_error_set(). Since "rte_errno" could have garbage value and is not relaiable, it could cause a segfault in the stack in port_flow_complain(). Fix it to set rte_flo

[dpdk-dev] [PATCH V2 03/10] net/bnxt: fix to use correct IOVA mapping

2020-01-12 Thread Kalesh A P
From: Kalesh AP Use rte_malloc_virt2iova() to obtain the IO address of a virtual address obtained through rte_malloc(). Fixed to use the iova address returned by rte_memzone_reserve_aligned() as the call always returns with populating "mz->iova" with rte_malloc_virt2iova(mz->addr). Removed redu

[dpdk-dev] [PATCH V2 00/10] bnxt patchset with bug fixes

2020-01-12 Thread Kalesh A P
From: Kalesh AP Please apply. V1->V2: fixed the correct the commit ids in Fixes tag. Kalesh AP (8): net/bnxt: handle flow create failure net/bnxt: fix probe failure in FreeBSD net/bnxt: fix to use correct IOVA mapping net/bnxt: fix enable/disable VLAN filtering net/bnxt: fix enable/di

[dpdk-dev] [PATCH V2 02/10] net/bnxt: fix probe failure in FreeBSD

2020-01-12 Thread Kalesh A P
From: Kalesh AP In FreeBSD environment, nic_uio driver does not support interrupts and rte_intr_callback_register() will fail to register interrupts which in turn causes bnxt driver probe failure. Fixed driver to ignore interrupt callback failures in FreeBSD. Also fixed to not use a dedicated co

[dpdk-dev] [PATCH] net/octeontx2: add check for PTP and HIGIG2

2020-01-12 Thread kirankumark
From: Kiran Kumar K For octeontx2 we won't support both PTP and HIGIG2 together. Added a check to verify this. Signed-off-by: Kiran Kumar K --- drivers/net/octeontx2/otx2_ethdev.c | 9 - drivers/net/octeontx2/otx2_ptp.c| 5 + 2 files changed, 13 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH 10/10] net/bnxt: fix to cap max rings to minimum of compl rings and stat contexts

2020-01-12 Thread Kalesh A P
From: Somnath Kotur Max Tx rings count could be lesser than max Rx rings in some cases, so take this into account as well. Account for stat contexts available(one for each ring) along with no: of completion rings(one for each ring) to cap the max no: of Tx /Rx rings that can be possibly created.

[dpdk-dev] [PATCH 09/10] net/bnxt: release port upon close

2020-01-12 Thread Kalesh A P
From: Somnath Kotur Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 + 1 file ch

[dpdk-dev] [PATCH 05/10] net/bnxt: fix enable/disable vlan strip

2020-01-12 Thread Kalesh A P
From: Kalesh AP HWRM_VNIC_CFG command to configure vnic dynamically with traffic running is not working. Driver has to free and recreate the vnic and then reconfigure the vnic filters. Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Signed-off-by: Kalesh AP Reviewed-by: Ajit Ku

[dpdk-dev] [PATCH 07/10] net/bnxt: fix a memory leak in port stop

2020-01-12 Thread Kalesh A P
From: Kalesh AP The memory for mark table is allocated during port start. But the allocated memory is freed only during port close or driver unload which in turn causes a memory leakage on each port start/stop. Fixed it by moving the memory free to port stop. Fixes: 4e40794a18a7 ("net/bnxt: add

[dpdk-dev] [PATCH 04/10] net/bnxt: fix enable/disable VLAN filtering

2020-01-12 Thread Kalesh A P
From: Kalesh AP There is no condition check for the user requested operation for VLAN filtering. As a result, VLAN filtering is getting disabled when the user enables/disables VLAN stripping on same port. The function bnxt_hwrm_clear_l2_filter() didn't actually free L2 filter in HW if the refere

[dpdk-dev] [PATCH 06/10] net/bnxt: handle hw filter setting when port is stopped

2020-01-12 Thread Kalesh A P
From: Kalesh AP Driver destroy the vnic when the port is brought down. Port hw filter setting such as promiscuos, allmulti and vlan filtering will be applied when port is started. Fixed to return success silently for these callbacks when port is stopped. Also fixed to clear "bp->dev_stopped" bef

[dpdk-dev] [PATCH 08/10] net/bnxt: use macro for PCI log format

2020-01-12 Thread Kalesh A P
From: Kalesh AP Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers

[dpdk-dev] [PATCH 03/10] net/bnxt: fix to use correct IOVA mapping

2020-01-12 Thread Kalesh A P
From: Kalesh AP Use rte_malloc_virt2iova() to obtain the IO address of a virtual address obtained through rte_malloc(). Fixed to use the iova address returned by rte_memzone_reserve_aligned() as the call always returns with populating "mz->iova" with rte_malloc_virt2iova(mz->addr). Removed redu

[dpdk-dev] [PATCH 01/10] net/bnxt: handle flow create failure

2020-01-12 Thread Kalesh A P
From: Kalesh AP If flow create fails due to not enough filter resources, driver does not populate the rte_flow_error using rte_flow_error_set(). Since "rte_errno" could have garbage value and is not relaiable, it could cause a segfault in the stack in port_flow_complain(). Fix it to set rte_flo

[dpdk-dev] [PATCH 02/10] net/bnxt: fix probe failure in FreeBSD

2020-01-12 Thread Kalesh A P
From: Kalesh AP In FreeBSD environment, nic_uio driver does not support interrupts and rte_intr_callback_register() will fail to register interrupts which in turn causes bnxt driver probe failure. Fixed driver to ignore interrupt callback failures in FreeBSD. Also fixed to not use a dedicated co

[dpdk-dev] [PATCH 00/10] bnxt patch set with fixes

2020-01-12 Thread Kalesh A P
From: Kalesh AP Please apply. Kalesh AP (8): net/bnxt: handle flow create failure net/bnxt: fix probe failure in FreeBSD net/bnxt: fix to use correct IOVA mapping net/bnxt: fix enable/disable VLAN filtering net/bnxt: fix enable/disable vlan strip net/bnxt: handle hw filter setting wh

[dpdk-dev] [PATCH v4] net/virtio: packed ring notification data feature support

2020-01-12 Thread Cheng Jiang
This patch supports the feature that the driver passes extra data (besides identifying the virtqueue) in its device notifications, expanding the notifications to include the avail index and avail wrap counter. Signed-off-by: Cheng Jiang --- v4: * Replaced used_wrap_counter with avail_wrap_counte

Re: [dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-01-12 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaolong Ye > Sent: Monday, January 13, 2020 10:39 AM > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [dpdk-dev] [PATCH v4 00/36] update for i40e base code > > This series is to support FVL 7.2 release. > > The mai

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP

2020-01-12 Thread Xing, Beilei
> -Original Message- > From: Sexton, Rory > Sent: Tuesday, January 7, 2020 11:40 PM > To: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > ; adrien.mazarg...@6wind.com; or...@mellanox.com > Cc: Sexton, Rory ; Jagus, DariuszX > > Subject: [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over I

Re: [dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

2020-01-12 Thread 方统浩50450
secondary process will enter rte_eth_copy_pci_info function when initializing. rte_eth_dev_pci_copy_info -> rte_eth_copy_pci_info 发件人:Stephen Hemminger 发送日期:2020-01-10 23:32:15 收件人:Fang TongHao 抄送人:tho...@monjalon.net,ferruh.yi...@intel.com,arybche...@solarflare.com,dev@dpdk.org,sta...@dpdk.o

Re: [dpdk-dev] [DPDK] net/virtio: packed ring notification data feature support

2020-01-12 Thread Jiang, Cheng1
Hi Marvin, > -Original Message- > From: Liu, Yong > Sent: Thursday, January 9, 2020 3:29 PM > To: Jiang, Cheng1 ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; Jiang, Cheng1 > > Subject: RE: [dpdk-dev] [DPDK] net/virtio: packed ring notification data > feat

Re: [dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-01-12 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xiaolong Ye > Sent: Monday, January 13, 2020 10:39 AM > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [dpdk-dev] [PATCH v4 00/36] update for i40e base code > > This series is to support FVL 7.2 release. > > The main changes include: > > * vir

Re: [dpdk-dev] [PATCH] vhost: add protocol feature check

2020-01-12 Thread Tiwei Bie
On Wed, Dec 25, 2019 at 10:24:45PM +0800, Jin Yu wrote: > Add VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD check in > getting inflight ring functions. > > Fixes: 4d891f77ddfa ("vhost: add APIs to get inflight ring") > Cc: sta...@dpdk.org > > Signed-off-by: Jin Yu > --- > lib/librte_vhost/vhost.c | 8 ++

[dpdk-dev] [PATCH v4 36/36] net/i40e/base: add new link speed constants

2020-01-12 Thread Xiaolong Ye
This patch fixes 'NIC Link is Up, Unknown bps' message in dmesg for 2.5Gb/5Gb speeds. This problem is fixed by adding constants for VIRTCHNL_LINK_SPEED_2_5GB and VIRTCHNL_LINK_SPEED_5GB. Fixes: a58860f68929 ("net/i40e/base: use new virtchnl header file") Signed-off-by: Aleksandr Loktionov Signed

[dpdk-dev] [PATCH v4 35/36] net/i40e/base: enable LED blinking flow

2020-01-12 Thread Xiaolong Ye
Add X710T*L device specific operations (in port LED detection and handling of GLGEN_GPIO_CTL.PIN_FUNC field) to enable LED blinking. Signed-off-by: Damian Milosek Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 28 +--- drivers/net/i40e/base/i40e_dev

[dpdk-dev] [PATCH v4 29/36] net/i40e/base: removed unreachable code

2020-01-12 Thread Xiaolong Ye
The result of the check is always FALSE and the code within "if" is never executed. Signed-off-by: Dzmitry Sautsa Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/

[dpdk-dev] [PATCH v4 34/36] net/i40e/base: add CRC stripping capability

2020-01-12 Thread Xiaolong Ye
Some VFs may want to disable CRC stripping on incoming packets so create an offload for that. The VF already sends information about configuring it's RX queues so use that structure to indicate that the CRC stripping should be enabled or not. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Xiao

[dpdk-dev] [PATCH v4 31/36] net/i40e/base: implement reading lpi statistics

2020-01-12 Thread Xiaolong Ye
There was no time duration statistics for LPI (Low Power Idle) in EEE (Energy-Efficient Ethernet). Added new procedure to get duration values from FW. Otherwise there is no available procedure to get tx_lpi_duration and rx_lpi_duration values. Signed-off-by: Jaroslaw Gawin Signed-off-by: Xiaolong

[dpdk-dev] [PATCH v4 27/36] net/i40e/base: fix wrong 'Advertised FEC modes'

2020-01-12 Thread Xiaolong Ye
Fix display of FEC settings for ethtool. This patch change variable 'phy.link_info.req_fec_info' sent to ethtool. Without this patch wrong FEC settings can be shown. Fixes: 1216fb9f0c8c ("net/i40e/base: store the requested FEC information") Signed-off-by: Jaroslaw Gawin Signed-off-by: Xiaolong Y

[dpdk-dev] [PATCH v4 28/36] net/i40e/base: add Flow Director defines

2020-01-12 Thread Xiaolong Ye
Add defines for creating Flow Director flows as defined in datasheet section 7.1.5.4 for field vectors. Signed-off-by: Doug Dziggel Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_register.h | 81 +++ 1 file changed, 81 insertions(+) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v4 33/36] net/i40e/base: introduce firmware EMP reset register offsets

2020-01-12 Thread Xiaolong Ye
Introduce offsets of firmware registers holding a number of EMP resets. Implement offsets as a preprocessor's constants. Required by drivers to read a number of EMP resets reported by FW. Signed-off-by: Piotr Kwapulinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_register.h | 2 +

[dpdk-dev] [PATCH v4 30/36] net/i40e/base: set PHY Access flag on X722

2020-01-12 Thread Xiaolong Ye
The X722 FW API version 1.9 adds support for accessing PHY registers with Admin Queue Command. This enables reading EEPROM data from (Q)SFP+ transceivers, what was previously possible only on X710 devices. Signed-off-by: Adam Ludkiewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_

[dpdk-dev] [PATCH v4 32/36] net/i40e/base: exposing missing LED functionality

2020-01-12 Thread Xiaolong Ye
The previous code had the LED code wrapped such that, it was static to the file and not usable outside of it. It is now available. Signed-off-by: Rusinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 8 drivers/net/i40e/base/i40e_prototype.h | 5 - 2 file

[dpdk-dev] [PATCH v4 22/36] net/i40e/base: update FW API version

2020-01-12 Thread Xiaolong Ye
Update FW API version to 1.9. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index f6

[dpdk-dev] [PATCH v4 24/36] net/i40e/base: make i40e_set_mac_type() public

2020-01-12 Thread Xiaolong Ye
Make i40e_set_mac_type() public. i40e driver requires i40e_set_mac_type() to be public. It is required for recovery mode handling. Without this patch recovery mode could not be detected at probe() function. Signed-off-by: Piotr Kwapulinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i4

[dpdk-dev] [PATCH v4 23/36] net/i40e/base: add persistent lldp support

2020-01-12 Thread Xiaolong Ye
This patch adds a function to read nvm module data and uses it to read current lldp agent configuration from nvm api version 1.8. Signed-off-by: Wnuczko Sylwia Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_dcb.c | 20 +++- drivers/net/i40e/base/i40e_dcb.h | 5 ++ dr

[dpdk-dev] [PATCH v4 21/36] net/i40e/base: add FWS1B register masks

2020-01-12 Thread Xiaolong Ye
Function check_recovery_mode had wrong if statement. Now we check proper FWS1B register values, which are responsible for the recovery mode. Recovery mode has 6 values in total. That's why we need 6 different flags. Now in if statement we recognize type of mac and register value. Without those chan

[dpdk-dev] [PATCH v4 20/36] net/i40e/base: add drop mode parameter to set MAC config

2020-01-12 Thread Xiaolong Ye
This patch adds "drop mode" parameter to set mac config AQ command. This bit controls the behavior when a no-drop packet is blocking a TC queue. 0 – The PF driver is notified. 1 – The blocking packet is dropped and then the PF driver is notified. Signed-off-by: Wnuczko Sylwia Signed-off-by: Xiaol

[dpdk-dev] [PATCH v4 25/36] net/i40e/base: fix retrying logic

2020-01-12 Thread Xiaolong Ye
Fixed a bug where driver was breaking out of the loop and reporting an error without retrying first. Fixes: 466eec7d6b1a ("net/i40e/base: retry AQC to overcome IRCRead hangs") Signed-off-by: Marcin Formela Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 17 ++--

[dpdk-dev] [PATCH v4 26/36] net/i40e/base: mark additional missing bits as reserved

2020-01-12 Thread Xiaolong Ye
Mark bits 0xD through 0xF for the command flags of a cloud filter as reserved. These bits are not yet defined and are considered as reserved in the data sheet. Signed-off-by: Jacob Keller Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++ 1 file changed, 3 insertion

[dpdk-dev] [PATCH v4 15/36] net/i40e/base: add reading LPI counters

2020-01-12 Thread Xiaolong Ye
This change introduces new function i40e_get_lpi_counters() reading Low Power Idle (LPI) mode counters from Energy Efficient Ethernet (EEE) statistics. Since reading EEE statistics requires running DNL script, function i40e_aq_run_phy_activity() able to run it, was implemented. i40e_lpi_stat_updat

[dpdk-dev] [PATCH v4 18/36] net/i40e/base: change of the incorrect Tx descriptors number

2020-01-12 Thread Xiaolong Ye
The existing driver allows setting the number of TX descriptors to the value that is indivisible by 32. This is not properly supported by x710 hardware. The patch limits the number of TX descriptors to the whole value of 32. Signed-off-by: Doug Dziggel Signed-off-by: Dariusz Chaberski Signed-off

[dpdk-dev] [PATCH v4 14/36] net/i40e/base: change for missing "link modes"

2020-01-12 Thread Xiaolong Ye
Fix for missing "Supported link modes" and "Advertised link modes" info in ethtool after changed speed on X722 devices with BASE-T PHY with FW API version >= 1.7. The same FW API version on X710 and X722 does not mean the same feature set so the change was needed as mac type of the device should al

[dpdk-dev] [PATCH v4 19/36] net/i40e/base: extend PHY access AQ command

2020-01-12 Thread Xiaolong Ye
Currently FW use MDIO I/F number corresponded with current PF for PHY access. This code allow to specify used MDIO I/F number. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq.c | 57 +++ drivers/net/i40e/base/i40e_adminq_cm

[dpdk-dev] [PATCH v4 17/36] net/i40e/base: update status codes

2020-01-12 Thread Xiaolong Ye
Add a few new status codes and rename a few to make them more consistent. Error code are mapped to similar values as in i40e_status.h, so as to be compatible with older VF drivers not using this status enum. Signed-off-by: Mitch Williams Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virt

[dpdk-dev] [PATCH v4 16/36] net/i40e/base: backport style changes from upstream Linux

2020-01-12 Thread Xiaolong Ye
The upstream virtchnl.h has a few minor style differences to what is out-of-tree, and there is no real reason we should prefer the current style over whats upstream. Signed-off-by: Jacob Keller Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 4 ++-- 1 file changed, 2 insertion

[dpdk-dev] [PATCH v4 13/36] net/i40e/base: read LPI status from external PHY

2020-01-12 Thread Xiaolong Ye
When external PHY is used, MAC register may not reflect actual state of LPI. Add function reading it directly from PHY or MAC, depending on what is supported by the device. Signed-off-by: Krzysztof Galazka Signed-off-by: Piotr Pietruszewski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/

[dpdk-dev] [PATCH v4 06/36] net/i40e/base: further implementation of LLDP

2020-01-12 Thread Xiaolong Ye
This code implements changes necessary for LLDP Agent support. 1. Modified i40e_aq_start_lldp and i40e_aq_stop_lldp. Now Stop and Start can also be persistent across power cycles. 2. Added new function i40e_aq_restore_lldp which restores factory setting for LLDP Agent or gets its status. Signed-o

[dpdk-dev] [PATCH v4 12/36] net/i40e/base: add support for Energy Efficient Ethernet

2020-01-12 Thread Xiaolong Ye
This change adds i40e_enable_eee() function controlling advertisement of Energy Efficient Ethernet mode (EEE). Signed-off-by: Piotr Pietruszewski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 64 ++ drivers/net/i40e/base/i40e_prototype.h | 1 +

[dpdk-dev] [PATCH v4 10/36] net/i40e/base: improve AQ log granularity

2020-01-12 Thread Xiaolong Ye
This patch makes it possible to log only AQ descriptors, without the entire AQ message buffers being dumped too. It should greatly reduce kernel log size in cases where a full AQ dump is not needed. Selection is made by setting flags in hw->debug_mask. Additionally, some debug messages that preced

[dpdk-dev] [PATCH v4 11/36] net/i40e/base: add getter for FW LLDP agent status

2020-01-12 Thread Xiaolong Ye
This change introduces i40e_get_fw_lldp_status() function capable of reporting status of FW Link Layer Discovery Protocol (LLDP) agent. Since reading LLDP configuration from NVM only gives information what is the default state of FW LLDP agent after POR, this change introduces more reliable method

[dpdk-dev] [PATCH v4 08/36] net/i40e/base: add check for MAC type

2020-01-12 Thread Xiaolong Ye
Some features were introduced in different FW API version on XL710 and X722 MACs. Others are available only on specific MAC type. Make sure that they are properly assigned. Also fix the style issues reported by current check-patch. Signed-off-by: Galazka Krzysztof Signed-off-by: Xiaolong Ye ---

[dpdk-dev] [PATCH v4 09/36] net/i40e/base: adding flags for PHY types

2020-01-12 Thread Xiaolong Ye
Adding bit flags to enable/disable EEE capability for 2.5GBase-T and 5GBase-T PHY types as well as 'Set autonomous EEE for relevant enabled PHY types' flag. Signed-off-by: Doug Dziggel Signed-off-by: Michal Litwicki Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++

[dpdk-dev] [PATCH v4 07/36] net/i40e/base: add new device ids

2020-01-12 Thread Xiaolong Ye
New device ids are created to support SFP+ and backplane connections. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 ++ drivers/net/i40e/base/i40e_devids.h | 2 ++ drivers/net/i40e/i40e_ethdev.c | 2 ++ 3 files changed, 6 insertions(+

[dpdk-dev] [PATCH v4 01/36] net/i40e/base: add support for feature flags

2020-01-12 Thread Xiaolong Ye
Extend NVM Update API to support reporting of features available for the tools. This change is needed by NVM Update to determine if driver supports changing NVM layout from structured to flat. Signed-off-by: Piotr Pietruszewski Signed-off-by: Galazka Krzysztof Signed-off-by: Xiaolong Ye --- d

[dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-01-12 Thread Xiaolong Ye
This series is to support FVL 7.2 release. The main changes include: * virtchnl updates * add lldp support * Flow director updates * extend PHY access AQ cmd * add reading LPI counters * add support for Energy Efficient Ethernet * A few fixes. v4: * add a few missed Fixes tags V3: * add missi

[dpdk-dev] [PATCH v4 03/36] net/i40e/base: change buffer address

2020-01-12 Thread Xiaolong Ye
The high 32-bits were being set incorrectly in the 'Set Local LLDP MIB' AQ command (0x0A08). Change it to use the right macro to get the correct bits. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[dpdk-dev] [PATCH v4 02/36] net/i40e/base: increase max VSI count for VFs

2020-01-12 Thread Xiaolong Ye
For historical reasons, we allowed 3 VSIs per VF, but never used more than one. Now with ADq, we can use up to 4 VSIs per VF, so change this value to match. Signed-off-by: Mitch Williams Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_type.h | 2 +- 1 file changed, 1 insertion(+), 1 d

[dpdk-dev] [PATCH v4 05/36] net/i40e/base: change misleading error message

2020-01-12 Thread Xiaolong Ye
This patch changes an error code for an admin queue head overrun to use I40E_ERR_ADMIN_QUEUE_FULL instead of I40E_ERR_QUEUE_EMPTY. Signed-off-by: Carolyn Wyborny Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v4 04/36] net/i40e/base: decouple cfg_lldp_mib_change from init_dcb

2020-01-12 Thread Xiaolong Ye
There is a need to enable MIB change event, not at the same time as init_dcb. This patch will serve this requirement. Modify the i40e_init_dcb to return the correct error when LLDP or DCBX is not in operational state. Signed-off-by: Chinh T Cao Signed-off-by: Xiaolong Ye --- drivers/net/i40e/b

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix return value of tap offload sets not checked

2020-01-12 Thread Tiwei Bie
On Thu, Jan 09, 2020 at 08:18:24PM +0800, Yunjian Wang wrote: > The function vhost_kernel_tap_set_offload() could return errors, > the return value need to be checked. And there is no need to fail > when error is -ENOTSUP. > > Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before

[dpdk-dev] [PATCH RFC 0/2] TCP flow classification using 4-tuple and flags

2020-01-12 Thread Sowmini Varadhan
An interesting class of problems is TCP flow tracking and classification based on TCP state, which requires the ability to classify TCP flows on more packet properties than just the 4-tuple This patch-set investigates the set of changes needed in the examples/flow_classify.c needed to achiev

[dpdk-dev] [PATCH RFC 2/2] Allow the flow_classify example to add an ACL table for tcp.

2020-01-12 Thread Sowmini Varadhan
The struct rte_flow_classifier can have upto RTE_FLOW_CLASSIFY_TABLE_MAX (32) classifier tables, but the existing flow_classify examples only adds a single table for the L4 5-tuple. When dealing with tcp flows, we frequently want to add add ACLs and filters to filter based on the state of the TCP

[dpdk-dev] [PATCH RFC 1/2] Hooks to allow the setting of filters on tcp flags

2020-01-12 Thread Sowmini Varadhan
The rte_eth_ntuple_filter allows tcp_flags which can check for things like #define RTE_TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */ #define RTE_TCP_ECE_FLAG 0x40 /**< ECN-Echo */ #define RTE_TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */ #define RT

[dpdk-dev] [PATCH v2] net/mlx5: fix modify actions support limitation

2020-01-12 Thread Bing Zhao
In the root table, there is some limitation of total number of header modify actions, 16 or 8 for each. But in other tables, there is no such strict limitation. In an IPv6 case, the IP fields modifying will occupy more actions than that in IPv4, so the total support number should be increased in or

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API

2020-01-12 Thread Ori Kam
Hi > -Original Message- > From: Ferruh Yigit > Sent: Friday, January 10, 2020 8:26 PM > To: Rory Sexton ; dev@dpdk.org; > qi.z.zh...@intel.com; beilei.x...@intel.com; Adrien Mazarguil > ; Ori Kam > Cc: Dariusz Jagus > Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP he

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API

2020-01-12 Thread Ori Kam
> -Original Message- > From: Rory Sexton > Sent: Tuesday, January 7, 2020 5:40 PM > To: dev@dpdk.org; qi.z.zh...@intel.com; beilei.x...@intel.com; Adrien > Mazarguil ; Ori Kam > Cc: Rory Sexton ; Dariusz Jagus > > Subject: [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API >