Re: [dpdk-dev] [PATCH v3] net/ixgbe: add support for VF MAC address add and remove

2019-12-23 Thread Ye Xiaolong
On 12/24, Guinan Sun wrote: >Ixgbe PMD pf host code needs to support ixgbevf mac address >add and remove. For this purpose, a response was added >between pf and vf to update the mac address. > >Signed-off-by: Guinan Sun >--- >v3: >* Changed from `RTE_LOG` to `PMD_DRV_LOG`. >v2: >* Changed the titl

Re: [dpdk-dev] [PATCH v3] net/iavf: fix virtual channel return value error

2019-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Cao, Yahui > Sent: Tuesday, December 24, 2019 12:13 PM > To: Wu, Jingjing ; Lu, Wenzhuo > > Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; Cao, > Yahui ; Ye, Xiaolong ; Su, > Simei > Subject: [PATCH v3] net/iavf: fix virtual channel return value error >

[dpdk-dev] [PATCH v3] net/iavf: fix virtual channel return value error

2019-12-23 Thread Yahui Cao
In iavf_handle_virtchnl_msg(), it is not appropriate for _clear_cmd() to be used as a notification to forground thread. So introduce _notify_cmd() to fix this error. In addition, since _notify_cmd() contains rte_wmb(), rte_compiler_barrier() is not necessary. Sending msg from VF to PF is mainly by

[dpdk-dev] [PATCH v3] net/ixgbe: add support for VF MAC address add and remove

2019-12-23 Thread Guinan Sun
Ixgbe PMD pf host code needs to support ixgbevf mac address add and remove. For this purpose, a response was added between pf and vf to update the mac address. Signed-off-by: Guinan Sun --- v3: * Changed from `RTE_LOG` to `PMD_DRV_LOG`. v2: * Changed the title of commit message. * Checked null in

Re: [dpdk-dev] [RFC PATCH] mbuf: fix to update documentation of PKT_RX_QINQ_STRIPPED

2019-12-23 Thread Somnath Kotur
Given that we haven't heard any objection from anyone in a while on this ...can we get this in please? Thanks On Mon, Dec 16, 2019 at 2:43 PM Andrew Rybchenko wrote: > > On 12/16/19 11:47 AM, Somnath Kotur wrote: > > On Mon, Dec 16, 2019 at 12:01 PM Andrew Rybchenko > > wrote: > >> > >> On 12/1

Re: [dpdk-dev] [PATCH] net/i40e: enable multi-queue Rx interrupt for VF

2019-12-23 Thread Ye Xiaolong
On 12/24, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Cui, LunyuanX >> Sent: Tuesday, December 3, 2019 7:44 PM >> To: dev@dpdk.org >> Cc: Xing, Beilei ; Zhang, Qi Z ; >> Yang, Qiming ; Cui, LunyuanX >> >> Subject: [PATCH] net/i40e: enable multi-queue Rx interrupt for VF >> >> C

[dpdk-dev] [PATCH v4 5/5] net/e1000: cleanup Tx buffers

2019-12-23 Thread Chenxu Di
Add support to the igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a3e30dbe

[dpdk-dev] [PATCH v4 4/5] net/ixgbe: cleanup Tx buffers

2019-12-23 Thread Chenxu Di
Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 + drivers/net/ixgbe/ixgbe_rxtx.c | 121 +++ drivers/net/ixgbe/ixgbe_rxtx.h | 2 +

[dpdk-dev] [PATCH v4 2/5] net/i40e: cleanup Tx buffers

2019-12-23 Thread Chenxu Di
Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c | 122 ++

[dpdk-dev] [PATCH v4 0/5] drivers/net: cleanup Tx buffers

2019-12-23 Thread Chenxu Di
Add support to the drivers inclulding fm10k, i40e, ice, ixgbe and igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. --- v2: added code about igb vf. v3: changed information of author v4: changed code. Chenxu Di (5): net/fm10k: cleanup Tx buffers net/i40e:

[dpdk-dev] [PATCH v4 3/5] net/ice: cleanup Tx buffers

2019-12-23 Thread Chenxu Di
Add support to the ice driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 123 +++ drivers/net/ice/ice_rxtx.h | 1 + 3 files ch

[dpdk-dev] [PATCH v4 1/5] net/fm10k: cleanup Tx buffers

2019-12-23 Thread Chenxu Di
Add support to the fm10k driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/fm10k/fm10k.h| 2 ++ drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/fm10k/fm10k_rxtx.c | 45 3

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support for VF MAC address add and remove

2019-12-23 Thread Ye Xiaolong
On 12/23, Guinan Sun wrote: >Ixgbe PMD pf host code needs to support ixgbevf mac address >add and remove. For this purpose, a response was added >between pf and vf to update the mac address. > >Signed-off-by: Guinan Sun >--- >v2: >* Changed the title of commit message. >* Checked null in front of

Re: [dpdk-dev] [PATCH] net/i40e: enable multi-queue Rx interrupt for VF

2019-12-23 Thread Zhang, Qi Z
> -Original Message- > From: Cui, LunyuanX > Sent: Tuesday, December 3, 2019 7:44 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Yang, Qiming ; Cui, LunyuanX > > Subject: [PATCH] net/i40e: enable multi-queue Rx interrupt for VF > > Current implementation is that only one R

Re: [dpdk-dev] [PATCH 04/14] examples/ipsec-secgw: add Rx adapter support

2019-12-23 Thread Ananyev, Konstantin
> Add Rx adapter support. The event helper init routine will initialize > the Rx adapter according to the configuration. If Rx adapter config > is not present it will generate a default config. It will check the > available eth ports and event queues and map them 1:1. So one eth port > will be conn

Re: [dpdk-dev] [PATCH 12/14] examples/ipsec-secgw: add driver outbound worker

2019-12-23 Thread Ananyev, Konstantin
> This patch adds the driver outbound worker thread for ipsec-secgw. > In this mode the security session is a fixed one and sa update > is not done. > > Signed-off-by: Ankur Dwivedi > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik > --- > examples/ipsec-secgw/ipsec-secgw.c | 1

[dpdk-dev] rte_eth_rx_burst seems to read packets tx through the same port

2019-12-23 Thread Danushka Menikkumbura
Hi, I have a dpdk app that implements a simple run-to-completion model. I use igb_uio as my PMD. I notice a weird situation where my receiver ( rte_eth_rx_burst) seems to sporadically read packets I intend to transmit through the same port using rte_eth_tx_burst. Is this possible by any chance an

Re: [dpdk-dev] [PATCH 11/14] examples/ipsec-secgw: add app processing code

2019-12-23 Thread Ananyev, Konstantin
> > Add IPsec application processing code for event mode. > > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik > --- > examples/ipsec-secgw/ipsec-secgw.c | 124 ++ > examples/ipsec-secgw/ipsec-secgw.h | 81 > examples/ipsec-secgw/ipsec.h|

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2019-12-23 Thread Ananyev, Konstantin
> > Add eventmode support to ipsec-secgw. This uses event helper to setup > and use the eventmode capabilities. Add driver inbound worker. > > Example command: > ./ipsec-secgw -c 0x1 -w 0002:02:00.0,ipsec_in_max_spi=100 -w 0002:07:00.0 > -w 0002:0e:00.0 -w 0002:10:00.1 -- -P -p 0x3 -u 0x1 > --c

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2019-12-23 Thread Stephen Hemminger
On Mon, 23 Dec 2019 05:04:12 + Honnappa Nagarahalli wrote: > > > > > > On Sat, 21 Dec 2019 16:07:23 + > > Honnappa Nagarahalli wrote: > > > > > Converting these into macros will help remove the size based duplication > > > of > > APIs. I came up with the following macro: > > >

Re: [dpdk-dev] [PATCH 14/14] examples/ipsec-secgw: add cmd line option for bufs

2019-12-23 Thread Ananyev, Konstantin
> > Add command line option -s which can be used to configure number > > of buffers in a pool. Default number of buffers is 8192. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Lukasz Bartosik > > --- > > examples/ipsec-secgw/ipsec-secgw.c | 23 +++ > > 1 file chan

Re: [dpdk-dev] [PATCH 14/14] examples/ipsec-secgw: add cmd line option for bufs

2019-12-23 Thread Ananyev, Konstantin
> > Add command line option -s which can be used to configure number > of buffers in a pool. Default number of buffers is 8192. > > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik > --- > examples/ipsec-secgw/ipsec-secgw.c | 23 +++ > 1 file changed, 19 inser

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-23 Thread Ananyev, Konstantin
> > >>> The rte_security API which enables inline protocol/crypto > > >>> feature mandates that for every security session an rte_flow > > >>> is > > >> created. > > >>> This would internally translate to a rule in the hardware > > >>> which would do packet

[dpdk-dev] Inconsistent behavior of mempool with regards to hugepage allocation

2019-12-23 Thread Bao-Long Tran
Hi, I'm not sure if this is a bug, but I've seen an inconsistency in the behavior of DPDK with regards to hugepage allocation for rte_mempool. Basically, for the same mempool size, the number of hugepages allocated changes from run to run. Here's how I reproduce with DPDK 19.11. IOVA=pa (default

[dpdk-dev] [PATCH v2] build: explicitly enable sse4 for meson builds

2019-12-23 Thread Bruce Richardson
If the compiler does not recognise the specific CPU when building with the default "native" machine type, sse4.2 instructions can be missing, causing a build error. Rather than advising the user to change the machine type, we can just turn on SSE4.2 directly. This can prevent issues with running au

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-23 Thread Gavin Hu
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Monday, December 23, 2019 5:20 PM > To: Gavin Hu > Cc: dpdk-dev ; nd ; David Marchand > ; tho...@monjalon.net; > rasl...@mellanox.com; maxime.coque...@redhat.com; > tiwei@intel.com; hemant.agra...@nxp.com; jer...@marvell.com;

Re: [dpdk-dev] [PATCH v2] raw/ntb: fix write memory barrier issue

2019-12-23 Thread Li, Xiaoyun
Hi Still, stability and correctness are much more important than performance. As I said, with WC can benefit more than 20X perf. Comparing to this benefit, the difference between rte_wmb and rte_io_wmb is not that important. And in my test, the performance is not that bad with rte_wmb especially

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-23 Thread Jerin Jacob
On Mon, Dec 23, 2019 at 2:44 PM Gavin Hu wrote: > > Hi Jerin, Hi Gavin, > > I think we are on the same page with regard to the problem, and the > situations, thanks for illuminating the historical background of the two > barriers. > About the solution, I added inline comments. > > It will be o

[dpdk-dev] [PATCH v2] net/ixgbe: add support for VF MAC address add and remove

2019-12-23 Thread Guinan Sun
Ixgbe PMD pf host code needs to support ixgbevf mac address add and remove. For this purpose, a response was added between pf and vf to update the mac address. Signed-off-by: Guinan Sun --- v2: * Changed the title of commit message. * Checked null in front of valid ether addr check. --- drivers/

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-23 Thread Gavin Hu
Hi Jerin, I think we are on the same page with regard to the problem, and the situations, thanks for illuminating the historical background of the two barriers. About the solution, I added inline comments. > -Original Message- > From: Jerin Jacob > Sent: Friday, December 20, 2019 2:56

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2019-12-23 Thread Jerin Jacob
On Sat, Dec 21, 2019 at 9:37 PM Honnappa Nagarahalli wrote: > > > +__rte_experimental > > > +static inline uint32_t > > > +rte_get_bit32_relaxed(unsigned int nr, uint32_t *addr) { > > Why not pass the memory order as a parameter? It would reduce the number > > of API calls by half. > I think thes

Re: [dpdk-dev] [PATCH] net/ixgbe: add or remove MAC address

2019-12-23 Thread Sun, GuinanX
Hi Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Monday, December 23, 2019 3:25 PM > To: Sun, GuinanX > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > ; Xing, Beilei > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add or remove MAC address > > Hi, guinan > > For the title, be

Re: [dpdk-dev] [PATCH v2] raw/ntb: fix write memory barrier issue

2019-12-23 Thread Gavin Hu
Hi Xiaoyun, > -Original Message- > From: Li, Xiaoyun > Sent: Monday, December 23, 2019 3:52 PM > To: Gavin Hu ; Wu, Jingjing > Cc: dev@dpdk.org; Maslekar, Omkar ; > sta...@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH v2] raw/ntb: fix write memory barrier issue > > Hi > I reconsidered