Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2019-12-21 Thread Stephen Hemminger
On Sat, 21 Dec 2019 16:07:23 + Honnappa Nagarahalli wrote: > Converting these into macros will help remove the size based duplication of > APIs. I came up with the following macro: > > #define RTE_GET_BIT(nr, var, ret, memorder) \ > ({ \ > if (sizeof(var) == sizeof(uint32_t)) { \ >

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2019-12-21 Thread Stephen Hemminger
On Sat, 21 Dec 2019 16:07:23 + Honnappa Nagarahalli wrote: > Converting these into macros will help remove the size based duplication of > APIs. I came up with the following macro: > > #define RTE_GET_BIT(nr, var, ret, memorder) \ > ({ \ > if (sizeof(var) == sizeof(uint32_t)) { \ >

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2019-12-21 Thread Honnappa Nagarahalli
> > Subject: [PATCH v6 1/6] lib/eal: implement the family of rte bit > > operation APIs > > > > There are a lot functions of bit operations scattered and duplicated > > in PMDs, consolidating them into a common API family is necessary. > > Furthermore, when the bit operation is applied to the IO

[dpdk-dev] [PATCH v3 5/9] net/hns3: optimize RSS's default algorithm

2019-12-21 Thread Wei Hu (Xavier)
From: Hao Chen This patch changed the default algorithm of RSS from simle_xor to toeplitz because toeplitz is used more frequently by upper applications such as ceph. Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rss.c | 14 +++--- 1 file changed, 11

[dpdk-dev] [PATCH v3 7/9] net/hns3: remove the redundant variable initialization

2019-12-21 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch removes the redundant initialization of the variable named ret. Signed-off-by: Hongbo Zheng Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 10 +- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- 2 files chan

[dpdk-dev] [PATCH v3 8/9] net/hns3: remove the unnecessary assignment

2019-12-21 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch removes the unncessary assignment in the '.tx_pkt_burst' ops implementation function to avoid performance loss. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Yisen Zhuang --- drivers/net/hns3/hns3_rxtx.c | 12 ++-- 1 file changed, 2 insertions(+), 10

[dpdk-dev] [PATCH v3 9/9] net/hns3: remove the unused macros

2019-12-21 Thread Wei Hu (Xavier)
From: Hao Chen This patch removed some unused macros defined in hns3_rss.h, these macros are used to set tuples for abandoned RTE_ETH_FILTER_HASH in hns3_dev_filter_ctrl(). Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rss.h | 10 -- 1 file changed,

[dpdk-dev] [PATCH v3 4/9] net/hns3: modify custom macro

2019-12-21 Thread Wei Hu (Xavier)
From: Huisong Li This patch replaces custom macro named HNS3_MIN_FRAME_LEN for ethernet minimum frame length with the macro named RTE_ETHER_MIN_LEN that defined in dpdk framework. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 2 +- drivers/net/h

[dpdk-dev] [PATCH v3 1/9] net/hns3: support Rx interrupt

2019-12-21 Thread Wei Hu (Xavier)
From: Hao Chen This patch adds supports of receive packets through interrupt mode for hns3 PF/VF driver. The following ops functions should be implemented defined in the struct eth_dev_ops: rx_queue_intr_enable rx_queue_intr_disable Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier) --- v2

[dpdk-dev] [PATCH v3 6/9] net/hns3: remove the redundant function call

2019-12-21 Thread Wei Hu (Xavier)
From: Hao Chen This patch removes the redundant statement calling hns3_stats_reset() to clear statistical information explicitly in the initialization of VF device, because hardware has been reseted by FLR in the initialization and the initial hardware and software statistics values are 0. Signe

[dpdk-dev] [PATCH v3 0/9] updates for hns3 PMD driver

2019-12-21 Thread Wei Hu (Xavier)
This series are updates for hns3 ethernet PMD driver. Hao Chen (4): net/hns3: support Rx interrupt net/hns3: optimize RSS's default algorithm net/hns3: remove the redundant function call net/hns3: remove the unused macros Hongbo Zheng (1): net/hns3: get link state change through mailbox

[dpdk-dev] [PATCH v3 2/9] net/hns3: get link state change through mailbox

2019-12-21 Thread Wei Hu (Xavier)
From: Hongbo Zheng Currently, firmware adds the function of sending message to PF driver through mailbox when the link status is changed, hns3 PMD driver can usually recognize link state change faster through the message. And in some extreme cases, this way is not faster than existing method reg

[dpdk-dev] [PATCH v3 3/9] net/hns3: modify the return value of enable msix

2019-12-21 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch replaces the return value "-1" with "-ENXIO". Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c index