[dpdk-dev] [PATCH] bus/pci: restricted bus scanning to allowed devices

2019-12-15 Thread Sunil Kumar Kori
rte_bus_scan API scans all the available PCI devices irrespective of white or black listing parameters then further devices are probed based on white or black listing parameters. So unnecessary CPU cycles are wasted during rte_pci_scan. For Octeontx2 platform with core frequency 2.4 Ghz, rte_bus_s

Re: [dpdk-dev] [RFC v3 1/2] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-15 Thread Ori Kam
> -Original Message- > From: Suanming Mou > Sent: Monday, December 16, 2019 5:42 AM > To: Adrien Mazarguil ; Wenzhuo Lu > ; Jingjing Wu ; Bernard > Iremonger ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Ferruh Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org; Shahaf Shuler

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

2019-12-15 Thread Jerin Jacob
On Mon, Dec 9, 2019 at 2:47 PM Andrew Rybchenko wrote: > > On 12/5/19 11:12 AM, Jerin Jacob wrote: > > On Mon, Dec 2, 2019 at 5:27 PM Andrew Rybchenko > > wrote: > >> >> >>> > >>> Ack. > >> > >> Yes, I agree as well, but in general we already have an > >> exception MBUF_FAST_FREE which is just

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix application crash.

2019-12-15 Thread Savinay Dharmappa
if algo is NULL set the status to error and return. This change prevent crashing of ipsec-secgw application when a specific cipher/auth/aead algo are not supported by application. Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") Signed-off-by: Savinay Dharmappa Acked-by:

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2019-12-15 Thread Suanming Mou
> -Original Message- > From: Tonghao Zhang > Sent: Monday, December 16, 2019 9:29 AM > To: Matan Azrad ; Shahaf Shuler > > Cc: dev@dpdk.org; Suanming Mou > Subject: Re: [PATCH v2] net/mlx5: avoid crash when meter action conf is > NULL > > On Fri, Dec 13, 2019 at 10:21 PM wrote: > > >

Re: [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked

2019-12-15 Thread wangyunjian
> -Original Message- > From: Tiwei Bie [mailto:tiwei@intel.com] > Sent: Monday, December 16, 2019 1:33 PM > To: wangyunjian > Cc: dev@dpdk.org; maxime.coque...@redhat.com; zhihong.w...@intel.com; > xudingke ; sta...@dpdk.org > Subject: Re: [PATCH] net/vhost: fix return value of vhost

Re: [dpdk-dev] [RFC PATCH] mbuf: fix to update documentation of PKT_RX_QINQ_STRIPPED

2019-12-15 Thread Andrew Rybchenko
On 12/16/19 6:16 AM, Somnath Kotur wrote: > Certain hardware may be able to strip and/or save only the outermost > VLAN instead of both the VLANs in the mbuf in a QinQ scenario. > To handle such cases, we could re-interpret setting of just > PKT_RX_QINQ_STRIPPED > to indicate that only the outermo

Re: [dpdk-dev] [PATCH v2] net/virtio: add link speed tuning

2019-12-15 Thread Tiwei Bie
On Fri, Dec 13, 2019 at 08:39:11PM +0300, Ivan Dyukov wrote: > Hi Maxime, > Thank you for comments. > > > 13.12.2019 17:59, Maxime Coquelin пишет: > > Hi Ivan, > > > > On 12/13/19 3:44 PM, Ivan Dyukov wrote: > >> Some applications like pktgen use link_speed to calculate transmit > >> rate. It lim

Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system

2019-12-15 Thread Tiwei Bie
On Wed, Dec 04, 2019 at 04:07:29PM +0100, Adrian Moreno wrote: > Currently there are a couple of limitations on the logging system: Most > of the logs are compiled out and both datapath and controlpath logs > share the same loglevel. > > This patch tries to help fix that situation by: > - Splittin

Re: [dpdk-dev] [PATCH] net/virtio-user: fix return value of tap offload sets not checked

2019-12-15 Thread Tiwei Bie
On Mon, Dec 16, 2019 at 09:03:15AM +0800, Yunjian Wang wrote: > The function vhost_kernel_tap_set_offload() could return errors, > the return value need to be checked. > > Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjia

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: set RSS based on device capabilities

2019-12-15 Thread Jerin Jacob
On Mon, Dec 16, 2019 at 11:07 AM wrote: > > From: Pavan Nikhilesh > > Setup RSS configuration based on underlying device capabilities. > > Signed-off-by: Satananda Burla > Signed-off-by: Pavan Nikhilesh > --- Please add Fixes: and cc stable as well as it is a fix for the bug. > examples/l2

[dpdk-dev] [PATCH] examples/l2fwd-event: set RSS based on device capabilities

2019-12-15 Thread pbhagavatula
From: Pavan Nikhilesh Setup RSS configuration based on underlying device capabilities. Signed-off-by: Satananda Burla Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_common.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/examples/l2fwd-event/l2fwd_common.c b/

Re: [dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked

2019-12-15 Thread Tiwei Bie
On Mon, Dec 16, 2019 at 09:05:59AM +0800, Yunjian Wang wrote: > The function eth_dev_vhost_create() could return errors, > the return value need to be checked. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang > --- > drive

Re: [dpdk-dev] [PATCH] net/i40e: fix flow control broken

2019-12-15 Thread Ye Xiaolong
On 12/16, Ye Xiaolong wrote: >On 12/06, Guinan Sun wrote: >>Repeat switching flow control on or off during receiving traffic, >>testpmd reports "failed to switch Tx queue occurs" after quit. >>The patch fixes the issue. >> >>Fixes: f53577f06925 ("i40e: support flow control") >>Cc: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH] net/i40e: fix flow control broken

2019-12-15 Thread Ye Xiaolong
On 12/06, Guinan Sun wrote: >Repeat switching flow control on or off during receiving traffic, >testpmd reports "failed to switch Tx queue occurs" after quit. >The patch fixes the issue. > >Fixes: f53577f06925 ("i40e: support flow control") >Cc: sta...@dpdk.org > >Signed-off-by: Guinan Sun >--- >

Re: [dpdk-dev] [PATCH v3] vhost: add config change slave msg support

2019-12-15 Thread Tiwei Bie
On Thu, Dec 05, 2019 at 01:38:33PM +0800, Li Feng wrote: > This msg is used to notify qemu that should get the config of backend. > > For example, vhost-user-blk uses this msg to notify guest os the > compacity of backend has changed. capacity? > > Signed-off-by: Li Feng > --- > v3: > * Move t

Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition

2019-12-15 Thread Jerin Jacob
On Fri, Dec 13, 2019 at 8:14 AM Xiaojun Liu wrote: > > 1. FM10K is the i2c master, the PCA9545/PCA9505/PCA9538 are the slave. > 2. All the i2c slave connect on board to FM10K SoC. > 3. To control the PHY and LED Yes. These are onboard devices, so it makes sense to segregate code for i2c master(in

[dpdk-dev] [RFC v3 2/2] net/mlx5: add IPv4/IPv6 DSCP rewrite action

2019-12-15 Thread Suanming Mou
This commit add the IPv4/IPv6 DSCP rewrite actions to the PMD code. Supported actions: RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.h| 6 +- drivers/net/mlx5/mlx5_flow_dv.c | 178 ++

[dpdk-dev] [RFC v3 1/2] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-15 Thread Suanming Mou
For some overlay network, such as VXLAN, the DSCP field in the new outer IP header after VXLAN decapsulation may need to be updated accordingly. This commit introduce the DSCP modify action for IPv4 and IPv6. Signed-off-by: Suanming Mou Acked-by: Andrew Rybchenko --- v3: * Add testpmd code.

[dpdk-dev] [RFC PATCH] mbuf: fix to update documentation of PKT_RX_QINQ_STRIPPED

2019-12-15 Thread Somnath Kotur
Certain hardware may be able to strip and/or save only the outermost VLAN instead of both the VLANs in the mbuf in a QinQ scenario. To handle such cases, we could re-interpret setting of just PKT_RX_QINQ_STRIPPED to indicate that only the outermost VLAN has been stripped by the hardware and saved i

[dpdk-dev] [PATCH v4] doc: introduce openwrt how-to guide

2019-12-15 Thread Xiaolong Ye
This doc describes how to enable DPDK on openwrt in both virtual and physical x86 environment. Signed-off-by: Xiaolong Ye --- V4 changes: 1. add release notes V3 changes: 1. emphasize target select in `OpenWrt configuration` section V2 changes: 1. add meson build steps for dpdk 2. replace s

[dpdk-dev] [PATCH v3 35/36] net/i40e/base: enable LED blinking flow

2019-12-15 Thread Xiaolong Ye
Add X710T*L device specific operations (in port LED detection and handling of GLGEN_GPIO_CTL.PIN_FUNC field) to enable LED blinking. Signed-off-by: Damian Milosek Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 28 +--- drivers/net/i40e/base/i40e_dev

[dpdk-dev] [PATCH v3 31/36] net/i40e/base: implement reading lpi statistics

2019-12-15 Thread Xiaolong Ye
There was no time duration statistics for LPI (Low Power Idle) in EEE (Energy-Efficient Ethernet). Added new procedure to get duration values from FW. Otherwise there is no available procedure to get tx_lpi_duration and rx_lpi_duration values. Signed-off-by: Jaroslaw Gawin Signed-off-by: Xiaolong

[dpdk-dev] [PATCH v3 36/36] net/i40e/base: add new link speed constants

2019-12-15 Thread Xiaolong Ye
This patch fixes 'NIC Link is Up, Unknown bps' message in dmesg for 2.5Gb/5Gb speeds. This problem is fixed by adding constants for VIRTCHNL_LINK_SPEED_2_5GB and VIRTCHNL_LINK_SPEED_5GB. Signed-off-by: Aleksandr Loktionov Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_prototype.h | 4

[dpdk-dev] [PATCH v3 33/36] net/i40e/base: introduce firmware EMP reset register offsets

2019-12-15 Thread Xiaolong Ye
Introduce offsets of firmware registers holding a number of EMP resets. Implement offsets as a preprocessor's constants. Required by drivers to read a number of EMP resets reported by FW. Signed-off-by: Piotr Kwapulinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_register.h | 2 +

[dpdk-dev] [PATCH v3 32/36] net/i40e/base: exposing missing LED functionality

2019-12-15 Thread Xiaolong Ye
The previous code had the LED code wrapped such that, it was static to the file and not usable outside of it. It is now available. Signed-off-by: Rusinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 8 drivers/net/i40e/base/i40e_prototype.h | 5 - 2 file

[dpdk-dev] [PATCH v3 34/36] net/i40e/base: add CRC stripping capability

2019-12-15 Thread Xiaolong Ye
Some VFs may want to disable CRC stripping on incoming packets so create an offload for that. The VF already sends information about configuring it's RX queues so use that structure to indicate that the CRC stripping should be enabled or not. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Xiao

[dpdk-dev] [PATCH v3 24/36] net/i40e/base: make i40e_set_mac_type() public

2019-12-15 Thread Xiaolong Ye
Make i40e_set_mac_type() public. i40e driver requires i40e_set_mac_type() to be public. It is required for recovery mode handling. Without this patch recovery mode could not be detected at probe() function. Signed-off-by: Piotr Kwapulinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i4

[dpdk-dev] [PATCH v3 29/36] net/i40e/base: removed unreachable code

2019-12-15 Thread Xiaolong Ye
The result of the check is always FALSE and the code within "if" is never executed. Signed-off-by: Dzmitry Sautsa Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/

[dpdk-dev] [PATCH v3 26/36] net/i40e/base: mark additional missing bits as reserved

2019-12-15 Thread Xiaolong Ye
Mark bits 0xD through 0xF for the command flags of a cloud filter as reserved. These bits are not yet defined and are considered as reserved in the data sheet. Signed-off-by: Jacob Keller Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++ 1 file changed, 3 insertion

[dpdk-dev] [PATCH v3 27/36] net/i40e/base: change wrong 'Advertised FEC modes'

2019-12-15 Thread Xiaolong Ye
Fix display of FEC settings for ethtool. This patch change variable 'phy.link_info.req_fec_info' sent to ethtool. Without this patch wrong FEC settings can be shown. Signed-off-by: Jaroslaw Gawin Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 13 ++--- 1 file chang

[dpdk-dev] [PATCH v3 28/36] net/i40e/base: add Flow Director defines

2019-12-15 Thread Xiaolong Ye
Add defines for creating Flow Director flows as defined in datasheet section 7.1.5.4 for field vectors. Signed-off-by: Doug Dziggel Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_register.h | 81 +++ 1 file changed, 81 insertions(+) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v3 30/36] net/i40e/base: set PHY Access flag on X722

2019-12-15 Thread Xiaolong Ye
The X722 FW API version 1.9 adds support for accessing PHY registers with Admin Queue Command. This enables reading EEPROM data from (Q)SFP+ transceivers, what was previously possible only on X710 devices. Signed-off-by: Adam Ludkiewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_

[dpdk-dev] [PATCH v3 25/36] net/i40e/base: change retrying logic

2019-12-15 Thread Xiaolong Ye
Fixed a bug where driver was breaking out of the loop and reporting an error without retrying first. Signed-off-by: Marcin Formela Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v3 23/36] net/i40e/base: add persistent lldp support

2019-12-15 Thread Xiaolong Ye
This patch adds a function to read nvm module data and uses it to read current lldp agent configuration from nvm api version 1.8. Signed-off-by: Wnuczko Sylwia Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_dcb.c | 20 +++- drivers/net/i40e/base/i40e_dcb.h | 5 ++ dr

[dpdk-dev] [PATCH v3 20/36] net/i40e/base: add drop mode parameter to set MAC config

2019-12-15 Thread Xiaolong Ye
This patch adds "drop mode" parameter to set mac config AQ command. This bit controls the behavior when a no-drop packet is blocking a TC queue. 0 – The PF driver is notified. 1 – The blocking packet is dropped and then the PF driver is notified. Signed-off-by: Wnuczko Sylwia Signed-off-by: Xiaol

[dpdk-dev] [PATCH v3 17/36] net/i40e/base: update status codes

2019-12-15 Thread Xiaolong Ye
Add a few new status codes and rename a few to make them more consistent. Error code are mapped to similar values as in i40e_status.h, so as to be compatible with older VF drivers not using this status enum. Signed-off-by: Mitch Williams Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virt

[dpdk-dev] [PATCH v3 18/36] net/i40e/base: change of the incorrect Tx descriptors number

2019-12-15 Thread Xiaolong Ye
The existing driver allows setting the number of TX descriptors to the value that is indivisible by 32. This is not properly supported by x710 hardware. The patch limits the number of TX descriptors to the whole value of 32. Signed-off-by: Doug Dziggel Signed-off-by: Dariusz Chaberski Signed-off

[dpdk-dev] [PATCH v3 19/36] net/i40e/base: extend PHY access AQ command

2019-12-15 Thread Xiaolong Ye
Currently FW use MDIO I/F number corresponded with current PF for PHY access. This code allow to specify used MDIO I/F number. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq.c | 57 +++ drivers/net/i40e/base/i40e_adminq_cm

[dpdk-dev] [PATCH v3 21/36] net/i40e/base: add FWS1B register masks

2019-12-15 Thread Xiaolong Ye
Function check_recovery_mode had wrong if statement. Now we check proper FWS1B register values, which are responsible for the recovery mode. Recovery mode has 6 values in total. That's why we need 6 different flags. Now in if statement we recognize type of mac and register value. Without those chan

[dpdk-dev] [PATCH v3 22/36] net/i40e/base: update FW API version

2019-12-15 Thread Xiaolong Ye
Update FW API version to 1.9. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index f6

[dpdk-dev] [PATCH v3 13/36] net/i40e/base: read LPI status from external PHY

2019-12-15 Thread Xiaolong Ye
When external PHY is used, MAC register may not reflect actual state of LPI. Add function reading it directly from PHY or MAC, depending on what is supported by the device. Signed-off-by: Krzysztof Galazka Signed-off-by: Piotr Pietruszewski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/

[dpdk-dev] [PATCH v3 14/36] net/i40e/base: change for missing "link modes"

2019-12-15 Thread Xiaolong Ye
Fix for missing "Supported link modes" and "Advertised link modes" info in ethtool after changed speed on X722 devices with BASE-T PHY with FW API version >= 1.7. The same FW API version on X710 and X722 does not mean the same feature set so the change was needed as mac type of the device should al

[dpdk-dev] [PATCH v3 10/36] net/i40e/base: improve AQ log granularity

2019-12-15 Thread Xiaolong Ye
This patch makes it possible to log only AQ descriptors, without the entire AQ message buffers being dumped too. It should greatly reduce kernel log size in cases where a full AQ dump is not needed. Selection is made by setting flags in hw->debug_mask. Additionally, some debug messages that preced

[dpdk-dev] [PATCH v3 16/36] net/i40e/base: backport style changes from upstream Linux

2019-12-15 Thread Xiaolong Ye
The upstream virtchnl.h has a few minor style differences to what is out-of-tree, and there is no real reason we should prefer the current style over whats upstream. Signed-off-by: Jacob Keller Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 4 ++-- 1 file changed, 2 insertion

[dpdk-dev] [PATCH v3 11/36] net/i40e/base: add getter for FW LLDP agent status

2019-12-15 Thread Xiaolong Ye
This change introduces i40e_get_fw_lldp_status() function capable of reporting status of FW Link Layer Discovery Protocol (LLDP) agent. Since reading LLDP configuration from NVM only gives information what is the default state of FW LLDP agent after POR, this change introduces more reliable method

[dpdk-dev] [PATCH v3 15/36] net/i40e/base: add reading LPI counters

2019-12-15 Thread Xiaolong Ye
This change introduces new function i40e_get_lpi_counters() reading Low Power Idle (LPI) mode counters from Energy Efficient Ethernet (EEE) statistics. Since reading EEE statistics requires running DNL script, function i40e_aq_run_phy_activity() able to run it, was implemented. i40e_lpi_stat_updat

[dpdk-dev] [PATCH v3 12/36] net/i40e/base: add support for Energy Efficient Ethernet

2019-12-15 Thread Xiaolong Ye
This change adds i40e_enable_eee() function controlling advertisement of Energy Efficient Ethernet mode (EEE). Signed-off-by: Piotr Pietruszewski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c| 64 ++ drivers/net/i40e/base/i40e_prototype.h | 1 +

[dpdk-dev] [PATCH v3 09/36] net/i40e/base: adding flags for PHY types

2019-12-15 Thread Xiaolong Ye
Adding bit flags to enable/disable EEE capability for 2.5GBase-T and 5GBase-T PHY types as well as 'Set autonomous EEE for relevant enabled PHY types' flag. Signed-off-by: Doug Dziggel Signed-off-by: Michal Litwicki Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +++

[dpdk-dev] [PATCH v3 04/36] net/i40e/base: decouple cfg_lldp_mib_change from init_dcb

2019-12-15 Thread Xiaolong Ye
There is a need to enable MIB change event, not at the same time as init_dcb. This patch will serve this requirement. Modify the i40e_init_dcb to return the correct error when LLDP or DCBX is not in operational state. Signed-off-by: Chinh T Cao Signed-off-by: Xiaolong Ye --- drivers/net/i40e/b

[dpdk-dev] [PATCH v3 08/36] net/i40e/base: add check for MAC type

2019-12-15 Thread Xiaolong Ye
Some features were introduced in different FW API version on XL710 and X722 MACs. Others are available only on specific MAC type. Make sure that they are properly assigned. Also fix the style issues reported by current check-patch. Signed-off-by: Galazka Krzysztof Signed-off-by: Xiaolong Ye ---

[dpdk-dev] [PATCH v3 07/36] net/i40e/base: add new device ids

2019-12-15 Thread Xiaolong Ye
New device ids are created to support SFP+ and backplane connections. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 ++ drivers/net/i40e/base/i40e_devids.h | 2 ++ drivers/net/i40e/i40e_ethdev.c | 2 ++ 3 files changed, 6 insertions(+

[dpdk-dev] [PATCH v3 05/36] net/i40e/base: change misleading error message

2019-12-15 Thread Xiaolong Ye
This patch changes an error code for an admin queue head overrun to use I40E_ERR_ADMIN_QUEUE_FULL instead of I40E_ERR_QUEUE_EMPTY. Signed-off-by: Carolyn Wyborny Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_adminq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v3 06/36] net/i40e/base: further implementation of LLDP

2019-12-15 Thread Xiaolong Ye
This code implements changes necessary for LLDP Agent support. 1. Modified i40e_aq_start_lldp and i40e_aq_stop_lldp. Now Stop and Start can also be persistent across power cycles. 2. Added new function i40e_aq_restore_lldp which restores factory setting for LLDP Agent or gets its status. Signed-o

[dpdk-dev] [PATCH v3 03/36] net/i40e/base: change buffer address

2019-12-15 Thread Xiaolong Ye
The high 32-bits were being set incorrectly in the 'Set Local LLDP MIB' AQ command (0x0A08). Change it to use the right macro to get the correct bits. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[dpdk-dev] [PATCH v3 02/36] net/i40e/base: increase max VSI count for VFs

2019-12-15 Thread Xiaolong Ye
For historical reasons, we allowed 3 VSIs per VF, but never used more than one. Now with ADq, we can use up to 4 VSIs per VF, so change this value to match. Signed-off-by: Mitch Williams Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_type.h | 2 +- 1 file changed, 1 insertion(+), 1 d

[dpdk-dev] [PATCH v3 01/36] net/i40e/base: add support for feature flags

2019-12-15 Thread Xiaolong Ye
Extend NVM Update API to support reporting of features available for the tools. This change is needed by NVM Update to determine if driver supports changing NVM layout from structured to flat. Signed-off-by: Piotr Pietruszewski Signed-off-by: Galazka Krzysztof Signed-off-by: Xiaolong Ye --- d

[dpdk-dev] [PATCH v3 00/36] update for i40e base code

2019-12-15 Thread Xiaolong Ye
This series is to support FVL 7.2 release. The main changes include: * virtchnl updates * add lldp support * Flow director updates * extend PHY access AQ cmd * add reading LPI counters * add support for Energy Efficient Ethernet * A few fixes. V3: * add missing SOBs V2: * strip some unnecessa

[dpdk-dev] [PATCH v3] net/ixgbe: fix port can not link up in FreeBSD

2019-12-15 Thread Lunyuan Cui
In FreeBSD environment, nic_uio drivers do not support interrupts, rte_intr_callback_register() will fail to register interrupts. We can not make link status to change from down to up by interrupt callback. So we need to wait for the controller to acquire link when ports start. Through multiple tes

[dpdk-dev] [PATCH v2] raw/ntb: fix write memory barrier issue

2019-12-15 Thread Xiaoyun Li
All buffers and ring info should be written before tail register update. This patch relocates the write memory barrier before updating tail register to avoid potential issues. Fixes: 11b5c7daf019 ("raw/ntb: add enqueue and dequeue functions") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- v2:

Re: [dpdk-dev] [PATCH] raw/ntb: fix write memory barrier issue

2019-12-15 Thread Li, Xiaoyun
Didn't notice that. Will fix it in v2. Thanks! > -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Saturday, December 14, 2019 23:30 > To: Li, Xiaoyun ; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH] raw/n

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2019-12-15 Thread Tonghao Zhang
On Fri, Dec 13, 2019 at 10:21 PM wrote: > > From: Tonghao Zhang > > When offloading the meter, should check the action > conf and make sure it is valid. > > Fixes: f46bf7488705 ("net/mlx5: support meter flow action") > Cc: Suanming Mou > > Signed-off-by: Tonghao Zhang > --- > v2: coding style i

[dpdk-dev] [PATCH] net/vhost: fix return value of vhost creates not checked

2019-12-15 Thread Yunjian Wang
The function eth_dev_vhost_create() could return errors, the return value need to be checked. Fixes: ee584e9710b9 ("vhost: add driver on top of the library") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/vhost/rte_eth_vhost.c | 6 -- 1 file changed, 4 insertions(+), 2 dele

[dpdk-dev] [PATCH] net/virtio-user: fix return value of tap offload sets not checked

2019-12-15 Thread Yunjian Wang
The function vhost_kernel_tap_set_offload() could return errors, the return value need to be checked. Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 3 ++- 1 fi

[dpdk-dev] Intel platform guide

2019-12-15 Thread Thomas Monjalon
Hi, I am reading the Linux guide which has a section about Intel platform: http://doc.dpdk.org/guides/linux_gsg/nic_perf_intel_platform.html After more thoughts, I think it would be better to have such information in the platform guide: http://doc.dpdk.org/guides/platform/index.html I guess a

Re: [dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues

2019-12-15 Thread Raslan Darawsheh
Please be noted that only the first two patches where applied from this series, The last patch is not needed anymore. Also Added Cc: sta...@dpdk.org to the commits. Kindest regards, Raslan Darawsheh > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Sunday, December

Re: [dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues

2019-12-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of > xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when > setting hairpin queues > > From: Tonghao Z

Re: [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment

2019-12-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of > xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant > assignment > > From: Tonghao Zhang > >