Re: [dpdk-dev] seeing a problem dpdk startup

2019-11-27 Thread Venumadhav Josyula
Hi Hui, I understand that and we are exploring that. But is there no work around there where in it defaults to igb_uio driver something like that. Basic idea is we should not be situation of no port detected at all under this situation ? Thanks, Regards, Venu On Thu, 28 Nov 2019 at 13:15, H

Re: [dpdk-dev] seeing a problem dpdk startup

2019-11-27 Thread Hui Wei
>We are seeing following error, no device is detected >== >EAL: Detected 8 lcore(s) >EAL: Detected 2 NUMA nodes >EAL: Multi-process socket /var/run/dpdk/rte/mp_socket >EAL: No free hugepages reported in hugepages-1048576kB >EAL: Probing VFIO support... >EAL: VFIO support initialized >E

Re: [dpdk-dev] seeing a problem dpdk startup

2019-11-27 Thread Venumadhav Josyula
Hi Gavin, It is [root@localhost scripts]# ./dpdk-devbind.py --status-dev net Network devices using DPDK-compatible driver :04:00.0 'Ethernet Controller 10-Gigabit X540-AT2 1528' drv=vfio-pci unused=ixgbe :04:00.1 'Ethernet Controller 10-Gigabit

Re: [dpdk-dev] seeing a problem dpdk startup

2019-11-27 Thread Gavin Hu (Arm Technology China)
Hi Venumadhav, > -Original Message- > From: dev On Behalf Of Venumadhav Josyula > Sent: Thursday, November 28, 2019 3:01 PM > To: dev@dpdk.org; us...@dpdk.org > Cc: Venumadhav Josyula > Subject: [dpdk-dev] seeing a problem dpdk startup > > We are seeing following error, no device is det

[dpdk-dev] [PATCH v2 1/3] config: set the pkgconfig executable

2019-11-27 Thread Ali Alnubani
Meson fails to find a pkg-config executable if pkgconfig isn't set for aarch64. The environment variable `PKG_CONFIG_PATH` is useless in this case, and meson fails to locate dependencies that are built in non-standard paths. Signed-off-by: Ali Alnubani Acked-by: Bruce Richardson --- v2: added an

[dpdk-dev] [PATCH v2 3/3] ci: add pkg-config-aarch64-linux-gnu to aarch64_packages

2019-11-27 Thread Ali Alnubani
The aarch64 cross-files are configured to explicitly use the binary 'aarch64-linux-gnu-pkg-config', which is available in the package 'pkg-config-aarch64-linux-gnu' in ubuntu. Signed-off-by: Ali Alnubani --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.

[dpdk-dev] [PATCH v2 2/3] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-27 Thread Ali Alnubani
The package pkg-config-aarch64-linux-gnu is required with meson for detecting dependencies installed in nonstandard paths. Signed-off-by: Ali Alnubani Acked-by: Bruce Richardson --- v2: added an additional patch to the series. doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 8 1

[dpdk-dev] [PATCH v2] add top level SPDX license identifier.

2019-11-27 Thread Hemant Agrawal
This patch adds top level SPDX license identifiers for some of the dpdk source and scripts, where the copyright owners have not yet agreed to replace the full BSD-3 license plate. This patch also add SPDX license tag for some of files with no previous license plates. (DPDK is BSD-3) Signed-off-by

[dpdk-dev] seeing a problem dpdk startup

2019-11-27 Thread Venumadhav Josyula
We are seeing following error, no device is detected == EAL: Detected 8 lcore(s) EAL: Detected 2 NUMA nodes EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: No free hugepages reported in hugepages-1048576kB EAL: Probing VFIO support... EAL: VFIO support initialized EAL: PCI de

[dpdk-dev] [PATCH v5 5/6] net/qede: use common rte bit operation APIs instead

2019-11-27 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/qede/base/bcm_osal.c | 20 drivers/net/qede/base/bcm_osal.h | 10 -- 2 files changed, 4 insertions

[dpdk-dev] [PATCH v5 6/6] net/hinic: use common rte bit operation APIs instead

2019-11-27 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/hinic/Makefile| 1 + drivers/net/hinic/base/hinic_compat.h | 33 + drivers/net/hin

[dpdk-dev] [PATCH v5 4/6] net/bnx2x: use common rte bit operation APIs instead

2019-11-27 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/bnx2x/bnx2x.c| 209 +++ drivers/net/bnx2x/bnx2x.h| 4 - drivers/net/bnx2x/eco

[dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bit operation APIs instead

2019-11-27 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/axgbe/axgbe_common.h | 29 + drivers/net/axgbe/axgbe_ethdev.c | 14 +++--- drivers/net/axgb

[dpdk-dev] [PATCH v5 2/6] test/bitops: add bit operation test case

2019-11-27 Thread Joyce Kong
Add test cases for set bit, clear bit, test and set bit, test and clear bit operations. Change-Id: I5a00e885ea8455636c11cb9455b7e6102c9312b4 Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test

[dpdk-dev] [PATCH v5 0/6] implement common rte bit operation APIs in PMDs

2019-11-27 Thread Joyce Kong
There are a lot functions of bit operations scattered in PMDs, consolidate them into a common API family and applied in different PMDs to reduce code duplication. v5: Correct the spelling mistake in test_bitops.c v4: Introduce uint32_t/uint64_t *addr when definiting bit operation APIs(suggest

[dpdk-dev] [PATCH v5 1/6] lib/eal: implement the family of rte bit operation APIs

2019-11-27 Thread Joyce Kong
There are a lot functions of bit operations scattered and duplicated in PMDs, consolidating them into a common API family is necessary. Furthermore, when the bit operation is applied to the IO devices, use __ATOMIC_ACQ_REL to ensure the ordering for io bit operation. Signed-off-by: Joyce Kong Rev

[dpdk-dev] [PATCH v3] doc: update cross build tool version

2019-11-27 Thread Joyce Kong
Update the cross build tool version to gcc8.3. Fixes: 01add9da25cd ("doc: add cross compiling guide") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- v3: 1. Remove the fix for numactl issue, Ali Alnubani has a similar fix http://patches.dpdk.org/patch/63355/. 2. Some m

Re: [dpdk-dev] [PATCH] doc: use the latest numactl release

2019-11-27 Thread Gavin Hu (Arm Technology China)
Acked-by: Gavin Hu

Re: [dpdk-dev] [PATCH] doc: use the latest numactl release

2019-11-27 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Ali Alnubani > Sent: Wednesday, November 27, 2019 23:23 > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Joyce Kong > (Arm Technology China) ; Ruifeng Wang (Arm > Technology China) > Subject: [PATCH] doc: use the latest numactl release > > Previou

Re: [dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

2019-11-27 Thread Thomas Monjalon
08/11/2019 05:00, Stephen Hemminger: > On Thu, 7 Nov 2019 14:37:43 -0600 > Allain Legacy wrote: > > > Replacing full license text with SPDX tag. > > > > Signed-off-by: Allain Legacy > > Thanks > Acked-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH] doc: Update license text to SPDX format

2019-11-27 Thread Thomas Monjalon
30/08/2019 05:57, Tetsuya Mukawa: > Signed-off-by: Tetsuya Mukawa > --- > doc/guides/nics/vhost.rst | 31 ++- > 1 files changed, 2 insertions(+), 29 deletions(-) Applied, thanks

Re: [dpdk-dev] [PATCH 2/7] reciprocal: remove redundant boilerplate

2019-11-27 Thread Thomas Monjalon
25/09/2019 17:51, Stephen Hemminger: > No need for extra language, coverd by SPDX tag. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH 1/7] uuid: remove BSD boilerplate

2019-11-27 Thread Thomas Monjalon
25/09/2019 17:51, Stephen Hemminger: > License type is already clear from SPDX tag. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] usertools/dpdk-telemetry-client: fix typo in SPDX tag

2019-11-27 Thread Thomas Monjalon
08/11/2019 15:45, Kevin Traynor: > On 08/11/2019 14:26, Bruce Richardson wrote: > > There is a typo in the SPDX tag, which is down as an "SPDK" tag. > > One-character change should be all that is needed. > > > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > > Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH 4/7] kni: add SPDX license tag

2019-11-27 Thread Thomas Monjalon
26/09/2019 09:39, Hemant Agrawal: > ++ Ethan Zhuang . > Acked-by: Hemant Agrawal Already acked (and merged) from another series.

Re: [dpdk-dev] [PATCH v2 09/11] port: replace license text with SPDX tag

2019-11-27 Thread Thomas Monjalon
30/09/2019 18:05, Yigit, Ferruh: > On 7/29/2019 12:15 PM, Ferruh Yigit wrote: > > On 7/26/2019 5:43 PM, Xiaolong Ye wrote: > >> Signed-off-by: Xiaolong Ye > >> Acked-by: Bruce Richardson > > > > Hi Ethan, > > > > Can you please check this patch, this is switching license representation > > (no

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: add missing SPDX license header

2019-11-27 Thread Thomas Monjalon
11/11/2019 14:21, Pavan Nikhilesh Bhagavatula: > >Add same tag as other files in this example. > > > >Signed-off-by: Stephen Hemminger > > Acked-by: Pavan Nikhilesh Applied, thanks

Re: [dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq

2019-11-27 Thread Tonghao Zhang
On Wed, Nov 27, 2019 at 10:52 PM Ori Kam wrote: > > This patch is not correct, > You are using old code. This was already solved. Thanks for your review, and tips > Thanks, > Ori > > > -Original Message- > > From: xiangxia.m@gmail.com > > Sent: Wednesday, November 27, 2019 4:19 PM > >

Re: [dpdk-dev] [PATCH] app/test_thash: replace license text with SPDX tag

2019-11-27 Thread Thomas Monjalon
22/11/2019 10:44, Hemant Agrawal: > Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH] net/nfp: replace license text with SPDX tag

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:47, Heinrich Kuhn: > On 2019/09/27 10:33, hemant.agrawal at nxp.com (Hemant Agrawal) wrote: > > Signed-off-by: Hemant Agrawal > > Acked-by: Heinrich Kuhn Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

2019-11-27 Thread Thomas Monjalon
27/11/2019 11:58, jer...@marvell.com: > From: Jerin Jacob > > Add tested Marvell integrated NIC platforms to v19.11 release note. > > Signed-off-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH V3] doc: add tested Intel platforms with Intel NICs

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:21, Chen, Zhaoyan: > From: Wenjie Li > > V3: > Use symbols from isonum.txt to optimize the doc. > > V2: > Fix some typos. > > V1: > Add tested Intel platforms with Intel NICs to v19.11 release note. > > Signed-off-by: Wenjie Li Applied, thanks Few notes: - changelog should be

Re: [dpdk-dev] [PATCH v5] doc: clarify virtio PMD path selection

2019-11-27 Thread Thomas Monjalon
27/11/2019 16:19, Yinan: > From: Yinan Wang > > Add virtio paths selection and usage introduction for better > virtio usability. > > Signed-off-by: Yinan Wang > --- > doc/guides/howto/index.rst| 1 + > .../virtio_paths_selection_and_usage.rst | 126 ++

Re: [dpdk-dev] [PATCH] doc: add info about codespell config

2019-11-27 Thread Thomas Monjalon
20/11/2019 14:27, Kevin Traynor: > Document the config to use codespell with checkpatches.sh. > > Signed-off-by: Kevin Traynor > --- > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > -This, and any other configuration variables required by the development

Re: [dpdk-dev] [PATCH v2 1/4] eal: add API to check if its interrupt context

2019-11-27 Thread Stephen Hemminger
On Wed, 27 Nov 2019 15:52:19 +0530 Sunil Kumar Kori wrote: > > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Check if currently executing in interrupt context > + * > + * @return > + * - positive in case of interrupt context > + * - zero in ca

Re: [dpdk-dev] [PATCH v2] MAINTAINERS: update armv8 crypto PMD maintainership

2019-11-27 Thread Thomas Monjalon
27/11/2019 09:47, Ruifeng Wang: > It is expected to update this PMD to be in line with Arm's crypto library. > Update the maintainership to refect the change. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > Acked-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: update maintainers for nfp PMD

2019-11-27 Thread Thomas Monjalon
27/11/2019 12:36, Heinrich Kuhn: > As Alejandro is no longer with Netronome we appointed two new > maintainers for the Netronome PMD > > Signed-off-by: Heinrich Kuhn Applied, thanks

Re: [dpdk-dev] [PATCH] devtools: check coverity and bugzilla tags

2019-11-27 Thread Thomas Monjalon
09/10/2019 15:43, Kevin Traynor: > On 08/10/2019 16:52, David Marchand wrote: > > Let's try to check for discrepancies in covery and bugzilla tags. > > s/covery/coverity/ - you are trying to fool your patch? :-) > > > The contributing guide specifies that: > > - for coverity issues, the tag is 'C

Re: [dpdk-dev] [PATCH] devtools: reset compilation flags for each target

2019-11-27 Thread Thomas Monjalon
02/10/2019 18:55, David Marchand: > Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite > useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS > for cross compilation or libraries that won't provide a pkg-config file. > > Fixes: 272236741258 ("devtools: load targe

[dpdk-dev] [PATCH v2] devtools: control location of test builds

2019-11-27 Thread Thomas Monjalon
From: Bruce Richardson By default, both test-build.sh and test-meson-builds.sh scripts create the builds they generate in the current working directory, leading to a large number of build directories being present when testing patches. This patchset modifies both scripts to use a DPDK_BUILD_TEST_

[dpdk-dev] [PATCH] eal: fix unitialized data warning

2019-11-27 Thread Stephen Hemminger
Valgrind reports that eal interrupt thread is calling epoll_ctl with uninitialized data. Trivial to fix by initializing it. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal_interrupts.c | 2 +- 1 file changed, 1 i

Re: [dpdk-dev] [PATCH] git: ignore more build directories

2019-11-27 Thread Thomas Monjalon
20/11/2019 10:48, David Marchand: > On Sat, Sep 14, 2019 at 5:05 PM Thomas Monjalon wrote: > > > > Build directories commonly have compiler in their names. > > In order to filter build directories not starting with "build-" > > (common with make), patterns for gcc and clang are added to .gitignore

Re: [dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 2:20 PM Harry van Haaren wrote: > > This commit fixes a sporadic failure of the service_autotest > unit test, as seen in the DPDK CI. The failure occurs as the main test > thread did not wait on the service-thread to return, and allowing it > to read a flag before the servi

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-27 Thread David Marchand
On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote: > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > So far, we did not pay attention to direct access to variables but they > > are part of the API/ABI too and should be clearly identified. > > > > Introduce a __rte_experimental_

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/service: fix wait for service core

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:16 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: Aaron Conole > > Sent: Wednesday, November 27, 2019 2:10 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] test/service: fix wait for service core > > > > Harry van Haaren

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Aaron Conole
David Marchand writes: > On Wed, Nov 27, 2019 at 3:16 PM Van Haaren, Harry > wrote: >> >> > -Original Message- >> > From: Aaron Conole >> > Sent: Wednesday, November 27, 2019 2:10 PM >> > To: Van Haaren, Harry >> > Cc: dev@dpdk.org >> > Subject: Re: [PATCH] test/service: fix wait for s

Re: [dpdk-dev] [dpdk-announce] release candidate 19.11-rc4

2019-11-27 Thread Stokes, Ian
On 11/26/2019 11:56 PM, Thomas Monjalon wrote: A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.11-rc4 93 patches were integrated. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_19_11.html It should be completed w

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/service: fix wait for service core

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:16 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: Aaron Conole > > Sent: Wednesday, November 27, 2019 2:10 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] test/service: fix wait for service core > > > > Harry van Haaren

Re: [dpdk-dev] [PATCH v2] event/octeontx: fix partial Rx packet handling

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:32, Jerin Jacob: > On Wed, Nov 27, 2019 at 9:36 PM wrote: > > > > From: Pavan Nikhilesh > > > > When net/octeontx is connected to event/octeontx as an event Rx adapter, > > PKI aka 'net/octeontx' can forward packets directly to SSO aka > > 'event/octeontx'. > > When pumping traffic

[dpdk-dev] [PATCH v2] examples/tep_termination: resolve unchecked return value

2019-11-27 Thread Shashank T D
This patch checked the return value of rte_eth_dev_info_get function. Coverity issue: 349922 Signed-off-by: Shashank T D --- examples/tep_termination/vxlan_setup.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_ter

[dpdk-dev] [PATCH] examples/tep_termination: resolve unchecked return value

2019-11-27 Thread Shashank T D
resolve the unchecked return value from the function rte_eth_dev_info_get. Coverity issue: 349922 Signed-off-by: Shashank T D --- examples/tep_termination/vxlan_setup.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/tep_termination/vxlan_setup.c b/examples/te

[dpdk-dev] [Bug 372] ixgbevf: cannot probe or start port if PF link is unstable

2019-11-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=372 Bug ID: 372 Summary: ixgbevf: cannot probe or start port if PF link is unstable Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIR

Re: [dpdk-dev] [PATCH 1/2] config: set the pkgconfig executable

2019-11-27 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 08:14:22AM +, Ali Alnubani wrote: > Meson fails to find a pkg-config executable if pkgconfig > isn't set for aarch64. The environment variable `PKG_CONFIG_PATH` > is useless in this case, and meson fails to locate dependencies > that are built in non-standard paths. > >

Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 03:54:55PM +, Ali Alnubani wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, November 26, 2019 2:01 PM > > To: Ali Alnubani > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu > > as a pre

Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-27 Thread Ali Alnubani
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, November 26, 2019 2:01 PM > To: Ali Alnubani > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu > as a prerequisite > > On Tue, Nov 26, 2019 at 10:41:08AM +, Ali Alnubani wrote:

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:54, Matan Azrad: > From: Viacheslav Ovsiienko > > The legacy multi-packet write is the feature allowing to put multiple > > packets > > into one transmitting descriptor, this feature is supported by only NIC > > ConnectX-4LX. > > The number of packets should be limited to provide opt

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy non-inline multi-packet performance

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:53, Matan Azrad: > From: Viacheslav Ovsiienko > > The legacy multi-packet write is the feature allowing to put multiple > > packets > > into one transmitting descriptor, this feature is supported by only NIC > > ConnectX-4LX. > > The number of packets should be limited to provide op

[dpdk-dev] [PATCH] doc: use the latest numactl release

2019-11-27 Thread Ali Alnubani
Previous versions of numactl may produce the following error on some systems (at least on Fedora 30 and RHEL7.4): ./.libs/libnuma.so: undefined reference to `minor' ./.libs/libnuma.so: undefined reference to `major' collect2: error: ld returned 1 exit status This was fixed in upstream commi

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix default mark copy flow

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:45, Ori Kam: > From: Viacheslav Ovsiienko > Sent: Wednesday, November 27, 2019 3:37 PM > > > In extensive metadata mode the MARK copy table is engaged, > > if the application creates the flow with zero MARK ID action: > > > > flow create 1 ingress pattern eth / ... / end actions ma

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-27 Thread Wiles, Keith
> On Nov 26, 2019, at 2:21 AM, Nirmal Sarkar wrote: > > Hello, > > To support Jumbo frame in dpdk-pktgen, changes were suggested in dpdk > libraries also apart from pktgen code. > lib/librte_mbuf/rte_mbuf.h > lib/common/pg_inet.h > > But dpdk framework already supports jumbo frame [using

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
27/11/2019 15:47, David Marchand: > On Wed, Nov 27, 2019 at 3:31 PM Thomas Monjalon wrote: > > > > A buffer overflow happens in testpmd with some drivers > > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > > > The advertised capabilities of mlx4, mlx5 and softnic > > for the num

Re: [dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq

2019-11-27 Thread Ori Kam
This patch is not correct, You are using old code. This was already solved. Thanks, Ori > -Original Message- > From: xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 3/3] net/mlx5: remove

Re: [dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues

2019-11-27 Thread Ori Kam
> -Original Message- > From: xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin > queues > > From: Tonghao Zhang > > If configuring the nu

Re: [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment

2019-11-27 Thread Ori Kam
> -Original Message- > From: xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment > > From: Tonghao Zhang > > The type of txq has been assigned

Re: [dpdk-dev] [dpdk-users] What is the 'unit of timestamp' assigned to mbuf packet in DPDK?

2019-11-27 Thread Tom Barbette
Hi Gokul, As Setphen said, only Mellanox sets the hardware timestamp. If you have a Mellanox card, you can actually follow the example given in the rxtx_callback sample application that precisely gives the number of CPU cycles a packet spent into the queue. Tom Le 22/11/2019 à 18:00, Gokul

Re: [dpdk-dev] [PATCH v2] ethdev: limit maximum number of queues

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:31 PM Thomas Monjalon wrote: > > A buffer overflow happens in testpmd with some drivers > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > The advertised capabilities of mlx4, mlx5 and softnic > for the number of queues were the maximum number: UINT16_MA

[dpdk-dev] [PATCH v2] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
A buffer overflow happens in testpmd with some drivers since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. The advertised capabilities of mlx4, mlx5 and softnic for the number of queues were the maximum number: UINT16_MAX. They must be limited by the configured RTE_MAX_QUEUES_PER_PORT t

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:11 PM Thomas Monjalon wrote: > > 27/11/2019 15:07, David Marchand: > > On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: > > > > > > On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > > > > A buffer overflow happens in testpmd with some drivers > > > > since the queue arr

Re: [dpdk-dev] [PATCH v3] mk: add support for UBSAN

2019-11-27 Thread Aaron Conole
Harman Kalra writes: > UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior > detector. UBSan modifies the program at compile-time to catch > various kinds of undefined behavior during program execution. > > This patch introduces support for UBSan to the DPDK. > > See: doc/guides/prog_

[dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment

2019-11-27 Thread xiangxia . m . yue
From: Tonghao Zhang The type of txq has been assigned in mlx5_txq_hairpin_new. Fixes: ae18a1ae9692 ("net/mlx5: support Tx hairpin queues") Cc: Ori Kam Signed-off-by: Tonghao Zhang --- drivers/net/mlx5/mlx5_txq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/

[dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues

2019-11-27 Thread xiangxia . m . yue
From: Tonghao Zhang If configuring the number of tx/rx queue with rte_eth_dev_configure to nr_queues + hairpin_nr_queues, and setting tx/rx queues to nr_queues with rte_eth_tx/rx_queue_setup. But not configuring the hairpin queues via rte_eth_tx/rx_hairpin_queue_setup. When starting the netdev,

[dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq

2019-11-27 Thread xiangxia . m . yue
From: Tonghao Zhang The mlx5_rxq_obj_hairpin_new doesn't alloc the cq anymore. When releasing it, don't check it. Fixes: e79c9be91515 ("net/mlx5: support Rx hairpin queues") Cc: Ori Kam Signed-off-by: Tonghao Zhang --- drivers/net/mlx5/mlx5_rxq.c | 1 - 1 file changed, 1 deletion(-) diff --g

Re: [dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Van Haaren, Harry
> -Original Message- > From: Aaron Conole > Sent: Wednesday, November 27, 2019 2:10 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH] test/service: fix wait for service core > > Harry van Haaren writes: > > > This commit fixes a sporadic failure of the service_autote

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Ferruh Yigit
On 11/27/2019 2:14 PM, Ferruh Yigit wrote: > On 11/27/2019 2:11 PM, Thomas Monjalon wrote: >> 27/11/2019 15:07, David Marchand: >>> On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > A buffer overflow happens in testpmd with some drive

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Ferruh Yigit
On 11/27/2019 2:11 PM, Thomas Monjalon wrote: > 27/11/2019 15:07, David Marchand: >> On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: >>> >>> On 11/27/2019 1:42 PM, Thomas Monjalon wrote: A buffer overflow happens in testpmd with some drivers since the queue arrays are limited to RTE_

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
27/11/2019 15:07, David Marchand: > On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: > > > > On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > > > A buffer overflow happens in testpmd with some drivers > > > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > > > > > The advertised

Re: [dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Aaron Conole
Harry van Haaren writes: > This commit fixes a sporadic failure of the service_autotest > unit test, as seen in the DPDK CI. The failure occurs as the main test > thread did not wait on the service-thread to return, and allowing it > to read a flag before the service was able to write to it. > >

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: > > On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > > A buffer overflow happens in testpmd with some drivers > > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > > > The advertised capabilities of mlx4, mlx5 and softnic > > for

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Ferruh Yigit
On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > A buffer overflow happens in testpmd with some drivers > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > The advertised capabilities of mlx4, mlx5 and softnic > for the number of queues were the maximum number: UINT16_MAX. > They m

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2019-11-27 Thread Matan Azrad
From: Viacheslav Ovsiienko > The legacy multi-packet write is the feature allowing to put multiple packets > into one transmitting descriptor, this feature is supported by only NIC > ConnectX-4LX. > The number of packets should be limited to provide optimal size descriptor > and better performan

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy non-inline multi-packet performance

2019-11-27 Thread Matan Azrad
From: Viacheslav Ovsiienko > The legacy multi-packet write is the feature allowing to put multiple packets > into one transmitting descriptor, this feature is supported by only NIC > ConnectX-4LX. > The number of packets should be limited to provide optimal size descriptor > and better performa

Re: [dpdk-dev] [PATCH] net/nfp: replace license text with SPDX tag

2019-11-27 Thread Heinrich Kuhn
On 2019/09/27 10:33, hemant.agrawal at nxp.com (Hemant Agrawal) wrote: > Signed-off-by: Hemant Agrawal Acked-by: Heinrich Kuhn

Re: [dpdk-dev] [PATCH v2 8/8] doc: drop EAL command-line reference from FreeBSD GSG

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 12:31:10PM +, Burakov, Anatoly wrote: > On 25-Nov-19 2:55 PM, Bruce Richardson wrote: > > The EAL command-line reference section duplicated material covered in a > > previous chapter, was out of date, and generally is unnecessary as options > > are best queried directly

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix default mark copy flow

2019-11-27 Thread Ori Kam
> -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, November 27, 2019 3:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH v2] net/mlx5: fix default mark copy flow > > In extensive metadata mode the MARK copy table is engaged,

[dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
A buffer overflow happens in testpmd with some drivers since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. The advertised capabilities of mlx4, mlx5 and softnic for the number of queues were the maximum number: UINT16_MAX. They must be limited by the configured RTE_MAX_QUEUES_PER_PORT t

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from NFP PMD maintainer

2019-11-27 Thread Heinrich Kuhn
On 2019/11/25 20:52, thomas at monjalon.net (Thomas Monjalon) wrote: > 13/11/2019 14:05, Alejandro Lucero: >> On Wed, Nov 13, 2019 at 12:55 PM Ferruh Yigit >> wrote: >>> On 11/13/2019 12:47 PM, Alejandro Lucero wrote: [...] >>> Can it be possible to nominate someone? >>> It would be good to have a

[dpdk-dev] [PATCH v2] net/mlx5: fix default mark copy flow

2019-11-27 Thread Viacheslav Ovsiienko
In extensive metadata mode the MARK copy table is engaged, if the application creates the flow with zero MARK ID action: flow create 1 ingress pattern eth / ... / end actions mark id 0 / .. end And then destroys that, the traffic to the port stops. This happens due to default flow for the copy ta

Re: [dpdk-dev] [PATCH v2] event/octeontx: fix partial Rx packet handling

2019-11-27 Thread Jerin Jacob
On Wed, Nov 27, 2019 at 9:36 PM wrote: > > From: Pavan Nikhilesh > > When net/octeontx is connected to event/octeontx as an event Rx adapter, > PKI aka 'net/octeontx' can forward packets directly to SSO aka > 'event/octeontx'. > When pumping traffic to PKI if flow control is disabled internal FIF

[dpdk-dev] [PATCH V3] doc: add tested Intel platforms with Intel NICs

2019-11-27 Thread Chen, Zhaoyan
From: Wenjie Li V3: Use symbols from isonum.txt to optimize the doc. V2: Fix some typos. V1: Add tested Intel platforms with Intel NICs to v19.11 release note. Signed-off-by: Wenjie Li --- doc/guides/rel_notes/release_19_11.rst | 99 ++ 1 file changed, 99 insertions(

[dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Harry van Haaren
This commit fixes a sporadic failure of the service_autotest unit test, as seen in the DPDK CI. The failure occurs as the main test thread did not wait on the service-thread to return, and allowing it to read a flag before the service was able to write to it. The fix changes the wait API call to s

Re: [dpdk-dev] [PATCH v2] examples/tep_termination: resolve unchecked return value

2019-11-27 Thread Li, Xiaoyun
> -Original Message- > From: T D, Shashank > Sent: Wednesday, November 27, 2019 12:04 > To: dev@dpdk.org > Cc: Li, Xiaoyun > Subject: [PATCH v2] examples/tep_termination: resolve unchecked return value > > This patch checked the return value of rte_eth_dev_info_get function. > Coverity is

[dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2019-11-27 Thread Viacheslav Ovsiienko
The legacy multi-packet write is the feature allowing to put multiple packets into one transmitting descriptor, this feature is supported by only NIC ConnectX-4LX. The number of packets should be limited to provide optimal size descriptor and better performance. Fixes: 18a1c20044c0 ("net/mlx5: imp

Re: [dpdk-dev] [PATCH v2] vhost-blk: fix the unused return value

2019-11-27 Thread Maxime Coquelin
On 11/27/19 1:16 PM, Jin Yu wrote: > add the assert to handle error. > > Coverity issue: 350592 > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") > Cc: sta...@dpdk.org > > Signed-off-by: Jin Yu > --- > v2 - add the error hander > --- > examples/vhost_blk/vhost_blk.

[dpdk-dev] [PATCH v2] event/octeontx: fix partial Rx packet handling

2019-11-27 Thread pbhagavatula
From: Pavan Nikhilesh When net/octeontx is connected to event/octeontx as an event Rx adapter, PKI aka 'net/octeontx' can forward packets directly to SSO aka 'event/octeontx'. When pumping traffic to PKI if flow control is disabled internal FIFOs might be overrun causing partial l2 packets to be

[dpdk-dev] [PATCH] net/mlx5: fix legacy non-inline multi-packet performance

2019-11-27 Thread Viacheslav Ovsiienko
The legacy multi-packet write is the feature allowing to put multiple packets into one transmitting descriptor, this feature is supported by only NIC ConnectX-4LX. The number of packets should be limited to provide optimal size descriptor and better performance. Fixes: 18a1c20044c0 ("net/mlx5: imp

Re: [dpdk-dev] [PATCH v2 8/8] doc: drop EAL command-line reference from FreeBSD GSG

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: The EAL command-line reference section duplicated material covered in a previous chapter, was out of date, and generally is unnecessary as options are best queried directly by passing "--help" to a DPDK binary. Therefore we can drop this section to av

Re: [dpdk-dev] [PATCH v2 7/8] doc: update documentation on build and running FreeBSD apps

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: Update the documentation on building and running apps on FreeBSD, taking account of having used meson for building. We can also update the section on the command-line parameters, rather than claiming to be a complete list of parameters, it should desc

Re: [dpdk-dev] [PATCH v2 5/8] doc: update examples output in FreeBSD GSG

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 12:11:41PM +, Burakov, Anatoly wrote: > On 25-Nov-19 2:55 PM, Bruce Richardson wrote: > > The output of running the helloworld example on FreeBSD was a little > > out-of-date and can be shortened by using the latest version of DPDK. > > Update appropriately. > > > > Sig

Re: [dpdk-dev] [PATCH v2 6/8] doc: add meson install instructions for FreeBSD

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: Update the FreeBSD GSG doc with instructions for installing using meson and ninja rather than make. Signed-off-by: Bruce Richardson --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 5/8] doc: update examples output in FreeBSD GSG

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: The output of running the helloworld example on FreeBSD was a little out-of-date and can be shortened by using the latest version of DPDK. Update appropriately. Signed-off-by: Bruce Richardson --- doc/guides/freebsd_gsg/install_from_ports.rst | 56

  1   2   >