Re: [dpdk-dev] [EXT] Re: [PATCH v2] test: fix process dup fd close

2019-11-03 Thread Krzysztof Kanas
On 19-10-30 10:06, David Marchand wrote: > External Email > > -- > On Mon, Sep 2, 2019 at 11:50 AM wrote: > > > > From: Krzysztof Kanas > > > > process_dup was intending to close it's own fd's but failed to do so > > A bit hard

Re: [dpdk-dev] DPDK QoS scheduler changes, are we there yet?

2019-11-03 Thread David Marchand
On Thu, Oct 31, 2019 at 6:45 PM Singh, Jasvinder wrote: > > On 10/30/2019 6:35 PM, Gladchun, Glenn wrote: > > > I stumbled upon this 11 month old post (https://narkive.com/ZwBXg4Xe) > > that goes over future enhancements to the scheduler. All of them are vital, > > and I am especially interested

[dpdk-dev] [PATCH v5] net/ice: fix setting max frame size

2019-11-03 Thread Min JiaqiX
Max frame size is not set to HW, so packets above the MTU do not get dropped by HW. The patch fixed the issue. Fixes: 50370662b727 ("net/ice: support device and queue ops") Cc: sta...@dpdk.org Signed-off-by: Min JiaqiX --- v5: * Set `ICE_FRAME_SIZE_MAX` to to default value. v4: * Removed Review

Re: [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size

2019-11-03 Thread Min, JiaqiX
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Monday, November 4, 2019 10:57 AM > To: Min, JiaqiX > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size > > On 10/30, Min JiaqiX wrote: > >Max frame size is not set to

[dpdk-dev] [PATCH] lib/eal: resolve address conflicts

2019-11-03 Thread Wangyu (Turing Solution Development Dep)
Resolve address conflicts on 64K pagesize without base_virtaddr, which cause new address conflicts in eal_get_virtual_area(). Signed-off-by: Beard-627 Acked-by: Eric wang Acked-by: Wei Hu Acked-by: Min Hu --- lib/librte_eal/linux/eal/eal.c | 22 ++ 1 file changed, 22 in

[dpdk-dev] [PATCH] bus/pci: resolve multiple NICs address conflicts

2019-11-03 Thread Wangyu (Turing Solution Development Dep)
NIC address conflicts on 64K pagesize when using multiple NICs, as system will mmap 64K pagesize for NIC, but dev->mem_resource[i].len is 16K. Signed-off-by: Beard-627 Acked-by: Eric wang Acked-by: Wei Hu Acked-by: Min Hu --- drivers/bus/pci/linux/pci.c | 5 + 1 file changed, 5 insertion

[dpdk-dev] [PATCH v9 1/2] ethdev: extend flow metadata

2019-11-03 Thread Viacheslav Ovsiienko
Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a r

[dpdk-dev] [PATCH v9 2/2] ethdev: move egress metadata to dynamic field

2019-11-03 Thread Viacheslav Ovsiienko
The dynamic mbuf fields were introduced by [1]. The egress metadata is good candidate to be moved from statically allocated field tx_metadata to dynamic one. Because mbufs are used in half-duplex fashion only, it is safe to share this dynamic field with ingress metadata. The shared dynamic field c

[dpdk-dev] [PATCH v9 0/2] extend flow metadata feature

2019-11-03 Thread Viacheslav Ovsiienko
This patchset just combines two metadata related patches to provide right applying order. The first patch introduces the ingress metadata with mbuf dynamic field usage, the second one moves egress metadata to the dynamic field presented by first patch. Signed-off-by: Viacheslav Ovsiienko Viaches

[dpdk-dev] [PATCH v2 1/1] net/octeontx2: add Rx/Tx burst mode get callbacks

2019-11-03 Thread Sunil Kumar Kori
Retrieve burst mode options according to the selected Rx/Tx burst function. Signed-off-by: Sunil Kumar Kori --- v2: - Rebased the patch on latest commit. - Update feature matrix for the support. doc/guides/nics/features/octeontx2.ini | 1 + drivers/net/octeontx2/otx2_ethdev.c | 2 ++ d

[dpdk-dev] [PATCH] net/ice: fix link status recovery

2019-11-03 Thread Qiming Yang
This patch fix a kernel driver link status issue by recovering link status when device stop. Fixes: e6161345d8a9 ("net/ice: support link status change") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 26 +- drivers/net/ice/ice_ethdev.h

Re: [dpdk-dev] [v2] net/ixgbe:fix wrong link status

2019-11-03 Thread Ye Xiaolong
On 10/29, Xiao Zhang wrote: >The link status for 82599eb got from link status register was not correct, >check the enable/disable flag of tx laser when getting the link status, >set the link status down if tx laser disabled since the tx laser flag >could be set correctly when up/down the link statu

Re: [dpdk-dev] Link status issue with i40e firmware 7.0x

2019-11-03 Thread Xing, Beilei
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, October 30, 2019 10:21 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev ; Jean Hsiao ; Christophe > Fontaine > Subject: Link status issue with i40e firmware 7.0x > > Hello, > > We recently up

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix port close in FreeBSD OS

2019-11-03 Thread Ye Xiaolong
Seems i40e driver has the same issue, could you help to cook another fix patch as well? On 11/01, Di ChenxuX wrote: >FreeBSD OS don't support igb_uio interrupt, so it will fail > when unregister the interrupt callback in port close. >We can fix the issue by passing -ENOENT when check the > return

Re: [dpdk-dev] [PATCH v2 2/2] vhost: do not limit packed ring size

2019-11-03 Thread Tiwei Bie
On Wed, Oct 30, 2019 at 05:24:21PM +0800, Marvin Liu wrote: > Virtio spec only set rule that packed ring maximum size is up to 2^15 > entries. Should not limit packed ring size to power of two. > > Fixes: 708e14d8b9ac ("vhost: advertize packed ring layout support") > Cc: sta...@dpdk.org > > Signe

Re: [dpdk-dev] [PATCH v1 1/6] doc: documentation update

2019-11-03 Thread Somalapuram, Amaranath
Hi Akhil, If I use fix as a tag. I get the below message. Is this messages is ok or do we need to have bug numbers for this? ./devtools/check-git-log.sh Missing 'Fixes' tag: doc: fix app usage in CCP guide Regards, S.Amarnath -Original Message- From: Akhil Goyal Sent: Tuesday,

Re: [dpdk-dev] [PATCH v2 1/2] net/virtio: do not limit packed ring size

2019-11-03 Thread Tiwei Bie
On Wed, Oct 30, 2019 at 05:24:20PM +0800, Marvin Liu wrote: > Virtio spec only set rule that packed ring maximum size is up to 2^15 > entries. Should not limit packed ring size to power of two. > > Fixes: aea29aa5d37b ("net/virtio: enable packed virtqueues by default") > Cc: sta...@dpdk.org > > S

Re: [dpdk-dev] [PATCH v2] vhost: fix compile error

2019-11-03 Thread Tiwei Bie
On Wed, Oct 30, 2019 at 05:40:55PM +0800, Jin Yu wrote: > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h > So we need the librte_hash to be compiled before vhost. > Add the DEPDIRs to make sure this. > > Bugzilla ID: 356 > Fixes: 939066d96563 ("vhost/crypto: add public function implement

[dpdk-dev] [PATCH] vhost: fix dirty page logging missing

2019-11-03 Thread Marvin Liu
Packets data are directly copied when doing batch enqueue, add missed dirty page logging after memory copy. Fixes: ad3df6dcc0fc ("vhost: add packed ring batch enqueue") Signed-off-by: Marvin Liu --- lib/librte_vhost/virtio_net.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte

Re: [dpdk-dev] [DPDK] net/ice: set vlan tpid is not supported by ice

2019-11-03 Thread Yang, Qiming
Hi, > -Original Message- > From: Zhu, TaoX > Sent: Thursday, October 31, 2019 6:29 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhu, TaoX > Subject: [DPDK] net/ice: set vlan tpid is not supported by ice > > From: Zhu Tao > > Set vlan tpid is not supported by ice hardware.

Re: [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e

2019-11-03 Thread Ye Xiaolong
On 10/31, taox@intel.com wrote: >From: Zhu Tao > >Qinq strip is not supported by i40e. When user tries to turn on >QinQ strip, the driver gives unsupported return value and log. > >Signed-off-by: Zhu Tao >--- > drivers/net/i40e/i40e_ethdev.c | 5 + > 1 file changed, 5 insertions(+) > >diff

Re: [dpdk-dev] [PATCH] net/ice/base: fix wrong symmetric hash configure

2019-11-03 Thread Ye Xiaolong
On 10/31, Qi Zhang wrote: >When a new hash profie is created, we need to reset all related >GLQF_HSYMM registers, otherwise unexpected hash behaviour may happens >on packet that hit that profile. > >The patch fix the issue that we only do reset when symmetric hash >is required, but actually for non

Re: [dpdk-dev] [PATCH] net/ice/base: fix wrong symmetric hash configure

2019-11-03 Thread Yang, Qiming
Hi, Some typos. > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, October 31, 2019 11:55 AM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/ice/base: fix wrong symmetric hash configure > > When a new hash profie is created, we need to reset all related

Re: [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size

2019-11-03 Thread Ye Xiaolong
On 10/30, Min JiaqiX wrote: >Max frame size is not set to HW, so packets above the MTU >do not get dropped by HW. The patch fixed the issue. > >Fixes: 50370662b727 ("net/ice: support device and queue ops") >Cc: sta...@dpdk.org > >Signed-off-by: Min JiaqiX > >--- >v4: >* Removed Reviewed-by >* Chec

[dpdk-dev] [PATCH v4] vhost: fix vhost user virtqueue not accessible

2019-11-03 Thread Marvin Liu
Log feature is disabled in vhost user, so that log address was invalid when checking. Check whether log address is valid can work around it. Log address should also be translated in packed ring virtqueue. Fixes: 04cfc7fdbfca ("vhost: translate incoming log address to gpa") Signed-off-by: Marvin L

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Wang, Haiyue
Hi Slava, Thanks for your reply. I've no more description to talk about the code design. And I agree with your thinking, all roads lead to Rome, please don't hesitate to submit a patch to clean up things. Your rich experience is very appreciated to speed up the design, thanks! ;-) BR, Haiyue > -

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 4, 2019 06:21 > To: Wang, Haiyue > Cc: dev@dpdk.org; arybche...@solarflare.com; Yigit, Ferruh > ; > jerinjac...@gmail.com; Ye, Xiaolong ; Kinsella, Ray > ; > Sun, Chenmin ; Slava Ovsiienko > > Subject: Re: [PATCH v1

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

2019-11-03 Thread Thomas Monjalon
03/11/2019 21:35, Ray Kinsella: > On 29/10/2019 14:27, Ferruh Yigit wrote: > > On 10/26/2019 5:23 PM, Thomas Monjalon wrote: > >> 26/10/2019 11:23, Wang, Haiyue: > >>> From: Thomas Monjalon [mailto:tho...@monjalon.net] > 26/10/2019 06:40, Wang, Haiyue: > > From: Thomas Monjalon [mailto:tho

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Thomas Monjalon
03/11/2019 04:52, Wang, Haiyue: > Hi Thomas, > > Reply the missed: > > From: Thomas Monjalon > > > > Thank you for trying to address comments done late. > > > > 31/10/2019 18:11, Haiyue Wang: > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > -enum rte_

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-03 Thread Thomas Monjalon
03/11/2019 16:27, Ananyev, Konstantin: > > > > > If we consider what Intel did, i.e. configure VF in place of > > > > representor for some operations, there are two drawbacks: > > > > - confusing that some ops apply to representor, others apply to VF > > > > - some ops are not possible on represen

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Ray Kinsella
On 02/11/2019 19:21, Damjan Marion (damarion) wrote: > > >> On 2 Nov 2019, at 09:38, Slava Ovsiienko wrote: >> >> Hi >>> -Original Message- >>> From: Liu, Yu Y >>> Sent: Saturday, November 2, 2019 8:56 >>> To: Wang, Haiyue ; Thomas Monjalon >>> >>> Cc: dev@dpdk.org; arybche...@solar

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

2019-11-03 Thread Ray Kinsella
On 29/10/2019 14:27, Ferruh Yigit wrote: > On 10/26/2019 5:23 PM, Thomas Monjalon wrote: >> 26/10/2019 11:23, Wang, Haiyue: >>> From: Thomas Monjalon [mailto:tho...@monjalon.net] 26/10/2019 06:40, Wang, Haiyue: > From: Thomas Monjalon [mailto:tho...@monjalon.net] >> 25/10/2019 18:02

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Slava Ovsiienko
Hi, Haiyue > -Original Message- > From: Wang, Haiyue > Sent: Sunday, November 3, 2019 13:38 > To: Slava Ovsiienko ; Liu, Yu Y > ; Thomas Monjalon > Cc: dev@dpdk.org; arybche...@solarflare.com; Yigit, Ferruh > ; jerinjac...@gmail.com; Ye, Xiaolong > ; Kinsella, Ray ; Sun, > Chenmin ; Damj

[dpdk-dev] [PATCH] app/testpmd: add hairpin support

2019-11-03 Thread Ori Kam
This commit introduce the hairpin queues to the testpmd. the hairpin queue is configured using --hairpinq= the hairpin queue adds n queue objects for both the total number of TX queues and RX queues. The connection between the queues are 1 to 1, first Rx hairpin queue will be connected to the first

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bitoperation APIs

2019-11-03 Thread Gavin Hu (Arm Technology China)
Hi Honnappa, > -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, November 1, 2019 9:48 PM > To: Gavin Hu (Arm Technology China) ; Morten > Brørup ; Joyce Kong (Arm Technology China) > ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > ravi1.ku...@amd.com; xu

Re: [dpdk-dev] [PATCH] net/mlx5: port id action must be after VLAN actions

2019-11-03 Thread Matan Azrad
Hi From: Xiaoyu Min > Rdma-core needs the dst_vport (port_id) action be after push/pop VLAN > and modify hdr actions otherwise it will reject to create rule. > > This pach validates the port_id is after push/pop VLAN and set VLAN VID/PCP > otherwise PMD spits out errors. > > Fixes: 5f163d520cff

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-03 Thread Ananyev, Konstantin
> > > If we consider what Intel did, i.e. configure VF in place of > > > representor for some operations, there are two drawbacks: > > > - confusing that some ops apply to representor, others apply to VF > > > - some ops are not possible on representor (because targetted to VF) > > > > > > I stil

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-03 Thread Matan Azrad
From: Andrew Rybchenko > On 11/3/19 9:57 AM, Matan Azrad wrote: > > Hi > > > > From: Andrew Rybchenko > >> On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh Bhagavatula > > Hi Matan, > > > >> Hi Pavan > >> > >> From: Pavan Nikhilesh > >>

Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

2019-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Friday, November 1, 2019 3:33 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN > header > > Currently i

Re: [dpdk-dev] [EXT] Re: [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-11-03 Thread Liron Himi
Hi, Correct, I didn't notice that the patch related to the 'rss' field in mbuf. So ignore my request. Regards, Liron -Original Message- From: Andrew Rybchenko Sent: Sunday, 3 November 2019 14:07 To: Liron Himi ; Pavan Nikhilesh Bhagavatula ; ferruh.yi...@intel.com; Jerin Jacob Kollan

Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char in logs

2019-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, October 30, 2019 10:42 AM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char in > logs > > DRV_LOG macro

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-03 Thread Andrew Rybchenko
On 11/3/19 9:57 AM, Matan Azrad wrote: Hi From: Andrew Rybchenko On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: From: Pavan Nikhilesh Bhagavatula Hi Matan, Hi Pavan From: Pavan Nikhilesh Some PMDs cannot work when certain offloads are enable/disabled, as a workaround PMDs auto e

Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-11-03 Thread Andrew Rybchenko
On 11/1/19 8:49 PM, Liron Himi wrote: Hi, mvpp2 and mvneta PMDs are also support RSS hash. Please add them to the patch. I've failed to find where mvpp2 and mvneta set PKT_RX_RSS_HASH. Regards, Liron -Original Message- From: dev On Behalf Of pbhagavat...@marvell.com Sent: Tuesday,

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-03 Thread Andrew Rybchenko
On 11/3/19 1:22 PM, Ori Kam wrote: Hi, -Original Message- From: dev On Behalf Of Andrew Rybchenko Sent: Friday, November 1, 2019 1:35 PM To: Thomas Monjalon Cc: dev@dpdk.org; Ori Kam ; pbhagavat...@marvell.com; ferruh.yi...@intel.com; jer...@marvell.com; John McNamara ; Marko Kovacevi

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Wang, Haiyue
Hi Slava, > -Original Message- > From: Slava Ovsiienko > Sent: Sunday, November 3, 2019 16:59 > To: Wang, Haiyue ; Liu, Yu Y ; > Thomas Monjalon > > Cc: dev@dpdk.org; arybche...@solarflare.com; Yigit, Ferruh > ; > jerinjac...@gmail.com; Ye, Xiaolong ; Kinsella, Ray > ; > Sun, Chenmin

[dpdk-dev] [PATCH] net/sfc: fix adapter lock usage on rule creation

2019-11-03 Thread Ivan Malov
The point is that adapter lock has to be held on list accesses, as well as when talking to the HW. Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_flow.c | 4 ++-- 1 file changed, 2

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-03 Thread Ori Kam
Hi, > -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Friday, November 1, 2019 1:35 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Ori Kam ; > pbhagavat...@marvell.com; ferruh.yi...@intel.com; jer...@marvell.com; John > McNamara ; Marko Kovacevic > ; Adrien Mazarguil >

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Slava Ovsiienko
> -Original Message- > From: Wang, Haiyue > Sent: Sunday, November 3, 2019 4:34 > To: Slava Ovsiienko ; Liu, Yu Y > ; Thomas Monjalon > Cc: dev@dpdk.org; arybche...@solarflare.com; Yigit, Ferruh > ; jerinjac...@gmail.com; Ye, Xiaolong > ; Kinsella, Ray ; Sun, > Chenmin ; Damjan Marion (da

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-03 Thread Slava Ovsiienko
> -Original Message- > From: Damjan Marion (damarion) > Sent: Saturday, November 2, 2019 21:21 > To: Slava Ovsiienko > Cc: Liu, Yu Y ; Wang, Haiyue ; > Thomas Monjalon ; dev@dpdk.org; > arybche...@solarflare.com; Yigit, Ferruh ; > jerinjac...@gmail.com; Ye, Xiaolong ; Ray Kinsella > ;