Re: [dpdk-dev] [PATCH] net/virtio: fix broken Tx checksum offloads

2019-10-24 Thread Tiwei Bie
On Thu, Oct 24, 2019 at 06:46:09PM +0100, Andrew Rybchenko wrote: > Missing parenthesis around expression before type cast to struct > virtio_net_hdr pointer makes the arithmetic to be in > sizeof(struct virtio_net_hdr) units. > > Use rte_pktmbuf_mtod_offset() to fix the problem. > > Type of head

Re: [dpdk-dev] [RFC PATCH 00/13] add eventmode to ipsec-secgw

2019-10-24 Thread Anoob Joseph
Hi Konstantin, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, October 16, 2019 6:33 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu > Cc: Thomas Monjalon ; Jerin Jacob Kollanukkaran > ; Narayana Prasad R

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add support for replay win for lookaside

2019-10-24 Thread Hemant Agrawal
This patch extend the support for window size config to lookaside based ipsec offload as well. Signed-off-by: Hemant Agrawal --- examples/ipsec-secgw/ipsec.c | 1 + examples/ipsec-secgw/sa.c| 1 + 2 files changed, 2 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-se

[dpdk-dev] [PATCH 1/2] security: add anti replay window size

2019-10-24 Thread Hemant Agrawal
At present the ipsec xfrom is missing the important step to configure the anti replay window size. The newly added field will also help in to enable or disable the anti replay checking, if available in offload by means of non-zero or zero value. Currently similar field is available in rte_ipsec li

[dpdk-dev] [PATCH] net/ice: modify packet type table

2019-10-24 Thread Ying Wang
The original packet type table's hw-ptype index to sw-ptype mapping is wrong. This patch fixed the issue. Fixes: ab9dccf09af9 ("net/ice: support packet type getting") Cc: sta...@dpdk.org Signed-off-by: Ying Wang --- drivers/net/ice/ice_rxtx.c | 312 -

[dpdk-dev] [PATCH] net/ixgbe: fix port close in FreeBSD OS

2019-10-24 Thread Di ChenxuX
FreeBSD OS don't support igb_uio interrupt, so it will fail that unregister intr callback when port close. Fix by passing -ENOENT when check the return value of unregister intr callback function. Fixes: f2f4990eff94 ("net/ixgbe: release port upon close") Signed-off-by: Di ChenxuX --- drivers/n

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-10-24 Thread Hideyuki Yamashita
Hello Slava, Thanks for your response back. While waiting your final response, I am sending additional info from my side. 1 I am using "MLNX_OFED_LINUX-4.7-1.0.0.1-ubuntu18.04-x86_64" as OFED. tx_h-yamashita@R730n10:~/dpdk-next-net$ pwd /home/tx_h-yamashita/dpdk-next-net tx_h-yamashita@R730n10

[dpdk-dev] Please stop using iopl() in DPDK

2019-10-24 Thread Andy Lutomirski
Hi all- Supporting iopl() in the Linux kernel is becoming a maintainability problem. As far as I know, DPDK is the only major modern user of iopl(). After doing some research, DPDK uses direct io port access for only a single purpose: accessing legacy virtio configuration structures. These struc

Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting

2019-10-24 Thread Tiwei Bie
On Wed, Aug 14, 2019 at 01:36:41PM -0500, David Christensen wrote: > Use of %llx print formatting causes meson build error on Power systems with > RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. > > Fixes: 9b62e2da1844 (vhost: register new regions with userfaultfd) > Cc: maxime.coque...@redhat

Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting

2019-10-24 Thread Tiwei Bie
On Thu, Oct 24, 2019 at 09:27:38PM +0200, David Marchand wrote: > On Mon, Aug 19, 2019 at 1:41 PM Maxime Coquelin > wrote: > > On 8/19/19 10:40 AM, David Marchand wrote: > > > On Thu, Aug 15, 2019 at 6:16 PM David Christensen > > > wrote: > > >> > > Use of %llx print formatting causes meson

Re: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for head

2019-10-24 Thread Pavan Nikhilesh Bhagavatula
Hi Gavin, >-Original Message- >From: dev On Behalf Of Gavin Hu (Arm >Technology China) >Sent: Thursday, October 24, 2019 9:23 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran >Cc: dev@dpdk.org; nd >Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: use wfe while >waiting f

Re: [dpdk-dev] [PATCH] net/ice: set max frame size

2019-10-24 Thread Min, JiaqiX
Hi Xiaolong, > -Original Message- > From: Ye, Xiaolong > Sent: Friday, October 25, 2019 11:06 AM > To: Min, JiaqiX > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > > Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size > > Hi, > > Could you provide the Fixes tag and cc stable?

[dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port

2019-10-24 Thread Jiang JunyuX
Port validation should be prior to getting dev data to avoid segmentation fault. This patch fixed the issue. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: sta...@dpdk.org Signed-off-by: Jiang Junyu

Re: [dpdk-dev] [PATCH] net/ice: set max frame size

2019-10-24 Thread Ye Xiaolong
Hi, Could you provide the Fixes tag and cc stable? Thanks, Xiaolong On 10/24, Min JiaqiX wrote: >Max frame size is not set to HW, so packets above the MTU >do not get dropped by HW. The patch fixed the issue. > >Signed-off-by: Min JiaqiX >--- > drivers/net/ice/ice_ethdev.c | 4 > 1 file cha

Re: [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check

2019-10-24 Thread Ye Xiaolong
On 09/18, Tianfei zhang wrote: >Add pointer null check before dereference. > >Coverity issue: 344976 >Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status") >Cc: sta...@dpdk.org > >Signed-off-by: Tianfei zhang >--- > drivers/raw/ifpga/base/opae_eth_group.c | 3 +-- > 1 file changed, 1 insertio

Re: [dpdk-dev] [PATCH v13 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-10-24 Thread Ye Xiaolong
Please fix the patchwork warnings for patch 10/11/12. Thanks, Xiaolong On 10/24, Andy Pei wrote: >This patch set adds PCIe AER disable and FPGA interrupt support for >ipn3ke. It also provides a small rework for port bonding between FPGA >line side port and I40e PF port. > >What is the PCI Express

Re: [dpdk-dev] [PATCH v13 05/19] raw/ifpga/base: add device tree support

2019-10-24 Thread Ye Xiaolong
On 10/24, Andy Pei wrote: >From: Tianfei zhang >--- a/drivers/meson.build >+++ b/drivers/meson.build >@@ -9,12 +9,12 @@ endif > dpdk_driver_classes = ['common', > 'bus', > 'mempool', # depends on common and bus. >- 'net', # depends on common, bus and mempo

Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove

2019-10-24 Thread Di, ChenxuX
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Friday, October 25, 2019 1:24 AM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove > > On 10/24/2019 2:03 AM, Di ChenxuX wrote: > > Hot

[dpdk-dev] [PATCH] net/ixgbe: fix macsec setting

2019-10-24 Thread Sun GuinanX
macsec setting is not valid when port is stopped. In order to make it valid, the patch changes the setting to where port is started. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Sun GuinanX --- drivers/net/ixgbe/ixgbe_ethdev.c | 160 +++

Re: [dpdk-dev] [PATCH v13 05/19] raw/ifpga/base: add device tree support

2019-10-24 Thread Xu, Rosen
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, October 24, 2019 21:09 > To: Pei, Andy > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Ye, Xiaolong ; Zhang, Qi > Z ; Yigit, Ferruh > Subject: Re: [PATCH v13 05/19] raw/ifpga/base: ad

Re: [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check

2019-10-24 Thread Xu, Rosen
Hi, > -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, October 25, 2019 3:22 > To: Xu, Rosen ; Zhang, Tianfei > > Cc: dev ; dpdk stable > Subject: Re: [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null > check > > On Tue, Sep 17, 2019

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

2019-10-24 Thread Thomas Monjalon
24/10/2019 21:09, David Marchand: > On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov > wrote: > > > > The rte_vfio_dma_map/unmap API's have been marked as deprecated in > > release 19.05. Remove them. > > > > Signed-off-by: Anatoly Burakov > > --- > > > > Notes: > > Although `rte_vfio_dma_map`

Re: [dpdk-dev] [PATCH v4 0/6] use WFE for locks and ring on aarch64

2019-10-24 Thread David Christensen
This series got a lot of attention from ARM people and it seems ready for integration. But I did not see comment from other architectures, could you have a look please? I spent some time going through the Power ISA specification and the Linux code and didn't find an equivalent. Under Linux thi

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

2019-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2019 21:09:25 +0200 David Marchand wrote: > On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov > wrote: > > > > The rte_vfio_dma_map/unmap API's have been marked as deprecated in > > release 19.05. Remove them. > > > > Signed-off-by: Anatoly Burakov > > --- > > > > Notes: > > Al

Re: [dpdk-dev] [PATCH v1 1/1] mempool/octeontx2: remove minimum chunck size limitation

2019-10-24 Thread David Marchand
On Fri, Oct 4, 2019 at 5:49 PM Jerin Jacob wrote: > > On Tue, Sep 10, 2019 at 4:33 PM wrote: > > > > From: Vamsi Attunuru > > > > Memory required for the mempool objects need not be physically > > contiguous on octeontx2's HW, mempool pmd supports the minimum chunk > > size set by the default ha

Re: [dpdk-dev] [EXT] Re: [PATCH v11 2/4] eal: add legacy kni option

2019-10-24 Thread Jerin Jacob
On Thu, Oct 24, 2019 at 11:05 PM Olivier Matz wrote: > > Hi, > > On Wed, Oct 23, 2019 at 08:32:08PM +0530, Jerin Jacob wrote: > > On Wed, Oct 23, 2019 at 8:17 PM Olivier Matz wrote: > > > > > > Hi, > > > > > > On Wed, Oct 23, 2019 at 03:42:39PM +0530, Jerin Jacob wrote: > > > > On Tue, Oct 22, 20

Re: [dpdk-dev] [PATCH v3 0/2] fix distributor unit test

2019-10-24 Thread David Marchand
On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang wrote: > > Bug 342 reported distributor_autotest execution suspension > on aarch64 platform. > Issue was due to lack of synchronization among threads. Distributor > thread and worker thread may get deadlocked. > Fixed synchronization issue by adding ba

Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting

2019-10-24 Thread David Marchand
On Mon, Aug 19, 2019 at 1:41 PM Maxime Coquelin wrote: > On 8/19/19 10:40 AM, David Marchand wrote: > > On Thu, Aug 15, 2019 at 6:16 PM David Christensen > > wrote: > >> > Use of %llx print formatting causes meson build error on Power systems > with > RHEL 7.6 and gcc 4.8.5. Repl

Re: [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check

2019-10-24 Thread David Marchand
On Tue, Sep 17, 2019 at 4:38 PM Tianfei zhang wrote: > > Add pointer null check before dereference. > > Coverity issue: 344976 > Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status") > Cc: sta...@dpdk.org > > Signed-off-by: Tianfei zhang This patch touches a "base driver" file, is this ok

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-24 Thread David Marchand
On Thu, Oct 3, 2019 at 10:43 AM Sachin Saxena wrote: > > > > -Original Message- > > From: Babu Radhakrishnan, AgalyaX > > > > Sent: Tuesday, September 10, 2019 1:11 PM > > To: dev@dpdk.org > > Cc: Pattan, Reshma ; Hemant Agrawal > > ; Sachin Saxena ; > > Parthasarathy, JananeeX M ; > > st

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

2019-10-24 Thread David Marchand
On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov wrote: > > The rte_vfio_dma_map/unmap API's have been marked as deprecated in > release 19.05. Remove them. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > Although `rte_vfio_dma_map` et al. was marked as deprecated in our > documentation

Re: [dpdk-dev] [PATCH v2 2/2] eal: use define instead of raw flag name

2019-10-24 Thread David Marchand
On Thu, Oct 24, 2019 at 5:18 PM Anatoly Burakov wrote: > > We are using '--base-virtaddr' in a few places. We have a define for that, > so use it instead. > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/freebsd/eal/eal.c| 3 ++- > lib/librte_eal/freebsd/eal/eal_memory.c | 5 +++

Re: [dpdk-dev] [PATCH v2 1/2] eal/freebsd: add support for base virtaddr option

2019-10-24 Thread David Marchand
On Thu, Oct 24, 2019 at 5:18 PM Anatoly Burakov wrote: > > According to our docs, only Linuxapp supports base-virtaddr option. > That is, strictly speaking, not true because most of the things > that are attempting to respect base-virtaddr are in common files, > so FreeBSD already *mostly* support

Re: [dpdk-dev] Debug crash in bucket_enqueue ()

2019-10-24 Thread Ravi Kerur
On Thu, Oct 24, 2019 at 9:58 AM Andrew Rybchenko wrote: > Hello, > > please, see note on the following page: > https://doc.dpdk.org/guides/prog_guide/mempool_lib.html#mempool-handlers Thanks for your inputs. Note refers to '-d' for shared objects. In my case both OVS/DPDK and multi_process/simp

Re: [dpdk-dev] [PATCH v2 00/17] bnxt patchset with bug fixes

2019-10-24 Thread Ajit Khaparde
On Thu, Oct 24, 2019 at 3:52 AM Somnath Kotur wrote: > Please apply. > > Ajit Khaparde (3): > net/bnxt: fix to set MAX RSS contexts for maximal reservation > net/bnxt: fix to write the correct MTU to FW > net/bnxt: update HWRM API to version 1.10.1.6 > > Kalesh AP (6): > net/bnxt: fix unu

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Tx checksum problem when TSO enabled

2019-10-24 Thread Ferruh Yigit
On 10/24/2019 12:37 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: dev On Behalf Of Peng Huang >> Sent: Thursday, October 24, 2019 10:38 AM >> To: Zhang, Qi Z >> Cc: dev@dpdk.org; Ye, Xiaolong ; Xu, Ting >> ; Huang, Peng ; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH] app/t

Re: [dpdk-dev] [PATCH v5 06/15] sched: modify pkt enqueue for config flexibility

2019-10-24 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 24, 2019 5:45 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Krakowiak, LukaszX > Subject: Re: [dpdk-dev] [PATCH v5 06/15] sched: modify pkt enqueue for > config flexibility > > 14/10/2019

[dpdk-dev] [PATCH v6 15/15] sched: remove redundant code

2019-10-24 Thread Jasvinder Singh
Remove redundant data structure fields from port level data structures and update the release notes. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- doc/guides/rel_notes/release_19_11.rst | 7 - lib/librte_sched/rte_sched.c | 42 +- lib/

[dpdk-dev] [PATCH v6 13/15] ip_pipeline: add subport config flexibility to TM

2019-10-24 Thread Jasvinder Singh
Modify ip pipeline traffic management function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- examples/ip_pipeline/cli.c | 71 ++-

[dpdk-dev] [PATCH v6 14/15] examples/qos_sched: add subport configuration flexibility

2019-10-24 Thread Jasvinder Singh
Modify qos sample app to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- examples/qos_sched/app_thread.c | 20 ++- examples/qos_sched/cfg_file.c

[dpdk-dev] [PATCH v6 08/15] sched: update grinder functions for config flexibility

2019-10-24 Thread Jasvinder Singh
Modify packet grinder functions of the schedule to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 223

[dpdk-dev] [PATCH v6 11/15] test/sched: modify tests for subport config flexibility

2019-10-24 Thread Jasvinder Singh
Modify tests function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- app/test/test_sched.c | 35 ++- 1 file change

[dpdk-dev] [PATCH v6 09/15] sched: update pkt dequeue for flexible config

2019-10-24 Thread Jasvinder Singh
Modify scheduler packet dequeue operation to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 51 +++

[dpdk-dev] [PATCH v6 10/15] sched: update queue stats read for config flexibility

2019-10-24 Thread Jasvinder Singh
Modify pipe queue stats read function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 18 +++--- 1 file

[dpdk-dev] [PATCH v6 12/15] net/softnic: add subport config flexibility to TM

2019-10-24 Thread Jasvinder Singh
Modify softnic traffic management function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- drivers/net/softnic/rte_eth_softnic_tm.c | 54 ++

[dpdk-dev] [PATCH v6 03/15] sched: remove pipe params config from port level

2019-10-24 Thread Jasvinder Singh
Remove pipes configuration from the port level to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 254 ++---

[dpdk-dev] [PATCH v6 01/15] sched: add pipe config params to subport struct

2019-10-24 Thread Jasvinder Singh
Add pipe configuration parameters to subport level structure to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/Makefile| 2 +-

[dpdk-dev] [PATCH v6 06/15] sched: modify pkt enqueue for config flexibility

2019-10-24 Thread Jasvinder Singh
Modify scheduler packet enqueue operation of the scheduler to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 277 +

[dpdk-dev] [PATCH v6 02/15] sched: modify internal structs for config flexibility

2019-10-24 Thread Jasvinder Singh
Update internal structures related to port and subport to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 106 +

[dpdk-dev] [PATCH v6 04/15] sched: add pipe config to subport level

2019-10-24 Thread Jasvinder Singh
Add pipes configuration from the port level to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 388

[dpdk-dev] [PATCH v6 07/15] sched: update memory compute to support flexiblity

2019-10-24 Thread Jasvinder Singh
Update memory footprint compute function for allowing subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 110 +

[dpdk-dev] [PATCH v6 05/15] sched: modify pipe functions for config flexibility

2019-10-24 Thread Jasvinder Singh
Modify pipe level functions to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 103 +

[dpdk-dev] [PATCH v6 00/15] sched: subport level configuration of pipe nodes

2019-10-24 Thread Jasvinder Singh
This patchset refactors the dpdk qos sched library to allow subport level configuration flexibility of the pipe nodes. Currently, all parameters for the pipe nodes (subscribers) configuration are part of the port level structure which forces all groups of subscribers (pipes) in different subports

[dpdk-dev] [PATCH] net/virtio: fix broken Tx checksum offloads

2019-10-24 Thread Andrew Rybchenko
Missing parenthesis around expression before type cast to struct virtio_net_hdr pointer makes the arithmetic to be in sizeof(struct virtio_net_hdr) units. Use rte_pktmbuf_mtod_offset() to fix the problem. Type of head_size is changed to signed since some compilers bark on unary minus applied to u

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix IPv4 csum calculation

2019-10-24 Thread Ferruh Yigit
On 10/24/2019 5:29 PM, Flavio Leitner wrote: > Currently the IPv4 header checksum is calculated including its > current value, which can be a valid checksum or just garbage. > In any case, if the original value is not zero, then the result > is always wrong. > > The IPv4 checksum is defined in RFC

Re: [dpdk-dev] [EXT] Re: [PATCH v11 2/4] eal: add legacy kni option

2019-10-24 Thread Olivier Matz
Hi, On Wed, Oct 23, 2019 at 08:32:08PM +0530, Jerin Jacob wrote: > On Wed, Oct 23, 2019 at 8:17 PM Olivier Matz wrote: > > > > Hi, > > > > On Wed, Oct 23, 2019 at 03:42:39PM +0530, Jerin Jacob wrote: > > > On Tue, Oct 22, 2019 at 7:01 PM Vamsi Krishna Attunuru > > > wrote: > > > > > > > > Hi Fer

[dpdk-dev] Performance impact of "declaring" more CPU cores

2019-10-24 Thread Tom Barbette
Hi all, We're experiencing a very strange problem. The code of our application is modified to always use 8 cores. However, when running with "-l 0-MAXCPU", with MAXCPU varying between 7 and 15 (therefore "allocating" more *unused* cores), the performance of the application change. It can be m

Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove

2019-10-24 Thread Ferruh Yigit
On 10/24/2019 2:03 AM, Di ChenxuX wrote: > Hotplug remove cause infinite loops. Fix by canceling port_close > before port_detach function when rmv_port_callback. Can you please give more details/backtrace of how loop happens? How can trigger it? > > Fixes: ac89d46096d5 ("net/i40e: release port

Re: [dpdk-dev] [PATCH v3] mbuf: support dynamic fields and flags

2019-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2019 17:44:09 +0200 Thomas Monjalon wrote: > 24/10/2019 17:30, Stephen Hemminger: > > On Thu, 24 Oct 2019 10:13:37 +0200 > > Olivier Matz wrote: > > > > > +/** > > > + * Copy dynamic fields from msrc to mdst. > > > + * > > > + * @param mdst > > > + * The destination mbuf. > >

Re: [dpdk-dev] [PATCH v9 2/5] eal: add the APIs to wait until equal

2019-10-24 Thread Gavin Hu (Arm Technology China)
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 24, 2019 9:52 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; david.march...@redhat.com; > tho...@monjalon.net; step...@networkplumber.org; > hemant.agra...@nxp.com; jer...@marve

Re: [dpdk-dev] Debug crash in bucket_enqueue ()

2019-10-24 Thread Andrew Rybchenko
Hello, please, see note on the following page: https://doc.dpdk.org/guides/prog_guide/mempool_lib.html#mempool-handlers Andrew. On 10/24/19 7:42 PM, Ravi Kerur wrote: DPDK team, I have a simple multi process setup with OVS/DPDK as primary and another process as secondary. OVS/DPDK sets up mem

Re: [dpdk-dev] [dpdk-stable] [PATCH 05/10] crypto/dpaa2_sec: fix global variable multiple definitions

2019-10-24 Thread David Marchand
On Thu, Oct 24, 2019 at 4:55 PM Ferruh Yigit wrote: > > On 10/24/2019 3:53 PM, David Marchand wrote: > > On Thu, Sep 5, 2019 at 4:54 PM Ferruh Yigit wrote: > >> > >> 'rta_sec_era' global variable is defined in 'crypto/dpaa2_sec', > >> 'crypto/caam_jr' & 'crypto/dpaa_sec' PMDs with the same name.

Re: [dpdk-dev] [PATCH v5 06/15] sched: modify pkt enqueue for config flexibility

2019-10-24 Thread Thomas Monjalon
14/10/2019 19:23, Jasvinder Singh: > Modify scheduler packet enqueue operation of the scheduler to allow > different subports of the same port to have different configuration > in terms of number of pipes, pipe queue sizes, etc. > > Signed-off-by: Jasvinder Singh > Signed-off-by: Lukasz Krakowiak

[dpdk-dev] Debug crash in bucket_enqueue ()

2019-10-24 Thread Ravi Kerur
DPDK team, I have a simple multi process setup with OVS/DPDK as primary and another process as secondary. OVS/DPDK sets up mempool and rings with MP/MC flags and secondary process attaches to it. I have used example/multi-process/simple_mp as an example. I have disabled 'ASLR' and made sure primar

Re: [dpdk-dev] [PATCH v3] mbuf: support dynamic fields and flags

2019-10-24 Thread Thomas Monjalon
24/10/2019 10:13, Olivier Matz: > Many features require to store data inside the mbuf. As the room in mbuf > structure is limited, it is not possible to have a field for each > feature. Also, changing fields in the mbuf structure can break the API > or ABI. > > This commit addresses these issues,

Re: [dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11

2019-10-24 Thread Thomas Monjalon
23/10/2019 20:54, David Marchand: > Let's prepare for the ABI freeze. > > The first patches are about changes that had been announced before (with > a patch from Stephen that I took as it is ready as is from my pov). > > The malloc_heap structure from the memory subsystem can be hidden. > The PCI

Re: [dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Maxime Coquelin
On 10/24/19 6:31 PM, Flavio Leitner wrote: > On Thu, 24 Oct 2019 16:32:43 +0200 > Maxime Coquelin wrote: > >> Hi Flavio, >> >> On 10/24/19 4:28 PM, Flavio Leitner wrote: >>> Currently the IPv4 header checksum is calculated including its >>> current value, which can be a valid checksum or just

Re: [dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Flavio Leitner
On Thu, 24 Oct 2019 16:32:43 +0200 Maxime Coquelin wrote: > Hi Flavio, > > On 10/24/19 4:28 PM, Flavio Leitner wrote: > > Currently the IPv4 header checksum is calculated including its > > current value, which can be a valid checksum or just garbage. > > In any case, if the original value is not

Re: [dpdk-dev] [PATCH v2 08/12] log: hide internal log structure

2019-10-24 Thread Thomas Monjalon
23/10/2019 20:54, David Marchand: > No need to expose rte_logs, hide it and remove it from the current ABI. > > Signed-off-by: David Marchand > Acked-by: Stephen Hemminger [...] > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > -struct rte_log_dyna

[dpdk-dev] [PATCH v2] vhost: fix IPv4 csum calculation

2019-10-24 Thread Flavio Leitner
Currently the IPv4 header checksum is calculated including its current value, which can be a valid checksum or just garbage. In any case, if the original value is not zero, then the result is always wrong. The IPv4 checksum is defined in RFC791, page 14 says: Header Checksum: 16 bits The che

Re: [dpdk-dev] [PATCH v4] eal: fix proc type auto detection

2019-10-24 Thread Burakov, Anatoly
On 12-Aug-19 11:03 AM, David Marchand wrote: On Wed, Jul 24, 2019 at 6:08 PM Anatoly Burakov wrote: Currently, primary process holds an exclusive lock on the config file, thereby preventing other primaries from spinning up. However, when the primary dies, the lock is no longer being held, even

Re: [dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11

2019-10-24 Thread David Marchand
On Thu, Oct 24, 2019 at 5:37 PM Stephen Hemminger wrote: > > > > rte_logs could be hidden, but I am not that confortable about > > > > doing it right away: I added an accessor to rte_logs.file, but I am fine > > > > with dropping the last patch and wait for actually hiding this in the > > > > nex

Re: [dpdk-dev] [PATCH v5 09/12] test/fib: add FIB library autotests

2019-10-24 Thread Thomas Monjalon
01/10/2019 19:12, Medvedkin, Vladimir: > On 12/09/2019 15:07, Aaron Conole wrote: > > Vladimir Medvedkin writes: > > > >> Functional tests for the new FIB library. > >> > >> Signed-off-by: Vladimir Medvedkin > >> --- > >> app/test/Makefile | 1 + > >> app/test/autotest_data.py | 6

Re: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for head

2019-10-24 Thread Gavin Hu (Arm Technology China)
Hi Pavan, > -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, October 24, 2019 12:13 AM > To: Gavin Hu (Arm Technology China) ; > jer...@marvell.com; Pavan Nikhilesh > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for > head >

Re: [dpdk-dev] [PATCH v3] mbuf: support dynamic fields and flags

2019-10-24 Thread Thomas Monjalon
24/10/2019 17:30, Stephen Hemminger: > On Thu, 24 Oct 2019 10:13:37 +0200 > Olivier Matz wrote: > > > +/** > > + * Copy dynamic fields from msrc to mdst. > > + * > > + * @param mdst > > + * The destination mbuf. > > + * @param msrc > > + * The source mbuf. > > + */ > > +static inline void > >

Re: [dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11

2019-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2019 09:32:10 +0200 David Marchand wrote: > On Wed, Oct 23, 2019 at 11:10 PM Stephen Hemminger > wrote: > > > > On Wed, 23 Oct 2019 20:54:12 +0200 > > David Marchand wrote: > > > > > Let's prepare for the ABI freeze. > > > > > > The first patches are about changes that had been

Re: [dpdk-dev] [pull-request] next-crypto 19.11 rc1

2019-10-24 Thread Thomas Monjalon
23/10/2019 17:07, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Thomas Monjalon
24/10/2019 17:30, Andrew Rybchenko: > On 10/24/19 6:17 PM, Thomas Monjalon wrote: > > 24/10/2019 16:47, Andrew Rybchenko: > >> On 10/24/19 11:29 AM, Ori Kam wrote: > >>> Hi Andrew, > >>> > >>> When writing the new function I thought about using bool, but > >>> I decided against it for the following

Re: [dpdk-dev] [PATCH v3] mbuf: support dynamic fields and flags

2019-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2019 10:13:37 +0200 Olivier Matz wrote: > > +/** > + * Copy dynamic fields from msrc to mdst. > + * > + * @param mdst > + * The destination mbuf. > + * @param msrc > + * The source mbuf. > + */ > +static inline void > +rte_mbuf_dynfield_copy(struct rte_mbuf *mdst, const struc

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Andrew Rybchenko
On 10/24/19 6:17 PM, Thomas Monjalon wrote: 24/10/2019 16:47, Andrew Rybchenko: On 10/24/19 11:29 AM, Ori Kam wrote: Hi Andrew, When writing the new function I thought about using bool, but I decided against it for the following reasons: 1. There is no use of bool any where in the code, and th

[dpdk-dev] [PATCH v2 1/2] eal/freebsd: add support for base virtaddr option

2019-10-24 Thread Anatoly Burakov
According to our docs, only Linuxapp supports base-virtaddr option. That is, strictly speaking, not true because most of the things that are attempting to respect base-virtaddr are in common files, so FreeBSD already *mostly* supports this option in practice. This commit fixes the remaining bits t

[dpdk-dev] [PATCH v2 2/2] eal: use define instead of raw flag name

2019-10-24 Thread Anatoly Burakov
We are using '--base-virtaddr' in a few places. We have a define for that, so use it instead. Signed-off-by: Anatoly Burakov --- lib/librte_eal/freebsd/eal/eal.c| 3 ++- lib/librte_eal/freebsd/eal/eal_memory.c | 5 - lib/librte_eal/linux/eal/eal.c | 4 ++-- lib/librte_eal/li

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Thomas Monjalon
24/10/2019 16:47, Andrew Rybchenko: > On 10/24/19 11:29 AM, Ori Kam wrote: > > Hi Andrew, > > > > When writing the new function I thought about using bool, but > > I decided against it for the following reasons: > > 1. There is no use of bool any where in the code, and there is not special > > rea

Re: [dpdk-dev] [PATCH v1] power: fix vm power manager build without i40e

2019-10-24 Thread Bruce Richardson
On Thu, Oct 24, 2019 at 03:26:10PM +0100, David Hunt wrote: > channel_monitor.c was dependent on i40e driver being available. > This is only necessary for the TRAFFIC policy, so use #ifdef's > to not call these when i40e not available. > > Fixes: f14791a8126e ("examples/vm_power_mgr: add policy to

Re: [dpdk-dev] [dpdk-stable] [PATCH 05/10] crypto/dpaa2_sec: fix global variable multiple definitions

2019-10-24 Thread Ferruh Yigit
On 10/24/2019 3:53 PM, David Marchand wrote: > On Thu, Sep 5, 2019 at 4:54 PM Ferruh Yigit wrote: >> >> 'rta_sec_era' global variable is defined in 'crypto/dpaa2_sec', >> 'crypto/caam_jr' & 'crypto/dpaa_sec' PMDs with the same name. This means >> they share same storage when application linked wit

Re: [dpdk-dev] [dpdk-stable] [PATCH 05/10] crypto/dpaa2_sec: fix global variable multiple definitions

2019-10-24 Thread David Marchand
On Thu, Sep 5, 2019 at 4:54 PM Ferruh Yigit wrote: > > 'rta_sec_era' global variable is defined in 'crypto/dpaa2_sec', > 'crypto/caam_jr' & 'crypto/dpaa_sec' PMDs with the same name. This means > they share same storage when application linked with static DPDK > library, which is not the intention

Re: [dpdk-dev] [PATCH v2] net: add new header file for VXLAN

2019-10-24 Thread Ferruh Yigit
On 10/23/2019 2:19 PM, Flavia Musatescu wrote: > The VXLAN related definitions and structures are moved from > rte_ether.h to a new header file: rte_xvlan.h. > > Also introducing a new define macro for VXLAN default port id: > RTE_VXLAN_DEFAULT_PORT > > Signed-off-by: Flavia Musatescu Reviewed-

[dpdk-dev] [PATCH v3] net/mlx: fix icc build

2019-10-24 Thread Raslan Darawsheh
Trying to compile mlx5 pmd in debug mode with icc will lead to compilation failures due to the fact that icc doesn't have support for the pragma of pedantic. Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx4/Makefile | 5 - drivers/net/

Re: [dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Maxime Coquelin
Hi Flavio, On 10/24/19 4:28 PM, Flavio Leitner wrote: > Currently the IPv4 header checksum is calculated including its > current value, which can be a valid checksum or just garbage. > In any case, if the original value is not zero, then the result > is always wrong. > > The IPv4 checksum is defi

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Andrew Rybchenko
On 10/24/19 11:29 AM, Ori Kam wrote: Hi Andrew, When writing the new function I thought about using bool, but I decided against it for the following reasons: 1. There is no use of bool any where in the code, and there is not special reason to add it now. rte_ethdev.c includes stdbool.h and us

[dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Flavio Leitner
Currently the IPv4 header checksum is calculated including its current value, which can be a valid checksum or just garbage. In any case, if the original value is not zero, then the result is always wrong. The IPv4 checksum is defined in RFC791, page 14 says: Header Checksum: 16 bits The che

[dpdk-dev] [PATCH v1] power: fix vm power manager build without i40e

2019-10-24 Thread David Hunt
channel_monitor.c was dependent on i40e driver being available. This is only necessary for the TRAFFIC policy, so use #ifdef's to not call these when i40e not available. Fixes: f14791a8126e ("examples/vm_power_mgr: add policy to channels") Signed-off-by: David Hunt --- examples/vm_power_manager

Re: [dpdk-dev] [PATCH v2 3/3] net/af_xdp: enable support for unaligned umem chunks

2019-10-24 Thread Ferruh Yigit
On 10/24/2019 1:18 PM, David Marchand wrote: > On Thu, Oct 24, 2019 at 1:10 PM David Marchand > wrote: >> >> On Mon, Sep 30, 2019 at 6:45 PM Ciara Loftus wrote: >>> diff --git a/doc/guides/rel_notes/release_19_11.rst >>> b/doc/guides/rel_notes/release_19_11.rst >>> index 06bf57c42..22369107c 100

Re: [dpdk-dev] [PATCH v2 0/6] remove a few example applications

2019-10-24 Thread David Marchand
On Thu, Oct 24, 2019 at 3:35 PM Ciara Power wrote: > As discussed by the DPDK technical board e.g. [1][2] and on the DPDK > mailing list [3], we have a lot of example applications shipped with > DPDK - a number which increases with each DPDK release, and not all of > which are probably needed any

Re: [dpdk-dev] [PATCH v9 2/5] eal: add the APIs to wait until equal

2019-10-24 Thread Ananyev, Konstantin
> > Hi Gavin, > > > The rte_wait_until_equal_xx APIs abstract the functionality of > > 'polling for a memory location to become equal to a given value'. > > > > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled > > by default. When it is enabled, the above APIs will call WFE i

Re: [dpdk-dev] [PATCH v9 2/5] eal: add the APIs to wait until equal

2019-10-24 Thread Ananyev, Konstantin
Hi Gavin, > The rte_wait_until_equal_xx APIs abstract the functionality of > 'polling for a memory location to become equal to a given value'. > > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled > by default. When it is enabled, the above APIs will call WFE instruction > to save

Re: [dpdk-dev] [PATCH] net/mlx5: fix LRO dependency to include DV flow

2019-10-24 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Thursday, October 24, 2019 15:47 > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix LRO dependency to include DV flow > > Rx queue for LRO is created using D

[dpdk-dev] [Bug 357] ppc64: i40e not compiling on RHEL7/CentOS7

2019-10-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=357 Bug ID: 357 Summary: ppc64: i40e not compiling on RHEL7/CentOS7 Product: DPDK Version: unspecified Hardware: POWER OS: Linux Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v2 6/6] examples/load_balancer: remove example from DPDK

2019-10-24 Thread Ciara Power
This example can be removed because DPDK now has a range of libraries, especially rte_eventdev, that did not exist previously for load balancing, making this less relevant. Also, modern NIC cards have greater ability to do load balancing, e.g. using RSS, over a wider range of fields than earlier ca

[dpdk-dev] [PATCH v2 3/6] examples/l3fwd-vf: remove example from DPDK

2019-10-24 Thread Ciara Power
From: Bruce Richardson The main l3fwd app should work with both PF and VF devices, so remove the VF-only l3fwd example. Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger Acked-by: Hemant Agrawal --- MAINTAINERS |3 - doc/guides/sample_app_ug/in

  1   2   3   >