Re: [dpdk-dev] examples/l3fwd-power: fix RX interrupt disable

2019-09-19 Thread Liu, Yong
> -Original Message- > From: Zhang, Xiao > Sent: Wednesday, September 11, 2019 12:10 AM > To: dev@dpdk.org > Cc: Liu, Yong ; Zhang, Xiao ; > sta...@dpdk.org > Subject: examples/l3fwd-power: fix RX interrupt disable > > Interrupt will not be received when disabling RX interrupt without > sy

[dpdk-dev] [PATCH v7 08/10] vhost: add vring functions packed ring support

2019-09-19 Thread Jin Yu
This patch add packed ring support in two APIs so user can get the packed ring`. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/vhost.c | 68 +--- 1 file changed, 49 insertions(+), 19 deletions

[dpdk-dev] [PATCH v7 09/10] vhost: add an API for judging vq format

2019-09-19 Thread Jin Yu
This patch introduces an API for getting virtqueue format. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 13 + lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/vhost.c

[dpdk-dev] [PATCH v7 10/10] vhost: add vhost-user-blk example which support inflight

2019-09-19 Thread Jin Yu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so It can show how there APIs work to support inflight feature. Signed-off-by: Jin Yu --- V1 - add the case. V2 - add the rte_vhost prefix. V3 - add packed ring support --- examples/v

[dpdk-dev] [PATCH v7 07/10] vhost: add APIs for user getting inflight ring

2019-09-19 Thread Jin Yu
This patch introduces two APIs. one is for getting inflgiht ring and the other is for getting base. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 40 + lib/librte_vhost/rte_vhost_version.m

[dpdk-dev] [PATCH v7 06/10] vhost: add the APIs to operate inflight ring

2019-09-19 Thread Jin Yu
This patch introduces three APIs to operate the inflight ring. Three APIs are set, set last and clear. It includes split and packed ring. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 116 +++ lib

[dpdk-dev] [PATCH v7 03/10] vhost: add the inflight structure

2019-09-19 Thread Jin Yu
This patch adds the inflight queue region structure include the split and packed. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 43 1 file changed, 43 insertions(+) diff --git

[dpdk-dev] [PATCH v7 04/10] vhost: add two new messages to support a shared buffer

2019-09-19 Thread Jin Yu
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/vhost.h | 7

[dpdk-dev] [PATCH v7 00/10] vhost: support inflight share memory protocol feature

2019-09-19 Thread Jin Yu
This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Now It can both support split and packed ring. The example code show how these API work. The test has passed. How to test the example

[dpdk-dev] [PATCH v7 05/10] vhost: checkout the resubmit inflight information

2019-09-19 Thread Jin Yu
This patch shows how to checkout the inflight ring and construct the resubmit information also include destroying resubmit info. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 19 +++ lib/librte_vhost/vhost.c

[dpdk-dev] [PATCH v7 02/10] vhost: add packed ring

2019-09-19 Thread Jin Yu
This patch add the packed ring in the rte_vhost_vring. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu Reviewed-by: Maxime Coquelin --- lib/librte_vhost/rte_vhost.h | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/

[dpdk-dev] [PATCH v7 01/10] vhost: add the inflight description

2019-09-19 Thread Jin Yu
This patch add the inflight message description and the inflight share fd protocol feature flag. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu Reviewed-by: Maxime Coquelin --- v1 - specify the APIs are split-ring only v2 - fix APIs and judge split o

[dpdk-dev] [PATCH v2] app/testpmd: fix Segment fault when start fwd

2019-09-19 Thread Wang ShougangX
This patch fixed the reset function to avoid crash when user don't call port stop, port reset and port start functions as sequence. Fixes: 97f1e19679 ("app/testpmd: add port reset command") Cc: sta...@dpdk.org Signed-off-by: Wang ShougangX --- app/test-pmd/testpmd.c | 2 ++

Re: [dpdk-dev] [PATCH v7] net/i40e: limit the number of VF messages

2019-09-19 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Friday, September 20, 2019 6:23 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v7] net/i40e: limit the number of VF messages > > From: Alvin Zhang > > PF driver supportes counting VF adminQ messages. If any

[dpdk-dev] [PATCH] net/i40e: fix conflict with multi-driver

2019-09-19 Thread alvinx . zhang
From: Alvin Zhang If support-multi-driver option been set, we suppose the DPDK will not modify the value of global register GLQF_FD_MSK. Current situation is if we create a new flow with 'flow creat ...' command, the register value may be changed. Fixes: cfdfca493cae ("net/i40e: fix multiple dri

[dpdk-dev] [PATCH v1 2/2] net/ice: add GTP type in tunneling parse

2019-09-19 Thread Ting Xu
Add GTP tunnel type in ice pmd tunneling parameters parse to enable checksum offload. Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_19_11.rst | 5 + drivers/net/ice/ice_rxtx.c | 1 + 2 files changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst

[dpdk-dev] [PATCH v1 1/2] lib/mbuf: add GTP tunnel type flag

2019-09-19 Thread Ting Xu
Add GTP tunnel type flag in mbuf for future use in GTP checksum offload. Signed-off-by: Ting Xu --- lib/librte_mbuf/rte_mbuf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 98225ec80..0a5d67d9a 100644 --- a/lib/librte_mbuf/rte

[dpdk-dev] [PATCH v1 0/2] net/ice: enable GTP checksum offload

2019-09-19 Thread Ting Xu
In this patchset, minor modifications are made in ice pmd and mbuf to enable GTP tx checksum offload in CVL. Add the GTP tunnel type flag. Ting Xu (2): lib/mbuf: add GTP tunnel type flag net/ice: add GTP type in tunneling parse doc/guides/rel_notes/release_19_11.rst | 5 + drivers/net/ic

[dpdk-dev] [PATCH v7] net/i40e: limit the number of VF messages

2019-09-19 Thread alvinx . zhang
From: Alvin Zhang PF driver supportes counting VF adminQ messages. If any VF driver sending much more adminQ messages to it's PF driver in a period of time, it will trigger the PF's message limiting, then in the next certain amount of seconds the PF driver will ignore any new adminQ message from

Re: [dpdk-dev] [RFC] igb_uio: change ISR to be threaded when using with RT kernel

2019-09-19 Thread Liu, Yongxin
Hi DPDK experts, This patch is especially used for PREEMPT_RT kernel. Whether it is correct, please share your opinion. Thanks, Yongxin > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongxin Liu > Sent: Friday, September 20, 2019 08:45 > To: dev@dpdk.org >

Re: [dpdk-dev] [PATCH v6 01/17] net/i40e: i40e support ipn3ke FPGA port bonding

2019-09-19 Thread Zhang, Qi Z
> -Original Message- > From: Pei, Andy > Sent: Thursday, September 19, 2019 5:03 PM > To: dev@dpdk.org > Cc: Xu, Rosen ; Zhang, Tianfei ; > Ye, Xiaolong ; Zhang, Qi Z ; > Lomartire, David ; Yigit, Ferruh > > Subject: [PATCH v6 01/17] net/i40e: i40e support ipn3ke FPGA port bonding > >

[dpdk-dev] [RFC] igb_uio: change ISR to be threaded when using with RT kernel

2019-09-19 Thread Yongxin Liu
When igb_uio driver is used with RT kernel, the interrupt handler should not use IRQF_NO_THREAD as a flag, since uio_event_notify will call rt_spin_lock which might sleep. Here is the calltrace. [ 2034.457805] Call Trace: [ 2034.460818] [ 2034.463397] dump_stack+0x70/0x9a [ 2034.467281] ___mi

Re: [dpdk-dev] [PATCH v8] net/ice: support device-specific DDP package loading

2019-09-19 Thread Ye Xiaolong
On 09/17, Ting Xu wrote: >This patch adds the feature that supports loading DDP package >according to the device serial number. Prior to loading the >default DDP package (ice.pkg), the driver will check for the >presence of a device-specific DDP package with the name containing >64-bit PCIe Device

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-09-19 Thread Ju-Hyoung Lee
+ @Abhishek Marathe -Original Message- From: Yu, PingX Sent: Thursday, September 19, 2019 3:22 AM To: Kevin Traynor ; sta...@dpdk.org; dev@dpdk.org Cc: dev@dpdk.org; Akhil Goyal ; Ali Alnubani ; Walker, Benjamin ; David Christensen ; Hemant Agrawal ; Stokes, Ian ; Jerin Jacob ; Mcnama

Re: [dpdk-dev] [EXT] Re: [PATCH 1/5] net/bnx2x: update and reorganize HW registers

2019-09-19 Thread Rasesh Mody
Hi Jerin, >From: Jerin Jacob >Sent: Thursday, September 12, 2019 5:18 AM > >-- >On Fri, Sep 6, 2019 at 12:57 PM Rasesh Mody wrote: >> >> Update and reorganize HW registers in preparation to update the >> firmware to version 7.1

[dpdk-dev] [PATCH v2 4/4] doc: cleanup SPDX license id usage in bnx2x guide

2019-09-19 Thread Rasesh Mody
Removed redundant BSD boilerplate text from bnx2x guide. Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst | 26 -- 1 file changed, 26 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index d3650267f..67d765af8 100644 --- a/doc/guide

[dpdk-dev] [PATCH v2 3/4] net/bnx2x: update to latest FW 7.13.11

2019-09-19 Thread Rasesh Mody
Use latest firmware 7.13.11. Some of the fixes included with this FW are as following: - Packets from a VF with pvid configured which were sent with a different vlan were transmitted instead of being discarded. - In some multi-function configurations, inter-PF and inter-VF Tx s

[dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW

2019-09-19 Thread Rasesh Mody
Hi, Currently, BNX2X PMD uses a very old firmware 7.2.51. This patch series updated the base driver to use to latest firmware 7.13.11. The latest firmware comprises of enhancements and fixes. v2: - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11" - Addressed most of chec

[dpdk-dev] [Bug 350] ixgbe: incorrect speed capabilities advertised for X553 devices

2019-09-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=350 Bug ID: 350 Summary: ixgbe: incorrect speed capabilities advertised for X553 devices Product: DPDK Version: 19.08 Hardware: All OS: Linux Status: UNCONFI

Re: [dpdk-dev] [EXT] [PATCH] crypto/openssl: support SG for inplace buffers

2019-09-19 Thread Akhil Goyal
Hi Anoob, > Hi Akhil, > > As per current support, scatter Gather is only supported for out of place > input > > [Anoob] s/scatter/Scatter Ok > > > and output buffers. > > This patch add support for scatter gather for inplace buffers. > > > > Signed-off-by: Akhil Goyal > > --- > > doc/guides/cry

Re: [dpdk-dev] [PATCH 03/20] security: add hfn override option in PDCP

2019-09-19 Thread Akhil Goyal
Hi Konstantin/Anoob/Radu, Any comments on this patch. Regards, Akhil > > HFN can be given as a per packet value also. > As we do not have IV in case of PDCP, and HFN is > used to generate IV. IV field can be used to get the > per packet HFN while enq/deq > If hfn_ovrd field in pdcp_xform is set,

Re: [dpdk-dev] [PATCH 0/7] Add PDCP test cases

2019-09-19 Thread Akhil Goyal
Hi Anoob, Konstantin, Any comments on this patchset. Regards, Akhil > > This patch add test vectors and a test framework for PDCP > cplane and uplane protocol processing based on various > sequence number sizes(5/7/12/15/18). > > These test cases and test vectors are validated over NXP DPAA_SEC

Re: [dpdk-dev] [PATCH v3 3/3] examples/ipsec-secgw: support IPv6 tunnel for lookaside proto

2019-09-19 Thread Akhil Goyal
Hi Konstantin, Could you please review this patch. Thanks, Akhil > > IPv6 tunnels are already supported in case of inline and > lookaside none cases. In case of protocol offload, the details > for IPv6 header need to be added in session configuration > for security session create. > > Signed-of

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-19 Thread Bruce Richardson
On Thu, Sep 19, 2019 at 02:28:04PM +0100, Ray Kinsella wrote: > > > On 19/09/2019 13:35, Andrzej Ostruszka wrote: > > On 9/18/19 3:32 PM, Ray Kinsella wrote: > ...> > > Compilation time is much longer. In a normal hack|fix/compile/repeat > > cycle with "compile" part being simple "make" the link

Re: [dpdk-dev] [EXT] [PATCH V2] crypto/octeontx: enable unbinding for the OCTEON TX crypto engines

2019-09-19 Thread Akhil Goyal
> > Version history has to be after ---. > > @Akhil, can you make this change when you submit? Done. > > Acked-by: Anoob Joseph > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] drivers/crypto/dpaa_sec: update DPAA iova table in dpaa_mem_vtop

2019-09-19 Thread Akhil Goyal
> > dpaa_sec needs translations between physical and virtual addresses. > V to P translation is relatively fast, as memory is managed in > contiguous segments. > > The result of each V to P translation is used to update the DPAA iova > table, which should be updated by a Mem event callback, but i

Re: [dpdk-dev] [PATCH] crypto/qat: fix digest length in XCBC capability

2019-09-19 Thread Akhil Goyal
> > > > Digest length in RTE_CRYPTO_AUTH_AES_XCBC_MAC capability was > > incorrectly marked 16 bytes, should be 12. > > > > Fixes: 6a3c87bc6a6c ("crypto/qat: refactor capabilities infrastructure") > > cc: sta...@dpdk.org > > > > Signed-off-by: Fiona Trahe > > --- > Acked-by: Arek Kusztal Applied

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: modify chain order for AES-CCM

2019-09-19 Thread Akhil Goyal
> > Up to version 0.52 of the IPSec Multi buffer library, > the chain order for AES-CCM was CIPHER_HASH when encrypting. > However, after this version, the order has been reversed in the library > since, when encrypting, hashing is done first and then ciphering. > > Therefore, order is changed

Re: [dpdk-dev] [PATCH] test/crypto: fix unit test failure for virtual cryptodev

2019-09-19 Thread Akhil Goyal
> > armv8 cryptodev virtual PMD autotest failed with output: > CRYPTODEV: [CRYPTODEV_NAME_ARMV8_CRYPTO_PMD] > armv8_crypto_pmd_qp_create_processed_ops_ring() line 210: > Unable to reuse existing ring armv8_crypto_pmd_0_qp_0 for processed ops > CRYPTODEV: rte_cryptodev_stop() line 942: > Device wit

Re: [dpdk-dev] [PATCH v2] security: update doxygen fields

2019-09-19 Thread Akhil Goyal
> > Replace /**< with /** for multiline doxygen comments. > > Fixes: c261d1431bd8 ("security: introduce security API and framework") > Cc: sta...@dpdk.org > > Signed-off-by: Radu Nicolau > Acked-by: Akhil Goyal > Acked-by: Anoob Joseph > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v3] security: add statistics definitions and update API

2019-09-19 Thread Akhil Goyal
> > > > Update IPsec statistics struct definition, add per SA > > statistics collection enable flag. > > > > Signed-off-by: Radu Nicolau > > --- > > v2: added second reserved field > > v3: update doc > > > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 1/2] crypto/caam_jr: reduce the function trace from critical path

2019-09-19 Thread Akhil Goyal
> From: Hemant Agrawal > > Reducing the functional traces from data path and critical session path > > Signed-off-by: Hemant Agrawal > Acked-by: Akhil Goyal > --- Series Applied to dpdk-next-crypto

[dpdk-dev] [PATCH] build: print out dependency names for clarity

2019-09-19 Thread Bruce Richardson
To help developers to get the correct dependency name e.g. when creating a new example that depends on a specific component, print out the dependency name for each lib/driver as it is processed. Signed-off-by: Bruce Richardson --- drivers/meson.build | 3 +++ lib/meson.build | 6 -- 2 fi

Re: [dpdk-dev] [PATCH] drivers/crypto: enable esn for dpaa/dpaa2/caam_jr

2019-09-19 Thread Akhil Goyal
> If the application enables the use of ESN in the > ipsec_xform for security session create, pdb options > are set for enabling ESN. > > Signed-off-by: Akhil Goyal > --- Changed title to drivers/crypto: enable esn for NXP PMDs Applied to dpdk-next-crypto

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: detach queues in session destroy

2019-09-19 Thread Akhil Goyal
> crypto queues need to be detached while session destroy > so that they can be reused. > > Signed-off-by: Akhil Goyal > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add offload error handling

2019-09-19 Thread Akhil Goyal
> > > > From: Michael Shamis > > > > Added error handler for offload mode. > > > > Signed-off-by: Michael Shamis > > --- > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix access to freed packet

2019-09-19 Thread Akhil Goyal
> > > > > For unknown/unsupported packets, the packet would get checked for > inline > > offloads after the packet is freed. > > > > Fixes: 0ccfd14bc10d ("examples/ipsec-secgw: support inline protocol") > > > > Signed-off-by: Anoob Joseph > > --- > Acked-by: Akhil Goyal Applied to dpdk-next-c

Re: [dpdk-dev] [PATCH] test/compress: return -ENOTSUP on capability get error

2019-09-19 Thread Akhil Goyal
> This patch fixes the return value of the test_deflate_comp_decomp > function on capabilities retrieval error to be -ENOTSUP. > > It also fixes passing of the test_deflate_comp_decomp function's > return value to the upper level (as the test suite function return > value). > > Signed-off-by: Ada

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ipsec-secgw: fix unchecked return value

2019-09-19 Thread Akhil Goyal
> > > > > 07/08/2019 15:39, Akhil Goyal: > > > > > > > > > > > Check the return value of the rte_eth_dev_rss_hash_conf_get > function. > > > > > > > > Coverity issue: 344970 > > > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline > > crypto") > > > > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH] cryptodev: fix pmd allocation on multi-process

2019-09-19 Thread Akhil Goyal
> Primary process is responsible to initialize the data struct of each > crypto devices. > > Secondary process should not override this data during the > initialization. > > Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto > devices") > Cc: sta...@dpdk.org > > Signed-off

Re: [dpdk-dev] [PATCH] app/compress-perf: fix floating point exception

2019-09-19 Thread Akhil Goyal
> > This patch fixes the floating point exception that happened > when the number of cores to be used during the benchmark > was zero. After the fix such situation is detected, the error > message is printed and the benchmark application exits. > > Fixes: 424dd6c8c1a8 ("app/compress-perf: add wea

Re: [dpdk-dev] [PATCH] app/compress-perf: fix memory deallocation issue

2019-09-19 Thread Akhil Goyal
> > This patch fixes the memory deallocation issue which happened > after unsuccessful allocation (e.g. due to the out of memory) > and produced the segmentation fault. > > Fixes: 424dd6c8c1 ("app/compress-perf: add weak functions for multicore > test") > > Signed-off-by: Adam Dybkowski > --- A

Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name

2019-09-19 Thread Akhil Goyal
> > > > -Original Message- > > From: Dybkowski, AdamX > > Sent: Tuesday, August 6, 2019 10:10 AM > > To: dev@dpdk.org; Trahe, Fiona ; Luse, Paul E > > > Cc: Dybkowski, AdamX > > Subject: [PATCH] compress/isal: create shorter qp name > > > > This patch shortens the queue pair name create

Re: [dpdk-dev] [PATCH v4 1/6] examples/ioat: create sample app on ioat driver usage

2019-09-19 Thread Baran, MarcinX
-Original Message- From: Bruce Richardson Sent: Thursday, September 19, 2019 4:44 PM To: Baran, MarcinX Cc: dev@dpdk.org; Modrak, PawelX Subject: Re: [PATCH v4 1/6] examples/ioat: create sample app on ioat driver usage On Thu, Sep 19, 2019 at 11:38:45AM +0200, Marcin Baran wrote: >

Re: [dpdk-dev] [PATCH v4 1/6] examples/ioat: create sample app on ioat driver usage

2019-09-19 Thread Bruce Richardson
On Thu, Sep 19, 2019 at 11:38:45AM +0200, Marcin Baran wrote: > From: Pawel Modrak > > A new sample app demonstrating use of driver for CBDMA. > The app receives packets, performs software or hardware > copy, changes packets' MAC addresses (if enabled) and > forwards them. The change covers ports

[dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-19 Thread Ciara Loftus
Network devices using the AF_XDP PMD will trigger interrupts on reception of packets. The new PMD argument 'queue_irq' allows the user to specify a core on which to pin interrupts for a given queue. Multiple queue_irq arguments can be specified. For example: --vdev=net_af_xdp1,iface=eth0,queue_c

[dpdk-dev] [PATCH 0/3] AF_XDP tx halt fix, IRQ pinning and unaligned chunks

2019-09-19 Thread Ciara Loftus
This series contains 3 patches for the AF_XDP PMD. They were originally independent patches but are now rolled into this series together. Patch 1: fix Tx halt when no recv packets (Xiaolong Ye) Previous (v1): http://patches.dpdk.org/patch/59044/ Patch 2: support pinning of IRQs Previous (v1): htt

[dpdk-dev] [PATCH 3/3] net/af_xdp: enable support for unaligned umem chunks

2019-09-19 Thread Ciara Loftus
This patch enables the unaligned chunks feature for AF_XDP which allows chunks to be placed at arbitrary places in the umem, as opposed to them being required to be aligned to 2k. This allows for DPDK application mempools to be mapped directly into the umem and in turn enable zero copy transfer bet

[dpdk-dev] [PATCH 1/3] net/af_xdp: fix Tx halt when no recv packets

2019-09-19 Thread Ciara Loftus
From: Xiaolong Ye The kernel only consumes Tx packets if we have some Rx traffic on specified queue or we have called send(). So we need to issue a send() even when the allocation fails so that kernel will start to consume packets again. Commit 45bba02c95b0 ("net/af_xdp: support need wakeup feat

Re: [dpdk-dev] [PATCH 4/4] doc/guides: add stateful feature in QAT

2019-09-19 Thread Akhil Goyal
Hi Fiona, If there are no more changes expected in this patchset. Could you please Ack it? I will squash the documentation patch myself with 2/4 patch of this set. > > Hi Adam, > > > > This patch adds the information about stateful decompression > > feature in QAT PMD. > > > Could you please squa

Re: [dpdk-dev] [PATCH 4/4] doc/guides: add stateful feature in QAT

2019-09-19 Thread Akhil Goyal
Hi Adam, > > This patch adds the information about stateful decompression > feature in QAT PMD. > Could you please squash this documentation patch with the patch where the Functionality is added. If multiple functionality/patches split this patch and merge In the relevant feature patch. > Signe

[dpdk-dev] [PATCH v2] eal: don't call RTE_LOG before init

2019-09-19 Thread Stephen Hemminger
rte_init_alert is called before rte_log is initialized. Therefore RTE_LOG() should not be used (only stderr). For VFIO, it is initialized after rte_log_init therefore, use RTE_LOG. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-19 Thread Ray Kinsella
On 19/09/2019 13:35, Andrzej Ostruszka wrote: > On 9/18/19 3:32 PM, Ray Kinsella wrote: ...> > Compilation time is much longer. In a normal hack|fix/compile/repeat > cycle with "compile" part being simple "make" the link time might be a > bit annoying. So I imagine keeping LTO off for the most

[dpdk-dev] [PATCH v5 2/2] net/failsafe: implement xstats

2019-09-19 Thread Stephen Hemminger
Add support for extended statistics in failsafe driver. Reports basic statistics for the failsafe driver, and detailed statistics for each sub device. Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ops.c | 135 1 file chang

[dpdk-dev] [PATCH v5 1/2] ethdev: expose basic xstats for driver use

2019-09-19 Thread Stephen Hemminger
Avoid duplication by having generic basic xstats available for use by drivers. A later patch uses this for failsafe driver. Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet --- lib/librte_ethdev/rte_ethdev.c | 17 +++ lib/librte_ethdev/rte_ethdev_driver.h| 65 ++

[dpdk-dev] [PATCH v5 0/2] failsafe: add xstats

2019-09-19 Thread Stephen Hemminger
A useful feature of netvsc PMD is the ability to see how many packets were processed through the VF device. This patch set adds a similar (but more limited) capability to failsafe driver. Since failsafe doesn't have top level xstats, this set uses the generic xstats that exist already as a base th

Re: [dpdk-dev] [PATCH 0/8] Fips validation fixes

2019-09-19 Thread Akhil Goyal
Hi Michael, I see that there are compilation issues with meson build Please check http://mails.dpdk.org/archives/test-report/2019-September/098161.html Also run devtools/check-git-log.sh -. You should have a fixes line in each of the fix commits as stated earlier also. Please have a look at htt

[dpdk-dev] [PATCH v4 0/2] failsafe: add xstats

2019-09-19 Thread Stephen Hemminger
A useful feature of netvsc PMD is the ability to see how many packets were processed through the VF device. This patch set adds a similar (but more limited) capability to failsafe driver. Since failsafe doesn't have top level xstats, this set uses the generic xstats that exist already as a base th

[dpdk-dev] [PATCH 2/2] net/failsafe: implement xstats

2019-09-19 Thread Stephen Hemminger
Add support for extended statistics in failsafe driver. Reports basic statistics for the failsafe driver, and detailed statistics for each sub device. Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ops.c | 135 1 file chang

[dpdk-dev] [PATCH 1/2] ethdev: expose basic xstats for driver use

2019-09-19 Thread Stephen Hemminger
Avoid duplication by having generic basic xstats available for use by drivers. A later patch uses this for failsafe driver. Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet --- lib/librte_ethdev/rte_ethdev.c | 17 +++ lib/librte_ethdev/rte_ethdev_driver.h| 65 ++

Re: [dpdk-dev] [PATCH v3] net/iavf: enable AVX2 for iavf

2019-09-19 Thread Zhang, Qi Z
minor capture inline > -Original Message- > From: Rong, Leyi > Sent: Thursday, September 19, 2019 4:45 PM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Ye, Xiaolong > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH v3] net/iavf: enable AVX2 for iavf > > This patch enables AVX data path for iavf PM

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-19 Thread Andrzej Ostruszka
On 9/18/19 3:32 PM, Ray Kinsella wrote: > this is cool, good work. > comments below. [...]>> +CONFIG_RTE_ENABLE_LTO=n >> + >> # >> # Compile to share library >> # > > Why would we make this optional in this way and expand the matrix of > different ways to build DPDK. To ask another way, why woul

[dpdk-dev] [PATCH v2 2/3] examples/fips_validation: added support AES ECB

2019-09-19 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- .../fips_validation/fips_validation_aes.c | 1 + examples/fips_validation/main.c | 96 +-- 2 files changed, 91 insertions(+), 6 deletions(-) diff --git a/examples/fips_validation/fips_validation_aes.c b/

[dpdk-dev] [PATCH v2 0/3] Support ECB for AES and TDES

2019-09-19 Thread michaelsh
From: Michael Shamis Michael Shamis (3): examples/fips_validation: added support for TDES ECB examples/fips_validation: added support AES ECB examples/fips_validation: separated init for TDES ECB and CBC examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_

[dpdk-dev] [PATCH v2 1/3] examples/fips_validation: added support for TDES ECB

2019-09-19 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_validation.h| 7 + .../fips_validation/fips_validation_tdes.c| 7 + examples/fips_validation/main.c | 27 ---

[dpdk-dev] [PATCH v2 3/3] examples/fips_validation: separated init for TDES ECB and CBC

2019-09-19 Thread michaelsh
From: Michael Shamis TDES: IV, PT and CT are initiated according to ECB or CBC cipher mode now Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 66 + 1 file changed, 50 insertions(+), 16 deletions(-) diff --git a/examples/fips_validation/main

[dpdk-dev] [PATCH 6/8] examples/fips_validation: fix overwrite of KEY line in TDES

2019-09-19 Thread michaelsh
From: Michael Shamis Fix for TCBCMonte2, TCBCMonte3 and TECBMonte2: application overwrites key1 line in output file so comparision with sample files failed Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 20 1 file changed, 20 insertions(+)

[dpdk-dev] [PATCH 7/8] examples/fips_validation: improve algo parsing logic

2019-09-19 Thread michaelsh
From: Michael Shamis The fix allows to find algorithm by folder name if the algorithm was not found from the test file header. In order to find algorithm used the folder name if it is not defined within the file. Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 4

[dpdk-dev] [PATCH 5/8] examples/fips_validation: fix AES-GCM decryption vector

2019-09-19 Thread michaelsh
From: Michael Shamis AES-GCM CAVS vectors for decryption set PTlen (plain text length) but provide crypto text and application expected CTlen to be not null. Now we assign PTlen to CTlen in decryption scenario and it allows to application to handle AES-GCM decryption vectors. Signed-off-by: Mich

[dpdk-dev] [PATCH 4/8] examples/fips_validation: move digest after cipher text

2019-09-19 Thread michaelsh
From: Michael Shamis Fix of GCM FIPS bug: ICV was not copied after the crypto text in decryption operation so driver failed to check authentication in GCM mode. Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/fi

[dpdk-dev] [PATCH 3/8] examples/fips_validation: initialize IV for AES-GCM

2019-09-19 Thread michaelsh
From: Michael Shamis Configurated AES-GCM IV may include only salt value which length is 12B. In this case driver should set second part of IV to initial value = 0x1. Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletion

[dpdk-dev] [PATCH 8/8] examples/fips_validation: fix plain text overwrite

2019-09-19 Thread michaelsh
From: Michael Shamis fix erroneous overwrite of PLAINTEXT-line after [DECRYPT] tag Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/examples/fips_validation/fips_validation.c b/examples

[dpdk-dev] [PATCH 0/8] Fips validation fixes

2019-09-19 Thread michaelsh
From: Michael Shamis Include fixes related to SHA, TDES and GCM. Michael Shamis (8): examples/fips_validation: separation between HMAC-SHA and SHA examples/fips_validation: fix structs used for AES-GCM examples/fips_validation: initialize IV for AES-GCM examples/fips_validation: move dig

[dpdk-dev] [PATCH 2/8] examples/fips_validation: fix structs used for AES-GCM

2019-09-19 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation_gcm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c index 0509b

[dpdk-dev] [PATCH 1/8] examples/fips_validation: separation between HMAC-SHA and SHA

2019-09-19 Thread michaelsh
From: Michael Shamis Fix: SHA initialization will not be called in case of HAMC-SHA Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/fips_validation/fips_validation.c b/exampl

[dpdk-dev] [PATCH] kni: add ability to set min/max MTU

2019-09-19 Thread Igor Ryzhov
Starting with kernel version 4.10, there are new min/max MTU values in net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by default. We should be able to change these values to allow MTU more than 1500 to be set on KNI. Signed-off-by: Igor Ryzhov --- examples/kni/main.c

[dpdk-dev] [PATCH] net/axgbe: fix double unlock coverity issue

2019-09-19 Thread Pallantla Poornima
One issue caught by Coverity 340835 *unlock: axgbe_phy_set_mode unlocks pdata->phy_mutex *double_unlock: axgbe_phy_sfp_detect unlocks pdata->phy_mutex while it is unlocked. In axgbe_phy_sfp_detect()/axgbe_phy_set_redrv_mode(), axgbe_phy_get_comm_ownership() and axgbe_phy_put_comm_ownership() are i

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: add fallback session

2019-09-19 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, September 19, 2019 1:04 PM > To: Anoob Joseph ; Smoczynski, MarcinX > ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Narayana Prasad Raju Athreya ; > Jerin Jacob Kollanukkaran ;

Re: [dpdk-dev] [PATCH v3 05/10] examples/l2fwd-event: add eventdev queue and port setup

2019-09-19 Thread Sunil Kumar Kori
>+static void >+event_port_setup_generic(void) >+{ >+ struct eventdev_resources *eventdev_rsrc = get_eventdev_rsrc(); >+ uint8_t event_d_id = eventdev_rsrc->event_d_id; >+ struct rte_event_port_conf event_p_conf = { >+ .dequeue_depth = 32, >+ .enqueue_depth

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-09-19 Thread Yu, PingX
Hi all, Update Intel test result here. # Basic Intel(R) NIC testing * PF(i40e): Pass * PF(ixgbe): Pass * VF: Pass * Build or compile: 3 bugs are found. 1. [dpdk-stable 18.11.3] compile error on freebsd12 2. [dpdk-stable 18.11.3] meson build error on ub1604-i86 3. [dpdk-stable 18.11.3] confi

[dpdk-dev] [PATCH v3 05/10] examples/l2fwd-event: add eventdev queue and port setup

2019-09-19 Thread pbhagavatula
From: Pavan Nikhilesh Add event device queue and port setup based on event eth Tx adapter capabilities. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_eventdev.c | 10 + examples/l2fwd-event/l2fwd_eventdev.h | 18 ++ examples/l2

[dpdk-dev] [PATCH v3 09/10] examples/l2fwd-event: add graceful teardown

2019-09-19 Thread pbhagavatula
From: Pavan Nikhilesh Add graceful teardown that addresses both event mode and poll mode. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/main.c | 44 + 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd-event/main.c b/exam

[dpdk-dev] [PATCH v3 07/10] examples/l2fwd-event: add service core setup

2019-09-19 Thread pbhagavatula
From: Sunil Kumar Kori Add service core setup when eventdev and Rx/Tx adapter don't have internal port capability. Signed-off-by: Sunil Kumar Kori --- examples/l2fwd-event/l2fwd_eventdev_generic.c | 31 +++ .../l2fwd_eventdev_internal_port.c| 6 examples/l2fwd

[dpdk-dev] [PATCH v3 08/10] examples/l2fwd-event: add eventdev main loop

2019-09-19 Thread pbhagavatula
From: Pavan Nikhilesh Add event dev main loop based on enabled l2fwd options and eventdev capabilities. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_eventdev.c | 273 ++ examples/l2fwd-event/main.c | 10 +- 2 files changed, 280 insertions(+),

[dpdk-dev] [PATCH v3 10/10] doc: add application usage guide for l2fwd-event

2019-09-19 Thread pbhagavatula
From: Sunil Kumar Kori Add documentation for l2fwd-event example. Update MAINTAINERS file claiming responsibility of l2fwd-event. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 5 + doc/guides/sample_app_ug/index.rst| 1 + doc/guides/sample_

[dpdk-dev] [PATCH v3 04/10] examples/l2fwd-event: add eth port setup for eventdev

2019-09-19 Thread pbhagavatula
From: Sunil Kumar Kori Add ethernet port Rx/Tx queue setup for event device which are later used for setting up event eth Rx/Tx adapters. Signed-off-by: Sunil Kumar Kori --- examples/l2fwd-event/l2fwd_eventdev.c | 114 ++ examples/l2fwd-event/l2fwd_eventdev.h | 1 + e

[dpdk-dev] [PATCH v3 06/10] examples/l2fwd-event: add event Rx/Tx adapter setup

2019-09-19 Thread pbhagavatula
From: Pavan Nikhilesh Add event eth Rx/Tx adapter setup for both generic and internal port event device pipelines. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_eventdev.c | 3 + examples/l2fwd-event/l2fwd_eventdev.h | 17 +++

[dpdk-dev] [PATCH v3 01/10] examples/l2fwd-event: add default poll mode routines

2019-09-19 Thread pbhagavatula
From: Sunil Kumar Kori Add the default l2fwd poll mode routines similar to examples/l2fwd. Signed-off-by: Sunil Kumar Kori --- examples/Makefile | 1 + examples/l2fwd-event/Makefile | 57 +++ examples/l2fwd-event/l2fwd_common.h | 26 + examples/l2fwd-event/main.c

[dpdk-dev] [PATCH v3 00/10] example/l2fwd-event: introduce l2fwd-event example

2019-09-19 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds a new application to demonstrate the usage of event mode. The poll mode is also available to help with the transition. The following new command line parameters are added: --mode: Dictates the mode of operation either poll or event. --eventq_sync: Dicta

[dpdk-dev] [PATCH v3 03/10] examples/l2fwd-event: add infra to split eventdev framework

2019-09-19 Thread pbhagavatula
From: Pavan Nikhilesh Add infra to split eventdev framework based on event Tx adapter capability. If event Tx adapter has internal port capability then we use `rte_event_eth_tx_adapter_enqueue` to transmitting packets else we use a SINGLE_LINK event queue to enqueue packets to a service core whic

  1   2   >