[dpdk-dev] [PATCH] net/mlx5: fix typo in error message

2019-08-19 Thread Dekel Peled
This patch fixes a typing mistake in an error message. Fixes: 2e4c987aad91 ("net/mlx5: validate Direct Rule E-Switch") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flo

Re: [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file

2019-08-19 Thread Tiwei Bie
On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote: > This function is declared __rte_always_inline so it > seems unnecessary to include it in the map file. In > addition, it was included in the EXPERIMENTAL section > even though the function itself is not marked > __rte_experimental. > >

[dpdk-dev] [PATCH v2] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2019-08-19 Thread Myers, Charles
From: Charles Myers When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() fails with -ENOTSUP and mtu is not stored in the mtu field in the rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is shared with hypervisor to always be set to 1500. This may cause issues r

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-08-19 Thread Wang, Xiang W
Thanks Jerin. Comments inline. -Original Message- From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] Sent: Monday, August 19, 2019 11:09 AM To: Thomas Monjalon ; dev@dpdk.org Cc: Pavan Nikhilesh Bhagavatula ; Shahaf Shuler ; Hemant Agrawal ; Opher Reviv ; Alex Rosenbaum ; Dovra

Re: [dpdk-dev] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa

2019-08-19 Thread Louis Luo
Hi Maxime, Thanks for the fix. Actually Yong and I had some discussion about removing TX IP CSUM offload flag last August and I did prepare a fix but later forgot to submit. Anyway your fix is fine. Thanks, Louis On 8/13/19, 6:30 AM, "Maxime Leroy" wrote: The vmxnet3_prep_pkts function

[dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file

2019-08-19 Thread Jim Harris
This function is declared __rte_always_inline so it seems unnecessary to include it in the map file. In addition, it was included in the EXPERIMENTAL section even though the function itself is not marked __rte_experimental. Found by check-experimental-syms.sh when trying to compile DPDK with -fin

Re: [dpdk-dev] [PATCH v4] timer: don't check tsc flags in secondary processes

2019-08-19 Thread Stephen Hemminger
On Mon, 19 Aug 2019 02:42:10 -0700 Jim Harris wrote: > check_tsc_flags() parses /proc/cpuinfo and prints > warning messages if any cores don't have constant_tsc > and nonstop_tsc. It has no functional meaning. > This consumes a noticeable amount of time in > secondary processes - on my test syst

[dpdk-dev] [PATCH v4] timer: don't check tsc flags in secondary processes

2019-08-19 Thread Jim Harris
check_tsc_flags() parses /proc/cpuinfo and prints warning messages if any cores don't have constant_tsc and nonstop_tsc. It has no functional meaning. This consumes a noticeable amount of time in secondary processes - on my test system, it consumes 21ms out of the 66ms total execution time for rte

Re: [dpdk-dev] [PATCH v3 1/2] timer: use rte_mp_msg to pass TSC hz to secondary procs

2019-08-19 Thread Harris, James R
On 8/16/19, 12:19 PM, "dev on behalf of Jim Harris" wrote: rte_eal_init() is much faster in secondary processes since hugepages don't need to be zeroed. But there's still non-trivial delays in the timer subsystem initialization due to the 100ms sleep used to calculate TSC hz.

Re: [dpdk-dev] [PATCH 03/11] drivers/baseband: use new logtype wrapper

2019-08-19 Thread Chautru, Nicolas
On 8/19/19, David Marchand wrote: > Make use of the newly introduced wrapper. > > Signed-off-by: David Marchand Acked-by: Nicolas Chautru

Re: [dpdk-dev] [PATCH v2] eal: unmap undesired address upon config reattach failure

2019-08-19 Thread David Marchand
On Mon, Aug 19, 2019 at 3:58 PM Arnon Warshavsky wrote: > > Have rte_eal_config_reattach clean up the mapped address > which is a valid address but not the one intended. > > Coverity issue: 343439 > Fixes: 4e8854ae89fa ("eal: do not panic on shared memory init") > Fixes: b149a7064261 ("eal/freebsd

Re: [dpdk-dev] [PATCH 10/11] drivers/net: use new logtype wrapper

2019-08-19 Thread Legacy, Allain
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, August 19, 2019 7:42 AM > To: dev@dpdk.org > Cc: John W. Linville; Xiaolong Ye; Qi Zhang; Igor Russkikh; Pavel Belous; > Legacy, Allain; Peters, Matt; Ravi Kumar; Rasesh Mody; Shahed Shaikh; Ajit

Re: [dpdk-dev] [PATCH v2] eal: unmap undesired address upon config reattach failure

2019-08-19 Thread Burakov, Anatoly
On 19-Aug-19 2:57 PM, Arnon Warshavsky wrote: Have rte_eal_config_reattach clean up the mapped address which is a valid address but not the one intended. Coverity issue: 343439 Fixes: 4e8854ae89fa ("eal: do not panic on shared memory init") Fixes: b149a7064261 ("eal/freebsd: add config reattach

[dpdk-dev] [Bug 342] distributor_autotest execution gets suspended

2019-08-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=342 Bug ID: 342 Summary: distributor_autotest execution gets suspended Product: DPDK Version: 19.08 Hardware: ARM OS: All Status: UNCONFIRMED Severity: minor

[dpdk-dev] [Bug 341] repeated execution of distributor_autotest fails

2019-08-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=341 Bug ID: 341 Summary: repeated execution of distributor_autotest fails Product: DPDK Version: 19.08 Hardware: All OS: Linux Status: UNCONFIRMED Severity: minor

[dpdk-dev] [PATCH v2] eal: unmap undesired address upon config reattach failure

2019-08-19 Thread Arnon Warshavsky
Have rte_eal_config_reattach clean up the mapped address which is a valid address but not the one intended. Coverity issue: 343439 Fixes: 4e8854ae89fa ("eal: do not panic on shared memory init") Fixes: b149a7064261 ("eal/freebsd: add config reattach in secondary") Signed-off-by: Arnon Warshavsky

[dpdk-dev] [PATCH] mk: add support for UBSAN

2019-08-19 Thread Harman Kalra
UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior detector. UBSan modifies the program at compile-time to catch various kinds of undefined behavior during program execution. This patch implements support for UBSan to the DPDK. See: doc/guides/prog_guide/ubsan.rst for more informatio

Re: [dpdk-dev] [PATCH 01/11] log: fix plugin level restore with patterns

2019-08-19 Thread Andrew Rybchenko
On 8/19/19 2:41 PM, David Marchand wrote: Same fix as the commit 6ff0f81d0ef7 ("log: fix pattern matching"), fnmatch returns 0 on success. Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing") Fixes: 6ff0f81d0ef7 ("log: fix pattern matching") Cc: sta...@dpdk.org Signed-off-by

Re: [dpdk-dev] [PATCH] Change email in maintainers file

2019-08-19 Thread Aaron Conole
Michael Santana writes: > Change email address for Michael Santana to personal email in the > MAINTAINERS file > > Signed-off-by: Michael Santana > Signed-off-by: Michael Santana > --- > > NOTE: My internship at Red Hat is ending soon so I will not be able > to monitor my red hat email. I will

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-08-19 Thread Andrew Rybchenko
On 8/19/19 2:41 PM, David Marchand wrote: The function rte_log_register_type_and_pick_level() fills a gap for dynamically loaded code (especially drivers) who would not pick up the log level passed at startup. Let's promote it to stable and export it for use by drivers via a wrapper. Signed-off

Re: [dpdk-dev] [PATCH v2] ethdev: add more protocol support in flow API

2019-08-19 Thread Zhang, Qi Z
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, August 14, 2019 5:08 PM > To: Wang, Ying A > Cc: Zhang, Qi Z ; Ye, Xiaolong ; > Yang, Qiming ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add more protocol support in flow

[dpdk-dev] [PATCH 11/11] drivers/raw: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 8 ++-- drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 8 ++-- drivers/raw/ifpga/ifpga_rawdev.c | 8 ++-- drivers/raw/ioat/ioat_rawdev.c | 8 ++-- drivers/

[dpdk-dev] [PATCH 07/11] drivers/crypto: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 7 ++--- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 6 ++-- drivers/crypto/caam_jr/caam_jr.c | 8 ++--- drivers/crypto/dpaa2_sec/dpaa2_s

[dpdk-dev] [PATCH 08/11] drivers/event: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++-- drivers/event/octeontx/ssovf_evdev.c | 8 ++-- drivers/event/octeontx/timvf_evdev.c | 8 ++-- drivers/event/opdl/opdl_evdev.c | 9 ++--- drivers/event/s

[dpdk-dev] [PATCH 06/11] drivers/compress: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/compress/isal/isal_compress_pmd.c | 8 ++-- drivers/compress/octeontx/otx_zip_pmd.c | 8 ++-- drivers/compress/zlib/zlib_pmd.c | 8 ++-- 3 files changed, 6 insertions(+), 18 deletions(-) d

[dpdk-dev] [PATCH 05/11] drivers/common: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/common/dpaax/dpaax_iova_table.c | 8 ++--- drivers/common/octeontx/octeontx_mbox.c | 8 ++--- drivers/common/octeontx2/otx2_common.c | 62 - drivers/common/qat/qat_logs.c

[dpdk-dev] [PATCH 10/11] drivers/net: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/net/af_packet/rte_eth_af_packet.c | 8 ++-- drivers/net/af_xdp/rte_eth_af_xdp.c | 8 ++-- drivers/net/atlantic/atl_ethdev.c | 13 - drivers/net/avp/avp_ethdev.c |

[dpdk-dev] [PATCH 09/11] drivers/mempool: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 8 ++-- drivers/mempool/octeontx/octeontx_fpavf.c | 8 ++-- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/

[dpdk-dev] [PATCH 00/11] Fixing log levels for dynamically loaded drivers

2019-08-19 Thread David Marchand
All (but the Solarflare net driver) drivers currently do not care about the log level the user might have passed at init time. Convert existing drivers from rte_log_register to a new wrapper RTE_LOG_REGISTER that relies on rte_log_register_type_and_pick_level that handles this issue. -- David M

[dpdk-dev] [PATCH 03/11] drivers/baseband: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 11 --- drivers/baseband/null/bbdev_null.c | 8 ++-- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 8 ++-- 3 files changed, 8 insert

[dpdk-dev] [PATCH 01/11] log: fix plugin level restore with patterns

2019-08-19 Thread David Marchand
Same fix as the commit 6ff0f81d0ef7 ("log: fix pattern matching"), fnmatch returns 0 on success. Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing") Fixes: 6ff0f81d0ef7 ("log: fix pattern matching") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/common

[dpdk-dev] [PATCH 04/11] drivers/bus: use new logtype wrapper

2019-08-19 Thread David Marchand
Make use of the newly introduced wrapper. Signed-off-by: David Marchand --- drivers/bus/dpaa/dpaa_bus.c | 26 -- drivers/bus/fslmc/fslmc_bus.c| 9 ++--- drivers/bus/ifpga/ifpga_bus.c| 8 ++-- drivers/bus/vdev/vdev.c | 8 ++-- drivers/b

[dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-08-19 Thread David Marchand
The function rte_log_register_type_and_pick_level() fills a gap for dynamically loaded code (especially drivers) who would not pick up the log level passed at startup. Let's promote it to stable and export it for use by drivers via a wrapper. Signed-off-by: David Marchand --- lib/librte_eal/com

Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting

2019-08-19 Thread Maxime Coquelin
On 8/19/19 10:40 AM, David Marchand wrote: > On Thu, Aug 15, 2019 at 6:16 PM David Christensen > wrote: >> Use of %llx print formatting causes meson build error on Power systems with RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. + (uint64_

[dpdk-dev] [PATCH 3/3] vhost: protect vring access done by application

2019-08-19 Thread Tiwei Bie
Besides the enqueue/dequeue API, other APIs of the builtin net backend should also be protected. Fixes: a3688046995f ("vhost: protect active rings from async ring changes") Cc: sta...@dpdk.org Reported-by: Peng He Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost.c | 50 +

[dpdk-dev] [PATCH 2/3] vhost: fix vring addr handling during live migration

2019-08-19 Thread Tiwei Bie
When live migration starts, QEMU will set ring addrs again for each virtqueue. In this case, we should try to translate ring addrs after we invalidating the ring, otherwise virtqueues can be enabled with the addrs untranslated. Besides, also leverage the access_ok flag in non-IOMMU case to prevent

[dpdk-dev] [PATCH 1/3] vhost: do not realloc device and queues during running

2019-08-19 Thread Tiwei Bie
When the device has been started, don't do the reallocation anymore. Otherwise the pointers used in application threads can be invalidated without proper protection. Instead of introducing a global lock to protect the change of device pointers which will hurt the performance, let's just do the real

[dpdk-dev] [PATCH 0/3] Some fixes for vhost

2019-08-19 Thread Tiwei Bie
Tiwei Bie (3): vhost: do not realloc device and queues during running vhost: fix vring addr handling during live migration vhost: protect vring access done by application lib/librte_vhost/vhost.c | 53 ++- lib/librte_vhost/vhost_user.c | 15 -- 2

[dpdk-dev] [PATCH ] event/octeontx2: fix Rx adapter capabilities

2019-08-19 Thread pbhagavatula
From: Pavan Nikhilesh Octeontx2 SSO co-processor allows multiple ethernet device Rx queues connected to a single Event device queue. Fix the Rx adapter capabilities to allow application to configure Rx queueus in n:1 ratio to event queues by adding `RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ` as a

Re: [dpdk-dev] [PATCH] pci: remove unnecessary access() check

2019-08-19 Thread David Marchand
On Tue, Aug 13, 2019 at 5:38 PM Stephen Hemminger wrote: > > Just open the sysfs file and handle failure, rather than > using access(). This eliminates Coverity warnings about > "time of check versus time of use"; although for this sysfs > file that is not really an issue anyway. > > Coverity ID:

Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler

2019-08-19 Thread David Marchand
On Wed, Aug 14, 2019 at 3:43 AM Chas Williams <3ch...@gmail.com> wrote: > > > > > On 7/2/19 11:01 AM, Ferruh Yigit wrote: > > On 5/16/2019 10:12 AM, David Marchand wrote: > >> Hello Chas, > >> > >> On Fri, Apr 19, 2019 at 12:50 AM Chas Williams <3ch...@gmail.com> wrote: > >> > >>> On 4/18/19 3:11 A

Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting

2019-08-19 Thread David Marchand
On Thu, Aug 15, 2019 at 6:16 PM David Christensen wrote: > > >> Use of %llx print formatting causes meson build error on Power systems with > >> RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. > >> > >> + (uint64_t)reg_struct.range.start, > >> +

Re: [dpdk-dev] [PATCH] eal: unmap undesired address upon config reattach failure

2019-08-19 Thread David Marchand
On Sun, Aug 18, 2019 at 8:47 AM Arnon Warshavsky wrote: > > Have rte_eal_config_reattach clean up the mapped address > which is a valid address but not the one intended. > > Coverity issue: 343439 Fixes: 4e8854ae89fa ("eal: do not panic on shared memory init") Since the issue was hidden before th

[dpdk-dev] [Bug 339] net/af_packet: af_packet driver is leaving stale socket after device is removed

2019-08-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=339 abhishek sachan (abhishek.sac...@altran.com) changed: What|Removed |Added CC||dev@dpdk.org -- Yo

Re: [dpdk-dev] [RFC] ethdev: allow multiple security sessions to use one rte flow

2019-08-19 Thread Akhil Goyal
Hi Anoob, > > Hi Akhil, > > > > > > > > > > > > > > > The rte_security API which enables inline protocol/crypto > > > > > > > feature mandates that for every security session an rte_flow is > > created. > > > > > > > This would internally translate to a rule in the hardware > > > > > > > which wo