Re: [dpdk-dev] [Suspected-Phishing][PATCH] net/vhost: fix redundant queue state event

2019-06-25 Thread Noa Ezra
Hi, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, June 25, 2019 11:24 AM > To: Noa Ezra > Cc: Matan Azrad ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [Suspected-Phishing][PATCH] net/vhost: fix redundant queue > state event > > > >

Re: [dpdk-dev] [PATCH 0/3] some update on CVL shared code

2019-06-25 Thread Yang, Qiming
Hi, Leyi Seems still have compile issue. Like, /tmp/SUSE15-64_K4.12.14_Clang5.0.1/x86_64-native-linuxapp-clang/251e3d92c8954331a686b2e9a9b73e2a/dpdk/drivers/net/ice/base/ice_switch.c:4636:18: error: comparison of constant 16 with expression of type 'enum ice_protocol_type' is always true [-Werro

Re: [dpdk-dev] [EXT] Re: [PATCH v6 2/4] lib/kni: add PCI related information

2019-06-25 Thread Vamsi Krishna Attunuru
From: Stephen Hemminger Sent: Tuesday, June 25, 2019 11:11 PM To: Vamsi Krishna Attunuru Cc: dev@dpdk.org; ferruh.yi...@intel.com; olivier.m...@6wind.com; arybche...@solarflare.com Subject: [EXT] Re: [dpdk-dev] [PATCH v6 2/4] lib/kni: add PCI related informat

Re: [dpdk-dev] [PATCH 2/3] net/ice/base: add support for ethertype switch filters

2019-06-25 Thread Zhao1, Wei
Tested-by: Wei Zhao > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong > Sent: Wednesday, June 26, 2019 10:30 AM > To: Ye, Xiaolong ; Yang, Qiming > > Cc: dev@dpdk.org; Rong, Leyi ; Nowlin, Dan > ; Stillwell Jr, Paul M > Subject: [dpdk-dev] [PATCH 2/3

[dpdk-dev] [PATCH 1/3] net/ice/base: add support for IPv6 based switch filters

2019-06-25 Thread Leyi Rong
- Add IPv6 switch rule support. - Add IPv6 training packet. - Correct name of IPv6 header variable. - Fix enum values so that they point to the proper ice_prot_ext_tbl_entry field. Signed-off-by: Kevin Scott Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base

[dpdk-dev] [PATCH 2/3] net/ice/base: add support for ethertype switch filters

2019-06-25 Thread Leyi Rong
Add protocol definitions for ethertype. Add ice_ethtype_hdr structure definition into the ice_prot_hdr union. Add ethtype offsets into the training packet maps. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_protocol_type.h |

[dpdk-dev] [PATCH 0/3] some update on CVL shared code

2019-06-25 Thread Leyi Rong
Main changes: 1. Add support for IPv6 based switch filters 2. Add support for ethertype switch filters 3. fix inner L2 offset in GRE dummy packet Leyi Rong (3): net/ice/base: add support for IPv6 based switch filters net/ice/base: add support for ethertype switch filters net/ice/base: fix in

[dpdk-dev] [PATCH 3/3] net/ice/base: fix inner L2 offset in GRE dummy packet

2019-06-25 Thread Leyi Rong
The offset for the inner L2 header in the dummy GRE packet was off by 2 bytes so updated the offset. Fixes: 4b018e5ce54d ("net/ice/base: enable additional switch rules") Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 2 +- 1 file changed, 1

Re: [dpdk-dev] [PATCH v7 0/3] Enable rte_flow API in ice driver

2019-06-25 Thread Yang, Qiming
Hi, It seems these error induced by lack of some base code which are merged in dpdk-next-net-intel branch. It's not this patch set's issue. Qiming -Original Message- From: Aaron Conole [mailto:acon...@redhat.com] Sent: Tuesday, June 25, 2019 10:58 PM To: Yang, Qiming Cc: dev@dpdk.org Su

[dpdk-dev] [PATCH v3 4/4] examples/ipsec-secgw: add bypass test case

2019-06-25 Thread Konstantin Ananyev
Add simple test-case with all traffic in BYPASS mode. Useful for some basic test of your network environment. Signed-off-by: Konstantin Ananyev --- examples/ipsec-secgw/test/bypass_defs.sh | 45 1 file changed, 45 insertions(+) create mode 100644 examples/ipsec-secgw/te

[dpdk-dev] [PATCH v3 3/4] examples/ipsec-secgw: add multi-segment test cases

2019-06-25 Thread Konstantin Ananyev
Enhance test scripts to support fragmentation/reassemble functionality. Signed-off-by: Konstantin Ananyev --- examples/ipsec-secgw/test/common_defs.sh | 18 +++--- examples/ipsec-secgw/test/data_rxtx.sh | 18 ++ examples/ipsec-secgw/test/linux_test4.sh | 17

[dpdk-dev] [PATCH v3 2/4] examples/ipsec-secgw: support packet fragmentation and reassembly

2019-06-25 Thread Konstantin Ananyev
Add optional ability to fragment packet bigger then mtu, and reassemble fragmented packet. To minimize possible performance effect, reassembly is implemented as RX callback. To support these features ipsec-secgw relies on librte_ipsec ability to handle multi-segment packets. Also when reassemble/fr

[dpdk-dev] [PATCH v3 1/4] examples/ipsec-secgw: fix invalid packet length

2019-06-25 Thread Konstantin Ananyev
for packets smaller then 64B some NICs reports pkt_len=64B. As ipsec-secgw (and librte_ipsec) relies on pkt_len value to determine payload length, that causes problems for small packets. To fix the issue, check that pkt_len matches values in IPv4/IPv6 header and re-adjust pkt_len if necessary. Fix

[dpdk-dev] [PATCH v3 0/4] examples/ipsec-secgw: support packet

2019-06-25 Thread Konstantin Ananyev
v1 -> v2 - merge with latest mainline - update sample app guide v2 -> v3 address Akhil comments: - merge with latest mainline - squash sample app guide changes with ipsec-secgw changes Add into ipsec-secgw ability to fragment packet bigger then mtu, and reassemble fragmented packet. To suppo

[dpdk-dev] [PATCH] net/bnx2x: fix build error with icc

2019-06-25 Thread Rasesh Mody
Fix a compilation issue seen with icc 19 Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/elink.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index d569366..b65126d 100644 --- a/drivers/net/bnx2x/elink.c +++ b/drive

Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler

2019-06-25 Thread Rasesh Mody
>From: David Marchand >Sent: Tuesday, June 25, 2019 6:39 AM > >-- >rte_intr_enable/rte_intr_disable configure the interrupt context on the >kernel side (either uio or vfio). >In VFIO case, calling it from the interrupt handlers tr

Re: [dpdk-dev] [PATCH] maintainers: claim maintainership of net-mrvl sub tree

2019-06-25 Thread Thomas Monjalon
25/06/2019 09:32, Ferruh Yigit: > On 6/25/2019 6:42 AM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Claim the maintainership of the sub tree dpdk-next-net-mrvl, > > which covers all the Marvell network PMDs. > > > > Cc: Maciej Czekaj > > Cc: Shijith Thotton > > Cc: Liron Himi > >

Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and mempool driver

2019-06-25 Thread Thomas Monjalon
22/06/2019 15:23, jer...@marvell.com: > From: Jerin Jacob > > This patch set adds initial driver support for OCTEON TX2 SoC. > > OCTEON TX2 is an armv8.2 SoC with integrated HW based mempool, ethdev, > cryptodev, compressdev, and eventdev devices. > > This patch set adds common driver and mempo

Re: [dpdk-dev] [PATCH v4 27/27] doc: add Marvell OCTEON TX2 mempool documentation

2019-06-25 Thread Thomas Monjalon
22/06/2019 15:24, jer...@marvell.com: > --- a/doc/guides/rel_notes/release_19_08.rst > +++ b/doc/guides/rel_notes/release_19_08.rst > @@ -171,6 +171,7 @@ The libraries prepended with a plus sign were incremented > in this version. > librte_cfgfile.so.2 > librte_cmdline.so.2 > lib

[dpdk-dev] [PATCH 3/3] lib/hash: adjust tbl_chng_cnt position

2019-06-25 Thread Honnappa Nagarahalli
tbl_chng_cnt is one of the first elements of the structure used in the lookup. Move it to the beginning of the cache line to gain performance. Fixes: e605a1d36 ("hash: add lock-free r/w concurrency") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Tested-by: Ruifen

[dpdk-dev] [PATCH 1/3] lib/hash: use ordered loads only if signature matches

2019-06-25 Thread Honnappa Nagarahalli
Relaxed signature comparison is done first. Further ordered loads are done only if the signature matches. Any false positives are caught by the full key comparison. Fixes: e605a1d36 ("hash: add lock-free r/w concurrency") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin

[dpdk-dev] [PATCH 2/3] lib/hash: load pData after full key compare

2019-06-25 Thread Honnappa Nagarahalli
When a hash entry is added, there are 2 sets of stores. 1) The application writes its data to memory (whose address is provided in rte_hash_add_key_with_hash_data API (or NULL)) 2) The rte_hash library writes to its own internal data structures; key store entry and the hash table. The only orderi

[dpdk-dev] [PATCH 0/3] lib/hash: perf improvements for lock-free

2019-06-25 Thread Honnappa Nagarahalli
While using the rte_hash library, there are 2 sets of stores that happen. 1) The application writes its data to memory (whose address is provided in rte_hash_add_key_with_hash_data API (or NULL)) 2) The rte_hash library writes to its own internal data structures; key store entry and the hash table

[dpdk-dev] Compilation error fixed by other patch

2019-06-25 Thread Morten Brørup
Dear CI team, Some patches failed compilation in CI due to unrelated compilation errors, which have now been fixed. The fixes for the unrelated compilation errors are these: https://patchwork.dpdk.org/patch/55085/ https://patchwork.dpdk.org/patch/55086/ A couple of my patches that failed compil

[dpdk-dev] [PATCH] ipsec: packet with null encryption can cause a segfault

2019-06-25 Thread Konstantin Ananyev
mbuf_get_seg_ofs() doesn't handle the case when requested offset equals to packet length. Though it is a valid situation for algorithms with no ICV data (IPsec with null encryption as an example). Fixes: 12a0423236a9 ("ipsec: support multi-segment packets") Signed-off-by: Konstantin Ananyev ---

Re: [dpdk-dev] [PATCH v6 2/4] lib/kni: add PCI related information

2019-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2019 09:26:58 +0530 wrote: > From: Vamsi Attunuru > > PCI related information is needed in KNI kernel module, > since it requires iommu domain info for address > translations(using iommu_iova_to_phys() call) when > KNI runs in IOVA = VA mode. > > Signed-off-by: Vamsi Attunuru >

Re: [dpdk-dev] [PATCH v3] net/avp: remove resources when port is closed

2019-06-25 Thread Ferruh Yigit
On 6/19/2019 12:33 PM, Peters, Matt wrote: >> -Original Message- >> From: Legacy, Allain >> Sent: Tuesday, June 18, 2019 3:19 PM >> To: tho...@monjalon.net >> Cc: dev@dpdk.org; ferruh.yi...@intel.com; Peters, Matt >> Subject: [PATCH v3] net/avp: remove resources when port is closed >> >> Th

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/softnic: remove trace of legacy "linuxapp"

2019-06-25 Thread Ferruh Yigit
On 6/17/2019 8:54 AM, David Marchand wrote: > This check on Linux environment has been added at a time when we already > had switched to using the boolean RTE_EXEC_ENV_LINUXAPP. > It was then missed when converting to RTE_EXEC_ENV_LINUX. > > Fixes: 7709a63bf178 ("net/softnic: add connection agent"

[dpdk-dev] [PATCH] devtools: return error on failure

2019-06-25 Thread Ferruh Yigit
Currently script is always returning success, returning failure on error helps on using script on automation tools. Signed-off-by: Ferruh Yigit --- devtools/check-git-log.sh | 56 ++- 1 file changed, 43 insertions(+), 13 deletions(-) diff --git a/devtools/che

Re: [dpdk-dev] [PATCH] vhost: support inflight share memory protocol feature

2019-06-25 Thread Maxime Coquelin
You need to specify the revision number when using git format-patch. You can see the 'contributing' section in the documentation for more information. On 6/25/19 6:18 PM, JinYu wrote: This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support tran

[dpdk-dev] [PATCH 2/2] timer: fix resource leak in finalize

2019-06-25 Thread Anatoly Burakov
Currently, whenever timer library is initialized, the memory is leaked because there is no telling when primary or secondary processes get to use the state, and there is no way to initialize/deinitialize timer library state without race conditions because the data itself must live in shared memory.

[dpdk-dev] [PATCH 1/2] eal: add internal locks for timer lib into EAL

2019-06-25 Thread Anatoly Burakov
Currently, timer library has a memory leak because there is no way to concurrently initialize/deinitialize shared memory because of race conditions [1]. Add a spinlock to the shared mem config to have a way to exclusively initialize/deinitialize the timer library without any races. [1] See the fo

[dpdk-dev] [PATCH 0/2] Fix timer resource leak

2019-06-25 Thread Anatoly Burakov
Previous attempts [1] at fixing the resource leak have been deemed unsuccessful because of limitations around what can be done without breaking the ABI. Now that we've broken the EAL ABI, we can fix this issue properly. This patchset is adding a new lock API, as well as fixes the actual issue. Th

[dpdk-dev] [PATCH v2 13/14] eal: unify internal config initialization

2019-06-25 Thread Anatoly Burakov
Currently, each EAL will update internal/shared config in their own way at init, resulting in needless duplication of code and OS-dependent behavior. Move the functions to a common file and add missing FreeBSD steps. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 18

[dpdk-dev] [PATCH v2 14/14] eal: prevent different primary/secondary process versions

2019-06-25 Thread Anatoly Burakov
Currently, nothing stops DPDK to attempt to run primary and secondary processes while having different versions. This can lead to all sorts of weird behavior and makes it harder to maintain compatibility without breaking ABI every once in a while. Fix it by explicitly disallowing running different

[dpdk-dev] [PATCH v2 12/14] eal: unify and move mcfg complete function

2019-06-25 Thread Anatoly Burakov
Currently, mcfg completion function exists in two independent implementations doing the same thing, which is bug prone. Unify the two functions and move them into one place. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 14 ++ lib/librte_eal/common/eal_

[dpdk-dev] [PATCH v2 11/14] eal: uninline wait for mcfg complete function

2019-06-25 Thread Anatoly Burakov
Currently, the function to wait until config completion is static inline for no reason. Move its implementation to an EAL common file. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 10 ++ lib/librte_eal/common/eal_memcfg.h | 10 +++--- lib/librte_e

[dpdk-dev] [PATCH v2 10/14] eal: remove packed attribute from mcfg structure

2019-06-25 Thread Anatoly Burakov
There is no reason to pack the memconfig structure, and doing so gives out warnings in some static analyzers. Fix it by removing the packed attributed. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_memcfg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/li

[dpdk-dev] [PATCH v2 09/14] eal: hide shared memory config

2019-06-25 Thread Anatoly Burakov
Now that everything that has ever accessed the shared memory config is doing so through the public API's, we can make it internal. Since we're removing quite a few headers from rte_eal_memconfig.h, we need to add them back in places where this header is used. Signed-off-by: Anatoly Burakov --- a

[dpdk-dev] [PATCH v2 08/14] eal: remove unused macros

2019-06-25 Thread Anatoly Burakov
These macros are not used anymore and can be removed. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_eal.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h index cf701e177..7042

[dpdk-dev] [PATCH v2 07/14] mempool: use new mempool list locking API

2019-06-25 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov Reviewed-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_mempool/rte_memp

[dpdk-dev] [PATCH v2 06/14] eal: add new API to lock/unlock mempool list

2019-06-25 Thread Anatoly Burakov
Currently, in order to lock access to the mempool list, a direct access to the shared memory structure is needed. Add an API to do the same. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 28 +++ .../common/include/rte_eal_memconfig.h|

[dpdk-dev] [PATCH v2 05/14] lib: use new tailq locking API

2019-06-25 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_acl/rte_acl.c | 18 +++ lib/librte_distributor/rte_distributor.c | 4 ++-- lib/librte_distributor/rte_distributor_v20.c | 4 ++--

[dpdk-dev] [PATCH v2 04/14] eal: add EAL tailq list lock/unlock API

2019-06-25 Thread Anatoly Burakov
Currently, locking/unlocking the TAILQ list requires direct access to the shared memory config. Add an API to do the same. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 28 +++ .../common/include/rte_eal_memconfig.h| 24 +++

[dpdk-dev] [PATCH v2 03/14] lib: use new memory locking API

2019-06-25 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 43 ++- lib/librte_eal/common/malloc_heap.c | 14 lib/librte_eal/common/rte_malloc.c| 32 ++

[dpdk-dev] [PATCH v2 02/14] drivers: use new memory locking API

2019-06-25 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- drivers/bus/fslmc/fslmc_vfio.c | 8 +++- drivers/net/mlx4/mlx4_mr.c | 11 +-- drivers/net/mlx5/mlx5_mr.c

[dpdk-dev] [PATCH v2 01/14] eal: add API to lock/unlock memory hotplug

2019-06-25 Thread Anatoly Burakov
Currently, the memory hotplug is locked automatically by all memory-related _walk() functions, but sometimes locking the memory subsystem outside of them is needed. There is no public API to do that, so it creates a dependency on shared memory config to be public. Fix this by introducing a new API

[dpdk-dev] [PATCH v2 00/14] Make shared memory config non-public

2019-06-25 Thread Anatoly Burakov
This patchset removes the shared memory config from public API, and replaces all usages of said config with new API calls. A lot of the patchset is a search-and-replace job and should be pretty easy to review. The rest are pretty trivial EAL changes. This patchset depends on FreeBSD fixes patchse

[dpdk-dev] [PATCH 2/2] eal/freebsd: add config reattach

2019-06-25 Thread Anatoly Burakov
Linux EAL will attach the shared config at an arbitrary address, find out where the shared config is mapped in the primary, and then will reattach it at that exact address. FreeBSD version doesn't seem to go for that extra reattach step, which makes one wonder how did it ever work in the first pla

[dpdk-dev] [PATCH 1/2] eal/freebsd: fix missing write to internal config

2019-06-25 Thread Anatoly Burakov
When init is complete, EAL is supposed to update internal config to indicate that initialization is complete. Add missing write. Fixes: a99c96e96ad3 ("eal: add internal flag of init completed") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/freebsd/eal/eal.c | 2 ++ 1 fil

[dpdk-dev] [PATCH v2 28/28] sched: add release note

2019-06-25 Thread Jasvinder Singh
From: Lukasz Krakowiak Add release notes and remove deprecation note. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- doc/guides/rel_notes/deprecation.rst | 6 -- doc/guides/rel_notes/release_19_08.rst | 7 ++- lib/librte_sched/Makefi

[dpdk-dev] [PATCH v2 27/28] sched: code cleanup

2019-06-25 Thread Jasvinder Singh
Remove redundant macros and fields from the data structures. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 43 lib/librte_sched/rte_sched.h | 25 +++-- 2 files

[dpdk-dev] [PATCH v2 26/28] examples/ip_pipeline: update ip pipeline sample app

2019-06-25 Thread Jasvinder Singh
Update ip pipeline sample app to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/ip_pipeline/cli.c |

[dpdk-dev] [PATCH v2 25/28] examples/qos_sched: update qos sched sample app

2019-06-25 Thread Jasvinder Singh
Update qos sched sample app to allow configuration flexibility for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/qos_sched/app_thread.c | 11 +-

[dpdk-dev] [PATCH v2 23/28] test/sched: update unit test

2019-06-25 Thread Jasvinder Singh
Update unit test to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- app/test/test_sched.c | 37 ---

[dpdk-dev] [PATCH v2 21/28] sched: update packet dequeue API

2019-06-25 Thread Jasvinder Singh
Update packet dequeue api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c |

[dpdk-dev] [PATCH v2 22/28] sched: update sched queue stats API

2019-06-25 Thread Jasvinder Singh
Update queue stats read api implementation of the scheduler to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_

[dpdk-dev] [PATCH v2 24/28] net/softnic: update softnic tm function

2019-06-25 Thread Jasvinder Singh
Update softnic tm function to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- drivers/net/softnic/rte_eth_softnic.c

[dpdk-dev] [PATCH v2 19/28] sched: update grinder schedule function

2019-06-25 Thread Jasvinder Singh
Update grinder schedule function to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 82

[dpdk-dev] [PATCH v2 20/28] sched: update grinder handle function

2019-06-25 Thread Jasvinder Singh
Update grinder handle function implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sche

[dpdk-dev] [PATCH v2 18/28] sched: update mbuf prefetch function

2019-06-25 Thread Jasvinder Singh
Update mbuf prefetch function of the scheduler grinder to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched

[dpdk-dev] [PATCH v2 17/28] sched: modify credits update function

2019-06-25 Thread Jasvinder Singh
Modify credits update function of scheduler grinder to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rt

[dpdk-dev] [PATCH v2 16/28] sched: update grinder wrr compute function

2019-06-25 Thread Jasvinder Singh
Update weighted round robin function for best-effort traffic class queues to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --

[dpdk-dev] [PATCH v2 13/28] sched: update grinder pipe and tc cache

2019-06-25 Thread Jasvinder Singh
Update grinder pipe and tc cache population to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.

[dpdk-dev] [PATCH v2 15/28] sched: update pipe and tc queues prefetch

2019-06-25 Thread Jasvinder Singh
Update pipe and tc queues prefetch functions to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched

[dpdk-dev] [PATCH v2 11/28] sched: update port memory footprint API

2019-06-25 Thread Jasvinder Singh
Update port memory footprint api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sc

[dpdk-dev] [PATCH v2 14/28] sched: update grinder next pipe and tc functions

2019-06-25 Thread Jasvinder Singh
Update grinder next pipe and tc functions to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c

[dpdk-dev] [PATCH v2 12/28] sched: update packet enqueue API

2019-06-25 Thread Jasvinder Singh
Update packet enqueue api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c |

[dpdk-dev] [PATCH v2 10/28] sched: update subport and tc queue stats

2019-06-25 Thread Jasvinder Singh
Update subport and tc queue stats api mplementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rt

[dpdk-dev] [PATCH v2 09/28] sched: update pkt read and write API

2019-06-25 Thread Jasvinder Singh
Update run time packet read and write api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sch

[dpdk-dev] [PATCH v2 08/28] sched: update pipe config API

2019-06-25 Thread Jasvinder Singh
Update pipe configuration api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched

[dpdk-dev] [PATCH v2 07/28] sched: update pipe profile add API

2019-06-25 Thread Jasvinder Singh
Update the pipe profile add api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sch

[dpdk-dev] [PATCH v2 06/28] sched: update subport config API

2019-06-25 Thread Jasvinder Singh
Update suport configuration api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sch

[dpdk-dev] [PATCH v2 05/28] sched: update port free API

2019-06-25 Thread Jasvinder Singh
Update port free api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 71 +

[dpdk-dev] [PATCH v2 04/28] sched: update port config API

2019-06-25 Thread Jasvinder Singh
Update port configuration api implementation to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched

[dpdk-dev] [PATCH v2 02/28] sched: update subport and pipe data structures

2019-06-25 Thread Jasvinder Singh
Update subport and pipe data structures to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- app/test/test_sched.c|

[dpdk-dev] [PATCH v2 03/28] sched: update internal data structures

2019-06-25 Thread Jasvinder Singh
Update internal data structures of the scheduler to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_s

[dpdk-dev] [PATCH v2 01/28] sched: update macros for flexible config

2019-06-25 Thread Jasvinder Singh
Update macros to allow configuration flexiblity for pipe traffic classes and queues, and subport level configuration of the pipe parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.h | 36 +++

[dpdk-dev] [PATCH v2 00/28] sched: feature enhancements

2019-06-25 Thread Jasvinder Singh
This patchset refactors the dpdk qos sched library to add following features to enhance the scheduler functionality. 1. flexibile configuration of the pipe traffic classes and queues; Currently, each pipe has 16 queues hardwired into 4 TCs scheduled with strict priority, and each TC has exa

[dpdk-dev] [PATCH v3] kni: fix possible kernel crash with va2pa

2019-06-25 Thread Yangchao Zhou
va2pa depends on the physical address and virtual address offset of current mbuf. It may get the wrong physical address of next mbuf which allocated in another hugepage segment. In rte_mempool_populate_default(), trying to allocate whole block of contiguous memory could be failed. Then, it would r

[dpdk-dev] [PATCH v2 8/8] raw/ioat: add local API to perform copies

2019-06-25 Thread Bruce Richardson
Add local APIs to trigger data copies, and retrieve handle values once those copies are completed. Included are unit tests to validate the data is copies correctly. Signed-off-by: Bruce Richardson --- V2: test cases moved to self-test routine --- doc/guides/rawdevs/ioat_rawdev.rst | 100 +

[dpdk-dev] [PATCH v2 7/8] raw/ioat: add statistics functions

2019-06-25 Thread Bruce Richardson
Add stats functions to track what is happening in the driver, and put unit tests to check those. Signed-off-by: Bruce Richardson --- V2: test cases moved to self-test routine --- doc/guides/rawdevs/ioat_rawdev.rst | 14 + drivers/raw/ioat/ioat_rawdev.c | 44 +++

[dpdk-dev] [PATCH v2 5/8] raw/ioat: add device info function

2019-06-25 Thread Bruce Richardson
Add in the "info_get" function to the driver, to allow us to query the device. This allows us to have the unit test pick up the presence of supported hardware or not. Signed-off-by: Bruce Richardson --- V2: Test case is placed in driver self-test routine --- app/test/test_rawdev.c

[dpdk-dev] [PATCH v2 6/8] raw/ioat: add configure, start and stop functions

2019-06-25 Thread Bruce Richardson
Allow initializing a driver instance. Include selftest to validate these functions. Signed-off-by: Bruce Richardson --- V2: test cases placed in self-test routine --- app/test/test_rawdev.c | 2 +- doc/guides/rawdevs/ioat_rawdev.rst | 32 drivers/raw/ioat/Makefile

[dpdk-dev] [PATCH v2 4/8] raw/ioat: create device on probe and destroy on release

2019-06-25 Thread Bruce Richardson
Add the create/destroy driver functions so that we can actually allocate a rawdev and destroy it when done. No rawdev API functions are actually implemented at this point. Signed-off-by: Bruce Richardson --- doc/guides/rawdevs/ioat_rawdev.rst | 11 drivers/raw/ioat/ioat_rawdev.c | 93 ++

Re: [dpdk-dev] [PATCH v7 0/3] Enable rte_flow API in ice driver

2019-06-25 Thread Aaron Conole
Qiming Yang writes: > This patch set enables the backend of rte_flow, and the generic > filter related functions in ice driver. Supported flows include > ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch > set depends on shared code update. > > --- > v2 changes: > - added UDP tunne

[dpdk-dev] [PATCH v2 1/8] raw/ioat: add initial support for ioat rawdev driver

2019-06-25 Thread Bruce Richardson
Add stubs for ioat rawdev driver support in DPDK, specifically: * makefile and meson build hooks * initial public header file * rawdev main C file, with probe and release functions * release note update announcing the driver * initial documentation for the new section in the rawdev doc

[dpdk-dev] [PATCH v2 0/8] raw/ioat: driver for Intel QuickData Technology

2019-06-25 Thread Bruce Richardson
This patch series adds support for the Intel QuickData Technology device, part of the Intel I/O Acceleration Technology (Intel I/OAT). It is a raw device for allowing hardware DMA i.e. data copies in hardware. Performing the copies in hardware can provide performance improvements for applications

[dpdk-dev] [PATCH v2 3/8] raw/ioat: add register definition file

2019-06-25 Thread Bruce Richardson
Add in the list of registers for the device. File is taken from the SPDK project: https://github.com/spdk/spdk/blob/master/include/spdk/ioat_spec.h Signed-off-by: Bruce Richardson --- drivers/raw/ioat/Makefile| 1 + drivers/raw/ioat/meson.build | 3 +- drivers/raw/ioat/rte_ioa

[dpdk-dev] [PATCH v2 2/8] usertools/dpdk-devbind.py: add support for IOAT devices

2019-06-25 Thread Bruce Richardson
In order to allow binding/unbinding of devices for use by the ioat_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. Signed-off-by: Bruce Richardson --- V2: rather than adding a DMA section, add to "misc (rawdev)" sectio

[dpdk-dev] [PATCH v2 1/2] lib/ipsec: add support for header construction

2019-06-25 Thread Fan Zhang
From: Marko Kovacevic Add support for RFC 4301(5.1.2) to update of Type of service field and Traffic class field bits inside ipv4/ipv6 packets for outbound cases and inbound cases which deals with the update of the DSCP/ENC bits inside each of the fields. Signed-off-by: Marko Kovacevic Signed-o

[dpdk-dev] [PATCH v2 0/2] ipsec: ECN and DSCP header reconstruction.

2019-06-25 Thread Fan Zhang
This patchset adds the ECN and DSCP tunnel mode header reconstruction support for rte_ipsec library. The ipsec-secgw sample application is updated with the feature's enabling and a python3 script for testing the correctness of the implementation. This patchset depends on the following patchset "[v

[dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: support header reconstruction

2019-06-25 Thread Fan Zhang
This patch updates the ipsec-secgw application to support header reconstruction. In addition a series of tests have been added to prove the implementation's correctness. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_19_08.rst | 6 + examples/ipsec-secgw/sa.c

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-25 Thread Drost, MariuszX
Hi, About your comments: 1) I used macros around sa->flags where it was needed. Not all checks for that set of flags use information if it is transport mode. As for macro WITHOUT_TRANSPORT_VERSION, it was set only for checks that required information from set of flags without taking into accou

[dpdk-dev] [PATCH] net/qede: remove interrupt reconfigure in handler

2019-06-25 Thread David Marchand
rte_intr_enable/rte_intr_disable configure the interrupt context on the kernel side (either uio or vfio). In VFIO case, calling it from the interrupt handlers triggers an unneeded interrupt handlers reconfiguration. During this reconfiguration window, the device can trigger interrupts which are lef

Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI

2019-06-25 Thread Burakov, Anatoly
On 25-Jun-19 12:30 PM, Burakov, Anatoly wrote: On 25-Jun-19 12:15 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: dev On Behalf Of Burakov, Anatoly Sent: Tuesday, June 25, 2019 3:30 PM To: Vamsi Krishna Attunuru ; dev@dpdk.org Cc: ferruh.yi...@intel.com; olivier.m...@6wind

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-25 Thread Akhil Goyal
Hi Marius, Could you please send the updated patch soon, so that they can be applied before RC1. Thanks, Akhil > > Hi Marius, > > > > Application ipsec-secgw is not working for IPv4 transport mode and for > > IPv6 both transport and tunnel mode. > > > > IPv6 tunnel mode is not working due to

Re: [dpdk-dev] [PATCH v2 1/5] examples/ipsec-secgw: fix invalid packet length

2019-06-25 Thread Ananyev, Konstantin
Hi Akhil, > > Hi Konstantin, > > Could you please rebase this patchset. There are some conflicting changes > because of Marcin's patches. > Also could you please squash your doc patch with " examples/ipsec-secgw: > support packet fragmentation and reassembly " > As per convention followed,

Re: [dpdk-dev] [PATCH v2 1/5] examples/ipsec-secgw: fix invalid packet length

2019-06-25 Thread Akhil Goyal
Hi Konstantin, Could you please rebase this patchset. There are some conflicting changes because of Marcin's patches. Also could you please squash your doc patch with " examples/ipsec-secgw: support packet fragmentation and reassembly " As per convention followed, there should not be separate do

Re: [dpdk-dev] [PATCH v2 0/4] IPv6 with options support for IPsec transport

2019-06-25 Thread Akhil Goyal
> > Add support for IPv6 with header extensions (IPv6 options) and IPsec > transport mode: > 1. Add IPv6 header extension parsing method in librte_net > 2. Fix IPv6 header with extension parsing in both librte_ipsec and >ipsec sample application using abovementioned function > 3. Add new te

  1   2   >