Re: [dpdk-dev] [RFC] net/vdev_netvsc: check for required related drivers

2019-03-16 Thread Matan Azrad
Hi From: Stephen Hemminger > wrote: > > > Hi > > > > From: Stephen Hemminger > > > The vdev_netvsc virtual driver that is used to do initialization on > > > Hyper- V/Azure won't work without failsafe and tap device. > > > If the related devices aren't present, it causes confusing errors > > > l

[dpdk-dev] [PATCH v2] vhost: fix interrupt suppression for the split ring

2019-03-16 Thread Jiayu Hu
The VIRTIO_RING_F_EVENT_IDX feature of split ring might be broken, as the value of signalled_used is invalid after live migration, start up and virtio driver reload. This patch fixes it by using signalled_used_valid. In addition, this patch makes the VIRTIO_RING_F_EVENT_IDX implementation of split

[dpdk-dev] [PATCH v5] net/mlx5: support new representor naming format

2019-03-16 Thread Dekel Peled
Kernel update [1] introduce new format of representors names. This patch implements RFC [2], updating MLX5 PMD to support the new format, while maintaining support of the existing format. [1] https://github.com/torvalds/linux/commit/c12ecc2 [2] http://mails.dpdk.org/archives/dev/2019-March/125676.

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix erronous cast

2019-03-16 Thread Matan Azrad
Hi From: Stephen Hemminger > > Hi > > > > From: Stephen Hemminger > > > The return value from bus->find_device is a rte_device which is not > > > safe to cast to a rte_vdev_device structure. > > > It doesn't really matter since only being checked for NULL but > > > static checkers might find a bug

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-16 Thread Ye Xiaolong
On 03/12, Ye Xiaolong wrote: >>I can see in makefile, libelf is also linked, is it a dependency? > >libelf is a leftover of RFC, will delete it in next version. Correction, libbpf depends on libelf, so I still need to keep it. Thanks, Xiaolong

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-16 Thread Ye Xiaolong
On 03/02, Ye Xiaolong wrote: >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet >>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += -lrte_pmd_af_xdp >>> -lelf -lbpf >> >>Are symbols from libelf being used by the PMD? > >Hmm, it is a leftover of RFC, libelf is no longer needed i

[dpdk-dev] [PATCH 1/2] eventdev: check timer adapter status before start

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Check if timer adapter is already started before starting it. Update the unit test accordingly. Signed-off-by: Pavan Nikhilesh --- app/test/test_event_timer_adapter.c | 4 ++-- lib/librte_eventdev/rte_event_timer_adapter.c | 6 ++ lib/librte_eventdev/rte_eve

[dpdk-dev] [PATCH 2/2] test/event_timer: improve unit test compatability

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Check if eventdev is open system eventdevs i.e. max_num_events = -1 before asserting. Allow event timer adapter to adjust the resolution using RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES and re-calculate timeout ticks based on the adjusted resolution. Signed-off-by: Pavan Nikhiles

[dpdk-dev] [PATCH v3 2/2] eal: roundup tsc frequency when estimating

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh When estimating tsc frequency using sleep/gettime round it up to the nearest multiple of 10Mhz for more accuracy. Signed-off-by: Pavan Nikhilesh Reviewed-by: Keith Wiles --- Useful in case of ARM64 if we enable RTE_ARM_EAL_RDTSC_USE_PMU, get_tsc_freq_arch() will return

[dpdk-dev] [PATCH v3 1/2] eal: add macro to align value to the nearest multiple

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Add macro to align value to the nearest multiple of the given value, resultant value might be greater than or less than the first parameter whichever difference is the lowest. Update unit test to include the new macro. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Spi

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
On Sat, 2019-03-16 at 18:22 +, Wiles, Keith wrote: > > On Mar 16, 2019, at 12:56 PM, Pavan Nikhilesh Bhagavatula < > > pbhagavat...@marvell.com> wrote: > > > > On Sat, 2019-03-16 at 17:18 +, Wiles, Keith wrote: > > > > On Mar 16, 2019, at 10:06 AM, Pavan Nikhilesh Bhagavatula < > > > > pbh

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Wiles, Keith
> On Mar 16, 2019, at 12:56 PM, Pavan Nikhilesh Bhagavatula > wrote: > > On Sat, 2019-03-16 at 17:18 +, Wiles, Keith wrote: >>> On Mar 16, 2019, at 10:06 AM, Pavan Nikhilesh Bhagavatula < >>> pbhagavat...@marvell.com> wrote: >>> >>> On Sat, 2019-03-16 at 14:42 +, Wiles, Keith wrote: >

Re: [dpdk-dev] [PATCH v3 1/4] build: add single source of DPDK version number

2019-03-16 Thread Rami Rosen
Bruce Richardson ‏: > Add a new file VERSION to hold the current DPDK version number. > Have meson use this file for it's project version, and have make use > it for reporting out "showversion" and "showversionum". > > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi > Reviewed-by: Ra

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
On Sat, 2019-03-16 at 17:18 +, Wiles, Keith wrote: > > On Mar 16, 2019, at 10:06 AM, Pavan Nikhilesh Bhagavatula < > > pbhagavat...@marvell.com> wrote: > > > > On Sat, 2019-03-16 at 14:42 +, Wiles, Keith wrote: > > > > On Mar 16, 2019, at 2:03 AM, Pavan Nikhilesh Bhagavatula < > > > > pbha

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Wiles, Keith
> On Mar 16, 2019, at 10:06 AM, Pavan Nikhilesh Bhagavatula > wrote: > > On Sat, 2019-03-16 at 14:42 +, Wiles, Keith wrote: >>> On Mar 16, 2019, at 2:03 AM, Pavan Nikhilesh Bhagavatula < >>> pbhagavat...@marvell.com> wrote: >>> >>> From: Pavan Nikhilesh >>> >>> When estimating tsc frequ

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
On Sat, 2019-03-16 at 14:42 +, Wiles, Keith wrote: > > On Mar 16, 2019, at 2:03 AM, Pavan Nikhilesh Bhagavatula < > > pbhagavat...@marvell.com> wrote: > > > > From: Pavan Nikhilesh > > > > When estimating tsc frequency using sleep/gettime round it up to > > the > > nearest multiple of 10Mhz

Re: [dpdk-dev] [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Wiles, Keith
> On Mar 16, 2019, at 2:03 AM, Pavan Nikhilesh Bhagavatula > wrote: > > From: Pavan Nikhilesh > > When estimating tsc frequency using sleep/gettime round it up to the > nearest multiple of 10Mhz for more accuracy. > > Signed-off-by: Pavan Nikhilesh > --- > Useful in case of ARM64 if we en

[dpdk-dev] [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh When estimating tsc frequency using sleep/gettime round it up to the nearest multiple of 10Mhz for more accuracy. Signed-off-by: Pavan Nikhilesh --- Useful in case of ARM64 if we enable RTE_ARM_EAL_RDTSC_USE_PMU, get_tsc_freq_arch() will return 0 as there is no instructi

[dpdk-dev] [PATCH v2 1/2] eal: add macro to align value to the nearest multiple

2019-03-16 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Add macro to align value to the nearest multiple of the given value, resultant value might be greater than or less than the first parameter whichever difference is the lowest. Update unit test to include the new macro. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Spi