[dpdk-dev] [PATCH] app/testpmd: fix a typo.

2019-03-11 Thread Rami Rosen
This patch fixes a typo in test-pmd/cmdline.c: succcessfully->successfully Two C's are good enough for success... Signed-off-by: Rami Rosen --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index db53cc0

[dpdk-dev] [PATCH v2] app/testpmd: optimized MAC swap by using neon intrinsics

2019-03-11 Thread Ruifeng Wang
Improved MAC swap performance for ARM platform. The improvement was achieved by using neon intrinsics to save CPU cycles and doing swap for four packets at a time. The optimization had 15% - 20% throughput boost in testpmd MAC swap mode. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed

[dpdk-dev] Query : Does Binding with vfio-pci is supported inside qemu-kvm guest/vm instance.?

2019-03-11 Thread Thanneeru Srinivasulu
Hi Everyone. I did attached pice to Guest VM using vfio-pci with qemu command, and then tried binding the pcie bdf with vfio-pci, observing binding failure with vfio-pci. Where as when tryied with igb_uio, everything works fine. Does Binding with vfio-pci is supported inside VM/guest? Regards

Re: [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G

2019-03-11 Thread Zhang, Qi Z
> -Original Message- > From: Luo, Michael > Sent: Tuesday, March 12, 2019 9:21 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix time sync for 25G > > Verified the patch on DPDK 18.11. > > Best regards, > Michael > > -Original Message--

Re: [dpdk-dev] [PATCH v1 0/6] Introduce AF_XDP PMD

2019-03-11 Thread Zhang, Qi Z
+ Magnus & Bjorn who can give more accurate comment about kernel upstream status. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, March 12, 2019 1:20 AM > To: Yigit, Ferruh ; Ye, Xiaolong > > Cc: dev@dpdk.org; Zhang, Qi Z ; Richardson, Bruce >

Re: [dpdk-dev] [PATCH] eal: unmap unneed dpdk VA spaces for legacy mem

2019-03-11 Thread Lilijun (Jerry, Cloud Networking)
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Friday, March 08, 2019 5:38 PM > To: Lilijun (Jerry, Cloud Networking) ; > dev@dpdk.org > Cc: jerry.zh...@intel.com; ian.sto...@intel.com > Subject: Re: [dpdk-dev] [PATCH] eal: unmap unneed

Re: [dpdk-dev] [PATCH v1] app/testpmd: optimized MAC swap by using neon intrinsics

2019-03-11 Thread Ruifeng Wang (Arm Technology China)
Regards, /Ruifeng > -Original Message- > From: Honnappa Nagarahalli > Sent: 2019年3月11日 23:33 > To: Ruifeng Wang (Arm Technology China) ; > wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com > Cc: dev@dpdk.org; jer...@marvell.com; hemant.agra...@nxp.com; nd > ; Ru

Re: [dpdk-dev] [PATCH v1] app/testpmd: optimized MAC swap by using neon intrinsics

2019-03-11 Thread Ruifeng Wang (Arm Technology China)
Regards, /Ruifeng > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: 2019年3月11日 22:17 > To: Ruifeng Wang (Arm Technology China) ; > jingjing...@intel.com; bernard.iremon...@intel.com; > wenzhuo...@intel.com > Cc: Honnappa Nagarahalli ; nd > ; hemant.agra...@nxp.com; dev@dpdk

Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note

2019-03-11 Thread Rami Rosen
> Make clear that spaces are only for alignments less than tab size. > > Signed-off-by: Kevin Traynor > Acked-by: Rami Rosen

Re: [dpdk-dev] [PATCH] net/mlx5: fix packet inline on Tx queue wraparound

2019-03-11 Thread Yongseok Koh
> On Mar 10, 2019, at 12:14 AM, Shahaf Shuler wrote: > > Inlining a packet to WQE that cross the WQ wraparound, i.e. the WQE > starts on the end of the ring and ends on the beginning, is not > supported and blocked by the data path logic. > > However, in case of TSO, an extra inline header is

[dpdk-dev] [PATCH] doc: clarify spaces for alignment note

2019-03-11 Thread Kevin Traynor
Make clear that spaces are only for alignments less than tab size. Signed-off-by: Kevin Traynor --- doc/guides/contributing/coding_style.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst in

Re: [dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding

2019-03-11 Thread Kevin Traynor
On 11/03/2019 12:35, Ferruh Yigit wrote: > On 3/11/2019 2:18 AM, Zhang, Qi Z wrote: >> >> >>> -Original Message- >>> From: Kevin Traynor [mailto:ktray...@redhat.com] >>> Sent: Wednesday, March 6, 2019 12:31 AM >>> To: Zhang, Qi Z >>> Cc: dev@dpdk.org; Kevin Traynor ; Yan, Zhirun >>> >>> S

Re: [dpdk-dev] [PATCH 15/15] eal/linux: use gettid(2) for debug message in sigbus_handler

2019-03-11 Thread Stephen Hemminger
On Mon, 11 Mar 2019 18:37:02 +0100 Natanael Copa wrote: > +#if !defined(__GLIBC__) > +#include > +#define gettid() syscall(SYS_gettid) > +#endif > + I though glibc didn't want to expose thread id. Personally, I would just drop the thread from the log message since it is not that useful anyway.

Re: [dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

2019-03-11 Thread Ajit Khaparde
On Mon, Mar 11, 2019 at 11:11 AM Stephen Hemminger < step...@networkplumber.org> wrote: > This reduces the logging in this driver and makes it > work like others. > > Stephen Hemminger (3): > net/bnxt: change PTP message to DEBUG level > net/bnxt: do not double space version message > net/bn

Re: [dpdk-dev] [PATCH 14/15] net/netvsc: fix compile warning for fcntl.h include

2019-03-11 Thread Stephen Hemminger
On Mon, 11 Mar 2019 18:37:01 +0100 Natanael Copa wrote: > Fix the following warning when building with musl libc: > > In file included from ../drivers/net/netvsc/hn_vf.c:14: > /usr/include/sys/fcntl.h:1:2: warning: #warning redirecting incorrect > #include to [-Wcpp] > #warning redirecting i

[dpdk-dev] [PATCH] ethdev: check for invalid device name

2019-03-11 Thread Stephen Hemminger
Do not allow creating a ethernet device with a name over the allowed maximum (or zero length). This is safer than silently truncating which is what happens now. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko --- v1 - previously sent as RFC lib/librte_ethdev/rte_ethdev.c | 10 +

Re: [dpdk-dev] [PATCH v1] doc: update cross build tool links

2019-03-11 Thread Stephen Hemminger
On Mon, 11 Mar 2019 11:05:14 +0800 Joyce Kong wrote: > Update cross build tool links as newer cross build tools > version are provided on Linaro, and attempts to download > the old one give permission denied. > > Fixes: 01add9da25cd ("doc: add cross compiling guide") > Cc: sta...@dpdk.org > > S

[dpdk-dev] [PATCH 3/3] net/bnxt: use NOTICE as default log level

2019-03-11 Thread Stephen Hemminger
Make bnxt driver consistent with all other network drivers by setting default to NOTICE for log level. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_et

[dpdk-dev] [PATCH 1/3] net/bnxt: change PTP message to DEBUG level

2019-03-11 Thread Stephen Hemminger
This message doesn't need to be at INFO level, it is a normal situation and only useful for debugging. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c

[dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

2019-03-11 Thread Stephen Hemminger
This reduces the logging in this driver and makes it work like others. Stephen Hemminger (3): net/bnxt: change PTP message to DEBUG level net/bnxt: do not double space version message net/bnxt: use NOTICE as default log level drivers/net/bnxt/bnxt_ethdev.c | 4 ++-- drivers/net/bnxt/bnxt_h

[dpdk-dev] [PATCH 2/3] net/bnxt: do not double space version message

2019-03-11 Thread Stephen Hemminger
The version message is double spaced in the log. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 189527207f9a..c5f7cf9cb9ec 100644 --- a/d

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-03-11 Thread David Marchand
On Mon, Mar 11, 2019 at 6:22 PM Ferruh Yigit wrote: > On 3/4/2019 11:18 AM, David Marchand wrote: > > According to the api, the q_errors[] per queue statistic is for reception > > errors not transmit errors. > > This is a first cleanup on statistics before looking at oerrors. > > > > Yes, the pat

[dpdk-dev] [PATCH 15/15] eal/linux: use gettid(2) for debug message in sigbus_handler

2019-03-11 Thread Natanael Copa
There is no guarantee that pthread_self() returns the thread id or that pthread_t is an integer. Use gettid(2) to get the kernel thread id instead. This fixes the following warning when building with musl libc: ../lib/librte_eal/linuxapp/eal/eal_dev.c: In function 'sigbus_handler': ../lib/librte_

[dpdk-dev] [PATCH 14/15] net/netvsc: fix compile warning for fcntl.h include

2019-03-11 Thread Natanael Copa
Fix the following warning when building with musl libc: In file included from ../drivers/net/netvsc/hn_vf.c:14: /usr/include/sys/fcntl.h:1:2: warning: #warning redirecting incorrect #include to [-Wcpp] #warning redirecting incorrect #include to ^~~ Signed-off-by: Natanael Copa --- T

[dpdk-dev] [PATCH 13/15] crypto/dpaa2_sec: simplify pr_{debug, err, warn} macros

2019-03-11 Thread Natanael Copa
Simplify pr_debug, pr_err and pr_warn macros by add an intermediate pr_msg macro. This way we only need test for SUPPRESS_PRINTS once. Signed-off-by: Natanael Copa --- This does not really fix any error, but I cleaned it up while at it. Feel free to skip this patch. drivers/crypto/dpaa2_sec/hw

[dpdk-dev] [PATCH 11/15] bus/dpaa: fix warning: "__WORDSIZE" is not defined, evaluates to 0

2019-03-11 Thread Natanael Copa
There is no standard saying that __WORDSIZE should be be defined or in what include it should be defined. Use a portable way to detect 64 bit environment. This fixes a warning when building with musl libc: warning: "__WORDSIZE" is not defined, evaluates to 0 [-Wundef] Signed-off-by: Natanael Co

[dpdk-dev] [PATCH 12/15] crypto/dpaa2_sec: build fix for musl libc

2019-03-11 Thread Natanael Copa
The swab16/swab32/swab64 are Linux specific and nog GNU libc specific. Keep the check for __GLIBC__ just in case other GNU systems depends on this (Hurd or GNU/kFreeBSD). This fixes a build error with musl libc. Signed-off-by: Natanael Copa --- I guess the check for __linux__ and __GLIBC__ coul

[dpdk-dev] [PATCH 10/15] bus/dpaa: use warn(3) instead of error(3) to improve portability

2019-03-11 Thread Natanael Copa
Fix build with musl libc by using warn(3) instead of error(3). This also fixes error message for kzmalloc failures which previously would have given "Unknown error -1". Signed-off-by: Natanael Copa --- Note that err.h is not in POSIX standard either, but is implemented in musl libc. drivers/b

[dpdk-dev] [PATCH 08/15] app/test: include fcntl.h due to use of O_RDONLY

2019-03-11 Thread Natanael Copa
Fix following build error with musl libc: ../app/test/test_eal_flags.c:152:55: error: 'O_RDONLY' undeclared (first use in this function) fd = openat(dirfd(hugepage_dir), dirent->d_name, O_RDONLY); ^~~~ Signed-off-by: Natanael Copa

[dpdk-dev] [PATCH 07/15] net/nfp: build fix for musl libc

2019-03-11 Thread Natanael Copa
Fixes following build error on systems without execinfo.h: ../drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c:19:10: fatal error: execinfo.h: No such file or directory #include ^~~~ Signed-off-by: Natanael Copa --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 2 ++ 1 file change

[dpdk-dev] [PATCH 06/15] bus/fslmc: remove unused include of error.h

2019-03-11 Thread Natanael Copa
Fixes following build error with musl libc: In file included from ../drivers/bus/fslmc/qbman/qbman_debug.c:6: ../drivers/bus/fslmc/qbman/include/compat.h:21:10: fatal error: error.h: No such file or directory #include ^ Apparently it is not used anywere in qbman so simply rem

[dpdk-dev] [PATCH 09/15] app/test: fix setting of -D_GNU_SOURCE with meson

2019-03-11 Thread Natanael Copa
in app/test/meson.build the default_cflag is never used so the -D_GNU_SOURCE was never passed as intended. Fixes the following build error with musl libc: ../lib/librte_eal/common/include/rte_lcore.h:26:9: error: unknown type name 'cpu_set_t' typedef cpu_set_t rte_cpuset_t; ^

[dpdk-dev] [PATCH 05/15] bus/fslmc: fix compile error with musl libc

2019-03-11 Thread Natanael Copa
This fixes the following compile error with musl libc: ../drivers/bus/fslmc/qbman/include/compat.h:41:10: error: 'stdout' undeclared (first use in this function) fflush(stdout); \ ^~ Signed-off-by: Natanael Copa --- drivers/bus/fslmc/qbman/include/compat.h | 1 + 1 file change

[dpdk-dev] [PATCH 04/15] bus/pci: factor out various ifdefs in pci_uio_ioport_{read, write}

2019-03-11 Thread Natanael Copa
define the macros so we can remove various #if defined(RTE_ARCH_X86) Ref: https://bugs.dpdk.org/show_bug.cgi?id=35#c6 Signed-off-by: Natanael Copa --- Please note that this is only compile tested with musl libc on x86_64. drivers/bus/pci/linux/pci_uio.c | 54 +++--

[dpdk-dev] [PATCH 03/15] bus/pci: add fallback for out[lwb]_p for non GNU libc

2019-03-11 Thread Natanael Copa
Add a fallback for non-GNU libc systems like musl libc for the non-standard functions outl_p, outw_p and outb_p. This ifixes the following buildtime errors when building with musl libc: pci_uio.c:(.text+0xaa1): undefined reference to `outw_p' pci_uio.c:(.text+0xac5): undefined reference to `outl_

[dpdk-dev] [PATCH 02/15] net/cxgbe: replace uint with unsigned int

2019-03-11 Thread Natanael Copa
Improve portability and fix build error with musl libc: In file included from ../drivers/net/cxgbe/cxgbe_filter.c:7: ../drivers/net/cxgbe/base/common.h:201:4: error: unknown type name 'uint' uint synmapen:1; /* SYN Map Enable */ ^~~~ Signed-off-by: Natanael Copa --- drivers/net/cxgbe/ba

[dpdk-dev] [PATCH 00/15] Build fixes for musl libc

2019-03-11 Thread Natanael Copa
A set of patches to fix build with musl libc. I also did a few cleanups wrt macros and fixed a few scary compiler warnings while at it. Please note that those are only compile tested on x86_64 with musl libc. Natanael Copa (15): app/testpmd: replace uint with unsigned int net/cxgbe: replace u

[dpdk-dev] [PATCH 01/15] app/testpmd: replace uint with unsigned int

2019-03-11 Thread Natanael Copa
Improve portability by avoid use non-standard 'uint'. This fixes following build error when building with musl libc: In file included from ../app/test-pmd/cmdline.c:75: ../app/test-pmd/testpmd.h:809:29: error: unknown type name 'uint'; did you mean 'int'? uint8_t *hash_key, uint hash_k

Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO DMA map APIs

2019-03-11 Thread Rami Rosen
> On 10-Mar-19 8:28 AM, Shahaf Shuler wrote: > > As those should be replaced by rte_dev_dma_map and rte_dev_dma_unmap > > APIs. > > > > Signed-off-by: Shahaf Shuler > > -- > Acked-by: Rami Rosen

Re: [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories

2019-03-11 Thread Rami Rosen
Acked-by: Rami Rosen >

Re: [dpdk-dev] [PATCH v1 0/6] Introduce AF_XDP PMD

2019-03-11 Thread Thomas Monjalon
11/03/2019 17:43, Ferruh Yigit: > On 3/1/2019 8:09 AM, Xiaolong Ye wrote: > > Overview > > > > > > This patchset adds a new PMD driver for AF_XDP which is a proposed > > faster version of AF_PACKET interface in Linux, see below links [1] [2] for > > details of AF_XDP introduction: > > >

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-03-11 Thread Ferruh Yigit
On 3/4/2019 11:18 AM, David Marchand wrote: > According to the api, the q_errors[] per queue statistic is for reception > errors not transmit errors. > This is a first cleanup on statistics before looking at oerrors. > Yes, the patchset looks aligned with the API documentation [1]. What can be t

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/nfp: fix set_mac_addr

2019-03-11 Thread Ferruh Yigit
On 3/10/2019 11:42 AM, Alejandro Lucero wrote: > On Fri, Mar 8, 2019 at 3:41 PM Pablo Cascón > wrote: > >> Some firmwares, mostly for VFs, do not advertise the feature / >> capability of changing the MAC address while the interface is up. With >> such firmware a request to change the MAC address

Re: [dpdk-dev] [PATCH v1 6/6] app/testpmd: add mempool flags parameter

2019-03-11 Thread Ferruh Yigit
On 3/1/2019 8:09 AM, Xiaolong Ye wrote: > When create rte_mempool, flags can be parsed from command line. > Now, it is possible for testpmd to create a af_xdp friendly > mempool (which enable zero copy). > > Signed-off-by: Qi Zhang > Signed-off-by: Xiaolong Ye > --- > app/test-pmd/parameters.c

Re: [dpdk-dev] [PATCH v1 0/6] Introduce AF_XDP PMD

2019-03-11 Thread Ferruh Yigit
On 3/1/2019 8:09 AM, Xiaolong Ye wrote: > Overview > > > This patchset adds a new PMD driver for AF_XDP which is a proposed > faster version of AF_PACKET interface in Linux, see below links [1] [2] for > details of AF_XDP introduction: > > AF_XDP roadmap > == > - AF_XDP is in

Re: [dpdk-dev] [PATCH v2] acl: fix missing flags when compiling without AVX2

2019-03-11 Thread Bruce Richardson
On Mon, Mar 11, 2019 at 03:18:11PM +, Andrius Sirvys wrote: > When compiling the ACL library on a system without AVX2 support, > the flags used to compile the AVX2-specific code for later run-time > use were not based on the regular cflags for the rest of the library. > This can cause errors du

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-11 Thread Ferruh Yigit
On 3/1/2019 8:09 AM, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the umem. > > [1] htt

[dpdk-dev] [PATCH] maintainers: claim responsibility for timer lib

2019-03-11 Thread Erik Gabriel Carrillo
Add myself as co-maintainer for the timer library. Signed-off-by: Erik Gabriel Carrillo --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 097cfb4..4b0beec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1192,6 +1192,7 @@ F: doc/guides/sample_app_u

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: remove useless casts on statistics

2019-03-11 Thread David Marchand
On Mon, Mar 11, 2019 at 4:57 PM Andrew Rybchenko wrote: > On 3/11/19 6:35 PM, David Marchand wrote: > > Caught by code review while investigating the stats display code. > Switching all port and fwd engine statistics to uint64_t makes it > possible to drop all casts. > > Signed-off-by: David Marc

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: remove useless casts on statistics

2019-03-11 Thread Andrew Rybchenko
On 3/11/19 6:35 PM, David Marchand wrote: Caught by code review while investigating the stats display code. Switching all port and fwd engine statistics to uint64_t makes it possible to drop all casts. Signed-off-by: David Marchand Patch summary is misleading here. The main change here is cha

Re: [dpdk-dev] [PATCH v2 2/4] app/testpmd: add missing newline when showing statistics

2019-03-11 Thread Andrew Rybchenko
On 3/11/19 6:35 PM, David Marchand wrote: Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkt

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-11 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-11 at 13:51 +, Richardson, Bruce wrote: > --- > --- > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Kollanukkaran > > Sent: Monday, March 11, 2019 12:45

[dpdk-dev] [PATCH v2 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-11 Thread David Marchand
Add a new "show/clear fwd stats all" command to display fwd and port statistics on the fly. To be able to do so, rte_port can't be used to maintain any statistics. Moved the stats dump parts from stop_packet_forwarding() and merge with fwd_port_stats_display() into fwd_stats_display(). fwd engine

[dpdk-dev] [PATCH v2 3/4] app/testpmd: remove useless casts on statistics

2019-03-11 Thread David Marchand
Caught by code review while investigating the stats display code. Switching all port and fwd engine statistics to uint64_t makes it possible to drop all casts. Signed-off-by: David Marchand --- app/test-pmd/testpmd.c | 62 ++ app/test-pmd/testpmd.h

[dpdk-dev] [PATCH v2 2/4] app/testpmd: add missing newline when showing statistics

2019-03-11 Thread David Marchand
Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] TX-burst

[dpdk-dev] [PATCH v2 0/4] display testpmd forwarding engine stats on the fly

2019-03-11 Thread David Marchand
Here is a little series that makes it possible to display and clear testpmd fwd engines while they run without having to stop them. This is mostly handy when running stress tests and you look for packets drops without having to stop/start testpmd forwarding. Example: testpmd> show fwd stats all

[dpdk-dev] [PATCH v2 1/4] app/testpmd: remove unused fwd_ctx field

2019-03-11 Thread David Marchand
Remove some leftover from a previous rework. Fixes: c4bcc342c8ee ("app/testpmd: refactor ieee1588 forwarding") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Rami Rosen --- Changelog since v1: - added Cc: stable --- app/test-pmd/testpmd.h | 1 - 1 file changed, 1 deletion(-)

Re: [dpdk-dev] [PATCH v1] app/testpmd: optimized MAC swap by using neon intrinsics

2019-03-11 Thread Honnappa Nagarahalli
> Improved MAC swap performance for ARM platform. > The improvement was achieved by using neon intrinsics to save CPU cycles and > doing swap for four packets at a time. > The optimization had 15% - 20% throughput boost in testpmd MAC swap mode. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavi

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-11 Thread Raslan Darawsheh
Hi, I've been trying to compile it as well without installing the VS stuff. But, it's always failing to compile: Even the sanitycheck.c file is failing with such error: lld-link.exe: error: could not open libcmt.lib: no such file or directory Kindest regards, Raslan Darawsheh > -Original Mess

[dpdk-dev] [PATCH v2] acl: fix missing flags when compiling without AVX2

2019-03-11 Thread Andrius Sirvys
When compiling the ACL library on a system without AVX2 support, the flags used to compile the AVX2-specific code for later run-time use were not based on the regular cflags for the rest of the library. This can cause errors due to symbols being missed/undefined due to incorrect flags. For example,

Re: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown sequence

2019-03-11 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-11 at 09:58 +, Van Haaren, Harry wrote: > --- > --- > > -Original Message- > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > > Sent: Friday, March 1, 2019 7:17 AM > > To: Jerin Jacob

[dpdk-dev] [PATCH] acl: fix missing flags when compiling without AVX2

2019-03-11 Thread Andrius Sirvys
When compiling the ACL library on a system without AVX2 support, the flags used to compile the AVX2-specific code for later run-time use were not based on the regular cflags for the rest of the library. This can cause errors due to symbols being missed/undefined due to incorrect flags. For example,

Re: [dpdk-dev] mlx5 under FreeBSD

2019-03-11 Thread Mit Matelske
I started spinning up a Linux box to do that exact test on Friday. I'll post the results later. Thanks! Mit Matelske - Original Message - From: "shahafs" To: "Mit Matelske" Cc: "stephen" , "Thomas Monjalon" , "dev" , "Yongseok Koh" Sent: Saturday, March 9, 2019 11:57:10 PM Subject:

Re: [dpdk-dev] [PATCH v1] app/testpmd: optimized MAC swap by using neon intrinsics

2019-03-11 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-11 at 16:14 +0800, Ruifeng Wang wrote: > --- > --- > Improved MAC swap performance for ARM platform. > The improvement was achieved by using neon intrinsics > to save CPU cycles and doing swap for four packets > at a ti

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-11 Thread Ananyev, Konstantin
> > > > > > > >>> In weak memory models, like arm64, reading the > > > > > > > >>> {prod,cons}.tail may get reordered after reading or > > > > > > > >>> writing the ring slots, which corrupts the ring and stale > > > > > > > >>> data is > > observed. > > > > > > > >>> > > > > > > > >>> This issue

[dpdk-dev] [dpdk] Header stripping

2019-03-11 Thread Oana Orjanu
Hello, I’ve noticed that, when doing Ip reassembly or Ip fragmentation, the header of all functions that do this operation requires the packets to be already stripped of the Ethernet header when reaching it. What is the advantage of doing it like this, instead of handling the packet manipulatio

Re: [dpdk-dev] [PATCH] event/opdl: fix sprintf with snprintf

2019-03-11 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-11 at 06:51 +, Jerin Jacob Kollanukkaran wrote: > On Mon, 2019-02-04 at 07:18 +, Pallantla Poornima wrote: > > > > %'16"PRIu64" %s " > > diff --git a/drivers/event/opdl/opdl_evdev_xstats.c > > b/drivers/event/opdl/opdl_evdev_xstats.c > > index 0e6c6bd5e..27b3d8802 100644 >

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-11 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Kollanukkaran > Sent: Monday, March 11, 2019 12:45 PM > To: Rawat, Anand ; dev@dpdk.org > Cc: Kadam, Pallavi ; tho...@monjalon.net; Menon, > Ranjit ; Shaw, Jeffrey B > > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v1 02/11] drivers/bus/ifpga: add function for AFU search by name

2019-03-11 Thread Xu, Rosen
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, March 06, 2019 20:45 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang > Subject: Re: [PATCH v1 02/11] drivers/bus/ifpga: add functi

Re: [dpdk-dev] [PATCH v1 05/11] drivers/net/ipn3ke: add IPN3KE PMD driver

2019-03-11 Thread Xu, Rosen
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, March 06, 2019 20:44 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang > Subject: Re: [PATCH v1 05/11] drivers/net/ipn3ke: add IPN3K

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-11 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-05 at 20:16 -0800, Anand Rawat wrote: > Added documentation to build helloworld example > on windows using meson and clang. Updated the > maintainers list to include windows maintainers. > > Signed-off-by: Anand Rawat > Signed-off-by: Pallavi Kadam > Reviewed-by: Jeff Shaw > Rev

Re: [dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding

2019-03-11 Thread Ferruh Yigit
On 3/11/2019 2:18 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Wednesday, March 6, 2019 12:31 AM >> To: Zhang, Qi Z >> Cc: dev@dpdk.org; Kevin Traynor ; Yan, Zhirun >> >> Subject: [RFC 2/2] net/i40e: update requested queue

Re: [dpdk-dev] [PATCH v8 0/3] generic spinlock optimization and test case enhancements

2019-03-11 Thread Nipun Gupta
> -Original Message- > From: Gavin Hu [mailto:gavin...@arm.com] > Sent: Friday, March 8, 2019 1:27 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; jer...@marvell.com; Hemant > Agrawal ; Nipun Gupta > ; honnappa.nagaraha...@arm.com; > gavin...@arm.com; i.maxim...@samsung.com;

[dpdk-dev] [PATCH v2 3/4] .gitignore: ignore hidden files

2019-03-11 Thread Bruce Richardson
Generally hidden files are hidden for good reason and we don't want to track them in git. They can always be manually added to git tracking individually if needed. Signed-off-by: Bruce Richardson --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index

[dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories

2019-03-11 Thread Bruce Richardson
test-meson-build.sh generates multiple build directories for various targets. As these follow a known pattern, and since they don't need to be tracked in git, we can add them to the gitignore file, along with the default build directory "build". Signed-off-by: Bruce Richardson --- .gitignore | 4

[dpdk-dev] [PATCH v2 2/4] .gitignore: ignore python bytecode files

2019-03-11 Thread Bruce Richardson
After you run a python script, a .pyc file is often left behind, which we don't want to track in git. Signed-off-by: Bruce Richardson --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index b23e1dbb7..eb3c23705 100644 --- a/.gitignore +++ b/.gitignore

[dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments

2019-03-11 Thread Bruce Richardson
Split the ignored file list into section based on logical groups of files, putting a comment at the top of each section clarifying what it is. Signed-off-by: Bruce Richardson --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 9105e26c5..b23e1dbb7

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-11 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anoob Joseph > Sent: Monday, March 11, 2019 5:56 AM > To: Akhil Goyal ; Doherty, Declan > ; De Lara Guarch, > Pablo > Cc: Anoob Joseph ; Ankur Dwivedi ; > Jerin Jacob > Kollanukkaran ; Narayana Prasad Raju Ath

Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO DMA map APIs

2019-03-11 Thread Burakov, Anatoly
On 10-Mar-19 8:28 AM, Shahaf Shuler wrote: As those should be replaced by rte_dev_dma_map and rte_dev_dma_unmap APIs. Signed-off-by: Shahaf Shuler --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v4 3/6] bus: introduce device level DMA memory mapping

2019-03-11 Thread Burakov, Anatoly
On 10-Mar-19 8:28 AM, Shahaf Shuler wrote: The DPDK APIs expose 3 different modes to work with memory used for DMA: 1. Use the DPDK owned memory (backed by the DPDK provided hugepages). This memory is allocated by the DPDK libraries, included in the DPDK memory system (memseg lists) and automati

Re: [dpdk-dev] [RFC] ethdev: check for invalid device name

2019-03-11 Thread Andrew Rybchenko
On 3/6/19 8:43 PM, Stephen Hemminger wrote: Do not allow creating a ethernet device with a name over the allowed maximum (or 0 length). Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown sequence

2019-03-11 Thread Van Haaren, Harry
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Friday, March 1, 2019 7:17 AM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > Subject: [dpdk-dev] [PATCH 3/3] app/eventdev: follow pro

Re: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info

2019-03-11 Thread Van Haaren, Harry
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Friday, March 1, 2019 7:17 AM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > Subject: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeli

Re: [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence

2019-03-11 Thread Van Haaren, Harry
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Friday, March 1, 2019 7:17 AM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > Subject: [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeli

Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

2019-03-11 Thread Bruce Richardson
On Sat, Mar 09, 2019 at 03:32:57PM +0200, Rami Rosen wrote: >> Thomas Monjalon <[1]tho...@monjalon.net> wrote: >>Yes, but "git ls build*" is not empty because of buildtools/ >>Could be "build" and "build-*". >+1 > Ok. I didn't want to be too liberal in my wildcarding hence the set

Re: [dpdk-dev] [PATCH v4 0/6] introduce DMA memory mapping for external memory

2019-03-11 Thread Gaëtan Rivet
Hello Shahaf, Thanks for taking my remarks into account. You can add my acked-by if you need to the series (not really for mlx5 PMD but you get the idea). BR, On Sun, Mar 10, 2019 at 10:27:57AM +0200, Shahaf Shuler wrote: > The DPDK APIs expose 3 different modes to work with memory used for DMA:

[dpdk-dev] [PATCH v1] app/testpmd: optimized MAC swap by using neon intrinsics

2019-03-11 Thread Ruifeng Wang
Improved MAC swap performance for ARM platform. The improvement was achieved by using neon intrinsics to save CPU cycles and doing swap for four packets at a time. The optimization had 15% - 20% throughput boost in testpmd MAC swap mode. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed

[dpdk-dev] [PATCH v2 1/2] app/eventdev: start event producers after eventdev

2019-03-11 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Start event producers after eventdev i.e. consumer is started as in some architectures it might lead to undefined behaviour or events being dropped. Signed-off-by: Pavan Nikhilesh Reviewed-by: Jerin Jacob --- app/test-eventdev/test_perf_atq.c | 31 +

[dpdk-dev] [PATCH v2 2/2] doc: add notes about eventdev producer consumer dependency

2019-03-11 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh EventDev i.e consumer needs to be started before starting the event producers. Update documentation of EventDev and EventDev adapters. Signed-off-by: Pavan Nikhilesh --- v2 Changes: Add Notes to doxygen API. doc/guides/prog_guide/event_crypto_adapter.rst | 5 +

[dpdk-dev] [PATCH] net/i40e: fix time sync for 25G

2019-03-11 Thread Qi Zhang
Time sync increment value is not configured for 25G device. The patch fix this issue by setting the same value as 40G, this aligned with kernel driver's behaviour. Fixes: 75d133dd3296 ("net/i40e: enable 25G device") Cc: sta...@dpdk.org Reported-by: Michael Luo Signed-off-by: Qi Zhang --- driv

Re: [dpdk-dev] [PATCH v3 38/38] net/ice/base: fix set UDP PTYPEs

2019-03-11 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, March 11, 2019 3:05 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: dev@dpdk.org; Stillwell Jr, Paul M ; Yigit, > Ferruh ; Zhang, Qi Z > Subject: [PATCH v3 38/38] net/ice/base: fix set UDP PTYPEs > > Set the UDP PTYPEs to inner-last

[dpdk-dev] [PATCH v3 36/38] net/ice/base: increase prototol offset size

2019-03-11 Thread Qi Zhang
OS package's format is changed, field vector's protocol offset size is changed from 8 bit to 16 bit. So base code also need to align to this, or PMD will not be able to load OS package correctly. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_flex_type.h

[dpdk-dev] [PATCH v3 37/38] net/ice/base: revert the workaround for resource allocation

2019-03-11 Thread Qi Zhang
Revert the workaround for allocating TCAM and FV entries to align with latest firmware. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 11 +- drivers/net/ice/base/ice_common.h| 2 +- drivers/net/ice/base/ic

[dpdk-dev] [PATCH v3 35/38] net/ice/base: minor fix

2019-03-11 Thread Qi Zhang
1. clean flow entry's action structure after remove it. 2. initialized priority when add a new flow entry 3. remove RSS configuration before deleting the flow profile. Fixes: aa1cd410fa64 ("net/ice/base: add flow module") Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-o

[dpdk-dev] [PATCH v3 38/38] net/ice/base: fix set UDP PTYPEs

2019-03-11 Thread Qi Zhang
Set the UDP PTYPEs to inner-last for non-tunneled packats according to data sheet. This also fix the issue that IPv4 TCP RSS does not work if RSS for IPv6 UDP is also configured. Fixes: aa1cd410fa64 ("net/ice/base: add flow module") Vignesh Sridhar Signed-off-by: Qi Zhang --- drivers/net/ice/

[dpdk-dev] [PATCH v3 34/38] net/ice/base: fix duplicate resource allocations

2019-03-11 Thread Qi Zhang
This patch ensure that TCAM allocations made by a newly added VSIG that has the same characteristic list of an existing VSIG are removed. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang

[dpdk-dev] [PATCH v3 33/38] net/ice/base: change profile priority for RSS reply

2019-03-11 Thread Qi Zhang
1. Add call to replay RSS configurations 2. Add RSS configurations to end of list and not the head to avoid inversion on replay. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 - drivers/net/ice/base/ice_

[dpdk-dev] [PATCH v3 30/38] net/ice/base: change profile id reference counting

2019-03-11 Thread Qi Zhang
Improved the profile reference counting, by moving it from being based on how many TCAM entries using the profile to how many profile map entries are using the profile. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c

[dpdk-dev] [PATCH v3 28/38] net/ice/base: return config error without queue to disable

2019-03-11 Thread Qi Zhang
If there is no queue to disable, return appropriate configuration error earlier without acquiring the lock. Signed-off-by: Akeem G Abodunrin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 17 ++--- 1 file changed, 10 insertions(+)

[dpdk-dev] [PATCH v3 32/38] net/ice/base: add FDIR support

2019-03-11 Thread Qi Zhang
Add flow director related support base code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/Makefile | 1 + drivers/net/ice/base/ice_adminq_cmd.h | 13 + drivers/net/ice/base/ice_common.c | 36 ++ drivers/net/ice/base/ice_common.h | 1 +

  1   2   >