[dpdk-dev] [PATCH 7/8] net/ice: support RX scatter AVX2 vector

2019-02-27 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 10 -- drivers/net/ice/ice_rxtx.h | 3 ++ drivers/net/ice/ice_rxtx_vec_avx2.c | 63 + 3 files changed, 73 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/

[dpdk-dev] [PATCH 8/8] net/ice: support TX AVX2 vector

2019-02-27 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_19_05.rst | 4 + drivers/net/ice/ice_rxtx.c | 14 ++- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c| 153 + 4 files changed, 171 insertions(+), 2 del

[dpdk-dev] [PATCH 4/8] net/ice: support RX scatter SSE vector

2019-02-27 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 16 +++ drivers/net/ice/ice_rxtx.h | 2 ++ drivers/net/ice/ice_rxtx_vec_sse.c | 41 ++ 3 files changed, 55 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_rx

[dpdk-dev] [PATCH 6/8] net/ice: support RX AVX2 vector

2019-02-27 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/Makefile| 19 ++ drivers/net/ice/ice_rxtx.c | 17 +- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c | 548 drivers/net/ice/meson.build | 15 + 5 fil

[dpdk-dev] [PATCH 5/8] net/ice: support TX SSE vector

2019-02-27 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 2 + drivers/net/ice/ice_rxtx.c| 17 + drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_common.h | 133 + drivers/net/ice/ice_rxtx_vec_sse.c| 135

[dpdk-dev] [PATCH 2/8] net/ice: add pointer for queue buffer release

2019-02-27 Thread Wenzhuo Lu
Add function pointers of buffer releasing for RX and TX queues, for vector functions will be added for RX and TX. Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 24 +++- drivers/net/ice/ice_rxtx.h | 5 + 2 files changed, 20 insertions(+), 9 deletions(-) diff

[dpdk-dev] [PATCH 3/8] net/ice: support RX SSE vector

2019-02-27 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- config/common_base| 1 + doc/guides/nics/features/ice_vec.ini | 38 +++ drivers/net/ice/Makefile | 3 + drivers/net/ice/ice_ethdev.c | 2 - drivers/net/ice/ice_ethdev.h | 2 + drivers/net/ice/ice_rxtx.c

[dpdk-dev] [PATCH 1/8] net/ice: fix TX function setting

2019-02-27 Thread Wenzhuo Lu
The TX setting functions is not called. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index a23c63a..b804be1 100644 --

[dpdk-dev] [PATCH 0/8] Support vector instructions on ICE

2019-02-27 Thread Wenzhuo Lu
Use SSE and AVX2 instructions in ICE RX and TX path. Wenzhuo Lu (8): net/ice: fix TX function setting net/ice: add pointer for queue buffer release net/ice: support RX SSE vector net/ice: support RX scatter SSE vector net/ice: support TX SSE vector net/ice: support RX AVX2 vector net

[dpdk-dev] [PATCH] kni: fix possible kernel crash with va2pa

2019-02-27 Thread Yangchao Zhou
va2pa depends on the physical address and virtual address offset of current mbuf. It may get the wrong physical address of next mbuf which allocated in another hugepage segment. Signed-off-by: Yangchao Zhou --- kernel/linux/kni/kni_net.c | 16 ++-- .../eal/inclu

[dpdk-dev] [PATCH v1 10/11] doc: add IPN3KE document

2019-02-27 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE document. Signed-off-by: Rosen Xu Signed-off-by: Dan Wei --- doc/guides/nics/features/ipn3ke.ini | 57 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/ipn3ke.rst | 97 + 3 file

[dpdk-dev] [PATCH v1 11/11] MAINTAINERS: add MAINTAINERS for IPN3KE

2019-02-27 Thread Rosen Xu
Add MAINTAINERS for Intel FPGA Acceleration NIC IPN3KE. Signed-off-by: Rosen Xu --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 835d8a2..ec49f00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -599,6 +599,13 @@ F: drivers/net/ice/ F: doc/

[dpdk-dev] [PATCH v1 09/11] usertools: add IPN3KE device bind

2019-02-27 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE device bind. Signed-off-by: Rosen Xu --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index a9cd66a..067a809 100755 --- a/usertools/dpdk-devbind.py +++

[dpdk-dev] [PATCH v1 07/11] mk: add link enablement for IPN3KE

2019-02-27 Thread Rosen Xu
Add link enablement for Intel FPGA Acceleration NIC IPN3KE. Signed-off-by: Rosen Xu --- mk/rte.app.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 8a4f0f4..8b427d1 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -295,6 +295,7 @@ endif # CONFIG_RTE_LIB

[dpdk-dev] [PATCH v1 04/11] drivers/raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

2019-02-27 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev. Signed-off-by: Rosen Xu Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 146 +++- drivers/raw/ifpga_rawdev/ifpga_rawdev_api.h | 71 ++ 2

[dpdk-dev] [PATCH v1 06/11] config: add build enablement for IPN3KE

2019-02-27 Thread Rosen Xu
Add build enablement for Intel FPGA Acceleration NIC IPN3KE. Signed-off-by: Rosen Xu --- config/common_base | 6 ++ 1 file changed, 6 insertions(+) diff --git a/config/common_base b/config/common_base index 7c6da51..4fac8ba 100644 --- a/config/common_base +++ b/config/common_base @@ -316,6

[dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd

2019-02-27 Thread Rosen Xu
Add IPN3KE support for testpmd Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- app/test-pmd/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index d5258ea..a6b6f6f 100644 --- a/app/test-pmd/Makefile +++ b/app/test-pmd/Makefile @@

[dpdk-dev] [PATCH v1 03/11] drivers/raw/ifpga_rawdev: add OPAE share code for IPN3KE

2019-02-27 Thread Rosen Xu
Add OPAE share code for Intel FPGA Acceleration NIC IPN3KE. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/Makefile | 7 + drivers/raw/ifpga_rawdev/base/ifpga_api.c | 69 ++- drivers/raw/ifpga_rawdev/base/ifpga_api.h | 1 + drivers/raw/ifpga_raw

[dpdk-dev] [PATCH v1 00/11] Add patch set for IPN3KE

2019-02-27 Thread Rosen Xu
This patch set adds the support of a new net PMD, Intel?? FPGA Programmable Acceleration Card N3000, also called ipn3ke. The ipn3ke PMD (librte_pmd_ipn3ke) provides poll mode driver support for Intel?? FPGA PAC(Programmable Acceleration Card) N3000 based on the Intel Ethernet Controller X710/XXV71

[dpdk-dev] [PATCH v1 02/11] drivers/bus/ifpga: add function for AFU search by name

2019-02-27 Thread Rosen Xu
In many scenarios, AFU is needed searched by name, this function add the feature. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/ifpga_bus.c | 13 + drivers/bus/ifpga/rte_bus_ifpga.h | 3 +++ 2 files changed, 16 insertions(+) diff --git a/drivers/bus/ifp

[dpdk-dev] [PATCH v1 01/11] drivers/bus/ifpga: add AFU shared data

2019-02-27 Thread Rosen Xu
AFU can be implemented into many different acceleration devices, these devices need shared data to store private information when they are handled by users. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/rte_bus_ifpga.h | 7 +++ 1 file changed, 7 insertions(+) diff -

[dpdk-dev] [PATCH 15/15] doc: update release notes for enic

2019-02-27 Thread Hyong Youb Kim
Signed-off-by: Hyong Youb Kim --- doc/guides/rel_notes/release_19_05.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index 4a3e2a7f3..9226dc5e9 100644 --- a/doc/guides/rel_notes/release_19_05.rst +++ b/d

[dpdk-dev] [PATCH 14/15] doc: update enic guide

2019-02-27 Thread Hyong Youb Kim
Minor changes to text around flow API. - Add vlan to the supported items. - Describe VLAN stripping's effect on ETH/VLAN match - Mention limitations on MARK, RAW, RSS, and PASSTHRU Signed-off-by: Hyong Youb Kim --- doc/guides/nics/enic.rst | 16 ++-- 1 file changed, 14 insertions(+),

[dpdk-dev] [PATCH 13/15] net/enic: fix several issues with inner packet matching

2019-02-27 Thread Hyong Youb Kim
Inner packet matching is currently buggy in many cases. 1. Mishandling null spec ("match any"). The copy_item functions do nothing if spec is null. This is incorrect, as all patterns should be appended to the L5 pattern buffer even for null spec (treated as all zeros). 2. Accessing null spec caus

[dpdk-dev] [PATCH 09/15] net/enic: enable limited support for RAW flow item

2019-02-27 Thread Hyong Youb Kim
Some apps like VPP use a raw item to match UDP tunnel headers like VXLAN or GENEVE. The NIC hardware supports such usage via L5 match, which does pattern match on packet data immediately following the outer L4 header. Accept raw items for these limited use cases. Signed-off-by: Hyong Youb Kim ---

[dpdk-dev] [PATCH 11/15] net/enic: fix a couple issues with VXLAN match

2019-02-27 Thread Hyong Youb Kim
The filter API does not have flags for "match VXLAN". Explicitly set the UDP destination port and mask in the L4 pattern. Otherwise, UDP packets with non-VXLAN ports may be falsely reported as VXLAN. 1400 series VIC adapters have hardware VXLAN parsing. The L5 buffer on the NIC starts with the inn

[dpdk-dev] [PATCH 10/15] net/enic: initialize VXLAN port regardless of overlay offload

2019-02-27 Thread Hyong Youb Kim
Currently, the driver resets the vxlan port register only if overlay offload is enabled. But, the register is actually tied to hardware vxlan parsing, which is an independent feature and is always enabled even if overlay offload is disabled. If left uninitialized, it can affect flow rules that matc

[dpdk-dev] [PATCH 12/15] net/enic: fix an endian bug in VLAN match

2019-02-27 Thread Hyong Youb Kim
The VLAN fields in the NIC filter use little endian. The VLAN item is in big endian, so swap bytes. Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_flow.c | 12 1 file cha

[dpdk-dev] [PATCH 06/15] net/enic: enable limited RSS flow action

2019-02-27 Thread Hyong Youb Kim
Some apps like OVS-DPDK use MARK+RSS flow rules in order to offload packet matching to the NIC. The RSS action in such flow rules simply indicates "receive packet normally", not trying to override the port wide RSS. The action is included in the flow rules simply to terminate them, as MARK is not a

[dpdk-dev] [PATCH 04/15] net/enic: allow flow mark ID 0

2019-02-27 Thread Hyong Youb Kim
The driver currently accepts mark ID 0 but does not report it in matching packet's mbuf. For example, the following testpmd command succeeds. But, the mbuf of a matching IPv4 UDP packet does not have PKT_RX_FDIR_ID set. flow create 0 ingress pattern ... actions mark id 0 / queue index 0 / end The

[dpdk-dev] [PATCH 07/15] net/enic: enable limited PASSTHRU flow action

2019-02-27 Thread Hyong Youb Kim
Some apps like VPP use PASSTHRU+MARK flow rules to offload packet matching to the NIC. Just like MARK+RSS used by OVS-DPDK and others, PASSTHRU+MARK is used to "mark and then receive normally". Recent VIC adapters support such flow rules, so enable PASSTHRU for this limited use case. Signed-off-by

[dpdk-dev] [PATCH 08/15] net/enic: move arguments into struct

2019-02-27 Thread Hyong Youb Kim
There are many copy_item functions, all with the same arguments, which makes it difficult to add/change arguments. Move the arguments into a struct to help subsequent commits that will add/fix features. Also remove self-explanatory verbose comments for these local functions. These changes are pure

[dpdk-dev] [PATCH 05/15] net/enic: check for unsupported flow item types

2019-02-27 Thread Hyong Youb Kim
Currently a pattern with an unsupported item type causes segfault, because the flow handler is using the type as an array index without checking bounds. Add an explicit check for unsupported item types and avoid out-of-bound accesses. Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced

[dpdk-dev] [PATCH 00/15] net/enic: 19.05 updates

2019-02-27 Thread Hyong Youb Kim
This patch series fixes bugs in enic's implementation of flow API and adds very limited support for RAW, RSS, and PASSTHRU. Limited RSS and PASSTHRU are intended to support partial offloads in OVS-DPDK and VPP. These apps use MARK + default RSS and PASSTHRU + MARK to "mark packet and then receive n

[dpdk-dev] [PATCH 03/15] net/enic: fix SCTP match for flow API

2019-02-27 Thread Hyong Youb Kim
The driver needs to explicitly set the protocol number (132) in the IP header pattern, as the current firmware filter API lacks "match SCTP packet" flag. Otherwise, the resulting NIC filter may lead to false positives (i.e. NIC reporting non-SCTP packets as SCTP packets). The flow director handler

[dpdk-dev] [PATCH 02/15] net/enic: fix flow director SCTP matching

2019-02-27 Thread Hyong Youb Kim
The firmware filter API does not have flags indicating "match SCTP packet". Instead, the driver needs to explicitly add an IP match and set the protocol number (132 for SCTP) in the IP header. The existing code (copy_fltr_v2) has two bugs. 1. It sets the protocol number (132) in the match value,

[dpdk-dev] [PATCH 01/15] net/enic: remove unused code

2019-02-27 Thread Hyong Youb Kim
Remove unused functions. Specifically, vnic_set_rss_key() is obsolete. enic_{add,del}_vlan() has never been supported in the firmware. And, remove vnic_rss.c altogether as it becomes empty. These were discovered by cppcheck. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Andrew Rybchenko
On 2/27/19 9:30 PM, Stephen Hemminger wrote: On Wed, 27 Feb 2019 14:24:21 +0300 Andrew Rybchenko wrote: On 2/27/19 2:21 PM, Ferruh Yigit wrote: On 2/26/2019 9:34 PM, Stephen Hemminger wrote: The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local logging. Signed-off-by:

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-27 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: Monday, February 25, 2019 5:22 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo ; Yigit, Ferruh > ; Thomas Monjalo

Re: [dpdk-dev] [PATCH 1/5] eal: drop unused RTE_PROC_PRIMARY_OR macros

2019-02-27 Thread Rami Rosen
Reviewed-by: Rami Rosen

[dpdk-dev] [PATCH 37/37] net/ice/base: revert the workaround for resource allocation

2019-02-27 Thread Qi Zhang
Revert the workaround for allocating TCAM and FV entries to align with latest firmware. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 11 +- drivers/net/ice/base/ice_common.h| 2 +- drivers/net/ice/base/ic

[dpdk-dev] [PATCH 36/37] net/ice/base: increase prototol offset size

2019-02-27 Thread Qi Zhang
Increase field vector's protocol offset size from 8 bit to 16 bit. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_flex_type.h | 8 +++- drivers/net/ice/base/ice_flow.c | 7 +-- drivers/net/ice/base/ice_flow.h | 2 +- drivers

[dpdk-dev] [PATCH 35/37] net/ice/base: minor fix

2019-02-27 Thread Qi Zhang
1. clean flow entry's action structure after remove it. 2. initialized priority when add a new flow entry 3. remove RSS configuration before deleting the flow profile. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 2 +- drivers/net/ice/ba

[dpdk-dev] [PATCH 34/37] net/ice/base: remove duplicate resource allocations

2019-02-27 Thread Qi Zhang
This patch ensure that TCAM allocations made by a newly added VSIG that has the same characteristic list of an existing VSIG are removed. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 85 +---

[dpdk-dev] [PATCH 33/37] net/ice/base: change profile priority for RSS reply

2019-02-27 Thread Qi Zhang
1. Add call to replay RSS configurations 2. Add RSS configurations to end of list and not the head to avoid inversion on replay. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 - drivers/net/ice/base/ice_

[dpdk-dev] [PATCH 30/37] net/ice/base: change profile id reference counting

2019-02-27 Thread Qi Zhang
Improved the profile reference counting, by moving it from being based on how many TCAM entries using the profile to how many profile map entries are using the profile. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c

[dpdk-dev] [PATCH 31/37] net/ice/base: add DCB support

2019-02-27 Thread Qi Zhang
Add module to support DCB related features. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/Makefile |1 + drivers/net/ice/base/ice_adminq_cmd.h | 243 ++ drivers/net/ice/base/ice_common.c | 12 + drivers/net/ice/base/ice_dcb.c|

[dpdk-dev] [PATCH 32/37] net/ice/base: add FDIR support

2019-02-27 Thread Qi Zhang
Add flow director related support base code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/Makefile | 1 + drivers/net/ice/base/ice_adminq_cmd.h | 13 + drivers/net/ice/base/ice_common.c | 36 ++ drivers/net/ice/base/ice_common.h | 1 +

[dpdk-dev] [PATCH 29/37] net/ice/base: add function to check FW recovery mode

2019-02-27 Thread Qi Zhang
Code added to check the FW recovery mode. This function will be used by the drivers during init to check whether the FW is in recovery mode or not. If FW is in recovery mode then the drivers need to run in a recovery mode where it can allow only limited operations. Link should be down, allow only c

[dpdk-dev] [PATCH 24/37] net/ice/base: remove local VSIG allocations

2019-02-27 Thread Qi Zhang
If allocating a VSI to a VSIG fails the local allocations made for VSIG profiles and change-lists will not be removed. Adding calls to free these entries on error in VSIG management calls. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net

[dpdk-dev] [PATCH 23/37] net/ice/base: do not write TCAM entries back

2019-02-27 Thread Qi Zhang
Profile TCAM entry removal is handled by the firmware when freeing the resource, so the driver does not need to write these default entries back with an update Package action. This patch removes writing of the TCAM entry using Update Package command when removing it, since the entry has already be

[dpdk-dev] [PATCH 26/37] net/ice/base: update copyright time

2019-02-27 Thread Qi Zhang
Update copyright time to 2019. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h| 2 +- drivers/net/ice/base/ice_alloc.h | 2 +- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_common.h| 2 +- drive

[dpdk-dev] [PATCH 22/37] net/ice/base: add RSS key related macro and structures

2019-02-27 Thread Qi Zhang
Add define for 52 byte RSS hash key size, and add struct ice_aqc_get_set_rss_keys comments regarding setting 40 bytes and 52 byte hash key. Signed-off-by: Paul Greenwalt Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 13 + 1 f

[dpdk-dev] [PATCH 28/37] net/ice/base: return config error without queue to disable

2019-02-27 Thread Qi Zhang
If there is no queue to disable, return appropriate configuration error earlier without acquiring the lock. Signed-off-by: Akeem G Abodunrin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 17 ++--- 1 file changed, 10 insertions(+)

[dpdk-dev] [PATCH 27/37] net/ice/base: resolve static analysis reported issues

2019-02-27 Thread Qi Zhang
Resolve static analysis reported issue in ice_get_itr_intrl_gran and ice_ptg_find_ptype. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 12 ++-- drivers/net/ice/base/ice_flex_pipe.c | 7 +-- 2 files

[dpdk-dev] [PATCH 25/37] net/ice/base: minor fix

2019-02-27 Thread Qi Zhang
1. Fix some problems with filling the HW tables. 2. Fix a logic error in ice_rem_prof_from_list. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 21/37] net/ice/base: enhance get link status command

2019-02-27 Thread Qi Zhang
Extend the functionality of the admin queue command by including additional status and ID bits to improve link topology configuration. Signed-off-by: Matthew Vick Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 7 ++- 1 file changed, 6

[dpdk-dev] [PATCH 19/37] net/ice/base: enable VSI queue context

2019-02-27 Thread Qi Zhang
The patch added to retrieve the queue context and update the queue handle for lan queues. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 60 --- drivers/net/ice/base/ice_common.h |

[dpdk-dev] [PATCH 20/37] net/ice/base: ensure only valid bits are set

2019-02-27 Thread Qi Zhang
In the ice_aq_set_phy_cfg AQ command, the 16.4 bit is reserved. This patch will make sure that this bit will never be set to 1. Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 1 + drivers/net/ice/base/ice_common

[dpdk-dev] [PATCH 17/37] net/ice/base: update macros

2019-02-27 Thread Qi Zhang
Update macros for metadata and package flags. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 36 - drivers/net/ice/base/ice_flow.h | 17 ++-- drivers/net/ice/base/ice_lan_tx_rx.h | 77 +++

[dpdk-dev] [PATCH 18/37] net/ice/base: code clean

2019-02-27 Thread Qi Zhang
Change below function as static and also relocated code line to align with kernel driver. ice_aq_move_sched_elems ice_sched_get_agg_node ice_sched_set_node_bw_lmt ice_sched_cfg_node_bw_alloc ice_sched_add_agg_cfg ice_sched_rm_agg_cfg ice_sched_move_vsi_to_agg ice_sched_del_rl_profile ice_sched_rm_

[dpdk-dev] [PATCH 15/37] net/ice/base: add two helper functions for flow management

2019-02-27 Thread Qi Zhang
1. ice_rem_all_sw_rules_info - remove all switch rules. 2. ice_reply_all_fltr - replay all filters stored in book keeping list. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 107 ++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH 16/37] net/ice/base: minor fix

2019-02-27 Thread Qi Zhang
1. ICE_SW_LKUP_LAST need to be handled correctly in ice_aq_alloc_free_vsi_list and ice_update_vsi_list_rule 2. ICE_SW_LKUP_ETHERTYPE_MAC need to be handled correctly in ice_update_vsi_lkup_fltr 3. free package segment pointer during ice_deinit_hw Signed-off-by: Paul M Stillwell Jr Signed-off-by:

[dpdk-dev] [PATCH 11/37] net/ice/base: add APIs to get allocated resources

2019-02-27 Thread Qi Zhang
1. ice_aq_get_res_alloc - get allocated resources. 2. ice_aq_get_res_descs - get allocated resource descriptors. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 53 +- drivers/net/ice/base/ice_switch.c | 83 +

[dpdk-dev] [PATCH 13/37] net/ice/base: add APIs to get VSI promiscuous mode

2019-02-27 Thread Qi Zhang
1. ice_get_vsi_promisc - get promiscuous mode of give VSI. 2. ice_get_vsi_vlan_promisc - get VLAN promiscuous mode of given VSI. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 79 +++ drivers/net/ice/base/ic

[dpdk-dev] [PATCH 08/37] net/ice/base: add more APIs in switch module

2019-02-27 Thread Qi Zhang
Add below APIs in switch module 1. ice_aq_get_vsi_params - get VSI context info 2. ice_aq_add_update_mir_rule - add/update mirror rule 3. ice_aq_delete_mir_rule - delete mirror rule 4. ice_aq_set_storm_ctrl - set storm control configuration 5. ice_aq_get_storm_ctrl - get storm control configurati

[dpdk-dev] [PATCH 14/37] net/ice/base: add MAC filter with marker and counter

2019-02-27 Thread Qi Zhang
1. ice_add_mac_with_sw_marker - add filter with software marker. 2. ice_add_mac_with_counter - add filter with counter enabled. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 328 ++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH 09/37] net/ice/base: add VSI queue context framework

2019-02-27 Thread Qi Zhang
Added code to allocate VSI queue contexts to save the queue specific information like bandwidth etc. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 52 +++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH 10/37] net/ice/base: add APIs to add remove ethertype filter

2019-02-27 Thread Qi Zhang
Add API ice_remove_eth_mac and ice_add_eth_mac to support adding / removing ethertype (or MAC) based filter rules. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 57 +++ drivers/net/ice/base/ice_switch.h |

[dpdk-dev] [PATCH 12/37] net/ice/base: add APIs to alloc/free VLAN resource counter

2019-02-27 Thread Qi Zhang
1. ice_alloc_res_cntr - allocate resource counter 2. ice_free_res_cntr - free resource counter 3. ice_alloc_vlan_res_counter - allocate vlan resource counter 4. ice_free_vlan_res_counter - free vlan resource counter Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/

[dpdk-dev] [PATCH 06/37] net/ice/base: code clean

2019-02-27 Thread Qi Zhang
Remove unnecessary macro and data structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 - drivers/net/ice/base/ice_flex_pipe.c | 2 - drivers/net/ice/base/ice_flow.c | 136 -- drivers/net/i

[dpdk-dev] [PATCH 07/37] net/ice/base: declare functions as external

2019-02-27 Thread Qi Zhang
Remove static of below functions and declare them as external APIs. ice_aq_add_vsi ice_aq_free_vsi ice_aq_update_vsi ice_aq_add_lan_txq ice_init_pkg Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_common.h

[dpdk-dev] [PATCH 05/37] net/ice/base: allow package copy to be used after resets

2019-02-27 Thread Qi Zhang
For components that make a copy of an external pipeline package file (i.e. the Linux and FreeBSD drivers), save the size of the package file along with the copy so that both can be used when calling ice_init_pkg() after a CORER/GLOBR reset. Also, do not free the copy of the package file in ice_ini

[dpdk-dev] [PATCH 04/37] net/ice/base: add helper macros

2019-02-27 Thread Qi Zhang
1. Add macro ice_for_each_traffic_class to loop for each traffic class. 2. Add macro MIN_T to wrap min with type conversion. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 2 +- drivers/net/ice/base/ice_nvm.c| 7 --- drivers/net/ice/

[dpdk-dev] [PATCH 03/37] net/ice/base: add two helper functions

2019-02-27 Thread Qi Zhang
Add two helper functions in common module. 1. ice_aq_set_mac_cfg to help configure maximum frame size with AQ command 2. ice_get_ctx help to extract context bits from a packet structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 20 +

[dpdk-dev] [PATCH 01/37] net/ice/base: add switch resource allocation and free

2019-02-27 Thread Qi Zhang
Add two APIs ice_alloc_sw and ice_free_sw to support switch related resource allocation and free. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 150 ++ drivers/net/ice/base/ice_switch.h | 5 ++ 2 files ch

[dpdk-dev] [PATCH 00/37] share code update.

2019-02-27 Thread Qi Zhang
Main changes: 1. add DCB/FDIR support. 2. add more APIs in switch module. 3. code clean and bug fix. Qi Zhang (37): net/ice/base: add switch resource allocation and free net/ice/base: improve comments net/ice/base: add two helper functions net/ice/base: add helper macros net/ice/base: a

Re: [dpdk-dev] [PATCH 3/7] test/stack: add stack test

2019-02-27 Thread Eads, Gage
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, February 25, 2019 4:59 AM > To: Eads, Gage > Cc: dev@dpdk.org; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha...@arm.com; n...@arm.co

Re: [dpdk-dev] [PATCH 1/7] stack: introduce rte stack library

2019-02-27 Thread Eads, Gage
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, February 25, 2019 4:43 AM > To: Eads, Gage > Cc: dev@dpdk.org; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha...@arm.com; n...@arm.co

Re: [dpdk-dev] [PATCH v3] net/ice: faster bit check

2019-02-27 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, February 18, 2019 8:47 PM > To: Stillwell Jr, Paul M > Cc: dev@dpdk.org; Brandeburg, Jesse > Subject: RE: [PATCH v3] net/ice: faster bit check > > > > > -Original Message- > > From: Stillwell Jr, Paul M > > Sent: Satur

[dpdk-dev] [dpdk-announce] DPDK development process and tools survey

2019-02-27 Thread Honnappa Nagarahalli
Hello, There have been questions/comments in the past DPDK summits on improving the development process and the tools being used. This survey is being conducted to better understand the pain points and arrive at a set of tools to use going forward. The survey itself will be done in 2 st

Re: [dpdk-dev] [RFC 1/6] ethdev: add min/max MTU to device info

2019-02-27 Thread Ian Stokes
On 2/25/2019 7:40 AM, Andrew Rybchenko wrote: On 2/20/19 6:57 PM, Ian Stokes wrote: From: Stephen Hemminger This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existin

[dpdk-dev] [PATCH v1 3/6] net/i40e: set min and max MTU for i40e VF devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e VF devices via the i40evf_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i4

[dpdk-dev] [PATCH v1 5/6] net/ixgbe: set min and max MTU for ixgbe VF devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe VF devices via the ixgbevf_dev_set_mtu() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. As transport overhead is the same for VF and PF ixg

[dpdk-dev] [PATCH v1 4/6] net/ixgbe: set min and max MTU for ixgbe devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe devices via the ixgbe_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'IXGBE_ETH_OVE

[dpdk-dev] [PATCH v1 2/6] net/i40e: set min and max MTU for i40e devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e devices via the i40e_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v1 6/6] net/e1000: set min and max MTU for igb devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for igb devices via the eth_igb_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'E1000_ETH_OVERHEA

[dpdk-dev] [PATCH v1 0/6] ethdev: add min/max MTU to device info

2019-02-27 Thread Ian Stokes
Building upon the discussion around [1], this series introduces MTU min and MTU max variables. It also provides updates to PMD implementations for ixgbe, i40e and IGB devices so that these variables are populated for use when retrieving device info. This series was tested with OVS DPDK and functio

[dpdk-dev] [PATCH v1 1/6] ethdev: add min/max MTU to device info

2019-02-27 Thread Ian Stokes
From: Stephen Hemminger This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. The initial version sets max mtu to normal Ethernet, it is up to PMD to

[dpdk-dev] DPDK port for vcpkg

2019-02-27 Thread Ernest Zed
Hi, I've submitted a PR to vcpkg vcpkg overview: "Vcpkg helps you manage C and C++ libraries on Windows, Linux and MacOS. This tool and ecosystem are constantly evolving; your involvement is vital to its success!" I

[dpdk-dev] [PATCH 2/2] doc: add notes regarding eventdev producer consumer dependency

2019-02-27 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh EventDev i.e consumer needs to be started before starting the event producers. Update documentation of EventDev and EventDev adapters. Signed-off-by: Pavan Nikhilesh --- doc/guides/prog_guide/event_crypto_adapter.rst | 5 + doc/guides/prog_guide/event_ethernet_rx

[dpdk-dev] [PATCH 1/2] app/eventdev: start event producers after eventdev is started

2019-02-27 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Start event producers after eventdev i.e. consumer is started as in some architectures it might lead to undefined behaviour or events being dropped. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c | 31 + app/test-eventde

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Stephen Hemminger
On Wed, 27 Feb 2019 14:24:21 +0300 Andrew Rybchenko wrote: > On 2/27/19 2:21 PM, Ferruh Yigit wrote: > > On 2/26/2019 9:34 PM, Stephen Hemminger wrote: > >> The sfc driver was still using RTE_LOGTYPE_PMD which was superseded > >> by local logging. > >> > >> Signed-off-by: Stephen Hemminger > >

[dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-02-27 Thread Junjie Wan
From: junka The bitmap will help maintain the metrics. We can dynamically add and remove metrics data. For example, after uninit latency lib, it could remove itself from the metrics. This could make the result from rte_metrics_get_names much more simple to display the wanted metrics data only. S

Re: [dpdk-dev] [RFC v4] /net: memory interface (memif)

2019-02-27 Thread Ferruh Yigit
On 2/20/2019 11:52 AM, Jakub Grajciar wrote: > Memory interface (memif), provides high performance > packet transfer over shared memory. > > Signed-off-by: Jakub Grajciar > --- > MAINTAINERS |6 + > config/common_base |5 + > confi

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Aaron Conole
Luca Boccassi writes: > On Wed, 2019-02-27 at 10:53 -0500, Aaron Conole wrote: >> Thomas Monjalon writes: >> >> > 27/02/2019 15:35, Aaron Conole: >> > > Thomas Monjalon writes: >> > > > 07/02/2019 23:01, Michael Santana: >> > > > > +python3.5 -m pip install --upgrade meson --user >> > > > >>

[dpdk-dev] [PATCH v2] net/sfc: do not use PMD logtype

2019-02-27 Thread Ferruh Yigit
From: Stephen Hemminger The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local logging. Signed-off-by: Stephen Hemminger --- v2: * Replaced all RTE_LOGTYPE_PMD instances in sfc_register_logtype() * ternary replaced with if and multiple return because of the compiler erro

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Luca Boccassi
On Wed, 2019-02-27 at 10:53 -0500, Aaron Conole wrote: > Thomas Monjalon writes: > > > 27/02/2019 15:35, Aaron Conole: > > > Thomas Monjalon writes: > > > > 07/02/2019 23:01, Michael Santana: > > > > > +python3.5 -m pip install --upgrade meson --user > > > > > > > > Which distributions have pyt

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Aaron Conole
Thomas Monjalon writes: > 27/02/2019 15:35, Aaron Conole: >> Thomas Monjalon writes: >> > 07/02/2019 23:01, Michael Santana: >> >> +# Just used for the 'classic' configuration system (ie: make) >> > >> > I am not sure about supporting the legacy system in a new CI. >> >> For now, documentation

[dpdk-dev] [PATCH] vfio: document multiprocess limitation for container API

2019-02-27 Thread Anatoly Burakov
Currently, there is no support for sharing custom VFIO containers between multiple processes, but it is not documented. Document this limitation. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_vfio.h | 4 1 file changed, 4 insertions(+) diff --gi

  1   2   >