Re: [dpdk-dev] [PATCH 1/2] net/bonding: do not set promisc on non-existent primary port

2019-02-09 Thread Chas Williams
On 1/10/19 5:22 AM, Hyong Youb Kim wrote: For active-backup, tlb, and alb mode, bond_ethdev_promiscuous_{enable,disable} tries to set promisc mode on the primary port, even when there are no slaves. It is harmless, as rte_eth_promiscuous_{enable,disable} does nothing if the port number is inva

Re: [dpdk-dev] [PATCH 2/2] net/bonding: avoid the next active slave going out of bound

2019-02-09 Thread Chas Williams
On 1/10/19 5:22 AM, Hyong Youb Kim wrote: For bonding modes like broadcast that use bond_ethdev_rx_burst(), it is fairly easy to produce a crash simply by bringing a slave port's link down. When slave links go down, the driver on one thread reduces active_slave_count via the LSC callback and d