Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Thomas Monjalon
26/01/2019 00:37, Ferruh Yigit: > On 1/25/2019 9:16 PM, Aaron Conole wrote: > > Jay Rolette writes: > > > >>>* Questions from Intel Test about the use of the Stable Tree. > >>> Do people use it? Each stable/LTS release requires a lot of > >>> testing and there are currently 3 releas

Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Ferruh Yigit
On 1/25/2019 9:16 PM, Aaron Conole wrote: > Jay Rolette writes: > >>>* Questions from Intel Test about the use of the Stable Tree. >>> Do people use it? Each stable/LTS release requires a lot of >>> testing and there are currently 3 releases to be tested. >> >> We do @ infinite io.

Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Aaron Conole
Jay Rolette writes: >>* Questions from Intel Test about the use of the Stable Tree. >> Do people use it? Each stable/LTS release requires a lot of >> testing and there are currently 3 releases to be tested. > > We do @ infinite io. +1. Red Hat also uses the LTS releases. I'm curi

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2019-01-25 Thread Andriy Berestovskyy
Sure, Ferruh. Just let me know how can I help you. Andriy > On 23 Jan 2019, at 19:36, Ferruh Yigit wrote: > >> On 5/24/2018 10:20 AM, Andriy Berestovskyy wrote: >> Hi Shahaf, >> >>> On 23 May 2018, at 07:21, Shahaf Shuler wrote: >>> I think this patch addressing just small issue in a bigger p

Re: [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir

2019-01-25 Thread Bruce Richardson
On Fri, Jan 25, 2019 at 08:26:38PM +, Bruce Richardson wrote: > The apps for testing are split between the "test" and "app" directories, > with a not-very-clear distinction between the two (at least to my mind). > > Given how the apps are being built, the easiest path to having > cmdline_test,

[dpdk-dev] [PATCH 3/4] test/test-pipeline: move to app directory

2019-01-25 Thread Bruce Richardson
Move to the app directory, and add to meson build. Signed-off-by: Bruce Richardson --- app/Makefile| 1 + app/meson.build | 1 + {test => app}/test-pipeline/Makefile| 0 {test => app}/test-pipeline/config.c

[dpdk-dev] [PATCH 4/4] test/bpf: move to examples folder

2019-01-25 Thread Bruce Richardson
The bpf folder didn't actual contain a test application, but instead basic examples of BPF code for use with testpmd. Therefore we can move it to the `examples` folder. Being different, it also needs a README with it, explaining what it is and how to use it. References to the code from the testpmd

[dpdk-dev] [PATCH 1/4] test/cmdline_test: move to app directory

2019-01-25 Thread Bruce Richardson
Move app to "app" directory and enable with meson build. Signed-off-by: Bruce Richardson --- app/Makefile| 1 + {test => app}/cmdline_test/Makefile | 0 {test => app}/cmdline_test/cmdline_test.c | 0 {test => app}/cmdline_test/cmdline_test.h

[dpdk-dev] [PATCH 2/4] test/test-acl: move to app directory

2019-01-25 Thread Bruce Richardson
Move to "app" directory and enable with meson build. Signed-off-by: Bruce Richardson --- app/Makefile| 1 + app/meson.build | 1 + {test => app}/test-acl/Makefile | 0 {test => app}/test-acl/main.c | 0 app/test-acl/meson.build| 5 + test/Makefil

[dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir

2019-01-25 Thread Bruce Richardson
The apps for testing are split between the "test" and "app" directories, with a not-very-clear distinction between the two (at least to my mind). Given how the apps are being built, the easiest path to having cmdline_test, test-acl and test-pipeline build using meson is to consolidate all these ap

Re: [dpdk-dev] [PATCH v3 0/5] Add non-blocking ring

2019-01-25 Thread Eads, Gage
> -Original Message- > From: Eads, Gage > Sent: Friday, January 25, 2019 11:43 AM > To: 'Honnappa Nagarahalli' ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; step...@networkplumber.org; nd > ; tho...@monjalon.net; Ola

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for meson version

2019-01-25 Thread Van Haaren, Harry
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, January 16, 2019 11:37 AM > To: dev@dpdk.org > Cc: bl...@debian.org; tredae...@redhat.com; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH] doc: add deprecation notice for meson

Re: [dpdk-dev] [PATCH v3 0/5] Add non-blocking ring

2019-01-25 Thread Eads, Gage
Hi Honnappa, Works for me -- I'm in favor of the best performing implementation, whoever provides it. To allow an apples-to-apples comparison, I suggest Ola's/ARM's implementation be made to fit into the rte_ring API with an associated mempool handler. That'll allow us to use the existing ring

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-25 Thread Eads, Gage
> -Original Message- > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Wednesday, January 23, 2019 4:16 AM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; step...@networkplumber.org; nd > ; Richardson, Bruce ; > arybche...@solarflare.com; Ananyev, Konstantin > >

Re: [dpdk-dev] [PATCH v3 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-25 Thread Eads, Gage
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, January 23, 2019 11:22 PM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; nd ; > chao...@linux

Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Thomas Monjalon
25/01/2019 17:53, Jay Rolette: > Hi Thomas, > > On Fri, Jan 25, 2019 at 10:40 AM Thomas Monjalon > wrote: > > > Hi Jay, > > > > 25/01/2019 14:42, Jay Rolette: > > > >* Questions from Intel Test about the use of the Stable Tree. > > > > Do people use it? Each stable/LTS release requires

Re: [dpdk-dev] [PATCH] crypto/qat: fix digest issue in wireless auth case

2019-01-25 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Trahe, Fiona > Sent: Friday, January 25, 2019 5:59 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > akhil.go...@nxp.com; Kusztal, ArkadiuszX ; > sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix digest issue in wireless

[dpdk-dev] [PATCH] crypto/qat: fix digest issue in wireless auth case

2019-01-25 Thread Fiona Trahe
When operation calls for auth (digest generation), followed by encryption of both data plus digest, the digest-in-buffer flag must be set for QAT. Fixes: 39e0bee48e81 ("crypto/qat: rework request builder for performance") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat

Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Jay Rolette
Hi Thomas, On Fri, Jan 25, 2019 at 10:40 AM Thomas Monjalon wrote: > Hi Jay, > > 25/01/2019 14:42, Jay Rolette: > > >* Questions from Intel Test about the use of the Stable Tree. > > > Do people use it? Each stable/LTS release requires a lot of > > > testing and there are currently

Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Thomas Monjalon
Hi Jay, 25/01/2019 14:42, Jay Rolette: > >* Questions from Intel Test about the use of the Stable Tree. > > Do people use it? Each stable/LTS release requires a lot of > > testing and there are currently 3 releases to be tested. > > We do @ infinite io. Would you be OK to share you

Re: [dpdk-dev] [PATCH 0/3] net/virtio: missing/wrong read barriers.

2019-01-25 Thread Maxime Coquelin
Hi Ilya, On 1/24/19 5:58 PM, Ilya Maximets wrote: Ilya Maximets (3): net/virtio: fix improper read barriers on packed Tx cleanup net/virtio: add barriers for extra descriptors on Rx split net/virtio: add missing read barrier for packed dequeue drivers/net/virtio/virtio_rxtx.c | 6 +++

[dpdk-dev] [PATCH] net/mlx5: fix VXLAN missing decap action Flows for E-Switch

2019-01-25 Thread Viacheslav Ovsiienko
There is an intention to support VXLAN tunnel match without hardware offloaded decapsulation, just to redirect ingress tunnelled frame untouched. This small fix allows to specify Flows with VXLAN VNI pattern and with or without following decapsulation action. Fixes: 251e8d02cf37 ("net/mlx5: add VX

[dpdk-dev] [PATCH] net/mlx5: fix ETH and VLAN items for E-Switch flows

2019-01-25 Thread Viacheslav Ovsiienko
This patch fixes two issues for E-Switch Flows - RTE_FLOW_ITEM_TYPE_ETH and RTE_FLOW_ITEM_TYPE_VLAN with NULL in spec field caused the asserts in debug version and segfault in release, fixed, now empty items are allowed and treated in correctl way - empty RTE_FLOW_ITEM_TYPE_VLAN now sets the ethe

Re: [dpdk-dev] [PATCH] test: test zero socket-mem as valid

2019-01-25 Thread Burakov, Anatoly
On 25-Jan-19 2:00 PM, Ilya Maximets wrote: On 25.01.2019 16:48, Burakov, Anatoly wrote: On 25-Jan-19 9:53 AM, David Marchand wrote: On Fri, Jan 25, 2019 at 9:06 AM Ilya Maximets mailto:i.maxim...@samsung.com>> wrote:     On 25.01.2019 10:55, Ilya Maximets wrote: > Dynamic memory mode

Re: [dpdk-dev] [PATCH] test: test zero socket-mem as valid

2019-01-25 Thread Ilya Maximets
On 25.01.2019 16:48, Burakov, Anatoly wrote: > On 25-Jan-19 9:53 AM, David Marchand wrote: >> >> >> On Fri, Jan 25, 2019 at 9:06 AM Ilya Maximets > > wrote: >> >>     On 25.01.2019 10:55, Ilya Maximets wrote: >> > Dynamic memory mode allowes zero socket-mem becau

Re: [dpdk-dev] [PATCH] test: test zero socket-mem as valid

2019-01-25 Thread Burakov, Anatoly
On 25-Jan-19 9:53 AM, David Marchand wrote: On Fri, Jan 25, 2019 at 9:06 AM Ilya Maximets > wrote: On 25.01.2019 10:55, Ilya Maximets wrote: > Dynamic memory mode allowes zero socket-mem because all the > required memory could be allocated on deman

Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Jay Rolette
>* Questions from Intel Test about the use of the Stable Tree. > Do people use it? Each stable/LTS release requires a lot of > testing and there are currently 3 releases to be tested. We do @ infinite io. Jay On Fri, Jan 25, 2019 at 3:24 AM Mcnamara, John wrote: > Release Status

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: log port ID as 16-bit unsigned integer

2019-01-25 Thread Ferruh Yigit
On 1/24/2019 3:20 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix improper read barriers on packed Tx cleanup

2019-01-25 Thread Jens Freimann
On Thu, Jan 24, 2019 at 07:59:00PM +0300, Ilya Maximets wrote: Read barrier must be implied between reading descriptor flags and descriptor id. Otherwise, in case of reordering, we could read wrong descriptor id. For the reference, similar barrier for split rings is the read barrier between VIRT

Re: [dpdk-dev] [PATCH 3/3] net/virtio: add missing read barrier for packed dequeue

2019-01-25 Thread Jens Freimann
On Thu, Jan 24, 2019 at 07:59:02PM +0300, Ilya Maximets wrote: Read barrier is required between reading the flags (desc_is_used) and the content of descriptor to ensure the ordering. Otherwise, speculative read of desc.id could be reordered with reading of the desc.flags. Fixes: a76290c8f1cf ("n

Re: [dpdk-dev] [PATCH 3/3] net/virtio: add missing read barrier for packed dequeue

2019-01-25 Thread Jens Freimann
On Thu, Jan 24, 2019 at 07:59:02PM +0300, Ilya Maximets wrote: Read barrier is required between reading the flags (desc_is_used) and the content of descriptor to ensure the ordering. Otherwise, speculative read of desc.id could be reordered with reading of the desc.flags. Fixes: a76290c8f1cf ("n

Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix improper read barriers on packed Tx cleanup

2019-01-25 Thread Jens Freimann
On Thu, Jan 24, 2019 at 07:59:00PM +0300, Ilya Maximets wrote: Read barrier must be implied between reading descriptor flags and descriptor id. Otherwise, in case of reordering, we could read wrong descriptor id. For the reference, similar barrier for split rings is the read barrier between VIRT

Re: [dpdk-dev] [PATCH] test: test zero socket-mem as valid

2019-01-25 Thread David Marchand
On Fri, Jan 25, 2019 at 9:06 AM Ilya Maximets wrote: > On 25.01.2019 10:55, Ilya Maximets wrote: > > Dynamic memory mode allowes zero socket-mem because all the > > required memory could be allocated on demand. > > > > Fixes: 339c2244b4f1 ("eal: fix parsing zero socket memory and limits") > > Cc:

[dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-25 Thread Mcnamara, John
Release Status Meeting 24/01/2018 28 June 2018 09:32 Agenda -- * Subtrees * Bugzilla * Dates Subtrees * Next-Net * There are no critical/blocking issues. There is only a bunch of patches merged, again nothing critical. Pulled from sub-trees. I

[dpdk-dev] [PATCH v3 0/2] ticketlock: implement ticketlock and add test case

2019-01-25 Thread Joyce Kong
V3: 1.Update ticketlock intrduction(suggested by Honnappa Nagarahalli). 2.Change the implementation of rte_ticketlock_trylock to CAS(suggested by Honnappa Nagarahalli). V2: 1.Update commit message(suggested by Jerin Jacob). 2.Add ticketlock test cases(suggested by Jeri

[dpdk-dev] [PATCH v3 2/2] test/ticketlock: add ticket lock test case

2019-01-25 Thread Joyce Kong
Add test cases for ticket lock, recursive ticket lock, and ticket lock performance. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- MAINTAINERS | 1 + test/test/Makefile | 1 + test/test/autotest_data.py | 6 + test/test/meson.build

[dpdk-dev] [PATCH v3 1/2] ticketlock: ticket based to improve fairness

2019-01-25 Thread Joyce Kong
The spinlock implementation is unfair, some threads may take locks aggressively while leaving the other threads starving for long time. This patch introduces ticketlock which gives each waiting thread a ticket and they can take the lock one by one. First come, first serviced. This avoids starvatio

[dpdk-dev] [PATCH 3/5] net/ena: fix setting rte_errno to negative value

2019-01-25 Thread Michal Krawczyk
The rte_errno shouldn't have assigned negative error codes, so it has to be fixed. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH 4/5] doc: update release notes for ENA PMD

2019-01-25 Thread Michal Krawczyk
From: Rafal Kozik Add changes in ENA PMD to DPDK v19.02 release notes. Signed-off-by: Michal Krawczyk Signed-off-by: Rafal Kozik --- doc/guides/rel_notes/release_19_02.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/gu

[dpdk-dev] [PATCH 5/5] doc: add instructions for enabling WC in ENAv2 PMD

2019-01-25 Thread Michal Krawczyk
From: Rafal Kozik ENAv2 hardware provides Low Latency Queue v2 (LLQv2). It needs kernel PCI driver to support write combining (WC). This patch add information how to use it with igb_uio and vfio-pci drivers. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- doc/guides/nics/ena.rst | 16

[dpdk-dev] [PATCH 0/5] net/ena: minor fixes and docs update

2019-01-25 Thread Michal Krawczyk
Hi, we would like to push fixes for part of the bugs reported in Bug 193, together with docs update for ENAv2 about enabling WC support, release notes and fix for assigning rte_errno negative values, as requested by the community. Michal Krawczyk (3): net/ena: remove lcore constraint from max q

[dpdk-dev] [PATCH 1/5] net/ena: remove lcore constraint from max queue number

2019-01-25 Thread Michal Krawczyk
The number of queues was limited by number of lcores in the recent ENAv2 patch. However, some apps like symmetric_mp, are configuring multiple queues although there is only single lcore used. To prevent failure in that case, the lcore number constraint was removed. Fixes: ea93d37eb49d ("net/ena:

[dpdk-dev] [PATCH 2/5] net/ena: fix dev init for RTE_PROC_SECONDARY

2019-01-25 Thread Michal Krawczyk
The check for proc type in eth_ena_dev_init() should appear before modyfing adapter structure. Calling memset on ena_adapter from secondary process context, was erasing all structure information, and it was causing the crash of the main process. Fixes: 1173fca25af9 ("ena: add polling-mode driver"

Re: [dpdk-dev] [PATCH] test: test zero socket-mem as valid

2019-01-25 Thread Ilya Maximets
On 25.01.2019 10:55, Ilya Maximets wrote: > Dynamic memory mode allowes zero socket-mem because all the > required memory could be allocated on demand. > > Fixes: 339c2244b4f1 ("eal: fix parsing zero socket memory and limits") > Cc: sta...@dpdk.org > Reported-by: Shuai Zhu > Signed-off-by: Ily