Re: [dpdk-dev] [PATCH] net/mlx4: fix creation of flow rule w/o ETH spec

2019-01-20 Thread Shahaf Shuler
Thursday, January 17, 2019 2:12 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx4: fix creation of flow rule w/o ETH spec > > The original commit enabled the creation of flow rule with empty ETH > address and with specific VLAN. > It works fine on PF, but such flow rule is still rejected on

Re: [dpdk-dev] [PATCH v3] gso: fix VxLAN/GRE tunnel checks

2019-01-20 Thread Hu, Jiayu
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Monday, January 21, 2019 2:43 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v3] gso: fix VxLAN/GRE tunnel checks > > Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits. > A

[dpdk-dev] [PATCH v3] gso: fix VxLAN/GRE tunnel checks

2019-01-20 Thread Andrew Rybchenko
Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits. As the result, for example, IPIP or MPLSinUDP tunnel packets may be incorrectly treated internally as VXLAN. Fixes: b058d92ea95d ("gso: support VxLAN GSO") Fixes: 70e737e448c7 ("gso: support GRE GSO") Cc: sta...@dpdk.org Signed-off-by: Andrew Ryb

Re: [dpdk-dev] [PATCH v2] gso: fix VxLAN/GRE tunnel checks

2019-01-20 Thread Hu, Jiayu
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Monday, January 21, 2019 2:28 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] gso: fix VxLAN/GRE tunnel checks > > Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits. > A

[dpdk-dev] [PATCH v2] gso: fix VxLAN/GRE tunnel checks

2019-01-20 Thread Andrew Rybchenko
Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits. As the result, for example, IPIP or MPLSinUDP tunnel packets may be incorrected treated internally as VXLAN. Fixes: b058d92ea95d ("gso: support VxLAN GSO") Fixes: 70e737e448c7 ("gso: support GRE GSO") Cc: sta...@dpdk.org Signed-off-by: Andrew Ryb

[dpdk-dev] [Bug 194] vhost pmd has become unusable from secondary processes.

2019-01-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=194 Bug ID: 194 Summary: vhost pmd has become unusable from secondary processes. Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED

[dpdk-dev] [PATCH v5 1/2] doc: add svg for debug and troubleshoot guide

2019-01-20 Thread Vipin Varghese
Add svg for debug and troubleshoot guide for single or multi stage applications. Signed-off-by: Vipin Varghese Acked-by: Marko Kovacevic --- doc/guides/howto/img/dtg_consumer_ring.svg| 19 doc/guides/howto/img/dtg_crypto.svg | 16 +++ .../howto/img/dtg_distributor_worker.sv

[dpdk-dev] [PATCH v5 2/2] doc: add guide for debug and troubleshoot

2019-01-20 Thread Vipin Varghese
Add user guide on debug and troubleshoot for common issues and bottleneck found in sample application model. Signed-off-by: Vipin Varghese Acked-by: Marko Kovacevic --- doc/guides/howto/debug_troubleshoot_guide.rst | 375 ++ doc/guides/howto/index.rst| 1 +

[dpdk-dev] [PATCH v5 0/2] doc/howto: add debug and troubleshoot guide

2019-01-20 Thread Vipin Varghese
This patch series is an attempt to add how to guide for commonly seen issues in various application scenario. It also tries to suggest a step by step guide on how to debug and troubleshoot with available stats and counters. Motivation == DPDK allows to build application on top of custom of

Re: [dpdk-dev] [PATCH v4 2/2] doc: add guide for debug and troubleshoot

2019-01-20 Thread Varghese, Vipin
Thanks Marko, I will spin v5 with the changes asap. Note: Just wondering why 'devtools/checkpatches.sh' did not report any error. Thanks Vipin Varghese > -Original Message- > From: Kovacevic, Marko > Sent: Friday, January 18, 2019 8:59 PM > To: Varghese, Vipin ; dev@dpdk.org; > shreyansh

[dpdk-dev] [dpdk-announce] release candidate 19.02-rc3

2019-01-20 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.02-rc3 The release notes are almost complete: http://doc.dpdk.org/guides/rel_notes/release_19_02.html There are some open bugs to check in bugzilla: https://dpdk.org/tracker/buglist.c

Re: [dpdk-dev] MLX5: Array written to out-of-bounds when freeing memory

2019-01-20 Thread Daniel Pharos
Hi Yongseok, Thanks for the quick response! If there is any information you need that I may be able to provide, please just ask. Kind regards, DanielPharos -Original Message- From: Yongseok Koh Sent: 19 January 2019 08:15 To: Daniel Pharos Cc: dev@dpdk.org; Dekel Peled ; Olga Shern

Re: [dpdk-dev] [PATCH v2] test/metrics: Fixed a negative case to pass

2019-01-20 Thread Thomas Monjalon
10/12/2018 09:39, Harman Kalra: > Negative test case for passing invalid count size to > rte_metrics_update_values() will pass if count value > is any value greater than 1 because set size wrt to > key id 1 is 1 and passing 0 as no of values to be > updated will not hit the ERANGE check. > > Signe

Re: [dpdk-dev] [PATCH v3] test: reduce test duration for efd autotest

2019-01-20 Thread Thomas Monjalon
Any review please? 29/11/2018 08:36, Jananee Parthasarathy: > Reduced test time for efd_autotest. > Key length is updated, invoke times of random function is reduced. > Different value is updated for each hash key entry. > > Signed-off-by: Jananee Parthasarathy > --- > v3: reverted the simple_ke

Re: [dpdk-dev] [PATCH] doc: update description in qat compression guide

2019-01-20 Thread Thomas Monjalon
> > Added limitations description for the QAT compression PMD. > > Updated intermediate buffers description in qat.rst file. > > > > Signed-off-by: Tomasz Jozwiak > Acked-by: Fiona Trahe Applied, thanks

[dpdk-dev] [PATCH] doc: add missing package dependency in contributors guide

2019-01-20 Thread Rami Rosen
There is a missing depenency for building docs with "make doc-guides-pdf". This causes it to break with "make[3]: latexmk: Command not found". This was observed and reproted in https://bugs.dpdk.org/show_bug.cgi?id=182 This patch fixes this issue by adding the latexmk package dependency in sub-se

Re: [dpdk-dev] [PATCH] doc/qat: add GCM AAD limitation

2019-01-20 Thread Thomas Monjalon
> > Add limitation that AAD buffer must be padded with zeroes in GCM case. > > > > Fixes: d4f44265a1d7 ("doc: add limitation of AAD size to QAT guide") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Fiona Trahe > > Acked-by: Arek Kusztal Applied, thanks

Re: [dpdk-dev] [PATCH 1/2] doc/power: library can now use intel-pstate

2019-01-20 Thread Thomas Monjalon
15/01/2019 15:17, David Hunt: > With the addition of the patchset to allow auto-detection and use > of the intel_pstate kernel driver instead of the acpi-cpufreq kernel > driver, we need to reflect this in the documentation. > > Now, instead of telling the user to disable intel_pstate in all cases

Re: [dpdk-dev] [PATCH] gso: fix VxLAN/GRE tunnel checks

2019-01-20 Thread Hu, Jiayu
Yes, this is a bug. Thanks for catching it. But the commit log doesn’t tell what issue the patch fixes. Can you add it in the commit log? Thanks, Jiayu From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Sunday, January 20, 2019 5:59 PM To: Hu, Jiayu Cc: dev@dpdk.org; sta...@dpdk.org

Re: [dpdk-dev] [PATCH v2] doc: fix references in power management guide

2019-01-20 Thread Thomas Monjalon
18/01/2019 10:34, David Hunt: > In the References section in the Power Management overview, > both links pointed to the same l3fwd-power app. Fix the links > so that one points to l3fwd-power, and the other points to > the vm_power_manager sample app. > > Signed-off-by: David Hunt > Acked-by: Mar

Re: [dpdk-dev] [PATCH] doc/gsg: update recommended NIC bios settings

2019-01-20 Thread Thomas Monjalon
17/01/2019 12:46, Kovacevic, Marko: > Acked-by: Marko Kovacevic Applied, thanks Note: Such doc should be out of Linux guide if they apply also to BSD and Windows.

Re: [dpdk-dev] [PATCH v2] doc: remove file listings

2019-01-20 Thread Thomas Monjalon
18/01/2019 16:35, Kovacevic, Marko: > Acked-by: Marko Kovacevic Applied, thanks Marko, please keep previous SoB and acks so we have a bit of history in replies. Usually we also the keep the commit description in acks.

Re: [dpdk-dev] [PATCH] doc: increase minimal supported Linux version

2019-01-20 Thread Thomas Monjalon
16/01/2019 19:56, Stephen Hemminger: > On Wed, 16 Jan 2019 12:45:35 +0100 > Thomas Monjalon wrote: > > > Update the Linux user guide to restrict the supported kernels > > to reasonnably recent enough versions. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Stephen Hemminger Applied

Re: [dpdk-dev] [PATCH] doc: add meson ut enhancements in prog guide

2019-01-20 Thread Thomas Monjalon
12/12/2018 12:35, Hari Kumar Vemula: > --- /dev/null > +++ b/doc/guides/prog_guide/meson_ut_enhancements.rst > @@ -0,0 +1,158 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +Copyright(c) 2014-2018 Intel Corporation. > + > +.. _Meson_UT_Enhancements: No need to add such anchor. The doc can b

Re: [dpdk-dev] [PATCH] gso: fix VxLAN/GRE tunnel checks

2019-01-20 Thread Andrew Rybchenko
On 1/19/19 4:31 PM, Hu, Jiayu wrote: Hi Andrew, Would you please give more explanation about the problem that the patch wants to fix? Let's consider if tunnel is IPIP (0x3ULL << 45) or MPLSINUDP (0x5ULL << 45). If so flags & VXLAN (0x1ULL << 45), still makes (0x1ULL << 45)==VXLAN, but it is no