Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-12-18 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, December 19, 2018 11:37 AM > To: dev@dpdk.org > Cc: Erik Gabriel Carrillo ; rsanf...@akamai.com; > olivier.m...@6wind.com; step...@networkplumber.org; > bruce.richard...@intel.com > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH] eal: close MP socket during cleanup

2018-12-18 Thread Qi Zhang
When secondary process quit, the mp_socket* file still exist, that cause rte_mp_request_sync fail when try to send message on a floating socket. The patch fix the issue by introduce a function rte_mp_channel_fini. This function will be called by rte_eal_cleanup and it will close the mp socket and

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2018-12-18 Thread Mattias Rönnblom
On 2018-12-19 04:35, Thomas Monjalon wrote: 13/12/2018 23:26, Erik Gabriel Carrillo: This patch series modifies the timer library in such a way that structures that used to be statically allocated in a process's data segment are now allocated in shared memory. As these structures contain lists

Re: [dpdk-dev] [PATCH v2]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga

2018-12-18 Thread Xu, Rosen
Hi Andy, > -Original Message- > From: Pei, Andy > Sent: Wednesday, December 19, 2018 3:35 > To: dev@dpdk.org > Cc: Xu, Rosen ; Zhang, Tianfei > ; Pei, Andy > Subject: [PATCH v2]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga > > When ifpga_rawdev_create() allocate memory for a n

[dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8

2018-12-18 Thread Xiao Liang
'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8. Build error log: /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean ‘ndo_change_mtu’? #define ndo_change_mtu ndo_change_mtu_rh74

[dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8

2018-12-18 Thread Xiao Liang
'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8. Build error log: /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean ‘ndo_change_mtu’? #define ndo_change_mtu ndo_change_mtu_rh74

Re: [dpdk-dev] Eventdev DSW and eth_rx_adapters

2018-12-18 Thread Mattias Rönnblom
On 2018-12-18 02:46, Venky Venkatesh wrote: Hi, I am relatively new to DPDK and am trying to use the eventdev library. The sw_evdev runs on a single core (service core). And then there is rte_event_eth_rx_adapter_ which links the sw_evdev to the ethdev. This adapter is also service core based.

Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking

2018-12-18 Thread Honnappa Nagarahalli
> > This patch targets 19.02 release. > > Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). > Signed-off-by: Konstantin Ananyev > --- > .../common/include/generic/rte_rwlock.h | 54 +++ > lib/librte_eal/rte_eal_version.map| 2 + > 2 files cha

[dpdk-dev] [PATCH v1 2/3] ethdev: advertise default MAC as retained on device restart

2018-12-18 Thread Andrew Rybchenko
The documentation says MAC addresses array is retained and it is logical to assume that default MAC address is retained as well. Also some PMDs do not allow to change the default MAC in running state (see RTE_ETH_DEV_NOLIVE_MAC_ADDR). Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_et

[dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

2018-12-18 Thread Andrew Rybchenko
The patch series tries to improve documentation of what is retained across default restart. Andrew Rybchenko (3): ethdev: advertise MTU as retained across device stop/start ethdev: advertise default MAC as retained on device restart ethdev: highlight that all-multicast is retained on restart

[dpdk-dev] [PATCH v1 3/3] ethdev: highlight that all-multicast is retained on restart

2018-12-18 Thread Andrew Rybchenko
All-multicast is a part of receive mode configuration and it is better to mention explicitly that it is retained across restart. Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev

[dpdk-dev] [PATCH v1 1/3] ethdev: advertise MTU as retained across device stop/start

2018-12-18 Thread Andrew Rybchenko
Changing MTU in running state may return -EBUSY saying that MTU cannot be changed when the port is running. It assumes that changes may be done in stopped and started (but some PMDs may reject it) state and it is logical to require that changes done in any of these states are retained. Signed-off-

[dpdk-dev] [PATCH] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8

2018-12-18 Thread Xiao Liang
'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8. Build error log: /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean ‘ndo_change_mtu’? #define ndo_change_mtu ndo_change_mtu_rh74

[dpdk-dev] [PATCH] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8

2018-12-18 Thread Xiao Liang
'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8. Build error log: /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean ‘ndo_change_mtu’? #define ndo_change_mtu ndo_change_mtu_rh74

[dpdk-dev] [PATCH v8 0/3] Support request more queues

2018-12-18 Thread Zhirun Yan
v8 - fix code style and compilation issues. DPDK VF send VIRTCHNL_OP_REQUEST_QUEUES to kernel PF or DPDK VF for requesting more queues, then PF will allocate more queues. Zhirun Yan (3): net/i40e: support VF request more queues net/i40e: support PF respond VF request more queues doc: update

[dpdk-dev] [PATCH v8 2/3] net/i40e: support PF respond VF request more queues

2018-12-18 Thread Zhirun Yan
This patch respond the VIRTCHNL_OP_REQUEST_QUEUES msg from VF, and process to allocated more queues for the requested VF. If successful, PF will notify VF to reset. If unsuccessful, PF will send message to inform VF. Signed-off-by: Zhirun Yan Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e

[dpdk-dev] [PATCH v8 3/3] doc: update queue number per vf for i40e

2018-12-18 Thread Zhirun Yan
Updated the doc and release notes on the support for requesting more queues. Signed-off-by: Zhirun Yan --- doc/guides/nics/i40e.rst | 16 +--- doc/guides/rel_notes/release_19_02.rst | 8 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/doc/guide

[dpdk-dev] [PATCH v8 1/3] net/i40e: support VF request more queues

2018-12-18 Thread Zhirun Yan
Before this patch, VF gets a default number of queues from the PF. This patch enables VF to request a different number. When VF configures more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request more queues, if success, PF will reset the VF. User can run "port stop all", "port config

Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-12-18 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona >Sent: 18 December 2018 20:13 >To: Stephen Hemminger >Cc: dev@dpdk.org; akhil.go...@nxp.com; Jozwiak, TomaszX >; Verma, Shally >; Gupta, Ashish ; Daly, Lee >; Luse, Paul E >; Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH] compressdev: add featu

[dpdk-dev] [PATCH v7 1/3] net/i40e: support VF request more queues

2018-12-18 Thread Zhirun Yan
Before this patch, VF gets a default number of queues from the PF. This patch enables VF to request a different number. When VF configures more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request more queues, if success, PF will reset the VF. User can run "port stop all", "port config

[dpdk-dev] [PATCH v7 3/3] doc: update queue number per vf for i40e

2018-12-18 Thread Zhirun Yan
Updated the doc and release notes on the support for requesting more queues. Signed-off-by: Zhirun Yan --- doc/guides/nics/i40e.rst | 16 +--- doc/guides/rel_notes/release_19_02.rst | 8 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/doc/guide

[dpdk-dev] [PATCH v7 2/3] net/i40e: support PF respond VF request more queues

2018-12-18 Thread Zhirun Yan
This patch respond the VIRTCHNL_OP_REQUEST_QUEUES msg from VF, and process to allocated more queues for the requested VF. If successful, PF will notify VF to reset. If unsuccessful, PF will send message to inform VF. Signed-off-by: Zhirun Yan Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e

[dpdk-dev] [PATCH v7 0/3] Support request more queues

2018-12-18 Thread Zhirun Yan
V7 - fix comment format - fix commit msg warning due to exceed 75 chars - modify doc to specify for i40e DPDK VF send VIRTCHNL_OP_REQUEST_QUEUES to kernel PF or DPDK VF for requesting more queues, then PF will allocate more queues. Zhirun Yan (3): net/i40e: support VF request more queues net/

Re: [dpdk-dev] [PATCH v1] config: enable c11 memory model for ARMv8 meson

2018-12-18 Thread Honnappa Nagarahalli
> > > > I see no issues with this, it's just setting flags for arm platforms. > > > > Acked-by: Bruce Richardson > > Applied, thanks. > > Note: according to the wording explained by Honnappa, I change ARMv8 to > armv8 in the title. > Please apply the official spelling in your updates, thanks. >

[dpdk-dev] [PATCH] net/vhost: fix double free of MAC addrs

2018-12-18 Thread Hideyuki Yamashita
The common data freeing has been moved to rte_eth_dev_release_port(), so freeing mac_addrs like this in eth_dev_close() is unnecessary and will cause double free. Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") Cc: sta...@dpdk.org Signed-off-by: Hideyuki Yamashita Signed

Re: [dpdk-dev] [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes

2018-12-18 Thread Thomas Monjalon
28/11/2018 11:15, Luca Boccassi: > On Mon, 2018-11-26 at 23:56 -0500, Chas Williams wrote: > > From: Chas Williams > > > > The same issue was fixed on for the ipv4 version of this routine in > > commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8 > > bytes"). > > Briefly, the size of

Re: [dpdk-dev] [PATCH v4 10/10] doc: add IPsec library guide

2018-12-18 Thread Thomas Monjalon
Hi, 14/12/2018 17:27, Konstantin Ananyev: > Add IPsec library guide and update release notes. A quick look at the guide hint me that you should check the spelling. > --- a/doc/guides/rel_notes/release_19_02.rst > +++ b/doc/guides/rel_notes/release_19_02.rst > @@ -60,6 +60,16 @@ New Features > +*

[dpdk-dev] Cavium OCTEON TX timvf - compile error on ARM CentOS 7.4

2018-12-18 Thread Yongseok Koh
Hi, I encountered the following build error on Mellanox BlueField ARMv8 CPU (Cortex-A72). It is CentOS 7.4 $ cat /etc/redhat-release CentOS Linux release 7.4.1708 (AltArch) And gcc is 4.8.5 $ gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) FYI, $ uname -a Linux dragon61-bf 4.11.0-22.

Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-12-18 Thread Thomas Monjalon
Who could review this fix please? 29/11/2018 19:53, Erik Gabriel Carrillo: > rte_timer_manage() adds expired timers to a "run list", and walks the > list, transitioning each timer from the PENDING to the RUNNING state. > If another lcore resets or stops the timer at precisely this > moment, the ti

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2018-12-18 Thread Thomas Monjalon
13/12/2018 23:26, Erik Gabriel Carrillo: > This patch series modifies the timer library in such a way that > structures that used to be statically allocated in a process's data > segment are now allocated in shared memory. As these structures contain > lists of timers, new APIs are introduced that

Re: [dpdk-dev] [dpdk-stable] [PATCH] gro: fix overflow of payload length calculation

2018-12-18 Thread Thomas Monjalon
17/12/2018 07:05, Jiayu Hu: > When the packet length is smaller than the header length, > the calculated payload length will be overflowed and result > in incorrect reassembly behaviors. > > Fixes: 1e4cf4d6d4fb ("gro: cleanup") > Fixes: 9e0b9d2ec0f4 ("gro: support VxLAN GRO") > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v6 00/31] A new net PMD - ICE

2018-12-18 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, December 18, 2018 9:53 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 00/31] A new net PMD - ICE > > On 12/18/2018 8:46 AM, Wenzhuo Lu wrote: > > This patch

Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility

2018-12-18 Thread Thomas Monjalon
14/12/2018 14:11, Liang Ma: > Previously, in order to use the power library, it was necessary > for the user to disable the intel_pstate driver by adding > “intel_pstate=disable” to the kernel command line for the system, > which causes the acpi_cpufreq driver to be loaded in its place. > > This p

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-12-18 Thread Thomas Monjalon
13/11/2018 16:54, Anatoly Burakov: > When creating process data structures, EAL will create many files > in EAL runtime directory. Because we allow multiple secondary > processes to run, each secondary process gets their own unique > file. With many secondary processes running and exiting on the >

Re: [dpdk-dev] [PATCH 0/2] Add 'try' semantics for RD and WR locking

2018-12-18 Thread Thomas Monjalon
13/11/2018 18:27, Konstantin Ananyev: > This series targets 19.02 release > > Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock() > and new UT test-case for it. > > Konstantin Ananyev (2): > rwlock: introduce 'try' semantics for RD and WR locking > test: add new test-cases for

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-12-18 Thread Thomas Monjalon
Hi Stephen, Can we expect a v2 of this patch? At least for removing deprecation and bump ethdev version, etc? 05/09/2018 18:41, Stephen Hemminger: > This addresses the usability issue raised by OVS at DPDK Userspace > summit. It adds general min/max mtu into device info. For compatiablity, > and

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix garbage text in generated HTML guides

2018-12-18 Thread Thomas Monjalon
05/12/2018 15:25, Luca Boccassi: > If the user has MAKEFLAGS set in the environment when building the > documentation, the doc/guides/conf.py script which calls "make" > exclusively to get the project version might pick up garbage from > stdout, like: > > FAQ — Data Plane Development Kit make[2]:

Re: [dpdk-dev] [PATCH] bus/vdev: add warning for duplicated vdev name

2018-12-18 Thread Thomas Monjalon
29/11/2018 08:16, Yahui Cao: > If duplicated vdev name is detected, print out a warning message. > > Signed-off-by: Yahui Cao > --- > drivers/bus/vdev/vdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index 9c66bdc78..ff2db7d3f

Re: [dpdk-dev] [PATCH] bus/dpaa: do nothing if bus not present

2018-12-18 Thread Thomas Monjalon
07/12/2018 07:45, Shreyansh Jain: > On Thursday 06 December 2018 03:32 AM, Stephen Hemminger wrote: > > The DPAA bus support code put out messages like: > > dpaax: read_memory_node(): Unable to glob device-tree memory > > node: (/proc/device-tree/memory[@0-9]*/reg)(3) > > dpaax: PA->

Re: [dpdk-dev] [PATCH v2 1/4] bus/vmbus: fix race in sub channel creation

2018-12-18 Thread Thomas Monjalon
05/12/2018 23:11, Stephen Hemminger: > When using multiple queues, there was a race with the kernel > in setting up the second channel. This regression is due to a kernel change > which does not allow accessing sysfs files for Hyper-V channels that are not > opened. > > The fix is simple, just mo

Re: [dpdk-dev] [PATCH v6 1/3] net/i40e: support VF request more queues

2018-12-18 Thread Yan, Zhirun
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, December 18, 2018 8:44 PM > To: Yan, Zhirun ; dev@dpdk.org > Cc: Wang, Haiyue > Subject: RE: [PATCH v6 1/3] net/i40e: support VF request more queues > > > > > -Original Message- > > From: Yan, Zhirun > > Sent: Wednesda

Re: [dpdk-dev] [PATCH v6 3/3] doc: update queue number per vf for i40e

2018-12-18 Thread Yan, Zhirun
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, December 18, 2018 9:00 PM > To: Yan, Zhirun ; dev@dpdk.org > Subject: RE: [PATCH v6 3/3] doc: update queue number per vf for i40e > > > > > -Original Message- > > From: Yan, Zhirun > > Sent: Wednesday, December 19, 2018

Re: [dpdk-dev] [dpdk-stable] [PATCH] log: add missing experimental tag

2018-12-18 Thread Thomas Monjalon
04/12/2018 16:18, Neil Horman: > On Tue, Dec 04, 2018 at 09:28:31AM +0100, David Marchand wrote: > > When rte_log_register_type_and_pick_level() has been introduced, it has > > been correctly added to the EXPERIMENTAL section of the eal map and the > > symbol itself has been marked at its definitio

Re: [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include

2018-12-18 Thread Thomas Monjalon
18/12/2018 00:58, Ferruh Yigit: > On 12/17/2018 3:42 PM, Rami Rosen wrote: > > On Fri, 14 Dec 2018 at 18:43, Jeff Shaw wrote: > >> > >> Prior to this patch, the two affected .c files include > >> unnecessarily. This commit removes the include lines. > >> > >> Signed-off-by: Jeff Shaw > > > > Rev

Re: [dpdk-dev] [PATCH] pdump: remove deprecated APIs

2018-12-18 Thread Thomas Monjalon
13/12/2018 18:15, Pattan, Reshma: > Hi, > > From: Bie, Tiwei > > > > We already changed to use generic IPC in pdump since below commit: > > > > commit 660098d61f57 ("pdump: use generic multi-process channel") > > > > The `rte_pdump_set_socket_dir()`, the `path` parameter of `rte_pdump_init()` >

Re: [dpdk-dev] [PATCH] mk: don't install meson.build in usertools

2018-12-18 Thread Thomas Monjalon
28/11/2018 11:13, Luca Boccassi: > On Tue, 2018-11-27 at 20:35 +0100, Timothy Redaelli wrote: > > In commit 7dd34c71de2a ("usertools: install with meson") meson.build > > was > > added in usertools directory and so it's copied to > > $(datadir)/usertools > > with "make install". > > > > This patch

Re: [dpdk-dev] [PATCH v1] config: enable c11 memory model for ARMv8 meson

2018-12-18 Thread Thomas Monjalon
12/12/2018 11:13, Bruce Richardson: > On Tue, Dec 11, 2018 at 06:02:01AM +, Honnappa Nagarahalli wrote: > > + Bruce > > > > From: Gavin Hu > > > > > > This patch makes the configuration based on makefile and the configuration > > > based on meson to be the same. > > > > > > Fixes: c6e536e38

Re: [dpdk-dev] [PATCH] maintainers: update Cavium maintainers email id

2018-12-18 Thread Thomas Monjalon
16/12/2018 16:43, Jerin Jacob Kollanukkaran: > Following Marvell's acquisition of Cavium, we need to update all the > Cavium maintainer's entries to point to our new e-mail addresses. > Update maintainers as they are no longer working for Cavium. > > Thanks to Harish Patil for his support and deve

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-18 Thread Thomas Monjalon
18/12/2018 20:34, Dumitrescu, Cristian: > From: Ananyev, Konstantin > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 18/12/2018 14:19, Dumitrescu, Cristian: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 18/12/2018 12:18, Dumitrescu, Cristian: > > > > > > > > I rep

Re: [dpdk-dev] [EXT] [PATCH v4 0/1] New software event timer adapter

2018-12-18 Thread Carrillo, Erik G
> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Tuesday, December 18, 2018 2:12 PM > To: Jerin Jacob Kollanukkaran ; Carrillo, Erik G > > Cc: rsanf...@akamai.com; mattias.ronnb...@ericsson.com; > pbhagavat...@caviumnetworks.com; dev@dpdk.org > Sub

Re: [dpdk-dev] [EXT] [PATCH v4 0/1] New software event timer adapter

2018-12-18 Thread Jerin Jacob Kollanukkaran
On Fri, 2018-12-14 at 17:15 -0600, Erik Gabriel Carrillo wrote: > This patch introduces a new version of the event timer adapter > software > PMD [1]. In the original design, timer event producer lcores in the > primary > and secondary processes enqueued event timers into a ring, and a > service >

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, December 18, 2018 5:07 PM > To: Thomas Monjalon ; Dumitrescu, Cristian > > Cc: Pattan, Reshma ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > ; david.march...@redhat.com; > olivier.m...@6wind.com > Su

[dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-12-18 Thread Luse, Paul E
Resend wrong subject -Original Message- From: Trahe, Fiona Sent: Tuesday, December 18, 2018 7:43 AM To: Stephen Hemminger Cc: dev@dpdk.org; akhil.go...@nxp.com; Jozwiak, TomaszX ; shally.ve...@caviumnetworks.com; ashish.gu...@caviumnetworks.com; Daly, Lee ; Luse, Paul E ; Trahe, Fiona

Re: [dpdk-dev] [PATCH 0/2] net/cxgbe: rte_flow related bug fixes

2018-12-18 Thread Ferruh Yigit
On 12/14/2018 7:01 PM, Rahul Lakkireddy wrote: > Patch 1 fixes memory corruption due to overlapping regions in TID table. > Patch 2 fixes NULL pointer dereference when attempting to parse pattern > match items without any spec. > > Thanks, > Rahul > > Rahul Lakkireddy (2): > net/cxgbe: fix over

Re: [dpdk-dev] mail to ack

2018-12-18 Thread Luse, Paul E
-Original Message- From: Trahe, Fiona Sent: Tuesday, December 18, 2018 7:43 AM To: Stephen Hemminger Cc: dev@dpdk.org; akhil.go...@nxp.com; Jozwiak, TomaszX ; shally.ve...@caviumnetworks.com; ashish.gu...@caviumnetworks.com; Daly, Lee ; Luse, Paul E ; Trahe, Fiona Subject: RE: [dpdk

Re: [dpdk-dev] [PATCH 3/4] net/cxgbe: only redefine symbols when not available for Windows

2018-12-18 Thread Ferruh Yigit
On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote: > Redefine symbols only when they are not available for Windows > Again "for Windows" is very vague, can you please add more context? > Signed-off-by: Rahul Lakkireddy <...>

Re: [dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs for Windows

2018-12-18 Thread Ferruh Yigit
On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote: > Replace "args..." with "fmt, ..." and directly use __VA_ARGS__. What do you mean exactly by "for Windows"? Which compiler? Is there a specific C standard version you target? What is the issue with existing macros? Since we don't have a Windows supp

Re: [dpdk-dev] [PATCH 1/4] net/cxgbe: use relative paths for including header files

2018-12-18 Thread Ferruh Yigit
On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote: > Explicitly state header file location using relative paths. > > Signed-off-by: Rahul Lakkireddy > --- > drivers/net/cxgbe/Makefile | 2 -- > drivers/net/cxgbe/base/adapter.h | 4 ++-- > drivers/net/cxgbe/base/common.h| 2 +- > driver

Re: [dpdk-dev] [RFC] kni: remove ethtool support

2018-12-18 Thread Ferruh Yigit
On 12/18/2018 9:20 AM, Ferruh Yigit wrote: > On 12/18/2018 8:20 AM, Igor Ryzhov wrote: >> Hi Ferruh, >> >> Please, look at my patch http://patches.dpdk.org/patch/48454/ and consider >> rebasing your patch over mine. > > Sorry about that, yes I will check it today. Hi Igor, I put some comments on

Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers

2018-12-18 Thread Ferruh Yigit
On 12/3/2018 2:06 PM, Igor Ryzhov wrote: > Hi Ferruh, > > What about the patch? > > I also support dropping ethtool for ixgbe and i40e, but to save generic > ethtool_ops > with .get_link implementation, because it's an essential function that works > correctly > after proper implementation of ca

Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2018-12-18 Thread Iremonger, Bernard
> -Original Message- > From: Xu, Rosen > Sent: Tuesday, December 18, 2018 11:30 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Xu, Rosen ; Yigit, > Ferruh > Subject: [PATCH v5] app/testpmd: add IFPGA AFU register access function > > Currently register re

Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers

2018-12-18 Thread Ferruh Yigit
On 12/1/2018 11:12 AM, Igor Ryzhov wrote: > Hi Stephen, > > I also do not see the point of the current implementation of ethtool > support. > That's why I sent this patch – it enables ethtool_ops for all devices, > independent of the underlying driver. I tried to clarify this in the patch, but it

Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers

2018-12-18 Thread Ferruh Yigit
On 11/30/2018 7:47 PM, Igor Ryzhov wrote: > Current implementation of kni_ethtool_ops just uses corresponding > ethtool_ops function of underlying driver for all functions except for > .get_link. This commit sets kni->net_dev->ethtool_ops directly to the > ethtool_ops of the corresponding driver. I

Re: [dpdk-dev] [PATCH 00/20] net/ena: ENAv2 release

2018-12-18 Thread Ferruh Yigit
On 12/14/2018 1:18 PM, Michal Krawczyk wrote: > Hi, > > we are proud to announce ENAv2 driver for the DPDK. > It is already available for the Linux, and now also ENAv2 can be used with > DPDK on the appropriate AWS instances. > > To summarize, this release contains: > > **New major features** >

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-18 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, December 18, 2018 1:39 PM > To: Dumitrescu, Cristian > Cc: Pattan, Reshma ; dev@dpdk.org; Ananyev, > Konstantin ; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder ; > david.march...@redhat.com

Re: [dpdk-dev] [PATCH v2 2/2] cryptodev: change symmetric session structure

2018-12-18 Thread Trahe, Fiona
Hi Fan, > -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, December 18, 2018 9:25 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH v2 2/2] cryptodev: change symmetric session > structure > > Hi Fiona, > > Tha

Re: [dpdk-dev] [PATCH v3 0/3] improve MAC swap performance

2018-12-18 Thread Ferruh Yigit
On 12/18/2018 12:15 AM, Ferruh Yigit wrote: > On 12/16/2018 12:58 AM, Qi Zhang wrote: >> Improved testpmd macswap performance for x86 by take advantage of SSE >> instructions. >> On a broadwell 1.6GHz sever with a i40e 25G NIC. >> We abserve 17.7% performance improvement for testpmd's macswap test.

Re: [dpdk-dev] [PATCH v2 2/2] cryptodev: change symmetric session structure

2018-12-18 Thread Zhang, Roy Fan
Hi Fiona, Thanks for the review. Comments inline. > -Original Message- > From: Trahe, Fiona > Sent: Monday, December 17, 2018 8:30 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin > ; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v2 2/2] cryptodev: ch

Re: [dpdk-dev] [RFC] cryptodev/asymm: propose changes to modexp and modinv API

2018-12-18 Thread Trahe, Fiona
Hi Shally, Arek, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, December 18, 2018 6:54 AM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan > ; Kanaka Durga Kotamarthy > ; Sunila Sahu > ; Kotamarthy, Kanaka ; Sahu,

Re: [dpdk-dev] [PATCH v14 05/10] net/virtio: implement transmit path for packed queues

2018-12-18 Thread Ferruh Yigit
On 12/17/2018 9:31 PM, Jens Freimann wrote: > This implements the transmit path for devices with > support for packed virtqueues. > > Signed-off-by: Jens Freiman 's/Freiman/Freimann', updated in repo > Signed-off-by: Tiwei Bie > Reviewed-by: Maxime Coquelin <...>

[dpdk-dev] [PATCH v4 1/2] meter: add new rte color definition

2018-12-18 Thread Reshma Pattan
Added new rte_color definition in librte_meter to consolidate color definition which is currently replicated in various places such as rte_meter.h, rte_tm.h and rte_mtr.h Created aliases for rte_tm_color, rte_mtr_color and rte_meter_color to use new rte_color values. The definitions of rte_tm_col

[dpdk-dev] [PATCH v4 2/2] mbuf: implement generic format for sched field

2018-12-18 Thread Reshma Pattan
This patch implements the changes proposed in the deprecation notes [1][2]. librte_mbuf changes: The mbuf::hash::sched field is updated to support generic definition in line with the ethdev TM and MTR APIs. The new generic format contains: queue ID, traffic class, color. Added public APIs to set

[dpdk-dev] [PATCH v3 2/2] test/test_meter: update meter test to include RFC4115 meters

2018-12-18 Thread Eelco Chaudron
Add test cases for RFC4115 meters Signed-off-by: Eelco Chaudron --- test/test/test_meter.c | 212 1 file changed, 212 insertions(+) diff --git a/test/test/test_meter.c b/test/test/test_meter.c index 8bb47e75c..f935faa53 100644 --- a/test/test/te

[dpdk-dev] [PATCH v3 1/2] lib/librte_meter: add RFC4115 trTCM meter support

2018-12-18 Thread Eelco Chaudron
This patch adds support for RFC4115 trTCM meters. Signed-off-by: Eelco Chaudron --- lib/librte_meter/rte_meter.c | 42 ++ lib/librte_meter/rte_meter.h | 235 lib/librte_meter/rte_meter_version.map |9 + 3 files changed, 284 insertio

[dpdk-dev] [PATCH v3 0/2] lib/librte_meter: add RFC4115 trTCM meter support

2018-12-18 Thread Eelco Chaudron
This patch adds support for RFC4115 trTCM meters. Signed-off-by: Eelco Chaudron v3: - Gave the rfc4115 meter it's own data structures v2: - Marked all functions with __rte_experimental, and added "EXPERIMENTAL:..." to doxygen comments. - Removed library version change, and merged it with

Re: [dpdk-dev] [PATCH v5 02/10] vhost: provide helper for host notifier ctrl

2018-12-18 Thread Ferruh Yigit
On 12/18/2018 8:01 AM, Xiao Wang wrote: > @@ -155,4 +157,20 @@ > > rte_vdpa_get_device(int did); > > */ > int __rte_experimental > rte_vdpa_get_device_num(void); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Enable/Disable host notifier map

Re: [dpdk-dev] [PATCH v3] crypto/aesni_mb: add gmac support

2018-12-18 Thread Akhil Goyal
On 12/18/2018 7:21 PM, Fan Zhang wrote: > This patch adds AES-GMAC authentication only support to AESNI-MB > PMD. The unit test is updated accordingly. > > Signed-off-by: Fan Zhang > Acked-by: Damian Nowak > --- > v3: > - rebased on top of latest code. > - updated release note. > > v2: > - upda

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix missed wrapping

2018-12-18 Thread Akhil Goyal
On 12/18/2018 7:33 PM, Fan Zhang wrote: > This patch fixes the missed macro check of intel-ipsec-mb version. > Since plain SHA is supported only in 0.52, without a marco to > wrap the newly introduced definitions will cause the failed > compile if intel-ipsec-mb older than 0.52 is installed. > >

[dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread Arnon Warshavsky
Bugzilla ID: 165 Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides") Signed-off-by: Arnon Warshavsky Explicitly collect the error code of the multiple awk script calls --- devtools/checkpatches.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/devtoo

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread David Marchand
On Tue, Dec 18, 2018 at 3:54 PM Arnon Warshavsky wrote: > No need for all those checks on $? and the output saving. >> > > You blew my cover guys. I am not a shell scripts person :) > You are right. WIll change that > Eheh, I am looking at shell scripts at the same time... hence the quick replie

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread Arnon Warshavsky
> > No need for all those checks on $? and the output saving. > You blew my cover guys. I am not a shell scripts person :) You are right. WIll change that

Re: [dpdk-dev] [PATCH] mk: use misleading indentation warning when available

2018-12-18 Thread Ferruh Yigit
On 12/18/2018 10:26 AM, Gaetan Rivet wrote: > -Wmisleading-indentation was introduced in GCC 6.0. It seems '-Wmisleading-indentation' is part of -Wall, which we already set by default. If so no need to explicitly add it. The link I found: https://www.gnu.org/software/gcc/gcc-6/porting_to.html co

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread David Marchand
On Tue, Dec 18, 2018 at 3:45 PM Arnon Warshavsky wrote: > The reason I did not use the && approach is that if both checks have > errors, > only the first will be reported and we want all errors to be reported at > once > without discovering them one by one after every fix. > > Ok, then: diff --

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread Thomas Monjalon
18/12/2018 15:44, Arnon Warshavsky: > The reason I did not use the && approach is that if both checks have errors, > only the first will be reported and we want all errors to be reported at > once > without discovering them one by one after every fix. So please do a simple OR of $? No need to capt

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread Arnon Warshavsky
The reason I did not use the && approach is that if both checks have errors, only the first will be reported and we want all errors to be reported at once without discovering them one by one after every fix.

Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-12-18 Thread Trahe, Fiona
Hi Stephen //snip// > > > Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify > > > where processing is done > > > > > > On Tue, 20 Nov 2018 01:39:48 + > > > Fiona Trahe wrote: > > > > > > > A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE > > > > is added

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread Thomas Monjalon
18/12/2018 15:27, David Marchand: > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -51,7 +51,7 @@ check_forbidden_additions() { # > -v RET_ON_FAIL=1 \ > -v MESSAGE='Using rte_panic/rte_exit' \ > -f $(dirname $(readlink -e $0))/c

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread David Marchand
On Tue, Dec 18, 2018 at 3:16 PM David Marchand wrote: > > > On Tue, Dec 18, 2018 at 3:12 PM David Marchand > wrote: > >> >> >> On Tue, Dec 18, 2018 at 3:03 PM Arnon Warshavsky wrote: >> >>> Bugzilla ID: 165 >>> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides") >>> Signed-off-b

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread David Marchand
On Tue, Dec 18, 2018 at 3:12 PM David Marchand wrote: > > > On Tue, Dec 18, 2018 at 3:03 PM Arnon Warshavsky wrote: > >> Bugzilla ID: 165 >> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides") >> Signed-off-by: Arnon Warshavsky >> >> Explicitly collect the output and result of t

Re: [dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread David Marchand
On Tue, Dec 18, 2018 at 3:03 PM Arnon Warshavsky wrote: > Bugzilla ID: 165 > Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides") > Signed-off-by: Arnon Warshavsky > > Explicitly collect the output and result of the > multiple awk script calls, print and return error > if any of t

[dpdk-dev] [PATCH] crypto/aesni_mb: fix missed wrapping

2018-12-18 Thread Fan Zhang
This patch fixes the missed macro check of intel-ipsec-mb version. Since plain SHA is supported only in 0.52, without a marco to wrap the newly introduced definitions will cause the failed compile if intel-ipsec-mb older than 0.52 is installed. Fixes: 9d8dd0c5af95 ("crypto/aesni_mb: support plain

[dpdk-dev] [PATCH v1] devtools: fix error propagation from check-forbidden-tokens.awk

2018-12-18 Thread Arnon Warshavsky
Bugzilla ID: 165 Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides") Signed-off-by: Arnon Warshavsky Explicitly collect the output and result of the multiple awk script calls, print and return error if any of them fails --- devtools/checkpatches.sh | 21 + 1 f

Re: [dpdk-dev] [PATCH v14 00/10] implement packed virtqueues

2018-12-18 Thread Maxime Coquelin
On 12/17/18 10:31 PM, Jens Freimann wrote: This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob

Re: [dpdk-dev] [PATCH v4 00/10] support SW assisted VDPA live migration

2018-12-18 Thread Maxime Coquelin
On 12/14/18 10:16 PM, Xiao Wang wrote: In the previous VDPA implementation we have enabled live migration support by HW accelerator doing all the stuff, including dirty page logging and device status report/restore. In this mode VDPA sample daemon and device driver just takes care of the contr

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-18 Thread Maxime Coquelin
On 12/6/18 5:00 PM, Matthias Gatto wrote: fdset_add can call fdset_shrink_nolock which call fdset_move concurrently to poll that is call in fdset_event_dispatch. This patch add a mutex to protect poll from been call at the same time fdset_add call fdset_shrink_nolock. Signed-off-by: Matthias

Re: [dpdk-dev] [RFC] cryptodev/asymm: propose changes to modexp and modinv API

2018-12-18 Thread Verma, Shally
HI Arek, Fiona >-Original Message- >From: Kusztal, ArkadiuszX >Sent: 17 December 2018 19:55 >To: Verma, Shally >Cc: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan >; Kanaka Durga Kotamarthy >; Sunila Sahu ; Kotamarthy, Kanaka >; Sahu, >Sunila ; Cel, TomaszX ; >Jozwiak, TomaszX >Subject

Re: [dpdk-dev] [PATCH v6 00/31] A new net PMD - ICE

2018-12-18 Thread Ferruh Yigit
On 12/18/2018 8:46 AM, Wenzhuo Lu wrote: > This patch set adds the support of a new net PMD, > Intel® Ethernet Network Adapters E810, also > called ice. > > Below features are enabled by this patch set, > > Basic features: > 1, Basic device operations: probe, initialization, start/stop, configure

[dpdk-dev] [PATCH v3] crypto/aesni_mb: add gmac support

2018-12-18 Thread Fan Zhang
This patch adds AES-GMAC authentication only support to AESNI-MB PMD. The unit test is updated accordingly. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- v3: - rebased on top of latest code. - updated release note. v2: - updated documentation. doc/guides/cryptodevs/aesni_mb.rst

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-18 Thread Thomas Monjalon
18/12/2018 14:19, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 18/12/2018 12:18, Dumitrescu, Cristian: > > > > > I replied in v3 that it should stay in rte_meter.h. > > > > > You can include rte_meter.h in ethdev. > > > > > > > > OK, thanks Thomas, makes sense to m

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, December 18, 2018 12:38 PM > To: Dumitrescu, Cristian > Cc: Pattan, Reshma ; dev@dpdk.org; Ananyev, > Konstantin ; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > ; david.march...@redhat.com;

  1   2   3   >