[dpdk-dev] [PATCH] hash: fix __rte_hash_lookup_bulk return value

The __rte_hash_lookup_bulk() function returns void, and therefore should not return with an expression. This commit fixes the following compiler warning when attempting to compile with "-pedantic -std=c11". warning: ISO C forbids ‘return’ with expression, in function returning void [-

Re: [dpdk-dev] [PATCH] eal: fix rte_zalloc_socket to zero memory

fix up my emailer issue, sending out in non-plain text. :-( > On Dec 7, 2018, at 4:47 PM, David Harton (dharton) wrote: > > > >> -Original Message- >> From: Wiles, Keith >> Sent: Friday, December 07, 2018 6:41 PM >> To: David Harton (dharton) >> Cc: dev@dpdk.org; Burakov, Anatoly >>

Re: [dpdk-dev] [PATCH] eal: fix rte_zalloc_socket to zero memory

On Dec 7, 2018, at 4:47 PM, David Harton (dharton) mailto:dhar...@cisco.com>> wrote: -Original Message- From: Wiles, Keith mailto:keith.wi...@intel.com>> Sent: Friday, December 07, 2018 6:41 PM To: David Harton (dharton) mailto:dhar...@cisco.com>> Cc: dev@dpdk.org

Re: [dpdk-dev] [PATCH] eal: fix rte_zalloc_socket to zero memory

> -Original Message- > From: Wiles, Keith > Sent: Friday, December 07, 2018 6:41 PM > To: David Harton (dharton) > Cc: dev@dpdk.org; Burakov, Anatoly > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_zalloc_socket to zero memory > > > > > On Dec 7, 2018, at 3:24 PM, David Harton wrote

Re: [dpdk-dev] [PATCH] eal: fix rte_zalloc_socket to zero memory

> On Dec 7, 2018, at 3:24 PM, David Harton wrote: > > The zalloc and calloc functions do not actually zero the memory. > Added memset to rte_zmalloc_socket() so allocated memory is cleared. > > Signed-off-by: David Harton > --- > lib/librte_eal/common/rte_malloc.c | 4 +++- > 1 file changed, 3

[dpdk-dev] [PATCH] eal: fix rte_zalloc_socket to zero memory

The zalloc and calloc functions do not actually zero the memory. Added memset to rte_zmalloc_socket() so allocated memory is cleared. Signed-off-by: David Harton --- lib/librte_eal/common/rte_malloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rt

[dpdk-dev] [PATCH v2 1/1] eventdev: add new software event timer adapter

This patch introduces a new version of the event timer adapter software PMD. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To improve

[dpdk-dev] [PATCH v2 0/1] New software event timer adapter

This patch introduces a new version of the event timer adapter software PMD [1]. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To impr

[dpdk-dev] [PATCH v2] malloc: notify primary process about hotplug in secondary

When secondary process hotplugs memory, it sends a request to primary, which then performs the real mmap() and sends sync requests to all secondary processes. Upon receiving such sync request, each secondary process will notify the upper layers of hotplugged memory (and will call all locally regist

[dpdk-dev] [PATCH] malloc: notify primary process about hotplug in secondary

When secondary process hotplugs memory, it sends a request to primary, which then performs the real mmap() and sends sync requests to all secondary processes. Upon receiving such sync request, each secondary process will notify the upper layers of hotplugged memory (and will call all locally regist

Re: [dpdk-dev] [PATCH v2 1/2] timer: allow timer management in shared memory

Hi Stephen, Thanks for the review. Some responses in-line: > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, December 7, 2018 12:10 PM > To: Carrillo, Erik G > Cc: rsanf...@akamai.com; jerin.ja...@caviumnetworks.com; > pbhagavat...@caviu

Re: [dpdk-dev] Problems running netvsc multiq

On Fri, 07 Dec 2018 13:15:43 +0200 Mohammed Gamal wrote: > On Wed, 2018-12-05 at 14:32 -0800, Stephen Hemminger wrote: > > The problem is a regression in 4.20 kernel. Bisecting now. > > I was bisecting the kernel and the change that seems to introduce this > regression is this one: > > commit

Re: [dpdk-dev] [PATCH v2 1/2] timer: allow timer management in shared memory

On Fri, 7 Dec 2018 11:52:59 -0600 Erik Gabriel Carrillo wrote: > Currently, the timer library uses a per-process table of structures to > manage skiplists of timers presumably because timers contain arbitrary > function pointers whose value may not resolve properly in other > processes. > > How

[dpdk-dev] [PATCH v2 2/2] timer: add function to stop all timers in a list

Add a function to the timer API that allows a caller to traverse a specified set of timer lists, stopping each timer in each list, and invoking a callback function. Signed-off-by: Erik Gabriel Carrillo --- lib/librte_timer/rte_timer.c | 39 ++ lib/librte

[dpdk-dev] [PATCH v2 1/2] timer: allow timer management in shared memory

Currently, the timer library uses a per-process table of structures to manage skiplists of timers presumably because timers contain arbitrary function pointers whose value may not resolve properly in other processes. However, if the same callback is used handle all timers, and that callback is onl

[dpdk-dev] [PATCH v2 0/2] Timer library changes

This patch series modifies the timer library in such a way that structures that used to be statically allocated in a process's data segment are now allocated in shared memory. As these structures contain lists of timers, new APIs are introduced that allow a caller to specify the particular struct

Re: [dpdk-dev] Problems running netvsc multiq

On Fri, 07 Dec 2018 13:15:43 +0200 Mohammed Gamal wrote: > On Wed, 2018-12-05 at 14:32 -0800, Stephen Hemminger wrote: > > The problem is a regression in 4.20 kernel. Bisecting now. > > I was bisecting the kernel and the change that seems to introduce this > regression is this one: > > commit

Re: [dpdk-dev] [RFC 2/3] tqs: add thread quiescent state library

On Fri, 7 Dec 2018 07:27:16 + Honnappa Nagarahalli wrote: > > > > > > > > + > > > > > +/* Add a reader thread, running on an lcore, to the list of > > > > > +threads > > > > > + * reporting their quiescent state on a TQS variable. > > > > > + */ > > > > > +int __rte_experimental > > > > > +

Re: [dpdk-dev] [PATCH 2/3] net/virtio: merge Rx mergeable and non-mergeable paths

On 12/3/18 4:10 PM, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 5 -- drivers/net/virtio/virtio_ethdev.h | 3 - drivers/net/virtio/virtio_rxtx.c | 115 ++--- 3 files changed, 7 insertions(+), 116 deletions(-

Re: [dpdk-dev] [1/5] vhost: enforce avail index and desc read ordering

On Fri, Dec 07, 2018 at 05:58:24PM +0300, Ilya Maximets wrote: > On 06.12.2018 16:48, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 12:17:38PM +0800, Jason Wang wrote: > >> > >> On 2018/12/5 下午7:30, Ilya Maximets wrote: > >>> On 05.12.2018 12:49, Maxime Coquelin wrote: > A read barrier

[dpdk-dev] [PATCH v2 4/4] baseband: enhancement of interrupt test

Improvements added to interrupt test: - test is run in loop (number of iterations is specified by TEST_REPETITIONS define) which ensures more accurate results - mapping cores to thread parameteres was put in order. Master core is always set at first index. It fixes problem with running test for onl

[dpdk-dev] [PATCH v2 3/4] baseband: support bigger Transpor Block

Test application and Turbo Software driver were adapted to support chained-mbuf for bigger TB sizes. Signed-off-by: Kamil Chalupnik --- app/test-bbdev/test_bbdev_perf.c | 60 +--- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 111 --- 2 files cha

[dpdk-dev] [PATCH v2 2/4] baseband: enhancement of throughput test

Improvements added to throughput test: - test is run in loop (number of iterations is specified by TEST_REPETITIONS define) which ensures more accurate results - length of input data is calculated based on amount of CBs in TB - maximum number of decoding iterations is gathered from results - added

[dpdk-dev] [PATCH v2 1/4] baseband: enhancement of offload cost test

Offload cost test was improved in order to collect more accurate results. Signed-off-by: Kamil Chalupnik --- app/test-bbdev/test_bbdev_perf.c | 152 +++ config/common_base | 2 +- drivers/baseband/turbo_sw/bbdev_turbo_software.c

[dpdk-dev] [PATCH v2 3/4] baseband: support bigger Transpor Block

Test application and Turbo Software driver were adapted to support chained-mbuf for bigger TB sizes. Signed-off-by: Kamil Chalupnik --- app/test-bbdev/test_bbdev_perf.c | 60 +--- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 111 --- 2 files cha

Re: [dpdk-dev] [1/5] vhost: enforce avail index and desc read ordering

On 06.12.2018 16:48, Michael S. Tsirkin wrote: > On Thu, Dec 06, 2018 at 12:17:38PM +0800, Jason Wang wrote: >> >> On 2018/12/5 下午7:30, Ilya Maximets wrote: >>> On 05.12.2018 12:49, Maxime Coquelin wrote: A read barrier is required to ensure the ordering between available index and the de

[dpdk-dev] [Bug 121] In ixgbe_tx_free_bufs function the variable free on stack is used before initialization

https://bugs.dpdk.org/show_bug.cgi?id=121 Bug ID: 121 Summary: In ixgbe_tx_free_bufs function the variable free on stack is used before initialization Product: DPDK Version: unspecified Hardware: All OS: All

Re: [dpdk-dev] [PATCH v2] eal_interrupts: add option for pending callback unregister

On 07-Dec-18 11:40 AM, Jakub Grajciar wrote: use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregi

[dpdk-dev] [PATCH 4/4] baseband: enhancement of interrupt test

Improvements added to interrupt test: - test is run in loop (number of iterations is specified by TEST_REPETITIONS define) which ensures more accurate results - mapping cores to thread parameteres was put in order. Master core is always set at first index. It fixes problem with running test for onl

[dpdk-dev] [PATCH 2/4] baseband: enhancement of throughput test

Improvements added to throughput test: - test is run in loop (number of iterations is specified by TEST_REPETITIONS define) which ensures more accurate results - length of input data is calculated based on amount of CBs in TB - maximum number of decoding iterations is gathered from results - added

[dpdk-dev] [PATCH 1/4] baseband: enhancement of offload cost test

Offload cost test was improved in order to collect more accurate results. Signed-off-by: Kamil Chalupnik --- app/test-bbdev/test_bbdev_perf.c | 152 +++ config/common_base | 2 +- drivers/baseband/turbo_sw/bbdev_turbo_software.c

[dpdk-dev] [PATCH v2 3/3] doc: add deprecation notice to remove rte meter color

Added deprecation notice to replace rte_meter_color with rte_color. Signed-off-by: Reshma Pattan --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 60e081a54..1c771d8

[dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

Added new rte_color definition in eal to consolidate color definition which is currently replicated in various places such as rte_meter.h, rte_tm.h and rte_mtr.h Removed rte_tm_color and rte_mtr_color and used the new color definition in rte_tm* and rte_mtr* files. Updated softnic and testpmd to

[dpdk-dev] [PATCH v2 1/3] mbuf: implement generic format for sched field

This patch implements the changes proposed in the deprecation notes [1][2]. librte_mbuf changes: The mbuf::hash::sched field is updated to support generic definition in line with the ethdev TM and MTR APIs. The new generic format contains: queue ID, traffic class, color. Added public APIs to set

Re: [dpdk-dev] [PATCH] test/metrics: Fixed a negative case to pass

Git apply choked on the patch but it applied using patch -p0 - I'm guessing this is a problem with patches made using diff rather than git format-patch. The change itself is fine though. :) On 06/12/2018 15:01, Harman Kalra wrote: Negative test case for passing invalid count size to rte_metric

[dpdk-dev] [PATCH v2] eal_interrupts: add option for pending callback unregister

use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

Re: [dpdk-dev] [5/5] vhost: remove useless casts to volatile

On 06.12.2018 19:59, Maxime Coquelin wrote: > Hi Ilya, > > On 12/5/18 2:52 PM, Ilya Maximets wrote: >> On 05.12.2018 12:49, Maxime Coquelin wrote: >>> Cast to volatile is done when reading avail index and writing >>> the used index. This would not be necessary if proper barriers >>> are used. >> >

Re: [dpdk-dev] Problems running netvsc multiq

On Wed, 2018-12-05 at 14:32 -0800, Stephen Hemminger wrote: > The problem is a regression in 4.20 kernel. Bisecting now. I was bisecting the kernel and the change that seems to introduce this regression is this one: commit ae6935ed7d424ffa74d634da00767e7b03c98fd3 Author: Stephen Hemminger Date: 

Re: [dpdk-dev] [PATCH] app/test-pmd: add IFPGA AFU register read/write access for testpmd

Hi Rosen > -Original Message- > From: Xu, Rosen > Sent: Thursday, December 6, 2018 12:17 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard ; > Xu, Rosen ; Yigit, Ferruh > Subject: [PATCH] app/test-pmd: add IFPGA AFU register read/write access for > testpmd > >

Re: [dpdk-dev] [PATCH v3 0/8] examples/ipsec-secgw: make app to use ipsec library

On 12/6/2018 3:54 PM, Konstantin Ananyev wrote: This patch series depends on the patch series: Add 'try' semantics for RD and WR locking http://patches.dpdk.org/patch/48044/ http://patches.dpdk.org/patch/48045/ ipsec: new library for IPsec data-path processing http://patches.dpdk.org/patch/4

Re: [dpdk-dev] [PATCH v2] eal: fix unlock in rte_eal_memzone_init

On 07-Dec-18 1:20 AM, Gao Feng wrote: The RTE_PROC_PRIMARY error handler lost the unlock statement in the current codes. Now unlock and return in one place to fix it. Fixes: 49df3db84883 ("memzone: replace memzone array with fbarray") Cc: sta...@dpdk.org Signed-off-by: Gao Feng --- Acked-by: