Re: [dpdk-dev] [PATCH 0/3] new software event timer adapter

2018-11-29 Thread Pavan Nikhilesh
Hi Eric, I think we may need to address the librte_timer and event_timer patches in separate series as we are modifying common code for the sake of sw_event_timer PMD and the series title implies that only the PMD has been modified. Also, I think we need to profile and report the performance regr

Re: [dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it

2018-11-29 Thread Pavan Nikhilesh
Hi Stephen, On Thu, Nov 29, 2018 at 01:21:52PM -0800, Stephen Hemminger wrote: > On Thu, 29 Nov 2018 08:32:03 + > Pavan Nikhilesh wrote: > > > When estimating tsc frequency using sleep/gettime round it up to the > > nearest multiple of 10Mhz for more accuracy. > > > > Signed-off-by: Pavan Nik

Re: [dpdk-dev] [v1] net/i40e: fix RX/TX setup when restart port

2018-11-29 Thread Yan, Zhirun
Hi Ilya, > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Wednesday, November 28, 2018 5:32 PM > To: Yan, Zhirun ; dev@dpdk.org; Zhang, Qi Z > > Cc: Wang, Haiyue > Subject: Re: [v1] net/i40e: fix RX/TX setup when restart port > > On 28.11.2018 19:51, Zh

[dpdk-dev] 答复: [PATCH] net/bonding: fix double fetch for active_slave_count

2018-11-29 Thread Linhaifeng
Hi, Chars Thank you. I use it for send pkts to the dedicated queue of slaves. Maybe i should not use it. I would though another way. -邮件原件- 发件人: Chas Williams [mailto:3ch...@gmail.com] 发送时间: 2018年11月30日 11:27 收件人: Linhaifeng ; dev@dpdk.org 抄送: ch...@att.com 主题: Re: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH] net/bonding: fix double fetch for active_slave_count

2018-11-29 Thread Chas Williams
I guess this is slightly more correct. There is still a race here though. After you make your copy of active_slave_count, the number of active slaves could go to 0 and the memcpy() would copy an invalid element, acitve_slaves[0]. There is no simple fix to this problem. Your patch reduces the opp

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-29 Thread Honnappa Nagarahalli
> > > > > > > Mixed feelings about this one. > > > > Love to see RCU used for more things since it is much better than > > reader/writer locks for many applications. But hate to see DPDK > > reinventing every other library and not reusing code. Userspace RCU > > https://liburcu.org/ is widely suppo

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-29 Thread Honnappa Nagarahalli
> > > > > Mixed feelings about this one. > > > > > > > > Love to see RCU used for more things since it is much better than > > > > reader/writer locks for many applications. But hate to see DPDK > > > > reinventing every other library and not reusing code. Userspace > > > > RCU https://liburcu.org

[dpdk-dev] [PATCH] net/i40e: fixed return value check for hash

2018-11-29 Thread Qiming Yang
RSS hash configure get API didn't check the return value. Will return sucess even get RSS hash key failed. This patch fixed teh issue. Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/i40e/i40e_ethdev.c | 5 - 1 file ch

[dpdk-dev] [RFC PATCH] kvargs: add match count inside processing

2018-11-29 Thread Thomas Monjalon
After processing a kvlist in rte_kvargs_process(), it may be needed to loop again over kvlist, in order to know whether the key is matched or not, as done with rte_kvargs_count(). In order to simplify implementation of kvargs checks, a new pointer parameter is added to get the match count from the

[dpdk-dev] [PATCH] ethdev: add siblings iterator

2018-11-29 Thread Thomas Monjalon
If multiple ports share the same hardware device (rte_device), they are siblings and can be found thanks to the new function and loop macro. The ownership is not checked because siblings may have different owners. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 15

[dpdk-dev] [PATCH 3/3] eventdev: add new software event timer adapter

2018-11-29 Thread Erik Gabriel Carrillo
This commit updates the implementation of the software event timer adapter. The original version used rings to let producer cores (and secondary processes) send timers to a service core, which would then arm or cancel the timers, depending on what the application had requested. The ring can be a b

[dpdk-dev] [PATCH 2/3] timer: add function to stop all timers in a list

2018-11-29 Thread Erik Gabriel Carrillo
Add a function to the timer API that allows a caller to traverse a specified set of timer lists, stopping each timer in each list, and invoking a callback function. Signed-off-by: Erik Gabriel Carrillo --- lib/librte_timer/rte_timer.c | 81 +++--- lib/librte

[dpdk-dev] [PATCH 0/3] new software event timer adapter

2018-11-29 Thread Erik Gabriel Carrillo
This patch series introduces a new version of the event timer adapter software PMD [1]. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further.

[dpdk-dev] [PATCH 1/3] timer: allow timer management in shared memory

2018-11-29 Thread Erik Gabriel Carrillo
Currently, the timer library uses a per-process table of structures to manage skiplists of timers presumably because timers contain arbitrary function pointers whose value may not resolve properly in other processes. However, if the same callback is used handle all timers, and that callback is onl

Re: [dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it

2018-11-29 Thread Stephen Hemminger
On Thu, 29 Nov 2018 08:32:03 + Pavan Nikhilesh wrote: > When estimating tsc frequency using sleep/gettime round it up to the > nearest multiple of 10Mhz for more accuracy. > > Signed-off-by: Pavan Nikhilesh Rounding reduces accuracy. Why is this code being used? Shouldn't get_tsc_freq_ar

[dpdk-dev] [PATCH 3/3] test/timer: enable unit test compilation always

2018-11-29 Thread Dharmik Thakkar
This patch replaces macro with log-level based approach to print debug information. Need to set timer log type to debug using the following eal parameter: --log-level=timer,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu R

[dpdk-dev] [PATCH 0/3] Replace compilation time options with log level

2018-11-29 Thread Dharmik Thakkar
Currently, in test code, for printing extra information, compilation time options are used. This approach does not compile the code always. Macro needs to be set for the code to compile. This patchset replaces compilation time option with log level based approach, thus enabling compilation of code

[dpdk-dev] [PATCH 2/3] test/efd: enable unit test compilation always

2018-11-29 Thread Dharmik Thakkar
This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-type=efd,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by:

[dpdk-dev] [PATCH 1/3] test/hash: replace macro with log-level approach

2018-11-29 Thread Dharmik Thakkar
Need to set hash log type to debug to print debug information, using following eal parameter: --log-type=hash,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- test/test/test_hash.c | 3 +-- 1 fil

[dpdk-dev] [PATCH] eventdev: remove redundant timer adapter function prototypes

2018-11-29 Thread Erik Gabriel Carrillo
Fixes: a6562f6d6f8e ("eventdev: introduce event timer adapter") Cc: sta...@dpdk.org Signed-off-by: Erik Gabriel Carrillo --- lib/librte_eventdev/rte_event_timer_adapter.h | 57 +-- 1 file changed, 2 insertions(+), 55 deletions(-) diff --git a/lib/librte_eventdev/rte_even

[dpdk-dev] [PATCH 1/1] app/eventdev: detect deadlock for timer event producer

2018-11-29 Thread Erik Gabriel Carrillo
If timer events get dropped for some reason, the thread that launched producer and worker cores will never exit, because the deadlock check doesn't currently apply to the event timer adapter case. This commit fixes this. Signed-off-by: Erik Gabriel Carrillo --- app/test-eventdev/test_perf_common

[dpdk-dev] [RFC] mem: do not merge elems from different heap allocs

2018-11-29 Thread Jim Harris
SPDK uses the rte_mem_event_callback_register API to create RDMA memory regions (MRs) for newly allocated regions of memory. This is used in both the SPDK NVMe-oF target and the NVMe-oF host driver. DPDK creates internal malloc_elem structures for these allocated regions. As users malloc and fre

[dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-11-29 Thread Erik Gabriel Carrillo
rte_timer_manage() adds expired timers to a "run list", and walks the list, transitioning each timer from the PENDING to the RUNNING state. If another lcore resets or stops the timer at precisely this moment, the timer state would instead be set to CONFIG by that other lcore, which would cause time

[dpdk-dev] [PATCH] test/hash: reset iter and found in perf test

2018-11-29 Thread Dharmik Thakkar
Reset 'iter' and 'tbl_rw_test_param.found' on each iteration to give correct result for lost and duplicated keys. Fixes: 0eb3726ebcf14 ("test/hash: add test for read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar --- test/test/test_hash_readwrite.c | 5 +++-- 1 file chan

Re: [dpdk-dev] [PATCH] helloworld: Windows DPDK sample application is compiled and built using eal and kvargs libraries in order to add windows support in the mainline repository.

2018-11-29 Thread Stephen Hemminger
On Wed, 28 Nov 2018 21:05:04 -0800 Pallavi Kadam wrote: > +// If we define WIN32_LEAN_AND_MEAN, winsock isn't included by default. We > can then include it in specific header files as we need later. > +#define WIN32_LEAN_AND_MEAN All this is Windows code, it would be best if the code style of t

Re: [dpdk-dev] [PATCH] net/mlx5: fix non-matching parameters documentation

2018-11-29 Thread Ferruh Yigit
On 11/29/2018 11:39 AM, Asaf Penso wrote: > tso and vlan parameters were removed from the signature > of txq_mbuf_to_swp function. > > The documentation of the function was not updated accordingly. > > Remove the tso and vlan documentation to match the function signature. > > Fixes: 8f6d9e13a98c

[dpdk-dev] RFC: Support for multiple buffer pool in examples/l3fwd

2018-11-29 Thread Shreyansh Jain
Currently examples/l3fwd/main.c has support for pktmbuf_pool per socket. L136: static struct rte_mempool * pktmbuf_pool[NB_SOCKETS]; In various setups, having a separate buffer pool per port (or even per queue) can achieve performance many-folds higher than single pool

Re: [dpdk-dev] [PATCH] examples/bond: wait for slaves to become active

2018-11-29 Thread Ferruh Yigit
On 11/27/2018 7:01 PM, Chas Williams wrote: > > > On 11/14/2018 07:19 AM, Radu Nicolau wrote: >> Do not start the packet processing threads until all configured >> slaves become active. >> >> Signed-off-by: Radu Nicolau > > Acked-by: Chas Williams Applied to dpdk-next-net/master, thanks. (co

Re: [dpdk-dev] [dpdk-stable] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Ferruh Yigit
On 11/29/2018 3:47 PM, Wiles, Keith wrote: > > >> On Nov 29, 2018, at 9:36 AM, Burakov, Anatoly >> wrote: >> >> On 29-Nov-18 2:54 PM, Wiles, Keith wrote: On Nov 29, 2018, at 8:21 AM, Anatoly Burakov wrote: We already trigger a mem event notification inside the walk functio

[dpdk-dev] 16.11.9 (LTS) patches review and test

2018-11-29 Thread Luca Boccassi
Hi all, Here is a list of patches targeted for LTS release 16.11.9. Please help review and test. The planned date for the final release is December the 10th. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression

[dpdk-dev] [PATCH] eal_interrupts: add option for pending callback unregister

2018-11-29 Thread Jakub Grajciar
use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

Re: [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Wiles, Keith
> On Nov 29, 2018, at 9:36 AM, Burakov, Anatoly > wrote: > > On 29-Nov-18 2:54 PM, Wiles, Keith wrote: >>> On Nov 29, 2018, at 8:21 AM, Anatoly Burakov >>> wrote: >>> >>> We already trigger a mem event notification inside the walk function, >>> no need to do it twice. >>> >>> Fixes: f32c7

Re: [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Burakov, Anatoly
On 29-Nov-18 3:18 PM, Anatoly Burakov wrote: We already trigger a mem event notification inside the walk function, no need to do it twice. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/r

Re: [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Burakov, Anatoly
On 29-Nov-18 2:54 PM, Wiles, Keith wrote: On Nov 29, 2018, at 8:21 AM, Anatoly Burakov wrote: We already trigger a mem event notification inside the walk function, no need to do it twice. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") Cc: sta...@dpdk.org Signed-

[dpdk-dev] [PATCH 1/2] test/distributor: flush with worker shutdown test fails

2018-11-29 Thread Harman Kalra
From: Harman Kalra On restarting worker 0 after shutdown, packets handled by worker 0 must be incremented only when a packet is received by it. Signed-off-by: Harman Kalra --- test/test/test_distributor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git test/test/test_distri

[dpdk-dev] [PATCH 2/2] distributor: imposing additional check on no of workers

2018-11-29 Thread Harman Kalra
From: Harman Kalra No of workers should never exceed RTE_MAX_LCORE. RTE_DIST_ALG_SINGLE also require no of workers check. Signed-off-by: Harman Kalra --- lib/librte_distributor/rte_distributor.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git lib/librte_distributo

Re: [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Wiles, Keith
> On Nov 29, 2018, at 8:21 AM, Anatoly Burakov > wrote: > > We already trigger a mem event notification inside the walk function, > no need to do it twice. > > Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov

Re: [dpdk-dev] [Bug 113] pktgen -s option send pcap traffic once

2018-11-29 Thread Wiles, Keith
> On Nov 29, 2018, at 8:09 AM, bugzi...@dpdk.org wrote: > > https://bugs.dpdk.org/show_bug.cgi?id=113 > >Bug ID: 113 > Summary: pktgen -s option send pcap traffic once > Product: DPDK > Version: unspecified > Hardware: x86 >OS:

Re: [dpdk-dev] [PATCH] net/nfp: add multiprocess support

2018-11-29 Thread Tom Barbette
Ferruh Yigit wrote: > According my understanding, > Only *one* DPDK application (primary or secondary) should control a device. > There is no restriction in DPDK for it, this responsibility is pushed to > application, application should manage it. ... > Device initialization (probe()) done only b

[dpdk-dev] [PATCH] malloc: fix duplicate mem event notification

2018-11-29 Thread Anatoly Burakov
We already trigger a mem event notification inside the walk function, no need to do it twice. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/rte_malloc.c | 4 1 file changed, 4 deletion

Re: [dpdk-dev] pkg-config file generated with meson

2018-11-29 Thread David Marchand
On Thu, Nov 29, 2018 at 3:08 PM Luca Boccassi wrote: > > It's true that there is "libdpdk" in the Requires.private section, and > probably shouldn't - but at least on Debian stable with pkg-config 0.29 > it works fine despite that: > Well, this was my first impression when I saw Requires.private

[dpdk-dev] [Bug 113] pktgen -s option send pcap traffic once

2018-11-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=113 Bug ID: 113 Summary: pktgen -s option send pcap traffic once Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal

Re: [dpdk-dev] pkg-config file generated with meson

2018-11-29 Thread Luca Boccassi
On Thu, 2018-11-29 at 14:55 +0100, David Marchand wrote: > Hello Bruce, > > I built v18.11 with meson and had a little look at the libdpdk.pc > file. > It looks like pkg-config works fine with --libs but is recursively > opening > libdpdk.pc when asking for the cflags: > > $ PKG_CONFIG_PATH=build

Re: [dpdk-dev] [PATCH] net/nfp: add multiprocess support

2018-11-29 Thread Ferruh Yigit
On 11/28/2018 6:05 PM, Alejandro Lucero wrote: > > > On Wed, Nov 28, 2018 at 5:28 PM Ferruh Yigit > wrote: > > On 11/28/2018 11:32 AM, Alejandro Lucero wrote: > > This patch introduces changes for supporting multiprocess support. > > This is trivial fo

[dpdk-dev] pkg-config file generated with meson

2018-11-29 Thread David Marchand
Hello Bruce, I built v18.11 with meson and had a little look at the libdpdk.pc file. It looks like pkg-config works fine with --libs but is recursively opening libdpdk.pc when asking for the cflags: $ PKG_CONFIG_PATH=build/meson-private:$PKG_CONFIG_PATH pkg-config --libs libdpdk -L/usr/local/lib6

[dpdk-dev] [PATCH 4/4] mem: allow usage of non-heap external memory in multiprocess

2018-11-29 Thread Anatoly Burakov
Add multiprocess support for externally allocated memory areas that are not added to DPDK heap (and add relevant doc sections). Signed-off-by: Anatoly Burakov --- .../prog_guide/env_abstraction_layer.rst | 3 + lib/librte_eal/common/eal_common_memory.c | 42 + lib/librte_ea

[dpdk-dev] [PATCH 0/4] Allow using external memory without malloc

2018-11-29 Thread Anatoly Burakov
Currently, the only way to use externally allocated memory is through rte_malloc API's. While this is fine for a lot of use cases, it may not be suitable for certain other use cases like manual memory management, etc. This patchset adds another API to register memory segments with DPDK (so that AP

[dpdk-dev] [PATCH 3/4] mem: allow registering external memory areas

2018-11-29 Thread Anatoly Burakov
The general use-case of using external memory is well covered by existing external memory API's. However, certain use cases require manual management of externally allocated memory areas, so this memory should not be added to the heap. It should, however, be added to DPDK's internal structures, so

[dpdk-dev] [PATCH 1/4] malloc: separate creating memseg list and malloc heap

2018-11-29 Thread Anatoly Burakov
Currently, creating external malloc heap involves also creating a memseg list backing that malloc heap. We need to have them as separate functions, to allow creating memseg lists without creating a malloc heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/malloc_heap.c | 34 +

[dpdk-dev] [PATCH 2/4] malloc: separate destroying memseg list and heap data

2018-11-29 Thread Anatoly Burakov
Currently, destroying external heap chunk and its memseg list is part of one process. When we will gain the ability to unregister external memory from DPDK that doesn't have any heap structures associated with it, we need to be able to find and destroy memseg lists as well as heap data separately.

[dpdk-dev] DPDK Release Status Meeting 29/11/2018

2018-11-29 Thread Ferruh Yigit
Minutes 29 November 2018 Agenda: * Dates * Proposal deadline * Subtrees * Bugzilla * OvS * Conferences * Coverity * Opens Participants: * Broadcom * Debian * Intel * NXP * RedHat Release Dates - * v18.11 released. Thanks to everyone contributed. * Thomas

Re: [dpdk-dev] [PATCH] examples/bond: wait for slaves to become active

2018-11-29 Thread Nicolau, Radu
I'm ok with the updates, thanks! -Original Message- From: Yigit, Ferruh Sent: Thursday, November 29, 2018 8:57 AM To: Nicolau, Radu ; dev@dpdk.org Cc: Doherty, Declan ; ch...@att.com Subject: [dpdk-dev] [PATCH] examples/bond: wait for slaves to become active On 11/28/2018 1:48 PM, Radu N

[dpdk-dev] [PATCH] net/mlx5: fix non-matching parameters documentation

2018-11-29 Thread Asaf Penso
tso and vlan parameters were removed from the signature of txq_mbuf_to_swp function. The documentation of the function was not updated accordingly. Remove the tso and vlan documentation to match the function signature. Fixes: 8f6d9e13a98c ("net/mlx5: remove redundant checks") Cc: ys...@mellanox.

[dpdk-dev] [PATCH v2 1/2] lib/librte_meter: add RFC4115 trTCM meter support

2018-11-29 Thread Eelco Chaudron
This patch adds support for RFC4115 trTCM meters. Signed-off-by: Eelco Chaudron --- lib/librte_meter/rte_meter.c | 40 + lib/librte_meter/rte_meter.h | 236 ++-- lib/librte_meter/rte_meter_version.map |9 + 3 files changed, 269 insertion

[dpdk-dev] [PATCH v2 2/2] test/test_meter: update meter test to include RFC4115 meters

2018-11-29 Thread Eelco Chaudron
Add test cases for RFC4115 meters Signed-off-by: Eelco Chaudron --- test/test/test_meter.c | 212 1 file changed, 212 insertions(+) diff --git a/test/test/test_meter.c b/test/test/test_meter.c index 8bb47e75c..097da0143 100644 --- a/test/test/te

[dpdk-dev] [PATCH v2 0/2] lib/librte_meter: add RFC4115 trTCM meter support

2018-11-29 Thread Eelco Chaudron
This patch adds support for RFC4115 trTCM meters. Signed-off-by: Eelco Chaudron v2: - Marked all functions with __rte_experimental, and added "EXPERIMENTAL:..." to doxygen comments. - Removed library version change, and merged it with first patch - Do not call rte_meter_trtcm_rfc4115_color

[dpdk-dev] [RFC] net/mlx5: add modify-header support using Direct Verbs

2018-11-29 Thread Dekel Peled
Modify-header actions support is implemented in librte_ethdev, and in test-pmd application, based on [1]. These actions include setting of source/destination IP, MAC & TP, as well as TTL. Currently MLX5 PMD supports modify-header actions using TCF (netlink) API only. This RFC adds to MLX5 PMD th

[dpdk-dev] [PATCH] eventdev: fix eth Tx adapter queue count checks

2018-11-29 Thread Nikhil Rao
rte_event_eth_tx_adapter_queue_add() - add a check that returns an error if the ethdev the zero Tx queues configured. rte_event_eth_tx_adapter_queue_del() - remove the checks for ethdev queue count, instead check for queues added to the adapter which maybe different from the current ethdev queue c

Re: [dpdk-dev] [PATCH] mbuf: implement generic format for sched field

2018-11-29 Thread Singh, Jasvinder
> > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 3dbc6695e..98428bd21 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -575,12 +575,10 @@ struct rte_mbuf { > > */ > > } f

Re: [dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it

2018-11-29 Thread Jerin Jacob
-Original Message- > Date: Thu, 29 Nov 2018 14:02:03 +0530 > From: "Bhagavatula, Pavan" > To: "Jacob, Jerin" > CC: "dev@dpdk.org" , "Bhagavatula, Pavan" > > Subject: [dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it > > When estimating tsc frequency using sleep/gettime

[dpdk-dev] [PATCH] examples/bond: wait for slaves to become active

2018-11-29 Thread Ferruh Yigit
On 11/28/2018 1:48 PM, Radu Nicolau wrote: > Hi > > > On 11/28/2018 11:08 AM, Ferruh Yigit wrote: >> On 11/14/2018 12:19 PM, Radu Nicolau wrote: >>> Do not start the packet processing threads until all configured >>> slaves become active. >> Hi Radu, >> >> What happens if packet processing thread

Re: [dpdk-dev] [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx adapter

2018-11-29 Thread Ferruh Yigit
On 11/29/2018 8:00 AM, Nikhil Rao wrote: > strerror() input parameter should be > 0. > > Coverity issue: 302864 > Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter") > CC: sta...@dpdk.org > > Signed-off-by: Nikhil Rao Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/ifcvf: fix a typo

2018-11-29 Thread Wang, Xiao W
Hi, > -Original Message- > From: Ye, Xiaolong > Sent: Thursday, November 29, 2018 4:22 PM > To: dev@dpdk.org; Maxime Coquelin ; Bie, > Tiwei ; Wang, Zhihong > Cc: Wang, Xiao W ; Ye, Xiaolong > ; sta...@dpdk.org > Subject: [PATCH] net/ifcvf: fix a typo > > The struct should be ifcvf_net_c

[dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it

2018-11-29 Thread Pavan Nikhilesh
When estimating tsc frequency using sleep/gettime round it up to the nearest multiple of 10Mhz for more accuracy. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/eal_common_timer.c | 4 ++-- lib/librte_eal/common/include/rte_common.h | 10 ++ lib/librte_eal/linuxapp/eal/eal_t

[dpdk-dev] [PATCH] net/ifcvf: fix a typo

2018-11-29 Thread Xiaolong Ye
The struct should be ifcvf_net_config other than ifcvf_net_device_config. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Cc: xiao.w.w...@intel.com Cc: sta...@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/ifc/base/ifcvf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[dpdk-dev] [PATCH] eventdev: fix call to strerror in eth Rx adapter

2018-11-29 Thread Nikhil Rao
strerror() input parameter should be > 0. Coverity issue: 302864 Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter") CC: sta...@dpdk.org Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di