[dpdk-dev] Issue in sending and receiving packets through L3fwd sample application

2018-11-19 Thread Kenvish Butani
# ./l3fwd -c 0x3 -n 2 -- -p 0x3 --config="(0,0,0),(1,0,1)" EAL: Detected 24 lcore(s) EAL: Detected 2 NUMA nodes EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Probing VFIO support... EAL: PCI device igb_uio :01:00.0: uio device registered with irq 44 :01:00.0 on NUMA socket 0 EA

[dpdk-dev] [PATCH v2] net/ixgbe: fix TDH register setting issue

2018-11-19 Thread Yanglong Wu
The only time that software should write to the TDH register is after a reset (hardware reset or CTRL.RST) and before enabling the transmit function (TXDCTL.ENABLE). If software were to write to this register while the transmit function was enabled, the on-chip descriptor buffers might be invalidat

Re: [dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-19 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Monday, November 19, 2018 6:12 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Wu, Jingjing ; Byrne, Stephen1 > > Subject: RE: [PATCH] net/ixgbe: fix TDH register setting issue > > Hi, qi > I don't understand why dose this patch not change re

Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone

2018-11-19 Thread Zhao1, Wei
Hi, Konstantin > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Wednesday, November 14, 2018 7:19 PM > To: Wang, Dong1 ; Lipiec, Herakliusz > ; dev@dpdk.org > Cc: tho...@monjalon.net; Burakov, Anatoly ; > sta...@dpdk.org > Subject: R

Re: [dpdk-dev] [PATCH 1/2] compressdev: add api to bulk free ops

2018-11-19 Thread Verma, Shally
>-Original Message- >From: Fiona Trahe >Sent: 20 November 2018 03:40 >To: dev@dpdk.org >Cc: akhil.go...@nxp.com; tomaszx.jozw...@intel.com; Verma, Shally >; Gupta, Ashish >; lee.d...@intel.com; fiona.tr...@intel.com >Subject: [PATCH 1/2] compressdev: add api to bulk free ops > >Externa

Re: [dpdk-dev] [PATCH 2/2] test/compress: use bulk free operations api

2018-11-19 Thread Verma, Shally
>-Original Message- >From: Fiona Trahe >Sent: 20 November 2018 03:40 >To: dev@dpdk.org >Cc: akhil.go...@nxp.com; tomaszx.jozw...@intel.com; Verma, Shally >; Gupta, Ashish >; lee.d...@intel.com; fiona.tr...@intel.com >Subject: [PATCH 2/2] test/compress: use bulk free operations api > >E

Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-11-19 Thread Verma, Shally
HI Fiona >-Original Message- >From: Fiona Trahe >Sent: 20 November 2018 07:10 >To: dev@dpdk.org >Cc: akhil.go...@nxp.com; tomaszx.jozw...@intel.com; Verma, Shally >; Gupta, Ashish >; lee.d...@intel.com; fiona.tr...@intel.com >Subject: [PATCH] compressdev: add feature flag to specify wher

[dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance

2018-11-19 Thread Qi Zhang
The patch optimizes the mac swap operation by taking advantage of SSE instructions, it only impacts x86 platform. Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- app/test-pmd/macswap.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/macswap.c b/

Re: [dpdk-dev] [PATCH v2] net/igb: fix LSC interrupt when using MSI-X

2018-11-19 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Monday, November 19, 2018 7:29 PM > To: Player, Timmons > Cc: dev@dpdk.org; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2] net/igb: fix LSC interrupt when using MSI-X > > Acked-by: Wei Zha

Re: [dpdk-dev] [PATCH v2] net/igb: fix LSC interrupt when using MSI-X

2018-11-19 Thread Zhao1, Wei
Acked-by: Wei Zhao > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Player, Timmons > Sent: Monday, November 19, 2018 10:49 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Player, Timmons > Subject: [dpdk-dev] [PATCH v2] net/igb: fix LSC interrupt when using MSI-X >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-19 Thread Wu, Yanglong
Hi, qi I don't understand why dose this patch not change register write order. THD is write before TXDCTL.ENABL. The Intel 82599 data sheet (https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82599-10-gbe-controller-datasheet.pdf, §8.2.3.9.8) states that "The only time t

Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-11-19 Thread Stephen Hemminger
On Tue, 20 Nov 2018 01:39:48 + Fiona Trahe wrote: > A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE > is added. A PMD which processes operations using a software > acceleration engine should set this if the bulk of the > processing is done during the dequeue. It should leave i

[dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-11-19 Thread Fiona Trahe
A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE is added. A PMD which processes operations using a software acceleration engine should set this if the bulk of the processing is done during the dequeue. It should leave it cleared if the bulk of the processing is done during the enque

Re: [dpdk-dev] [PATCH 6/9] ipsec: implement SA data-path API

2018-11-19 Thread Zhang, Qi Z
Hi Konstantin and Awal: I have couple questions for this patch. please forgive me if they are obvious, since I don't have much insight on IPsec, but I may work on related stuff in future :) > +static inline int32_t > +esp_outb_tun_pkt_prepare(struct rte_ipsec_sa *sa, rte_

[dpdk-dev] [RFC] net/i40e: Match on outer and inner headers for tunneled packets

2018-11-19 Thread subarna . kar
From: Subarna Kar This patch is to allow i40e to match on outer and inner headers for tunneled packets (MPLSoGRE, MPLSoUDP, VXLAN) and perform actions like RSS, MARK Signed-off-by: Subarna Kar --- drivers/net/i40e/i40e_ethdev.c | 12 +- drivers/net/i40e/i40e_ethdev.h | 109 +- drivers/net

[dpdk-dev] [dpdk_org] net/i40e: Match on outer and inner headers for tunneled packets

2018-11-19 Thread subarna . kar
From: Subarna Kar This patch is to allow i40e to match on outer and inner headers for tunneled packets (MPLSoGRE, MPLSoUDP, VXLAN) and perform actions like RSS, MARK Signed-off-by: Subarna Kar --- drivers/net/i40e/i40e_ethdev.c | 12 +- drivers/net/i40e/i40e_ethdev.h | 109 +- drivers/net

[dpdk-dev] [PATCH 2/2] test/compress: use bulk free operations api

2018-11-19 Thread Fiona Trahe
Use the new rte_comp_op_bulk_free API. Add trace to catch any mempool elements not freed at test end. Signed-off-by: Fiona Trahe --- test/test/test_compressdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/test/test/test_compressdev.c b/test/test/test_com

[dpdk-dev] [PATCH 0/2] compressdev: add bulk op free API

2018-11-19 Thread Fiona Trahe
Add API to bulk free operations and use it in the unit test suite. Fiona Trahe (2): compressdev: add api to bulk free ops test/compress: use bulk free operations api lib/librte_compressdev/rte_comp.c | 12 lib/librte_compressdev/rte_comp.h | 14

[dpdk-dev] [PATCH 1/2] compressdev: add api to bulk free ops

2018-11-19 Thread Fiona Trahe
There's an API to bulk allocate operations, this adds a corresponding bulk free API. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.c | 12 lib/librte_compressdev/rte_comp.h | 14 ++ lib/librte_compressdev/rte_compressde

Re: [dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1

2018-11-19 Thread Mody, Rasesh
Hi Ferruh, >From: Ferruh Yigit >Sent: Monday, November 19, 2018 5:28 AM > >On 11/17/2018 9:37 AM, Mody, Rasesh wrote: >> Signed-off-by: Rasesh Mody > >Hi Rasesh, > >18.11-rc4 is out and this patchset was late for it, I suggest postponing >previous >patch, `cleanup info logs`, in to next release

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2018-11-19 Thread Burakov, Anatoly
On 19-Nov-18 11:20 AM, Shahaf Shuler wrote: Thursday, November 15, 2018 1:00 PM, Burakov, Anatoly: Subject: Re: [RFC] ethdev: introduce DMA memory mapping for external memory On 15-Nov-18 9:46 AM, Shahaf Shuler wrote: Wednesday, November 14, 2018 7:06 PM, Burakov, Anatoly: Subject: Re: [RFC]

Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Stephen Hemminger
On Mon, 19 Nov 2018 08:38:44 + Leah Tekoa wrote: > - link = dev->data->dev_link; > + memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link)); > If structure assignment and memcpy don't give same result, then you have a buggy compiler.

Re: [dpdk-dev] mlx5 under FreeBSD

2018-11-19 Thread Stephen Hemminger
On Mon, 19 Nov 2018 09:09:22 -0600 (CST) Mit Matelske wrote: > > Monday, November 19, 2018 1:23 AM, Mit Matelske: > >> Subject: Re: [dpdk-dev] mlx5 under FreeBSD > >> > >> > 15/11/2018 17:48, Mit Matelske: > >> >> Is anyone working to include support for the mlx5 PMD under FreeBSD? > >>

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2018-11-19 Thread Stephen Hemminger
On Thu, 15 Nov 2018 10:59:36 + "Burakov, Anatoly" wrote: > > Unfortunately it cannot be done at least w/ Mellanox. > > In Mellanox the kernel driver is the one which maps the memory. The mapping > > returns a key which identify a memory region which was just registered to > > the device. >

[dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation

2018-11-19 Thread Dekel Peled
Set MPLS label value in appropriate location at mplsoudp_encap_conf, so it is correctly copied to rte_flow_item_mpls. Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation") Cc: or...@mellanox.com Signed-off-by: Dekel Peled --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertio

Re: [dpdk-dev] mlx5 under FreeBSD

2018-11-19 Thread Mit Matelske
> Monday, November 19, 2018 1:23 AM, Mit Matelske: >> Subject: Re: [dpdk-dev] mlx5 under FreeBSD >> >> > 15/11/2018 17:48, Mit Matelske: >> >> Is anyone working to include support for the mlx5 PMD under FreeBSD? >> > >> > I think Stephen (Cc) looked at it. >> > >> >> I've started down this road by

[dpdk-dev] [PATCH v2] net/igb: fix LSC interrupt when using MSI-X

2018-11-19 Thread Player, Timmons
Take the 'other interrupt' into account when setting up MSI-X interrupts and use the proper mask when enabling it. Also, rearm the MSI-X vector after the LSC interrupt fires. This change allows both LSC and RXQ interrupts to work at the same time when using MSI-X interrupts. Signed-off-by: Timmon

[dpdk-dev] [PATCH] test/compress: improve debug trace setup

2018-11-19 Thread Lee Daly
This removes the magic number from the assignment of the engine variable, which is used in the debug trace. Signed-off-by: Lee Daly --- test/test/test_compressdev.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/test/test/test_compressdev.c b/test/test/test

Re: [dpdk-dev] [ovs-dev] Packet Drop Issue in OVS-DPDK L2FWD Application

2018-11-19 Thread Ian Stokes
On 11/18/2018 8:16 PM, vkrishnabhat k wrote: Hi Team, I am new to OVS and DPDK. While I am using l2fwd application with OVS and DPDK I am seeing packet drop issue in OVS bridge. Topology : My topology has Ubuntu machine (Ubuntu 18.04 LTS). I have installed Qemu-KVM 2.11.1 version. Also I am usi

Re: [dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1

2018-11-19 Thread Ferruh Yigit
On 11/17/2018 9:37 AM, Mody, Rasesh wrote: > Signed-off-by: Rasesh Mody Hi Rasesh, 18.11-rc4 is out and this patchset was late for it, I suggest postponing previous patch, `cleanup info logs`, in to next release (v19.02) But not sure about this patch, I guess this is to mark the changes in this

Re: [dpdk-dev] [PATCH v2] doc: document all EAL parameters in one place

2018-11-19 Thread Burakov, Anatoly
On 19-Nov-18 1:10 PM, Anatoly Burakov wrote: Currently, the most complete (but still incomplete) user guide for EAL command-line parameters resides in user guide for testpmd. This is wrong on multiple levels, and should not be the case. To fix it, we have to create a document that lists all supp

[dpdk-dev] [PATCH v2] doc: document all EAL parameters in one place

2018-11-19 Thread Anatoly Burakov
Currently, the most complete (but still incomplete) user guide for EAL command-line parameters resides in user guide for testpmd. This is wrong on multiple levels, and should not be the case. To fix it, we have to create a document that lists all supported EAL command-line arguments. However, beca

[dpdk-dev] [PATCH 2/2] doc: update Mellanox supported OFED version

2018-11-19 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx4.rst | 2 +- doc/guides/nics/mlx5.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst index 4a57c7a6aa..5326d916e1 100644 --- a/doc/guides/nics/mlx4.rst +++ b/doc/guides

[dpdk-dev] [PATCH 1/2] doc: update Mellanox release notes

2018-11-19 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/rel_notes/release_18_11.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index 32ff0e5c08..f66ade2a52 100644 --- a/doc/guides/rel_notes/release_18

Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Leah Tekoa
We had problems with the way it is currently written and it didn't work for us. We got zero in link.link_speed and the real value was not copied correctly. -Original Message- From: Ferruh Yigit Sent: November 19, 2018 1:44 PM To: Leah Tekoa ; dev@dpdk.org Cc: Ouyang Changchun Subject:

Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Ferruh Yigit
On 11/19/2018 8:38 AM, Leah Tekoa wrote: > From: Leah Tekoa > > memcpy should be used for copying rte_eth_link structure Why? > > Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue and VF") > > Signed-off-by: Leah Tekoa > --- > lib/librte_ethdev/rte_ethdev.c | 2 +- > 1 file changed, 1

[dpdk-dev] [Bug 109] Using the environment variable to get the filepath

2018-11-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=109 Bug ID: 109 Summary: Using the environment variable to get the filepath Product: DPDK Version: 17.11 Hardware: All OS: All Status: IN_PROGRESS Severity: minor

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2018-11-19 Thread Shahaf Shuler
Thursday, November 15, 2018 1:00 PM, Burakov, Anatoly: > Subject: Re: [RFC] ethdev: introduce DMA memory mapping for external > memory > > On 15-Nov-18 9:46 AM, Shahaf Shuler wrote: > > Wednesday, November 14, 2018 7:06 PM, Burakov, Anatoly: > >> Subject: Re: [RFC] ethdev: introduce DMA memory map

Re: [dpdk-dev] [PATCH] doc: document all EAL parameters in one place

2018-11-19 Thread Mcnamara, John
> -Original Message- > From: Rami Rosen [mailto:roszenr...@gmail.com] > Sent: Saturday, November 17, 2018 5:15 AM > To: Yigit, Ferruh > Cc: Burakov, Anatoly ; dev@dpdk.org; Mcnamara, > John ; Kovacevic, Marko > ; Richardson, Bruce > ; Lu, Wenzhuo ; Wu, > Jingjing ; Iremonger, Bernard > ;

[dpdk-dev] [Bug 108] There should be a NULL pointer check about the internal_config.hugefile_prefix

2018-11-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=108 Bug ID: 108 Summary: There should be a NULL pointer check about the internal_config.hugefile_prefix Product: DPDK Version: 17.11 Hardware: All OS: All St

[dpdk-dev] [PATCH v2] devbind: don't display non-existent device categories

2018-11-19 Thread Anatoly Burakov
If there aren't any devices of a particular category on user's system, we still display them, which is bad for usability. Fix devbind to not print out a category unless there are devices in it. Signed-off-by: Anatoly Burakov Reviewed-by: David Hunt --- Notes: v2: fix indentation usertools

Re: [dpdk-dev] [PATCH] doc: fix mismatch descriptorion

2018-11-19 Thread Kovacevic, Marko
> [dpdk-dev] [PATCH] doc: fix mismatch descriptorion Spelling mistake in the heading but that's fine it can be changed when applied. > This patch fixes the mismatch keyword in vhost_crypto sample application > guide. > > Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core") > Cc: sta

Re: [dpdk-dev] [PATCH] doc: document all EAL parameters in one place

2018-11-19 Thread Burakov, Anatoly
On 16-Nov-18 4:52 PM, Anatoly Burakov wrote: Currently, the most complete (but still incomplete) user guide for EAL command-line parameters resides in user guide for testpmd. This is wrong on multiple levels, and should not be the case. To fix it, we have to create a document that lists all supp

Re: [dpdk-dev] [PATCH 1/2] cryptodev: change queue pair configure structure

2018-11-19 Thread Zhang, Roy Fan
Hi Konstantin, Ah, sorry they are added by mistake. Will not happen in V2. Regards, fan > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, November 16, 2018 12:06 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH 1/2] cryptode

Re: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-19 Thread Zhang, Roy Fan
Hi Konstantin, Thanks for the review. Comments inline. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, November 16, 2018 2:32 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session > struct

Re: [dpdk-dev] [PATCH] vfio: fix build with Linux < 4.0

2018-11-19 Thread Burakov, Anatoly
On 18-Nov-18 9:29 PM, Thomas Monjalon wrote: drivers/bus/pci/linux/pci_vfio.c:45:23: error: ‘failure_handle_lock’ defined but not used Fixes: 8ffe73865124 ("vfio: add lock for hot-unplug failure handler") Cc: jia@intel.com Signed-off-by: Thomas Monjalon --- Applied immediately. Ack for

Re: [dpdk-dev] [PATCH] devbind: don't display non-existent device categories

2018-11-19 Thread Burakov, Anatoly
On 18-Nov-18 11:13 PM, Thomas Monjalon wrote: 13/11/2018 17:42, Anatoly Burakov: --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py +n_devs = len(dpdk_drv) + len(kernel_drv) + len(no_drv) + +# don't bother displaying anything if there are no devices +if n_devs == 0: +

Re: [dpdk-dev] [PATCH] doc: fix mismatch descriptorion

2018-11-19 Thread Maxime Coquelin
On 11/19/18 10:38 AM, Fan Zhang wrote: This patch fixes the mismatch keyword in vhost_crypto sample application guide. Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- doc/guides/sample_app_ug/vhost_crypto.rst | 2 +- 1 fi

[dpdk-dev] [PATCH] doc: fix mismatch descriptorion

2018-11-19 Thread Fan Zhang
This patch fixes the mismatch keyword in vhost_crypto sample application guide. Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- doc/guides/sample_app_ug/vhost_crypto.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Leah Tekoa
From: Leah Tekoa memcpy should be used for copying rte_eth_link structure Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue and VF") Signed-off-by: Leah Tekoa --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethd