Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs RSS hash field

2018-11-12 Thread Yongseok Koh
Please disregard this email. Shahaf already sent it on my behalf. Thanks, Yongseok > On Nov 12, 2018, at 11:32 PM, Yongseok Koh wrote: > > As mlx5_flow_hashfields_adjust() refers to flow->rss, actions must be > translated prior to items like in Verbs. Otherwise, hash fields are not > correctly

[dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs RSS hash field

2018-11-12 Thread Yongseok Koh
As mlx5_flow_hashfields_adjust() refers to flow->rss, actions must be translated prior to items like in Verbs. Otherwise, hash fields are not correctly set. Fixes: d02cb0691299 ("net/mlx5: add Direct Verbs translate actions") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh --- drivers/net/ml

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-12 Thread Sam
And what about rte_vhost_user_rx_burst and rte_vhost_user_tx_burst Sam 于2018年11月13日周二 下午3:17写道: > And what about vhost-user port? > > Sam 于2018年11月13日周二 下午3:16写道: > >> Hi all, >> >> As we know, ethernet frame must longer then 64B. >> >> So if I create rte_mbuf and fill it with just 60B data, wi

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-12 Thread Sam
And what about vhost-user port? Sam 于2018年11月13日周二 下午3:16写道: > Hi all, > > As we know, ethernet frame must longer then 64B. > > So if I create rte_mbuf and fill it with just 60B data, will > rte_eth_tx_burst add padding data, let the frame longer then 64B > > If it does, where is the code? >

[dpdk-dev] Where is the padding code in DPDK?

2018-11-12 Thread Sam
Hi all, As we know, ethernet frame must longer then 64B. So if I create rte_mbuf and fill it with just 60B data, will rte_eth_tx_burst add padding data, let the frame longer then 64B If it does, where is the code?

[dpdk-dev] [PATCH v2] net/ixgbe: fix ixgbevf link status

2018-11-12 Thread Yanglong Wu
For ixgbevf kernel driver, link status changes from down to up will trigger vf kernel driver send IXGBE_VF_RESET message to pf kernel driver, after this, vf kernel driver will disable and enable it self. By these series operations, the vf kernel driver report link up. Besides, all these operations

Re: [dpdk-dev] [PATCH] doc: document IPv6 multicast limitation on VM

2018-11-12 Thread Shahaf Shuler
Monday, November 12, 2018 1:31 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] doc: document IPv6 multicast limitation on VM > > This patch adds limitation notice for MLX5 PMD. > IPv6 multicast messages are not received on VM when promiscuous and > allmulticast modes are off, due to netlink restric

[dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs RSS hash field

2018-11-12 Thread Shahaf Shuler
From: Yongseok Koh As mlx5_flow_hashfields_adjust() refers to flow->rss, actions must be translated prior to items like in Verbs. Otherwise, hash fields are not correctly set. Fixes: d02cb0691299 ("net/mlx5: add Direct Verbs translate actions") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh

Re: [dpdk-dev] [PATCH] net/mlx5: restrict workaround of gcc AVX512F bug

2018-11-12 Thread Jerin Jacob
-Original Message- > Date: Tue, 13 Nov 2018 01:01:22 +0100 > From: Thomas Monjalon > To: dev@dpdk.org > Cc: ys...@mellanox.com, shah...@mellanox.com, ferruh.yi...@intel.com, > bruce.richard...@intel.com, konstantin.anan...@intel.com, > christian.ehrha...@canonical.com, justin.pa...@micro

Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-12 Thread Zhao1, Wei
Add Ophir Munk for discussion. > -Original Message- > From: Peng, Yuan > Sent: Tuesday, November 13, 2018 10:27 AM > To: Zhao1, Wei ; Adrien Mazarguil > > Cc: dev@dpdk.org > Subject: RE: FW: [PATCH] net/i40e: add parameter check for RSS flow init > > Hi, Adrien Mazarguil > > Yes. It's

[dpdk-dev] Recall: FW: [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-12 Thread Peng, Yuan
Peng, Yuan would like to recall the message, "FW: [PATCH] net/i40e: add parameter check for RSS flow init".

Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-12 Thread Peng, Yuan
Hi, Adrien Mazarguil Yes. It's just the problem related to commit a4391f8bae85db0153e1f101c21c61151573baad "app/testpmd: set default RSS key as null". You can check the detailed bug information from https://jira01.devtools.intel.com/browse/DPDK-7136?filter=-2 Thank you. Yuan. -Original Me

Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-12 Thread Zhao1, Wei
Hi, Adrien Mazarguil Peng yuan has find this problem, if you use the following test step, You will find the problem. ./x86_64-native-linuxapp-gcc/app/testpmd -c 1 -n 4 - -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained ... testpmd> start testpmd> flow create 0 in

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-12 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, November 10, 2018 5:10 AM > To: Andrew Rybchenko ; Lu, Wenzhuo > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration > enhancement > > On 11/8/2018 6:25 AM, Andrew Rybchenko wrote: >

Re: [dpdk-dev] [PATCH] net/mlx5: restrict workaround of gcc AVX512F bug

2018-11-12 Thread Thomas Monjalon
13/11/2018 01:14, Stephen Hemminger: > On Mon, Nov 12, 2018, 4:01 PM Thomas Monjalon > > A bug was found when the inline function mlx5_tx_complete() > > is optimized with AVX512F instructions. It corrupts an offset > > in the instructions vmovdqu8 of the AVX2 version of rte_mov128(), > > used in

Re: [dpdk-dev] [PATCH] net/mlx5: restrict workaround of gcc AVX512F bug

2018-11-12 Thread Stephen Hemminger
The additional annotations clutter the code. How big a performance hit is it to disable for whole driver? Or just use memcpy instead of rte_memcpy? On Mon, Nov 12, 2018, 4:01 PM Thomas Monjalon A bug was found when the inline function mlx5_tx_complete() > is optimized with AVX512F instructions. I

[dpdk-dev] [PATCH] net/mlx5: restrict workaround of gcc AVX512F bug

2018-11-12 Thread Thomas Monjalon
A bug was found when the inline function mlx5_tx_complete() is optimized with AVX512F instructions. It corrupts an offset in the instructions vmovdqu8 of the AVX2 version of rte_mov128(), used in rte_memcpy(), which is called in rte_mempool_put_bulk(). All the above functions are inline. So the wo

[dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-12 Thread Burdick, Cliff
This patch was submitted by Jean Tourrilhes over two years ago, but didn't receive any responses. I hit the same issue recently when trying to use cgo (Golang) as a primary process linked to libdpdk.a against a C++ application linked against the same library. The history of the patch is here: h

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-12 Thread Trahe, Fiona
Correction below > -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 4:17 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; > Doherty, Declan ; Ravi Kumar ; > Jerin Jacob > ; Zhang, Roy Fan ; > Tomasz Duszynski > ; Hemant A

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-12 Thread Trahe, Fiona
RE item 4: use of session pool in qp setup: > > 4.#2 and #3 above implies that now each struct rte_cryptodev_sym_session > > would have sort of readonly type data (init once at allocation time, > > keep unmodified through session life-time). > > That requires more changes in current cryptodev

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-12 Thread Ananyev, Konstantin
> -Original Message- > From: Lipiec, Herakliusz > Sent: Monday, November 12, 2018 8:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Lipiec, Herakliusz > > Subject: [PATCH] example/ipv4_multicast: fix app hanging when using clone > > This example was dropping packets when using cl

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-12 Thread Trahe, Fiona
Hi Konstantin, Sorry for the delay in reviewing this and thanks for your proposals. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, August 24, 2018 10:48 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; De Lara Guarch, Pablo > ; Akhil Goyal ; Doherty, > Declan > ; Ravi K

[dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-12 Thread Herakliusz Lipiec
This example was dropping packets when using clone (ip 224.0.0.103). The problem was that mbufs were not freed. This was caused by coping ol_flags from cloned mbuf to header mbufs. Signed-off-by: Herakliusz Lipiec --- examples/ipv4_multicast/main.c | 2 -- 1 file changed, 2 deletions(-) diff --

[dpdk-dev] [PATCH 4/4] net/mlx5: add E-switch rule hardware offload flag check

2018-11-12 Thread Slava Ovsiienko
This patch adds the in_hw flag check for tc flower filter rules. If rule is applied without skip_sw flag set driver should check whether the in_hw flag is set after rule applying. If no in_hw flag set found it means the rule is not hardware offloaded and error should be returned to application. Si

[dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine

2018-11-12 Thread Slava Ovsiienko
While receiving the Netlink reply messages we should stop at DONE or ACK message. The existing implementation stops at DONE message or if no multiple message flag set ( NLM_F_MULTI). It prevents the single query requests from working, these requests send the single reply message without multi-messa

[dpdk-dev] [PATCH 3/4] net/mlx5: prepare to add E-switch rule flags check

2018-11-12 Thread Slava Ovsiienko
The tc flower filter rules are used to control E-switch from the application side. In order to gain garanteed rule hardware offload the skip_sw flag should be specified while applying the rule. But some tc rules is rejected by kernel if skip_sw flag is set by design. Currently this regards VXLAN tu

[dpdk-dev] [PATCH 1/4] net/mlx5: prepare Netlink communication routine to fix

2018-11-12 Thread Slava Ovsiienko
This patch removes the unused message length parameter, we do not send multiple commands in the single message anymore, message length can be taken from the prepared message header, so length parameter can be removed. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_tcf.c | 38

[dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check

2018-11-12 Thread Slava Ovsiienko
The tc flower filter rules are used to control E-switch from the application side. In order to gain garanteed rule hardware offload the skip_sw flag should be specified while applying the rule. Some tc rules is rejected by kernel if skip_sw flag is set by design. Currently this regards VXLAN tunnel

Re: [dpdk-dev] [Bug 106] running dpdk-procinfo or any secondary leading to system memory exhaustion

2018-11-12 Thread Mattias Rönnblom
On 2018-11-12 11:44, bugzi...@dpdk.org wrote: https://bugs.dpdk.org/show_bug.cgi?id=106 Bug ID: 106 Summary: running dpdk-procinfo or any secondary leading to system memory exhaustion Product: DPDK Version: 18.05 Ha

Re: [dpdk-dev] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-12 Thread Honnappa Nagarahalli
> > From: Yipeng Wang > > This patch adds back the local cache when TSX support is turned on. > > When TSX is turned on, free key-data slot ring would be contended by various > TSX regions. The purpose of this commit is to reduce possible memory > collisions during key insertion. > > Signed-of

[dpdk-dev] [PATCH] net/qede: fix Tx tunnel offload notsup mask

2018-11-12 Thread Mody, Rasesh
From: Shahed Shaikh Tunneling offloads are represented by multi-bit values. So, feature wise tunneling offload can only be entirely supported/unsupported using PKT_TX_TUNNEL_MASK. Its upon PMDs to further isolate which of the tunneling offload types are supported by respective PMD. Using subset o

[dpdk-dev] [PATCH v2] crypto/octeontx: fix coverity issues

2018-11-12 Thread Anoob Joseph
Coverity Issue: 323492 If the length of string pointed by 'name' is equal to or greater than the sizeof cptvf->dev_name string, the resultant string will not be null terminated. Using strlcpy would make sure the string would always be null terminated. Fixes: 0dc1cffa4d33 ("crypto/octeontx: add ha

[dpdk-dev] [PATCH] net/octeontx: fix mbuf corruption with larger priv sizes

2018-11-12 Thread Anoob Joseph
From: Nitin Saxena When the priv_size of the mbuf is > 128 bytes, the mbuf would not be properly constructed. This would lead to a corrupt mbuf. This patch fixes the issue by accounting for rte_pktmbuf_priv_size(pool) and RTE_PKTMBUF_HEADROOM while configuring first skip register calculation. F

Re: [dpdk-dev] [dpdk-techboard] DPDK techboard minutes of October 24

2018-11-12 Thread Thomas Monjalon
12/11/2018 17:43, Stephen Hemminger: > On Mon, 12 Nov 2018 12:36:45 + > "Ananyev, Konstantin" wrote: > > From: Richardson, Bruce > > > From: techboard [mailto:techboard-boun...@dpdk.org] On Behalf Of Ananyev, > > > > Konstantin > > > > > > > > Hi Anatoly, > > > > > > > > > > Meeting notes fo

[dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-12 Thread Qi Zhang
Private vdev on secondary is never supported by the new shared device mode but pdump still relies on a private pcap PMD on secondary. The patch enables pcap PMD's data path on secondary so that pdump can work as usual. Signed-off-by: Qi Zhang Tested-by: Yufeng Mo --- v2: - fix init issue when

[dpdk-dev] [pull-request] next-pipeline 18.11 PRE-RC3

2018-11-12 Thread Cristian Dumitrescu
eal: fix build (2018-11-12 13:27:02 +0100) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 7c7ba8477d28cac7a168d91cbd29356851bebc6d: app/testpmd: fix memory alloc for DSCP table (2018-11-12 16:45:32 +) --

Re: [dpdk-dev] [dpdk-techboard] DPDK techboard minutes of October 24

2018-11-12 Thread Stephen Hemminger
On Mon, 12 Nov 2018 12:36:45 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, November 12, 2018 12:22 PM > > To: Ananyev, Konstantin ; Burakov, Anatoly > > ; Jerin Jacob > > ; dev@dpdk.org > > Cc: techbo...@dpdk.org > > Subject: RE:

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix memory alloc for dscp table

2018-11-12 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Tuesday, November 6, 2018 10:27 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yigit, Ferruh ; Wu, Jingjing > ; Iremonger, Bernard > > Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix memory

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix null pointer deref

2018-11-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, November 9, 2018 4:12 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/ip_pipeline: fix null pointer deref > > Fixes null pointer dereference issue raised by coverity. > > Coverity issue: 325728,

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak for tm object

2018-11-12 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Tuesday, November 6, 2018 10:23 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yigit, Ferruh ; Wu, Jingjing > ; Iremonger, Bernard > > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix memory

Re: [dpdk-dev] [PATCH] lib/pipeline: fix logically dead code

2018-11-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, November 5, 2018 12:27 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] lib/pipeline: fix logically dead code > > This patches fixes the coverity issue of logically dead code. > > Fixes: 96303217a606 ("pipe

Re: [dpdk-dev] [PATCH] drivers/net: set close behaviour flag at probing

2018-11-12 Thread Ferruh Yigit
On 11/12/2018 9:42 AM, Luca Boccassi wrote: > On Sun, 2018-11-11 at 23:46 +0100, Thomas Monjalon wrote: >> The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers >> having migrated to the new behaviour of rte_eth_dev_close(). >> >> As any other flag, it can be useful to know about its value >>

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: revert setting default RSS

2018-11-12 Thread Ferruh Yigit
On 11/9/2018 9:38 AM, Ophir Munk wrote: > This reverts the patch that enables default RSS action by setting > key=NULL and key_len=0. > In current testpmd implementation a key pointer must exist if > key_len!=0. For example, the following flow rule will cause a > segmentation fault: > flow create 0

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix set L4 len for UDP packets

2018-11-12 Thread Ferruh Yigit
On 11/11/2018 3:31 PM, Raslan Darawsheh wrote: > testpmd only sets the L4 len in case of TCP packets. > some PMD's like tap rely on mbuf meta data to calculate csum > > this will set the L4 len for UDP packets same as TCP > > Fixes: 160c3dc9 ("app/testpmd: introduce IP parsing functions in csum f

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix queue pair free

2018-11-12 Thread Akhil Goyal
On 10/16/2018 3:15 PM, Fan Zhang wrote: > This patch fixes the queue pair free for AESNI-MB PMD. Originally > the queue pair ring name are different than the object name, > caused the aesni_mb_pmd_qp_release() cannot find the ring to > release. This patch uses the same name between queue pair obj

Re: [dpdk-dev] [PATCH] crypto/ccp: fix resource leak

2018-11-12 Thread Akhil Goyal
On 11/4/2018 10:20 AM, Kumar, Ravi1 wrote: >> File *fp, opened but not closed, this patch add fclose(fp) >> >> Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Ferruh Yigit >> --- >> drivers/crypto/ccp/ccp_pci.c | 5 - >> 1 file changed, 4 in

Re: [dpdk-dev] [dpdk-techboard] DPDK techboard minutes of October 24

2018-11-12 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Monday, November 12, 2018 12:22 PM > To: Ananyev, Konstantin ; Burakov, Anatoly > ; Jerin Jacob > ; dev@dpdk.org > Cc: techbo...@dpdk.org > Subject: RE: [dpdk-techboard] [dpdk-dev] DPDK techboard minutes of October 24 > > > > > --

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] eal: fix build issue

2018-11-12 Thread Thomas Monjalon
07/11/2018 07:59, Jerin Jacob: > Some toolchain has fls() definition in string.h as argument type int, > which is conflicting uint32_t argument type. > > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: > error: conflicting types for ‘fls’ > static inline int fls(uint32_t x) >

[dpdk-dev] [PATCH v2] mk: allow renaming of build directories

2018-11-12 Thread Bruce Richardson
When building using make, the Makefile in the build directory contained the name of the build directory to be passed as an "O=" parameter to the DPDK SDK makefiles. Unfortunately, this meant that the compilation would always fail if the build directory was renamed. To remove this limitation, we can

Re: [dpdk-dev] [dpdk-techboard] DPDK techboard minutes of October 24

2018-11-12 Thread Richardson, Bruce
> -Original Message- > From: techboard [mailto:techboard-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Monday, November 12, 2018 11:24 AM > To: Burakov, Anatoly ; Jerin Jacob > ; dev@dpdk.org > Cc: techbo...@dpdk.org > Subject: Re: [dpdk-techboard] [dpdk-dev] DPDK techboard

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/qede: fix crash when configure fails

2018-11-12 Thread Ferruh Yigit
On 11/10/2018 12:39 AM, Mody, Rasesh wrote: >> From: Timothy Redaelli >> Sent: Friday, November 09, 2018 7:46 AM >> >> Currently, if configuration fails (for example if a 100G card is used with >> an odd >> number of RX/TX queues) QEDE crashes due to a null pointer dereference. >> >> This commit

Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-12 Thread Akhil Goyal
On 10/11/2018 7:50 PM, Konstantin Ananyev wrote: > Below are details and reasoning for proposed changes. > > 1.rte_cryptodev_sym_session_init()/ rte_cryptodev_sym_session_clear() >operate based on cytpodev device id, though inside >rte_cryptodev_sym_session device specific data is address

Re: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing

2018-11-12 Thread Akhil Goyal
Hi Anoob, On 11/12/2018 4:53 PM, Joseph, Anoob wrote: > Hi Akhil, > > You can squash the entire series. Or should I send a revised patch? Either > way is fine. You can send a revised patch with coverity ID and appropriate patch description for all the issues resolved here. -Akhil

[dpdk-dev] [PATCH] doc: document IPv6 multicast limitation on VM

2018-11-12 Thread Dekel Peled
This patch adds limitation notice for MLX5 PMD. IPv6 multicast messages are not received on VM when promiscuous and allmulticast modes are off, due to netlink restriction. Signed-off-by: Dekel Peled --- doc/guides/nics/mlx5.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/

Re: [dpdk-dev] [dpdk-stable] [PATCH 17.11] mem: fix memory initialization time

2018-11-12 Thread Eelco Chaudron
On 12 Nov 2018, at 12:18, Alejandro Lucero wrote: When using large amount of hugepage based memory, doing all the hugepages mapping can take quite significant time. The problem is hugepages being initially mmaped to virtual addresses which will be tried later for the final hugepage mmaping.

Re: [dpdk-dev] [dpdk-techboard] DPDK techboard minutes of October 24

2018-11-12 Thread Ananyev, Konstantin
Hi Anatoly, > > Meeting notes for the DPDK technical board meeting > > held on 2018-10-24 > > > > Attendees: > > - Bruce Richardson > > - Ferruh Yigit > > - Hemant Agrawal > > - Jerin Jacob > > - Konstantin Ananyev > > - Maxime Coquelin > >

Re: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing

2018-11-12 Thread Joseph, Anoob
Hi Akhil, You can squash the entire series. Or should I send a revised patch? Either way is fine. Anoob > -Original Message- > From: Akhil Goyal > Sent: 12 November 2018 16:51 > To: Joseph, Anoob ; Pablo de Lara > > Cc: Joseph, Anoob ; Jacob, Jerin > ; Athreya, Narayana Prasad > ; Dwi

Re: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing

2018-11-12 Thread Akhil Goyal
Hi Anoob, On 11/11/2018 8:54 PM, Anoob Joseph wrote: > Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton") > > Signed-off-by: Anoob Joseph > --- > drivers/crypto/octeontx/otx_cryptodev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/octeontx/otx_

[dpdk-dev] [PATCH 17.11] mem: fix memory initialization time

2018-11-12 Thread Alejandro Lucero
When using large amount of hugepage based memory, doing all the hugepages mapping can take quite significant time. The problem is hugepages being initially mmaped to virtual addresses which will be tried later for the final hugepage mmaping. This causes the final mapping requiring calling mmap wit

[dpdk-dev] [PATCH v2 4/4] test/test: improve output for hash read-write test

2018-11-12 Thread Bruce Richardson
The hash read-write autotest generates a lot of text, which is very dense on the screen. Even the summary at the end is hard to follow as everything is very compact. We can improve readability by highlighting the starts of the various sections, and by indenting the values within subsections. Signe

[dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX

2018-11-12 Thread Bruce Richardson
When testing with rte_hash library and TSX, a higher level of transaction aborts was observed in some cases, especially with newer compilers. These patches reduce aborts by ensuring that the compiler does not accidentally insert instructions that cause aborts, and by adding in delays on retry to a

[dpdk-dev] [PATCH v2 3/4] eal/x86: reduce contention when retrying TSX

2018-11-12 Thread Bruce Richardson
When TSX transactions abort, it is generally worth retrying a number of times before falling back to the traditional locking path, as the parallelism benefits from TSX can be worth it when a transaction does succeed. For cases with multiple threads and high contention rates, it can be useful to hav

[dpdk-dev] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-12 Thread Bruce Richardson
From: Yipeng Wang This patch adds back the local cache when TSX support is turned on. When TSX is turned on, free key-data slot ring would be contended by various TSX regions. The purpose of this commit is to reduce possible memory collisions during key insertion. Signed-off-by: Yipeng Wang Ac

[dpdk-dev] [PATCH v2 1/4] hash: fix TSX aborts with newer gcc

2018-11-12 Thread Bruce Richardson
From: Yipeng Wang gcc 7 and 8 with O3 will generate vzeroupper from rte_memcpy into TSX region which may abort the TSX transaction. This fix changes rte_memcpy to memcpy which will not insert extra vzeroupper into the library. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: sta

[dpdk-dev] [Bug 106] running dpdk-procinfo or any secondary leading to system memory exhaustion

2018-11-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=106 Bug ID: 106 Summary: running dpdk-procinfo or any secondary leading to system memory exhaustion Product: DPDK Version: 18.05 Hardware: x86 OS: Linux Stat

Re: [dpdk-dev] [PATCH] net/mlx5: fix MPLS item validation

2018-11-12 Thread Ori Kam
PSB > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, November 12, 2018 11:20 AM > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; Ori Kam > Subject: [dpdk-dev] [PATCH] net/mlx5: fix MPLS item validation > > Update the mlx5_flow_validate_item_mpls() funct

[dpdk-dev] [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-12 Thread Wei Zhao
There need an parameter check for RSS flow init, or it may cause core dump if pointer is NULL in memory copy. Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-

Re: [dpdk-dev] [PATCH] drivers/net: set close behaviour flag at probing

2018-11-12 Thread Luca Boccassi
On Sun, 2018-11-11 at 23:46 +0100, Thomas Monjalon wrote: > The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers > having migrated to the new behaviour of rte_eth_dev_close(). > > As any other flag, it can be useful to know about its value > as soon as the port is probed. > Unfortunately, i

Re: [dpdk-dev] DPDK techboard minutes of October 24

2018-11-12 Thread Burakov, Anatoly
On 10-Nov-18 9:18 AM, Jerin Jacob wrote: Meeting notes for the DPDK technical board meeting held on 2018-10-24 Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Maxime Coquelin - Olivi

Re: [dpdk-dev] [PATCH] pci: fix parsing of address without function number

2018-11-12 Thread Gaëtan Rivet
On Mon, Nov 12, 2018 at 12:58:56AM +0100, Thomas Monjalon wrote: > If the last part of the PCI address (function number) is missing, > the parsing was successful, assuming function 0. > The call to strtoul is not returning an error in such a case, > so an explicit check is inserted before. > > Thi

Re: [dpdk-dev] [dpdk-stable] AVX512 bug on SkyLake

2018-11-12 Thread Ananyev, Konstantin
> 11/11/2018 15:15, Ananyev, Konstantin: > > Hi Thomas, > > > > > Below is my conclusion for this bug. > > > An expert of x86 is required to follow-up. > > > > > > Summary: > > > - CPU: Intel Skylake > > > - Linux environment: Ubuntu 18.04 > > > - Compiler: GCC 7 or 8 > > > - Scenario: te

Re: [dpdk-dev] [dpdk-stable] AVX512 bug on SkyLake

2018-11-12 Thread Thomas Monjalon
12/11/2018 10:09, Christian Ehrhardt: > > -vmovdqu8 xmm0,XMMWORD PTR [rax*8+0x6] > > +vmovdqu xmm0,XMMWORD PTR [rax*8+0x60] > > vinserti128 ymm0,ymm0,XMMWORD PTR [rax*8+0x70],0x1 > > vmovups XMMWORD PTR [rsi+0x60],xmm0 > > vextracti128 XMMWORD PTR [rsi+0x70],ymm0,0x1 > > > >

[dpdk-dev] [PATCH] net/mlx5: fix MPLS item validation

2018-11-12 Thread Dekel Peled
Update the mlx5_flow_validate_item_mpls() function to allow MPLS over UDP as well as MPLS over IP. Fixes: 84c406e74524 ("net/mlx5: add flow translate function") Cc: or...@mellanox.com Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deleti

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-12 Thread Burakov, Anatoly
On 10-Nov-18 11:03 AM, Rami Rosen wrote: HI Anatoly, Do all other distros have lspci in package called pciutils? If not, i prefer to keep it the way it is. Your original patch have: +if ret != 0: +print("'lspci' not found - please install 'lspci'") And I suggest to consi

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] eal: fix build issue

2018-11-12 Thread Thomas Monjalon
12/11/2018 10:01, Ferruh Yigit: > On 11/12/2018 4:50 AM, Jerin Jacob wrote: > > -Original Message- > >> Date: Mon, 12 Nov 2018 02:37:15 +0100 > >> From: Thomas Monjalon > >> To: Jerin Jacob > >> Cc: sta...@dpdk.org, "dev@dpdk.org" , Qi Zhang > >> , Xiao Wang , > >> "sthem...@microsoft.c

Re: [dpdk-dev] [dpdk-stable] AVX512 bug on SkyLake

2018-11-12 Thread Christian Ehrhardt
> -vmovdqu8 xmm0,XMMWORD PTR [rax*8+0x6] > +vmovdqu xmm0,XMMWORD PTR [rax*8+0x60] > vinserti128 ymm0,ymm0,XMMWORD PTR [rax*8+0x70],0x1 > vmovups XMMWORD PTR [rsi+0x60],xmm0 > vextracti128 XMMWORD PTR [rsi+0x70],ymm0,0x1 > > > Not sure what causing compiler behaves that way. >

Re: [dpdk-dev] 答复: [PATCH v2] mem: accelerate dpdk program startup by reuse page from page cache

2018-11-12 Thread Burakov, Anatoly
On 11-Nov-18 2:19 AM, 范建明 wrote: Hi, Burakov Thanks very much for your reply. I run the testpmd dpdk18.08 on my router with 200GB huge page configured. And find it still takes 50s in zeroing the 200GB huge page each time the program restarts. As you mentioned app shall cal

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] eal: fix build issue

2018-11-12 Thread Ferruh Yigit
On 11/12/2018 4:50 AM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 12 Nov 2018 02:37:15 +0100 >> From: Thomas Monjalon >> To: Jerin Jacob >> Cc: sta...@dpdk.org, "dev@dpdk.org" , Qi Zhang >> , Xiao Wang , >> "sthem...@microsoft.com" , "shaopeng...@intel.com" >> , "Jacob, Jeri