[dpdk-dev] [PATCH] net/e1000: fix uninitialized variables

From: Yunjian Wang This patch fixes the variable 'phy_word' may be used uninitialized. Fixes: 5b6439cf03a4ca3 ("e1000/base: support different EEARBC for i210") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/e1000/base/e1000_i210.c | 1 + 1 file changed, 1 insertion(+) diff -

[dpdk-dev] [PATCH] net/mlx5: fix misuse of device flow reference

dev_flow->verbs is mistakenly used instead of dev_flow->dv. A sanity check is added for debugging purpose. Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 37 +

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

On 10/22/18 3:13 PM, Thomas Monjalon wrote: 22/10/2018 14:01, Ferruh Yigit: On 8/23/2018 9:58 AM, Andrew Rybchenko wrote: On 22.08.2018 19:55, Ferruh Yigit wrote: On 8/14/2018 1:57 AM, Lu, Wenzhuo wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko [mailto:arybche...@solarfl

[dpdk-dev] [PATCH] doc/linux_gsg: fix numa lib name error

The library for handling NUMA is numactl-devel, not libnuma-devel. Signed-off-by: Yong Wang --- doc/guides/linux_gsg/sys_reqs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst index e2230f3..1cb14b5 1006

[dpdk-dev] [PATCH 1/2] vhost: fix IOVA access for packed ring

We should apply for RO access when receiving packets from the VM and apply for RW access when sending packets to the VM. Fixes: a922401f35cc ("vhost: add Rx support for packed ring") Fixes: ae999ce49dcb ("vhost: add Tx support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- l

[dpdk-dev] [PATCH 2/2] net/virtio-user: fix typo in error message

The param we are checking is VIRTIO_USER_ARG_PATH, instead of VIRTIO_USER_ARG_QUEUE_SIZE. Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost

Tiwei Bie (2): vhost: fix IOVA access for packed ring net/virtio-user: fix typo in error message drivers/net/virtio/virtio_user_ethdev.c | 2 +- lib/librte_vhost/virtio_net.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.19.1

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix callback issue for hot-unplug

Hi Jeff From: Jeff Guo > Before detach device when device be hot-unplugged, the failure process in > user space and kernel space both need to be finished, such as eal interrupt > callback need to be inactive before the callback be unregistered when device > is being cleaned. This patch add rte a

[dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting

The tx offloads should be compared to tx capability Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap") Cc: or...@mellanox.com Cc: wei.zh...@intel.com Signed-off-by: Ori Kam --- examples/flow_filtering/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH 2/3] vfio: fix to add handler lock for hot-unplug

Hi Jeff Can you detail more in the commit log that we can understand the synchronization problematic scenario. And how does this commit fix it? > -Original Message- > From: Jeff Guo > Sent: Tuesday, November 6, 2018 8:07 AM > To: konstantin.anan...@intel.com; anatoly.bura...@intel.com

Re: [dpdk-dev] [PATCH 1/3] eal: fix lock issue for hot-unplug

Hi Jeff Can you detail more in the commit log that we can understand the deadlock scenario. And how does this commit fix it? > -Original Message- > From: Jeff Guo > Sent: Tuesday, November 6, 2018 8:07 AM > To: konstantin.anan...@intel.com; anatoly.bura...@intel.com; Thomas > Monjalon

Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write concurrency

> > > > > > Add lock-free read-write concurrency. This is achieved by the > > > following changes. > > > > > > 1) Add memory ordering to avoid race conditions. The only race > > > condition that can occur is - using the key store element before > > > the key write is completed. Hence, while insert

[dpdk-dev] [PATCH 2/3] vfio: fix to add handler lock for hot-unplug

This patch add hot-unplug handler lock and unlock in device request handler when process bus and device resource, in order to avoid the synchronization issue when device be hot-unplugged. Fixes: c115fd000c32 ("vfio: handle hotplug request notifier") Signed-off-by: Jeff Guo --- drivers/bus/pci/li

[dpdk-dev] [PATCH 3/3] app/testpmd: fix callback issue for hot-unplug

Before detach device when device be hot-unplugged, the failure process in user space and kernel space both need to be finished, such as eal interrupt callback need to be inactive before the callback be unregistered when device is being cleaned. This patch add rte alarm for device detaching, with th

[dpdk-dev] [PATCH 1/3] eal: fix lock issue for hot-unplug

This patch will add missing unlock for hot-unplug handler, without this patch potential dead lock will occur when device be hotplug-in after device be hot-unplugged. Fixes: 0fc54536b14a ("eal: add failure handling for hot-unplug") Signed-off-by: Jeff Guo --- lib/librte_eal/linuxapp/eal/eal_dev.c

[dpdk-dev] [PATCH 0/3] fix vfio hot-unplug issue

This patch set aim to fix some dead lock issue when device be hotplug-in after device be hot-unplugged for vfio. Jeff Guo (3): eal: fix lock issue for hot-unplug vfio: fix to add handler lock for hot-unplug app/testpmd: fix callback issue for hot-unplug app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v2] bus/pci: update device devargs on each rescan

From: Darek Stojaczyk Bus rescan is done e.g. during the device hotplug, where devargs are re-allocated. By not updating the rte_device->devargs pointer we potentially make it a dangling one, as previous devargs could have been (or will be soon) freed. Fixes: 55e411b301c3 ("bus/pci: fix resource

[dpdk-dev] [PATCH v2] app/proc-info:fix port mask parse bug

parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Signed-off-by: Li Han --- v2:fix typecast i

[dpdk-dev] [dpdk-announce] release candidate 18.11-rc2

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v18.11-rc2 145 patches were integrated. This version should be more stable, as we are approaching the 18.11.0 release date, hopefully in two weeks. The release notes should be almost complete: htt

Re: [dpdk-dev] [PATCH v2] net/ixgbe: check jumbo frame enable parameter

> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, November 6, 2018 12:34 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; yamashita.hidey...@po.ntt-tx.co.jp; > step...@networkplumber.org > Subject: RE: [PATCH v2] net/ixgbe: check jumbo frame enable parameter > > Hi Wei:

[dpdk-dev] [PATCH v4 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

[dpdk-dev] [PATCH v4 9/9] doc/procinfo: add information for debug options

Document update for debug options and information for PMD instances like port, traffic manager, crypto, mempool and ring instances. Signed-off-by: Vipin Varghese --- V3: - update document from dbg to show - Vipin Varghese V2: - update word style for content - Vipin Varghese --- doc/guides/to

[dpdk-dev] [PATCH v4 6/9] app/procinfo: add support for show crypto

Function show_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- v4: - add space to compare - Vipin Varghese V3: - replace MACRO to function - Reshma Pathan & Stephen Hemminger - add memset for struct elements - Reshma Pathan - change d

[dpdk-dev] [PATCH v4 7/9] app/procinfo: add support for debug ring

Function show_ring is used for displaying the RING of the primary process. Signed-off-by: Vipin Varghese --- V3: - replace space to tab in printf - Reshma Pathan - change ring display information - Vipin Varghese --- app/proc-info/main.c | 34 +- 1 file changed

[dpdk-dev] [PATCH v4 3/9] app/procinfo: add prototype for debug instances

Add prototype function calls for the show functions. Signed-off-by: Vipin Varghese --- V3: - update function names from debug to show - Vipin Varghese V2: - removed if else ladder - Vipin Varghese --- app/proc-info/main.c | 42 ++ 1 file changed, 42 in

[dpdk-dev] [PATCH v4 4/9] app/procinfo: add support for show port

Function show_port is used for displaying the port PMD information under under primary process. The information shows basic, per queue and security. Signed-off-by: Vipin Varghese --- V3: - fix meson build - Reshma Pattan - change 100 to MAX_STRING_LEN - Reshma Pattan - memset to struct elemen

[dpdk-dev] [PATCH v4 1/9] app/procinfo: add usage for new debug

Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- V3: - change the usage details - Vipin Varghese V2: - change word dbg to show - Stephen Hemminger --- app/proc-info/main.c | 16 +++- 1 file changed, 15 i

[dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with stats. Signed-off-by: Vipin Varghese --- V3: - memset for struct elements - Vipin Varghese - code cleanup for TM - Vipin Varghese - fetch for leaf nodes if node exis

[dpdk-dev] [PATCH v4 2/9] app/procinfo: add compare for new options

Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- V3: - variables from debug to show - Vipin Varghese V2: - compare string from dbg to show - Stephen Hemminger --- app/proc-info/main.c | 30 ++ 1 file ch

[dpdk-dev] [PATCH v5 9/9] doc/procinfo: add information for debug options

Document update for debug options and information for PMD instances like port, traffic manager, crypto, mempool and ring instances. Signed-off-by: Vipin Varghese --- V3: - update document from dbg to show - Vipin Varghese V2: - update word style for content - Vipin Varghese --- doc/guides/to

[dpdk-dev] [PATCH v5 7/9] app/procinfo: add support for debug ring

Function show_ring is used for displaying the RING of the primary process. Signed-off-by: Vipin Varghese --- V3: - replace space to tab in printf - Reshma Pathan - change ring display information - Vipin Varghese --- app/proc-info/main.c | 34 +- 1 file changed

[dpdk-dev] [PATCH v5 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

[dpdk-dev] [PATCH v5 6/9] app/procinfo: add support for show crypto

Function show_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- v4: - add space to compare - Vipin Varghese V3: - replace MACRO to function - Reshma Pathan & Stephen Hemminger - add memset for struct elements - Reshma Pathan - change d

[dpdk-dev] [PATCH v5 5/9] app/procinfo: add support for show tm

Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with stats. Signed-off-by: Vipin Varghese --- V3: - memset for struct elements - Vipin Varghese - code cleanup for TM - Vipin Varghese - fetch for leaf nodes if node exis

[dpdk-dev] [PATCH v5 4/9] app/procinfo: add support for show port

Function show_port is used for displaying the port PMD information under under primary process. The information shows basic, per queue and security. Signed-off-by: Vipin Varghese --- V3: - fix meson build - Reshma Pattan - change 100 to MAX_STRING_LEN - Reshma Pattan - memset to struct elemen

[dpdk-dev] [PATCH v5 1/9] app/procinfo: add usage for new debug

Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- V3: - change the usage details - Vipin Varghese V2: - change word dbg to show - Stephen Hemminger --- app/proc-info/main.c | 16 +++- 1 file changed, 15 i

[dpdk-dev] [PATCH v5 2/9] app/procinfo: add compare for new options

Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- V3: - variables from debug to show - Vipin Varghese V2: - compare string from dbg to show - Stephen Hemminger --- app/proc-info/main.c | 30 ++ 1 file ch

[dpdk-dev] [PATCH v5 3/9] app/procinfo: add prototype for debug instances

Add prototype function calls for the show functions. Signed-off-by: Vipin Varghese --- V3: - update function names from debug to show - Vipin Varghese V2: - removed if else ladder - Vipin Varghese --- app/proc-info/main.c | 42 ++ 1 file changed, 42 in

[dpdk-dev] [PATCH v4 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

[dpdk-dev] [PATCH v4 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

Re: [dpdk-dev] [PATCH v3] test/hash: solve unit test hash compilation error

26/10/2018 23:43, Dharmik Thakkar: > Enable print_key_info() function compilation always. > > Compilation error message: > 'test_hash.c: In function ‘print_key_info’: > test_hash.c:90:15: error: cast discards ‘const’ qualifier from pointer > target type [-Werror=cast-qual] > uint8_t *p = (uint8_

Re: [dpdk-dev] [PATCH] test/test: allow taking extra arguments from environment

12/10/2018 19:42, Luca Boccassi: > On Fri, 2018-10-12 at 16:34 +0100, Bruce Richardson wrote: > > When running unit tests automatically, either via script, from meson, > > or otherwise, the same set of options may be used for each run, for > > example to set a standard coremask to be used for all t

Re: [dpdk-dev] [PATCH v2] test/bpf: use hton instead of _builtin_bswap

02/11/2018 20:08, Malvika Gupta: > From: Malvika Gupta > > Convert host machine endianness to networking endianness for > comparison of incoming packets with BPF filter > > Suggested-by: Brian Brooks > Signed-off-by: Malvika Gupta > Reviewed-by: Gavin Hu > Reviewed-by: Konstantin Ananyev > A

Re: [dpdk-dev] [PATCH v2] test: reduce test time for hash multiwriter ut

02/11/2018 13:01, Jananee Parthasarathy: > From: Naga Suresh Somarowthu > > Reduced test duration for hash_multiwriter_autotest. > Number of entries and total insertions are reduced > such that the duration is less than 10 seconds. > > Signed-off-by: Naga Suresh Somarowthu > Acked-by: Heraklius

Re: [dpdk-dev] [PATCH] test: reduce test time for func reentrancy ut

02/11/2018 11:28, Pattan, Reshma: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pattan, Reshma > > From: Somarowthu, Naga SureshX > > > > Signed-off-by: Naga Suresh Somarowthu > > > > --- > > test/test/test_func_reentrancy.c | 60 > > +++- > > 1 file

Re: [dpdk-dev] [PATCH 1/2] examples/flow_filtering: fix set offloads based on cap

05/11/2018 10:51, Zhao1, Wei: > From: Ori Kam [mailto:or...@mellanox.com] > > > > Some of the requested offloads are not supported by all devices. > > > > This patch fixes this issue by setting only the supported offloads. > > > > Fixes: feca6c428a5e ("examples/flow_filtering: add Tx queues setu

Re: [dpdk-dev] [PATCH] bus/pci: fix missing case for virtio-crypto

01/11/2018 13:10, Fan Zhang: > The recent change to rte_pci_read_config() caused virtio-crypto > device initialization always failed as it has a > RTE_KDRV_UIO_GENERIC driver type. This patch fixes the problem. > > Fixes: 630deed612ca ("bus/pci: compare kernel driver instead of interrupt > handle

Re: [dpdk-dev] [PATCH v2 0/2] ip_frag: two fixes in reassembly code

05/11/2018 13:18, Konstantin Ananyev: > Fix 2 issues reported in reassembly code path. > > Konstantin Ananyev (2): > ip_frag: check fragment length of incoming packet > ip_frag: use key length for key comparision Applied, thanks

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

Hi Ferruh, Andrew, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, October 23, 2018 3:29 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Yigit, Ferruh ; Andrew > Rybchenko > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting > > 23/10

[dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

When probe the same device at second time, devargs will be replaced in devargs_list, old version is destoried but they are still referenced by vdev->device. So we break the link between vdev->device to devargs_list by clone, and the copy one will be freed by vdev bus itself. Signed-off-by: Qi Zhan

[dpdk-dev] [PATCH v2] net/e1000: update Tx offload mask

Tx offload mask is updated in following commit: commit 1037ed842c37 ("mbuf: fix Tx offload mask") Currently, the new added offload flags are not supported in PMD and application will fail to call PMD transmit prepare function. This patch updates IGB_TX_OFFFLOAD_MASK. Fixes: 1037ed842c37 ("mbuf: f

Re: [dpdk-dev] [PATCH 1/3] lib: fix shifting 32 bits signed variable 31 times

28/10/2018 02:08, Ferruh Yigit: > Fix cppcheck warning by marking variable as unsigned. > > Fixes: dc276b5780c2 ("acl: new library") > Fixes: 986ff526fb84 ("net: add CRC computation API") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit Series applied, thanks

Re: [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove

05/11/2018 14:13, Thomas Monjalon: > 05/11/2018 13:19, Kevin Traynor: > > On 11/01/2018 02:46 PM, Thomas Monjalon wrote: > > > The functions rte_dev_probe() and rte_dev_remove() are new > > > in DPDK 18.11 so they got the experimental tag by policy. > > > However they are too much basic functions f

Re: [dpdk-dev] [PATCH] malloc: fix invalid argument handling

05/11/2018 18:26, Anatoly Burakov: > When adding memory to an external heap, do not go to unlock failure > handler because the memory hotplug lock hasn't been taken out yet. > > Fixes: 7d75c31014f7 ("malloc: allow adding memory to named heaps") > > Signed-off-by: Anatoly Burakov Applied, thanks

Re: [dpdk-dev] [PATCH] bus/pci: fix missing case for virtio-crypto

We must also fix rte_pci_write_config() 02/11/2018 11:39, Thomas Monjalon: > +Cc Bruce and Ferruh > > 02/11/2018 11:01, Zhang, Roy Fan: > > Hi Thomas, > > > > You are right, the problem can happen with any PMD falls into > > RTE_KDRV_UIO_GENERIC and RTE_KDRV_NIC_UIO driver type. As riginally >

Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail

> > > > 27/10/2018 17:00, Jerin Jacob: > > > From: Thomas Monjalon > > > > The thread is totally messed up because: > > > > - there is no cover letter > > > > - some different series (testpmd, i40e and doc) are in the > > > > same > > thread > > > > - v4 replies to a differ

Re: [dpdk-dev] [PATCH v1] ethdev: document RSS default key and types

This patch is in next-net but may be improved before reaching mainline. The comments may be shorter and avoid being split in 2 parts. The second part of the doxygen comments, starting with /**, will apply wrongly to the next field. 03/11/2018 16:46, Ophir Munk: > struct rte_flow_action_rss includ

[dpdk-dev] [PATCH] net/pcap: enable data path on secondary

Private vdev on secondary is never supported by the new shared device mode but pdump still relies on a private pcap PMD on secondary. The patch enables pcap PMD's data path on secondary so that pdump can work as usual. Signed-off-by: Qi Zhang --- drivers/net/pcap/rte_eth_pcap.c | 98

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix build

05/11/2018 18:51, Ferruh Yigit: > On 11/5/2018 5:45 PM, Thomas Monjalon wrote: > > The example was not added to the Makefile and there are some > > compilation errors: > > > > examples/fips_validation/main.c: In function ‘prepare_aead_op’: > > error: control reaches end of non-void function > > ex

[dpdk-dev] [PATCH v2] doc: add kni changes to release note

Add the new module parameter for the KNI kernel module, the new command line flag for the KNI sample application, and the new API function 'rte_kni_update_link()' to the release note. Signed-off-by: Dan Gora --- doc/guides/rel_notes/release_18_11.rst | 19 +++ 1 file changed, 19

Re: [dpdk-dev] [PATCH] app/testpmd: fix memory leak for tm object

On 11/5/2018 4:21 PM, Jasvinder Singh wrote: > Fixes memory leak for shared shaper object of the traffic manager. > > Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") > > Signed-off-by: Jasvinder Singh Reviewed-by: Ferruh Yigit - needs stable tag: "Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH] doc: add kni changes to release note

On Mon, Nov 5, 2018 at 5:06 PM Ferruh Yigit wrote: > > +* kni: Added the new API function ``rte_kni_update_link()`` to allow the > > user > > + to set the carrier state of the KNI kernel network interface. > > + > > It is good to document new API, which can be on "new features" section above, >

Re: [dpdk-dev] [PATCH v2] testpmd: fix memory alloc for dscp table

On 11/5/2018 4:26 PM, Jasvinder Singh wrote: > The patch fixes the memory allocation for the meter dscp table. > > Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") > > Signed-off-by: Jasvinder Singh Reviewed-by: Ferruh Yigit - title should be: "app/testpmd: ..." - nee

Re: [dpdk-dev] [PATCH] netvsc: fix vf link update handling

On 11/5/2018 6:51 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > The netvsc device calls VF (if present) to update the link status > with the wrong device. This leads to errors in mlx5 device when it > can't find the ifindex. > > Fixes: dc7680e8597c ("net/netvsc: support integrated V

Re: [dpdk-dev] [PATCH] doc: add kni changes to release note

On 11/5/2018 6:29 PM, Dan Gora wrote: > Add the new module parameter for the KNI kernel module, the new command > line flag for the KNI sample application, and the new API function > 'rte_kni_update_link()' to the release note. > > Signed-off-by: Dan Gora > > --- > doc/guides/rel_notes/release_

Re: [dpdk-dev] Fwd: Disable receiving new flows on a core

Thank you for your response. My guess was that to implement this feature in hardware isn't straightforward and would require support for: - allocating additional memory and keeping track of flow hashes per core - parsing TCP packets for SYN flag - If flow hash matches for a core, send it to a

[dpdk-dev] [PATCH] netvsc: fix vf link update handling

From: Stephen Hemminger The netvsc device calls VF (if present) to update the link status with the wrong device. This leads to errors in mlx5 device when it can't find the ifindex. Fixes: dc7680e8597c ("net/netvsc: support integrated VF") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

On Mon, Nov 5, 2018 at 4:23 PM Dan Gora wrote: > > On Mon, Nov 5, 2018 at 4:21 PM Ferruh Yigit wrote: > > There is no test plan documentation within dpdk repo. There is DTS (dpdk > > test > > suit) in a separate repo [1], which needs to be updated, and indeed this > > patch > > is to point them

[dpdk-dev] [PATCH] doc: add kni changes to release note

Add the new module parameter for the KNI kernel module, the new command line flag for the KNI sample application, and the new API function 'rte_kni_update_link()' to the release note. Signed-off-by: Dan Gora --- doc/guides/rel_notes/release_18_11.rst | 13 + 1 file changed, 13 inser

[dpdk-dev] [PATCH 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

On Mon, Nov 5, 2018 at 4:21 PM Ferruh Yigit wrote: > There is no test plan documentation within dpdk repo. There is DTS (dpdk test > suit) in a separate repo [1], which needs to be updated, and indeed this patch > is to point them the change because existing test is failing after changes... > > [1

[dpdk-dev] [PATCH 6/9] app/procinfo: add support for show crypto

Function show_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- v4: - add space to compare - Vipin Varghese V3: - replace MACRO to function - Reshma Pathan & Stephen Hemminger - add memset for struct elements - Reshma Pathan - change d

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

On 11/5/2018 6:12 PM, Dan Gora wrote: > Hi Ferruh, > > On Mon, Nov 5, 2018 at 3:28 PM Ferruh Yigit wrote: >> >> Commit 89397a01ce4a ("kni: set default carrier state of interface") >> changes the KNI interface default carrier status. Which prevents traffic >> flow by default and may break some exi

[dpdk-dev] [PATCH 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

On 11/05/2018 12:41 PM, Zhang, Qi Z wrote: -Original Message- From: Luca Boccassi [mailto:bl...@debian.org] Sent: Friday, November 2, 2018 8:19 AM To: dev@dpdk.org Cc: Lu, Wenzhuo ; Ananyev, Konstantin ; Zhang, Qi Z ; 3ch...@gmail.com; Luca Boccassi ; sta...@dpdk.org Subject: [PATCH

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

Hi Ferruh, On Mon, Nov 5, 2018 at 3:28 PM Ferruh Yigit wrote: > > Commit 89397a01ce4a ("kni: set default carrier state of interface") > changes the KNI interface default carrier status. Which prevents traffic > flow by default and may break some existing usage / testing. > > Document this behavio

[dpdk-dev] [PATCH 6/9] app/procinfo: add support for show crypto

Function show_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- v4: - add space to compare - Vipin Varghese V3: - replace MACRO to function - Reshma Pathan & Stephen Hemminger - add memset for struct elements - Reshma Pathan - change d

[dpdk-dev] [PATCH 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

Re: [dpdk-dev] [PATCH v3 8/9] app/procinfo: add support for show mempool

Sending v4 for spacing issue > + (flags & MEMPOOL_F_NO_SPREAD)? 'y' : 'n', > + (flags & MEMPOOL_F_NO_CACHE_ALIGN) ? 'y' > : 'n', > + (flags & MEMPOOL_F_SP_PUT) ? 'y' :'n', > + (flags &

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

On Mon, 2018-11-05 at 17:41 +, Zhang, Qi Z wrote: > > -Original Message- > > From: Luca Boccassi [mailto:bl...@debian.org] > > Sent: Friday, November 2, 2018 8:19 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; Zhang, Qi Z ; > > 3ch...@gmail.com; Luca Boccassi ;

Re: [dpdk-dev] [PATCH v3 6/9] app/procinfo: add support for show crypto

Sending v4 for fixing spacing issue > + (x & RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO) ? 'y' : 'n', > + (x & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO) ? 'y' : 'n', > + (x & RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING) ? 'y' : > 'n'); > + printf("\t\t + CPU: SSE (%c), AVX

[dpdk-dev] [PATCH v3 9/9] doc/procinfo: add information for debug options

Document update for debug options and information for PMD instances like port, traffic manager, crypto, mempool and ring instances. Signed-off-by: Vipin Varghese --- V3: - update document from dbg to show - Vipin Varghese V2: - update word style for content - Vipin Varghese --- doc/guides/to

Re: [dpdk-dev] [PATCH] net/bnxt: fix uninitialized variable access

On 11/5/2018 5:38 PM, Ajit Khaparde wrote: > > > On Sat, Oct 27, 2018 at 8:36 PM Ferruh Yigit > wrote: > > ag_cons is used uninitialized, it is used when DEBUG enabled, remove > debug code. > > Fixes: 0958d8b6435d ("net/bnxt: support LRO") > Cc: s

[dpdk-dev] [PATCH v3 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- V3: - add avail and in use - Vipin Varghese - add flag split - Vipin Varghese --- app/proc-info/main.c | 67

[dpdk-dev] [PATCH v3 7/9] app/procinfo: add support for debug ring

Function show_ring is used for displaying the RING of the primary process. Signed-off-by: Vipin Varghese --- V3: - replace space to tab in printf - Reshma Pathan - change ring display information - Vipin Varghese --- app/proc-info/main.c | 34 +- 1 file changed

[dpdk-dev] [PATCH v3 5/9] app/procinfo: add support for show tm

Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with stats. Signed-off-by: Vipin Varghese --- V3: - memset for struct elements - Vipin Varghese - code cleanup for TM - Vipin Varghese - fetch for leaf nodes if node exis

[dpdk-dev] [PATCH v3 6/9] app/procinfo: add support for show crypto

Function show_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- V3: - replace MACRO to function - Reshma Pathan & Stephen Hemminger - add memset for struct elements - Reshma Pathan - change display formating of flags - Vipin Varghese -

[dpdk-dev] [PATCH v3 3/9] app/procinfo: add prototype for debug instances

Add prototype function calls for the show functions. Signed-off-by: Vipin Varghese --- V3: - update function names from debug to show - Vipin Varghese V2: - removed if else ladder - Vipin Varghese --- app/proc-info/main.c | 42 ++ 1 file changed, 42 in

[dpdk-dev] [PATCH v3 1/9] app/procinfo: add usage for new debug

Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- V3: - change the usage details - Vipin Varghese V2: - change word dbg to show - Stephen Hemminger --- app/proc-info/main.c | 16 +++- 1 file changed, 15 i

[dpdk-dev] [PATCH v3 4/9] app/procinfo: add support for show port

Function show_port is used for displaying the port PMD information under under primary process. The information shows basic, per queue and security. Signed-off-by: Vipin Varghese --- V3: - fix meson build - Reshma Pattan - change 100 to MAX_STRING_LEN - Reshma Pattan - memset to struct elemen

[dpdk-dev] [PATCH v3 2/9] app/procinfo: add compare for new options

Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- V3: - variables from debug to show - Vipin Varghese V2: - compare string from dbg to show - Stephen Hemminger --- app/proc-info/main.c | 30 ++ 1 file ch

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix build

On 11/5/2018 5:45 PM, Thomas Monjalon wrote: > The example was not added to the Makefile and there are some > compilation errors: > > examples/fips_validation/main.c: In function ‘prepare_aead_op’: > error: control reaches end of non-void function > examples/fips_validation/main.c: In function ‘pr

[dpdk-dev] [PATCH] examples/fips_validation: fix build

The example was not added to the Makefile and there are some compilation errors: examples/fips_validation/main.c: In function ‘prepare_aead_op’: error: control reaches end of non-void function examples/fips_validation/main.c: In function ‘prepare_auth_op’: error: control reaches end of non-void fu

Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

> -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Friday, November 2, 2018 8:19 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; > 3ch...@gmail.com; Luca Boccassi ; sta...@dpdk.org > Subject: [PATCH v3 1/2] net/ixgbe: fix x550 cod

[dpdk-dev] [PATCH 4/4] test/test: improve output for hash read-write test

The hash read-write autotest generates a lot of text, which is very dense on the screen. Even the summary at the end is hard to follow as everything is very compact. We can improve readability by highlighting the starts of the various sections, and by indenting the values within subsections. Signe

[dpdk-dev] [PATCH 1/4] hash: fix TSX aborts with newer gcc

From: Yipeng Wang gcc 7 and 8 with O3 will generate vzeroupper from rte_memcpy into TSX region which may abort the TSX transaction. This fix changes rte_memcpy to memcpy which will not insert extra vzeroupper into the library. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: sta

[dpdk-dev] [PATCH 2/4] hash: add local cache for TSX region

From: Yipeng Wang This patch adds back the local cache when TSX support is turned on. When TSX is turned on, free key-data slot ring would be contended by various TSX regions. The purpose of this commit is to reduce possible memory collisions during key insertion. Signed-off-by: Yipeng Wang -

[dpdk-dev] [PATCH 3/4] eal/x86: reduce contention when retrying TSX

When TSX transactions abort, it is generally worth retrying a number of times before falling back to the traditional locking path, as the parallelism benefits from TSX can be worth it when a transaction does succeed. For cases with multiple threads and high contention rates, it can be useful to hav

[dpdk-dev] [PATCH 0/4] fixes for rte_hash with TSX

When testing with rte_hash library and TSX, a higher level of transaction aborts was observed in some cases, especially with newer compilers. These patches reduce aborts by ensuring that the compiler does not accidentally insert instructions that cause aborts, and by adding in delays on retry to a

Re: [dpdk-dev] [PATCH] net/bnxt: fix uninitialized variable access

On Sat, Oct 27, 2018 at 8:36 PM Ferruh Yigit wrote: > ag_cons is used uninitialized, it is used when DEBUG enabled, remove > debug code. > > Fixes: 0958d8b6435d ("net/bnxt: support LRO") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit > Acked-by: Ajit Khaparde We have not enabled this fo

  1   2   >