Re: [dpdk-dev] [PATCH v1 2/5] eal: add a new req event to device event

2018-08-20 Thread Jeff Guo
hi, andrew On 8/20/2018 6:37 PM, Andrew Rybchenko wrote: On 17.08.2018 13:51, Jeff Guo wrote: Add a new req event in eal device event for vfio hotplug. When the req request send from the vfio kernel module be detected, vfio userpace driver could use this event to notify the app to handler it.

Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio

2018-08-20 Thread Jeff Guo
hi, gaetan On 8/20/2018 5:15 PM, Gaëtan Rivet wrote: Hi Jeff, On Fri, Aug 17, 2018 at 06:51:26PM +0800, Jeff Guo wrote: As we may know that the process of hotplug is different between igb_uio and vfio. For igb_uio, it could use uevent notification and memory failure handle mechanism for hotpl

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-20 Thread Honnappa Nagarahalli
-Original Message- From: Michel Machado Sent: Saturday, August 18, 2018 6:08 PM To: Honnappa Nagarahalli ; Fu, Qiaobin ; Richardson, Bruce ; De Lara Guarch, Pablo Cc: dev@dpdk.org; Doucette, Cody, Joseph ; Wang, Yipeng1 ; Wiles, Keith ; Gobriel, Sameh ; Tai, Charlie ; Stephen Hemm

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-20 Thread Tiwei Bie
On Mon, Aug 20, 2018 at 05:45:35PM +0100, Luca Boccassi wrote: > On Mon, 2018-08-20 at 16:18 +0800, Tiwei Bie wrote: > > On Thu, Aug 16, 2018 at 07:49:43PM +0100, Luca Boccassi wrote: > > > On Thu, 2018-08-16 at 19:47 +0100, Luca Boccassi wrote: > > > > From: Brian Russell > > > > > > > > In virt

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-20 Thread Mody, Rasesh
>From: dev On Behalf Of Marco Varlese >Sent: Monday, August 20, 2018 2:21 AM > >Hi, > >The code in 17.11.4-rc1 does not compile for me. This needs to be fixed for 17.11.4 as rte_eth_linkstatus_set() is not available in DPDK 17.11.x. Will send a patch with fix. Thanks! -Rasesh >Please, see belo

Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

2018-08-20 Thread Cody Doucette
Re-upping for review. Thanks, Cody On Fri, Jul 27, 2018 at 9:52 AM, Cody Doucette wrote: > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > other IPv6 extension headers when finding the fragment header. > > According to RFC 8200, there is no guarantee that the IPv6 > Fragment

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-20 Thread Luca Boccassi
On Mon, 2018-08-20 at 16:18 +0800, Tiwei Bie wrote: > On Thu, Aug 16, 2018 at 07:49:43PM +0100, Luca Boccassi wrote: > > On Thu, 2018-08-16 at 19:47 +0100, Luca Boccassi wrote: > > > From: Brian Russell > > > > > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config > > > returns > > >

[dpdk-dev] [PATCH v3 2/2] virtio: fix PCI config err handling

2018-08-20 Thread Luca Boccassi
From: Brian Russell In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config returns the number of bytes read from PCI config or < 0 on error. If less than the expected number of bytes are read then log the failure and return rather than carrying on with garbage. Fixes: 6ba1f63b5ab0 ("virt

[dpdk-dev] [PATCH v3 1/2] bus/pci: harmonize and document rte_pci_read_config return value

2018-08-20 Thread Luca Boccassi
On Linux, rte_pci_read_config on success returns the number of read bytes, but on BSD it returns 0. Document the return values, and have BSD behave as Linux does. At least one case (bnx2x PMD) treats 0 as an error, so the change makes sense also for that. Signed-off-by: Luca Boccassi --- driver

Re: [dpdk-dev] [RFC v2] ethdev: add flow metadata

2018-08-20 Thread Ferruh Yigit
On 8/20/2018 4:45 PM, Ferruh Yigit wrote: > On 6/26/2018 9:54 AM, Xueming Li wrote: >> Currently, rte_flow pattern only match packet header fields. >> This patch adds additional data to match the packet. >> >> For example, in egress direction, to do an action depending on the VM >> id, the applicat

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-20 Thread Wiles, Keith
> On Aug 20, 2018, at 9:47 AM, Matteo Lanzuisi wrote: > > Hello Olivier, > > Il 13/08/2018 23:54, Olivier Matz ha scritto: >> Hello Matteo, >> >> On Mon, Aug 13, 2018 at 03:20:44PM +0200, Matteo Lanzuisi wrote: >>> Any suggestion? any idea about this behaviour? >>> >>> Il 08/08/2018 11:56,

Re: [dpdk-dev] [RFC v2] ethdev: add flow metadata

2018-08-20 Thread Ferruh Yigit
On 6/26/2018 9:54 AM, Xueming Li wrote: > Currently, rte_flow pattern only match packet header fields. > This patch adds additional data to match the packet. > > For example, in egress direction, to do an action depending on the VM > id, the application needs to configure rte_flow rule with the ne

Re: [dpdk-dev] Minimum kernel version for DPDK

2018-08-20 Thread Stephen Hemminger
On Mon, 20 Aug 2018 11:46:25 +0300 Kevin Wilson wrote: > Hi all, > Maybe this is a silly question, please bear with me. > > According to the “Getting Started Guide for Linux” in > http://doc.dpdk.org/guides/linux_gsg/sys_reqs.html, > the kernel version should be >= 3.2. > Accrding to my understa

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-20 Thread Matteo Lanzuisi
Hello Olivier, Il 13/08/2018 23:54, Olivier Matz ha scritto: Hello Matteo, On Mon, Aug 13, 2018 at 03:20:44PM +0200, Matteo Lanzuisi wrote: Any suggestion? any idea about this behaviour? Il 08/08/2018 11:56, Matteo Lanzuisi ha scritto: Hi all, recently I began using "dpdk-17.11-11.el7.x86_6

[dpdk-dev] [PATCH v2] port: add sym crypto port

2018-08-20 Thread Zhang, Roy Fan
This patch adds the symmetric crypto support to port library. The crypto port acts as a shim layer to DPDK cryptodev library and supports in-place crypto workload processing. Signed-off-by: Fan Zhang Acked-by: Dumitrescu, Cristian --- v2: - added experimental flags - enabled meson build lib/li

Re: [dpdk-dev] Dpdk eventdev performance testing

2018-08-20 Thread Ferruh Yigit
On 8/18/2018 4:12 PM, Guru Prasad wrote: > Hi All, > > While testing performance with eventdev, I am seeing a crash in dpdk > service core. Test scenario is given below > 1) DPDK 1805 > 2 Eventdev ordered Queues & 2 Ports > 2) 2 Workers threads + 1 Service core for running scheduling. > 3) 1st wor

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-20 Thread Chas Williams
This will need to be implemented for some of the other RX burst methods at some point for other modes to see this performance improvement (with the exception of active-backup). On Thu, Aug 16, 2018 at 9:32 AM Luca Boccassi wrote: > During bond 802.3ad receive, a burst of packets is fetched from

Re: [dpdk-dev] [PATCH] net/bonding: fix buf corruption in merging un-transmitted packets

2018-08-20 Thread Chas Williams
On Mon, Aug 20, 2018 at 3:02 AM Jia Yu wrote: > Hi Chas, > > > > Could you help to review the v2 of the patch? I have addressed the “Fixes” > requirement in commit message, and modified slave_tx_fail_count’s > definition. > Looks fine to me. Thanks for the patch! > > > Thanks, > > Jia > > > >

Re: [dpdk-dev] [PATCH v2] net/bonding: fix buf corruption in merging un-transmitted packets

2018-08-20 Thread Chas Williams
On Mon, Aug 20, 2018 at 2:54 AM Jia Yu wrote: > When bond slave devices cannot transmit all packets in bufs array, > tx_burst callback shall merge the un-transmitted packets back to > bufs array. Recent merge logic introduced a bug which causes > invalid mbuf addresses being written to bufs array

[dpdk-dev] [RFC] mlx5: flow counters support on the linux-rdma v19 base

2018-08-20 Thread viacheslavo
Mellanox mlx5 PMD supports Flow Counters via Verbs library. The current implementation is based on the Mellanox proprietary Verbs library included in MLNX OFED packages. The Flow Counter support is recently added into linux-rdma release (v19), so the mlx5 PMD update is needed to provide Counter fea

Re: [dpdk-dev] [RFC] ethdev: flow counters batch query

2018-08-20 Thread Slava Ovsiienko
Adding relevant maintainers. > -Original Message- > From: Slava Ovsiienko > Sent: Monday, August 20, 2018 14:39 > To: dev@dpdk.org > Cc: Shahaf Shuler ; Slava Ovsiienko > > Subject: [RFC] ethdev: flow counters batch query > > There is a demand to perform query operations on the set of co

Re: [dpdk-dev] Minimum kernel version for DPDK

2018-08-20 Thread Wiles, Keith
> On Aug 20, 2018, at 3:46 AM, Kevin Wilson wrote: > > Hi all, > Maybe this is a silly question, please bear with me. > > According to the “Getting Started Guide for Linux” in > http://doc.dpdk.org/guides/linux_gsg/sys_reqs.html, > the kernel version should be >= 3.2. > Accrding to my understa

Re: [dpdk-dev] dpaa2: building with EXTRA_CFLAGS="-g -O0" and shared libs link error

2018-08-20 Thread Wiles, Keith
> On Aug 20, 2018, at 2:33 AM, Hemant Agrawal wrote: > > Hi Keith, > I am able to reproduce the issue. We will send the fix asap. Thanks Hemant. > > Regards, > Hemant > > -Original Message- > From: dev On Behalf Of Wiles, Keith > Sent: Sunday, August 19, 2018 8:25 PM > To: DPD

[dpdk-dev] [PATCH] port: add sym crypto port

2018-08-20 Thread Zhang, Roy Fan
This patch adds the symmetric crypto support to port library. The crypto port acts as a shim layer to DPDK cryptodev library and supports in-place crypto workload processing. Change-Id: I8e9c87bdaaa252b39873596cbfaa2de2324e765c Signed-off-by: Zhang, Roy Fan --- lib/librte_port/Makefile

[dpdk-dev] [RFC] ethdev: flow counters batch query

2018-08-20 Thread viacheslavo
There is a demand to perform query operations on the set of counters generally belonging to the different RTE flows. The counter queries is the very effective way for application to know in detail what is going on into the network and to take some actions basing on this knowledge. As example, the m

Re: [dpdk-dev] [PATCH 0/5] AESNI MB PMD changes

2018-08-20 Thread Kovacevic, Marko
> The Multi-buffer library supports full digest sizes for the HMAC algorithms > (except for MD5), from 0.50 version. > Also, since 0.50, keys larger than the algorithm block size can be used for > HMAC algorithms, performing a hash on the key. > > Therefore, the AESNI MB PMD now supports any key s

Re: [dpdk-dev] [PATCH v1 2/5] eal: add a new req event to device event

2018-08-20 Thread Andrew Rybchenko
On 17.08.2018 13:51, Jeff Guo wrote: Add a new req event in eal device event for vfio hotplug. When the req request send from the vfio kernel module be detected, vfio userpace driver could use this event to notify the app to handler it. Signed-off-by: Jeff Guo --- lib/librte_eal/common/includ

[dpdk-dev] [PATCH] bus/fslmc: fix the undefined ref of rte dpaa2 memsegs

2018-08-20 Thread Hemant Agrawal
This patch fix the undefined reference issue with rte_dpaa2_memsegs when compiled in shared lib mode with EXTRA_CFLAGS="-g -O0" Fixes: 365fb925d3b3 ("bus/fslmc: optimize physical to virtual address search") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Reported-by: Keith Wiles --- drivers/

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-20 Thread Marco Varlese
Hi, The code in 17.11.4-rc1 does not compile for me. Please, see below what I get: [ 100s] gcc -m64 -DVERSION="17.11.4" -L/home/abuild/rpmbuild/BUILD/dpdk-stable- 17.11.4-rc1/x86_64-native-linuxapp-gcc-default/lib -Wl,--version- script=/home/abuild/rpmbuild/BUILD/dpdk-stable-17.11.4- rc1/driver

Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio

2018-08-20 Thread Gaëtan Rivet
Hi Jeff, On Fri, Aug 17, 2018 at 06:51:26PM +0800, Jeff Guo wrote: > As we may know that the process of hotplug is different between igb_uio > and vfio. For igb_uio, it could use uevent notification and memory > failure handle mechanism for hotplug. But for vfio, when device is be > hotplug-out, t

Re: [dpdk-dev] [PATCH v15 1/7] ethdev: add function to release port in secondary process

2018-08-20 Thread Andrew Rybchenko
On 16.08.2018 06:04, Qi Zhang wrote: Add driver API rte_eth_release_port_secondary to support the case when an ethdev need to be detached on a secondary process. Local state is set to unused and shared data will not be reset so the primary process can still use it. There are few questions below

Re: [dpdk-dev] 16.11.8 (LTS) patches review and test

2018-08-20 Thread Luca Boccassi
On Mon, 2018-08-13 at 19:21 +0100, luca.bocca...@gmail.com wrote: > Hi all, > > Here is a list of patches targeted for LTS release 16.11.8. Please > help review and test. The planned date for the final release is > August > the 23rd. > Before that, please shout if anyone has objections with these

Re: [dpdk-dev] [dpdk-stable] 16.11.8 (LTS) patches review and test

2018-08-20 Thread Luca Boccassi
Great, thanks for checking! On Mon, 2018-08-20 at 08:46 +0200, Marco Varlese wrote: > Hi Luca & all, > > I have gone through the usual smoke tests using test_pmd and OvS- > DPDK. > I have not experienced any issues with the -rc1 release. > > > Thanks, > Marco > > On Mon, 2018-08-13 at 19:21 +0

[dpdk-dev] Minimum kernel version for DPDK

2018-08-20 Thread Kevin Wilson
Hi all, Maybe this is a silly question, please bear with me. According to the “Getting Started Guide for Linux” in http://doc.dpdk.org/guides/linux_gsg/sys_reqs.html, the kernel version should be >= 3.2. Accrding to my understanding, there are only two kernel modules in DPDK, namely rte_kni.ko and

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-20 Thread Tiwei Bie
On Thu, Aug 16, 2018 at 07:49:43PM +0100, Luca Boccassi wrote: > On Thu, 2018-08-16 at 19:47 +0100, Luca Boccassi wrote: > > From: Brian Russell > > > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config > > returns > > the number of bytes read from PCI config or < 0 on error. > > If

Re: [dpdk-dev] dpaa2: building with EXTRA_CFLAGS="-g -O0" and shared libs link error

2018-08-20 Thread Hemant Agrawal
Hi Keith, I am able to reproduce the issue. We will send the fix asap. Regards, Hemant -Original Message- From: dev On Behalf Of Wiles, Keith Sent: Sunday, August 19, 2018 8:25 PM To: DPDK Subject: [dpdk-dev] dpaa2: building with EXTRA_CFLAGS="-g -O0" and shared libs link error

Re: [dpdk-dev] [PATCH] net/bonding: fix buf corruption in merging un-transmitted packets

2018-08-20 Thread Jia Yu
Hi Chas, Could you help to review the v2 of the patch? I have addressed the “Fixes” requirement in commit message, and modified slave_tx_fail_count’s definition. Thanks, Jia From: Chas Williams <3ch...@gmail.com> Date: Sunday, August 19, 2018 at 5:07 PM To: Jia Yu Cc: "dev@dpdk.org" , Declan D