[dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-16 Thread Nikhil Rao
This patch adds tests for the eth Tx adapter APIs. It also tests the data path for the rte_service function based implementation of the APIs. Signed-off-by: Nikhil Rao --- test/test/test_event_eth_tx_adapter.c | 676 ++ MAINTAINERS | 1

[dpdk-dev] [PATCH v2 3/4] eventdev: add eth Tx adapter implementation

2018-08-16 Thread Nikhil Rao
This patch implements the Tx adapter APIs by invoking the corresponding eventdev PMD callbacks and also provides the common rte_service function based implementation when the eventdev PMD support is absent. Signed-off-by: Nikhil Rao --- config/rte_config.h|1 + li

[dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-08-16 Thread Nikhil Rao
The caps API allows the application to query if the transmit stage is implemented in the eventdev PMD or uses the common rte_service function. The PMD callbacks support the eventdev PMD implementation of the adapter. Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_eventdev.h | 33

[dpdk-dev] [PATCH v2 1/4] eventdev: add eth Tx adapter APIs

2018-08-16 Thread Nikhil Rao
The ethernet Tx adapter abstracts the transmit stage of an event driven packet processing application. The transmit stage may be implemented with eventdev PMD support or use a rte_service function implemented in the adapter. These APIs provide a common configuration and control interface and an tra

Re: [dpdk-dev] [PATCH] check-symbol-change: relax rule for identifying a section

2018-08-16 Thread Rao, Nikhil
On 8/16/2018 4:38 PM, Neil Horman wrote: It was reported recently that some patches that add symbols to an existing EXPERIMENTAL section of a version map file generate errors because the check-symbol-change script was identifying the section as "@@" rather than EXPERIMENTAL. This was fairly clea

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-16 Thread Honnappa Nagarahalli
Hi Fu, Thank you for the patch. I have few comments below. Thank you, Honnappa -Original Message- From: dev On Behalf Of Fu, Qiaobin Sent: Thursday, August 16, 2018 2:30 AM To: Richardson, Bruce ; De Lara Guarch, Pablo Cc: dev@dpdk.org; Michel Machado ; Doucette, Cody, Joseph

[dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-16 Thread Stephen Hemminger
Function is boolean so use that. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index f09bf8bc8b01..f0336736b7c1 100644 --- a/lib/librt

[dpdk-dev] [PATCH 0/2] ethdev: minor ownership changes

2018-08-16 Thread Stephen Hemminger
While debugging something else noticed that unset always logged an error. Stephen Hemminger (2): ethdev: silence error message on rte_eth_dev_owner_unset ethdev: make rte_eth_is_valid_owner_id return bool lib/librte_ethdev/rte_ethdev.c | 17 - 1 file changed, 8 insertions(+),

[dpdk-dev] [PATCH 1/2] ethdev: silence error message on rte_eth_dev_owner_unset

2018-08-16 Thread Stephen Hemminger
The rte_eth_dev_owner_unset function always generates a log message because the unset value for owner id is 0. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [dpdk-dev] [PATCH] doc: add mlx5 limitation of RSS hash result

2018-08-16 Thread Yongseok Koh
> On Aug 14, 2018, at 9:57 AM, Yongseok Koh wrote: > > Signed-off-by: Yongseok Koh > --- > doc/guides/nics/mlx5.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index 52e1213cf5..cbcc233d03 100644 > --- a/doc/guides/nics/m

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-16 Thread Luca Boccassi
On Thu, 2018-08-16 at 19:47 +0100, Luca Boccassi wrote: > From: Brian Russell > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config > returns > the number of bytes read from PCI config or < 0 on error. > If less than the expected number of bytes are read then log the > failure and re

[dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-16 Thread Luca Boccassi
From: Brian Russell In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config returns the number of bytes read from PCI config or < 0 on error. If less than the expected number of bytes are read then log the failure and return rather than carrying on with garbage. Fixes: 6ba1f63b5ab0 ("virt

[dpdk-dev] [PATCH 1/2] bus/pci: harmonize and document rte_pci_read_config return value

2018-08-16 Thread Luca Boccassi
On Linux, rte_pci_read_config on success returns the number of read bytes, but on BSD it returns 0. Document the return values, and have BSD behave as Linux does. At least one case (bnx2x PMD) treats 0 as an error, so the change makes sense also for that. Signed-off-by: Luca Boccassi --- driver

[dpdk-dev] 17.11.4 patches review and test

2018-08-16 Thread Yongseok Koh
Hi all, Here is a list of patches targeted for LTS release 17.11.4. Please help review and test. The planned date for the final release is August 23. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests,

Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Stephen Hemminger
On Thu, 16 Aug 2018 16:34:12 + "Wiles, Keith" wrote: > I looked at the Coding Guide in section 1.7.2 and it states > > 1.7.2. Definitions > - The function type should be on a line by itself preceding the > function. > - The opening brace of the function body should be on a line

[dpdk-dev] [PATCH v1] doc: fix sample application formatting

2018-08-16 Thread Marko Kovacevic
Fixed formatting an extra header was added making it an extra section when it was not intended. Fixes: d0dff9ba445e ("doc: sample application user guide") Cc: bernard.iremon...@intel.com Signed-off-by: Marko Kovacevic --- doc/guides/sample_app_ug/ip_reassembly.rst | 4 ++-- 1 file changed, 2 in

Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Wiles, Keith
> On Aug 16, 2018, at 10:31 AM, Stephen Hemminger > wrote: > > The hexdump code obviously came from somewhere else originally. > It is not formatted according to DPDK coding style. > > Also, drop the comment which is not useful the docbock comment > is already in the rte_hexdump.h > > Signed

Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Wiles, Keith
> On Aug 16, 2018, at 10:31 AM, Stephen Hemminger > wrote: > > The hexdump code obviously came from somewhere else originally. > It is not formatted according to DPDK coding style. > > Also, drop the comment which is not useful the docbock comment > is already in the rte_hexdump.h > > Signe

Re: [dpdk-dev] [PATCH 2/2] hexdump: align output of string

2018-08-16 Thread Stephen Hemminger
On Thu, 16 Aug 2018 08:31:06 -0700 Stephen Hemminger wrote: > This fixes the issue where if the length of the output is not > a multiple of 16 the formatting was off. > > Before: > : 45 00 00 1C 12 34 2C E0 40 06 B8 2E C0 A8 01 12 | E4,.@... > 0010: C0 A8 01 37 | | | | |

[dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Stephen Hemminger
The hexdump code obviously came from somewhere else originally. It is not formatted according to DPDK coding style. Also, drop the comment which is not useful the docbock comment is already in the rte_hexdump.h Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_hexdump.c | 10

[dpdk-dev] [PATCH 2/2] hexdump: align output of string

2018-08-16 Thread Stephen Hemminger
This fixes the issue where if the length of the output is not a multiple of 16 the formatting was off. Before: : 45 00 00 1C 12 34 2C E0 40 06 B8 2E C0 A8 01 12 | E4,.@... 0010: C0 A8 01 37 | | | | | | | | | | | | | ...7 After: : 45 00 00 1C 12 34 2C E0 40

[dpdk-dev] [PATCH 0/2] eal: hexcump trivial changes

2018-08-16 Thread Stephen Hemminger
Minor cleanups of the hexdump routines Stephen Hemminger (2): hexdump: whitespace cleanup hexdump: align output of string lib/librte_eal/common/eal_common_hexdump.c | 116 + 1 file changed, 50 insertions(+), 66 deletions(-) -- 2.18.0

[dpdk-dev] [RFC v3 5/6] net/af_xdp: enable zero copy

2018-08-16 Thread Qi Zhang
Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Qi Zhang --- drivers/net/af_xdp/rte_eth_af_xdp.c | 158 +--- 1 fi

[dpdk-dev] [RFC v3 6/6] app/testpmd: add mempool flags parameter

2018-08-16 Thread Qi Zhang
When create rte_mempool, flags can be parsed from command line. Now, it is possible for testpmd to create a af_xdp friendly mempool (which enable zero copy). Signed-off-by: Qi Zhang --- app/test-pmd/parameters.c | 12 app/test-pmd/testpmd.c| 15 +-- app/test-pmd/test

[dpdk-dev] [RFC v3 4/6] net/af_xdp: use mbuf mempool for buffer management

2018-08-16 Thread Qi Zhang
Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be allocated from rte_mempool can be convert to xdp_desc's address and vice versa. Signed-off-by: Qi Zhang --- drivers/net/af_xdp/rte_eth_af_xdp.c | 184 +--- 1 file changed, 108 insertions(+), 7

[dpdk-dev] [RFC v3 2/6] lib/mbuf: enable parse flags when create mempool

2018-08-16 Thread Qi Zhang
This give the option that applicaiton can configure each memory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD). Signed-off-by: Qi Zhang --- lib/librte_mbuf/rte_mbuf.c | 15 --- lib/librte_mbuf/rte_mbuf.h | 8 +++- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [RFC v3 3/6] lib/mempool: allow page size aligned mempool

2018-08-16 Thread Qi Zhang
Allow create a mempool with page size aligned base address. Signed-off-by: Qi Zhang --- lib/librte_mempool/rte_mempool.c | 3 +++ lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 4 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 03e6b

[dpdk-dev] [RFC v3 1/6] net/af_xdp: new PMD driver

2018-08-16 Thread Qi Zhang
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. https://fosdem.org/2018/schedule/event/af_xdp/ https://lwn.net/Articles/745934/ This patch enable the vanilla version. Packet data will copy between xdp socket's memory buffer and rx queue's mbuf me

[dpdk-dev] [PATCH v3 0/6] PMD driver for AF_XDP

2018-08-16 Thread Qi Zhang
Overview The patch set add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below link for detail AF_XDP introduction: https://lwn.net/Articles/750845/ https://fosdem.org/2018/schedule/event/af_xdp/ AF_XDP roadmap == - The ke

[dpdk-dev] [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-08-16 Thread Luca Boccassi
The vmxnet3 driver can't call back into dev_close(), and possibly dev_stop(), in dev_uninit(). When dev_uninit() is called, anything that those routines would want to clean up has already been released. Further, for complete cleanup, it is necessary to release any of the queue resources during dev

[dpdk-dev] [PATCH 1/3] net/virtio: register/unregister intr handler on start/stop

2018-08-16 Thread Luca Boccassi
Register and unregister the virtio interrupt handler when the device is started and stopped. This allows a virtio device to be hotplugged or unplugged. Fixes: c1f86306a026 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Brian Russell Signed-off-by: Luca Boccassi --- drivers/net/v

[dpdk-dev] [PATCH 3/3] eal/linux: handle uio read failure in interrupt handler

2018-08-16 Thread Luca Boccassi
If a device is unplugged while an interrupt is pending, the read call to the uio device to remove it from the poll wait list can fail resulting in it being continually polled forever. This change checks for the read failing and if so, unregisters the device as an interrupt source and causes the wai

[dpdk-dev] [PATCH 0/3] Fix hot plug/unplug of virtual devices

2018-08-16 Thread Luca Boccassi
Although not very common and perhaps a bit strange, we do have users that want to be able to hot plug/unplug virtio or vmxnet devices from a running system, without shutting down the application nor the VM. We have been enabling this in production for a year or so, so it's well tested. The only is

[dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-16 Thread Luca Boccassi
During bond 802.3ad receive, a burst of packets is fetched from each slave into a local array and appended to per-slave ring buffer. Packets are taken from the head of the ring buffer and returned to the caller. The number of mbufs provided to each slave is sufficient to meet the requirements of t

Re: [dpdk-dev] [PATCH] net/bonding: add support to match on 0x88A8 ethertype

2018-08-16 Thread Chas Williams
On Tue, Aug 7, 2018 at 4:11 AM wangyunjian wrote: > From: Yunjian Wang > > We assume VLAN ethtertype is 0x8100 in get_vlan_offset() function, > but it could be 0x88A8 if QinQ is supported. > > Signed-off-by: Yunjian Wang > Acked-by: Chas Williams > --- > drivers/net/bonding/rte_eth_bond_p

[dpdk-dev] [PATCH v3] net/bonding: per-slave intermediate rx ring

2018-08-16 Thread Luca Boccassi
During bond 802.3ad receive, a burst of packets is fetched from each slave into a local array and appended to per-slave ring buffer. Packets are taken from the head of the ring buffer and returned to the caller. The number of mbufs provided to each slave is sufficient to meet the requirements of t

Re: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization

2018-08-16 Thread Ferruh Yigit
On 8/16/2018 7:52 AM, Jerin Jacob wrote: > -Original Message- >> Date: Thu, 9 Aug 2018 12:30:57 +0100 >> From: Ferruh Yigit >> To: Kiran Kumar >> CC: dev@dpdk.org, Jerin Jacob , Konstantin >> Ananyev , Bruce Richardson >> , Santosh Shukla >> >> Subject: Re: [dpdk-dev] [PATCH] kni: fix

Re: [dpdk-dev] [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default

2018-08-16 Thread Shahaf Shuler
Wednesday, August 15, 2018 8:12 PM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send > by default > > > > On Aug 15, 2018, at 5:17 AM, Shahaf Shuler > wrote: > > > > On ConnectX-4 Lx the Multi Packet Send (MPW) feature is considered > > un-secure, as on s

[dpdk-dev] [PATCH] check-symbol-change: relax rule for identifying a section

2018-08-16 Thread Neil Horman
It was reported recently that some patches that add symbols to an existing EXPERIMENTAL section of a version map file generate errors because the check-symbol-change script was identifying the section as "@@" rather than EXPERIMENTAL. This was fairly clearly due to the fact that the rule identifyi

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-16 Thread Neil Horman
On Thu, Aug 16, 2018 at 06:19:40AM +, Rao, Nikhil wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Wednesday, August 15, 2018 4:19 PM > > To: Rao, Nikhil > > Cc: dev@dpdk.org; tho...@monjalon.net; Mcnamara, John > > ; Richardson, Bruce

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-16 Thread Luca Boccassi
On Thu, 2018-08-16 at 14:46 +0800, Tiwei Bie wrote: > On Wed, Aug 15, 2018 at 10:50:57AM +0100, Luca Boccassi wrote: > > On Wed, 2018-08-15 at 11:11 +0800, Tiwei Bie wrote: > > > On Tue, Aug 14, 2018 at 03:30:35PM +0100, Luca Boccassi wrote: > > > > From: Brian Russell > > > > > > > > In virtio_r

[dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-16 Thread Kiran Kumar
With existing code in kni_fifo_put, rx_q values are not being updated before updating fifo_write. While reading rx_q in kni_net_rx_normal, This is causing the sync issue on other core. So adding a write barrier to make sure the values being synced before updating fifo_write. Fixes: 3fc5ca2f6352 ("

Re: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization

2018-08-16 Thread Jerin Jacob
-Original Message- > Date: Thu, 9 Aug 2018 15:53:53 +0530 > From: Kiran Kumar > To: ferruh.yi...@intel.com > CC: dev@dpdk.org, Kiran Kumar > Subject: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization > X-Mailer: git-send-email 2.7.4 > > External Email > > With existing

Re: [dpdk-dev] [RFC] ethdev: add tail drop API for traffic management

2018-08-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Xu, Rosen > Sent: Tuesday, August 14, 2018 7:45 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Lu, Wenzhuo ; Singh, Jasvinder > ; Yigit, Ferruh ; > nithin.dabilpu...@cavium.com > Subject: RE: [dpdk-dev] [RFC] ethdev: add tail drop API for

Re: [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters

2018-08-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Xu, Rosen > Sent: Thursday, August 16, 2018 2:14 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Singh, Jasvinder ; > jerin.ja...@caviumnetworks.com; Xu, Rosen ; Yigit, > Ferruh > Subject: [PATCH] lib/librte_ethdev: expand queue threshold

[dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-16 Thread Fu, Qiaobin
Function rte_hash_iterate_conflict_entries() iterates over the entries that conflict with an incoming entry. Iterating over conflicting entries enables one to decide if the incoming entry is more valuable than the entries already in the hash table. This is particularly useful after an insertion fa

Re: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization

2018-08-16 Thread Jerin Jacob
-Original Message- > Date: Thu, 9 Aug 2018 12:30:57 +0100 > From: Ferruh Yigit > To: Kiran Kumar > CC: dev@dpdk.org, Jerin Jacob , Konstantin > Ananyev , Bruce Richardson > , Santosh Shukla > > Subject: Re: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer > synchronization > User-Age