Re: [dpdk-dev] [RFC] ethdev: add tail drop API for traffic management

2018-08-13 Thread Xu, Rosen
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, August 14, 2018 14:06 > To: Xu, Rosen > Cc: dev@dpdk.org; Dumitrescu, Cristian ; Lu, > Wenzhuo ; Singh, Jasvinder > ; Yigit, Ferruh ; > nithin.dabilpu...@cavium.com > Subject: Re: [dpdk-dev

Re: [dpdk-dev] [RFC] ethdev: add tail drop API for traffic management

2018-08-13 Thread Jerin Jacob
-Original Message- > Date: Mon, 13 Aug 2018 15:53:32 +0800 > From: Rosen Xu > To: dev@dpdk.org > CC: cristian.dumitre...@intel.com, wenzhuo...@intel.com, > jasvinder.si...@intel.com, rosen...@intel.com, ferruh.yi...@intel.com > Subject: [dpdk-dev] [RFC] ethdev: add tail drop API for traff

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-13 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > The rte_eth_dev_owner_unset function is unusable because it always > returns -EINVAL. This is because the magic (unowned) value is flagged as not > valid. > It's OK to raise an error when you do unset for unowned device. It means that unset owner should be ca

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-13 Thread Rao, Nikhil
On 6/27/2018 11:31 PM, Neil Horman wrote: diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh new file mode 100755 index 0..17d123cf4 --- /dev/null +++ b/devtools/check-symbol-change.sh @@ -0,0 +1,159 @@ +#!/bin/sh +# SPDX-License-Identifier: BSD-3-Clause +# Cop

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-08-13 Thread Lu, Wenzhuo
Hi Andrew, > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Monday, August 13, 2018 4:39 PM > To: Lu, Wenzhuo ; Thomas Monjalon > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting > > On 13.08.2

[dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-13 Thread Stephen Hemminger
The rte_eth_dev_owner_unset function is unusable because it always returns -EINVAL. This is because the magic (unowned) value is flagged as not valid. Move the validation of owner into set and unset as separate calls. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Signed-off-by: Stephen Hemmi

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-13 Thread Olivier Matz
Hello Matteo, On Mon, Aug 13, 2018 at 03:20:44PM +0200, Matteo Lanzuisi wrote: > Any suggestion? any idea about this behaviour? > > Il 08/08/2018 11:56, Matteo Lanzuisi ha scritto: > > Hi all, > > > > recently I began using "dpdk-17.11-11.el7.x86_64" rpm (RedHat rpm) on > > RedHat 7.5 kernel 3.1

Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS flow action hash type selection

2018-08-13 Thread Yongseok Koh
> On Aug 12, 2018, at 4:14 AM, Shahaf Shuler wrote: > > On the code after the below commits, the criteria to select the IPV4 or > IPV6 hash functions was the existence of some ETH_RSS_IPV4 RSS types on > the flow rule. > > The check is wrong. For example ETH_RSS_NONFRAG_IPV4_TCP will not selec

Re: [dpdk-dev] [RFC] ethdev: add tail drop API for traffic management

2018-08-13 Thread Stephen Hemminger
On Mon, 13 Aug 2018 15:53:32 +0800 Rosen Xu wrote: > @@ -1028,6 +1094,8 @@ enum rte_tm_error_type { > RTE_TM_ERROR_TYPE_WRED_PROFILE_YELLOW, > RTE_TM_ERROR_TYPE_WRED_PROFILE_RED, > RTE_TM_ERROR_TYPE_WRED_PROFILE_ID, > + RTE_TM_ERROR_TYPE_TDROP_PROFILE, > + RTE_TM_ERROR_T

[dpdk-dev] 16.11.8 (LTS) patches review and test

2018-08-13 Thread luca . boccassi
Hi all, Here is a list of patches targeted for LTS release 16.11.8. Please help review and test. The planned date for the final release is August the 23rd. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression t

Re: [dpdk-dev] [PATCH v2 2/2] netvsc: resize event buffer as needed

2018-08-13 Thread Stephen Hemminger
On Mon, 13 Aug 2018 08:51:08 -0700 Stephen Hemminger wrote: > The event buffer was changed to be a fixed size value, but it > is not large enough for a forwarding stress test. > > This version of event buffer code uses malloc/realloc to size > the event buffer as needed. Malloc is preferred over

[dpdk-dev] [RFC 2/2] ethdev: check received mbufs sanity

2018-08-13 Thread David Marchand
Let's check the mbufs given by the drivers directly in the rx handler. The only drawback is that you need CONFIG_RTE_LIBRTE_MBUF_DEBUG to be set for this to actually do some real checks. Signed-off-by: David Marchand --- lib/librte_ethdev/rte_ethdev.h | 4 1 file changed, 4 insertions(+) d

[dpdk-dev] [RFC 1/2] mbuf: add a sanity check on segment metadata

2018-08-13 Thread David Marchand
Add some basic check on the segments offset and length metadata: always funny to have a < 0 tailroom cast to uint16_t ;-). Signed-off-by: David Marchand --- lib/librte_mbuf/rte_mbuf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c in

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-13 Thread Joseph, Anoob
Hi Bruce, The reason why l2fwd was chosen was to allow everyone to chip in their ideas while preparing the framework. This framework would be extended to other applications, hence needed enough inputs before expanding to complex applications. If your suggestion is to make l3fwd event driven fi

[dpdk-dev] [PATCH v2 1/2] netvsc: fix rte malloc pool corruption

2018-08-13 Thread Stephen Hemminger
The event buffer was changed to be a fixed size value, but calls to rte_free were left. That causes bugs because it calls to rte_free() for a pointer that was not setup with rte_malloc(). Fixes: 530af95a7849 ("bus/vmbus: avoid signalling host on read") Signed-off-by: Stephen Hemminger --- driver

[dpdk-dev] [PATCH v2 2/2] netvsc: resize event buffer as needed

2018-08-13 Thread Stephen Hemminger
The event buffer was changed to be a fixed size value, but it is not large enough for a forwarding stress test. This version of event buffer code uses malloc/realloc to size the event buffer as needed. Malloc is preferred over rte_malloc because the event buffer does not need to be used for DMA an

[dpdk-dev] [PATCH v2 0/2] netvsc: event buffer bug fixes

2018-08-13 Thread Stephen Hemminger
A couple of bugs were introduced by the way the event buffer is handled. Stephen Hemminger (2): netvsc: fix rte malloc pool corruption netvsc: resize event buffer as needed v2 - split into two patches and fix whitespace drivers/net/netvsc/hn_rxtx.c | 49 +---

[dpdk-dev] [PATCH] checkpatches: don't assume bash syntax

2018-08-13 Thread Stephen Hemminger
The read -d option is a bash extension and not avaiable in other shells. On Debian, /bin/sh is dash and checktpatches would fail with: ./devtools/checkpatches.sh: 52: read: Illegal option -d Fix by using awk -e and adding necessary double backslash. Fixes: 7413e7f2aeb3 ("devtools: alert on new ca

Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start

2018-08-13 Thread Stephen Hemminger
On Mon, 13 Aug 2018 07:52:47 + Shahaf Shuler wrote: > Hi Stephan, > > Thursday, August 2, 2018 1:00 AM, Stephen Hemminger: > > Subject: [RFC] mlx5: fix error unwind in device start > > > > The error handling in start of the mlx5 driver is buggy. > > For example, if setting up the flows fail

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-13 Thread Ferruh Yigit
On 8/12/2018 9:46 AM, Shahaf Shuler wrote: > Sunday, August 12, 2018 10:53 AM, Andrew Rybchenko: >> Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from >> ixgbe >> >> On 12.08.2018 09:28, Shahaf Shuler wrote: >>> Thursday, August 9, 2018 11:32 AM, Ferruh Yigit: Subject: Re:

Re: [dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:11 PM To: dev@dpdk.org; De Lara Guarch, Pablo ; Jozwiak, TomaszX ; tho...@monjalon.net Cc: Trahe, Fiona Subject: [PATCH v3 0/6] doc/qat: clarify build config options Clarified documentation structure between compre

Re: [dpdk-dev] [PATCH v3 5/6] doc/qat: update build instructions for both PMDs

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:11 PM To: dev@dpdk.org; De Lara Guarch, Pablo ; Jozwiak, TomaszX ; tho...@monjalon.net Cc: Trahe, Fiona Subject: [PATCH v3 5/6] doc/qat: update build instructions for both PMDs Update PMD build section. Linked to k

Re: [dpdk-dev] [PATCH] crypto/qat: fix typo

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 5:20 PM To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo ; Jozwiak, TomaszX Cc: Trahe, Fiona Subject: RE: [PATCH] crypto/qat: fix typo Corrected subject - only 1 patch here. > -Original Message-

Re: [dpdk-dev] [PATCH] compress/qat: use compression specific driver name

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 5:18 PM To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo ; Jozwiak, TomaszX Cc: Trahe, Fiona Subject: [PATCH] compress/qat: use compression specific driver name The QAT compression driver was named "qat"

Re: [dpdk-dev] [PATCH v3 6/6] doc/qat: describe build config options

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:11 PM To: dev@dpdk.org; De Lara Guarch, Pablo ; Jozwiak, TomaszX ; tho...@monjalon.net Cc: Trahe, Fiona Subject: [PATCH v3 6/6] doc/qat: describe build config options Added description of the build configuration op

Re: [dpdk-dev] [PATCH v3 4/6] doc/qat: add overview of doc sections

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:11 PM To: dev@dpdk.org; De Lara Guarch, Pablo ; Jozwiak, TomaszX ; tho...@monjalon.net Cc: Trahe, Fiona Subject: [PATCH v3 4/6] doc/qat: add overview of doc sections Add overview of QAT doc sections and link betwee

Re: [dpdk-dev] [PATCH v3 3/6] doc/qat: fix typos and make cosmetic changes

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:11 PM To: dev@dpdk.org; De Lara Guarch, Pablo ; Jozwiak, TomaszX ; tho...@monjalon.net Cc: Trahe, Fiona Subject: [PATCH v3 3/6] doc/qat: fix typos and make cosmetic changes Signed-off-by: Fiona Trahe Acked-by: tom

Re: [dpdk-dev] [PATCH v3 1/6] doc/qat: add limitations to compressdev PMD

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:11 PM To: dev@dpdk.org; De Lara Guarch, Pablo ; Jozwiak, TomaszX ; tho...@monjalon.net Cc: Trahe, Fiona Subject: [PATCH v3 1/6] doc/qat: add limitations to compressdev PMD Add 2 missing limitations to QAT compressd

Re: [dpdk-dev] [PATCH v3 2/6] doc/qat: add information on how to test

2018-08-13 Thread Jozwiak, TomaszX
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:11 PM To: dev@dpdk.org; De Lara Guarch, Pablo ; Jozwiak, TomaszX ; tho...@monjalon.net Cc: Trahe, Fiona Subject: [PATCH v3 2/6] doc/qat: add information on how to test Add section to common QAT part of doc about wh

[dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses

2018-08-13 Thread Rahul Lakkireddy
From: Shagun Agrawal Add actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkired

[dpdk-dev] [RFC v2 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-08-13 Thread Rahul Lakkireddy
This series of patches add support for actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. - SET_TP_SRC - set a new TCP/UDP source port numb

[dpdk-dev] [RFC v2 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address

2018-08-13 Thread Rahul Lakkireddy
From: Shagun Agrawal Query firmware for the new filter work request to offload flows with actions to modify IP and TCP/UDP port addresses. When available, translate IP and TCP/UDP port address modify actions to internal hardware specification and offload the flow to hardware. Signed-off-by: Shag

[dpdk-dev] [RFC v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-08-13 Thread Rahul Lakkireddy
From: Shagun Agrawal Add actions: - SET_TP_SRC - set a new TCP/UDP source port number. - SET_TP_DST - set a new TCP/UDP destination port number. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- v2: - Remove OpenFlow prefix from TCP/UDP port rewrite actions. - Re-based to tip.

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-13 Thread Matteo Lanzuisi
Any suggestion? any idea about this behaviour? Il 08/08/2018 11:56, Matteo Lanzuisi ha scritto: Hi all, recently I began using "dpdk-17.11-11.el7.x86_64" rpm (RedHat rpm) on RedHat 7.5 kernel 3.10.0-862.6.3.el7.x86_64 as a porting of an application from RH6 to RH7. On RH6 I used dpdk-2.2.0.

[dpdk-dev] [PATCH v2] bus/pci: check if 5-level paging is enabled when testing IOMMU address width

2018-08-13 Thread Drocula
The kernel version 4.14 released with the support of 5-level paging. When PML5 enabled, user-space virtual addresses uses up to 56 bits. see kernel's Documentation/x86/x86_64/mm.txt. Signed-off-by: ZY Qiu --- drivers/bus/pci/linux/pci.c | 33 ++--- 1 file changed, 30

Re: [dpdk-dev] [PATCH] version: 18.11-rc0

2018-08-13 Thread Thomas Monjalon
13/08/2018 12:07, Mcnamara, John: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Start version numbering for a new release cycle, and introduce a template > > file for release notes. > > > > The release notes comments have a new block to suggest the order of items, > > inspired by F

[dpdk-dev] [PATCH] app/test-pmd: add and identify shaper profile parameters

2018-08-13 Thread Rosen Xu
As struct rte_tm_shaper_params defined, the command line of test-pmd should include committed and peak parameters, but right now the command line doesn't identify whether it's committed or peak parameter. This patch identifies and adds the clarify definition Signed-off-by: Rosen Xu Fixes: bddc2f4

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-13 Thread Rahul Lakkireddy
On Tuesday, August 08/07/18, 2018 at 14:20:10 +, Jack Min wrote: > There is a need to offload rewrite MAC address for both destination and source > from the matched flow > > The proposed actions could make above easily achieved > +1. We're also looking to offload these actions. In addition,

Re: [dpdk-dev] [PATCH] version: 18.11-rc0

2018-08-13 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, August 11, 2018 11:12 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Mcnamara, John > > Subject: [PATCH] version: 18.11-rc0 > > Start version numbering for a new release cycle, and introduce a temp

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-13 Thread Bruce Richardson
On Mon, Aug 13, 2018 at 12:52:19PM +0530, Joseph, Anoob wrote: > Hi Bruce, Pablo, > > If there are no more issues about the approach, can you review the patches > and give the feedback? > > Please do note that this series doesn't add any event mode specific code. > That will come as a different p

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-08-13 Thread Andrew Rybchenko
On 13.08.2018 05:50, Lu, Wenzhuo wrote: Hi Thomas, -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Wednesday, August 1, 2018 11:37 PM To: Lu, Wenzhuo ; Andrew Rybchenko ; Yigit, Ferruh Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix device i

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

2018-08-13 Thread Dekel Peled
Adding relevant maintainers. > -Original Message- > From: Dekel Peled [mailto:dek...@mellanox.com] > Sent: Monday, August 13, 2018 10:47 AM > To: dev@dpdk.org > Cc: Ori Kam ; Shahaf Shuler > > Subject: [RFC] ethdev: support metadata as flow rule criteria > > Current implementation of rt

[dpdk-dev] [RFC] ethdev: add tail drop API for traffic management

2018-08-13 Thread Rosen Xu
This patch introduces new ethdev generic Tail Drop API for Traffic Management, which is yet another standard congestion management offload for Ethernet devices. Tail Drop is about packets dropping when they arrive on a congested interface buffer. It's one mode of congestion management for hierarch

Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start

2018-08-13 Thread Shahaf Shuler
Hi Stephan, Thursday, August 2, 2018 1:00 AM, Stephen Hemminger: > Subject: [RFC] mlx5: fix error unwind in device start > > The error handling in start of the mlx5 driver is buggy. > For example, if setting up the flows fails the device driver will then get > stuck > in mlx5_flow_rxq_flags_clea

[dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

2018-08-13 Thread Dekel Peled
Current implementation of rte_flow allows match pattern of flow rule, based on packet data or header fields. This limits the application use of match patterns. For example, consider a vswitch application which controls a set of VMs, connected with virtio, in a fabric with overlay of VXLAN. Several

Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

2018-08-13 Thread Xing, Beilei
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, August 10, 2018 4:58 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and > FDIR > > 10/08/2018 04:31,

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-13 Thread Joseph, Anoob
Hi Bruce, Pablo, If there are no more issues about the approach, can you review the patches and give the feedback? Please do note that this series doesn't add any event mode specific code. That will come as a different patch series after incorporating Jerin's comments. Thanks, Anoob On 02-

[dpdk-dev] [PATCH] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default

2018-08-13 Thread Shahaf Shuler
On ConnectX-4 Lx the Multi Packet Send (MPW) feature is considered un-secure, as on some cases were the application provides incorrect mbufs on the Tx burst the host or NIC can get stuck. Hence, disabling the feature by default for this specific NIC. Users can still enable this feature and enjoy t