Re: [dpdk-dev] [PATCH 2/2] raw/skeleton: implement queue count API

> On Jul 31, 2018, at 5:33 AM, Shreyansh Jain wrote: > > Use the rte_rawdev_queue_count API in skeleton and add its unit test > case. > > Signed-off-by: Shreyansh Jain > --- > drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 13 + > drivers/raw/skeleton_rawdev/skeleton_rawdev_

Re: [dpdk-dev] [PATCH 1/2] rawdev: fix missing queue count API

> On Jul 31, 2018, at 5:33 AM, Shreyansh Jain wrote: > > Rawdev queue count API prototype was declared, but the definition was > missing from the library. This patch implements the function. > > This API is used to query the device about the count of queues it has > been configured with. > >

[dpdk-dev] [PATCH v2] ring: fix c11 memory ordering issue

This patch includes two bug fixes(#1 and 2) and two optimisations(#3 and #4). 1) In update_tail, read ht->tail using __atomic_load.Although the compiler currently seems to be doing the right thing even without _atomic_load, we don't want to give the compiler freedom to optimise what should

[dpdk-dev] [PATCH v2] eal/vfio: fix sPAPR IOMMU mapping

Commit 73a639085938 ("vfio: allow to map other memory regions") introduced a bug in sPAPR IOMMU mapping. The commit removed necessary ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, vfio_spapr_map_walk should call vfio_spapr_dma_do_map instead of vfio_spapr_dma_mem_map. Fixes: 73a639085938 ("vf

[dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping

Commit 73a639085938 ("vfio: allow to map other memory regions") introduced a bug in sPAPR IOMMU mapping. The commit removed necessary ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, vfio_spapr_map_walk should call vfio_spapr_dma_do_map instead of vfio_spapr_dma_mem_map. Fixes: 73a639085938 ("vf

Re: [dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping

>06/08/2018 10:43, Takeshi Yoshimura: >> Commit 73a639085938 ("vfio: allow to map other memory regions") >> introduced a bug in sPAPR IOMMU mapping. The commit removed >necessary >> ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, >vfio_spapr_map_walk >> should call vfio_spapr_dma_do_map instead

[dpdk-dev] [PATCH v2] net/i40e: stop lldp before setting local lldp MIB

From: "Charles (Chas) Williams" >From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction Update: Starting from NVM 5.02, if the Set Local LLDP MIB command is received while the DCBx specific agent is stopped, the command returns an EPERM error. If the command is received wh

Re: [dpdk-dev] [PATCH] net/mlx5: prohibit wildcard match for GRE protocol

On Sun, Aug 05, 2018 at 12:01:01AM -0700, Matan Azrad wrote: > Hi > More info below... > > From: Matan Azrad > > Hi Koh > > > > From: Yongseok Koh > > > Currently, driver sets full mask (0x) for GRE protocol to device. > > > Until it is changed, PMD can't support wildcard match. > > > > > > F

[dpdk-dev] i40e VMDQ behavior

How is VMDQ supposed to work? The i40e .dev_infos_get doesn't seem to look for the VMDQ enabled flag and just goes ahead and modifies the queue counts to include the VMDQ queues: if (pf->flags & I40E_FLAG_VMDQ) { dev_info->max_vmdq_pools = pf->max_nb_vmdq_vsi;

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi Chas From: Chas Williams >On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad wrote: >Hi Chas > >From: Chas Williams >>On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad >>wrote: >>Hi Chas >> >> From: Chas Williams [mailto:mailto:mailto:mailto:3c

Re: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB

On Thu, Aug 2, 2018 at 10:10 PM Zhang, Qi Z wrote: > > > > > *From:* Chas Williams [mailto:3ch...@gmail.com] > *Sent:* Friday, August 3, 2018 5:20 AM > *To:* Zhang, Qi Z > *Cc:* dev@dpdk.org; Xing, Beilei ; Chas Williams < > ch...@att.com> > *Subject:* Re: [PATCH] net/i40e: stop lldp before sett

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad wrote: > Hi Chas > > From: Chas Williams > >On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad > wrote: > >Hi Chas > > > > From: Chas Williams [mailto:mailto:3ch...@gmail.com] On Thu, Aug 2, > 2018 at 1:33 > >> PM Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix sanity check for MPLS-in-GRE

On Sun, Aug 05, 2018 at 04:17:21AM -0700, Shahaf Shuler wrote: > Sunday, August 5, 2018 9:41 AM, Matan Azrad: > > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix sanity check for MPLS-in-GRE > > > > Hi Koh > > > > From: Yongseok Koh > > > Multiple tunnel isn't allowed but MPLS over GRE should be ac

[dpdk-dev] [PATCH 1/2] netvsc: support packet type

The Netvsc PMD was not filling in the packet type information. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_rxt

[dpdk-dev] [PATCH 2/2] netvsc: report checksum failures

The host will notify netvsc device about failed UDP and TCP checksum. Propogate that information into the mbuf. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c ind

[dpdk-dev] [PATCH 0/2] netvsc: small patches

A couple of small missing features discovered during later testing. The netvsc PMD was not setting packet type or reporting checksum failures. Stephen Hemminger (2): netvsc: support packet type netvsc: report checksum failures drivers/net/netvsc/hn_rxtx.c | 13 +++-- 1 file changed,

[dpdk-dev] [Bug 79] ACL doesn't match a rule with a first `TYPE_MASK` field with low mask when there's a large number of rules

https://bugs.dpdk.org/show_bug.cgi?id=79 Bug ID: 79 Summary: ACL doesn't match a rule with a first `TYPE_MASK` field with low mask when there's a large number of rules Product: DPDK Version: 18.05 Hardwa

[dpdk-dev] [PATCH 2/3] vmbus: make sure path is null terminated

Use strlcpy rather than strncpy to avoid any issues about null termination. Coverity issue 302859 Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[dpdk-dev] [PATCH 3/3] vmbus: handle eof on irq read

This function is not used by netvsc driver yet. Still the code should handle case where device driver returns zero (due to rescind). Coverity issue: 302871 Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c

[dpdk-dev] [PATCH 1/3] vmbus: close directory in error path

Fix bug reported by Coverity where directory being scanned was not closed in error path (leaking file descriptor). Coverity issue: 302848 Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 1 + 1 file chan

[dpdk-dev] [PATCH 0/3] vmbus: coverity bug fixes

Recent Covertity scan reported some issues in code that is unlikely to be used, but fix it anyway. Stephen Hemminger (3): vmbus: close directory in error path vmbus: make sure path is null terminated vmbus: handle eof on irq read drivers/bus/vmbus/linux/vmbus_uio.c | 20 ++-

Re: [dpdk-dev] [PATCH] ethdev: bump library version

On 06.08.2018 13:55, Thomas Monjalon wrote: The old offload API is removed in 18.08, so the library version must be increased, in order to show the incompatibility with 18.05 one. Fixes: ab3ce1e0c193 ("ethdev: remove old offload API") Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchen

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi Chas From: Chas Williams >On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad wrote: >Hi Chas > > From: Chas Williams [mailto:mailto:3ch...@gmail.com] On Thu, Aug 2, 2018 at >1:33 >> PM Matan Azrad wrote: >> > >> > > I suggest to do it like next,

Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash

On Sat, 4 Aug 2018 06:42:53 + Gavin Hu wrote: > Hi Stephen, > > I am no sure only supporting bash is acceptable or not. Any impact to freebsd? > > We should seek wider opinions about this. > > I did not meet your problem, either bash or dash, what's your shell? > > Best Regards, > Gavin

[dpdk-dev] [Bug 78] Mismatch between return value and documentation for `rte_hash_lookup_data` (cuckoo hashing implementation)

https://bugs.dpdk.org/show_bug.cgi?id=78 Bug ID: 78 Summary: Mismatch between return value and documentation for `rte_hash_lookup_data` (cuckoo hashing implementation) Product: DPDK Version: 18.05 Hardware: All

[dpdk-dev] [PATCH] doc: clarify usage of netvsc PMD

Since netvsc PMD does not support SR-IOV accelerated networking, it is not recommended for use on Azure. Make this clear in the guide. Signed-off-by: Stephen Hemminger --- doc/guides/nics/netvsc.rst | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/doc/guides/

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad wrote: > Hi Chas > > From: Chas Williams [mailto:3ch...@gmail.com] On Thu, Aug 2, 2018 at 1:33 > > PM Matan Azrad wrote: > > > > > > > I suggest to do it like next, > > > > To add one more parameter for LACP which means how to configure the > > > LACP

Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon wrote: > 02/08/2018 15:38, Doherty, Declan: > > On 01/08/2018 2:18 PM, Radu Nicolau wrote: > > > When a bonding port is stopped also stop and deactivate all slaves. > > > Otherwise slaves will be still listed as active. > > > > > > Fixes: 69bce062132

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix RSS

After adding RSS hash offload checks, flags that are not supported by the current device result in RSS configuration failing as opposed to unsupported flags being silently discarded. This fix is making sure that only device supported flags are passed to RSS configuration. Fixes: aa1a6d87f15d ("eth

[dpdk-dev] [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules

Partial bit-masks are in fact supported on TCP/UDP source/destination ports. Remove unnecessary check. Fixes: 2bfc777e07 ("net/mlx5: add L2-L4 pattern items to switch flow rules") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_nl_flow.c | 20 1 file changed, 20 d

Re: [dpdk-dev] [PATCH v2] net/tap: fix zeroed flow mask configurations

On Mon, Aug 06, 2018 at 10:58:47AM +, Matan Azrad wrote: > The rte_flow meaning of zero flow mask configuration is to match all > the range of the item value. > For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 > should much all the ipv4 traffic from the rte_flow API perspectiv

[dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

Signed-off-by: Drocula --- kernel/linux/kni/ethtool/igb/kcompat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h index 40a8d99..ae1b530 100644 --- a/kernel/linux/kni/ethtool/igb/kcompat.h +++ b/kernel/linux

[dpdk-dev] DPDK techboard minutes of August 1

Meeting notes for the DPDK technical board meeting held on 2018-08-01 It was a very short meeting without agenda. Several members were not present or active. 1/ Kevin Traynor did a comment about experimental API which can be forgotten and not be promoted as stable API. It is OK to keep API experi

[dpdk-dev] DPDK techboard minutes of July 18

Meeting notes for the DPDK technical board meeting held on 2018-07-18 Attendees: - Bruce Richardson - Ferruh Yigit - Jerin Jacob - Konstantin Ananyev - Olivier Matz - Thomas Monjalon 1/ Power management patches - examples/vm_power: 100% Bu

[dpdk-dev] [PATCH v2] net/tap: fix zeroed flow mask configurations

The rte_flow meaning of zero flow mask configuration is to match all the range of the item value. For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 should much all the ipv4 traffic from the rte_flow API perspective. >From some kernel perspectives the above rule means to ignore all

[dpdk-dev] [PATCH] ethdev: bump library version

The old offload API is removed in 18.08, so the library version must be increased, in order to show the incompatibility with 18.05 one. Fixes: ab3ce1e0c193 ("ethdev: remove old offload API") Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/release_18_08.rst | 13 - lib/librte

Re: [dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations

Hi Adrien From: Adrien Mazarguil > On Sun, Aug 05, 2018 at 06:10:55AM +, Matan Azrad wrote: > > Hi Adrien > > > > From: Adrien Mazarguil > > > Hi Matan, > > > > > > On Thu, Aug 02, 2018 at 05:52:18PM +, Matan Azrad wrote: > > > > Hi Adrien > > > > > > > > From: Adrien Mazarguil > > > > > O

Re: [dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping

06/08/2018 10:43, Takeshi Yoshimura: > Commit 73a639085938 ("vfio: allow to map other memory regions") > introduced a bug in sPAPR IOMMU mapping. The commit removed necessary > ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, vfio_spapr_map_walk > should call vfio_spapr_dma_do_map instead of vfio

Re: [dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations

On Sun, Aug 05, 2018 at 06:10:55AM +, Matan Azrad wrote: > Hi Adrien > > From: Adrien Mazarguil > > Hi Matan, > > > > On Thu, Aug 02, 2018 at 05:52:18PM +, Matan Azrad wrote: > > > Hi Adrien > > > > > > From: Adrien Mazarguil > > > > On Thu, Aug 02, 2018 at 10:33:00AM +, Matan Azrad w

Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

06/08/2018 07:45, Beilei Xing: > This patch adds bitmask support for RSS, FDIR > and FDIR flexible payload. > > Signed-off-by: Beilei Xing Flow director API is deprecated for almost 2 years: http://git.dpdk.org/dpdk/commit/?id=7fdcde6 We asked several times to stop using it in i40e. It h

Re: [dpdk-dev] [PATCH] ring: fix c11 memory ordering issue

Hi, Please start your patch by explaining the issue you are solving. What is the consequence of the bug on the behaviour? What is the scope of the bug? only PPC? 06/08/2018 03:18, Gavin Hu: > 1) In update_tail, read ht->tail using __atomic_load. > 2) In __rte_ring_move_prod_head, move the __atomi

[dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping

Commit 73a639085938 ("vfio: allow to map other memory regions") introduced a bug in sPAPR IOMMU mapping. The commit removed necessary ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, vfio_spapr_map_walk should call vfio_spapr_dma_do_map instead of vfio_spapr_dma_mem_map. Fixes: 73a639085938 ("vf