[dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2018-08-05 Thread Raslan Darawsheh
Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_18_08.rst | 150 + 1 file changed, 150 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index 9849fec..0338de5 100644 --- a/doc/guides/rel_n

[dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

2018-08-05 Thread Beilei Xing
This patch adds bitmask support for RSS, FDIR and FDIR flexible payload. Signed-off-by: Beilei Xing --- app/test-pmd/cmdline.c | 199 +--- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +- 2 files changed, 187 insertions(+), 20 deletions(-) diff

[dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2018-08-05 Thread Lijuan Tu
Add tested Intel platforms with Intel NICs to the release note. Signed-off-by: Lijuan Tu --- doc/guides/rel_notes/release_18_08.rst | 74 ++ 1 file changed, 74 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08

[dpdk-dev] [PATCH] ring: fix c11 memory ordering issue

2018-08-05 Thread Gavin Hu
1) In update_tail, read ht->tail using __atomic_load. 2) In __rte_ring_move_prod_head, move the __atomic_load_n up and out of the do {} while loop as upon failure the old_head will be updated, another load is not necessary. 3) Synchronize the load-acquires of prod.tail and cons.tail with stor

[dpdk-dev] [dpdk-announce] release candidate 18.08-rc3

2018-08-05 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v18.08-rc3 It should be the last release candidate before the release 18.08.0, next week. In order to prepare the next cycle, the deprecation notices must be reviewed, and the roadmap topics proposed on t

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

2018-08-05 Thread Thomas Monjalon
02/08/2018 11:25, Shreyansh Jain: > On Wednesday 01 August 2018 05:37 PM, Anatoly Burakov wrote: > > Due to the upcoming external memory support [1], some API and ABI > > changes will be required. In addition, although the changes called > > out in the deprecation notice are not yet present in form

Re: [dpdk-dev] [PATCH] meter: remove experimental from profile APIs

2018-08-05 Thread Thomas Monjalon
> > As per guideline that new APIs must be experimental > > for at least one release, it is now possible to remove > > the experimental tag from: > > > > rte_meter_srtcm_profile_config() > > rte_meter_trtcm_profile_config() > > > > Cc: Cristian Dumitrescu > > Signed-off-by: Kevin Traynor > > T

Re: [dpdk-dev] [PATCH 0/3] deprecate attach and detach functions

2018-08-05 Thread Thomas Monjalon
01/08/2018 18:26, Stephen Hemminger: > On Wed, 11 Jul 2018 15:14:07 +0100 > Andrew Rybchenko wrote: > > > As discussed in [1] EAL hotplug should be used directly to add/remove > > devices. > > > > app/pdump changes are build-tested only. > > > > [1] http://mails.dpdk.org/archives/dev/2018-July

Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

2018-08-05 Thread Thomas Monjalon
02/08/2018 15:38, Doherty, Declan: > On 01/08/2018 2:18 PM, Radu Nicolau wrote: > > When a bonding port is stopped also stop and deactivate all slaves. > > Otherwise slaves will be still listed as active. > > > > Fixes: 69bce062132b ("net/bonding: do not clear active slave count") > > Cc: sta...@d

Re: [dpdk-dev] [PATCH] doc: announce deprecation of flow copy function

2018-08-05 Thread Thomas Monjalon
03/08/2018 16:37, Adrien Mazarguil: > +* ethdev: flow API function ``rte_flow_copy()`` will be deprecated in v18.11 > + in favor of ``rte_flow_conv()`` (which will appear in that version) and > + subsequently removed for v19.02. > + > + This is due to a lack of flexibility and reliance on a type

Re: [dpdk-dev] [PATCH v2 1/2] eal: remove deprecated function returning mbuf pool ops name

2018-08-05 Thread Thomas Monjalon
26/07/2018 23:42, Thomas Monjalon: > 26/06/2018 11:56, Olivier Matz: > > rte_eal_mbuf_default_mempool_ops() is replaced by > > rte_mbuf_best_mempool_ops(). > > > > Signed-off-by: Olivier Matz > > --- > > > > v2: > > * remove rte_eal_mbuf_user_pool_ops from .map in next patch instead of this > >

Re: [dpdk-dev] [PATCH v2 1/2] mempool: remove deprecated functions

2018-08-05 Thread Thomas Monjalon
27/07/2018 15:46, Andrew Rybchenko: > Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and > rte_mempool_populate_phys_tab() are just wrappers for corresponding > IOVA functions and were deprecated in v17.11. > > Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(), > rte_memp

Re: [dpdk-dev] [PATCH 1/2] doc: add multithread description to hash library

2018-08-05 Thread Thomas Monjalon
Pablo, Marko, review please? 26/07/2018 19:56, Yipeng Wang: > Added multithreading related description into programmer > guide of hash library. > > Signed-off-by: Yipeng Wang

Re: [dpdk-dev] [PATCH v2] examples/l3fw-power: do not exit on power lib init failure

2018-08-05 Thread Thomas Monjalon
No review? 27/07/2018 11:53, Radu Nicolau: > Do not exit the application if power library fails to initialize > or high performance cores configuration cannot be used. > > Signed-off-by: Radu Nicolau > --- > v2: updated init_power_library to return error code if any core init fails > > > exam

Re: [dpdk-dev] [PATCH v4] examples/flow_filtering: add rte_fdir_conf initialization

2018-08-05 Thread Thomas Monjalon
31/07/2018 14:52, Rosen Xu: > Rte_fdir_conf of rte_eth_conf should be initialized before > port initialization. It is a workaround solution when working > with Intel I40e. > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API") > Cc: sta...@dpdk.org > > Signed-off-by: Ros

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix RSS

2018-08-05 Thread Thomas Monjalon
31/07/2018 16:49, Cristian Dumitrescu: > Fix for RSS issue triggered by latest changes in ethdev layer. > > Signed-off-by: Cristian Dumitrescu Collected agreements: Acked-by: Fan Zhang Acked-by: Konstantin Ananyev Tested-by: Yuan Peng But 3 things are missing: - The issue

[dpdk-dev] [PATCH] Fix a doxygen comment of rte_eth_dev_allocate()

2018-08-05 Thread Rami Rosen
This patch fixes a doxygen comment of the rte_eth_dev_allocate() method. There is no parameter named "type" for this method; so this patch removes the doxygen comment about it. Signed-off-by: Rami Rosen --- lib/librte_ethdev/rte_ethdev_driver.h | 1 - 1 file changed, 1 deletion(-) diff --git a

Re: [dpdk-dev] [PATCH v2] examples/multi_process: remove l2fwd fork example

2018-08-05 Thread Thomas Monjalon
30/07/2018 17:10, Gage Eads: > l2fwd_fork relies on a multiprocess model that that DPDK does not support > (calling rte_eal_init() before fork()), in particular in light of recent > EAL changes like the multiproess communication channel. > > This example can mislead users into thinking this is a s

[dpdk-dev] [PATCH] bus/pci: check if 5-level paging is enabled when testing IOMMU address width

2018-08-05 Thread Drocula
The kernel version 4.14 released with the support of 5-level paging. When PML5 enabled, user-space virtual addresses uses up to 56 bits. see kernel's Documentation/x86/x86_64/mm.txt. Signed-off-by: Drocula --- drivers/bus/pci/linux/pci.c | 27 +-- 1 file changed, 25 inser

Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline

2018-08-05 Thread Thomas Monjalon
01/08/2018 19:47, Dumitrescu, Cristian: > > 20/07/2018 15:09, Kevin Laatz: > > > Add a note to the 'link' command in the IP Pipeline documentation > > > specifying the PCI device name format required to run the application. > > > > > > Signed-off-by: Kevin Laatz > > Acked-by: Cristian Dumitrescu

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix bitmap documentation

2018-08-05 Thread Thomas Monjalon
02/08/2018 16:34, Dumitrescu, Cristian: > > 17/07/2018 19:14, Jerin Jacob: > > > n_bits comes as first argument, align doxygen comment. > > > > > > n_bit need to not be multiple of 512 as n_bits > > > are rounding to RTE_BITMAP_CL_BIT_SIZE. > > > > > > Fixes: 14456f59e9f7 ("doc: fix doxygen warning

Re: [dpdk-dev] [PATCH v4] rte_ring: clarify preemptible nature of ring algorithm

2018-08-05 Thread Thomas Monjalon
03/08/2018 17:09, Olivier Matz: > On Mon, Jul 16, 2018 at 11:52:44PM -0500, Honnappa Nagarahalli wrote: > > rte_ring implementation is not preemptible only under certain > > circumstances. This clarification is helpful for data plane and > > control plane communication using rte_ring. > > > > Sign

Re: [dpdk-dev] [PATCH v2] mempool: check for invalid args on creation

2018-08-05 Thread Thomas Monjalon
02/08/2018 13:10, Andrew Rybchenko: > On 02.08.2018 03:35, Pablo de Lara wrote: > > Currently, a mempool can be created if the number of > > objects is zero. However, in this scenario, > > rte_mempool_create should return NULL, > > as the mempool created is useless otherwise. > > > > Signed-off-by:

Re: [dpdk-dev] [PATCH v2] ethdev: decrease log level for successful API

2018-08-05 Thread Thomas Monjalon
03/08/2018 10:04, Andrew Rybchenko: > On 02.08.2018 21:39, Kevin Traynor wrote: > > Change log level of messages from ERR to INFO where > > the post condition of the API is success, but no action > > was actually needed as the condition already existed. > > e.g. calling rte_eth_dev_start() for a de

Re: [dpdk-dev] [pull-request] next-crypto 18.08-rc3

2018-08-05 Thread Thomas Monjalon
03/08/2018 09:22, Pablo de Lara: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

2018-08-05 Thread Thomas Monjalon
Konstantin, Is it candidate for last minute fix in 18.08? 02/08/2018 04:01, Li Han: > in struct ip_frag_key,src_dst[] type is uint64_t. > but "val" which to store the calc restult ,type is uint32_t. > we may lost high 32 bit key. and function return value is int, > but it won't return < 0. > > S

Re: [dpdk-dev] [PATCH v2] event: fix check in ring init() in event ring code

2018-08-05 Thread Thomas Monjalon
02/08/2018 16:43, Harry van Haaren: > This commit fixes a bug in a 32-bit environment where the > generic ring_init() would fail, but given the interaction > with memzones the next iteration of the event_ring_autotest > would actually *pass* because the ring in question would > exist already an be

Re: [dpdk-dev] [PATCH] net/mlx5: fix minimum number of Multi-Packet RQ buffers

2018-08-05 Thread Shahaf Shuler
Friday, August 3, 2018 12:00 AM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix minimum number of Multi-Packet RQ buffers > > If MPRQ is enabled, a PMD-private mempool is allocated. For ConnectX-4 Lx, > the minimum number of strides is 512 which ConnectX-5 supports 8. This > results in quite small

Re: [dpdk-dev] [PATCH] net/mlx5: fix sanity check for MPLS-in-GRE

2018-08-05 Thread Shahaf Shuler
Sunday, August 5, 2018 9:41 AM, Matan Azrad: > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix sanity check for MPLS-in-GRE > > Hi Koh > > From: Yongseok Koh > > Multiple tunnel isn't allowed but MPLS over GRE should be accepted. > > > > Fixes: a4a5cd21d20a ("net/mlx5: add flow MPLS item") > > > >

[dpdk-dev] [PATCH] doc: update mlx4 and mlx5 release notes

2018-08-05 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx4.rst | 2 +- doc/guides/nics/mlx5.rst | 2 +- doc/guides/rel_notes/release_18_08.rst | 12 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: preserve promisc flag for flow isolation mode

2018-08-05 Thread Shahaf Shuler
Friday, August 3, 2018 12:07 AM, Yongseok Koh: > Subject: [PATCH v2 1/2] net/mlx5: preserve promisc flag for flow isolation > mode > > mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous > mode as it can't be enabled in flow isolation mode. If the function pointers > are null

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix commands to config some offload

2018-08-05 Thread Thomas Monjalon
03/08/2018 14:55, Wei Dai: > Without this patch, testpmd command to config Rx offload keep_crc > would fail and report "Bad argument". > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Fixes: c73a907187

Re: [dpdk-dev] [PATCH 1/3] net/softnic: add softnic documentation

2018-08-05 Thread Thomas Monjalon
24/07/2018 17:50, Jasvinder Singh: > Add softnic documentation to NIC drivers guide. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Jasvinder Singh Series applied, thanks

[dpdk-dev] [PATCH] devtools: fix symbol check for dash

2018-08-05 Thread Thomas Monjalon
The script check-symbol-change.sh was not running when /bin/sh redirects to dash. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: nhor...@tuxdriver.com Reported-by: Stephen Hemminger Signed-off-by: Thomas Monjalon --- devtools/check-symbol-change.sh | 10 +- 1

Re: [dpdk-dev] [PATCH 0/4] netvsc PMD performance fixes

2018-08-05 Thread Thomas Monjalon
24/07/2018 23:08, Stephen Hemminger: > The netvsc PMD is faster than the kernel but is still slow > on receiving packets. These patches help. > > Stephen Hemminger (4): > netvsc: change rx descriptor setup and sizing > netvsc: avoid over filling receive descriptor ring > netvsc: implement qu

Re: [dpdk-dev] [PATCH] net/mlx5: prohibit wildcard match for GRE protocol

2018-08-05 Thread Matan Azrad
Hi More info below... From: Matan Azrad > Hi Koh > > From: Yongseok Koh > > Currently, driver sets full mask (0x) for GRE protocol to device. > > Until it is changed, PMD can't support wildcard match. > > > > Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") > > Cc: sta...@dpdk.org > > > >