Hi Stephen,
I am no sure only supporting bash is acceptable or not. Any impact to freebsd?
We should seek wider opinions about this.
I did not meet your problem, either bash or dash, what's your shell?
Best Regards,
Gavin
> -Original Message-
> From: Stephen Hemminger
> Sent: Saturday
On Fri, Aug 03, 2018 at 01:31:48PM -0700, Stephen Hemminger wrote:
> Fix spelling errors in messages and comments.
>
> Signed-off-by: Stephen Hemminger
> ---
Hi Stephen,
'initialise' is accepted, not a typo. AFAIK, it is 'British' way.
Same for 'recognised' and 'finalise'. I don't want to enfor
On Wed, 1 Aug 2018 13:22:57 +0800
Gavin Hu wrote:
> When running checkpatch.sh, it generates the following error
> on some linux distributions(like Debian) with Dash as the
> default shell interpreter.
> trap: SIGINT: bad trap
>
> The fix is to replace SIGINT with INT signal, it works for
> bot
Multiple tunnel isn't allowed but MPLS over GRE should be accepted.
Fixes: a4a5cd21d20a ("net/mlx5: add flow MPLS item")
Signed-off-by: Yongseok Koh
---
drivers/net/mlx5/mlx5_flow.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net
Fix spelling errors in messages and comments.
Signed-off-by: Stephen Hemminger
---
drivers/net/mlx5/mlx5_ethdev.c | 2 +-
drivers/net/mlx5/mlx5_flow.c | 4 ++--
drivers/net/mlx5/mlx5_mr.c | 8
drivers/net/mlx5/mlx5_rxq.c| 20 ++--
drivers/net/mlx5/mlx5_rxtx.
> On Aug 3, 2018, at 7:06 AM, Keith Wiles wrote:
>
> Signed-off-by: Keith Wiles
> ---
Acked-by: Yongseok Koh
Thanks
The following changes since commit e94be227b7ea025d8fd0ee5d79052a8c31d432c6:
net/dpaa2: remove loop for unused pool entries (2018-08-03 17:09:44 +0200)
are available in the Git repository at:
http://dpdk.org/git/next/dpdk-next-crypto
for you to fetch changes up to fb33043c4552e1166bbb3a8d9
On Wed, 1 Aug 2018 08:57:39 -0400
Michel Machado wrote:
> On 07/31/2018 09:40 PM, Wang, Yipeng1 wrote:
> > How about an API that is more universal? For example, an API such as
> > "rte_iterate_conflict_entries". After an insertion failure, this function
> > will iterate all entries that may co
31/07/2018 15:52, Shreyansh Jain:
> On 7/31/2018 1:21 PM, Gavin Hu wrote:
> > Currently only one buffer pool is configured and in use,
> > looping for up to maxmum 8 times is unnecessary and might
> > be buggy as assigned uninititalized values.
> >
> > The fix is to loop for the configured times w
On Mon, Jul 16, 2018 at 11:52:44PM -0500, Honnappa Nagarahalli wrote:
> rte_ring implementation is not preemptible only under certain
> circumstances. This clarification is helpful for data plane and
> control plane communication using rte_ring.
>
> Signed-off-by: Honnappa Nagarahalli
> Reviewed-
03/08/2018 16:16, Parthasarathy, JananeeX M:
> Hi Thomas,
>
> From: Pattan, Reshma
> >
> >Hi Thomas,
> >
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >> 01/08/2018 00:18, Reshma Pattan:
> >> > v10: fixed clang compiler issues and freed latency stats memzone in
> >> > latency stats unit
27/07/2018 17:47, Rasesh Mody:
> We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing
> tag from all the source file. Remove the LICENSE.bnx2x_pmd file and
> directly include SPDX tags in source files.
>
> Signed-off-by: Rasesh Mody
> Acked-by: Hemant Agrawal
Applied
27/07/2018 17:45, Rasesh Mody:
> Originally the PMD had "QLogic Corporation" copyright. When we submitted
> commit e3de5dad2a5d ("net/bnx2x: change copyright info to Cavium"),
> the "Qlogic Corporation" copyright was accidentally replaced
> with "Cavium Inc". So now we see multiple Cavium copyright
Signed-off-by: Adrien Mazarguil
Cc: Thomas Monjalon
Cc: Ferruh Yigit
Cc: Gaetan Rivet
---
doc/guides/rel_notes/deprecation.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index 14714fe94..05c77da65 1006
Update MAINTAINERSHIP for metrics unit test
Signed-off-by: Hari Kumar Vemula
Reviewed-by: Reshma Pattan
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3b9fec76f..7057b8a0c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1140,6 +1140,7 @@ F: do
added metrics unit test to autotest list.
Signed-off-by: Hari Kumar Vemula
Reviewed-by: Reshma Pattan
---
test/test/autotest_data.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index f68d9b111..9fc4f2fbc 100644
--- a/test/tes
1/3: add unit tests for metrics library
2/3: add new unit tests to autotest list
3/3: updated maintainer for metrics test
Signed-off-by: Hari Kumar Vemula
Reviewed-by: Reshma Pattan
Acked-by: Reshma Pattan
---
v3: Resolved clang compilation issue,
changed the expected value of tests in tes
Unit testcases are added for metrics library.
Signed-off-by: Hari Kumar Vemula
Reviewed-by: Reshma Pattan
Reviewed-by: Remy Horton
Acked-by: Remy Horton
---
test/test/Makefile | 2 +
test/test/test_metrics.c | 312 +++
2 files changed, 314 i
On 07/31/2018 09:40 PM, Wang, Yipeng1 wrote:
How about an API that is more universal? For example, an API such as
"rte_iterate_conflict_entries". After an insertion failure, this function will
iterate all entries that may conflict with the newly inserted key and you could decide
which entry t
Hi Thomas,
>-Original Message-
>From: Pattan, Reshma
>Sent: Friday, August 03, 2018 7:15 PM
>To: Thomas Monjalon ; Somarowthu, Naga SureshX
>
>Cc: dev@dpdk.org; Burakov, Anatoly ;
>Parthasarathy, JananeeX M
>Subject: RE: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and
>
03/08/2018 15:45, Pattan, Reshma:
> Hi Thomas,
>
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, August 1, 2018 8:52 AM
> >
> > 01/08/2018 00:18, Reshma Pattan:
> > > v10: fixed clang compiler issues and freed latency stats memzone in
> > > latency stats unit tests.
> > >
Signed-off-by: Keith Wiles
---
drivers/net/ixgbe/ixgbe_rxtx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index f82b74a9a..510c36c4c 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/
Signed-off-by: Keith Wiles
---
lib/librte_acl/rte_acl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_acl/rte_acl.c b/lib/librte_acl/rte_acl.c
index 2f1243cde..db7d3221e 100644
--- a/lib/librte_acl/rte_acl.c
+++ b/lib/librte_acl/rte_acl.c
@@ -16,7 +16,7 @@
03/08/2018 15:36, Adrien Mazarguil:
> Adrien Mazarguil (7):
> ethdev: add flow API object converter
> ethdev: add flow API item/action name conversion
> app/testpmd: rely on flow API conversion function
> net/failsafe: switch to flow API object conversion function
> net/bonding: switch to
Signed-off-by: Keith Wiles
---
lib/librte_bpf/bpf_load.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_bpf/bpf_load.c b/lib/librte_bpf/bpf_load.c
index 2b84fe724..d9d163b7d 100644
--- a/lib/librte_bpf/bpf_load.c
+++ b/lib/librte_bpf/bpf_load.c
@@ -131,7 +131,7 @@
Signed-off-by: Keith Wiles
---
drivers/net/virtio/virtio_rxtx_simple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_rxtx_simple.c
b/drivers/net/virtio/virtio_rxtx_simple.c
index 31e565b4c..f8bcbaa1c 100644
--- a/drivers/net/virtio/virtio_rxtx_simp
Signed-off-by: Keith Wiles
---
drivers/net/mlx5/mlx5_rxtx.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 2d14f8a6e..357c64838 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/ml
Signed-off-by: Keith Wiles
---
drivers/net/fm10k/fm10k_ethdev.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 541a49b75..e43b16d4e 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/d
Signed-off-by: Keith Wiles
---
drivers/net/i40e/i40e_rxtx.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 59a6a8adb..73499dfdd 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net
Signed-off-by: Keith Wiles
---
drivers/common/qat/qat_device.c | 12 ++--
drivers/common/qat/qat_qp.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index f32d72358..db01e5bc2 100644
--- a/drive
Signed-off-by: Keith Wiles
---
drivers/net/avf/avf_rxtx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index e03a136fc..1c1b1f05e 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -
Signed-off-by: Keith Wiles
---
lib/librte_eal/common/include/rte_common.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_common.h
b/lib/librte_eal/common/include/rte_common.h
index 069c13ec7..2c4535b1a 100644
--- a/lib/librte_eal/common/include/rte_com
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, August 1, 2018 8:52 AM
> To: Pattan, Reshma
> Cc: dev@dpdk.org; Burakov, Anatoly ;
> Parthasarathy, JananeeX M ;
> Somarowthu, Naga SureshX
> Subject: Re: [dpdk-dev] [PATCH v10 0/5] ad
This patch replaces rte_flow_copy() with rte_flow_conv().
Signed-off-by: Adrien Mazarguil
Cc: Declan Doherty
Cc: Chas Williams
--
v2 changes:
- Patch was not present in original series.
---
drivers/net/bonding/rte_eth_bond_api.c | 6 ++---
drivers/net/bonding/rte_eth_bond_flow.c| 31
This patch replaces rte_flow_copy() with rte_flow_conv().
Signed-off-by: Adrien Mazarguil
Cc: Gaetan Rivet
--
v2 changes:
- Patch was split from "ethdev: add flow API object converter".
---
drivers/net/failsafe/failsafe_ether.c | 6 +++---
drivers/net/failsafe/failsafe_flow.c| 31 ++
Several pattern items and actions were never handled by rte_flow_copy()
because their descriptions were missing. rte_flow_conv() inherited this
deficiency.
This patch adds them and reorders others to match rte_flow.h. It doesn't
pose as a fix because so far no one has complained about it and
rte_f
No users left for this function, time to deprecate it.
Signed-off-by: Adrien Mazarguil
Cc: Thomas Monjalon
Cc: Ferruh Yigit
Cc: Andrew Rybchenko
Cc: Gaetan Rivet
--
v2 changes:
- Patch was not present in original series.
---
lib/librte_ethdev/rte_flow.h | 7 ++-
1 file changed, 6 insert
This commit replaces all local information about pattern items and actions
as well as flow rule duplication code with calls to rte_flow_conv().
Signed-off-by: Adrien Mazarguil
Cc: Wenzhuo Lu
Cc: Jingjing Wu
Cc: Bernard Iremonger
---
app/test-pmd/config.c | 407 +++
This provides a means for applications to retrieve the name of flow pattern
items and actions.
Signed-off-by: Adrien Mazarguil
Cc: Thomas Monjalon
Cc: Ferruh Yigit
Cc: Andrew Rybchenko
--
v2 changes:
- Replaced rte_flow_conv_name_ptr() with extra is_ptr argument to
rte_flow_conv_name() sinc
rte_flow_copy() is bound to duplicate flow rule descriptions (attributes,
pattern and list of actions, all at once), however applications sometimes
need more flexibility, for instance the ability to duplicate only one of
the underlying objects (a single pattern item or action) or retrieve other
pro
This is a follow up to the "Flow API helpers enhancements" series submitted
almost a year ago [1]. The new title is due to the reduced scope of this
version.
rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a
temporary solution pending something better [2]. It replaces a lot of
03/08/2018 06:42, Rasesh Mody:
> The PMD has been modified to invoke the polling function in the link
> management code which detects the peer speed/mode, configure the link
> and update the status accordingly. This patch is the fix for the link
> down issue seen when we do dev_stop() and dev_start
On 03-Aug-18 12:41 PM, David Hunt wrote:
This patch contains two section.
1. Updates to the existing quick-start.html page giving
infomration on the new dpdk-quickstart.py script.
2. The dpdk-quickstart.py script itself.
1. The Quick start section contains some instructions for
build
Without this patch, testpmd command to config Rx offload keep_crc
would fail and report "Bad argument".
This patch aslo fix the command to config the Tx offload mbuf_fast_free.
Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC")
Fixes: c73a9071877a ("app/testpmd: add commands to test
Thanks, Iremonger.
I will reply this patch with a v3 patch.
> -Original Message-
> From: Iremonger, Bernard
> Sent: Thursday, August 2, 2018 5:12 PM
> To: Dai, Wei ; Wu, Jingjing ; Lu,
> Wenzhuo
> Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd:
Unit test cases are added for pdump library.
Primary process will act as server, forks a child secondary process.
Secondary process acts as client.
Server will do pdump init to serve any pdump client requests.
Server will create a vdev, send/receive packets continuously
in a separate thread.
Client
Unit Test Cases added for latencystats library.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
---
test/test/Makefile| 1 +
test/test/test_latencystats.c | 226 ++
2 files changed, 227 insertions(+)
create mode 100644 test
1/6: add helper functions for tests using ring-PMD Rx/Tx
2/6: unit test cases added for bitrate library
3/6: unit test cases added for latencystats library
4/6: unit test cases added for pdump library
5/6: added new unit tests to autotest list
6/6: updated maintainers for bitrate latency pdump test
Unit Test Cases for BitRate library.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
Reviewed-by: Remy Horton
---
test/test/Makefile| 1 +
test/test/test_bitratestats.c | 229 ++
2 files changed, 230 insertions(+)
create m
Added ring pmd based packet rx/tx helper functions
for verifying Latency, Bitrate and pdump lib UTs.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
Reviewed-by: Anatoly Burakov
---
test/test/Makefile| 1 +
test/test/sample_packet_forward.c | 115
Update MAINTAINERSHIP for bitrate, latency, pdump unit tests
and sample packet helper functions for unit test.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
---
MAINTAINERS | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
added bitrate, latency and pdump lib unit tests to autotest list.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
---
test/test/autotest_data.py | 18 ++
1 file changed, 18 insertions(+)
diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index
added bitrate, latency and pdump lib unit tests to autotest list.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
---
test/test/autotest_data.py | 18 ++
1 file changed, 18 insertions(+)
diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index
Update MAINTAINERSHIP for bitrate, latency, pdump unit tests
and sample packet helper functions for unit test.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
---
MAINTAINERS | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
Added ring pmd based packet rx/tx helper functions
for verifying Latency, Bitrate and pdump lib UTs.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
Reviewed-by: Anatoly Burakov
---
test/test/Makefile| 1 +
test/test/sample_packet_forward.c | 115
Unit Test Cases added for latencystats library.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
---
test/test/Makefile| 1 +
test/test/test_latencystats.c | 226 ++
2 files changed, 227 insertions(+)
create mode 100644 test
Unit Test Cases for BitRate library.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
Reviewed-by: Remy Horton
---
test/test/Makefile| 1 +
test/test/test_bitratestats.c | 229 ++
2 files changed, 230 insertions(+)
create m
1/6: add helper functions for tests using ring-PMD Rx/Tx
2/6: unit test cases added for bitrate library
3/6: unit test cases added for latencystats library
4/6: unit test cases added for pdump library
5/6: added new unit tests to autotest list
6/6: updated maintainers for bitrate latency pdump test
Unit test cases are added for pdump library.
Primary process will act as server, forks a child secondary process.
Secondary process acts as client.
Server will do pdump init to serve any pdump client requests.
Server will create a vdev, send/receive packets continuously
in a separate thread.
This patch contains two section.
1. Updates to the existing quick-start.html page giving
infomration on the new dpdk-quickstart.py script.
2. The dpdk-quickstart.py script itself.
1. The Quick start section contains some instructions for
building DPDK and running TestPMD.
While this is st
On Thu, Aug 02, 2018 at 07:21:22PM +0200, Maxime Coquelin wrote:
IOTLB entries contain the host virtual address of the guest
pages. When receiving a new VHOST_USER_SET_MEM_TABLE request,
the previous regions get unmapped, so the IOTLB entries, if any,
will be invalid. It does cause the vhost-user
> -Original Message-
> From: Jozwiak, TomaszX
> Sent: Thursday, August 2, 2018 4:09 PM
> To: De Lara Guarch, Pablo ; dev@dpdk.org;
> Trahe, Fiona ; Jozwiak, TomaszX
>
> Subject: [PATCH 0/2] common/qat: handle offset greater than first sgl segment
>
> This patchset fixes buffer lengths
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Thursday, August 2, 2018 9:45 AM
> To: Doherty, Declan
> Cc: dev@dpdk.org; De Lara Guarch, Pablo ;
> sta...@dpdk.org
> Subject: [PATCH] app/crypto-perf: fix auth IV offset
>
> Auth IV offset was not being set when creating the
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Wednesday, August 1, 2018 2:31 PM
> To: Daly, Lee
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] compress/isal: fixes offset check
>
>
>
> > -Original Message-
>
On Fri, Aug 03, 2018 at 09:54:21AM +0200, Maxime Coquelin wrote:
> On 08/03/2018 04:30 AM, Tiwei Bie wrote:
> > On Thu, Aug 02, 2018 at 07:21:22PM +0200, Maxime Coquelin wrote:
[...]
> >>
> >> #endif /* _VHOST_IOTLB_H_ */
> >> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost
Hi Matan,
On Thu, Aug 02, 2018 at 05:52:18PM +, Matan Azrad wrote:
> Hi Adrien
>
> From: Adrien Mazarguil
> > On Thu, Aug 02, 2018 at 10:33:00AM +, Matan Azrad wrote:
> > > The rte_flow meaning of zero flow mask configuration is to match all
> > > the range of the item value.
> > > For ex
On 02.08.2018 21:39, Kevin Traynor wrote:
Change log level of messages from ERR to INFO where
the post condition of the API is success, but no action
was actually needed as the condition already existed.
e.g. calling rte_eth_dev_start() for a device that is
already started.
Fixes: bea1e0c70cfc (
On 08/03/2018 04:30 AM, Tiwei Bie wrote:
On Thu, Aug 02, 2018 at 07:21:22PM +0200, Maxime Coquelin wrote:
IOTLB entries contain the host virtual address of the guest
pages. When receiving a new VHOST_USER_SET_MEM_TABLE request,
the previous regions get unmapped, so the IOTLB entries, if any,
68 matches
Mail list logo
