Re: [dpdk-dev] [RFC] queue: introduce queue APIs and driver framework

2018-07-10 Thread Jerin Jacob
-Original Message- > Date: Wed, 11 Jul 2018 02:02:32 + > From: Honnappa Nagarahalli > To: Jerin Jacob > CC: "dev@dpdk.org" , Gavin Hu , nd > , Hemant Agrawal > Subject: RE: [dpdk-dev] [RFC] queue: introduce queue APIs and driver > framework > > External Email > > -Original Me

[dpdk-dev] [PATCH] ethdev: fix flow expansion matching types

2018-07-10 Thread Nelio Laranjeiro
Node RSS types are generally covering more RSS kind than the user is requesting, it should accept to expand even if only a single bit is remains after masking. Setting the correct RSS kind for the rule remains the driver job. Fixes: 959823ce4c47 ("ethdev: add flow API to expand RSS flows") Signe

[dpdk-dev] [PATCH v2 11/12] examples/l2fwd: use fprint instead of printf for usage print

2018-07-10 Thread Anoob Joseph
Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c inde

[dpdk-dev] [PATCH v2 12/12] examples/l2fwd: improvements to the usage print

2018-07-10 Thread Anoob Joseph
Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b/e

[dpdk-dev] [PATCH v2 10/12] examples/l2fwd: move pkt send code to a new function

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index d6a5e90..bac1

[dpdk-dev] [PATCH v2 09/12] examples/l2fwd: skip timer updates for non master cores

2018-07-10 Thread Anoob Joseph
The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8 dele

[dpdk-dev] [PATCH v2 08/12] examples/l2fwd: move periodic tasks to new function

2018-07-10 Thread Anoob Joseph
Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 83 --- examples/l2fwd/l2fwd_worker.h | 6

[dpdk-dev] [PATCH v2 07/12] examples/l2fwd: optimize check for master core

2018-07-10 Thread Anoob Joseph
Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd/l2f

[dpdk-dev] [PATCH v2 06/12] examples/l2fwd: move drain buffers to new function

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c inde

[dpdk-dev] [PATCH v2 05/12] examples/l2fwd: remove unused header includes

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 663c505..ad5468a 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/ex

[dpdk-dev] [PATCH v2 03/12] examples/l2fwd: move globally accessed vars to common header

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_common.h | 26 ++ examples/l2fwd/main.c | 41 + 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd/l2fwd_comm

[dpdk-dev] [PATCH v2 04/12] examples/l2fwd: move dataplane code to new file

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * Merged checkpatch fix patches v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/Makefile | 1 + examples/l2fwd/l2fwd_worker.c | 233 ++ examples/l2fwd/l2fwd_worker.h | 10 ++ examples/l2fwd/main.c

[dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-07-10 Thread Anoob Joseph
This patchset modularizes l2fwd application to prepare it for eventmode additions. This patchset doesn't change the code flow or logic, except for few minor improvements. Some of the newly added functions are used in just one place, but is added for efficient usage with eventmode. v2: * Merged sma

[dpdk-dev] [PATCH v2 01/12] examples/l2fwd: move macro definitions to common header

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * Merged the patch which was adding the common header v1: * Retaining Intel license with copied code examples/l2fwd/l2fwd_common.h | 25 + examples/l2fwd/main.c | 16 ++-- 2 files changed, 27 insertions(+), 14 delet

Re: [dpdk-dev] [PATCH v2 0/6] compress: add Octeontx ZIP compression PMD

2018-07-10 Thread Verma, Shally
Hi Pablo, Can we close on this? We're targeting it for 18.08. Thanks Shally >-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma >Sent: 02 July 2018 22:25 >To: pablo.de.lara.gua...@intel.com >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahip

Re: [dpdk-dev] [PATCH v5 0/4] crypto: add asym crypto support

2018-07-10 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 11 July 2018 03:05 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu > >Subject: RE: [PATCH v5 0/4] crypto: add asym crypto support > >External Email > >> -

[dpdk-dev] I40e issue: Sharing ports between linux kernel and DPDK

2018-07-10 Thread Mounesh Badiger
Hi All, we are hitting kernel panic when I40E NIC ports are shared between kernel and DPDK stack. There are patches fixing the issues. https://patches.dpdk.org/patch/34880/ https://patches.dpdk.org/patch/34881/ https://patches.dpdk.org/patch/34882/ https://patches.dpdk.org/patch/34883/ These pa

[dpdk-dev] [PATCH v11 19/19] doc: update release notes for multi process hotplug

2018-07-10 Thread Qi Zhang
Update release notes for the new multi-process hotplug feature. Signed-off-by: Qi Zhang --- doc/guides/rel_notes/release_18_08.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index bc0124295..12

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Jeff Guo
On 7/11/2018 5:48 AM, Stephen Hemminger wrote: On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: +/* uio pci device state */ +enum rte_udev_state { + RTE_UDEV_PROBED, + RTE_UDEV_OPENNED, + RTE_UDEV_RELEASED, + RTE_UDEV_REMOVED, +}; + The states here are a little

[dpdk-dev] [PATCH v11 18/19] examples/multi_process: add hotplug sample

2018-07-10 Thread Qi Zhang
The sample code demonstrates device (ethdev only) management at a multi-process environment. The user can attach/detach a device on primary process and see it is synced on secondary process automatically. How to start? ./hotplug_mp --proc-type=auto Command Line Example: >help >list /* attach a

[dpdk-dev] [PATCH v11 16/19] net/tap: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 17/19] net/vhost: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 13/19] net/octeontx: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 15/19] net/softnic: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 14/19] net/pcap: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 12/19] net/null: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 08/19] net/ixgbe: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH v11 11/19] net/kni: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 10/19] net/bonding: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 09/19] net/af_packet: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v11 07/19] net/i40e: enable hotplug on secondary process

2018-07-10 Thread Qi Zhang
Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 ++ 1 file changed, 2 ins

[dpdk-dev] [PATCH v11 00/19] enable hotplug on multi-process

2018-07-10 Thread Qi Zhang
v11: - move out common code from pci_vfio_unmap_secondary and pci_vfio_unmap_primary. - move RTE_BUS_NAME_MAX_LEN and RTE_DEV_ARGS_MAX_LEN into hotplug_mp.h - fix reply check in eal_dev_hotplug_request_to_primary. - move skeleton code for attaching device from secondary from patch 6/19 to patch

[dpdk-dev] [PATCH v11 06/19] eal: support attach or detach share device from secondary

2018-07-10 Thread Qi Zhang
This patch cover the multi-process hotplug case when a device attach/detach request be issued from a secondary process device attach on secondary: a) secondary send sync request to the primary. b) primary receive the request and attach the new device if failed goto i). c) primary forward attach

[dpdk-dev] [PATCH v11 05/19] eal: enable hotplug on multi-process

2018-07-10 Thread Qi Zhang
We are going to introduce the solution to handle hotplug in multi-process, it includes the below scenario: 1. Attach a device from the primary 2. Detach a device from the primary 3. Attach a device from a secondary 4. Detach a device from a secondary In the primary-secondary process model, we ass

[dpdk-dev] [PATCH v11 03/19] bus/pci: enable vfio unmap resource for secondary

2018-07-10 Thread Qi Zhang
Subroutine to unmap VFIO resource is shared by secondary and primary, and it does not work on the secondary process. Since for secondary process, it is not necessary to close interrupt handler, set pci bus mastering and remove vfio_res from vfio_res_list. So, the patch adds a dedicate function to h

[dpdk-dev] [PATCH v11 04/19] vfio: remove uneccessary IPC for group fd clear

2018-07-10 Thread Qi Zhang
Clear vfio_group_fd is not necessary to involve any IPC. Also, current IPC implementation for SOCKET_CLR_GROUP is not correct. rte_vfio_clear_group on secondary will always fail, that prevent device be detached correctly on a secondary process. The patch simply removes all IPC related stuff in rte_

[dpdk-dev] [PATCH v11 01/19] ethdev: add function to release port in local process

2018-07-10 Thread Qi Zhang
Add driver API rte_eth_release_port_private to support the case when an ethdev need to be detached on a secondary process. Local state is set to unused and shared data will not be reset so the primary process can still use it. Signed-off-by: Qi Zhang Reviewed-by: Andrew Rybchenko Acked-by: Remy

[dpdk-dev] [PATCH v11 02/19] bus/pci: fix PCI address compare

2018-07-10 Thread Qi Zhang
When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a device. Fixes: c752998b5e2e ("pci: int

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Jeff Guo
On 7/11/2018 5:52 AM, Stephen Hemminger wrote: On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: When hotplug out device, the device resource will be released in kernel. The fd sys file will disappear, and the irq will be released. At this time, if igb uio driver still try to release this

[dpdk-dev] [PATCH v2] app/testpmd: fix little perf drop with XL710

2018-07-10 Thread Xiaoyun Li
There is about 1.8M perf drop with XL710. And it is because of a bitrate calculation in the datapath. So improve it by maintaining an array of port indexes in testpmd, which is updated with ethdev events. Fixes: 8728ccf37615 ("fix ethdev ports enumeration") Cc: sta...@dpdk.org Signed-off-by: Xiao

Re: [dpdk-dev] [PATCH v10 06/19] eal: support attach or detach share device from secondary

2018-07-10 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 10, 2018 10:12 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v10 06/19] eal

Re: [dpdk-dev] [PATCH V4 3/9] bus: introduce sigbus handler

2018-07-10 Thread Jeff Guo
On 7/11/2018 5:55 AM, Stephen Hemminger wrote: On Fri, 29 Jun 2018 18:30:42 +0800 Jeff Guo wrote: When device be hotplug, if data path still read/write device, the sigbus error will occur, this error need to be handled. So a handler need to be here to capture the signal and handle it corres

Re: [dpdk-dev] [PATCH v10 05/19] eal: enable hotplug on multi-process

2018-07-10 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, July 11, 2018 9:26 AM > To: Burakov, Anatoly ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati,

Re: [dpdk-dev] [RFC] queue: introduce queue APIs and driver framework

2018-07-10 Thread Honnappa Nagarahalli
-Original Message- From: Jerin Jacob Sent: Wednesday, June 27, 2018 11:20 AM To: Honnappa Nagarahalli Cc: dev@dpdk.org; Gavin Hu ; nd Subject: Re: [dpdk-dev] [RFC] queue: introduce queue APIs and driver framework -Original Message- > Date: Wed, 27 Jun 2018 11:06:13 -0500 > F

Re: [dpdk-dev] [PATCH v10 05/19] eal: enable hotplug on multi-process

2018-07-10 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 10, 2018 10:01 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v10 05/19] eal

[dpdk-dev] [PATCH v5 7/8] test: add test case for read write concurrency

2018-07-10 Thread Yipeng Wang
This commits add a new test case for testing read/write concurrency. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- test/test/Makefile | 1 + test/test/test_hash_readwrite.c | 637 2 files changed, 638 insertions(+) create mode 10

[dpdk-dev] [PATCH v5 8/8] hash: add new API function to query the key count

2018-07-10 Thread Yipeng Wang
Add a new function, rte_hash_count, to return the number of keys that are currently stored in the hash table. Corresponding test functions are added into hash_test and hash_multiwriter test. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- lib/librte_hash/rte_cuckoo_hash.c| 24 +++

[dpdk-dev] [PATCH v5 3/8] hash: fix key slot size accuracy

2018-07-10 Thread Yipeng Wang
This commit calculates the needed key slot size more accurately. The previous local cache fix requires the free slot ring to be larger than actually needed. The calculation of the value is inaccurate. Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH v5 5/8] hash: add read and write concurrency support

2018-07-10 Thread Yipeng Wang
The existing implementation of librte_hash does not support read-write concurrency. This commit implements read-write safety using rte_rwlock and rte_rwlock TM version if hardware transactional memory is available. Both multi-writer and read-write concurrency is protected by rte_rwlock now. The x8

[dpdk-dev] [PATCH v5 4/8] hash: make duplicated code into functions

2018-07-10 Thread Yipeng Wang
This commit refactors the hash table lookup/add/del code to remove some code duplication. Processing on primary bucket can also apply to secondary bucket with same code. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- lib/librte_hash/rte_cuckoo_hash.c | 182 +++---

[dpdk-dev] [PATCH v5 6/8] test: add tests in hash table perf test

2018-07-10 Thread Yipeng Wang
New code is added to support read-write concurrency for rte_hash. Due to the newly added code in critial path, the perf test is modified to show any performance impact. It is still a single-thread test. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- test/test/test_hash_perf.c | 36 +

[dpdk-dev] [PATCH v5 2/8] hash: fix a multi-writer race condition

2018-07-10 Thread Yipeng Wang
Current multi-writer implementation uses Intel TSX to protect the cuckoo path moving but not the cuckoo path searching. After searching, we need to verify again if the same empty slot still exists at the beginning of the TSX region. Otherwise another writer could occupy the empty slot before the TS

[dpdk-dev] [PATCH v5 1/8] hash: fix multiwriter lock memory allocation

2018-07-10 Thread Yipeng Wang
When malloc for multiwriter_lock, the align should be RTE_CACHE_LINE_SIZE rather than LCORE_CACHE_SIZE. Also there should be check to verify the success of rte_malloc. Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang

[dpdk-dev] [PATCH v5 0/8] Add read-write concurrency to rte_hash library

2018-07-10 Thread Yipeng Wang
This patch set adds the read-write concurrency support in rte_hash. A new flag value is added to indicate if read-write concurrency is needed during creation time. Test cases are implemented to do functional and performance tests. The new concurrency model is based on rte_rwlock. When Intel TSX is

Re: [dpdk-dev] [PATCH V4 3/9] bus: introduce sigbus handler

2018-07-10 Thread Stephen Hemminger
On Fri, 29 Jun 2018 18:30:42 +0800 Jeff Guo wrote: > When device be hotplug, if data path still read/write device, the sigbus > error will occur, this error need to be handled. So a handler need to be > here to capture the signal and handle it correspondingly. > > To handle sigbus error is a bus

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Stephen Hemminger
On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: > When hotplug out device, the device resource will be released in kernel. > The fd sys file will disappear, and the irq will be released. At this time, > if igb uio driver still try to release this resource, it will cause kernel > crash. On the

Re: [dpdk-dev] [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug

2018-07-10 Thread Stephen Hemminger
On Tue, 10 Jul 2018 19:03:27 +0800 Jeff Guo wrote: > > +/* uio pci device state */ > +enum rte_udev_state { > + RTE_UDEV_PROBED, > + RTE_UDEV_OPENNED, > + RTE_UDEV_RELEASED, > + RTE_UDEV_REMOVED, > +}; > + The states here are a little confusing. especially since pci_release see

[dpdk-dev] [pull-request] next-crypto 18.08-rc1

2018-07-10 Thread Pablo de Lara
The following changes since commit 05e0eee0001cb19671eb7e8d3dd68680a695fea2: net/ena: enable write combining (2018-06-30 00:12:58 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to f78a922e520e233c4b8038de1abc777968803be4

Re: [dpdk-dev] [PATCH v5 0/2]test/crypto: add unit testcase for asym crypto

2018-07-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, July 10, 2018 10:36 PM > To: Shally Verma > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v5 0/2]test/crypto:

Re: [dpdk-dev] [PATCH v5 0/4] crypto: add asym crypto support

2018-07-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, July 10, 2018 10:35 PM > To: Shally Verma > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v5 0/4] crypto: add

Re: [dpdk-dev] [PATCH v5 0/2]test/crypto: add unit testcase for asym crypto

2018-07-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Tuesday, July 10, 2018 5:01 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com > Subject: [PATCH v5 0/2]test/crypto: add unit testcase for

Re: [dpdk-dev] [PATCH v5 0/4] crypto: add asym crypto support

2018-07-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Tuesday, July 10, 2018 4:33 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com > Subject: [PATCH v5 0/4] crypto: add asym crypto support >

[dpdk-dev] [PATCH] examples/ip_pipeline: remove CLI command dependency on pipeline thread

2018-07-10 Thread Jasvinder Singh
Currently, some CLI commands (for examples- add or delete pipeline table entries, add meter profile etc.) fails to execute when application pipeline threads are not running. Therefore, command for enabling pipeline on the thread is required to be executed first or specified in the script file befor

Re: [dpdk-dev] [PATCH v4 0/8] Add read-write concurrency to rte_hash library

2018-07-10 Thread Honnappa Nagarahalli
Hi Yipeng/Pablo, Apologies for my delayed comments -Original Message- From: Yipeng Wang Sent: Monday, July 9, 2018 5:45 AM To: pablo.de.lara.gua...@intel.com Cc: dev@dpdk.org; yipeng1.w...@intel.com; bruce.richard...@intel.com; Honnappa Nagarahalli ; vgu...@caviumnetworks.com;

Re: [dpdk-dev] [dpdk-users] Traffic doesn't forward on virtual devices

2018-07-10 Thread Bala Sankaran
- Original Message - > From: "Ciara Loftus" > To: "Aaron Conole" , "Bala Sankaran" > Cc: "Keith Wiles" , us...@dpdk.org, dev@dpdk.org, > "Maxime Coquelin" > , "Ian Stokes" > Sent: Tuesday, July 10, 2018 4:20:31 AM > Subject: RE: [dpdk-users] Traffic doesn't forward on virtual devices

Re: [dpdk-dev] [PATCH v2 0/4] add head/tailroom requirement for crypto PMDs

2018-07-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, July 10, 2018 6:21 PM > To: Anoob Joseph ; Doherty, Declan > > Cc: Akhil Goyal ; Ankur Dwivedi > ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH v4 4/5] net/nfp: check hugepages IOVAs based on DMA mask

2018-07-10 Thread Alejandro Lucero
NFP devices can not handle DMA addresses requiring more than 40 bits. This patch uses rte_dev_check_dma_mask with 40 bits and avoids device initialization if memory out of NFP range. Applicable to v17.11.3 only. Signed-off-by: Alejandro Lucero Acked-by: Eelco Chaudron --- drivers/net/nfp/nfp_n

[dpdk-dev] [PATCH v4 5/5] net/nfp: support IOVA VA mode

2018-07-10 Thread Alejandro Lucero
NFP can handle IOVA as VA. It requires to check those IOVAs being in the supported range what is done during initialization. Applicable to v17.11.3 only. Signed-off-by: Alejandro Lucero Acked-by: Eelco Chaudron --- drivers/net/nfp/nfp_net.c | 6 -- 1 file changed, 4 insertions(+), 2 deleti

[dpdk-dev] [PATCH v4 2/5] bus/pci: use IOVAs check when setting IOVA mode

2018-07-10 Thread Alejandro Lucero
Although VT-d emulation currently only supports 39 bits, it could be iovas being within that supported range. This patch allows IOVA mode in such a case. Indeed, memory initialization code can be modified for using lower virtual addresses than those used by the kernel for 64 bits processes by defa

[dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

2018-07-10 Thread Alejandro Lucero
This patchset adds, mainly, a check for ensuring IOVAs are within a restricted range due to addressing limitations with some devices. There are two known cases: NFP and IOMMU VT-d emulation. With this check IOVAs out of range are detected and PMDs can abort initialization. For the VT-d case, IOVA

[dpdk-dev] [PATCH v4 3/5] mem: use address hint for mapping hugepages

2018-07-10 Thread Alejandro Lucero
Linux kernel uses a really high address as starting address for serving mmaps calls. If there exists addressing limitations and IOVA mode is VA, this starting address is likely too high for those devices. However, it is possible to use a lower address in the process virtual address space as with 64

[dpdk-dev] [PATCH v4 1/5] mem: add function for checking memsegs IOVAs addresses

2018-07-10 Thread Alejandro Lucero
A device can suffer addressing limitations. This functions checks memsegs have iovas within the supported range based on dma mask. PMD should use this during initialization if supported devices suffer addressing limitations, returning an error if this function returns memsegs out of range. Anothe

Re: [dpdk-dev] [PATCH v2 0/4] add head/tailroom requirement for crypto PMDs

2018-07-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Tuesday, July 10, 2018 3:43 PM > To: Doherty, Declan ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Akhil Goyal > ; Ankur Dwivedi > ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: [P

Re: [dpdk-dev] [pull-request] next-net 18.08 RC1

2018-07-10 Thread Thomas Monjalon
05/07/2018 19:57, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled, thanks

Re: [dpdk-dev] Problem compiling dpdk for Aarch64 on RHEL/Centos

2018-07-10 Thread Thomas F Herbert
On 07/10/2018 12:39 PM, Thomas F Herbert wrote: +Nitin On 07/10/2018 09:36 AM, Thomas F Herbert wrote: Any insight would be appreciated. As you can see this is an aarmv8-a server. This problem was reproduced on Centos 7.5 and RHEL 7.5. and dpdk top of master. Original error: /home/

[dpdk-dev] [PATCH v5 1/2] lib/librte_power: traffic pattern aware power control

2018-07-10 Thread Radu Nicolau
From: Liang Ma 1. Abstract For packet processing workloads such as DPDK polling is continuous. This means CPU cores always show 100% busy independent of how much work those cores are doing. It is critical to accurately determine how busy a core is hugely important for the following reasons:

[dpdk-dev] [PATCH v5 2/2] examples/l3fwd-power: simple app update to support new API

2018-07-10 Thread Radu Nicolau
From: Liang Ma Add the support for new traffic pattern aware power control power management API. Example: ./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3 -P --config="(0,0,xx),(1,0,xx)" --empty-poll Please Reference l3fwd-power document for all parameter except empty-pol

[dpdk-dev] [PATCH v5 10/10] net/mlx5: support negative identifiers for port representors

2018-07-10 Thread Adrien Mazarguil
This patch brings support for BlueField representors. Signed-off-by: Adrien Mazarguil Cc: Shahaf Shuler -- v3 changes: - This patch was not present in prior revisions. --- drivers/net/mlx5/mlx5.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/

[dpdk-dev] [PATCH v5 08/10] net/mlx5: probe port representors in natural order

2018-07-10 Thread Adrien Mazarguil
Port representors are probed in whatever unspecified order ibv_get_device_list() returns them. This is counterintuitive to users since DPDK port IDs assignment almost never follows the same sequence as representor IDs. Additionally, the master device does not necessarily inherit the lowest DPDK po

[dpdk-dev] [PATCH v5 09/10] net/mlx5: add parameter for port representors

2018-07-10 Thread Adrien Mazarguil
Prior to this patch, all port representors detected on a given device were probed and Ethernet devices instantiated for each of them. This patch adds support for the standard "representor" parameter, which implies that port representors are not probed by default anymore, except for the list provid

[dpdk-dev] [PATCH v5 06/10] net/mlx5: add port representor awareness

2018-07-10 Thread Adrien Mazarguil
The current PCI probing method is not aware of Verbs port representors, which appear as standard Verbs devices bound to the same PCI address and cannot be distinguished. Problem is that more often than not, the wrong Verbs device is used, resulting in unexpected traffic. This patch makes the driv

[dpdk-dev] [PATCH v5 07/10] net/mlx5: probe all port representors

2018-07-10 Thread Adrien Mazarguil
Probe existing port representors in addition to their master device and associate them automatically. To avoid collision between Ethernet devices, they are named as follows: - "{DBDF}" for master/switch devices. - "{DBDF}_representor_{rep}" with "rep" starting from 0 for port representors. (Pa

[dpdk-dev] [PATCH v5 05/10] net/mlx5: re-indent generic probing function

2018-07-10 Thread Adrien Mazarguil
Since commit "net/mlx5: drop useless support for several Verbs ports" removed an inner loop, mlx5_dev_spawn() is left with an unnecessary indent level. This patch eliminates a block, moves its local variables to function scope, and re-indents its contents (diff best viewed with --ignore-all-space)

[dpdk-dev] [PATCH v5 04/10] net/mlx5: split PCI from generic probing code

2018-07-10 Thread Adrien Mazarguil
All the generic probing code needs is an IB device. While this device is currently supplied by a PCI lookup, other methods will be added soon. This patch divides the original function, which has become huge over time, as follows: 1. PCI-specific (mlx5_pci_probe()). 2. Verbs device (mlx5_dev_spawn

[dpdk-dev] [PATCH v5 03/10] net/mlx5: drop useless support for several Verbs ports

2018-07-10 Thread Adrien Mazarguil
Unlike mlx4 from which this capability was inherited, mlx5 devices expose exactly one Verbs port per PCI bus address. Each physical port gets assigned its own bus address with a single Verbs port. While harmless, this code requires an extra loop that would get in the way of subsequent refactoring.

[dpdk-dev] [PATCH v5 02/10] net/mlx5: remove redundant objects in probe code

2018-07-10 Thread Adrien Mazarguil
This patch gets rid of redundant calls to open the device and query its attributes in order to simplify the code. Signed-off-by: Adrien Mazarguil Reviewed-by: Xueming Li -- v2 changes: - Minor indent fix on existing code. --- drivers/net/mlx5/mlx5.c | 64 +--

[dpdk-dev] [PATCH v5 00/10] net/mlx5: add port representor support

2018-07-10 Thread Adrien Mazarguil
This series adds support for port (VF) representors to the mlx5 PMD, which can be instantiated using the standard "representor" device parameter. Note the PMD only probes existing representors which exist as Verbs devices; their creation is part of the host system configuration. v5 changes: - Fi

[dpdk-dev] [PATCH v5 01/10] net/mlx5: rename confusing object in probe code

2018-07-10 Thread Adrien Mazarguil
There are several attribute objects in this function: - IB device attributes (struct ibv_device_attr_ex device_attr). - Direct Verbs attributes (struct mlx5dv_context attrs_out). - Port attributes (struct ibv_port_attr). - IB device attributes again (struct ibv_device_attr_ex device_attr_ex). "at

[dpdk-dev] [PATCH v5 2/2] test/crypto: add dh and dsa tests

2018-07-10 Thread Shally Verma
From: Sunila Sahu Test application include test case for : - Diffie-Hellman key pair generation and shared secret compute - DSA sign and verify Test cases uses predefined test vectors. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta Signed-off-by: Umesh Ka

[dpdk-dev] [PATCH v5 1/2] test/crypto: add rsa and mod tests

2018-07-10 Thread Shally Verma
From: Sunila Sahu Test application include test case for : - RSA encrypt, decrypt, sign and verify - Modular Inversion and Exponentiation Test cases uses predefined test vectors. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta Signed-off-by: Umesh Kartha

[dpdk-dev] [PATCH v5 0/2]test/crypto: add unit testcase for asym crypto

2018-07-10 Thread Shally Verma
This patch series add unit test case for asymmetric crypto. Current testcase covers following operations: - RSA encrypt, decrypt, sign and verify - Modular Inversion and Exponentiation - Diffie-Hellman key pair generation and shared secret compute - DSA sign and verify All test cases use pre-def

Re: [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files

2018-07-10 Thread Mody, Rasesh
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 09, 2018 2:07 PM > > Hi, > > 08/07/2018 07:24, Rasesh Mody: > > We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX > > licensing tag from all the source file. Remove the LICENSE.bnx2x_pmd > > file and directly i

Re: [dpdk-dev] [PATCH] net/qede: move SPDX tags to source files

2018-07-10 Thread Mody, Rasesh
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Sunday, July 08, 2018 11:40 PM > > Hi Rasesh, > There is a problem with these patches. > > The SPDX shall be first line for *.c, *.h and Makefiles. It shall come before > the > copyright statements. I will send a v2 with the

[dpdk-dev] migration from 17.05 to 17.11, testpmd not able to bring up ports for virtio instance running inside a VM

2018-07-10 Thread Bly, Mike
Does anyone have some suggestions on where to start with this ? When we run this using DPDK 17.05, the ports come up fine for our design and testpmd. However, with 17.11, the ports to not come up and I end up with undefined rx_pkt_burst/tx_pkt_burst functions as shown here: (gdb) p rte_eth_dev

Re: [dpdk-dev] [PATCH] lib/librte_ethdev: Error checking for stats mapping

2018-07-10 Thread Andrew Rybchenko
On 10.07.2018 18:26, Kiran Kumar wrote: With current implementation, we are not checking for queue_id range and stat_idx range in stats mapping function. This patch will add check for queue_id and stat_idx range. Fixes: 5de201df892 ("ethdev: add stats per queue") Signed-off-by: Kiran Kumar ---

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 3/6] bus/pci: use IOVAs check when setting IOVA mode

2018-07-10 Thread Alejandro Lucero
On Tue, Jul 10, 2018 at 11:14 AM, Eelco Chaudron wrote: > > > On 4 Jul 2018, at 14:53, Alejandro Lucero wrote: > > Although VT-d emulation currently only supports 39 bits, it could >> be iovas being within that supported range. This patch allows >> IOVA mode in such a case. >> >> Indeed, memory i

[dpdk-dev] [PATCH v5 3/4] cryptodev: add asymmetric capability

2018-07-10 Thread Shally Verma
From: Sunila Sahu Extend cryptodev with asymmetric capability APIs and definitions. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta Signed-off-by: Umesh Kartha --- lib/librte_cryptodev/rte_cryptodev.c | 76 ++ lib/librte_cryptode

[dpdk-dev] [PATCH v5 4/4] doc: add asym crypto in cryptodev programmer guide

2018-07-10 Thread Shally Verma
Update cryptodev programmer guide with description of asymmetric crypto framework in lib cryptodev. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta Signed-off-by: Umesh Kartha --- doc/guides/prog_guide/cryptodev_lib.rst | 264 ++--

[dpdk-dev] [PATCH v5 2/4] cryptodev: support asymmetric operations

2018-07-10 Thread Shally Verma
From: Ashish Gupta Extend DPDK librte_cryptodev to: - define asym op type in rte_crypto_op_type and associated op pool create/alloc APIs - define asym session and associated session APIs If PMD shows in its feature flag that it supports both sym and asym then it must support those on all its q

[dpdk-dev] [PATCH v5 1/4] cryptodev: add asymmetric xform and op definitions

2018-07-10 Thread Shally Verma
From: Umesh Kartha Add rte_crypto_asym.h with supported xforms and associated op structures and APIs API currently supports: - RSA Encrypt, Decrypt, Sign and Verify - Modular Exponentiation and Inversion - DSA Sign and Verify - Diffie-hellman private key exchange - Diffie-hellman public key exch

  1   2   3   >