Re: [dpdk-dev] [PATCH v3 08/11] net/virtio: add in-order Rx/Tx into selection

2018-06-29 Thread Tiwei Bie
On Fri, Jun 29, 2018 at 10:04:23AM +0200, Maxime Coquelin wrote: > On 06/28/2018 05:39 PM, Liu, Yong wrote: > > > > > > > -Original Message- > > > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > > > Sent: Thursday, June 28, 2018 11:16 PM > > > To: Liu, Yong ; Bie, Tiwei > > >

Re: [dpdk-dev] [PATCH v5 03/15] vhost: vring address setup for packed queues

2018-06-29 Thread Tiwei Bie
On Fri, Jun 29, 2018 at 06:34:09PM +0200, Maxime Coquelin wrote: > On 06/29/2018 05:59 PM, Tiwei Bie wrote: > > On Fri, Jun 22, 2018 at 03:43:15PM +0200, Maxime Coquelin wrote: [...] > > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > > > index 34a614c97..671b4b3bf 100644 > > >

Re: [dpdk-dev] [PATCH v2] docs: add default that all fixes should be backported

2018-06-29 Thread Kevin Traynor
On 06/29/2018 11:02 PM, Thomas Monjalon wrote: > 29/06/2018 23:47, Kevin Traynor: >> -Backporting should be limited to bug fixes. >> +Backporting should be limited to bug fixes. All patches accepted on the >> master >> +branch with Fixes tags should be backported to the relevant stable/LTS >> bra

[dpdk-dev] [PATCH v3] docs: add default that all fixes should be backported

2018-06-29 Thread Kevin Traynor
Set the starting point that all commits on master branch with Fixes tag should be backported to relevant stable/LTS branches, and explain that the submitter may indicate it is not suitable for backport. Of course there will be exceptions that will crop up from time to time that need discussion, so

Re: [dpdk-dev] [PATCH v5 0/4] Support for write combining.

2018-06-29 Thread Thomas Monjalon
29/06/2018 16:26, Ferruh Yigit: > On 6/29/2018 2:54 PM, Rafal Kozik wrote: > > Support for write combining. > > > > Kozik (4): > > igb_uio: add wc option > > bus/pci: reference driver structure > > eal: enable WC during resources mapping > > net/ena: enable WC > > For series, > Reviewed-b

Re: [dpdk-dev] [PATCH v2] docs: add default that all fixes should be backported

2018-06-29 Thread Thomas Monjalon
29/06/2018 23:47, Kevin Traynor: > -Backporting should be limited to bug fixes. > +Backporting should be limited to bug fixes. All patches accepted on the > master > +branch with Fixes tags should be backported to the relevant stable/LTS > branches, > +unless the submitter indicates otherwise. If

Re: [dpdk-dev] [PATCH] docs: add default that all fixes are backported

2018-06-29 Thread Thomas Monjalon
29/06/2018 23:39, Kevin Traynor: > On 06/29/2018 05:15 PM, Thomas Monjalon wrote: > > 21/06/2018 18:45, Ferruh Yigit: > >> On 6/21/2018 5:00 PM, Kevin Traynor wrote: > >>> Set the starting point that all commits on master branch > >>> with Fixes tag are backported to relevant stable/LTS branches. >

[dpdk-dev] [PATCH v2] docs: add default that all fixes should be backported

2018-06-29 Thread Kevin Traynor
Set the starting point that all commits on master branch with Fixes tag should be backported to relevant stable/LTS branches, and explain that the submitter may indicate it is not suitable for backport. Of course there will be exceptions that will crop up from time to time that need discussion, so

Re: [dpdk-dev] [PATCH] docs: add default that all fixes are backported

2018-06-29 Thread Kevin Traynor
On 06/29/2018 05:15 PM, Thomas Monjalon wrote: > 21/06/2018 18:45, Ferruh Yigit: >> On 6/21/2018 5:00 PM, Kevin Traynor wrote: >>> Set the starting point that all commits on master branch >>> with Fixes tag are backported to relevant stable/LTS branches. >>> >>> Of course there will be exceptions t

[dpdk-dev] Failures in AESNI-GCM enc/dec tests

2018-06-29 Thread Ashot Andreasyan
Hi there, I think there is errors on running AESNI-GCM Enc/Dec tests with long authentication tag length. When #define GCM_LARGE_AAD_LENGTH65296 then rte_pktmbuf_append(...) fails if (unlikely(len > rte_pktmbuf_tailroom(m_last))) return NULL; because there is no room t

Re: [dpdk-dev] 17.05 --> 17.11, minimum hash table key size

2018-06-29 Thread Bly, Mike
Cristian, Thank you. I have done the recommended change. The next thing we have run into is the f_hash selection. We were historically using rte_hash_crc_8byte() from rte_has_crc.h. In looking at DPDK content, I do not see anything close in an rte_*.h file to use with the appropriate input para

[dpdk-dev] [PATCH v2 6/6] hash: add new API function to query the key count

2018-06-29 Thread Yipeng Wang
Add a new function, rte_hash_count, to return the number of keys that are currently stored in the hash table. Corresponding test functions are added into hash_test and hash_multiwriter test. Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c| 24 lib/li

[dpdk-dev] [PATCH v2 2/6] hash: add read and write concurrency support

2018-06-29 Thread Yipeng Wang
The existing implementation of librte_hash does not support read-write concurrency. This commit implements read-write safety using rte_rwlock and rte_rwlock TM version if hardware transactional memory is available. Both multi-writer and read-write concurrency is protected by rte_rwlock now. The x8

[dpdk-dev] [PATCH v2 0/6] Add read-write concurrency to rte_hash library

2018-06-29 Thread Yipeng Wang
This patch set adds the read-write concurrency support in rte_hash. A new flag value is added to indicate if read-write concurrency is needed during creation time. Test cases are implemented to do functional and performance tests. The new concurrency model is based on rte_rwlock. When Intel TSX is

[dpdk-dev] [PATCH v2 5/6] hash: fix to have more accurate key slot size

2018-06-29 Thread Yipeng Wang
This commit calculates the needed key slot size more accurately. The previous local cache fix requires the free slot ring to be larger than actually needed. The calculation of the value is inaccurate. Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") Signed-off-by: Yipeng Wang ---

[dpdk-dev] [PATCH v2 3/6] test: add tests in hash table perf test

2018-06-29 Thread Yipeng Wang
New code is added to support read-write concurrency for rte_hash. Due to the newly added code in critial path, the perf test is modified to show any performance impact. It is still a single-thread test. Signed-off-by: Yipeng Wang --- test/test/test_hash_perf.c | 36 +-

[dpdk-dev] [PATCH v2 1/6] hash: make duplicated code into functions

2018-06-29 Thread Yipeng Wang
This commit refactors the hash table lookup/add/del code to remove some code duplication. Processing on primary bucket can also apply to secondary bucket with same code. Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c | 186 ++ 1 file changed,

[dpdk-dev] [PATCH v2 4/6] test: add test case for read write concurrency

2018-06-29 Thread Yipeng Wang
This commits add a new test case for testing read/write concurrency. Signed-off-by: Yipeng Wang --- test/test/Makefile | 1 + test/test/test_hash_readwrite.c | 645 2 files changed, 646 insertions(+) create mode 100644 test/test/test_hash_

[dpdk-dev] [PATCH 5/5] net/cxgbevf: add missing Tx byte counters

2018-06-29 Thread Rahul Lakkireddy
Fixes: a0a344a8f728 ("net/cxgbe: add VF port statistics") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_regs.h | 3 +++ drivers/net/cxgbe/base/t4vf_hw.c | 6 ++ drivers/net/cxgbe/cxgbevf_ethdev.c | 1 + 3 files changed, 10 insertions(+) diff --git a/d

[dpdk-dev] [PATCH 4/5] net/cxgbe: fix Rx channel map and queue type

2018-06-29 Thread Rahul Lakkireddy
Set the Rx channel map and ingress queue type properly to allow firmware to manage the internal mapping correctly. Fixes: 6c2809628cd5 ("net/cxgbe: improve latency for slow traffic") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4fw_interface.h | 8 d

[dpdk-dev] [PATCH 3/5] net/cxgbe: query firmware for max queues available

2018-06-29 Thread Rahul Lakkireddy
Query firmware for max Tx and Rx queues that can be allocated. Move the code to determine max queues to common place for both PF and VF. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 10 +++ drivers/net/cxgbe/base/t4_hw.c | 40

[dpdk-dev] [PATCH 1/5] net/cxgbe: add link up and down ops

2018-06-29 Thread Rahul Lakkireddy
Add ops to set link up and down for both PF and VF. If wait_to_complete is set, poll for link update for up to 10 seconds max. Original work by Surendra Mobiya Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe.h | 5 +++ drivers/net/cxgbe/cxgbe_ethdev.c | 72 +

[dpdk-dev] [PATCH 2/5] net/cxgbe: enable more RSS hash functions

2018-06-29 Thread Rahul Lakkireddy
Enable RSS on IPv4 fragmented packets and IPv6 packets with extension headers based on 2-tuple hash. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe.h| 15 ++- drivers/net/cxgbe/cxgbe_ethdev.c | 8 drivers/net/cxgbe/cxgbe_main.c | 14 -- 3

[dpdk-dev] [PATCH 0/5] net/cxgbe: feature updates and bug fixes

2018-06-29 Thread Rahul Lakkireddy
Patch 1 adds link up and down operations for PF and VF. Patch 2 enables 2-tuple based RSS hash on IPv4 fragment packets and IPv6 packets with extension headers. Patch 3 queries firmware for max queues that can be allocated. Patch 4 fixes Rx channel map and ingress queue type needed for firmware

[dpdk-dev] [PATCH 9/9] net/cxgbe: add support to redirect packets to egress physical port

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add action to redirect matched packets to specified egress physical port without sending them to host. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_msg.h | 6 ++ drivers/net/cxgbe/cxgbe_filter.c | 19 +--

[dpdk-dev] [PATCH 8/9] net/cxgbe: add support to match on ingress physical port

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add support to match packets based on ingress physical port. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 16 +++- drivers/net/cxgbe/cxgbe_flow.c | 30 ++ 2 files changed, 45

[dpdk-dev] [PATCH 7/9] net/cxgbe: add support to flush flows in HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c index 48df62aff..4f00ac4c6 100644 --- a/drive

[dpdk-dev] [PATCH 5/9] net/cxgbe: add support to delete flows in HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add interface to delete offloaded flows in HASH region. Use the hash index saved during insertion to delete the corresponding flow. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_msg.h | 72 drivers/net/cx

[dpdk-dev] [PATCH 6/9] net/cxgbe: add support to query hit counters for flows in HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add interface to enable hit counters for flows offloaded in HASH region. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_tcb.h | 11 +++ drivers/net/cxgbe/cxgbe_filter.c | 71 +--- driver

[dpdk-dev] [PATCH 4/9] net/cxgbe: add support to offload flows to HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add interface to offload flows to HASH region. Translate internal filter specification to requests to offload flows to HASH region. Save the returned hash index of the offloaded flow for deletion later. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- dri

[dpdk-dev] [PATCH 3/9] net/cxgbe: add Compressed Local IP region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal CLIP region holds destination IPv6 addresses to be matched for corresponding flows. Query firmware for CLIP resources and allocate table to manage them. Also update LE-TCAM to use CLIP to reduce number of slots needed to offload IPv6 flows. Signed-off-by: Shagun Agrawal Sig

[dpdk-dev] [PATCH 2/9] net/cxgbe: validate flows offloaded to HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Fetch supported match items in HASH region. Ensure the mask is all set for all the supported match items to be offloaded to HASH region. Otherwise, offload them to LE-TCAM region. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/com

[dpdk-dev] [PATCH 0/9] net/cxgbe: add support for offloading flows to HASH region

2018-06-29 Thread Rahul Lakkireddy
This series of patches add support to offload flows to HASH region available on Chelsio T6 NICs. HASH region can only offload exact match (maskless) flows and hence the masks must be all set for all match items. Patch 1 queries firmware for HASH filter support. Patch 2 updates cxgbe_flow to decid

[dpdk-dev] [PATCH 1/9] net/cxgbe: query firmware for HASH filter resources

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Fetch available HASH filter resources and allocate table for managing them. Currently only supported on Chelsio T6 family of NICs. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 7 ++ drivers/net/cxgbe/base/t4_reg

Re: [dpdk-dev] [PATCH v2 2/2] librte_ip_frag: add mbuf counter

2018-06-29 Thread Alex Kiselev
Hi Konstantin > Hi Alex, >> There might be situations (kind of attack when a lot of >> fragmented packets are sent to a dpdk application in order >> to flood the fragmentation table) when no additional mbufs >> must be added to the fragmentations table since it already >> contains to many of the

Re: [dpdk-dev] [PATCH] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

2018-06-29 Thread Cody Doucette
Hi, > Just a generic thought - might be worse to move functions that parse ipv6 > header extentions > and related strcutures into rte_net. > I am sure they might be reused by some other code. Sorry, I am misunderstanding. Do you mean it might be better to move struct ipv6_opt_hdr and ipv6_ext_hd

Re: [dpdk-dev] [PATCH v13 2/6] doc: add a guide doc for cross compiling from x86

2018-06-29 Thread Gavin Hu
Hi Ali, Thanks for your comments, I submitted the v14, please check if your comments are addressed and any more are welcome! Best Regards, Gavin > -Original Message- > From: Ali Alnubani > Sent: Wednesday, June 27, 2018 10:26 PM > To: Gavin Hu ; 'dev@dpdk.org' > Cc: nd > Subject: RE:

Re: [dpdk-dev] [dpdk-stable] [PATCH v13 6/6] devtools: expand meson cross compiling test coverage

2018-06-29 Thread Gavin Hu
Hi Thomas, I submitted the v14 patch set to address your two comments! Any more comments are welcome! Best Regards, Gavin > -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 28, 2018 5:26 AM > To: Gavin Hu > Cc: dev@dpdk.org; nd > Subject: Re: [dpdk-stable] [PATCH v13

[dpdk-dev] [PATCH v14 6/6] devtools: expand meson cross compiling test coverage

2018-06-29 Thread Gavin Hu
The default test script covers only default host cc compiler, either gcc or clang, the fix is to increase the coverage by adding one more to cover clang and the others for gcc. Fixes: a55277a788 ("devtools: add test script for meson builds") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-b

[dpdk-dev] [PATCH v14 5/6] build: fix the meson cross compile error

2018-06-29 Thread Gavin Hu
The following error hits if host cc compiler is clang(default one in most linux distributions) and the cross compiler is gcc. The root cause is: the hybride compilers add the warning options to the meson project as project arguments, which apply for both host compiling and cross compiling. But som

[dpdk-dev] [PATCH v14 4/6] devtools: fix the missing ninja command error

2018-06-29 Thread Gavin Hu
On some linux distributions, eg: CentOS, the ninja executable has a different name: ninja-build, this patch is to check and adapt to it accordingly. ./devtools/test-meson-builds.sh: line 24: ninja: command not found Fixes: a55277a788 ("devtools: add test script for meson builds") Cc: sta...@dpdk.

[dpdk-dev] [PATCH v14 3/6] build: fix the meson build warning

2018-06-29 Thread Gavin Hu
This is to fix the unnecessary warning output, it is not consistent with the configurations of other platforms. WARNING: Cross file does not specify strip binary, result will not be stripped. Fixes: e53a5299d2 ("build: support vendor specific ARM cross builds") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v14 0/6] Fix the cross compiling errors

2018-06-29 Thread Gavin Hu
1. Pre-v5 of this patch set(two patches) is to fix the GNU Makefile based cross compiling errors and add a guiding doc for this. 2. v6 add 5 more new patches to cover meson cross fixes 3. v7 Some minor changes to address the comments: a) trim the commit message b) at the start of the scri

[dpdk-dev] [PATCH v14 2/6] doc: add a guide doc for cross compiling from x86

2018-06-29 Thread Gavin Hu
From: gavin hu This is the guide for cross compiling ARM64 DPDK from X86 hosts. Signed-off-by: Gavin Hu Reviewed-by: Steve Capper Reviewed-by: Honnappa Nagarahalli Acked-by: Marko Kovacevic --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 132 + doc/guides/linux_

[dpdk-dev] [PATCH v14 1/6] mk: fix makefile based cross build errors

2018-06-29 Thread Gavin Hu
From: gavin hu The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was enabled when the cross compiler gcc is greater than 7.0, but for the host side buildtools/pmdinfogen, if the native gcc is older than 7.0, or the host cc compiler is clang, it should not be enabled. The fix

Re: [dpdk-dev] [PATCH] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

2018-06-29 Thread Ananyev, Konstantin
Hi, > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > other IPv6 extension headers when finding the fragment header. > > According to RFC 8200, there is no guarantee that the IPv6 > Fragment extension header will come before any other extension > header, even though it is r

Re: [dpdk-dev] [PATCH] ip_frag: add function rte_ip_frag_sweep_table()

2018-06-29 Thread Ananyev, Konstantin
Hi > > Function rte_ip_frag_sweep_table() enables callers to > incrementally sweep IP frament tables for incomplete, expired fragments. > > rte_ip_frag_sweep_table() is needed to identify > never-to-be-completed fragments during DDoS attacks. There is a patch from Alex Kiselev: http://patches.d

Re: [dpdk-dev] [PATCH v2 2/2] librte_ip_frag: add mbuf counter

2018-06-29 Thread Ananyev, Konstantin
Hi Alex, > There might be situations (kind of attack when a lot of > fragmented packets are sent to a dpdk application in order > to flood the fragmentation table) when no additional mbufs > must be added to the fragmentations table since it already > contains to many of them. Currently there is

Re: [dpdk-dev] [PATCH v2 1/2] librte_ip_frag: add function to delete expired entries

2018-06-29 Thread Ananyev, Konstantin
> -Original Message- > From: Alex Kiselev [mailto:a...@therouter.net] > Sent: Monday, June 4, 2018 11:13 AM > To: Ananyev, Konstantin ; dev@dpdk.org; > Burakov, Anatoly > Subject: [dpdk-dev] [PATCH v2 1/2] librte_ip_frag: add function to delete > expired entries > > A fragmented pack

Re: [dpdk-dev] [PATCH v5 03/15] vhost: vring address setup for packed queues

2018-06-29 Thread Maxime Coquelin
On 06/29/2018 05:59 PM, Tiwei Bie wrote: On Fri, Jun 22, 2018 at 03:43:15PM +0200, Maxime Coquelin wrote: From: Yuanhan Liu Add code to set up packed queues when enabled. Signed-off-by: Yuanhan Liu Signed-off-by: Jens Freimann Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.

Re: [dpdk-dev] [PATCH v3] ethdev: add new offload flag to keep CRC

2018-06-29 Thread Ferruh Yigit
On 6/29/2018 12:57 PM, Thomas Monjalon wrote: > 29/06/2018 14:41, Ferruh Yigit: >> DEV_RX_OFFLOAD_KEEP_CRC offload flag is added. PMDs that support >> keeping CRC should advertise this offload capability. >> >> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release >> default behavior in PMDs a

Re: [dpdk-dev] [PATCH v5] ethdev: add flow API to expand RSS flows

2018-06-29 Thread Ferruh Yigit
On 6/28/2018 5:09 PM, Adrien Mazarguil wrote: > On Thu, Jun 28, 2018 at 06:01:21PM +0200, Nelio Laranjeiro wrote: >> Introduce an helper for PMD to expand easily flows items list with RSS >> action into multiple flow items lists with priority information. >> >> For instance a user items list being

Re: [dpdk-dev] [PATCH v5] ethdev: add flow API to expand RSS flows

2018-06-29 Thread Ferruh Yigit
On 6/28/2018 5:09 PM, Adrien Mazarguil wrote: > On Thu, Jun 28, 2018 at 06:01:21PM +0200, Nelio Laranjeiro wrote: >> Introduce an helper for PMD to expand easily flows items list with RSS >> action into multiple flow items lists with priority information. >> >> For instance a user items list being

Re: [dpdk-dev] [PATCH v5 14/15] vhost: add notification for packed ring

2018-06-29 Thread Tiwei Bie
On Fri, Jun 22, 2018 at 03:43:26PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.c | 55 +++ > lib/librte_vhost/vhost.h | 71 > > lib/librte_vhost/vhost_user.c

Re: [dpdk-dev] [PATCH v5 02/15] vhost: add helpers for packed virtqueues

2018-06-29 Thread Maxime Coquelin
On 06/29/2018 05:51 PM, Tiwei Bie wrote: On Fri, Jun 22, 2018 at 03:43:14PM +0200, Maxime Coquelin wrote: From: Jens Freimann Add some helper functions to check descriptor flags and check if a vring is of type packed. Signed-off-by: Jens Freimann Signed-off-by: Maxime Coquelin --- lib/

Re: [dpdk-dev] [PATCH v5 01/15] vhost: add virtio packed virtqueue defines

2018-06-29 Thread Maxime Coquelin
On 06/29/2018 05:47 PM, Tiwei Bie wrote: On Fri, Jun 22, 2018 at 03:43:13PM +0200, Maxime Coquelin wrote: From: Jens Freimann Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.h | 4 lib/librte_vhost/virtio-packed.h | 22 ++ 2 files changed, 26 ins

Re: [dpdk-dev] [PATCH] docs: add default that all fixes are backported

2018-06-29 Thread Thomas Monjalon
21/06/2018 18:45, Ferruh Yigit: > On 6/21/2018 5:00 PM, Kevin Traynor wrote: > > Set the starting point that all commits on master branch > > with Fixes tag are backported to relevant stable/LTS branches. > > > > Of course there will be exceptions that will crop up from time > > to time that need

Re: [dpdk-dev] [PATCH v5 09/15] vhost: add shadow used ring support for packed rings

2018-06-29 Thread Tiwei Bie
On Fri, Jun 22, 2018 at 03:43:21PM +0200, Maxime Coquelin wrote: [...] > index 671b4b3bf..62d49f238 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -80,6 +80,12 @@ struct log_cache_entry { > unsigned long val; > }; > > +struct vring_used_elem_packed { > +

Re: [dpdk-dev] [PATCH] maintainers: update for ethdev

2018-06-29 Thread Thomas Monjalon
29/06/2018 17:51, Ferruh Yigit: > On 6/29/2018 4:11 PM, Andrew Rybchenko wrote: > > On 06/29/2018 05:58 PM, Thomas Monjalon wrote: > >> Ferruh and Andrew are doing excellent reviews and contributions > >> to ethdev API. > >> They become official maintainers and responsibles of this major lib. > >>

Re: [dpdk-dev] [PATCH v5 03/15] vhost: vring address setup for packed queues

2018-06-29 Thread Tiwei Bie
On Fri, Jun 22, 2018 at 03:43:15PM +0200, Maxime Coquelin wrote: > From: Yuanhan Liu > > Add code to set up packed queues when enabled. > > Signed-off-by: Yuanhan Liu > Signed-off-by: Jens Freimann > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.c | 44 > +++

Re: [dpdk-dev] [PATCH v5 02/15] vhost: add helpers for packed virtqueues

2018-06-29 Thread Tiwei Bie
On Fri, Jun 22, 2018 at 03:43:14PM +0200, Maxime Coquelin wrote: > From: Jens Freimann > > Add some helper functions to check descriptor flags > and check if a vring is of type packed. > > Signed-off-by: Jens Freimann > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h |

Re: [dpdk-dev] [PATCH] maintainers: update for ethdev

2018-06-29 Thread Ferruh Yigit
On 6/29/2018 4:11 PM, Andrew Rybchenko wrote: > On 06/29/2018 05:58 PM, Thomas Monjalon wrote: >> Ferruh and Andrew are doing excellent reviews and contributions >> to ethdev API. >> They become official maintainers and responsibles of this major lib. >> >> Signed-off-by: Thomas Monjalon >> --- >>

Re: [dpdk-dev] [PATCH v4 0/4] lib/rib: Add Routing Information Base library

2018-06-29 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 01:03:30AM +0300, Medvedkin Vladimir wrote: > This patch series introduces new library librte_rib which potentially could > replace librte_lpm. > > RIB is an alternative to current LPM library. > It solves the following problems > - Increases the speed of control plane ope

Re: [dpdk-dev] [PATCH v5 01/15] vhost: add virtio packed virtqueue defines

2018-06-29 Thread Tiwei Bie
On Fri, Jun 22, 2018 at 03:43:13PM +0200, Maxime Coquelin wrote: > From: Jens Freimann > > Signed-off-by: Jens Freimann > --- > lib/librte_vhost/vhost.h | 4 > lib/librte_vhost/virtio-packed.h | 22 ++ > 2 files changed, 26 insertions(+) > create mode 100644 l

[dpdk-dev] [PATCH 2/2] net/sfc: support Rx descriptor status for EF10 ESSB datapath

2018-06-29 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_ef10_essb_rx.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c index 257e40db1..040380650 100644 --- a/dri

[dpdk-dev] [PATCH 1/2] net/sfc: support ops to check ready descriptors in ESSB Rx

2018-06-29 Thread Andrew Rybchenko
Implement EF10 ESSB Rx datapath callback to get number of pending descriptors. Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_ef10_essb_rx.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/net/sfc/sfc_ef10

[dpdk-dev] [PATCH] net/sfc: fix double-free in EF10 ESSB Rx queue purge

2018-06-29 Thread Andrew Rybchenko
Number of buffers left in completed descriptor may be 0. If so, all buffers of the descriptor are freed once again. Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_ef1

Re: [dpdk-dev] [PATCH v4 3/4] Add autotests for RIB library

2018-06-29 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 01:03:33AM +0300, Medvedkin Vladimir wrote: > Signed-off-by: Medvedkin Vladimir > --- > test/test/Makefile | 5 + > test/test/meson.build| 8 + > test/test/test_rib.c | 308 > +++ > test/test/te

[dpdk-dev] [PATCH] net/sfc: discard packets with bad CRC on EF10 ESSB Rx

2018-06-29 Thread Andrew Rybchenko
Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_ef10_essb_rx.c | 7 +++ drivers/net/sfc/sfc_ef10_rx_ev.h | 6 +- 2 files changed, 12 insertions(+), 1 deletion

[dpdk-dev] [PATCH] net/sfc: cut non VLAN ID bits from TCI

2018-06-29 Thread Andrew Rybchenko
TCI may contain PCP or DEI bits. Matching of these bits is not supported, but the bits still may be set in specification value and not covered by mask. So, these bits should be ignored. Fixes: 894080975e1e ("net/sfc: support VLAN in flow API filters") Cc: sta...@dpdk.org Signed-off-by: Andrew Ryb

Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation

2018-06-29 Thread Andrew Rybchenko
On 06/29/2018 12:44 PM, Jerin Jacob wrote: The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS) Fixes: 5de201df8927 ("ethdev: add stats per queue") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- lib/librte_ethdev/rte_ethdev.h

Re: [dpdk-dev] [PATCH] maintainers: update for ethdev

2018-06-29 Thread Andrew Rybchenko
On 06/29/2018 05:58 PM, Thomas Monjalon wrote: Ferruh and Andrew are doing excellent reviews and contributions to ethdev API. They become official maintainers and responsibles of this major lib. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --gi

Re: [dpdk-dev] [PATCH v4 3/4] Add autotests for RIB library

2018-06-29 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 01:03:33AM +0300, Medvedkin Vladimir wrote: > Signed-off-by: Medvedkin Vladimir > --- > test/test/Makefile | 5 + > test/test/meson.build| 8 + > test/test/test_rib.c | 308 > +++ > test/test/te

[dpdk-dev] [PATCH] maintainers: update for ethdev

2018-06-29 Thread Thomas Monjalon
Ferruh and Andrew are doing excellent reviews and contributions to ethdev API. They become official maintainers and responsibles of this major lib. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3bc928f46..dabb

Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-29 Thread Thomas Monjalon
29/06/2018 16:05, Iremonger, Bernard: > Hi Maxime, Thomas, > > > > Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy > > neighbour > > > > Hi Bernard, > > > > On 06/26/2018 01:09 PM, Iremonger, Bernard wrote: > > > checkpatch.pl is showing the following warnings: > >

Re: [dpdk-dev] [PATCH v5 0/4] Support for write combining.

2018-06-29 Thread Ferruh Yigit
On 6/29/2018 2:54 PM, Rafal Kozik wrote: > Support for write combining. > > --- > v2: > * Rebased on top of master. > * Fix typos. > * Make commit messages more verbose. > * Add comments. > * Initialize fd. > > --- > v3: > * Log if BAR was mapped with or without support for WC. > > --- > v

Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-29 Thread Maxime Coquelin
On 06/29/2018 04:05 PM, Iremonger, Bernard wrote: Hi Maxime, Thomas, Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour Hi Bernard, On 06/26/2018 01:09 PM, Iremonger, Bernard wrote: checkpatch.pl is showing the following warnings: WARNING: Missing or

Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-29 Thread Maxime Coquelin
Hi Sharaf, On 06/26/2018 02:17 PM, Shahaf Shuler wrote: +/* + * Forwarding of packets in I/O mode. + * Forward packets "as-is". + * This is the fastest possible forwarding operation, as it does not +access + * to packets data. + */ +static void +pkt_burst_noisy_vnf(struct fwd_stream *fs) { +

Re: [dpdk-dev] [PATCH v4 3/4] Add autotests for RIB library

2018-06-29 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 01:03:33AM +0300, Medvedkin Vladimir wrote: > Signed-off-by: Medvedkin Vladimir > --- > test/test/Makefile | 5 + > test/test/meson.build| 8 + > test/test/test_rib.c | 308 > +++ > test/test/te

Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-29 Thread Iremonger, Bernard
Hi Maxime, Thomas, > Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy > neighbour > > Hi Bernard, > > On 06/26/2018 01:09 PM, Iremonger, Bernard wrote: > > checkpatch.pl is showing the following warnings: > > > > WARNING: Missing or malformed SPDX-License-Identifier

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-06-29 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 01:03:31AM +0300, Medvedkin Vladimir wrote: > Signed-off-by: Medvedkin Vladimir > --- > config/common_base | 6 + > doc/api/doxy-api.conf | 1 + > lib/Makefile | 2 + > lib/librte_rib/Makefile| 23 ++ >

[dpdk-dev] [PATCH v3] crypto/scheduler: add dynamic logging

2018-06-29 Thread Hari Kumar
1.added new logtype for driver. 2.registered the new logtype. 3.CS_LOG_ERR and RTE_LOG logtypes are replaced with new logtype name. Signed-off-by: Hari Kumar Reviewed-by: Reshma Pattan Reviewed-by: Pablo de Lara Guarch --- v3: Changed suggested macro name and title. Removed unused CONFIG_RT

[dpdk-dev] [PATCH v5 1/4] igb_uio: add wc option

2018-06-29 Thread Rafal Kozik
From: Kozik Write combining (WC) increases NIC performance by making better utilization of PCI bus, but cannot be use by all PMD. To get internal_addr memory need to be mapped. But as memory could not be mapped twice: with and without WC it should be skipped for WC. [1] To do not spoil other dr

[dpdk-dev] [PATCH v5 2/4] bus/pci: reference driver structure

2018-06-29 Thread Rafal Kozik
From: Kozik Add pointer to driver structure before calling rte_pci_map_device. It allows to use driver flags for adjusting configuration. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/bus/pci/pci_common.c | 17 - 1 file changed, 12 insertions(+), 5 deletion

[dpdk-dev] [PATCH v5 4/4] net/ena: enable WC

2018-06-29 Thread Rafal Kozik
From: Kozik Write combining (WC) increases NIC performance by making better utilization of PCI bus. ENA PMD may make usage of this feature. To enable it load igb_uio driver with wc_activate set to 1. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/net/ena/ena_ethdev.c | 3 +

[dpdk-dev] [PATCH v5 3/4] eal: enable WC during resources mapping

2018-06-29 Thread Rafal Kozik
From: Kozik Write combining (WC) increases NIC performance by making better utilization of PCI bus, but cannot be used by all PMDs. It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in drivers flags. For proper work also igb_uio driver must be loaded with wc_activate set to 1. When

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-06-29 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 01:03:31AM +0300, Medvedkin Vladimir wrote: > Signed-off-by: Medvedkin Vladimir > --- > config/common_base | 6 + > doc/api/doxy-api.conf | 1 + > lib/Makefile | 2 + > lib/librte_rib/Makefile| 23 ++ >

[dpdk-dev] [PATCH v5 0/4] Support for write combining.

2018-06-29 Thread Rafal Kozik
Support for write combining. --- v2: * Rebased on top of master. * Fix typos. * Make commit messages more verbose. * Add comments. * Initialize fd. --- v3: * Log if BAR was mapped with or without support for WC. --- v4: * Log only if WC mapping failed. * Log if wc_activate is set in igb_

[dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf.

2018-06-29 Thread Ian Stokes
This patch enables setting the MTU of an igbvf device by re-using the eth_igb_mtu_set() in igbvf_eth_dev_ops. Cc: sta...@dpdk.org Signed-off-by: Ian Stokes --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/i

Re: [dpdk-dev] [PATCH] net/e1000: Support mtu set for igbvf.

2018-06-29 Thread Ian Stokes
On 6/29/2018 2:36 PM, Ian Stokes wrote: This patch enables setting the MTU of an igbvf device by re-using the eth_igb_mtu_set() in igbvf_eth_dev_ops. Cc: sta...@dpdk.org Signed-off-by: Ian Stokes --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

Re: [dpdk-dev] [PATCH v4 1/4] igb_uio: add wc option

2018-06-29 Thread Ferruh Yigit
On 6/29/2018 1:17 PM, Rafal Kozik wrote: > From: Kozik > > Write combining (WC) increases NIC performance by making better > utilization of PCI bus, but cannot be use by all PMD. > > To get internal_addr memory need to be mapped. But as memory could not be > mapped twice: with and without WC it

Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-29 Thread Maxime Coquelin
Hi Bernard, On 06/26/2018 01:09 PM, Iremonger, Bernard wrote: checkpatch.pl is showing the following warnings: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #122: FILE: app/test-pmd/noisy_vnf.c:1: +/* SPDX-License-Identifier: BSD-3-Clause I'm not sure to get what is wro

[dpdk-dev] [PATCH] net/e1000: Support mtu set for igbvf.

2018-06-29 Thread Ian Stokes
This patch enables setting the MTU of an igbvf device by re-using the eth_igb_mtu_set() in igbvf_eth_dev_ops. Cc: sta...@dpdk.org Signed-off-by: Ian Stokes --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/i

Re: [dpdk-dev] [PATCH v4 1/4] igb_uio: add wc option

2018-06-29 Thread Ferruh Yigit
On 6/29/2018 1:17 PM, Rafal Kozik wrote: > From: Kozik > > Write combining (WC) increases NIC performance by making better > utilization of PCI bus, but cannot be use by all PMD. > > To get internal_addr memory need to be mapped. But as memory could not be > mapped twice: with and without WC it

Re: [dpdk-dev] [PATCH v4 1/4] igb_uio: add wc option

2018-06-29 Thread Rafał Kozik
> How can I confirm this silently fall-back behavior, is there any log can I > turn > on in kernel or anything from proc/sysfs? I cannot find any. I check it by measuring write speed. 2018-06-29 14:17 GMT+02:00 Rafal Kozik : > From: Kozik > > Write combining (WC) increases NIC performance by ma

Re: [dpdk-dev] [PATCH v3 00/11] support in-order feature

2018-06-29 Thread Maxime Coquelin
Hi, I was about to apply it, but there are quite a few checkpatch and git-check-log.sh issues reported. Could you please resent with this fixed? Also, I think it would be better to squash the doc patches in relevant ones. Thanks, Maxime On 06/28/2018 11:52 PM, Marvin Liu wrote: In latest virt

[dpdk-dev] [PATCH v3] examples: fix RSS hash function configuration

2018-06-29 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-29 Thread Ferruh Yigit
On 6/29/2018 12:55 AM, Thomas Monjalon wrote: > 20/06/2018 19:15, Ferruh Yigit: >> On 6/20/2018 6:07 PM, Dan Gora wrote: >>> Hi Ferruh, >>> >>> The documentation for rte_eth_dev_configure() should get updated as >>> well to document this requirement to strip the unsupported RSS hash >>> function bi

Re: [dpdk-dev] [PATCH V4 5/9] bus: add helper to handle sigbus

2018-06-29 Thread Gaëtan Rivet
On Fri, Jun 29, 2018 at 12:21:39PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Guo, Jia > > Sent: Friday, June 29, 2018 12:23 PM > > To: Ananyev, Konstantin ; > > step...@networkplumber.org; Richardson, Bruce > > ; Yigit, Ferruh ; > > gaetan.ri...@6wind.com; W

[dpdk-dev] [PATCH v2] crypto/openssl: add dynamic logging

2018-06-29 Thread Naga Suresh Somarowthu
1.added new logtype for openssl driver. 2.registered new logtype. 3.OPENSSL_LOG_ERR and CDEV_LOG_ERR are replaced with new logtype name OPENSSL_PMD_LOG. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Pablo de Lara Guarch --- v2: Changed suggested macro name and

  1   2   >