[dpdk-dev] [PATCH v2] eventdev: add callback for Rx adapter SW transfers

2018-06-27 Thread Nikhil Rao
Add ability for application to register a callback function for SW transfers, the callback can decide which packets can be enqueued to the event device. Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --- Changelog = v1->v2: * Change function names to rte_event_eth_rx_adapter_ namespac

Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check

2018-06-27 Thread Shahaf Shuler
Wednesday, June 27, 2018 2:55 PM, Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix invalid error check > > On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote: > > Since its return type is unsigned, if_nametoindex() returns 0 in case > > of error, never -1. > > > > Fixes: ccdcba

[dpdk-dev] [PATCH] net/mlx4: refinements to Rx packet type report

2018-06-27 Thread Moti Haimovsky
This commit refines the Rx Packet type flags reported by the PMD for each packet being received in order to make the report more accurate. Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4_prm.h | 1 + drivers/net/mlx4/mlx4_rxtx.c | 153 +-- 2 fil

[dpdk-dev] [PATCH] ip_frag: add function rte_ip_frag_sweep_table()

2018-06-27 Thread Fu, Qiaobin
Function rte_ip_frag_sweep_table() enables callers to incrementally sweep IP frament tables for incomplete, expired fragments. rte_ip_frag_sweep_table() is needed to identify never-to-be-completed fragments during DDoS attacks. Signed-off-by: Qiaobin Fu Reviewed-by: Cody Doucette Reviewed-by: M

[dpdk-dev] [PATCH 2/2] net/qede: fix Rx/Tx offload flags

2018-06-27 Thread Rasesh Mody
From: Shahed Shaikh - We don't support QinQ offload, so removing it now. - Fix incorrect offload flags in default rxconf Since qede PMD does not support per queue rx offload, it should not set default_rxconf.offload flags in .dev_infos_get(). Although these offloads are enabled by defa

[dpdk-dev] [PATCH 1/2] net/qede: fix default extended VLAN offload config

2018-06-27 Thread Rasesh Mody
This patch disables extended VLAN offload by default as PMD does not support it. Fixes: d87246a43759 ("net/qede: enable and disable VLAN filtering") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors

2018-06-27 Thread Shahaf Shuler
Wednesday, June 27, 2018 4:32 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors > > On Sun, Jun 17, 2018 at 10:15:07AM +, Shahaf Shuler wrote: > > Hi Adrien, > > > > Saturday, June 16, 2018 11:58 AM, Xueming(Steven) Li: > > > Subject: RE: [dpd

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors

2018-06-27 Thread Shahaf Shuler
Wednesday, June 27, 2018 4:33 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors > > On Sun, Jun 24, 2018 at 01:33:31PM +, Shahaf Shuler wrote: > > One more input, > > > > Sunday, June 17, 2018 1:15 PM, Shahaf Shuler: > > > Subject: RE: [dpdk-d

Re: [dpdk-dev] [PATCH v2 2/7] net/mlx5: remove redundant objects in probe code

2018-06-27 Thread Shahaf Shuler
Wednesday, June 27, 2018 4:31 PM, Adrien Mazarguil: > Subject: Re: [PATCH v2 2/7] net/mlx5: remove redundant objects in probe > code > > Hey Shahaf, > > I couldn't reply earlier, sorry for that. See below. > > On Sun, Jun 17, 2018 at 10:14:01AM +, Shahaf Shuler wrote: > > Hi Adrien, > > > >

[dpdk-dev] [PATCH v3 5/5] eventdev: add Rx adapter tests for interrupt driven queues

2018-06-27 Thread Nikhil Rao
Add test for queue add and delete, the add/delete calls also switch queues between poll and interrupt mode. Signed-off-by: Nikhil Rao --- test/test/test_event_eth_rx_adapter.c | 261 +++--- 1 file changed, 242 insertions(+), 19 deletions(-) diff --git a/test/test/tes

[dpdk-dev] [PATCH v3 4/5] eventdev: add interrupt driven queues to Rx adapter

2018-06-27 Thread Nikhil Rao
Add support for interrupt driven queues when eth device is configured for rxq interrupts and servicing weight for the queue is configured to be zero. A interrupt driven packet received counter has been added to rte_event_eth_rx_adapter_stats. Signed-off-by: Nikhil Rao --- config/rte_config.h

[dpdk-dev] [PATCH v3 3/5] eventdev: move Rx adapter eth Rx to separate function

2018-06-27 Thread Nikhil Rao
Create a separate function that handles eth receive and enqueue to event buffer. This function will also be called for interrupt driven receive queues. Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 67 ++ 1 file chan

[dpdk-dev] [PATCH v3 0/5] eventdev: add interrupt driven queues to Rx adapter

2018-06-27 Thread Nikhil Rao
This patch series adds support for interrupt driven queues to the ethernet Rx adapter, the first 3 patches prepare the code to handle both poll and interrupt driven Rx queues, the 4th patch patch has code changes specific to interrupt driven queues and the final patch has test code. Changelog: v2

[dpdk-dev] [PATCH v3 1/5] eventdev: standardize Rx adapter internal function names

2018-06-27 Thread Nikhil Rao
Add a common prefix to function names and rename few to better match functionality Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 167 - 1 file changed, 80 insertions(+), 87 deletions(-) diff --git a/lib/librte_event

[dpdk-dev] [PATCH v3 2/5] eventdev: improve err handling for Rx adapter queue add/del

2018-06-27 Thread Nikhil Rao
The new WRR sequence applicable after queue add/del is set up after setting the new queue state, so a memory allocation failure will leave behind an incorrect state. This change separates the memory sizing + allocation for the Rx poll and WRR array from calculation of the WRR sequence. If there is

[dpdk-dev] [PATCH 14/14] net/enic: cap Rx packet processing to end of desc ring

2018-06-27 Thread John Daley
In the default Rx handler stop processing packets at the end of the completion ring so that wrapping doesn't have to be checked in the inner while loop. Also, check the color bit in the completion without using a conditional. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/ne

[dpdk-dev] [PATCH 13/14] net/enic: add simple Rx handler

2018-06-27 Thread John Daley
Add an optimized Rx handler for non-scattered Rx. Signed-off-by: Hyong Youb Kim Signed-off-by: John Daley --- drivers/net/enic/base/cq_desc.h | 1 + drivers/net/enic/base/vnic_rq.h | 2 + drivers/net/enic/enic.h | 2 + drivers/net/enic/enic_ethdev.c | 3 +- drivers/net/enic/eni

[dpdk-dev] [PATCH 12/14] net/enic: check maximum packet size in Tx prepare handler

2018-06-27 Thread John Daley
From: Hyong Youb Kim The default tx handler checks the maximum packet size. Check it in the prepare handler too. WQ stops working if the app/driver tries to send oversized packets, so these checks are unavoidable. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic

[dpdk-dev] [PATCH 11/14] net/enic: add the simple version of Tx handler

2018-06-27 Thread John Daley
From: Hyong Youb Kim Add a much-simplified handler that works when all offloads are disabled, except mbuf fast free. When compared against the default handler, under ideal conditions, cycles per packet drop by 60+%. By default, the driver tries to use the simple handler. Add a new devarg (disabl

[dpdk-dev] [PATCH 10/14] net/enic: reduce Tx completion updates

2018-06-27 Thread John Daley
From: Hyong Youb Kim Request one completion update per roughly 32 buffers. It saves DMA resources on the NIC, PCIe utilization, and cache miss rates. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_wq.c | 1 + drivers/net/enic/base/vnic_wq.h | 1 + drive

[dpdk-dev] [PATCH 09/14] net/enic: support mbuf fast free offload

2018-06-27 Thread John Daley
From: Hyong Youb Kim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_wq.h | 1 + drivers/net/enic/enic.h | 1 + drivers/net/enic/enic_ethdev.c | 11 --- drivers/net/enic/enic_res.c | 2 ++ drivers/net/enic/enic_rxtx.c| 30 +++

[dpdk-dev] [PATCH 08/14] net/enic: use mbuf pointer array for inflight Tx packets

2018-06-27 Thread John Daley
From: Hyong Youb Kim WQ is currently using vnic_wq_buf to store mbuf pointers for Tx packets. But, it contains an unused mempool pointer and mbuf is unnecessarily cast to void pointer. Remove vnic_wq_buf entirely and use an mbuf pointer array instead. Signed-off-by: Hyong Youb Kim Reviewed-by:

[dpdk-dev] [PATCH 05/14] net/enic: report ring limits and preferred default values

2018-06-27 Thread John Daley
From: Hyong Youb Kim Report min/max ring sizes, alignments, and so on, and rely on the common checks implemented in the rte_ethdev layer. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 24 drivers/net/enic/enic_main.c | 24

[dpdk-dev] [PATCH 06/14] net/enic: add devarg to specify ingress VLAN rewrite mode

2018-06-27 Thread John Daley
From: Hyong Youb Kim Add a new devarg "ig-vlan-rewrite" to allow the user to set non-default rewrite mode. The UCS VIC may add/remove/modify the VLAN header of an ingress packet depending on the ingress VLAN rewrite mode. By default, the driver sets the pass-through mode, which tells the NIC "do

[dpdk-dev] [PATCH 07/14] net/enic: add handlers to add/delete vxlan port number

2018-06-27 Thread John Daley
From: Hyong Youb Kim The NIC has one configurable VXLAN port, which is set to the default 4789 upon vNIC reset. Adding a non-default port replaces this single VXLAN port. Deleting the previously added non-default port restores the VXLAN port to the hardware default. Signed-off-by: Hyong Youb Kim

[dpdk-dev] [PATCH 04/14] net/enic: initialize RQ fetch index before enabling RQ

2018-06-27 Thread John Daley
From: Hyong Youb Kim The fetch index must be initialized only when RQ is disabled. Otherwise, it may lead to stale entries in IG descriptor cache on the VIC. Fixes: a74629cfa3a1 ("net/enic: enable RQ first and then post Rx buffers") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- d

[dpdk-dev] [PATCH 03/14] net/enic: do not overwrite admin Tx queue limit

2018-06-27 Thread John Daley
From: Hyong Youb Kim Currently, enic_alloc_wq (via rte_eth_tx_queue_setup) may overwrite the admin limit with a lower value. This is wrong as seen in the following sequence. 1. UCS admin-set Tx queue limit (config.wq_desc_count) = 4096 2. Set up tx queue with 512 descriptors The admin limit (

[dpdk-dev] [PATCH 02/14] net/enic: update the UDP RSS detection mechanism

2018-06-27 Thread John Daley
From: Hyong Youb Kim The UDP RSS interface has changed in the release firmware for 100G VIC adapters. The capability bit is now in NIC_CFG. Also the driver is supposed to use CMD_NIC_CFG_CHK and check if RSS config is successful. No more changes are expected with respect to UDP RSS API. Fixes: 9

[dpdk-dev] [PATCH 01/14] net/enic: fix receive packet types

2018-06-27 Thread John Daley
From: Hyong Youb Kim Fix missing or incorrect packet types discovered by DTS. - Non-IP inner packets Set the tunnel flag. - Inner Ethernet packets All supported tunnel packets have Ethernet as inner packets. So, set INNER_L2_ETHER for all tunnel types. - IPv4 fragments carrying TCP/UDP Th

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-27 Thread Joseph, Anoob
Hi Declan, Please see inline. Thanks, Anoob On 26-06-2018 15:42, Doherty, Declan wrote: External Email On 19/06/2018 7:26 AM, Anoob Joseph wrote: Enabling crypto devs to specify the minimum headroom and tailroom it expects in the mbuf. For net PMDs, standard headroom has to be honoured by

Re: [dpdk-dev] [PATCH] net/i40e: remove memset in i40evf_dev_info_get

2018-06-27 Thread Xing, Beilei
Hi, Thanks for the patch, but there's another patch which has been accepted for the issue. https://patches.dpdk.org/patch/40682/ Best Regards, Beilei > -Original Message- > From: David Harton [mailto:dhar...@cisco.com] > Sent: Thursday, June 28, 2018 9:16 AM > To: Xing, Beilei ; Zhang,

Re: [dpdk-dev] Reviewathon

2018-06-27 Thread Dan Gora
Someone should add this IRC board to the dpdk.org website... I had no idea it existed until this email. > [2] > IRC freenode #dpdk-board > web client: https://webchat.freenode.net/

[dpdk-dev] [PATCH v6 19/19] doc: update release notes for multi process hotplug

2018-06-27 Thread Qi Zhang
Update release notes for the new multi process hotplug feature. Signed-off-by: Qi Zhang --- doc/guides/rel_notes/release_18_08.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index bc0

[dpdk-dev] [PATCH v6 18/19] examples/multi_process: add hotplug sample

2018-06-27 Thread Qi Zhang
The sample code demonstrate device (ethdev only) management at multi-process envrionment. User can attach/detach a device on primary process and see it is synced on secondary process automatically, also user can lock a device to prevent it be detached or unlock it to go back to default behaviour.

[dpdk-dev] [PATCH v6 16/19] net/tap: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/tap/rte_eth_tap.c | 17 +++-- 1 file

[dpdk-dev] [PATCH v6 17/19] net/vhost: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/vhost/rte_eth_vhost.c | 11 +++ 1 file c

[dpdk-dev] [PATCH v6 14/19] net/pcap: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/pcap/rte_eth_pcap.c | 15 ++- 1 file

[dpdk-dev] [PATCH v6 12/19] net/null: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/null/rte_eth_null.c | 16 +++- 1 fil

[dpdk-dev] [PATCH v6 13/19] net/octeontx: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/octeontx/octeontx_ethdev.c | 16

[dpdk-dev] [PATCH v6 15/19] net/softnic: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/softnic/rte_eth_softnic.c | 19 -

[dpdk-dev] [PATCH v6 11/19] net/kni: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/kni/rte_eth_kni.c | 11 +++ 1 file chang

[dpdk-dev] [PATCH v6 08/19] net/ixgbe: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH v6 09/19] net/af_packet: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/af_packet/rte_eth_af_packet.c | 11 +++

[dpdk-dev] [PATCH v6 10/19] net/bonding: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++ 1 f

[dpdk-dev] [PATCH v6 07/19] net/i40e: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 ++ 1 file changed, 2 ins

[dpdk-dev] [PATCH v6 05/19] ethdev: support attach or detach share device from secondary

2018-06-27 Thread Qi Zhang
This patch cover the multi-process hotplug case when a share device attach/detach request be issued from secondary process device attach on secondary: a) seconary send sync request to primary. b) primary receive the request and attach the new device if failed goto i). c) primary forward attach

[dpdk-dev] [PATCH v6 06/19] ethdev: support attach private device as first

2018-06-27 Thread Qi Zhang
When attach a private device from secondary as the first one, we need to make sure rte_eth_dev_shared_data is initialized, the patch add necessary IPC for secondary to inform primary to do initialization. Signed-off-by: Qi Zhang --- lib/librte_ethdev/ethdev_mp.c | 2 ++ lib/librte_ethdev/e

[dpdk-dev] [PATCH v6 02/19] eal: enable multi process init callback

2018-06-27 Thread Qi Zhang
Introduce new API rte_eal_register_mp_init that help to register a callback function which will be invoked right after multi-process channel be established (rte_mp_channel_init). Typically the API will be used by other module that want it's mp channel action callbacks can be registered during rte_e

[dpdk-dev] [PATCH v6 04/19] ethdev: introduce device lock

2018-06-27 Thread Qi Zhang
Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let application lock or unlock on specific ethdev, a locked device can't be detached, this help applicaiton to prevent unexpected device detaching, especially in multi-process envrionment. Aslo introduce the new API rte_eth_dev_lock_with_cal

[dpdk-dev] [PATCH v6 03/19] ethdev: enable hotplug on multi-process

2018-06-27 Thread Qi Zhang
We are going to introduce the solution to handle different hotplug cases in multi-process situation, it include below scenario: 1. Attach a share device from primary 2. Detach a share device from primary 3. Attach a share device from secondary 4. Detach a share device from secondary 5. Attach a pr

[dpdk-dev] [PATCH v6 01/19] ethdev: add function to release port in local process

2018-06-27 Thread Qi Zhang
Add driver API rte_eth_release_port_private to support the requirement that an ethdev only be released on secondary process, so only local state be set to unused , share data will not be reset so primary process can still use it. Signed-off-by: Qi Zhang --- lib/librte_ethdev/rte_ethdev.c

[dpdk-dev] [PATCH v6 00/19] enable hotplug on multi-process

2018-06-27 Thread Qi Zhang
v6: - remove bus->scan_one, since ABI break is not necessary. - remove patch for failsafe PMD since it will not support secondary. - fix wrong implemenation on ixgbe. - add rte_eth_dev_release_port_private into rte_eth_dev_pci_generic_remove for secondary process, so we don't need to patch on PMD

[dpdk-dev] [PATCH v6 17/19] net/vhost: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/vhost/rte_eth_vhost.c | 11 +++ 1 file c

[dpdk-dev] [PATCH v6 18/19] examples/multi_process: add hotplug sample

2018-06-27 Thread Qi Zhang
The sample code demonstrate device (ethdev only) management at multi-process envrionment. User can attach/detach a device on primary process and see it is synced on secondary process automatically, also user can lock a device to prevent it be detached or unlock it to go back to default behaviour.

[dpdk-dev] [PATCH v6 19/19] doc: update release notes for multi process hotplug

2018-06-27 Thread Qi Zhang
Update release notes for the new multi process hotplug feature. Signed-off-by: Qi Zhang --- doc/guides/rel_notes/release_18_08.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index bc0

[dpdk-dev] [PATCH v6 16/19] net/tap: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/tap/rte_eth_tap.c | 17 +++-- 1 file

[dpdk-dev] [PATCH v6 14/19] net/pcap: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/pcap/rte_eth_pcap.c | 15 ++- 1 file

[dpdk-dev] [PATCH v6 13/19] net/octeontx: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/octeontx/octeontx_ethdev.c | 16

[dpdk-dev] [PATCH v6 15/19] net/softnic: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/softnic/rte_eth_softnic.c | 19 -

[dpdk-dev] [PATCH v6 12/19] net/null: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/null/rte_eth_null.c | 16 +++- 1 fil

[dpdk-dev] [PATCH v6 07/19] net/i40e: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 ++ 1 file changed, 2 ins

[dpdk-dev] [PATCH v6 08/19] net/ixgbe: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH v6 11/19] net/kni: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/kni/rte_eth_kni.c | 11 +++ 1 file chang

[dpdk-dev] [PATCH v6 06/19] ethdev: support attach private device as first

2018-06-27 Thread Qi Zhang
When attach a private device from secondary as the first one, we need to make sure rte_eth_dev_shared_data is initialized, the patch add necessary IPC for secondary to inform primary to do initialization. Signed-off-by: Qi Zhang --- lib/librte_ethdev/ethdev_mp.c | 2 ++ lib/librte_ethdev/e

[dpdk-dev] [PATCH v6 02/19] eal: enable multi process init callback

2018-06-27 Thread Qi Zhang
Introduce new API rte_eal_register_mp_init that help to register a callback function which will be invoked right after multi-process channel be established (rte_mp_channel_init). Typically the API will be used by other module that want it's mp channel action callbacks can be registered during rte_e

[dpdk-dev] [PATCH v6 04/19] ethdev: introduce device lock

2018-06-27 Thread Qi Zhang
Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let application lock or unlock on specific ethdev, a locked device can't be detached, this help applicaiton to prevent unexpected device detaching, especially in multi-process envrionment. Aslo introduce the new API rte_eth_dev_lock_with_cal

[dpdk-dev] [PATCH v6 05/19] ethdev: support attach or detach share device from secondary

2018-06-27 Thread Qi Zhang
This patch cover the multi-process hotplug case when a share device attach/detach request be issued from secondary process device attach on secondary: a) seconary send sync request to primary. b) primary receive the request and attach the new device if failed goto i). c) primary forward attach

[dpdk-dev] [PATCH v5 00/24] enable hotplug on multi-process

2018-06-27 Thread Qi Zhang
v6: - remove bus->scan_one, since ABI break is not necessary. - remove patch for failsafe PMD since it will not support secondary. - fix wrong implemenation on ixgbe. - add rte_eth_dev_release_port_private into rte_eth_dev_pci_generic_remove for secondary process, so we don't need to patch on PMD

[dpdk-dev] [PATCH v6 01/19] ethdev: add function to release port in local process

2018-06-27 Thread Qi Zhang
Add driver API rte_eth_release_port_private to support the requirement that an ethdev only be released on secondary process, so only local state be set to unused , share data will not be reset so primary process can still use it. Signed-off-by: Qi Zhang --- lib/librte_ethdev/rte_ethdev.c

[dpdk-dev] [PATCH v6 10/19] net/bonding: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++ 1 f

[dpdk-dev] [PATCH v6 03/19] ethdev: enable hotplug on multi-process

2018-06-27 Thread Qi Zhang
We are going to introduce the solution to handle different hotplug cases in multi-process situation, it include below scenario: 1. Attach a share device from primary 2. Detach a share device from primary 3. Attach a share device from secondary 4. Detach a share device from secondary 5. Attach a pr

[dpdk-dev] [PATCH v6 09/19] net/af_packet: enable port detach on secondary process

2018-06-27 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/af_packet/rte_eth_af_packet.c | 11 +++

Re: [dpdk-dev] [PATCH v3] net/i40e: remove VF interrupt handler

2018-06-27 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, June 27, 2018 9:15 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Yu, De ; > dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v3] net/i40e: remove VF interrupt handler > > For i40evf, internal rx interrupt and adminq interrupt share t

[dpdk-dev] [PATCH] net/i40e: remove memset in i40evf_dev_info_get

2018-06-27 Thread David Harton
i40evf_dev_info_get clears dev_info when data has already been set by the calling function. Remove the call to memset() to fix the problem. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: helin.zh...@intel.com Signed-off-by: David Harton --- drivers/net/i40e/i40e_ethdev_vf.c | 1 - 1 fil

[dpdk-dev] [PATCH v2] doc: update qede management firmware guide

2018-06-27 Thread Rasesh Mody
Fixes: c49a438fce90 ("doc: update qede guide and features") Fixes: db86fbe54d90 ("doc: update qede PMD NIC guide") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/qede.

Re: [dpdk-dev] [PATCH] doc: update qede management firmware guide

2018-06-27 Thread Mody, Rasesh
Hi Ferruh, > From: Mody, Rasesh > Sent: Friday, June 08, 2018 11:50 AM > > > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > Sent: Friday, June 08, 2018 11:10 AM > > > > On 6/1/2018 11:57 PM, Rasesh Mody wrote: > > > Fixes: c49a438fce90 ("doc: update qede guide and features") > > > Fixes:

Re: [dpdk-dev] [dpdk-stable] [PATCH v13 6/6] devtools: expand meson cross compiling test coverage

2018-06-27 Thread Thomas Monjalon
Hi, 25/06/2018 04:49, Gavin Hu: > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > # enable cross compilation if gcc cross-compiler is found > +c=aarch64-linux-gnu-gcc > +if ! command -v $c >/dev/null 2>&1 ; then > + echo "## ERROR: $c is missing, cross compiling is

Re: [dpdk-dev] [PATCH] cryptodev: fix ABI breakage

2018-06-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Wednesday, June 13, 2018 11:01 AM > To: De Lara Guarch, Pablo ; Doherty, Declan > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] cryptodev: fix ABI breakage > > > > > -Original Message- > > From: De Lara Gu

Re: [dpdk-dev] [PATCH] cryptodev: convert to SPDX license tag

2018-06-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Laatz, Kevin > Sent: Thursday, June 14, 2018 10:27 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH] cryptodev: convert to SPDX license tag > > Acked-by: Kevin Laatz > > On 11/06/2018 09:56, Pablo de Lara

Re: [dpdk-dev] [dpdk-stable] [PATCH v13 4/6] devtools: fix the missing ninja command error

2018-06-27 Thread Thomas Monjalon
25/06/2018 04:49, Gavin Hu: > On some linux distributions, eg: CentOS, the ninja executable has a > different name: ninja-build, this patch is to check and adapt to it > accordingly. > > ./devtools/test-meson-builds.sh: line 24: ninja: command not found > > Fixes: a55277a788 ("devtools: add test

Re: [dpdk-dev] [PATCH v3 0/3] crypto/qat: move files to drivers/common directory

2018-06-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Tuesday, June 26, 2018 9:18 AM > To: Trahe, Fiona ; Jozwiak, TomaszX > ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/3] crypto/qat: move files to drivers/common > directory > > This pat

Re: [dpdk-dev] [dpdk-stable] [PATCH v13 1/6] mk: fix makefile based cross build errors

2018-06-27 Thread Thomas Monjalon
25/06/2018 04:49, Gavin Hu: > From: gavin hu > > The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was > enabled when the cross compiler gcc is greater than 7.0, but for the host > side buildtools/pmdinfogen, if the native gcc is older than 7.0, or the > host cc compiler is cl

Re: [dpdk-dev] [PATCH] net: rename u16 to fix shadowed declaration warning

2018-06-27 Thread Thomas Monjalon
25/06/2018 17:38, Olivier Matz: > On Mon, Jun 04, 2018 at 02:40:00PM -0500, Gage Eads wrote: > > This patch renames u16 to u16_buf. u16 as a variable name causes a shadowed > > declaration warning if, for example, the application also typedefs u16 > > (e.g. by including a header containing "typedef

Re: [dpdk-dev] [PATCH] pci: remove unused function

2018-06-27 Thread Thomas Monjalon
20/05/2018 21:52, Rami Rosen: > The function rte_pci_detach() is private to PCI and is > not used anywhere in current code base. Remove dead code. > > Signed-off-by: Rami Rosen Applied, thanks

[dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag

2018-06-27 Thread Pablo de Lara
The current mbuf scatter gather feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not. Therefore, three new flags will replace this flag: - RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT - RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT - RTE_COMP_FF_O

[dpdk-dev] [PATCH v2 2/2] compressdev: add huffman encoding flags

2018-06-27 Thread Pablo de Lara
Added Huffman fixed and dynamic encoding feature flags, so an application can query if a device supports these two types, when performing DEFLATE compression. Signed-off-by: Pablo de Lara --- Changes in v2: - Fixed typo drivers/compress/isal/isal_compress_pmd_ops.c | 4 +++- lib/librte_compre

[dpdk-dev] [PATCH 6/6] net/mlx5: add port ID pattern item to switch flow rules

2018-06-27 Thread Adrien Mazarguil
This enables flow rules to match traffic coming from a different DPDK port ID associated with the device (PORT_ID pattern item), mainly for the convenience of applications that want to deal with a single port ID for all flow rules associated with some physical device. Testpmd example: - Creating

[dpdk-dev] [PATCH 5/6] net/mlx5: add VLAN item and actions to switch flow rules

2018-06-27 Thread Adrien Mazarguil
This enables flow rules to explicitly match VLAN traffic (VLAN pattern item) and perform various operations on VLAN headers at the switch level (OF_POP_VLAN, OF_PUSH_VLAN, OF_SET_VLAN_VID and OF_SET_VLAN_PCP actions). Testpmd examples: - Directing all VLAN traffic received on port ID 1 to port ID

[dpdk-dev] [PATCH 4/6] net/mlx5: add L2-L4 pattern items to switch flow rules

2018-06-27 Thread Adrien Mazarguil
This enables flow rules to explicitly match supported combinations of Ethernet, IPv4, IPv6, TCP and UDP headers at the switch level. Testpmd example: - Dropping TCPv4 traffic with a specific destination on port ID 2: flow create 2 ingress transfer pattern eth / ipv4 / tcp dst is 42 / end

[dpdk-dev] [PATCH 3/6] net/mlx5: add fate actions to switch flow rules

2018-06-27 Thread Adrien Mazarguil
This patch enables creation of rte_flow rules that direct matching traffic to a different port (e.g. another VF representor) or drop it directly at the switch level (PORT_ID and DROP actions). Testpmd examples: - Directing all traffic to port ID 0: flow create 1 ingress transfer pattern end ac

[dpdk-dev] [PATCH 2/6] net/mlx5: add framework for switch flow rules

2018-06-27 Thread Adrien Mazarguil
Because mlx5 switch flow rules are configured through Netlink (TC interface) and have little in common with Verbs, this patch adds a separate parser function to handle them. - mlx5_nl_flow_transpose() converts a rte_flow rule to its TC equivalent and stores the result in a buffer. - mlx5_nl_flo

[dpdk-dev] [PATCH 1/6] net/mlx5: lay groundwork for switch offloads

2018-06-27 Thread Adrien Mazarguil
With mlx5, unlike normal flow rules implemented through Verbs for traffic emitted and received by the application, those targeting different logical ports of the device (VF representors for instance) are offloaded at the switch level and must be configured through Netlink (TC interface). This patc

[dpdk-dev] [PATCH 0/6] net/mlx5: add support for switch flow rules

2018-06-27 Thread Adrien Mazarguil
This series adds support for switch flow rules, that is, rte_flow rules applied to mlx5 devices at the switch level. It allows applications to offload traffic redirection between DPDK ports in hardware, while optionally modifying it (e.g. performing encap/decap). For this to work, involved DPDK p

[dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-06-27 Thread Neil Horman
Recently, some additional patches were added to allow for programmatic marking of C symbols as experimental. The addition of these markers is dependent on the manual addition of exported symbols to the EXPERIMENTAL section of the corresponding libraries version map file. The consensus on review i

Re: [dpdk-dev] [PATCH v8] checkpatches.sh: Add checks for ABI symbol addition

2018-06-27 Thread Neil Horman
On Tue, Jun 26, 2018 at 01:04:16AM +0200, Thomas Monjalon wrote: > 14/06/2018 15:30, Neil Horman: > > * found a way to eliminate the use of filterdiff (new awk rules) > > Thanks a lot for not requiring filterdiff dependency. > > [...] > > + # Just inform the user of thi

Re: [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags

2018-06-27 Thread Trahe, Fiona
> > > + case RTE_COMP_FF_HUFFMAN_FIXED: > > > + return "HUFFMAN_FIXED"; > > > + case RTE_COMP_FF_HUFFMAN_DYNAMIC: > > > + return "HUFFMAN_DYNAMIC"; > > [Fiona] Thanks for adding this. > > Just in case any other algos are added in future which also use Huffman > > encoding I'd sugges

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

2018-06-27 Thread Kevin Traynor
On 06/26/2018 12:40 PM, Radu Nicolau wrote: > From: Liang Ma > > 1. Abstract > > For packet processing workloads such as DPDK polling is continuous. > This means CPU cores always show 100% busy independent of how much work > those cores are doing. It is critical to accurately determine how busy

[dpdk-dev] [pull-request] next-pipeline 18.08 pre-rc1

2018-06-27 Thread Cristian Dumitrescu
The following changes since commit d67014c3d38b20ac4cfe103f5a7a2107feaa5acf: igb_uio: fail and log if kernel lock down is enabled (2018-06-27 17:02:54 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to bd9fea7cdbde0371

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors

2018-06-27 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, June 27, 2018 9:32 PM > To: Shahaf Shuler > Cc: Xueming(Steven) Li ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors > > On Sun, Jun 17, 2018 at 10:15:07AM +, Shahaf Shuler

Re: [dpdk-dev] [RFC] Add support for device dma mask

2018-06-27 Thread Alejandro Lucero
On Wed, Jun 27, 2018 at 2:24 PM, Burakov, Anatoly wrote: > On 27-Jun-18 11:13 AM, Alejandro Lucero wrote: > > >> >> On Wed, Jun 27, 2018 at 9:17 AM, Burakov, Anatoly < >> anatoly.bura...@intel.com > wrote: >> >> On 26-Jun-18 6:37 PM, Alejandro Lucero wrote: >

  1   2   3   >