Re: [dpdk-dev] [PATCH v2] i40e: fix corruption of VF stats via port representor

2018-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Horton, Remy > Sent: Friday, May 18, 2018 7:50 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Zhang, Qi Z > ; > Xing, Beilei ; Zhang, Helin ; > Wu, Jingjing > Subject: [PATCH v2] i40e: fix corruption of VF stats via port representor > > The resetting of stats

Re: [dpdk-dev] [PATCH 0/2] eal/malloc: fix wrong heap initialization over multiple memsegs

2018-05-18 Thread gowrishankar muthukrishnan
Hi Thomas, On Friday 18 May 2018 06:40 PM, Thomas Monjalon wrote: Hi, What is the status of DPDK 18.05 on IBM POWER? This patch suggests there are some issues but there were no news for two weeks, after comments from Anatoly. Are we going to release a DPDK which does not work well on POWER?

Re: [dpdk-dev] [PATCH v4] net/ixgbe: config VLAN strip on the fly

2018-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Dai, Wei > Sent: Saturday, May 19, 2018 12:09 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; Wu, > Yanglong ; Yigit, Ferruh > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v4] net/ixgbe: config VLAN strip on the fly > > The old ixgbe_vlan_offlo

[dpdk-dev] [PATCH] net/cxgbevf: fix inter-vm traffic when physical link down

2018-05-18 Thread Rahul Lakkireddy
From: Shagun Agrawal Add force_link_up devargs to always force link as up for VFs. This enables VFs on the same NIC to send traffic to each other even when physical link is down. Fixes: 011ebc236ddc ("net/cxgbe: add skeleton VF driver") Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghv

Re: [dpdk-dev] [PATCH 2/2] ethdev: fix shallow copy of flow API RAW item

2018-05-18 Thread Ferruh Yigit
On 5/16/2018 4:41 PM, Adrien Mazarguil wrote: > Like original commit mentioned below, this fix synchronizes flow rule copy > function with testpmd's own implementation following "app/testpmd: fix copy > of raw flow item (revisited)". > > Fixes: d0ad8648b1c5 ("ethdev: fix shallow copy of flow API R

Re: [dpdk-dev] [PATCH 0/7] bnxt patchset

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 3:39 PM, Ajit Khaparde wrote: > Patchset against dpdk-next. > Contains fixes mostly. Please apply. > > Ajit Khaparde (7): > net/bnxt: add fallthrough comments for cascading switch cases > net/bnxt: fix to initialize tx and rx burst for secondary processes > net/bnxt: fix rss has

[dpdk-dev] DPDK Release Status Meeting 17/05/2018

2018-05-18 Thread Mcnamara, John
For the last 3 weeks we have had an 30min inter-company weekly sync on the release status of the current DPDK release. It is mainly intended for DPDK Committers to discuss the status of the master and sub-trees. It is also intended as an update for project managers who need to track progress or mi

[dpdk-dev] [PATCH v2] cryptodev: extend feature flags description

2018-05-18 Thread Pablo de Lara
Extend the description of cryptodev feature flags, adding extra information. Signed-off-by: Pablo de Lara --- Changes in v2: - Rephrased the comment as per Vipin's comments - Added comment in cryptodev structure lib/librte_cryptodev/rte_cryptodev.h | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [dpdk-dev] [PATCH-18.08 08/15] net/ifc: rename to ifcvf

2018-05-18 Thread Wang, Xiao W
Hi, > -Original Message- > From: Richardson, Bruce > Sent: Friday, May 18, 2018 4:13 PM > To: Wang, Xiao W > Cc: dev@dpdk.org > Subject: Re: [PATCH-18.08 08/15] net/ifc: rename to ifcvf > > On Fri, May 18, 2018 at 02:52:36AM +0100, Wang, Xiao W wrote: > > Hi Bruce, > > > > > -Origina

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 4:55 PM, Matan Azrad wrote: > Hi all > > While this patch also applied I don't understand it. > Is it mandatory for each PMD to free all its resources in dev_close()? > Or it should be done by the rte_device remove function? > > If the resource cleanup should be done by the remove fu

[dpdk-dev] [PATCH v4] net/ixgbe: config VLAN strip on the fly

2018-05-18 Thread Wei Dai
The old ixgbe_vlan_offload_set() is called by rte_eth_dev_set_vlan_offload() which is meant to config VLAN strip/filter/extend on all queues. This old function is also called by rte_eth_dev_start()/ixgbe_dev_start() which need support per-queue VALN strip on only parts of queues. So add new functio

[dpdk-dev] [Bug 49] Compile error kni_net.c unknown field ‘ndo_change_mtu’

2018-05-18 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=49 Bug ID: 49 Summary: Compile error kni_net.c unknown field ‘ndo_change_mtu’ Product: DPDK Version: 18.02 Hardware: All OS: All Status: CONFIRMED Severity: major

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Dai, Wei
As 18.05 release is coming soon. I'd like to submit http://dpdk.org/dev/patchwork/patch/40226/ in reply to yanglong's v2 patch for quick review and validation. Thanks for your understanding. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dai, Wei > Sent: Friday

[dpdk-dev] [PATCH v3] net/ixgbe: config VLAN strip on the fly

2018-05-18 Thread Wei Dai
The old ixgbe_vlan_offload_set() is called by rte_eth_dev_set_vlan_offload() which is meant to config VLAN strip/filter/extend on all queues. This old fucntion is also called by rte_eth_dev_start()/ixgbe_dev_start() which need support per-queue VALN strip on only parts of queues. So add new functio

[dpdk-dev] [Bug 48] Unexpected performance regression since CVE-2018-1059 fix with vector path

2018-05-18 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=48 Bug ID: 48 Summary: Unexpected performance regression since CVE-2018-1059 fix with vector path Product: DPDK Version: 18.05 Hardware: All OS: All Statu

Re: [dpdk-dev] [PATCH] nfp: restore the unlink operation

2018-05-18 Thread Aaron Conole
Luca Boccassi writes: > On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote: >> For the stable versions of DPDK, the NFP driver's NSP user space >> driver was modified to account for non-root usage.  When that >> happened, commit 515933ad8385 ("nfp: allow for non-root user") >> inadvertently re

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Matan Azrad
Hi all While this patch also applied I don't understand it. Is it mandatory for each PMD to free all its resources in dev_close()? Or it should be done by the rte_device remove function? If the resource cleanup should be done by the remove function I think it should be called for all the devices

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, May 18, 2018 8:37 PM > To: Dai, Wei ; Wu, Yanglong > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port > > Hi Daiwei: > > > -Original Message- > > From: Dai, Wei > > Sent: Friday, M

[dpdk-dev] [PATCH 1/7] net/bnxt: add fallthrough comments for cascading switch cases

2018-05-18 Thread Ajit Khaparde
The FALLTHROUGH comment for cascading switch cases was missing in a few places. This patch adds that. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c| 1 + drivers/net/bnxt/bnxt_ethdev.c | 3 +++ drivers/net/bnxt/bnxt_hwrm.c | 4 drivers/net/bnxt/bnxt_rxq.c| 1 + 4 fi

[dpdk-dev] [PATCH 3/7] net/bnxt: fix rss hash configuration

2018-05-18 Thread Ajit Khaparde
While configuring RSS, the FW needs to know the rss_hash_mode that needs to be initialized. Set hash mode to HWRM_VNIC_RSS_CFG_INPUT_HASH_MODE_FLAGS_DEFAULT to allow the FW to use the global mode already configured in the device. Fixes: bcd4bcc4426f ("net/bnxt: configure RSS") Signed-off-by: Ajit

[dpdk-dev] [PATCH 7/7] net/bnxt: fix Rx checksum flags

2018-05-18 Thread Ajit Khaparde
For frames where the hardware is not able to calculate checksum we are indicating such frames to be bad. And that is incorrect. Indicate PKT_RX_IP_CKSUM_UNKNOWN or PKT_RX_L4_CKSUM_UNKNOWN for such frames. Fixes: 7ec39d8c524b ("net/bnxt: update status of Rx IP/L4 CKSUM") Cc: sta...@dpdk.org Signed

[dpdk-dev] [PATCH 5/7] net/bnxt: fix VF resource allocation

2018-05-18 Thread Ajit Khaparde
If the resource requirement of a VF is more than what is allotted to it by the FW, a VF can request to reallocate some of the resources. This is possible only when the NIC is running the Resource Manager aware CHiMP FW. If necessary, calculate Tx and Rx ring count using the new RM API. Otherwise

[dpdk-dev] [PATCH 6/7] net/bnxt: fix xstats support for VF

2018-05-18 Thread Ajit Khaparde
Query of port stats is permitted for VF interfaces as well. Fix the code to allow VFs to query port stats. Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/bnxt/bnxt_hwrm.c | 3 --- drivers/net/bnxt/

[dpdk-dev] [PATCH 4/7] net/bnxt: fix to use 1st completion ring for forwarding and async events

2018-05-18 Thread Ajit Khaparde
In order to save completion resource, use the first completion ring from PF or VF as the default completion ring for async event & HWRM forward response handling. Add bnxt_hwrm_set_async_event_cr() to set async_event_cr for either PF or VF. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notifi

[dpdk-dev] [PATCH 2/7] net/bnxt: fix to initialize tx and rx burst for secondary processes

2018-05-18 Thread Ajit Khaparde
We were initializing Tx and Rx burst functions only for primary processes. Fixing it in this patch. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethde

[dpdk-dev] [PATCH 0/7] bnxt patchset

2018-05-18 Thread Ajit Khaparde
Patchset against dpdk-next. Contains fixes mostly. Please apply. Ajit Khaparde (7): net/bnxt: add fallthrough comments for cascading switch cases net/bnxt: fix to initialize tx and rx burst for secondary processes net/bnxt: fix rss hash configuration net/bnxt: fix to use 1st completion rin

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue

2018-05-18 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Friday, May 18, 2018 11:16 AM > To: dev; dev@dpdk.org > Cc: Zhang, Qi Z; Yang, Qiming; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix dcb configuration issue > > Hi, > >

[dpdk-dev] [PATCH] doc: add known issue of rte abort on FreeBSD

2018-05-18 Thread Reshma Pattan
Added known issue of rte_abort taking a long time on FreeBSD due to recent memory subsystem rework. Signed-off-by: Reshma Pattan --- doc/guides/rel_notes/release_18_05.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/re

Re: [dpdk-dev] [PATCH] cryptodev: extend feature flags description

2018-05-18 Thread Varghese, Vipin
Hi Pablo, thanks for the information update. I am ok with this patch, except for one cosmetic change shared inline to previous email otherwise ACK from segmentation. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, May 18, 2018 6:5

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 1:36 PM, Zhang, Qi Z wrote: > Hi Daiwei: > >> -Original Message- >> From: Dai, Wei >> Sent: Friday, May 18, 2018 7:07 PM >> To: Zhang, Qi Z ; Wu, Yanglong >> ; dev@dpdk.org >> Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port >> >>> -Original Mess

Re: [dpdk-dev] [PATCH] cryptodev: add missing feature string

2018-05-18 Thread Varghese, Vipin
Thanks Pablo for the fix. I am ok with this change Acked-by: Vipin Varghese > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, May 18, 2018 6:54 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org

Re: [dpdk-dev] [PATCH] cryptodev: fix supported size check

2018-05-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Friday, May 18, 2018 11:29 AM > To: De Lara Guarch, Pablo ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] cryptodev: fix supported size check > > > > > -Original M

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast

2018-05-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Friday, May 18, 2018 11:17 AM > To: De Lara Guarch, Pablo ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast > > > > > -Origina

[dpdk-dev] [PATCH] eal: fix directory permissions

2018-05-18 Thread Adrien Mazarguil
Executable bit must be set on directories for normal users to enter them. This patch addresses the inability to start DPDK applications as non-root due to errors such as: EAL: failed to bind /tmp/dpdk/rte/mp_socket: Permission denied Fixes: 56236363b481 ("eal: add directory for runtime data") C

Re: [dpdk-dev] [RFC v2] vhost: new rte_vhost API proposal

2018-05-18 Thread Maxime Coquelin
Hi Dariusz, On 05/18/2018 03:01 PM, Dariusz Stojaczyk wrote: rte_vhost is not vhost-user spec compliant. Some Vhost drivers have been already confirmed not to work with rte_vhost. virtio-user-scsi-pci in QEMU 2.12 doesn't fully initialize its management queues at SeaBIOS stage. This is perfectly

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

2018-05-18 Thread Thomas Monjalon
18/05/2018 15:32, Parthasarathy, JananeeX M: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 15/05/2018 18:14, Parthasarathy, JananeeX M: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > I think we need to keep a fast subset of tests. > > > > Please check in mk/rte.sdkte

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

2018-05-18 Thread Parthasarathy, JananeeX M
Hi Thomas, -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, May 15, 2018 9:47 PM To: Parthasarathy, JananeeX M Cc: dev@dpdk.org; Burakov, Anatoly ; Pattan, Reshma Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script 15/05/2018 18:14, P

[dpdk-dev] [PATCH] cryptodev: add missing feature string

2018-05-18 Thread Pablo de Lara
Security protocol flag string was not added when the actual flag was added. Fixes: eadb4fa1e1fe ("cryptodev: support security APIs") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cryptod

Re: [dpdk-dev] [PATCH] nfp: restore the unlink operation

2018-05-18 Thread Luca Boccassi
On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote: > For the stable versions of DPDK, the NFP driver's NSP user space > driver was modified to account for non-root usage.  When that > happened, commit 515933ad8385 ("nfp: allow for non-root user") > inadvertently removed the unlink() call. > >

[dpdk-dev] [PATCH] cryptodev: extend feature flags description

2018-05-18 Thread Pablo de Lara
Extend the description of cryptodev feature flags, adding extra information. Signed-off-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h i

Re: [dpdk-dev] [PATCH] net/i40e: fix link up failure issue

2018-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, May 18, 2018 10:57 AM > To: Guo, Jia ; Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix link up failure issue > > > -Original Message- > > From: Guo, Jia > > Sent: Friday, May 18, 2018 10:05 AM > > To:

Re: [dpdk-dev] [dpdk-stable] [PATCH] nfp: restore the unlink operation

2018-05-18 Thread Aaron Conole
Ferruh Yigit writes: > On 5/14/2018 3:46 PM, Aaron Conole wrote: >> For the stable versions of DPDK, the NFP driver's NSP user space >> driver was modified to account for non-root usage. When that >> happened, commit 515933ad8385 ("nfp: allow for non-root user") >> inadvertently removed the unli

Re: [dpdk-dev] [PATCH 0/2] eal/malloc: fix wrong heap initialization over multiple memsegs

2018-05-18 Thread Thomas Monjalon
Hi, What is the status of DPDK 18.05 on IBM POWER? This patch suggests there are some issues but there were no news for two weeks, after comments from Anatoly. Are we going to release a DPDK which does not work well on POWER? 03/05/2018 12:11, Gowrishankar: > When there are multiple memsegs (ea

[dpdk-dev] [PATCH] rte_ethdev.h: fix gcc8.1 sign conversion warining

2018-05-18 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h: In function 'rte_eth_rx_queue_count': /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:3882:10: warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'} may change the sign of the result [-Wsign-conversion] return (*dev->dev_

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Zhang, Qi Z
Hi Daiwei: > -Original Message- > From: Dai, Wei > Sent: Friday, May 18, 2018 7:07 PM > To: Zhang, Qi Z ; Wu, Yanglong > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday, Ma

Re: [dpdk-dev] [PATCH 1/2] examples/vhost_scsi: add virtio-1.0 feature bit support

2018-05-18 Thread Maxime Coquelin
On 05/18/2018 01:32 AM, Changpeng Liu wrote: Signed-off-by: Changpeng Liu --- examples/vhost_scsi/vhost_scsi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH] app/test-pmd: fix testpmd log of start command

2018-05-18 Thread Ferruh Yigit
On 5/15/2018 5:24 PM, Bernard Iremonger wrote: > In the testpmd log of the start command, show the RX and TX > descriptor values from dev_info instead of the default > values. > > Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") > > Reported-by: Ferruh Yigit > Signed-off-by: Berna

[dpdk-dev] [PATCH v2] i40e: fix corruption of VF stats via port representor

2018-05-18 Thread Remy Horton
The resetting of stats on a VF involves the setting of an offset that is subtracted from future calls, rather zeroing of counters. However doing a stats reset on the port representor was also adjusting the values forwarded to the VF, which had the effect of corrupting the VF's counters. The fix is

Re: [dpdk-dev] [PATCH] net/i40e: fix corruption of VF stats via port representor

2018-05-18 Thread Remy Horton
Missing fixline, so v2 coming.. On 18/05/2018 08:59, Remy Horton wrote: The resetting of stats on a VF involves the setting of an offset that is subtracted from future calls, rather zeroing of counters. However doing a stats reset on the port representor was also adjusting the values forwarded t

Re: [dpdk-dev] [PATCH v3 3/4] doc: announce deprecation for attach/detach crypto session

2018-05-18 Thread Akhil Goyal
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 85945ee72..cd75150a6 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -80,3 +80,7 @@ Deprecation Notices is not internal in the crypto device anymor

Re: [dpdk-dev] [PATCH v3 1/4] doc: announce ABI change for crypto sym info struct

2018-05-18 Thread Akhil Goyal
On 5/17/2018 2:30 PM, Pablo de Lara wrote: Since the API changes made in 17.08, the session mempool is not created anymore in each crypto device. Therefore, there is no need to have, in the cryptodev info structure, the maximum number of sessions supported per device and per queue pair. Signed-o

Re: [dpdk-dev] [PATCH v3 3/3] net/i40e: convert to SPDX license tags

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 12:25 PM, gavin...@linaro.org wrote: > From: Gavin Hu > > Signed-off-by: Gavin Hu > Acked-by: Hemant Agrawal For Intel part, Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v3 2/4] doc: announce ABI change for crypto info struct

2018-05-18 Thread Akhil Goyal
On 5/17/2018 2:30 PM, Pablo de Lara wrote: Cryptodev info structure currently contains a pointer to an rte_pci_device structure. This field depends on a specific bus type (PCI), which is not following a bus independent design. Following the same approach taken in ethdev, the field will be replace

Re: [dpdk-dev] [PATCH v3 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 12:25 PM, gavin...@linaro.org wrote: > From: Gavin Hu > > Signed-off-by: Gavin Hu > Acked-by: Hemant Agrawal For Intel part, Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v3 3/3] net/i40e: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c inde

[dpdk-dev] [PATCH v3 2/3] expamples/ip_pipeline: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- examples/ip_pipeline/hash_func_arm64.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/examples/ip_pipeline/hash_func_arm64.h b/examples/ip_pipeline/hash_func_arm64.h ind

[dpdk-dev] [PATCH v3 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- examples/l3fwd/l3fwd_common.h | 35 +++ examples/l3fwd/l3fwd_em_hlm.h | 35 +++ examples/l3fwd/l3fwd_em_hlm_neon.h | 35 +++-

Re: [dpdk-dev] [PATCH] mbuf: properly cast shared data

2018-05-18 Thread Thomas Monjalon
16/05/2018 13:10, David Marchand: > Including rte_mbuf.h in C++ triggers the following warning as C++ does not > allow implicit casting of a void *. > > In file included from test.cpp:1:0: > x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function > ‘rte_mbuf_ext_shared_info* rte_pktmbuf_ext_shi

Re: [dpdk-dev] [PATCH-18.08 02/15] net/avp: add to meson build

2018-05-18 Thread Legacy, Allain
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, May 17, 2018 4:15 PM > To: dev@dpdk.org > Cc: RICHARDSON, BRUCE; Legacy, Allain; Peters, Matt > Subject: [PATCH-18.08 02/15] net/avp: add to meson build > > Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev-ops API to return int

2018-05-18 Thread Andy Green
On 05/18/2018 06:59 PM, Shreyansh Jain wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green Sent: Thursday, May 17, 2018 7:19 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev- ops API to return int Signed-of

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, May 18, 2018 3:46 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Dai, Wei > Subject: RE: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port > > > -Original Message- > > From: Wu, Yanglong > > Sent: Friday, May 18, 20

[dpdk-dev] [PATCH v2 3/3] net/i40e: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c inde

[dpdk-dev] [PATCH v2 2/3] expamples/ip_pipeline: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- examples/ip_pipeline/hash_func_arm64.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/examples/ip_pipeline/hash_func_arm64.h b/examples/ip_pipeline/hash_func_arm64.h ind

[dpdk-dev] [PATCH v2 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- examples/l3fwd/l3fwd_common.h | 35 +++ examples/l3fwd/l3fwd_em_hlm.h | 35 +++ examples/l3fwd/l3fwd_em_hlm_neon.h | 35 +++-

Re: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev-ops API to return int

2018-05-18 Thread Shreyansh Jain
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Thursday, May 17, 2018 7:19 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev- > ops API to return int > > Signed-off-by: Andy Green > --- > drivers

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:18 AM, Iremonger, Bernard wrote: > Hi Ferruh, Zhiyong, > > > >>> Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs >>> >>> For vdev, just calling rte_eth_dev_close() isn't enough to free all >>> the resources allocated during device probe, e.g. for virtio-use

Re: [dpdk-dev] [PATCH 3/3] net/i40e: convert to SPDX license tags

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:26 AM, gavin...@linaro.org wrote: > From: Gavin Hu > > Signed-off-by: Gavin Hu > Acked-by: Hemant Agrawal > --- > drivers/net/i40e/i40e_rxtx_vec_neon.c | 35 > +++ > 1 file changed, 3 insertions(+), 32 deletions(-) > > diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:26 AM, gavin...@linaro.org wrote: > @@ -1,35 +1,6 @@ > -/*- > - * BSD LICENSE > - * > - * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > - * Copyright(c) 2017, Linaro Limited > - * All rights reserved. > - * > - * Redistribution and use in source and bina

Re: [dpdk-dev] [PATCH] cryptodev: fix supported size check

2018-05-18 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, May 15, 2018 8:13 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] cryptodev: fix supported size check > > Cryp

[dpdk-dev] [PATCH 2/3] expamples/ip_pipeline: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- examples/ip_pipeline/hash_func_arm64.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/examples/ip_pipeline/hash_func_arm64.h b/examples/ip_pipeline/hash_func_arm64.h ind

Re: [dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent

2018-05-18 Thread Thomas Monjalon
18/05/2018 12:14, Zijie Pan: > Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e. > It supports the following i40e debug lldp commands: > - start/stop of the LLDP agent. > - get local/remote of the LLDP MIB (Management Information Base). > > Signed-off-by: Laurent Hard

[dpdk-dev] [PATCH 3/3] net/i40e: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c inde

[dpdk-dev] [PATCH 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread gavin . hu
From: Gavin Hu Signed-off-by: Gavin Hu Acked-by: Hemant Agrawal --- examples/l3fwd/l3fwd_common.h | 35 +++ examples/l3fwd/l3fwd_em_hlm.h | 35 +++ examples/l3fwd/l3fwd_em_hlm_neon.h | 35 +++-

[dpdk-dev] [PATCH 0/3] *** convert to SPDX-3 clause license tag ***

2018-05-18 Thread gavin . hu
From: Gavin Hu Gavin Hu (3): examples/l3fwd: convert to SPDX license tags expamples/ip_pipeline: convert to SPDX license tags net/i40e: convert to SPDX license tags drivers/net/i40e/i40e_rxtx_vec_neon.c | 35 +++-- examples/ip_pipeline/hash_func_arm64.h | 33 +

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix eth_dev_last_created_port storage type

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:22 AM, Ferruh Yigit wrote: > On 5/18/2018 11:41 AM, zhiyong.y...@intel.com wrote: >> eth_dev_last_created_port is used to store port id type and should >> be extended to 16bits corresponding to ethdev port id range. >> >> Cc: sta...@dpdk.org >> Cc: ferruh.yi...@intel.com >> >> Fixes

Re: [dpdk-dev] [PATCH] ethdev: fix eth_dev_last_created_port storage type

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:41 AM, zhiyong.y...@intel.com wrote: > eth_dev_last_created_port is used to store port id type and should > be extended to 16bits corresponding to ethdev port id range. > > Cc: sta...@dpdk.org > Cc: ferruh.yi...@intel.com > > Fixes: f8244c6399d9 ("ethdev: increase port id range")

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:18 AM, Iremonger, Bernard wrote: > Hi Ferruh, Zhiyong, > > > >>> Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs >>> >>> For vdev, just calling rte_eth_dev_close() isn't enough to free all >>> the resources allocated during device probe, e.g. for virtio-use

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Iremonger, Bernard
Hi Ferruh, Zhiyong, > > Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs > > > > For vdev, just calling rte_eth_dev_close() isn't enough to free all > > the resources allocated during device probe, e.g. for virtio-user, > > virtio_user_pmd_remove(), i.e. the remove() method

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast

2018-05-18 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, May 15, 2018 9:21 PM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast > > q

[dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent

2018-05-18 Thread Zijie Pan
Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e. It supports the following i40e debug lldp commands: - start/stop of the LLDP agent. - get local/remote of the LLDP MIB (Management Information Base). Signed-off-by: Laurent Hardy Signed-off-by: Zijie Pan --- drivers

Re: [dpdk-dev] [PATCH v2] doc: correct spell issues in i40e.rst

2018-05-18 Thread Ferruh Yigit
On 5/17/2018 2:58 PM, dev-boun...@dpdk.org wrote: > This patch corrects some spelling issues in i40e.rst and clarifies > which controllers and connections are part of the 700 Series. > > Signed-off-by: Qiming Yang > Acked-by: Marko Kovacevic Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 10:53 AM, Gavin Hu wrote: > > > On 18 May 2018 at 16:17, Ferruh Yigit > wrote: > > On 4/19/2018 9:52 AM, gavin...@linaro.org > wrote: > > From: Gavin Hu mailto:gavin...@linaro.org>> > > > > Signed-off-by:

Re: [dpdk-dev] [PATCH 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread Gavin Hu
On 18 May 2018 at 16:17, Ferruh Yigit wrote: > On 4/19/2018 9:52 AM, gavin...@linaro.org wrote: > > From: Gavin Hu > > > > Signed-off-by: Gavin Hu > > <...> > > > diff --git a/examples/l3fwd/l3fwd_common.h > b/examples/l3fwd/l3fwd_common.h > > index 7002a43..df3e461 100644 > > --- a/examples/l3

Re: [dpdk-dev] [PATCH 2/2] net/mlx4: refactor RSS conversion functions

2018-05-18 Thread Adrien Mazarguil
Hi Ophir, On Thu, May 17, 2018 at 05:46:45PM +, Ophir Munk wrote: > Hi Adrien, > I like the idea of having one conversion function from dpdk to verbs and vice > versa. > I have some comments inline regarding the implementation. > > > -Original Message- > > From: Adrien Mazarguil [mai

Re: [dpdk-dev] [dpdk-stable] [PATCH] nfp: restore the unlink operation

2018-05-18 Thread Ferruh Yigit
On 5/14/2018 3:46 PM, Aaron Conole wrote: > For the stable versions of DPDK, the NFP driver's NSP user space > driver was modified to account for non-root usage. When that > happened, commit 515933ad8385 ("nfp: allow for non-root user") > inadvertently removed the unlink() call. This patch is for

Re: [dpdk-dev] [PATCH] mk: using initial-exec model for thread local variable

2018-05-18 Thread Thomas Monjalon
28/04/2018 06:39, Yang, Zhiyong: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marvin Liu > Sent: Saturday, April 28, 2018 5:54 PM > > > > When building share library, thread-local storage model will be changed to > > global-dynamic. It will cost additional protect for read thread local

Re: [dpdk-dev] [PATCH v2] doc: correct spell issues in i40e.rst

2018-05-18 Thread Kovacevic, Marko
Checked the new fix it builds fine and content is ok too. Acked-by: Marko Kovacevic

[dpdk-dev] [RFC v2] vhost: new rte_vhost API proposal

2018-05-18 Thread Dariusz Stojaczyk
rte_vhost is not vhost-user spec compliant. Some Vhost drivers have been already confirmed not to work with rte_vhost. virtio-user-scsi-pci in QEMU 2.12 doesn't fully initialize its management queues at SeaBIOS stage. This is perfectly fine from the Vhost-user spec perspective, but doesn't meet rte

Re: [dpdk-dev] [PATCH] nfp: restore the unlink operation

2018-05-18 Thread Alejandro Lucero
Acked-by: Alejandro Lucero On Mon, May 14, 2018 at 4:09 PM, Eelco Chaudron wrote: > On 14/05/18 16:46, Aaron Conole wrote: > >> For the stable versions of DPDK, the NFP driver's NSP user space >> driver was modified to account for non-root usage. When that >> happened, commit 515933ad8385 ("nf

Re: [dpdk-dev] [PATCH v2] net/tap: fix device removal when no queues exist

2018-05-18 Thread Ophir Munk
Hi Keith, Please find comments inline > -Original Message- > From: Wiles, Keith [mailto:keith.wi...@intel.com] > Sent: Thursday, May 17, 2018 4:00 PM > To: Ophir Munk > Cc: dev@dpdk.org; Pascal Mazon ; Thomas > Monjalon ; Olga Shern ; > Shahaf Shuler ; sta...@dpdk.org > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v2] doc: correct spell issues in i40e.rst

2018-05-18 Thread Yang, Qiming
Hi, John Could you help to review it? Qiming > -Original Message- > From: Yang, Qiming > Sent: Thursday, May 17, 2018 9:58 PM > To: dev@dpdk.org > Cc: Zhang, Helin ; Yang, Qiming > > Subject: [PATCH v2] doc: correct spell issues in i40e.rst > > This patch corrects some spelling issues in

[dpdk-dev] [PATCH v3] net/tap: fix device removal when no queues exist

2018-05-18 Thread Ophir Munk
TAP device is created following its first queue creation. Multiple queues can be added or removed over time. In Linux terminology those are file descriptors which are opened or closed over time. As long as the number of opened file descriptors is positive - TAP device will appear as a Linux device.

[dpdk-dev] Question: can dpdk acl lookup support specific the starting rule index or priority?

2018-05-18 Thread Lilijun (Jerry, Cloud Networking)
Hi all, Currently dpdk acl search can be done by calling rte_acl_classify(). In some usecases, we need lookup the acl table again staring from a specific rule index. Are there anyone do some research or has some opinions about this question? Thanks. B.R. Jerry

Re: [dpdk-dev] [PATCH 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-18 Thread Ferruh Yigit
On 4/19/2018 9:52 AM, gavin...@linaro.org wrote: > From: Gavin Hu > > Signed-off-by: Gavin Hu <...> > diff --git a/examples/l3fwd/l3fwd_common.h b/examples/l3fwd/l3fwd_common.h > index 7002a43..df3e461 100644 > --- a/examples/l3fwd/l3fwd_common.h > +++ b/examples/l3fwd/l3fwd_common.h > @@ -1,3

Re: [dpdk-dev] [PATCH-18.08 08/15] net/ifc: rename to ifcvf

2018-05-18 Thread Bruce Richardson
On Fri, May 18, 2018 at 02:52:36AM +0100, Wang, Xiao W wrote: > Hi Bruce, > > > -Original Message- > > From: Richardson, Bruce > > Sent: Friday, May 18, 2018 4:15 AM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; Wang, Xiao W > > > > Subject: [PATCH-18.08 08/15] net/ifc: rename to ifcvf

[dpdk-dev] [PATCH] net/i40e: fix corruption of VF stats via port representor

2018-05-18 Thread Remy Horton
The resetting of stats on a VF involves the setting of an offset that is subtracted from future calls, rather zeroing of counters. However doing a stats reset on the port representor was also adjusting the values forwarded to the VF, which had the effect of corrupting the VF's counters. The fix is

Re: [dpdk-dev] [RFC] vhost: new rte_vhost API proposal

2018-05-18 Thread Stojaczyk, DariuszX
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Friday, May 11, 2018 6:06 PM > On Fri, May 11, 2018 at 05:55:45AM +, Stojaczyk, DariuszX wrote: > > > -Original Message- > > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > > Sent: Frida

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Friday, May 18, 2018 3:24 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Wu, > Yanglong > Subject: [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port > > rxq->offload should synchronize with dev_conf > > Fixes: 860a94d3c

Re: [dpdk-dev] Bug in OVS2.8.0+DPDK17.05+Intel_82599_IXGBE sriov?

2018-05-18 Thread Sam
I have test dpdk testpmd, it is OK in the same enviroment. Why ovs-dpdk could not work? I think that must be some bug in ovs? 2018-05-18 11:42 GMT+08:00 Sam : > Hi all, > > I'm using OVS2.8.0+DPDK17.05+Intel_82599_IXGBE for test, the vf driver is > ixgbevf-4.0.3. > > I use sriov follow like this

[dpdk-dev] [PATCH v2] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-18 Thread Yanglong Wu
rxq->offload should synchronize with dev_conf Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue offloading in VF") Signed-off-by: Yanglong Wu --- v2: rework as comments asked --- drivers/net/ixgbe/ixgbe_ethdev.c | 16 1 file changed, 16 insertions(+) diff --git a/dr

  1   2   >