Re: [dpdk-dev] [PATCH] ethdev: fixed device info get issue

From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Tuesday, May 15, 2018 4:42 PM To: Yang, Qiming ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: fixed device info get issue On 05/15/2018 07:10 PM, Qiming Yang wrote: This patch fixed error function call or

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fixed device info get issue

> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, May 15, 2018 7:31 PM > To: Andrew Rybchenko ; Yang, Qiming > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: fixed device info get > issue > > On 5/15/2018 9:41 AM, Andrew Rybchenko wr

[dpdk-dev] [PATCH] doc: correct spell issues in i40e.rst

This patch corrects some spelling issues in i40e.rst and clarifies which controllers and connections are part of the 700 Series. Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 69 +--- 1 file changed, 36 insertions(+), 33 deletions(-) diff

Re: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang compiling issue

-Original Message- > Date: Wed, 16 May 2018 14:08:02 +0800 > From: Gavin Hu > To: dev@dpdk.org > CC: gavin hu > Subject: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang > compiling issue > X-Mailer: git-send-email 2.17.0 > > From: gavin hu > > The patch fixes the compile iss

[dpdk-dev] [PATCH 1/2] app/crypto-perf: use strcpy for allocated string

inlined from ‘cperf_test_vector_get_from_file’ at ../app/test-crypto-perf/cperf_test_vector_parsing.c:578:11: ../app/test-crypto-perf/cperf_test_vector_parsing.c:510:3: error: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-trunc

[dpdk-dev] [PATCH 2/2] app/crypto-perf: fix memcpy source range

Since arm64 was using plain memcpy for rte_memcpy, gcc 8.1, could detect size was more than source address range. /export/dpdk.org/test/test/test_cryptodev.c: In function 'test_multi_session_random_usage': /export/dpdk.org/build/include/rte_memcpy_64.h:364:29: error: 'memcpy' forming offset [113,

[dpdk-dev] [PATCH] net/i40e: fix link up failure issue

If don't enable auto negotiation when set PHY to be link down, will cause PHY can’t be Link up again in some case, this patch aim to fix this issue. When rebind to kernel driver, it can use ethtool to set auto negotiation and use ifconfig tool to link up the device. And for the case of PHY config

Re: [dpdk-dev] [PATCH v2] vhost: improve dirty pages logging performance

On Tue, May 15, 2018 at 07:30:21PM +0200, Maxime Coquelin wrote: > This patch caches all dirty pages logging until the used ring index > is updated. These dirty pages won't be accessed by the guest as > long as the host doesn't give them back to it by updating the > index. > > The goal of this opt

Re: [dpdk-dev] [PATCH] vhost/crypto: fix descriptor move

Hi Fan, On 05/09/2018 04:08 PM, Fan Zhang wrote: This patch fixes the redundant descriptor move in the copy mode of vhost crypto. Originally the redundant descriptor move will cause the message parsing error. As it is a fix, we need to specify which commit it fixes. In this case it is: Fixes:

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

On Tue, May 15, 2018 at 03:50:54PM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > I just see I missed to reply to your comment on my commit message: > > On 05/03/2018 01:56 PM, Tiwei Bie wrote: > > On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: > > > This patch caches all dirty p

[dpdk-dev] [PATCH v3 2/3] eventdev: fix the clang compiling issue

From: gavin hu This patch fix the clang compiling issue reported on the ARM64 builing host. ev is a pointer in size of 64bit, but the herein it should be the size of its content. ~/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49: error: 'rte_memcpy' call operates on objects of type 's

[dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang compiling issue

From: gavin hu The patch fixes the compile issue with clang on ARM64. Newly introduced #pragma pack(1) in the header file caused comipiling issues for the files who included it. In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ ifpga_fme_dperf.c:5: In file included from ~/dpdk/drivers

[dpdk-dev] [PATCH v3 1/3] net/mlx5: fix the clang compiling issue

From: gavin hu This patch adds a pair of "()" to embrace the argument input to the function-like macro invocation. drivers/net/mlx5/mlx5_rxtx_vec.c:37: drivers/net/mlx5/mlx5_rxtx_vec_neon.h:170:24: error: too many arguments provided to function-like macro invocation (uint16x8_t) { 0, 0,

Re: [dpdk-dev] [PATCH] doc/guides/rel_notes: Add known issue for IOMMU attributes read

Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, May 15, 2018 1:10 > To: Xu, Rosen ; dev@dpdk.org > Cc: gaetan.ri...@6wind.com; Mcnamara, John ; > Pei, Yulong ; sta...@dpdk.org > Subject: Re: [PATCH] doc/guides/rel_notes: Add known issue for IOMMU > attributes rea

[dpdk-dev] [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide

Update cryptodev programmer guide with description of asymmetric crypto framework in lib cryptodev. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta --- doc/guides/prog_guide/cryptodev_lib.rst | 338 +++- 1 file changed, 329 inserti

[dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

Add asymmetric crypto operation support in openssl PMD. Current list of supported asym xforms: * RSA * DSA * Deffie-hellman * Modular Operations changes from v2: - Update the pmd capability as per new capability structure changes from v1: - resolve new line error in dod/guides/cryptodevs/openssl.

[dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto

Add unit test case to test openssl PMD asym crypto operations. Test case invoke asymmetric operation on DPDK Openssl PMD and cross-verify results via Openssl SW library. Tests have been verified with openssl 1.0.2m release. Tested for: * RSA Encrypt, Decrypt, Sign and Verify using pre-defined t

[dpdk-dev] [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

Extend cryptodev with asymmetric capability APIs and definitions. changes from v2: - remove redundant xform_type from asym capability struct - rename rte_cryptodev_get_asym_xform_enum to be more consistent with other API names Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by

[dpdk-dev] [PATCH v3 2/6] lib/cryptodev: add asym op support in cryptodev

Extend DPDK librte_cryptodev to: - define asym op type in rte_crypto_op_type and associated op pool create/alloc APIs - define asym session and associated session APIs If PMD shows in its feature flag that it supports both sym and asym then it must support those on all its qps. Changes from v2:

[dpdk-dev] [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev

Add rte_crypto_asym.h with supported xfrms and associated op structures and APIs API currently supports: - RSA Encrypt, Decrypt, Sign and Verify - Modular Exponentiation and Inversion - DSA Sign and Verify - Deffie-hellman private key exchange - Deffie-hellman public key exchange - Deffie-hellman

[dpdk-dev] [PATCH v3 0/6] crypto: add asym crypto support

This patch series add support for asymmetric crypto in DPDK librte_cryptodev framework along with unit test, PMD and documentation updates This patch series is divided in to following categories: 1. library patches with asymmetric API, xform and capability definitions 2. Unit test case addition

Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix feature setting with vhost-net backend

On 05/11/2018 09:26 AM, Jiayu Hu wrote: When the backend is vhost-net, virtio-user must work in client mode and needs to request features from the backend in virtio_user_dev_init(). But currently, virtio-user is assigned to default features in this case. This patch is to fix this inappropriate

Re: [dpdk-dev] [PATCH v2 4/4] ifpgai_rawdev: fix the clang compiling issue

-Original Message- > Date: Tue, 15 May 2018 05:23:47 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 4/4] ifpgai_rawdev: fix the clang compiling > issue > X-Mailer: git-send-email 2.1.4 > > Newly introduced #pragma pack(1) in the header file caused comipiling >

Re: [dpdk-dev] dev Digest, Vol 195, Issue 45

-Original Message- > Date: Wed, 16 May 2018 02:08:48 + > From: Gavin Hu > To: "dev@dpdk.org" , "Jacob, Jerin" > > Subject: Re: [dpdk-dev] dev Digest, Vol 195, Issue 45 > > > > > For ARM64 platform, libdpdk.a includes the > > librte_pmd_octeontx_ssovf.a, which requires the libatomic

Re: [dpdk-dev] dev Digest, Vol 195, Issue 45

-Original Message- From: dev On Behalf Of dev-requ...@dpdk.org Sent: Tuesday, May 15, 2018 5:12 PM To: dev@dpdk.org Subject: dev Digest, Vol 195, Issue 45 Send dev mailing list submissions to dev@dpdk.org To subscribe or unsubscribe via the World Wide Web, visit https://dpdk.org/ml/listi

Re: [dpdk-dev] [PATCH] maintainers: add maintainer for testpmd

Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, May 10, 2018 5:29 PM > To: dev@dpdk.org; tho...@monjalon.net; Mcnamara, John > > Cc: Iremonger, Bernard > Subject: [dpdk-dev] [PATCH] maintainers: add maintainer for testp

Re: [dpdk-dev] [PATCH v2] net/tap: perform proto field update for tun only

Hi, I am adding my review although this patch has already been acked. Please find some comments inline. Otherwise it looks OK. Regards, Ophir > -Original Message- > From: Vipin Varghese [mailto:vipin.vargh...@intel.com] > Sent: Tuesday, May 15, 2018 5:50 PM > To: dev@dpdk.org; keith.wi...

[dpdk-dev] [PATCH v8 3/5] net/netvsc: add hyper-v netvsc network device

The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). This version supports the latest NetVSP 6.1

[dpdk-dev] [PATCH v8 5/5] bus/vmbus and net/netvsc: add meson build support

From: Stephen Hemminger Update meson build files for new netvsc and vmbus drivers. Signed-off-by: Stephen Hemminger --- config/meson.build | 7 +++ drivers/bus/meson.build| 2 +- drivers/bus/vmbus/meson.build | 16 drivers/net/meson.build| 2

[dpdk-dev] [PATCH v8 2/5] bus/vmbus: add hyper-v virtual bus support

This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but the code

[dpdk-dev] [PATCH v8 4/5] net/netvsc: add documentation

From: Stephen Hemminger Matching documentation for new netvsc device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst | 103 + doc/guides/rel

[dpdk-dev] [PATCH v8 1/5] eal: add rte_uuid support

Since uuid functions may not be available everywhere, implement uuid functions in DPDK. These are based off the BSD licensed libuuid in util-link. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_

[dpdk-dev] [PATCH v8 0/5] Hyper-V netvsc PMD and VMBus support

This is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Onl

Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue

Hi Yongseok, We will make the commit message more verbose. As for the error: This is a clang compiler issue: drivers/net/mlx5/mlx5_rxtx_vec.c:37: /home/sirdas/code/commitc/dpdk-stable-18.02.1/drivers/net/mlx5/mlx5_rxtx_vec_neon.h:170:24: error: too many arguments provided to function-like macro i

[dpdk-dev] [dpdk-announce] release candidate 18.05-rc4

A new DPDK release candidate is ready for testing: https://dpdk.org/browse/dpdk/tag/?id=v18.05-rc4 This small release candidate is published one day after -rc3. The reason is fixing two outstanding bugs introduced in recent commits: - PCI probing broken for device string >8B

Re: [dpdk-dev] [PATCH] net/qede: fix default Tx offload config

15/05/2018 21:43, Rasesh Mody: > Correct the default Tx offload config > > Fixes: 946dfd18a4ec ("net/qede: convert to new Rx/Tx offloads API") > > Signed-off-by: Rasesh Mody Applied, thanks

Re: [dpdk-dev] [PATCH v3 0/4] GCC8 fixes for MLX4/5/BNX2X PMD

> Andy Green (4): > net/bnx2x: do not cast function pointers as a policy > net/bnx2x: correct unmeetable comparison > net/mlx5: solve var may be used uninitialized > net/bnx2x: solve overruns Series applied, thanks

[dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded cast

qp->temp_digest is already an array of uint8_t, so no need to cast to uint8_t*. Fixes: baf1e63bfd65 ("crypto/aesni_gcm: do not append digest") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, May 15, 2018 7:46 AM > > 15/05/2018 00:16, Mody, Rasesh: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > > > Sent: Sunday, May 13, 2018 10:05 PM > > > > > > /home/agreen/projects/dpdk/drivers/net/bnx2x/el

Re: [dpdk-dev] [PATCH v3 1/4] net/bnx2x: do not cast function pointers as a policy

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Sunday, May 13, 2018 10:04 PM > > This is stopping the compiler telling you when you have done something > stupid... that is something none of us can afford... > > Now gcc 8.x can tell you did something stupid despite tryin

Re: [dpdk-dev] [PATCH v3 4/4] net/bnx2x: solve overruns

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Sunday, May 13, 2018 10:05 PM > > Signed-off-by: Andy Green > Fixes: 540a211084a7 ("bnx2x: driver core") > Cc: sta...@dpdk.org > Acked-by: Pablo de Lara > --- Acked-by: Rasesh Mody

Re: [dpdk-dev] [PATCH 1/5] net/qede: convert to new Rx/Tx offloads API

> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, May 14, 2018 5:53 AM > > On 5/11/2018 10:16 AM, Andrew Rybchenko wrote: > > On 03/28/2018 03:15 AM, Rasesh Mody wrote: > >> From: Harish Patil > >> > >> Ethdev RX/TX offloads API has changed since: > >> commit ce17eddefc20 ("eth

[dpdk-dev] [PATCH] net/qede: fix default Tx offload config

Correct the default Tx offload config Fixes: 946dfd18a4ec ("net/qede: convert to new Rx/Tx offloads API") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_e

[dpdk-dev] [PATCH v2] crypto/aesni_mb: fix capabilities

Missing AES-CMAC supported parameters in PMD capabilities. Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC") Signed-off-by: Pablo de Lara --- Changes in v2: - Fixed structure type from aead to auth .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c| 23 +-- 1 file changed,

[dpdk-dev] [PATCH] cryptodev: fix supported size check

Crypto capability structure contains supported sizes for key, IV, digest, etc. on different algorithms. These sizes can be expressed as a single value or a range of values. The check was broken when a size was checked against a range with multiple values. Also, for more clarity, the param_range_ch

Re: [dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

On Tue, 15 May 2018 17:56:12 +0100 Ferruh Yigit wrote: > When EFI secure boot is enabled, it is possible to lock down kernel and > prevent accessing device BARs and this makes igb_uio unusable. This distro specific (and not upstream) stuff in igb_uio is getting to be a significantly ugly. Can th

Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue

> On May 15, 2018, at 10:52 AM, Sirshak Das wrote: > > Hi Yongseok, > > We will make the commit message more verbose. > As for the error: This is a clang compiler issue: > drivers/net/mlx5/mlx5_rxtx_vec.c:37: > /home/sirdas/code/commitc/dpdk-stable-18.02.1/drivers/net/mlx5/mlx5_rxtx_vec_neon.h:

Re: [dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

On Tue, 2018-05-15 at 17:56 +0100, Ferruh Yigit wrote: > When EFI secure boot is enabled, it is possible to lock down kernel > and > prevent accessing device BARs and this makes igb_uio unusable. > > Lock down patches are not part of the vanilla kernel but they are > applied and used by some distr

[dpdk-dev] [PATCH v2] vhost: improve dirty pages logging performance

This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be accessed by the guest as long as the host doesn't give them back to it by updating the index. The goal of this optimization is to fix a performance regression introduced when the vhost librar

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: solve var may be used uninitialized

> On May 13, 2018, at 10:04 PM, Andy Green wrote: > > Signed-off-by: Andy Green > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") > Acked-by: Pablo de Lara > --- Acked-by: Yongseok Koh Thanks > drivers/net/mlx5/mlx5.c |2 +- > 1 file changed, 1 insertion(+), 1

Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue

> On May 15, 2018, at 2:23 AM, Gavin Hu wrote: The title should start from 'net/mlx5: ...' and please be more specific why that pair of parentheses is needed. Add more commit messages and it'd be better to add the error messages like you do in the other commit. To me, it still looks unnecessary

[dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

When EFI secure boot is enabled, it is possible to lock down kernel and prevent accessing device BARs and this makes igb_uio unusable. Lock down patches are not part of the vanilla kernel but they are applied and used by some distros already [1]. It is not possible to fix this issue, but intentio

[dpdk-dev] [PATCH] app/test-pmd: fix testpmd log of start command

In the testpmd log of the start command, show the RX and TX descriptor values from dev_info instead of the default values. Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") Reported-by: Ferruh Yigit Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 4 ++-- 1 file chan

[dpdk-dev] [PATCH] maintainers: fix responsibility of flow API bits

The following commits lack MAINTAINERS entries for this mess. Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") Fixes: 19c90af6285c ("app/testpmd: add flow command") Cc: sta...@dpdk.org Signed-off-by: Adrien Mazarguil Cc: Bernard Iremonger --- MAINTAINERS | 2 ++ 1 file changed, 2 insert

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

15/05/2018 18:14, Parthasarathy, JananeeX M: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/05/2018 12:36, Jananee Parthasarathy: > > > 1. Sanity Script is enhanced with additional test cases being added to > > > autotest_data.py > > > > How long they are? > > How did you choose to g

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

Hi Thomas, -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Monday, May 14, 2018 3:42 AM To: Parthasarathy, JananeeX M Cc: dev@dpdk.org; Burakov, Anatoly ; Pattan, Reshma Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script Hi, 10/05/2018 12:3

Re: [dpdk-dev] [PATCH v3 1/3] app/test: add new test cases to sanity script

On 15-May-18 4:58 PM, Jananee Parthasarathy wrote: Sanity Script is enhanced with additional test cases being added to autotest_data.py Signed-off-by: Jananee Parthasarathy --- Patchset-wide reviews/acks should be part of the commit message. Just out of curiousity - where did the name "sanit

[dpdk-dev] [PATCH v3 2/3] app/test: update result for skipped test cases

Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in sanity script execution. Signed-off-by: Jananee Parthasarathy --- test/test/autotest_test_funcs.py | 6 -- 1 file changed, 4 insertions(+),

[dpdk-dev] [PATCH v3 3/3] app/test: enhance freebsd support in sanity script

Update test command line with no additional arguments, as FreeBSD doesn't support socket-mem, file-prefix options Signed-off-by: Jananee Parthasarathy --- test/test/autotest_runner.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/test/autotest_runner.py b/test/t

[dpdk-dev] [PATCH v3 1/3] app/test: add new test cases to sanity script

Sanity Script is enhanced with additional test cases being added to autotest_data.py Signed-off-by: Jananee Parthasarathy --- test/test/autotest_data.py | 471 - 1 file changed, 462 insertions(+), 9 deletions(-) mode change 100644 => 100755 test/test/

[dpdk-dev] [PATCH v3 0/3] enhance sanity scripts

1/3: new test cases are added to sanity script 2/3: skipped test case result is updated appropriately 3/3: test cmdline is updated to support freebsd Signed-off-by: Jananee Parthasarathy Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- v3: created separate patches for all sanity sc

[dpdk-dev] [PATCH v2] eal/service: improve error checking of coremasks

This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example

[dpdk-dev] [PATCH 2/2] net/mlx4: refactor RSS conversion functions

Since commit 97b2217ae5bc ("net/mlx4: advertise supported RSS hash functions"), this PMD includes two similar-looking functions that convert RSS hash fields between Verbs and DPDK formats. This patch refactors them as a single two-way function and gets rid of redundant helper macros. Note the los

[dpdk-dev] [PATCH 1/2] net/mlx4: fix inadequate default in RSS converter

Below commit documents 0 as a value standing for a default set of RSS hash types, however the mlx4 PMD doesn't interpret it correctly and still uses its own internal special value for that (-1). Also, its function prototype was not updated. Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration

Re: [dpdk-dev] [PATCH] eal/service: improve error checking of coremasks

15/05/2018 16:52, Harry van Haaren: > + if (eal_service_cores_parsed()) > + RTE_LOG(ERR, EAL, > + "Warning: Service cores parsed before dataplane cores. > Ensure -c is before -s or -S.\n"); > + [...] > + if (core_parsed && taken_lcore_count != count) { > +

[dpdk-dev] [dpdk-announce] SPDK Summit Live streamed!

Hi All, We are happy to announce we will be live streaming the summit today and tomorrow. Please tune into to the link below to watch the sessions as they are delivered. Here is the agenda for the event. www.youtube.com/watch?v=g7J2i_jxBJI Thanks An

Re: [dpdk-dev] [PATCH] bus/pci: fix error in parsing vfio driver

Give up this patch as there is already a patch in http://dpdk.org/dev/patchwork/patch/40030/ bus/pci: correct the earlier strlcpy conversion > -Original Message- > From: Dai, Wei > Sent: Tuesday, May 15, 2018 10:41 PM > To: Yigit, Ferruh ; Burakov, Anatoly > > Cc: dev@dpdk.org; Dai, Wei

[dpdk-dev] [PATCH] bus/pci: fix error in parsing vfio driver

In pci_get_kernel_driver_by_path(), the available memory size of dri_name should be strlen(name + 1) + 1, not the size of the pointer (8 bytes), so "vfio-pci" is truncated to "vfio-pc" ended with number 0. This patch fixes it. Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy") Cc: sta...@

[dpdk-dev] [PATCH] eal/service: improve error checking of coremasks

This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

15/05/2018 00:16, Mody, Rasesh: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > > Sent: Sunday, May 13, 2018 10:05 PM > > > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: > > In function ‘elink_check_kr2_wa’: > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:1

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

15/05/2018 13:28, Olivier Matz: > On Tue, May 15, 2018 at 08:58:06AM +0100, Burakov, Anatoly wrote: > > On 14-May-18 7:48 PM, Thomas Monjalon wrote: > > > 14/05/2018 18:06, Anatoly Burakov: > > > > Currently, populate_virt will check if mempool is already populated. > > > > This will cause inabilit

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

Hey Kevin, What if I have 10 ports and want all 9 ports to forward packets to port 0, this cannot done in paired. But with this topo the user can overwrite the topo. E.g: - Set custom-topo 1 0 Will make those paired and those two as active only. - set custom-topo 2 0 Will make those two as paire

Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

15/05/2018 14:16, Burakov, Anatoly: > On 15-May-18 12:36 PM, Andrew Rybchenko wrote: > > On 05/15/2018 01:44 PM, Anatoly Burakov wrote: > >> The intention of the original code was to create runtime data > >> directory as early as possible, however it was moved too early, > >> before the arguments w

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

Hi Tiwei, I just see I missed to reply to your comment on my commit message: On 05/03/2018 01:56 PM, Tiwei Bie wrote: On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be acce

Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Tuesday, May 15, 2018 12:42 PM > To: Gavin Hu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling > issue > > -Original Message- > > Date:

[dpdk-dev] [PATCH] net/mlx5: fix default RSS level

Using inner RSS by default for GRE leads to memory corruption as the extra flow items added for the inner RSS are not counted in the flow attributes buffer size. Fixing by enforcing the default RSS level to be outer. This much simplify the flow engine and more robust. Future optimization for out o

Re: [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion

15/05/2018 12:51, Andrew Rybchenko: > On 05/15/2018 10:31 AM, Andy Green wrote: > > Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy") > > Signed-off-by: Andy Green > > Reviewed-by: Andrew Rybchenko > > Suggest to reword it as: > > bus/pci: fix invalid size of driver name buffer > >

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

On 05/09/2018 01:34 PM, Wisam Jaddo wrote: > Set custom topology for forwading packets by making the ^ > given two ports as pair, in custom topology the active > ports will be the defiend in custum-topo only. ^^^^^ typos above and si

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

On 05/14/2018 07:06 PM, Anatoly Burakov wrote: Currently, populate_virt will check if mempool is already populated. This will cause inability to reserve multi-chunk mempools if contiguous memory is not a hard requirement, because if allocating all-contiguous memory fails, mempool will retry with

Re: [dpdk-dev] [PATCH] librte_ip_frag: mbuf count, expiration

Hi Alex, On 14-May-18 3:23 PM, Alex Kiselev wrote: Hi. This patch adds two features to the librte_ip_frag library: The commit message will be saved in git history for all eternity. I don't think it should start with "Hi", it's not an email :) More to the point, generally, one patch == one

Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

HI Keith, Thanks for the input, please find my answer inline to email therad > > + /* TODO: request info from primary to set up Rx and Tx */ > > What is the rule (if we have one) about having TODO, FIXME, … like comments in > the code? Maybe remove the todo and create a enhancement r

Re: [dpdk-dev] [PATCH] net/tap: update tap index to unsgined

> On May 12, 2018, at 1:30 AM, Vipin Varghese wrote: > > Updating the logic to reflect unsigned integer as index for TAP PMD. > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/tap/rt

Re: [dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue

> -Original Message- > From: Xing, Beilei > Sent: Wednesday, May 16, 2018 12:19 AM > To: Wu, Jingjing ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix fail to disable FDIR Tx queue > > If flow directory is enabled, FDIR Tx queue can't be disabled when exi

Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

> On May 12, 2018, at 1:37 AM, Vipin Varghese wrote: > > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > > Enables TUN PMD sharing by attaching the port from the shared data. > > Cc: zhihong.w...@intel.com > Cc: ferruh.yi...@intel.com > > Signed-off-by: Vipin Varg

Re: [dpdk-dev] [PATCH v2] net/tap: perform proto field update for tun only

> On May 15, 2018, at 9:49 AM, Varghese, Vipin wrote: > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > type field will ensure the TAP PMD will always have protocol field > as 0. > > Signed-off-by: Vipin Varghese > Suggested-by: Ferruh Yigit > --- > > Changes in V2:

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation without tunnel RSS support

Monday, May 14, 2018 9:00 AM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation without tunnel > RSS support > > Sunday, May 13, 2018 4:28 PM, Xueming(Steven) Li: > > Thanks for fixing this, one minor issue below. > > > > > -Original Message- > > > From: Shahaf Shu

Re: [dpdk-dev] [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

Tuesday, May 15, 2018 3:04 PM, Nélio Laranjeiro: > Subject: Re: [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP > > On Tue, May 15, 2018 at 11:07:14AM +, Matan Azrad wrote: > > Add support for MPLS over GRE and MPLS over UDP tunnel types as > > described in the next RFCs: > > 1. > > >

Re: [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit

Thanks Nikhil, Have made changes and send a v2 for the same. > -Original Message- > From: Rao, Nikhil > Sent: Tuesday, May 15, 2018 3:54 PM > To: Varghese, Vipin ; dev@dpdk.org; Jain, Deepak K > > Cc: Rao, Nikhil > Subject: Re: [PATCH] test/eventdev: update the port id to 16 bit > > On

[dpdk-dev] [PATCH v2] test/eventdev: update the port id to 16 bit

port id in test case is update to unsigned int 16 bit, to prevent compilation failure when RTE_MAX_ETHPORTS port is set more than 255. Signed-off-by: Vipin Varghese Acked-by: Nikhil Rao --- Changes for V2: spell check for commit message - Nikhil Rao --- test/test/test_event_eth_rx_adapter.c |

Re: [dpdk-dev] [PATCH v2] net/tap: add RSS hash update callback

> On May 10, 2018, at 12:30 PM, Ophir Munk wrote: > > Add RSS hash update callback to eth_dev_ops. > > Signed-off-by: Ophir Munk > --- > v1: > Initial release > v2: > typo fix > Acked by: Keith Wiles Regards, Keith

Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

On 15-May-18 12:36 PM, Andrew Rybchenko wrote: On 05/15/2018 01:44 PM, Anatoly Burakov wrote: The intention of the original code was to create runtime data directory as early as possible, however it was moved too early, before the arguments were parsed, resulting in --file-prefix option essentia

Re: [dpdk-dev] [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

On Tue, May 15, 2018 at 11:07:14AM +, Matan Azrad wrote: > Add support for MPLS over GRE and MPLS over UDP tunnel types as > described in the next RFCs: > 1. https://tools.ietf.org/html/rfc4023 > 2. https://tools.ietf.org/html/rfc7510 > 3. https://tools.ietf.org/html/rfc4385 > > Signed-off-by:

Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue

-Original Message- > Date: Tue, 15 May 2018 05:23:46 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue > X-Mailer: git-send-email 2.1.4 > > ~/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49: error: > 'rte_mem

Re: [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic lib

-Original Message- > Date: Tue, 15 May 2018 05:23:44 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic > lib > X-Mailer: git-send-email 2.1.4 > > For ARM64 platform, libdpdk.a includes the librte_pmd_octeontx_ssovf.a,

Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

On 05/15/2018 01:44 PM, Anatoly Burakov wrote: The intention of the original code was to create runtime data directory as early as possible, however it was moved too early, before the arguments were parsed, resulting in --file-prefix option essentially not working. Fix this by moving eal_create_

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fixed device info get issue

On 5/15/2018 9:41 AM, Andrew Rybchenko wrote: > On 05/15/2018 07:10 PM, Qiming Yang wrote: >> This patch fixed error function call order in rte_eth_dev_configure. >> This wrong order makes user can't get correct device informations, >> and cause DCB configure issue. >> >> Fixes: 3be82f5cc5e3 ("ethd

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

On Tue, May 15, 2018 at 08:58:06AM +0100, Burakov, Anatoly wrote: > On 14-May-18 7:48 PM, Thomas Monjalon wrote: > > 14/05/2018 18:06, Anatoly Burakov: > > > Currently, populate_virt will check if mempool is already populated. > > > This will cause inability to reserve multi-chunk mempools if > > >

[dpdk-dev] [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

Add support for MPLS over GRE and MPLS over UDP tunnel types as described in the next RFCs: 1. https://tools.ietf.org/html/rfc4023 2. https://tools.ietf.org/html/rfc7510 3. https://tools.ietf.org/html/rfc4385 Signed-off-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 4 +- drivers/net/mlx5/

Re: [dpdk-dev] [PATCH] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

Hi Nelio From: Nélio Laranjeiro > Hi Matan, > > I have a single comment, please see bellow, > > On Mon, May 14, 2018 at 01:41:20PM +, Matan Azrad wrote: > > Add support for MPLS over GRE and MPLS over UDP tunnel types as > > described in the next RFCs: > > 1. > > https://emea01.safelinks.pro

Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation

15/05/2018 12:41, Andy Green: > On 05/15/2018 06:31 PM, Jerin Jacob wrote: > >> [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion​ > > > > I am fine with taking any of the of the patch. Please improve the patch > > subject > > and bug description in case if you prefer to take yo

  1   2   >