Re: [dpdk-dev] [RFC] vhost: new rte_vhost API proposal

Hi, > -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Friday, May 11, 2018 12:37 AM > On Thu, May 10, 2018 at 03:22:53PM +0200, Dariusz Stojaczyk wrote: > > rte_virtio would offer both vhost and virtio driver APIs. These two > > have a lot of common code for

Re: [dpdk-dev] [PATCH v3] crypto/ccp: support command line option to enable CPU based auth

> >> -Original Message- >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> Sent: Thursday, May 10, 2018 10:20 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; >> tho...@monjalon.net; hemant.agra...@nxp.com >> Subject: [PATCH v3] crypto/ccp: support command line option to enable >> C

Re: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver

> -Original Message- > From: Xu, Rosen > Sent: Friday, May 11, 2018 11:17 AM > To: Zhang, Qi Z ; dev@dpdk.org; > tho...@monjalon.net > Cc: Zhang, Roy Fan ; Doherty, Declan > ; Richardson, Bruce > ; shreyansh.j...@nxp.com; Yigit, Ferruh > ; Ananyev, Konstantin > ; Zhang, Tianfei ; > Liu, S

[dpdk-dev] [PATCH v2] net/i40e: print original value for global register change

Currently, only new value is printed during global register change. Add original value to help debugging facility. Fixes: bc66b9717c50 ("net/i40e: add debug logs when writing global registers") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- v2 changes: - Add original value print in i40e_wri

[dpdk-dev] [PATCH] doc: update device options in multi process

Update information for blacklist and whitelist options for secondary process to share same from primary process. Signed-off-by: Vipin Varghese --- doc/guides/prog_guide/multi_proc_support.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/d

[dpdk-dev] [PATCH] net/i40e: print original value for global register change

Currently, only new value is printed during global register change. Add original value to help debugging facility. Fixes: bc66b9717c50 ("net/i40e: add debug logs when writing global registers") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 42 ++

Re: [dpdk-dev] [PATCH] net/mlx5: fix inlining segmented TSO packet

> On May 10, 2018, at 5:50 PM, Yongseok Koh wrote: > > When a multi-segmented packet is inlined, data can be further inlined even > after the first segment. In case of TSO packet, extra inline data after TSO > header should be carried by an inline DSEG which has 4B inline header > recording the

[dpdk-dev] [PATCH v4] net/virtio-user: fix multiple queues fail in server mode

This patch fixes multiple queues failure when virtio-user works in server mode. This patch adds feature negotiation in the processing of virtio-user connection and enables multiple-queue pairs. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: sta...@dpdk.org Cc: tiwei@intel.co

Re: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver

Hi Jingjing, After we have aligned this morning, I will reply your email again. > -Original Message- > From: Wu, Jingjing > Sent: Thursday, May 10, 2018 17:21 > To: Xu, Rosen ; dev@dpdk.org; tho...@monjalon.net > Cc: Xu, Rosen ; Zhang, Roy Fan > ; Doherty, Declan ; > Richardson, Bruce ; s

Re: [dpdk-dev] [PATCH v10 1/3] bus/ifpga: Add Intel FPGA BUS Library

Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Friday, May 11, 2018 6:40 > To: Xu, Rosen ; dev@dpdk.org; tho...@monjalon.net > Cc: Zhang, Roy Fan ; Doherty, Declan > ; Richardson, Bruce > ; shreyansh.j...@nxp.com; Yigit, Ferruh > ; Ananyev, Konstantin > ; Zhang, Tianfei ; >

Re: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver

Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, May 10, 2018 22:24 > To: Xu, Rosen ; dev@dpdk.org; tho...@monjalon.net > Cc: Xu, Rosen ; Zhang, Roy Fan > ; Doherty, Declan ; > Richardson, Bruce ; shreyansh.j...@nxp.com; > Yigit, Ferruh ; Ananyev, Konstantin > ; Zhang, Tia

Re: [dpdk-dev] [PATCH v2 00/24] Fixes for GCC8 against lagopus

On Fri, 11 May 2018 09:58:54 +0800 Andy Green wrote: > The following series fixes build problems in dpdk master > headers, found when using it as the dpdk subproject in > lagopus. These errors are coming when you try to use > the dpdk headers, not when you build dpdk itself. > > Two patches are

Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix multiple queues fail in server mode

> -Original Message- > From: Bie, Tiwei > Sent: Friday, May 11, 2018 10:50 AM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Yigit, Ferruh ; > maxime.coque...@redhat.com; sta...@dpdk.org > Subject: Re: [PATCH v3] net/virtio-user: fix multiple queues fail in server > mode > > On Fri, May 11, 20

Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix multiple queues fail in server mode

On Fri, May 11, 2018 at 10:12:47AM +0800, zhiyong.y...@intel.com wrote: [...] > @@ -447,11 +447,17 @@ virtio_user_handle_mq(struct virtio_user_dev *dev, > uint16_t q_pairs) > return -1; > } > > - for (i = 0; i < q_pairs; ++i) > - ret |= dev->ops->enable_qp(dev

[dpdk-dev] [pull-request] next-net 18.05 RC3

The following changes since commit e0d88a394e91f446234aa04d0f9e01c150b0d347: crypto/ccp: support run-time CPU based auth (2018-05-10 17:46:20 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 023214134055d2f0ef5bc73ef2267d9

[dpdk-dev] [PATCH v3] net/virtio-user: fix multiple queues fail in server mode

This patch fixes multiple queues failure when virtio-user works in server mode. This patch adds feature negotiation in the processing of virtio-user connection and enables multiple-queue pairs. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: sta...@dpdk.org Signed-off-by: Zhiyon

[dpdk-dev] [PATCH v2 24/24] test_table_pipeline: repair munged indirection level

Signed-off-by: Andy Green --- test/test/test_table_pipeline.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c index 055a1a4e7..d007d55ce 100644 --- a/test/test/test_table_pipeline.c +++ b/test/test/test_t

[dpdk-dev] [PATCH v2 23/24] rte_hash_crc.h: explicit casts for truncation

/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h: In function 'crc32c_sse42_u64_mimic': /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:402:40: warning: conversion from 'uint64_t' {aka 'long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion] init_val

[dpdk-dev] [PATCH v2 20/24] rte_ethdev.h: align sign and scope of temp var

Signed-off-by: Andy Green --- lib/librte_ethdev/rte_ethdev.h | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7ccf4bae6..2487e1d2d 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++

[dpdk-dev] [PATCH v2 16/24] rte_mbuf.h: explicit casts to uint16 to avoid warnings

Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 169f3d3b0..3cd76abbc 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.

[dpdk-dev] [PATCH v2 21/24] rte_ethdev.h: explicit cast for truncation

/projects/lagopus/src/dpdk/build/include/rte_ethdev.h: In function 'rte_eth_tx_buffer_flush': /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:4248:55: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] buffer->error_callback(&buffer->pkt

[dpdk-dev] [PATCH v2 18/24] rte_ether.h: explicit cast avoiding truncation warning

/projects/lagopus/src/dpdk/build/include/rte_ether.h:213:13: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion] addr[0] &= ~ETHER_GROUP_ADDR; /* clear multicast bit */ Signed-off-by: Andy Green --- lib/librte_net/rte_ether.h |2 +- 1 file chan

[dpdk-dev] [PATCH v2 19/24] rte_ether.h: stack vars declared at top of function

/projects/lagopus/src/dpdk/build/include/rte_ether.h: In function 'rte_vlan_strip': /projects/lagopus/src/dpdk/build/include/rte_ether.h:357:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] struct vlan_hdr *vh = (struct vlan_hdr *)(eh + 1); Signed-off-by: A

[dpdk-dev] [PATCH v2 22/24] rte_hash_crc.h: stack vars declared at top of function

/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h: In function 'crc32c_2words': /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:347:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] uint32_t crc, term1, term2; Signed-off-by: Andy Green --- li

[dpdk-dev] [PATCH v2 17/24] rte_byteorder.h: explicit cast for return promotion

Signed-off-by: Andy Green --- .../common/include/generic/rte_byteorder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/generic/rte_byteorder.h b/lib/librte_eal/common/include/generic/rte_byteorder.h index 9bed85cca..8ffbac394 100644

[dpdk-dev] [PATCH v2 11/24] rte_mbuf.h: avoid warnings from inadvertant promotion

Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 4fd9a0d9e..a2a37a311 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@

[dpdk-dev] [PATCH v2 10/24] rte_dev.h: stack declaration at top of own basic block

/projects/lagopus/src/dpdk/build/include/rte_dev.h:54:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; Signed-off-by: Andy Green --- lib/librte_eal/common/include/rte_dev.h | 15 +-- 1 file chang

[dpdk-dev] [PATCH v2 13/24] rte_mbuf.h: make sure RTE-MIN compares same types

/projects/lagopus/src/dpdk/build/include/rte_common.h:384:2: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] __extension__ ({ \ ^ /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1204:16: note: in expansion of macro 'RTE_MIN

[dpdk-dev] [PATCH v2 15/24] rte_mbuf.h: explicit cast for size type to uint32

Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 0580ec8a0..169f3d3b0 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1577,7 +1

[dpdk-dev] [PATCH v2 12/24] rte_mbuf.h: explicit casts for int16 to uint16

differences to the atomic16 are signed, but the atomic16 itself is unsigned. It needs to be made explicit with casts. Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/libr

[dpdk-dev] [PATCH v2 14/24] rte_mbuf.h: explicit cast restricting ptrdiff to uint16

/projects/lagopus/src/dpdk/build/include/rte_common.h:141:34: warning: conversion from 'long unsigned int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] #define RTE_PTR_DIFF(ptr1, ptr2) ((uintptr_t)(ptr1) - (uintptr_t)(ptr2)) ^ /projects

[dpdk-dev] [PATCH v2 07/24] rte_spinlock.h: stack declarations before code

/projects/lagopus/src/dpdk/build/include/rte_spinlock.h: In function 'rte_try_tm': /projects/lagopus/src/dpdk/build/include/rte_spinlock.h:82:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] int retries = RTE_RTM_MAX_RETRIES; Signed-off-by: Andy Green ---

[dpdk-dev] [PATCH v2 09/24] rte_ring.h: remove signed type flipflopping

/projects/lagopus/src/dpdk/build/include/rte_ring.h:350:46: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] update_tail(&r->prod, prod_head, prod_next, is_sp, 1); The visible apis take unsigned int, then call a private api t

[dpdk-dev] [PATCH v2 06/24] /lib/librte_eal: stage cast from uint64 to long

/projects/lagopus/src/dpdk/build/include/rte_random.h: In function 'rte_srand': /projects/lagopus/src/dpdk/build/include/rte_random.h:34:10: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion] srand48((long unsigned int)seedval); /proj

[dpdk-dev] [PATCH v2 08/24] rte_ring_generic.h: stack declarations before code

/projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: In function '__rte_ring_move_prod_head': /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] const uint32_t cons_tail = r->cons.tail;

[dpdk-dev] [PATCH v2 05/24] lib/librte_eal: explicit cast for signed change

/projects/lagopus/src/dpdk/build/include/rte_lcore.h: In function 'rte_lcore_index': /projects/lagopus/src/dpdk/build/include/rte_lcore.h:122:14: warning: conversion to 'int' from 'unsigned int' may change the sign of the result [-Wsign-conversion] lcore_id = rte_lcore_id(); Signed-off-by: Andy

[dpdk-dev] [PATCH v2 03/24] rte_common.h: cast gcc builtin result to avoid complaints

/projects/lagopus/src/dpdk/build/include/rte_common.h:416:9: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] return __builtin_ctz(v); ^~~~ The builtin is defined to return int, but we want to return it a

[dpdk-dev] [PATCH v2 00/24] Fixes for GCC8 against lagopus

The following series fixes build problems in dpdk master headers, found when using it as the dpdk subproject in lagopus. These errors are coming when you try to use the dpdk headers, not when you build dpdk itself. Two patches are updated to follow requests for larger work. --- Andy Green (24):

[dpdk-dev] [PATCH v2 04/24] lib/librte_eal: explicit tmp cast

Signed-off-by: Andy Green --- .../common/include/arch/x86/rte_memcpy.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h index 5ead68ab2..f9ea0ab69 100

[dpdk-dev] [PATCH v2 01/24] lib/librte_eal: import libbsd strlcpy

Signed-off-by: Andy Green --- lib/librte_eal/common/eal_common_string_fns.c | 34 lib/librte_eal/common/include/rte_string_fns.h |7 + 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_string_fns.c b/lib/librte_ea

[dpdk-dev] [PATCH v2 02/24] lib/librte_ethdev: change eth-dev-ops API to return int

Signed-off-by: Andy Green --- drivers/net/ark/ark_ethdev_rx.c |4 ++-- drivers/net/ark/ark_ethdev_rx.h |3 +-- drivers/net/avf/avf_rxtx.c |4 ++-- drivers/net/avf/avf_rxtx.h |2 +- drivers/net/bnxt/bnxt_ethdev.c |5 +++-- drivers/net/dpaa/dpaa_et

Re: [dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability

On 5/11/2018 2:35 AM, Zhang, Qi Z wrote: > Hi Yanglong > The patch is OK, could you rebase to dpdk-next-net ? > Thanks > Qi > >> -Original Message- >> From: Wu, Yanglong >> Sent: Thursday, May 10, 2018 2:51 PM >> To: dev@dpdk.org >> Cc: Zhang, Qi Z ; Dai, Wei ; Wu, >> Yanglong >> S

[dpdk-dev] [PATCH 4/4] net/bnx2x: solve overruns

--- drivers/net/bnx2x/bnx2x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index bfd9cce51..3892934cc 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -170,10 +170,10 @@ bnx2x_dma_alloc(st

[dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized

--- drivers/net/mlx5/mlx5.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 8f983061a..4d379fb13 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -624,7 +624,7 @@ mlx5_pci_probe(struct rte_pci_driv

[dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison

/home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: In function ‘elink_check_kr2_wa’: /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] ((next_page & 0xe0) == 0x2; --- drivers/net/bnx2x/el

[dpdk-dev] [PATCH 0/4] GCC8 fixes for MLX4/5/BNX2X PMD

The following series fixes build breakage if you additionally enable CONFIG_RTE_LIBRTE_MLX4_PMD CONFIG_RTE_LIBRTE_MLX5_PMD CONFIG_RTE_LIBRTE_BNX2X_PMD --- Andy Green (4): net/bnx2x: do not cast function pointers as a policy net/bnx2x: remove unmeetable comparison net/mlx5: solv

[dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

This is stopping the compiler telling you when you have done something stupid... that is something none of us can afford... Now gcc 8.x can tell you did something stupid despite trying to hide the evidence. Remove all the "black magic" casts. Fix the actual problems. --- drivers/net/bnx2x/elink

[dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated string

Signed-off-by: Andy Green --- app/test-bbdev/test_bbdev_vector.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index c574f2135..4a3ddcffe 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/t

[dpdk-dev] [PATCH v4 17/18] app/test-bbdev: strcpy ok for allocated string

Signed-off-by: Andy Green --- app/test-bbdev/test_bbdev_vector.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index a37e35f4d..c574f2135 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/tes

[dpdk-dev] [PATCH v4 16/18] app/proc-info: sprintf overrun bug

/home/agreen/projects/dpdk/app/proc-info/main.c: In function ‘nic_xstats_display’: /home/agreen/projects/dpdk/app/proc-info/main.c:495:45: error: ‘%s’ directive writing up to 255 bytes into a region of size between 165 and 232 [-Werror=format-overflow=] sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/

[dpdk-dev] [PATCH v4 15/18] app: can't find include

/home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10: fatal error: rte_pmd_dpaa.h: No such file or directory #include ^~~~ Signed-off-by: Andy Green --- app/test-pmd/Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Ma

[dpdk-dev] [PATCH v4 14/18] net/vdev_netvsc: 3 x strncpy misuse

Signed-off-by: Andy Green --- drivers/net/vdev_netvsc/vdev_netvsc.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index dca25761d..f1d036152 100644 --- a/drivers/net/vdev_netvsc/vdev_net

[dpdk-dev] [PATCH v4 13/18] net/vdev_netvsc: readlink inputs cannot be aliased

/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/ vdev_netvsc.c:335:2:error: passing argument 2 to restrict- qualified parameter aliases with argument 1 [-Werror=restrict] ret = readlink(buf, buf, size); ^~~ Signed-off-by: Andy Green --- drivers/net/vdev_netvsc/vdev_netvsc.c |8 +--

[dpdk-dev] [PATCH v4 12/18] net/sfc: solve strncpy size and NUL

Signed-off-by: Andy Green --- drivers/net/sfc/sfc_ethdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index ef5e9ecb2..a8c0f8e19 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@

[dpdk-dev] [PATCH v4 09/18] net/qede: strncpy length constant and NUL

Signed-off-by: Andy Green --- drivers/net/qede/base/ecore_int.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c index f43781ba4..d9e22b5ed 100644 --- a/drivers/net/qede/base/ecore_int.c +++ b/dri

[dpdk-dev] [PATCH v4 10/18] net/qede: solve broken strncpy

/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function ‘qed_slowpath_start’: /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strncpy’ output may be truncated copying 12 bytes from a string of length 127 [-Werror=stringop-truncation] strncpy((char *)drv_versio

[dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length

Signed-off-by: Andy Green --- drivers/net/sfc/sfc_ethdev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index e42d55350..ef5e9ecb2 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c

[dpdk-dev] [PATCH v4 08/18] net/nfp: don't memcpy out of source range

/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2: error: ‘memcpy’ forming offset [5, 6] is out of the bounds [0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0], &tmp, sizeof(struct ether_addr)); Signed-off-by: Andy Green Acke

[dpdk-dev] [PATCH v4 07/18] net/nfp/nfpcore: off-by-one and no NUL on strncpy use

/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c: 76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from a string of length 8 [-Werror=stringop-truncation] strncpy(name_pad, res->name, sizeof(name_pad)); Signed-off-by: Andy Green --- drivers/net/nfp/nfpcore/nfp_res

[dpdk-dev] [PATCH v4 03/18] bus/pci: replace strncpy dangerous code

In function ‘pci_get_kernel_driver_by_path’, inlined from ‘pci_scan_one.isra.1’ at /home/agreen/projects/dpdk/ drivers/bus/pci/linux/pci.c:317:8: /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error: ‘strncpy’ specified bound depends on the length of the source argument [-

[dpdk-dev] [PATCH v4 06/18] net/nfp/nfpcore: solve strncpy misuse

Signed-off-by: Andy Green Acked-by: Alejandro Lucero Tested-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c inde

[dpdk-dev] [PATCH v4 05/18] net/axgbe: solve broken eeprom string comp

/home/agreen/projects/dpdk/drivers/net/axgbe/axgbe_phy_impl.c:576:6: error: ‘__builtin_memcmp_eq’ reading 16 bytes from a region of size 9 [-Werror=stringop-overflow=] if (memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_NAME], ^ AXGBE

[dpdk-dev] [PATCH v4 04/18] bus/dpaa: solve inconsistent struct alignment

The actual descriptor for qm_mr_entry is 64-byte aligned. But the original code plays a trick, and puts a u8 common to the three descriptor subtypes in the union afterwards outside their structure definitions. Unfortunately since they compose a struct qm_fd with alignment 8, this trick destroys t

[dpdk-dev] [PATCH v4 02/18] net/nfp: solve buffer overflow

/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function ‘nfp_pf_pci_probe’: /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160: 23: error: ‘%s’ directive writing up to 99 bytes into a region of size 76 [-Werror=format-overflow=] sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, ser

[dpdk-dev] [PATCH v4 00/18] Fix default build on gcc8.0.1

This series allows dpdk master to build on Fedora 28, with the x86_64 default config. --- Andy Green (18): devtools/check-git: provide more generic grep pattern net/nfp: solve buffer overflow bus/pci: replace strncpy dangerous code bus/dpaa: solve inconsistent struct align

[dpdk-dev] [PATCH v4 01/18] devtools/check-git: provide more generic grep pattern

On Fedora 28, every patch is faulted for "Wrong headline uppercase", because [A-Z] is not always case sensitive. Change to use [[:upper:]] --- devtools/check-git-log.sh |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh

Re: [dpdk-dev] [PATCH v2] net/i40e: fix missing mbuf fast free offload

On 5/11/2018 2:25 AM, Qi Zhang wrote: > Expose the missing mbuf fast free capability since i40 does > support it. > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > > Signed-off-by: Qi Zhang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs

On 05/11/2018 08:29 AM, Andy Green wrote: On 05/10/2018 11:01 PM, Stephen Hemminger wrote: On Thu, 10 May 2018 20:13:31 +0800 Andy Green wrote: I appreciate the reply. But why bother having a subject line at all if it is going to be mechanically enforced that nothing in it is allowed to

Re: [dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability

Hi Yanglong The patch is OK, could you rebase to dpdk-next-net ? Thanks Qi > -Original Message- > From: Wu, Yanglong > Sent: Thursday, May 10, 2018 2:51 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Wu, > Yanglong > Subject: [PATCH v2] net/i40e: fix missing VLAN offload ca

[dpdk-dev] [PATCH v2] net/i40e: fix missing mbuf fast free offload

Expose the missing mbuf fast free capability since i40 does support it. Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Qi Zhang --- v2: - fix tx function selection. drivers/net/i40e/i40e_ethdev.c | 5 +++-- drivers/net/i40e/i40e_rxtx.c | 8 +--- 2 files

Re: [dpdk-dev] [PATCH v3 00/11] ethdev: fix race conditions in iterator and notifications

On 5/11/2018 12:58 AM, Thomas Monjalon wrote: > We have discovered some race conditions when using the port iterator > and/or the notifications recently added. > The work was done mostly with failsafe but some bugs could > be reproduced with other drivers. > These 11 patches are fixing all these is

[dpdk-dev] [PATCH] net/mlx5: fix inlining segmented TSO packet

When a multi-segmented packet is inlined, data can be further inlined even after the first segment. In case of TSO packet, extra inline data after TSO header should be carried by an inline DSEG which has 4B inline header recording the length of the inline data. If more than one segment is inlined,

Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload

> -Original Message- > From: Yigit, Ferruh > Sent: Friday, May 11, 2018 6:10 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload > > On 5/8/2018 5:50 PM, Ferruh Yigit wrote: > > On 5/7/2018 6:08 AM, Xing,

Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs

On 05/10/2018 11:01 PM, Stephen Hemminger wrote: On Thu, 10 May 2018 20:13:31 +0800 Andy Green wrote: I appreciate the reply. But why bother having a subject line at all if it is going to be mechanically enforced that nothing in it is allowed to be "useful"? That really doesn't make sense d

Re: [dpdk-dev] [PATCH v3 40/40] rte_string_fns.h: explicit cast for int return to size_t

On 05/11/2018 03:17 AM, Stephen Hemminger wrote: On Thu, 10 May 2018 10:49:40 +0800 Andy Green wrote: Signed-off-by: Andy Green --- lib/librte_eal/common/include/rte_string_fns.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_stri

Re: [dpdk-dev] [PATCH v8] app/testpmd: add commands to test new offload API

On 5/11/2018 1:00 AM, Ferruh Yigit wrote: > On 5/9/2018 1:13 PM, Wei Dai wrote: >> Add following testpmd run-time commands to support test of >> new Rx offload API: >> show port rx_offload capabilities >> show port rx_offload configuration >> port config rx_offload on|off >> port rxq rx_offlo

[dpdk-dev] [PATCH v3 11/11] ethdev: fix port removal notification timing

From: Matan Azrad When an ethdev port is released, a destroy event is triggered to notify the users about the released port. A bit before the destroy event is triggered, the port becomes invalid by changing its state to UNUSED and cleaning its data. Therefore, the port is invalid for the destroy

[dpdk-dev] [PATCH v3 10/11] net/failsafe: fix sub-device ownership race

From: Matan Azrad There is time between the sub-device port probing by the sub-device PMD to the sub-device port ownership taking by a fail-safe port. In this time, the port is available for the application usage. For example, the port will be exposed to the applications which use RTE_ETH_FOREAC

Re: [dpdk-dev] [PATCH v8] app/testpmd: add commands to test new offload API

On 5/9/2018 1:13 PM, Wei Dai wrote: > Add following testpmd run-time commands to support test of > new Rx offload API: > show port rx_offload capabilities > show port rx_offload configuration > port config rx_offload on|off > port rxq rx_offload on|off > Above last 2 commands should be run w

[dpdk-dev] [PATCH v3 07/11] ethdev: add lock to port allocation check

From: Matan Azrad When comparing the port name, there can be a race condition with a thread allocating a new port and writing the name at the same time. It can lead to match with a partial name by error. The check of the port is now considered as a critical section protected with locks. This fi

[dpdk-dev] [PATCH v3 08/11] ethdev: fix port visibility before initialization

The port was set to the state ATTACHED during allocation. The consequence was to iterate over ports which are not initialized. The state ATTACHED is now set as the last step of probing. The uniqueness of port name is now checked before the availability of a port id for allocation (order reversed)

[dpdk-dev] [PATCH v3 09/11] ethdev: fix port probing notification

The new device was notified as soon as it was allocated. It leads to use a device which is not yet initialized. The notification must be published after the initialization is done by the PMD, but before the state is changed, in order to let notified entities taking ownership before general availab

[dpdk-dev] [PATCH v3 06/11] ethdev: allow ownership operations on unused port

From: Matan Azrad When the state will be updated later than in allocation, we may need to update the ownership of a port which is still in state unused. It will be used to take ownership of a port before it is declared as available for other entities. Cc: sta...@dpdk.org Signed-off-by: Matan A

[dpdk-dev] [PATCH v3 05/11] ethdev: add probing finish function

A new hook function is added and called inside the PMDs at the end of the device probing: - in primary process, after allocating, init and config - in secondary process, after attaching and local init This new function is almost empty for now. It will be used later to add some post

[dpdk-dev] [PATCH v3 04/11] drivers/net: use higher level of probing helper for PCI

The drivers avp, bnx2x and liquidio were using the helper function rte_eth_dev_pci_allocate() and can be replaced by rte_eth_dev_pci_generic_probe() which calls the former. Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Reviewed-by: Ferr

[dpdk-dev] [PATCH v3 03/11] ethdev: add doxygen comments for each state

The enum rte_eth_dev_state was not properly documented. Its values did not appear in the doxygen output, and may be misunderstood. The state RTE_ETH_DEV_DEFERRED has no interest anymore since the ownership mechanism brings a more flexible categorization. This state could be removed later. Fixes:

[dpdk-dev] [PATCH v3 02/11] net/failsafe: fix sub-device visibility

The iterator function rte_eth_find_next_owned_by(), used by the iterator macro RTE_ETH_FOREACH_DEV_OWNED_BY, are ignoring the devices which are neither ATTACHED nor REMOVED. Thus sub-devices, having the state DEFERRED, cannot be seen with the ethdev iterator. The state RTE_ETH_DEV_DEFERRED can be r

[dpdk-dev] [PATCH v3 01/11] ethdev: fix debug log of owner id

The owner id is 64-bit. On 32-bit environment, it must be printed with PRIX64. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Stephen Hemminger --- lib/librte_ethdev/rt

[dpdk-dev] [PATCH v3 00/11] ethdev: fix race conditions in iterator and notifications

We have discovered some race conditions when using the port iterator and/or the notifications recently added. The work was done mostly with failsafe but some bugs could be reproduced with other drivers. These 11 patches are fixing all these issues. The PMDs are modified to call a new function after

Re: [dpdk-dev] [PATCH v3 36/40] rte_ethdev.h: explicit cast for return type

On 05/11/2018 03:18 AM, Stephen Hemminger wrote: On Thu, 10 May 2018 10:49:20 +0800 Andy Green wrote: /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:3860:10: warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'} may change the sign of the result [-Wsign-conversion] retu

Re: [dpdk-dev] [PATCH 07/11] ethdev: add lock to port allocation check

11/05/2018 00:13, Thomas Monjalon: > 10/05/2018 22:35, Stephen Hemminger: > > On Wed, 9 May 2018 14:21:17 +0200 > > Gaëtan Rivet wrote: > > > > > A suggestion about the naming here. > > > Reading subsequent patches, we can see this function being used during > > > ethdev allocation routines. The

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: print global register change info

On 5/10/2018 11:48 PM, Beilei Xing wrote: > Global register change info during enabling > flexible payload is not printed. > This patch changes macro to print the global > register change info. > > Fixes: d2f9fe8ae309 ("net/i40e: turn off flexible payload on driver init") > Cc: sta...@dpdk.org >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix inner TCP/UDP checksum offload control

On 5/10/2018 12:59 PM, Andrew Rybchenko wrote: > If application uses Tx offload API and sets ETH_TXQ_FLAGS_IGNORE flag, > it still should have inner TCP/UDP checksum offload enabled if it is > supported and TCP/UDP checksum offload is requested. > > Fixes: c78d280e88ef ("net/sfc: convert to new Tx

Re: [dpdk-dev] [PATCH] doc: add XXV710 support in i40e.rst

On 5/10/2018 12:10 PM, dev-boun...@dpdk.org wrote: > Signed-off-by: Qiming Yang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/enic: fix flow drop action

On 5/10/2018 9:51 AM, Hyong Youb Kim wrote: > Drop is a fate-deciding action, so mark it as FATE. It was missing in > a previous commit. > > Fixes: cc17feb90413 ("ethdev: alter behavior of flow API actions") > > Signed-off-by: Hyong Youb Kim Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3] doc: update release notes.

On 5/10/2018 7:55 AM, Qi Zhang wrote: > Add updates for runtime queue setup. > > Signed-off-by: Qi Zhang > --- > v3: > - fix typo. > > v2: > - fix typo. > > doc/guides/rel_notes/release_18_05.rst | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_not

Re: [dpdk-dev] [PATCH v10 1/3] bus/ifpga: Add Intel FPGA BUS Library

> -Original Message- > From: Xu, Rosen > Sent: Thursday, May 10, 2018 8:21 PM > To: Wu, Jingjing ; dev@dpdk.org; tho...@monjalon.net > Cc: Zhang, Roy Fan ; Doherty, Declan > ; Richardson, Bruce ; > shreyansh.j...@nxp.com; Yigit, Ferruh ; Ananyev, > Konstantin > ; Zhang, Tianfei ; > Liu,

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix link status update error

On 5/10/2018 3:36 AM, Zhang, Qi Z wrote: >> -Original Message- >> From: Xing, Beilei >> Sent: Thursday, May 10, 2018 10:26 AM >> To: Zhang, Roy Fan ; Zhang, Qi Z >> >> Cc: dev@dpdk.org; echau...@redhat.com; sta...@dpdk.org; Wiles, Keith >> >> Subject: [PATCH] net/i40e: fix link status upd

Re: [dpdk-dev] [PATCH 07/11] ethdev: add lock to port allocation check

On Fri, 11 May 2018 00:10:19 +0200 Thomas Monjalon wrote: > 10/05/2018 22:33, Stephen Hemminger: > > On Wed, 9 May 2018 11:43:33 +0200 > > Thomas Monjalon wrote: > > > > > > > > +struct rte_eth_dev * > > > +rte_eth_dev_allocated(const char *name) > > > +{ > > > + struct rte_eth_dev *ethdev

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix device configure with zero queue

On 5/10/2018 9:37 AM, Remy Horton wrote: > > On 10/05/2018 03:22, Qi Zhang wrote: > [..] >> Fixes: 3be82f5cc5e ("ethdev: support PMD-tuned Tx/Rx parameters") >> Signed-off-by: Qi Zhang Signed-off-by: Qi Zhang s/ntel/intel > > Acked-by: Remy Horton Applied to dpdk-next-net/master, thanks.

  1   2   3   >