[dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability

2018-05-09 Thread Yanglong Wu
VLAN offload capability should be exposed in VF since i40e does support it. Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") Signed-off-by: Yanglong Wu --- v2: rework as comments required --- drivers/net/i40e/i40e_ethdev_vf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

[dpdk-dev] [PATCH v3] doc: update release notes.

2018-05-09 Thread Qi Zhang
Add updates for runtime queue setup. Signed-off-by: Qi Zhang --- v3: - fix typo. v2: - fix typo. doc/guides/rel_notes/release_18_05.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst ind

Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs

2018-05-09 Thread Andy Green
On 05/10/2018 02:17 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 10 May 2018 10:46:18 +0800 From: Andy Green To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs User-Agent: StGit/unknown-version The following series gets current master abl

Re: [dpdk-dev] [PATCH v2] doc: update release notes.

2018-05-09 Thread Zhang, Qi Z
> -Original Message- > From: Tonghao Zhang [mailto:xiangxia.m@gmail.com] > Sent: Thursday, May 10, 2018 2:25 PM > To: Zhang, Qi Z > Cc: Mcnamara, John ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: update release notes. > > On Thu, May 10, 2018 at 12:22 PM, Qi Zhang wrote

Re: [dpdk-dev] [PATCH v2] doc: update release notes.

2018-05-09 Thread Tonghao Zhang
On Thu, May 10, 2018 at 12:22 PM, Qi Zhang wrote: > Add updates for runtime queue setup. > > Signed-off-by: Qi Zhang > --- > > v2: > - fix typo. > > doc/guides/rel_notes/release_18_05.rst | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/release_

Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Thu, 10 May 2018 10:46:18 +0800 > From: Andy Green > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs > User-Agent: StGit/unknown-version > > The following series gets current master able to build > itself, and allow lag

Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Thu, 10 May 2018 10:46:18 +0800 > From: Andy Green > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs > User-Agent: StGit/unknown-version > > The following series gets current master able to build > itself, and allow lag

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support

2018-05-09 Thread Yongseok Koh
> On May 9, 2018, at 8:00 PM, Yongseok Koh wrote: > > >> On May 9, 2018, at 4:12 PM, Ferruh Yigit wrote: >> >> On 5/9/2018 12:09 PM, Yongseok Koh wrote: >> <...> >> >>> +/** >>> + * Insert an entry to B-tree lookup table. >>> + * >>> + * @param bt >>> + * Pointer to B-tree structure. >>> +

[dpdk-dev] [PATCH] net/mlx: fix printing format specifiers

2018-05-09 Thread Yongseok Koh
This will have to be squashed to: net/mlx4: add new Memory Region support net/mlx5: add new Memory Region support Signed-off-by: Yongseok Koh --- This is not a formal patch to merge but Shahaf will squash it separately to mlx4 and mlx5 for dpdk-next-net. drivers/net/mlx4/mlx4_m

[dpdk-dev] [pull-request] [v2] next-eventdev 18.05 RC3

2018-05-09 Thread Jerin Jacob
The following changes since commit 0256386dc43ce0f27f4c9d6bfa58c534aaf997e2: mem: add argument to memory event callback (2018-05-08 22:28:58 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 640b0d1e510e111694c25145466

Re: [dpdk-dev] [PATCH v2] eventdev: make ethernet port identifiers 16 bit

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Thu, 10 May 2018 11:05:40 +0530 > From: Jerin Jacob > To: Nikhil Rao > CC: ferruh.yi...@intel.com, lei.a@intel.com, dev@dpdk.org, > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: make ethernet port identifiers > 16 bit > User-Agent: Mutt/1.

Re: [dpdk-dev] [PATCH v2] eventdev: make ethernet port identifiers 16 bit

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Thu, 10 May 2018 02:22:40 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: ferruh.yi...@intel.com, lei.a@intel.com, dev@dpdk.org, Nikhil Rao > , sta...@dpdk.org > Subject: [PATCH v2] eventdev: make ethernet port identifiers 16 bit > X-Mail

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: advertise supported RSS hash functions

2018-05-09 Thread Shahaf Shuler
Hi Ophir, Thursday, May 10, 2018 1:27 AM, Ophir Munk: > Subject: [PATCH v2 1/2] net/mlx4: advertise supported RSS hash functions > > Advertise mlx4 supported RSS functions as part of dev_infos_get callback. > Previous to this commit RSS support was reported as none. Since the > introduction of [

[dpdk-dev] [PATCH] eventdev: bump library version

2018-05-09 Thread Nikhil Rao
This commit bumps the library version to refect the ABI change caused by extending the ethernet port parameter in Rx adapter functions from 8 to 16 bits. Signed-off-by: Nikhil Rao -- The ABI change is caused by the following commit: http://dpdk.org/ml/archives/dev/2018-May/100979.html --- doc/

Re: [dpdk-dev] [PATCH] net/virtio-user: fix feature setting with vhost-net backend

2018-05-09 Thread Tiwei Bie
On Tue, May 08, 2018 at 03:44:22PM +0800, Jiayu Hu wrote: > Hi Tiwei, > > On Tue, May 08, 2018 at 10:49:50AM +0800, Tiwei Bie wrote: > > On Mon, May 07, 2018 at 02:50:06PM +0800, Jiayu Hu wrote: > > > Currently, when the backend is vhost-net, which implies > > > virtio-user works in client mode, v

[dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability

2018-05-09 Thread Yanglong Wu
VLAN offload capability should be exposed in VF since i40e does support it. Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") Signed-off-by: Yanglong Wu --- v2: rework as comments required --- drivers/net/i40e/i40e_ethdev_vf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiple queues fail in server mode

2018-05-09 Thread Tiwei Bie
On Thu, May 10, 2018 at 11:04:59AM +0800, Yang, Zhiyong wrote: > Hi Tiwei, > > > -Original Message- > > From: Bie, Tiwei > > Sent: Thursday, May 10, 2018 10:47 AM > > To: Yang, Zhiyong > > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Yao, Lei A > > ; sta...@dpdk.org > > Subject: Re: [dp

Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

2018-05-09 Thread Shahaf Shuler
Thursday, May 10, 2018 1:09 AM, Ferruh Yigit: > Subject: [PATCH] app/testpmd: check if CRC strip offload supported > > Testpmd set CRC_STRIP offload blindly, this is wrong according offload API > definition, and will cause error for the PMDs that doesn't support CRC_STRIP > like virtual PMDs. > >

Re: [dpdk-dev] [PATCH v2] eventdev: make ethernet port identifiers 16 bit

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Thu, 10 May 2018 02:22:40 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: ferruh.yi...@intel.com, lei.a@intel.com, dev@dpdk.org, Nikhil Rao > , sta...@dpdk.org > Subject: [PATCH v2] eventdev: make ethernet port identifiers 16 bit > X-Mail

[dpdk-dev] [PATCH v2] doc: update release notes.

2018-05-09 Thread Qi Zhang
Add updates for runtime queue setup. Signed-off-by: Qi Zhang --- v2: - fix typo. doc/guides/rel_notes/release_18_05.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 718734852..58

[dpdk-dev] [PATCH] doc: update release notes.

2018-05-09 Thread Qi Zhang
Add updates for runtime queue setup. Signed-off-by: Qi Zhang --- doc/guides/rel_notes/release_18_05.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 718734852..589649121 100644 ---

[dpdk-dev] [PATCH] net/e1000: add support of Tx multi_segs

2018-05-09 Thread Wei Dai
This feature has been confirmed with testpmd: testpmd> set fwd txonly testpmd> port stop all testpmd> port config all txd 1024 testpmd> set txsplit on testpmd> set txpkts 70,80,90,100 testpmd> start It can be observed at peer port that UDP packets with UDP data length 298 bytes. Signed-off-by: Wei

[dpdk-dev] [PATCH v2] eventdev: make ethernet port identifiers 16 bit

2018-05-09 Thread Nikhil Rao
Ethernet port ID data size has been extended to 16 bits size 17.11 Update the Rx event adapter interface and implementation accordingly. Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") Signed-off-by: Nikhil Rao Cc: sta...@dpdk.org -- Supersedes the following posts: http://dpd

[dpdk-dev] [PATCH] doc: add XXV710 support in i40e.rst

2018-05-09 Thread Qiming Yang
Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 212faf4..cc282be 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -5,7 +5,7 @@ I40E Poll Mod

Re: [dpdk-dev] [PATCH] eventdev: make ethernet port identifiers 16 bit

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Thu, 10 May 2018 00:47:32 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: ferruh.yi...@intel.com, lei.a@intel.com, dev@dpdk.org, Nikhil Rao > , sta...@dpdk.org > Subject: [PATCH] eventdev: make ethernet port identifiers 16 bit > X-Mailer:

Re: [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability

2018-05-09 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Thursday, May 10, 2018 10:45 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Wu, > Yanglong > Subject: [PATCH] net/i40e: fix missing VLAN offload capability > > VLAN offload capability should be exposed both VF and PF since i40e doe

Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiple queues fail in server mode

2018-05-09 Thread Yang, Zhiyong
Hi Tiwei, > -Original Message- > From: Bie, Tiwei > Sent: Thursday, May 10, 2018 10:47 AM > To: Yang, Zhiyong > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Yao, Lei A > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiple queues fail in > server mode > > O

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support

2018-05-09 Thread Yongseok Koh
> On May 9, 2018, at 4:12 PM, Ferruh Yigit wrote: > > On 5/9/2018 12:09 PM, Yongseok Koh wrote: >> This is the new design of Memory Region (MR) for mlx PMD, in order to: >> - Accommodate the new memory hotplug model. >> - Support non-contiguous Mempool. >> >> There are multiple layers for MR se

[dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability

2018-05-09 Thread Yanglong Wu
VLAN offload capability should be exposed both VF and PF since i40e does support it. Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v3 38/40] rte_hash_crc.h: stack vars declared at top of function

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h: In function 'crc32c_2words': /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:347:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] uint32_t crc, term1, term2; Signed-off-by: Andy Green --- li

[dpdk-dev] [PATCH v3 37/40] rte_ethdev.h: explicit cast for truncation

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h: In function 'rte_eth_tx_buffer_flush': /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:4248:55: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] buffer->error_callback(&buffer->pkt

[dpdk-dev] [PATCH v3 36/40] rte_ethdev.h: explicit cast for return type

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h:3860:10: warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'} may change the sign of the result [-Wsign-conversion] return (*dev->dev_ops->rx_queue_count)(dev, queue_id); Signed-off-by: Andy Green --- lib/librte_ethdev/rte_ethd

[dpdk-dev] [PATCH v3 40/40] rte_string_fns.h: explicit cast for int return to size_t

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_eal/common/include/rte_string_fns.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_string_fns.h b/lib/librte_eal/common/include/rte_string_fns.h index fcbb42e00..51413a55e 100644 --- a/lib/librte_e

[dpdk-dev] [PATCH v3 39/40] rte_hash_crc.h: explicit casts for truncation

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_hash_crc.h: In function 'crc32c_sse42_u64_mimic': /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:402:40: warning: conversion from 'uint64_t' {aka 'long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion] init_val

[dpdk-dev] [PATCH v3 35/40] rte_ethdev.h: fix sign and scope of temp var

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_ethdev/rte_ethdev.h | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7ccf4bae6..2487e1d2d 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++

[dpdk-dev] [PATCH v3 33/40] rte_ether.h: explicit cast avoiding truncation warning

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ether.h:213:13: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion] addr[0] &= ~ETHER_GROUP_ADDR; /* clear multicast bit */ Signed-off-by: Andy Green --- lib/librte_net/rte_ether.h |2 +- 1 file chan

[dpdk-dev] [PATCH v3 32/40] rte_byteorder.h: explicit cast for return promotion

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- .../common/include/generic/rte_byteorder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/generic/rte_byteorder.h b/lib/librte_eal/common/include/generic/rte_byteorder.h index 9bed85cca..8ffbac394 100644

[dpdk-dev] [PATCH v3 31/40] rte_mbuf.h: explicit casts to uint16_t to avoid truncation warnings

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 169f3d3b0..3cd76abbc 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.

[dpdk-dev] [PATCH v3 30/40] rte_mbuf.h: explicit cast for size_t to uint32_t

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 0580ec8a0..169f3d3b0 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1577,7 +1

[dpdk-dev] [PATCH v3 34/40] rte_ether.h: stack vars declared at top of function

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ether.h: In function 'rte_vlan_strip': /projects/lagopus/src/dpdk/build/include/rte_ether.h:357:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] struct vlan_hdr *vh = (struct vlan_hdr *)(eh + 1); Signed-off-by: A

[dpdk-dev] [PATCH v3 29/40] rte_mbuf.h: explicit cast restricting ptrdiff to uint16_t

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_common.h:141:34: warning: conversion from 'long unsigned int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] #define RTE_PTR_DIFF(ptr1, ptr2) ((uintptr_t)(ptr1) - (uintptr_t)(ptr2)) ^ /projects

[dpdk-dev] [PATCH v3 27/40] rte_mbuf.h: explicit casts for flipping between int16_t and uint16_t

2018-05-09 Thread Andy Green
differences to the atomic16 are signed, but the atomic16 itself is unsigned. It needs to be made explicit with casts. Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/libr

[dpdk-dev] [PATCH v3 28/40] rte_mbuf.h: make sure RTE_MIN compares same types

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_common.h:384:2: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] __extension__ ({ \ ^ /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1204:16: note: in expansion of macro 'RTE_MIN

[dpdk-dev] [PATCH v3 26/40] rte_mbuf.h: avoid truncation warnings from inadvertant int16_t to int promotion

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- lib/librte_mbuf/rte_mbuf.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 4fd9a0d9e..a2a37a311 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@

[dpdk-dev] [PATCH v3 25/40] rte_dev.h: stack declaration at top of own basic block

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_dev.h:54:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; Signed-off-by: Andy Green --- lib/librte_eal/common/include/rte_dev.h | 15 +-- 1 file chang

[dpdk-dev] [PATCH v3 22/40] rte_spinlock.h: stack declarations before code

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_spinlock.h: In function 'rte_try_tm': /projects/lagopus/src/dpdk/build/include/rte_spinlock.h:82:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] int retries = RTE_RTM_MAX_RETRIES; Signed-off-by: Andy Green ---

[dpdk-dev] [PATCH v3 23/40] rte_ring_generic.h: stack declarations before code

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: In function '__rte_ring_move_prod_head': /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] const uint32_t cons_tail = r->cons.tail;

[dpdk-dev] [PATCH v3 24/40] rte_ring.h: remove signed type flipflopping

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ring.h:350:46: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] update_tail(&r->prod, prod_head, prod_next, is_sp, 1); The visible apis take unsigned int, then call a private api t

[dpdk-dev] [PATCH v3 21/40] /lib/librte_eal/common/include/rte_random.h: stage cast from uint64_t to long

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_random.h: In function 'rte_srand': /projects/lagopus/src/dpdk/build/include/rte_random.h:34:10: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion] srand48((long unsigned int)seedval); /proj

[dpdk-dev] [PATCH v3 20/40] lib/librte_eal/common/include/rte_lcore.h: explicit cast for signed change

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_lcore.h: In function 'rte_lcore_index': /projects/lagopus/src/dpdk/build/include/rte_lcore.h:122:14: warning: conversion to 'int' from 'unsigned int' may change the sign of the result [-Wsign-conversion] lcore_id = rte_lcore_id(); Signed-off-by: Andy

[dpdk-dev] [PATCH v3 18/40] rte_common.h: cast gcc builtin result to avoid complaints

2018-05-09 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_common.h:416:9: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] return __builtin_ctz(v); ^~~~ The builtin is defined to return int, but we want to return it a

[dpdk-dev] [PATCH v3 19/40] rte_memcpy.h: explicit tmp cast

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- .../common/include/arch/x86/rte_memcpy.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h index 5ead68ab2..f9ea0ab69 100

[dpdk-dev] [PATCH v3 17/40] app/test-bbdev: strcpy ok for allocated string

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- app/test-bbdev/test_bbdev_vector.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index 5ad2a6535..373f94984 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/t

[dpdk-dev] [PATCH v3 14/40] app/test-pmd: can't find include

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10: fatal error: rte_pmd_dpaa.h: No such file or directory #include ^~~~ Signed-off-by: Andy Green --- app/test-pmd/Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Ma

[dpdk-dev] [PATCH v3 16/40] app/test-bbdev: test-bbdev: strcpy ok for allocated string

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- app/test-bbdev/test_bbdev_vector.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index addef0572..5ad2a6535 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/tes

[dpdk-dev] [PATCH v3 13/40] drivers/net/vdev: fix 3 x strncpy misuse

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/vdev_netvsc/vdev_netvsc.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index dca25761d..f1d036152 100644 --- a/drivers/net/vdev_netvsc/vdev_net

[dpdk-dev] [PATCH v3 15/40] app/proc-info: fix sprintf overrun bug

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/app/proc-info/main.c: In function ‘nic_xstats_display’: /home/agreen/projects/dpdk/app/proc-info/main.c:495:45: error: ‘%s’ directive writing up to 255 bytes into a region of size between 165 and 232 [-Werror=format-overflow=] sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/

[dpdk-dev] [PATCH v3 12/40] drivers/net/vdev: readlink inputs cannot be aliased

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/ vdev_netvsc.c:335:2:error: passing argument 2 to restrict- qualified parameter aliases with argument 1 [-Werror=restrict] ret = readlink(buf, buf, size); ^~~ Signed-off-by: Andy Green --- drivers/net/vdev_netvsc/vdev_netvsc.c |8 +--

[dpdk-dev] [PATCH v3 10/40] drivers/net/sfc: fix strncpy length

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/sfc/sfc_ethdev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index e42d55350..ef5e9ecb2 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c

[dpdk-dev] [PATCH v3 11/40] drivers/net/sfc: fix strncpy size and NUL

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/sfc/sfc_ethdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index ef5e9ecb2..a8c0f8e19 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@

[dpdk-dev] [PATCH v3 09/40] drivers/net/qede: fix broken strncpy

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function ‘qed_slowpath_start’: /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strncpy’ output may be truncated copying 12 bytes from a string of length 127 [-Werror=stringop-truncation] strncpy((char *)drv_versio

[dpdk-dev] [PATCH v3 08/40] drivers/net/qede: fix strncpy constant and NUL

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green --- drivers/net/qede/base/ecore_int.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c index f43781ba4..d9e22b5ed 100644 --- a/drivers/net/qede/base/ecore_int.c +++ b/dri

[dpdk-dev] [PATCH v3 07/40] drivers/net/nfp: fix buffer overflow in fw_name

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function ‘nfp_pf_pci_probe’: /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160: 23: error: ‘%s’ directive writing up to 99 bytes into a region of size 76 [-Werror=format-overflow=] sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, ser

[dpdk-dev] [PATCH v3 06/40] drivers/net/nfp: don't memcpy out of source range

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2: error: ‘memcpy’ forming offset [5, 6] is out of the bounds [0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0], &tmp, sizeof(struct ether_addr)); Signed-off-by: Andy Green Acke

[dpdk-dev] [PATCH v3 02/40] drivers/bus/dpaa: fix inconsistent struct alignment

2018-05-09 Thread Andy Green
The actual descriptor for qm_mr_entry is 64-byte aligned. But the original code plays a trick, and puts a u8 common to the three descriptor subtypes in the union afterwards outside their structure definitions. Unfortunately since they compose a struct qm_fd with alignment 8, this trick destroys t

[dpdk-dev] [PATCH v3 05/40] drivers/net/nfp/nfpcore: fix off-by-one and no NUL on strncpy use

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c: 76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from a string of length 8 [-Werror=stringop-truncation] strncpy(name_pad, res->name, sizeof(name_pad)); Signed-off-by: Andy Green --- drivers/net/nfp/nfpcore/nfp_res

[dpdk-dev] [PATCH v3 04/40] drivers/net/nfp/nfpcore: fix strncpy misuse

2018-05-09 Thread Andy Green
Signed-off-by: Andy Green Acked-by: Alejandro Lucero Tested-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c inde

[dpdk-dev] [PATCH v3 01/40] drivers/bus/pci: fix strncpy dangerous code

2018-05-09 Thread Andy Green
In function ‘pci_get_kernel_driver_by_path’, inlined from ‘pci_scan_one.isra.1’ at /home/agreen/projects/dpdk/ drivers/bus/pci/linux/pci.c:317:8: /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error: ‘strncpy’ specified bound depends on the length of the source argument [-

[dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs

2018-05-09 Thread Andy Green
The following series gets current master able to build itself, and allow lagopus to build against it, on Fedora 28 + x86_64 using gcc 8.0.1. The first 17 patches have already been through two spins and this time are corrected for all the comment (thanks to everybody who commented) since v2, and ha

[dpdk-dev] [PATCH v3 03/40] drivers/net/axgbe: fix broken eeprom string comp

2018-05-09 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/axgbe/axgbe_phy_impl.c:576:6: error: ‘__builtin_memcmp_eq’ reading 16 bytes from a region of size 9 [-Werror=stringop-overflow=] if (memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_NAME], ^ AXGBE

Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiple queues fail in server mode

2018-05-09 Thread Tiwei Bie
On Wed, May 09, 2018 at 05:49:36PM +0800, zhiyong.y...@intel.com wrote: > This patch fixes multiple queues failure when virtio-user works in > server mode. > > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") > Cc: sta...@dpdk.org > Signed-off-by: Zhiyong Yang > --- > drivers/net/vir

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-09 Thread Thomas Monjalon
Hi, I am checking if this patch comply with goals discussed in the survey: http://dpdk.org/ml/archives/dev/2018-March/094459.html - Allow "forgetting" port offloads in queue offloads setup. - An offload enabled at port level, cannot be disabled at queue level. - Every queue capabilities

Re: [dpdk-dev] [PATCH] net/i40e: fix link status update error

2018-05-09 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, May 10, 2018 10:26 AM > To: Zhang, Roy Fan ; Zhang, Qi Z > > Cc: dev@dpdk.org; echau...@redhat.com; sta...@dpdk.org; Wiles, Keith > > Subject: [PATCH] net/i40e: fix link status update error > > Link status is not updated correct

[dpdk-dev] [PATCH] eventdev: make ethernet port identifiers 16 bit

2018-05-09 Thread Nikhil Rao
Supersedes the following posts: http://dpdk.org/ml/archives/dev/2018-May/100917.html http://dpdk.org/ml/archives/dev/2018-May/100426.html Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") Signed-off-by: Nikhil Rao Cc: sta...@dpdk.org --- lib/librte_eventdev/rte_event_eth_rx_ada

[dpdk-dev] [PATCH] net/i40e: fix link status update error

2018-05-09 Thread Beilei Xing
Link status is not updated correctly, link speed is 0 when link is up and link speed is not 0 when link is down. This patch fixes the issue. Fixes: eef2daf2e199 ("net/i40e: fix link update no wait") Cc: echau...@redhat.com Cc: sta...@dpdk.org Signed-off-by: Keith Wiles Signed-off-by: Beilei Xing

[dpdk-dev] [PATCH v2] app/testpmd: fix device configure with zero queue

2018-05-09 Thread Qi Zhang
Setup number of Rx & Tx queues to 0 at rte_eth_dev_configure means take driver's default queue number, so if during a re-configureation previous queue number will be overwrite, this is not expected when we configure dcb. The patch fix it by re-confgure device with the original queue number. Fixes:

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix multiple queues fail in server mode

2018-05-09 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Thursday, May 10, 2018 9:29 AM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Yao, Lei A ; > sta...@dpdk.org; Bie, Tiwei > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH]

Re: [dpdk-dev] [PATCH 0/3] net/sfc: fix Rx/Tx offload checks

2018-05-09 Thread Ferruh Yigit
On 5/8/2018 4:04 PM, Andrew Rybchenko wrote: > The patch series applies net/sfc review notes in [1]. > Feel free to sqaush these fixes into [1] on apply. > > Fixes reference is incorrect (since [1] is not applied yet) and > provided just as a hint. > > [1] https://dpdk.org/ml/archives/dev/2018-Ma

Re: [dpdk-dev] [pull-request] next-pipeline 18.05 pre-rc3

2018-05-09 Thread Thomas Monjalon
08/05/2018 18:54, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-pipeline Pulled, thanks I have merged together 9 commits replacing strncpy by strlcpy.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix multiple queues fail in server mode

2018-05-09 Thread Yang, Zhiyong
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, May 9, 2018 10:49 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Yao, Lei A ; > sta...@dpdk.org; Bie, Tiwei > Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix multiple queues fail > in > server

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-09 Thread Ferruh Yigit
On 5/10/2018 1:56 AM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_c

[dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-09 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and [rt]x_conf->offloads to rte_e

[dpdk-dev] [PATCH v9] ethdev: new Rx/Tx offloads API

2018-05-09 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and [rt]x_conf->offloads to rte_e

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix multiple queues fail in server mode

2018-05-09 Thread Tiwei Bie
On Wed, May 09, 2018 at 03:48:58PM +0100, Ferruh Yigit wrote: > On 5/9/2018 10:49 AM, zhiyong.y...@intel.com wrote: > > This patch fixes multiple queues failure when virtio-user works in > > server mode. > > > > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") > > Cc: sta...@dpdk.org >

[dpdk-dev] [PATCH] eventdev: fix build related to port id storage size

2018-05-09 Thread Ferruh Yigit
When CONFIG_RTE_MAX_ETHPORTS more than 255 getting following build error with gcc, gcc (GCC) 7.3.1 .../lib/librte_eventdev/rte_event_eth_rx_adapter.c: In function ‘eth_poll_wrr_calc’: .../build/include/rte_ethdev.h:1328:23: error: comparison is always true due to limited range of data type

Re: [dpdk-dev] [pull-request] next-tm 18.05 pre-rc3

2018-05-09 Thread Thomas Monjalon
08/05/2018 19:12, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-qos Pulled with experimental function declaration fixed, and nits in commit logs. Thanks

Re: [dpdk-dev] [pull-request] next-eventdev 18.05 RC3

2018-05-09 Thread Thomas Monjalon
09/05/2018 12:58, Jerin Jacob: > The following changes since commit 0256386dc43ce0f27f4c9d6bfa58c534aaf997e2: > > mem: add argument to memory event callback (2018-05-08 22:28:58 +0200) > > are available in the Git repository at: > > http://dpdk.org/git/next/dpdk-next-eventdev There is a com

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support

2018-05-09 Thread Ferruh Yigit
On 5/9/2018 12:09 PM, Yongseok Koh wrote: > This is the new design of Memory Region (MR) for mlx PMD, in order to: > - Accommodate the new memory hotplug model. > - Support non-contiguous Mempool. > > There are multiple layers for MR search. > > L0 is to look up the last-hit entry which is pointe

Re: [dpdk-dev] [PATCH] ethdev: fix corrupted device info in configure

2018-05-09 Thread Ferruh Yigit
On 5/9/2018 11:50 PM, Thomas Monjalon wrote: > 10/05/2018 00:16, Ferruh Yigit: >> Calling dev_infos_get() devops directly in rte_eth_dev_configure cause >> random values in uninitialized fields because devops doesn't reset the >> dev_info structure. >> >> Call rte_eth_dev_info_get() API instead whi

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] net/failsafe: fix probe cleanup

2018-05-09 Thread Ferruh Yigit
On 5/9/2018 4:57 PM, Raslan Darawsheh wrote: > The hot-plug alarm mechanism is responsible to practically execute both > plug in and out operations. It periodically tries to detect missed > sub-devices to be reconfigured and clean the resources of the removed > sub-devices. > > The hot-plug alarm

Re: [dpdk-dev] [PATCH] ethdev: fix corrupted device info in configure

2018-05-09 Thread Thomas Monjalon
10/05/2018 00:16, Ferruh Yigit: > Calling dev_infos_get() devops directly in rte_eth_dev_configure cause > random values in uninitialized fields because devops doesn't reset the > dev_info structure. > > Call rte_eth_dev_info_get() API instead which memset the struct. > > Also remove duplicated d

Re: [dpdk-dev] [PATCH v6 08/10] compress/isal: add ISA-L compression functionality

2018-05-09 Thread Tucker, Greg B
> > Adds compression functionality, this sets internal ISA-L structures, provides > input & output mbuf addresses, executes compression, which ISA-L calls > deflate, > and finally error checks. > > Signed-off-by: Lee Daly Acked-by: Greg Tucker > --- > drivers/compress/isal/isal_compress_pmd.c

Re: [dpdk-dev] [PATCH v6 09/10] compress/isal: add ISA-L decomp functionality

2018-05-09 Thread Tucker, Greg B
> > Adds decompression functionality, similar to compression, this sets internal > ISA-L structures, provides input & output mbuf addresses, executes > decompression, which ISA-L calls inflate and finally error checks. > > Signed-off-by: Lee Daly Acked-by: Greg Tucker > --- > drivers/compress

Re: [dpdk-dev] [PATCH v2] net/failsafe: advertise supported RSS functions

2018-05-09 Thread Ferruh Yigit
On 5/9/2018 3:04 PM, Gaëtan Rivet wrote: > thanks Ophir, > > On Wed, May 09, 2018 at 01:46:41PM +, Ophir Munk wrote: >> Advertise failsafe supported RSS functions as part of dev_infos_get >> callback. Set failsafe default RSS hash functions to be: >> ETH_RSS_IP, ETH_RSS_UDP, and ETH_RSS_TCP. >

[dpdk-dev] [PATCH v2 08/11] ethdev: fix port visibility before initialization

2018-05-09 Thread Thomas Monjalon
The port was set to the state ATTACHED during allocation. The consequence was to iterate over ports which are not initialized. The state ATTACHED is now set as the last step of probing. The uniqueness of port name is now checked before the availability of a port id for allocation (order reversed)

[dpdk-dev] [PATCH v2 11/11] ethdev: fix port removal notification timing

2018-05-09 Thread Thomas Monjalon
From: Matan Azrad When an ethdev port is released, a destroy event is triggered to notify the users about the released port. A bit before the destroy event is triggered, the port becomes invalid by changing its state to UNUSED and cleaning its data. Therefore, the port is invalid for the destroy

[dpdk-dev] [PATCH v2 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Thomas Monjalon
From: Matan Azrad There is time between the sub-device port probing by the sub-device PMD to the sub-device port ownership taking by a fail-safe port. In this time, the port is available for the application usage. For example, the port will be exposed to the applications which use RTE_ETH_FOREAC

[dpdk-dev] [PATCH v2 09/11] ethdev: fix port probing notification

2018-05-09 Thread Thomas Monjalon
The new device was notified as soon as it was allocated. It leads to use a device which is not yet initialized. The notification must be published after the initialization is done by the PMD, but before the state is changed, in order to let notified entities taking ownership before general availab

[dpdk-dev] [PATCH v2 06/11] ethdev: allow ownership operations on unused port

2018-05-09 Thread Thomas Monjalon
From: Matan Azrad When the state will be updated later than in allocation, we may need to update the ownership of a port which is still in state unused. It will be used to take ownership of a port before it is declared as available for other entities. Cc: sta...@dpdk.org Signed-off-by: Matan A

[dpdk-dev] [PATCH v2 03/11] ethdev: add doxygen comments for each state

2018-05-09 Thread Thomas Monjalon
The enum rte_eth_dev_state was not properly documented. Its values did not appear in the doxygen output, and may be misunderstood. The state RTE_ETH_DEV_DEFERRED has no interest anymore since the ownership mechanism brings a more flexible categorization. This state could be removed later. Fixes:

  1   2   3   4   >